- tor-commits - lists.torproject.org

[tor/master] don't mark our descriptor dirty if our onion key hasn't changed
by nickm＠torproject.org 07 Jul '11

07 Jul '11

commit af0e8d834e4b1da029f7505745225f848e96def6 Author: Roger Dingledine <arma(a)torproject.org> Date: Sat May 21 19:23:27 2011 -0400 don't mark our descriptor dirty if our onion key hasn't changed --- changes/bug3263 | 4 ++++ src/or/router.c | 5 +++++ 2 files changed, 9 insertions(+), 0 deletions(-) diff --git a/changes/bug3263 b/changes/bug3263 new file mode 100644 index 0000000..43202c2 --- /dev/null +++ b/changes/bug3263 @@ -0,0 +1,4 @@ + o Minor bugfixes: + - Don't publish a new relay descriptor when we reload our onion key, + unless the onion key has actually changed. Fixes bug 3263 and + resolves another cause of bug 1810. Bugfix on 0.1.1.11-alpha. diff --git a/src/or/router.c b/src/or/router.c index 184715b..f6728aa 100644 --- a/src/or/router.c +++ b/src/or/router.c @@ -82,6 +82,11 @@ static authority_cert_t *legacy_key_certificate = NULL; static void set_onion_key(crypto_pk_env_t *k) { + if (onionkey && !crypto_pk_cmp_keys(onionkey, k)) { + /* k is already our onion key; free it and return */ + crypto_free_pk_env(k); + return; + } tor_mutex_acquire(key_lock); crypto_free_pk_env(onionkey); onionkey = k;

1 0

[tor/master] Have transitions in public_server_mode count as affects_descriptor
by nickm＠torproject.org 07 Jul '11

07 Jul '11

commit bc3c54a07f035c69b81cbf7817b8071938abf2ca Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Jul 7 11:05:06 2011 -0400 Have transitions in public_server_mode count as affects_descriptor Previously, we'd get a new descriptor for free when public_server_mode() changed, since it would count as affects_workers, which would call init_keys(), which would make us regenerate a new descriptor. But now that we fixed bug 3263, init_keys() is no longer necessarily a new descriptor, and so we need to make sure that public_server_mode() counts as a descriptor transition. --- src/or/config.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/or/config.c b/src/or/config.c index 36fb991..4bdb038 100644 --- a/src/or/config.c +++ b/src/or/config.c @@ -3847,7 +3847,8 @@ options_transition_affects_descriptor(or_options_t *old_options, !opt_streq(old_options->ContactInfo, new_options->ContactInfo) || !opt_streq(old_options->MyFamily, new_options->MyFamily) || !opt_streq(old_options->AccountingStart, new_options->AccountingStart) || - old_options->AccountingMax != new_options->AccountingMax) + old_options->AccountingMax != new_options->AccountingMax || + public_server_mode(old_options) != public_server_mode(new_options)) return 1; return 0;

1 0

[tor/master] Merge branch 'bug3263'
by nickm＠torproject.org 07 Jul '11

07 Jul '11

commit 6b670d6032b33f255f88e31a727b8f042b1dfcef Merge: 586d0ab bc3c54a Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Jul 7 11:08:03 2011 -0400 Merge branch 'bug3263' changes/bug3263 | 4 ++++ src/or/config.c | 3 ++- src/or/router.c | 5 +++++ 3 files changed, 11 insertions(+), 1 deletions(-)

1 0

[tor/master] oops; wrong bug number.
by nickm＠torproject.org 07 Jul '11

07 Jul '11

commit 586d0abe591e241124790b6ee0d273158e96bd0c Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Jul 7 11:01:41 2011 -0400 oops; wrong bug number. --- changes/bug3403 | 3 +++ changes/bug3404 | 3 --- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/changes/bug3403 b/changes/bug3403 new file mode 100644 index 0000000..7d051d9 --- /dev/null +++ b/changes/bug3403 @@ -0,0 +1,3 @@ + o Minor bugfixes: + - Fix a class of double-mark-for-close bugs when bufferevents + are enabled. Fixes bug 3403; bugfix on 0.2.3.1-alpha. diff --git a/changes/bug3404 b/changes/bug3404 deleted file mode 100644 index 4e2e21b..0000000 --- a/changes/bug3404 +++ /dev/null @@ -1,3 +0,0 @@ - o Minor bugfixes: - - Fix a class of double-mark-for-close bugs when bufferevents - are enabled. Fixes bug 3404; bugfix on 0.2.3.1-alpha.

1 0

[tor/master] Avoid double-free in bufferevent read/write cbs
by nickm＠torproject.org 07 Jul '11

07 Jul '11

commit 57822cbbbe85410785716fa62667b674b35602df Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Jul 7 11:00:21 2011 -0400 Avoid double-free in bufferevent read/write cbs Fixes bug 3404; bugfix on 0.2.3.1-alpha. --- changes/bug3404 | 3 +++ src/or/connection.c | 9 ++++++--- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/changes/bug3404 b/changes/bug3404 new file mode 100644 index 0000000..4e2e21b --- /dev/null +++ b/changes/bug3404 @@ -0,0 +1,3 @@ + o Minor bugfixes: + - Fix a class of double-mark-for-close bugs when bufferevents + are enabled. Fixes bug 3404; bugfix on 0.2.3.1-alpha. diff --git a/src/or/connection.c b/src/or/connection.c index e8969e0..c84ee04 100644 --- a/src/or/connection.c +++ b/src/or/connection.c @@ -2957,9 +2957,11 @@ connection_handle_read_cb(struct bufferevent *bufev, void *arg) { connection_t *conn = arg; (void) bufev; - if (!conn->marked_for_close) + if (!conn->marked_for_close) { if (connection_process_inbuf(conn, 1)<0) /* XXXX Always 1? */ - connection_mark_for_close(conn); + if (!conn->marked_for_close) + connection_mark_for_close(conn); + } } /** Callback: invoked whenever a bufferevent has written data. */ @@ -2969,7 +2971,8 @@ connection_handle_write_cb(struct bufferevent *bufev, void *arg) connection_t *conn = arg; struct evbuffer *output; if (connection_flushed_some(conn)<0) { - connection_mark_for_close(conn); + if (!conn->marked_for_close) + connection_mark_for_close(conn); return; }

1 0

[tor/master] Remove unused var in write_to_evbuffer_zlib
by nickm＠torproject.org 07 Jul '11

07 Jul '11

commit 31120ff692cba0c663a144ae9ece4b80ae8877a1 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Jul 7 11:00:51 2011 -0400 Remove unused var in write_to_evbuffer_zlib --- src/or/buffers.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/src/or/buffers.c b/src/or/buffers.c index 8f5fb1e..7312749 100644 --- a/src/or/buffers.c +++ b/src/or/buffers.c @@ -2240,7 +2240,6 @@ write_to_evbuffer_zlib(struct evbuffer *buf, tor_zlib_state_t *state, int over = 0, n; struct evbuffer_iovec vec[1]; do { - int need_new_chunk = 0; { size_t cap = data_len / 4; if (cap < 128) @@ -2269,7 +2268,6 @@ write_to_evbuffer_zlib(struct evbuffer *buf, tor_zlib_state_t *state, if (avail) { /* Zlib says we need more room (ZLIB_BUF_FULL). Start a new chunk * automatically, whether were going to or not. */ - need_new_chunk = 1; } break; }

1 0

[tor/master] Merge remote-tracking branch 'origin/maint-0.2.2'
by nickm＠torproject.org 07 Jul '11

07 Jul '11

commit f883ec09b5b2f48cd4186658e0b92f1511358f21 Merge: eee942c 3ab0976 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Jul 7 09:56:01 2011 -0400 Merge remote-tracking branch 'origin/maint-0.2.2' changes/bug3536 | 5 +++++ src/or/connection_edge.c | 3 ++- 2 files changed, 7 insertions(+), 1 deletions(-)

1 0

[tor/master] Correctly send a SUCCEEDED event for rdns requests
by nickm＠torproject.org 07 Jul '11

07 Jul '11

commit 3ab09763ced6d892cd72956e53f2dfb804ec0a7c Author: Sebastian Hahn <sebastian(a)torproject.org> Date: Thu Jul 7 05:27:20 2011 +0200 Correctly send a SUCCEEDED event for rdns requests The issue was that we overlooked the possibility of reverse DNS success at the end of connection_ap_handshake_socks_resolved(). Issue discovered by katmagic, thanks! --- changes/bug3536 | 5 +++++ src/or/connection_edge.c | 3 ++- 2 files changed, 7 insertions(+), 1 deletions(-) diff --git a/changes/bug3536 b/changes/bug3536 new file mode 100644 index 0000000..d3cec13 --- /dev/null +++ b/changes/bug3536 @@ -0,0 +1,5 @@ + o Minor bugfixes: + - Send a SUCCEEDED stream event to the controller when a reverse + resolve succeeded. Fixes bug 3536; bugfix on 0.0.8pre1. Issue + discovered by katmagic. + diff --git a/src/or/connection_edge.c b/src/or/connection_edge.c index 78b1b92..d4d7e1c 100644 --- a/src/or/connection_edge.c +++ b/src/or/connection_edge.c @@ -2611,7 +2611,8 @@ connection_ap_handshake_socks_resolved(edge_connection_t *conn, } connection_ap_handshake_socks_reply(conn, buf, replylen, (answer_type == RESOLVED_TYPE_IPV4 || - answer_type == RESOLVED_TYPE_IPV6) ? + answer_type == RESOLVED_TYPE_IPV6 || + answer_type == RESOLVED_TYPE_HOSTNAME) ? 0 : END_STREAM_REASON_RESOLVEFAILED); }

1 0

[tor/maint-0.2.2] Correctly send a SUCCEEDED event for rdns requests
by nickm＠torproject.org 07 Jul '11

07 Jul '11

commit 3ab09763ced6d892cd72956e53f2dfb804ec0a7c Author: Sebastian Hahn <sebastian(a)torproject.org> Date: Thu Jul 7 05:27:20 2011 +0200 Correctly send a SUCCEEDED event for rdns requests The issue was that we overlooked the possibility of reverse DNS success at the end of connection_ap_handshake_socks_resolved(). Issue discovered by katmagic, thanks! --- changes/bug3536 | 5 +++++ src/or/connection_edge.c | 3 ++- 2 files changed, 7 insertions(+), 1 deletions(-) diff --git a/changes/bug3536 b/changes/bug3536 new file mode 100644 index 0000000..d3cec13 --- /dev/null +++ b/changes/bug3536 @@ -0,0 +1,5 @@ + o Minor bugfixes: + - Send a SUCCEEDED stream event to the controller when a reverse + resolve succeeded. Fixes bug 3536; bugfix on 0.0.8pre1. Issue + discovered by katmagic. + diff --git a/src/or/connection_edge.c b/src/or/connection_edge.c index 78b1b92..d4d7e1c 100644 --- a/src/or/connection_edge.c +++ b/src/or/connection_edge.c @@ -2611,7 +2611,8 @@ connection_ap_handshake_socks_resolved(edge_connection_t *conn, } connection_ap_handshake_socks_reply(conn, buf, replylen, (answer_type == RESOLVED_TYPE_IPV4 || - answer_type == RESOLVED_TYPE_IPV6) ? + answer_type == RESOLVED_TYPE_IPV6 || + answer_type == RESOLVED_TYPE_HOSTNAME) ? 0 : END_STREAM_REASON_RESOLVEFAILED); }

1 0

r24869: {website} updated docs/de/sidenav.wmi from Sacro (website/trunk/docs/de)
by Runa Sandvik 07 Jul '11

07 Jul '11

Author: runa Date: 2011-07-07 13:34:09 +0000 (Thu, 07 Jul 2011) New Revision: 24869 Modified: website/trunk/docs/de/sidenav.wmi Log: updated docs/de/sidenav.wmi from Sacro Modified: website/trunk/docs/de/sidenav.wmi =================================================================== --- website/trunk/docs/de/sidenav.wmi 2011-07-07 11:43:12 UTC (rev 24868) +++ website/trunk/docs/de/sidenav.wmi 2011-07-07 13:34:09 UTC (rev 24869) @@ -30,6 +30,12 @@ {'url' => 'docs/tor-doc-unix', 'txt' => 'Installation auf Linux/BSD/Unix', }, + {'url' => 'docs/debian', + 'txt' => 'Installation von Tor auf Debian/Ubuntu', + }, + {'url' => 'docs/debian-vidalia', + 'txt' => 'Installation von Vidalia auf Debian/Ubuntu', + }, {'url' => 'docs/tor-doc-osx', 'txt' => 'Installation auf Mac OS X', }, @@ -96,3 +102,4 @@ ]; :> +

1 0