- tor-commits - lists.torproject.org

[arm/release] Merge remote-tracking branch 'origin'
by atagar＠torproject.org 17 Jul '11

17 Jul '11

commit 68518b5a9e4210393777678124a9a6f597409305 Merge: 3f3cc61 52c50c8 Author: Kamran Riaz Khan <krkhan(a)inspirated.com> Date: Sat Jul 16 01:06:24 2011 +0500 Merge remote-tracking branch 'origin' Conflicts: src/gui/arm.xml armrc.sample | 12 +- src/cli/configPanel.py | 6 + src/cli/connections/connEntry.py | 3 + src/cli/connections/connPanel.py | 8 +- src/cli/controller.py | 162 +++++++++++- src/cli/graphing/bandwidthStats.py | 10 +- src/cli/headerPanel.py | 22 ++- src/cli/logPanel.py | 110 +++++--- src/cli/menu/actions.py | 10 +- src/cli/wizard.py | 449 +++++++++++++++++++++++++++++- src/resources/exitNotice/exit-noice.html | 143 ---------- src/resources/exitNotice/index.html | 143 ++++++++++ src/resources/startTor | 28 ++ src/resources/torrcTemplate.txt | 90 ++++++ src/settings.cfg | 28 ++- src/starter.py | 36 ++- src/util/panel.py | 11 +- src/util/torConfig.py | 142 ++++++++++ src/util/torTools.py | 77 ++++-- 19 files changed, 1235 insertions(+), 255 deletions(-)

1 0

[arm/release] Minor fix for general panel stacktrace reported by atagar.
by atagar＠torproject.org 17 Jul '11

17 Jul '11

commit 4521f43d889240a24433d2b435689fcbea23769c Author: Kamran Riaz Khan <krkhan(a)inspirated.com> Date: Sat Jul 16 02:14:10 2011 +0500 Minor fix for general panel stacktrace reported by atagar. --- src/gui/generalPanel.py | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/gui/generalPanel.py b/src/gui/generalPanel.py index dee96be..1f72b49 100644 --- a/src/gui/generalPanel.py +++ b/src/gui/generalPanel.py @@ -21,6 +21,7 @@ class GeneralPanel(CliHeaderPanel): self.builder = builder self.filled = False + self._isTorConnected = torTools.getConn().isAlive() gobject.idle_add(self._fill_entries) gobject.timeout_add(3000, self._timeout_fill_entries) @@ -93,6 +94,7 @@ class GeneralPanel(CliHeaderPanel): if self.vals["stat/rss"] != "0": memoryLabel = uiTools.getSizeLabel(int(self.vals["stat/rss"])) else: memoryLabel = "0" + uptimeLabel = "N/A" if self.vals["tor/startTime"]: if self.isPaused() or not self._isTorConnected: uptimeLabel = uiTools.getShortTimeLabel(self.getPauseTime() - self.vals["tor/startTime"])

1 0

[arm/release] fix: couple issues spotted by pylint
by atagar＠torproject.org 17 Jul '11

17 Jul '11

commit 7bd1d2af1d27ce91f179b63a6fcf0f95090b19b8 Author: Damian Johnson <atagar(a)torproject.org> Date: Sat Jul 16 21:55:15 2011 -0700 fix: couple issues spotted by pylint --- src/util/__init__.py | 2 +- src/util/panel.py | 1 - src/util/torConfig.py | 2 +- 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/util/__init__.py b/src/util/__init__.py index 365e82a..cd5d721 100644 --- a/src/util/__init__.py +++ b/src/util/__init__.py @@ -4,5 +4,5 @@ application's status, making cross platform system calls, parsing tor data, and safely working with curses (hiding some of the gory details). """ -__all__ = ["conf", "connections", "enum", "hostnames", "log", "panel", "procTools", "procName", "sysTools", "torConfig", "torTools", "uiTools"] +__all__ = ["conf", "connections", "enum", "gtkTools", "hostnames", "log", "panel", "procTools", "procName", "sysTools", "torConfig", "torTools", "uiTools"] diff --git a/src/util/panel.py b/src/util/panel.py index 5a96623..bb47726 100644 --- a/src/util/panel.py +++ b/src/util/panel.py @@ -4,7 +4,6 @@ Wrapper for safely working with curses subwindows. import copy import time -import traceback import curses import curses.ascii import curses.textpad diff --git a/src/util/torConfig.py b/src/util/torConfig.py index 2eca571..e4570ca 100644 --- a/src/util/torConfig.py +++ b/src/util/torConfig.py @@ -146,7 +146,7 @@ def loadOptionDescriptions(loadPath = None, checkVersion = True): category = inputFileContents.pop(0).rstrip() if not category in Category.values(): baseMsg = "invalid category in input file: '%s'" - raise IOError(baseMsg % categoryStr) + raise IOError(baseMsg % category) # gets the position in the man page indexArg, indexStr = -1, inputFileContents.pop(0).rstrip()

1 0

[arm/release] fix: including gui resources with arm install
by atagar＠torproject.org 17 Jul '11

17 Jul '11

commit de8695a17bb96fd7a461c2b49fa5f064c004f9e2 Author: Damian Johnson <atagar(a)torproject.org> Date: Sat Jul 16 22:29:46 2011 -0700 fix: including gui resources with arm install --- install | 2 +- setup.py | 3 ++- src/gui/__init__.py | 2 +- src/gui/controller.py | 13 ++++++++++--- src/prereq.py | 6 ++++-- 5 files changed, 18 insertions(+), 8 deletions(-) diff --git a/install b/install index fead85c..605f724 100755 --- a/install +++ b/install @@ -1,5 +1,5 @@ #!/bin/sh -python src/prereq.py +python src/prereq.py --both if [ $? = 0 ]; then python setup.py -q install diff --git a/setup.py b/setup.py index 6e31f44..4513dee 100644 --- a/setup.py +++ b/setup.py @@ -93,7 +93,7 @@ if "install" in sys.argv: # When installing we include a bundled copy of TorCtl. However, when creating # a deb we have a dependency on the python-torctl package instead: # http://packages.debian.org/unstable/main/python-torctl -installPackages = ['arm', 'arm.cli', 'arm.cli.graphing', 'arm.cli.connections', 'arm.cli.menu', 'arm.util'] +installPackages = ['arm', 'arm.cli', 'arm.cli.graphing', 'arm.cli.connections', 'arm.cli.menu', 'arm.gui', 'arm.gui.connections', 'arm.gui.graphing', 'arm.util', 'arm.cagraph', 'arm.cagraph.axis', 'arm.cagraph.series'] if not isDebInstall: installPackages.append('arm.TorCtl') setup(name='arm', @@ -108,6 +108,7 @@ setup(name='arm', data_files=[("/usr/bin", ["arm"]), ("/usr/share/man/man1", [manFilename]), (docPath, ["armrc.sample"]), + ("/usr/share/arm/gui", ["src/gui/arm.xml"]), ("/usr/share/arm", ["src/settings.cfg", "src/uninstall"])] + getResources("/usr/share/arm", "resources"), ) diff --git a/src/gui/__init__.py b/src/gui/__init__.py index b700273..f274d81 100644 --- a/src/gui/__init__.py +++ b/src/gui/__init__.py @@ -2,5 +2,5 @@ Panels, popups, and handlers comprising the arm user interface. """ -__all__ = ["controller", "logPanel"] +__all__ = ["controller", "generalPanel", "logPanel"] diff --git a/src/gui/controller.py b/src/gui/controller.py index 5736def..4979ea1 100644 --- a/src/gui/controller.py +++ b/src/gui/controller.py @@ -13,10 +13,17 @@ gobject.threads_init() class GuiController: def __init__(self): - filename = 'src/gui/arm.xml' - self.builder = gtk.Builder() - self.builder.add_from_file(filename) + + try: + self.builder.add_from_file('src/gui/arm.xml') + except: + # when installed the above path doesn't work (the 'src' prefix doesn't + # exist and whichever path it's working off of doens't seem to exist), + # so using absolute path instead + + self.builder.add_from_file('/usr/share/arm/gui/arm.xml') + self.builder.connect_signals(self) self.logPanel = logPanel.LogPanel(self.builder) diff --git a/src/prereq.py b/src/prereq.py index eee9fdb..8641057 100644 --- a/src/prereq.py +++ b/src/prereq.py @@ -232,6 +232,8 @@ def guiPrereq(): if __name__ == '__main__': isGui = "-g" in sys.argv or "--gui" in sys.argv - if isGui: guiPrereq() - else: cliPrereq() + isBoth = "--both" in sys.argv + + if isGui or isBoth: guiPrereq() + if not isGui or isBoth: cliPrereq()

1 0

[arm/release] Changelog update for the 1.4.3 release
by atagar＠torproject.org 17 Jul '11

17 Jul '11

commit dc4ce6205b49593d2f6602cf776022485d10c19a Author: Damian Johnson <atagar(a)torproject.org> Date: Sat Jul 16 23:00:22 2011 -0700 Changelog update for the 1.4.3 release --- ChangeLog | 53 +++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 53 insertions(+), 0 deletions(-) diff --git a/ChangeLog b/ChangeLog index 5c9ecde..8b1b776 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,58 @@ CHANGE LOG +7/16/11 - version 1.4.3 +This completes the codebase refactoring project that's been a year in the works and provides numerous performance and usability improvements. Most notably this includes a setup wizard for new relays, menuing interface, gui prototype, substantial performance improvements, and support for Mac OSX. + + * added: relay setup wizard for autogenerating a torrc configuration + * added: menu interface with all of arm's functionality (thanks to help from krkhan) + * added: option for reconnecting to tor if it's been shut down and restarted + * added: fetching the download and upload bandwidth totals from Tor if it's available + * added: option for requesting a new identity + * added: file descriptor usage in the header panel when running low + * added: logging a notice when file descriptor usage is high + * added: making interface components optionally excludeable + * added: reintroduced the descriptor popup for the new connection panel + * added: moved arm's codebase to git, with helper scripts to replace svn:externals and export + * added: option for overriding all displayed color + * change: renaming our process from "python src/starter.py <args>" to "arm <args>" (thanks to help from ioerror) + * change: hiding connection init latency, dropping arm's startup time from 0.84 seconds to 0.14 (83% improvement) + * change: using blank space to display the nickname for circuit connections + * change: dropping the file descriptor popup (it was both unused and inaccurate) + * change: dropping deprecated connection panel from the codebase + * change: using SAVECONF rather than writing directly when able + * change: closing all message prompts when a key is pressed + * change: using a more intuitive mode toggling for resizing the graph + * change: added summaries for new tor config options + * fix: avoiding mass memory allocation in torctl, lowering arm's perceived base memory footprint by 2.5 MB (12%) (https://trac.torproject.org/projects/tor/ticket/3406) + * fix: fixing shutdown concurrency in torctl, lowering arm's shutdown time from a second to being almost instantaneous (https://trac.torproject.org/projects/tor/ticket/2412) + * fix: sighups that caused tor to crash would also crash torctl and arm (https://trac.torproject.org/projects/tor/ticket/1329) + * fix: crash when connecting to tor's socks port rather than control port (https://trac.torproject.org/projects/tor/ticket/2580) + * fix: shutting down torctl zombie connections to the control port (https://trac.torproject.org/projects/tor/ticket/2812) + * fix: moving connection component negotiation into torctl (https://trac.torproject.org/projects/tor/ticket/3409) + * fix: all pid resolution was failing on macs, causing much of arm's functionality to fail + * fix: dropping straight to lsof on macs to avoid fallback process, which was both lengthy and raised warnings + * fix: misparsing circuit paths for Tor < 0.2.2.1 (caught by asn) + * fix: pressing enter on an empty connection page caused crash (caught by asn, https://trac.torproject.org/projects/tor/ticket/3128) + * fix: edited config entries weren't displaying their new value + * fix: ns/desc lookup failures could crash descriptor popup (caught by asn) + * fix: autogenerated Nickname field caused a torrc validation false positive + * fix: crashing issue when querying locales with an unavailable geoip file + * fix: misparsing config option types for some older tor versions + * fix: stacktrace from unjoined thread at shutdown + * fix: intermediate graphing bounds were either inaccurate or missing + * fix: man page typo (caught by tagnaq) + * fix: --debug flag broke if config-text unavailable (caught by trogdor) + * fix: man page had author's hard coded home rather than ~ (caught by kuhkatz) + * fix: dropping remaining addfstr usage from the codebase + * fix: indicating when tor's shut down in client mode + * fix: miscropping strings that broke on their first word, causing alignment issues in the config panel + * fix: cropping whitespace-only strings could crash + * fix: display was cropped by an extra cell + * fix: utilizing extra horizontal space for the configuration value field if wide + * fix: providing a more descriptive controller password prompt (suggestion by weasel) + * fix: fallback configuration descriptions weren't being installed (caught by ioerror) + * fix: daemons weren't being shut down on keyboard interrupt, causing occasional stacktrace + 4/4/11 - version 1.4.2 (r24555) This release chiefly consists of a fully reimplemented connection panel. Besides being a sane, maintainable implementation this includes numerous new features and improvements like full circuit paths, applications involved for local connections, and better type identification.

1 0

[arm/release] 1.4.3 version bump
by atagar＠torproject.org 17 Jul '11

17 Jul '11

commit 6cf483617349d31ab35ffa2b0bae5af32e3087ee Author: Damian Johnson <atagar(a)torproject.org> Date: Sat Jul 16 23:07:09 2011 -0700 1.4.3 version bump --- src/version.py | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/version.py b/src/version.py index d135944..1653b22 100644 --- a/src/version.py +++ b/src/version.py @@ -2,6 +2,6 @@ Provides arm's version and release date. """ -VERSION = '1.4.3_dev' -LAST_MODIFIED = "April 4, 2011" +VERSION = '1.4.3' +LAST_MODIFIED = "July 16, 2011"

1 0

[arm/release] fix: repopulating log panel when on tor init
by atagar＠torproject.org 17 Jul '11

17 Jul '11

commit 96e46cbfa76c479da428762d046ab7300a78d338 Author: Damian Johnson <atagar(a)torproject.org> Date: Mon Jul 11 21:55:59 2011 -0700 fix: repopulating log panel when on tor init When connecting to a new tor instance the log panel is now clearing itself and repopulating with the event backlog. This keeps all arm events, and mixes them with the events of the tor log file. This is helpful since it means that we'll display the events that occurred during initialization. --- src/cli/logPanel.py | 94 +++++++++++++++++++++++++++++++------------------- 1 files changed, 58 insertions(+), 36 deletions(-) diff --git a/src/cli/logPanel.py b/src/cli/logPanel.py index 9ea4ecb..6da0901 100644 --- a/src/cli/logPanel.py +++ b/src/cli/logPanel.py @@ -619,47 +619,14 @@ class LogPanel(panel.Panel, threading.Thread): self._titleCache = None self._titleArgs = (None, None, None) - # fetches past tor events from log file, if available - torEventBacklog = [] - if self._config["features.log.prepopulate"]: - setRunlevels = list(set.intersection(set(self.loggedEvents), set(log.Runlevel.values()))) - readLimit = self._config["features.log.prepopulateReadLimit"] - addLimit = self._config["cache.logPanel.size"] - torEventBacklog = getLogFileEntries(setRunlevels, readLimit, addLimit, self._config) - - # adds arm listener and fetches past events + # adds arm listener and prepopulates log with past tor/arm events log.LOG_LOCK.acquire() try: - armRunlevels = [log.DEBUG, log.INFO, log.NOTICE, log.WARN, log.ERR] - log.addListeners(armRunlevels, self._registerArmEvent) - - # gets the set of arm events we're logging - setRunlevels = [] - for i in range(len(armRunlevels)): - if "ARM_" + log.Runlevel.values()[i] in self.loggedEvents: - setRunlevels.append(armRunlevels[i]) - - armEventBacklog = [] - for level, msg, eventTime in log._getEntries(setRunlevels): - armEventEntry = LogEntry(eventTime, "ARM_" + level, msg, RUNLEVEL_EVENT_COLOR[level]) - armEventBacklog.insert(0, armEventEntry) - - # joins armEventBacklog and torEventBacklog chronologically into msgLog - while armEventBacklog or torEventBacklog: - if not armEventBacklog: - self.msgLog.append(torEventBacklog.pop(0)) - elif not torEventBacklog: - self.msgLog.append(armEventBacklog.pop(0)) - elif armEventBacklog[0].timestamp < torEventBacklog[0].timestamp: - self.msgLog.append(torEventBacklog.pop(0)) - else: - self.msgLog.append(armEventBacklog.pop(0)) + log.addListeners(log.Runlevel.values(), self._registerArmEvent) + self.reprepopulateEvents() finally: log.LOG_LOCK.release() - # crops events that are either too old, or more numerous than the caching size - self._trimEvents(self.msgLog) - # leaving lastContentHeight as being too low causes initialization problems self.lastContentHeight = len(self.msgLog) @@ -667,6 +634,7 @@ class LogPanel(panel.Panel, threading.Thread): conn = torTools.getConn() conn.addEventListener(TorEventObserver(self.registerEvent)) conn.addTorCtlListener(self._registerTorCtlEvent) + conn.addStatusListener(self._resetListener) # opens log file if we'll be saving entries if self._config["features.logFile"]: @@ -683,6 +651,52 @@ class LogPanel(panel.Panel, threading.Thread): log.log(self._config["log.logPanel.logFileWriteFailed"], "Unable to write to log file: %s" % sysTools.getFileErrorMsg(exc)) self.logFile = None + def reprepopulateEvents(self): + """ + Clears the event log and repopulates it from the arm and tor backlogs. + """ + + self.valsLock.acquire() + + # clears the event log + self.msgLog = [] + + # fetches past tor events from log file, if available + torEventBacklog = [] + if self._config["features.log.prepopulate"]: + setRunlevels = list(set.intersection(set(self.loggedEvents), set(log.Runlevel.values()))) + readLimit = self._config["features.log.prepopulateReadLimit"] + addLimit = self._config["cache.logPanel.size"] + torEventBacklog = getLogFileEntries(setRunlevels, readLimit, addLimit, self._config) + + # gets the set of arm events we're logging + setRunlevels = [] + armRunlevels = log.Runlevel.values() + for i in range(len(armRunlevels)): + if "ARM_" + log.Runlevel.values()[i] in self.loggedEvents: + setRunlevels.append(armRunlevels[i]) + + armEventBacklog = [] + for level, msg, eventTime in log._getEntries(setRunlevels): + armEventEntry = LogEntry(eventTime, "ARM_" + level, msg, RUNLEVEL_EVENT_COLOR[level]) + armEventBacklog.insert(0, armEventEntry) + + # joins armEventBacklog and torEventBacklog chronologically into msgLog + while armEventBacklog or torEventBacklog: + if not armEventBacklog: + self.msgLog.append(torEventBacklog.pop(0)) + elif not torEventBacklog: + self.msgLog.append(armEventBacklog.pop(0)) + elif armEventBacklog[0].timestamp < torEventBacklog[0].timestamp: + self.msgLog.append(torEventBacklog.pop(0)) + else: + self.msgLog.append(armEventBacklog.pop(0)) + + # crops events that are either too old, or more numerous than the caching size + self._trimEvents(self.msgLog) + + self.valsLock.release() + def setDuplicateVisability(self, isVisible): """ Sets if duplicate log entries are collaped or expanded. @@ -1159,6 +1173,14 @@ class LogPanel(panel.Panel, threading.Thread): self._cond.notifyAll() self._cond.release() + def _resetListener(self, _, eventType): + # if we're attaching to a new tor instance then clears the log and + # prepopulates it with the content belonging to this instance + + if eventType == torTools.State.INIT: + self.reprepopulateEvents() + self.redraw(True) + def _getTitle(self, width): """ Provides the label used for the panel, looking like:

1 0

[arm/release] fix: panel overlap if sighup toggles being a relay
by atagar＠torproject.org 17 Jul '11

17 Jul '11

commit 121d0dfc41a8f65f6fe336a10c29f6d310f99468 Author: Damian Johnson <atagar(a)torproject.org> Date: Mon Jul 11 14:41:59 2011 -0700 fix: panel overlap if sighup toggles being a relay If we sighup or reconnect to a tor instance and this toggles having an ORPort then the height of the header panel can change, causing overlap with the panel below it (this causes flickering of the overlapped content). Redrawing the whole display if this happens. --- src/cli/headerPanel.py | 11 ++++++++++- 1 files changed, 10 insertions(+), 1 deletions(-) diff --git a/src/cli/headerPanel.py b/src/cli/headerPanel.py index f80eff8..e64a6de 100644 --- a/src/cli/headerPanel.py +++ b/src/cli/headerPanel.py @@ -418,10 +418,19 @@ class HeaderPanel(panel.Panel, threading.Thread): """ if eventType in (torTools.State.INIT, torTools.State.RESET): + initialHeight = self.getHeight() self._isTorConnected = True self._haltTime = None self._update(True) - self.redraw(True) + + if self.getHeight() != initialHeight: + # We're toggling between being a relay and client, causing the height + # of this panel to change. Redraw all content so we don't get + # overlapping content. + cli.controller.getController().requestRedraw(True) + else: + # just need to redraw ourselves + self.redraw(True) elif eventType == torTools.State.CLOSED: self._isTorConnected = False self._haltTime = time.time()

1 0

[arm/release] fix: graph panel can overlap after reconnect
by atagar＠torproject.org 17 Jul '11

17 Jul '11

commit 4793494447312e0ef1bbb33c2d82948362b129b9 Author: Damian Johnson <atagar(a)torproject.org> Date: Tue Jul 12 09:40:48 2011 -0700 fix: graph panel can overlap after reconnect If having accounting stats changes from one tor instance to the next then the graph panel's size can change, causing overlap with the log panel for a few seconds. --- src/cli/graphing/bandwidthStats.py | 10 +++++++++- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/src/cli/graphing/bandwidthStats.py b/src/cli/graphing/bandwidthStats.py index 642790d..f1891f9 100644 --- a/src/cli/graphing/bandwidthStats.py +++ b/src/cli/graphing/bandwidthStats.py @@ -6,6 +6,8 @@ stats if they're set. import time import curses +import cli.controller + from cli.graphing import graphPanel from util import log, sysTools, torTools, uiTools @@ -87,7 +89,13 @@ class BandwidthStats(graphPanel.GraphStats): self.new_desc_event(None) # updates title params if eventType in (torTools.State.INIT, torTools.State.RESET) and self._config["features.graph.bw.accounting.show"]: - self.isAccounting = conn.getInfo('accounting/enabled') == '1' + isAccountingEnabled = conn.getInfo('accounting/enabled') == '1' + + if isAccountingEnabled != self.isAccounting: + self.isAccounting = isAccountingEnabled + + # redraws the whole screen since our height changed + cli.controller.getController().requestRedraw(True) # redraws to reflect changes (this especially noticeable when we have # accounting and shut down since it then gives notice of the shutdown)

1 0

[arm/release] Using extra config panel width for values
by atagar＠torproject.org 17 Jul '11

17 Jul '11

commit fa77ada821231a50426185f23a27254d7e18c475 Author: Damian Johnson <atagar(a)torproject.org> Date: Tue Jul 12 09:48:31 2011 -0700 Using extra config panel width for values When the configuration panel has enough space to show the whole summaries using the extra space for the value column instead. --- src/cli/configPanel.py | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/src/cli/configPanel.py b/src/cli/configPanel.py index d76a528..e4a48fc 100644 --- a/src/cli/configPanel.py +++ b/src/cli/configPanel.py @@ -528,6 +528,12 @@ class ConfigPanel(panel.Panel): valueWidth = self._config["features.config.state.colWidth.value"] descriptionWidth = max(0, width - scrollOffset - optionWidth - valueWidth - 2) + # if the description column is overly long then use its space for the + # value instead + if descriptionWidth > 80: + valueWidth += descriptionWidth - 80 + descriptionWidth = 80 + for lineNum in range(scrollLoc, len(self._getConfigOptions())): entry = self._getConfigOptions()[lineNum] drawLine = lineNum + detailPanelHeight + 1 - scrollLoc

1 0