- tor-commits - lists.torproject.org

[torbrowser/master] [Linux] Trim leading newlines in complain messages (patch by velope)
by erinn＠torproject.org 28 Aug '11

28 Aug '11

commit ccfb64406fb371b3e48377a2fb32ed45d3496107 Author: Robert Ransom <rransom.8774(a)gmail.com> Date: Fri Aug 26 04:23:50 2011 -0400 [Linux] Trim leading newlines in complain messages (patch by velope) --- src/RelativeLink/RelativeLink.sh | 16 +++++++++++----- 1 files changed, 11 insertions(+), 5 deletions(-) diff --git a/src/RelativeLink/RelativeLink.sh b/src/RelativeLink/RelativeLink.sh index a1a1510..7df0983 100755 --- a/src/RelativeLink/RelativeLink.sh +++ b/src/RelativeLink/RelativeLink.sh @@ -47,9 +47,12 @@ fi # Usage: complain message # message must not begin with a dash. complain () { + # Trim leading newlines, to avoid breaking formatting in some dialogs. + complain_message="`echo "$1" | sed '/./,$!d'`" + # If we're being run in a terminal, complain there. if [ "$ARE_WE_RUNNING_IN_A_TERMINAL" -ne 0 ]; then - echo "$1" >&2 + echo "$complain_message" >&2 return fi @@ -65,13 +68,16 @@ complain () { # it returns non-zero.) # First, try zenity. - zenity --error --title="$complain_dialog_title" --text="$1" + zenity --error \ + --title="$complain_dialog_title" \ + --text="$complain_message" if [ "$?" -ne 127 ]; then return fi # Try kdialog. - kdialog --title "$complain_dialog_title" --error "$1" + kdialog --title "$complain_dialog_title" \ + --error "$complain_message" if [ "$?" -ne 127 ]; then return fi @@ -83,7 +89,7 @@ complain () { -default OK \ -geometry 300 \ -xrm '*message.scrollVertical: Never' \ - "$1" + "$complain_message" if [ "$?" -ne 127 ]; then return fi @@ -98,7 +104,7 @@ complain () { -buttons GTK_STOCK_OK \ -default OK \ -geometry 300 \ - "$1" + "$complain_message" if [ "$?" -ne 127 ]; then return fi

1 0

[torbrowser/master] [Linux] Don't specify -geometry when complaining using [g]xmessage
by erinn＠torproject.org 28 Aug '11

28 Aug '11

commit a4c597d4f3bcdc931f6cbbdaa142d1b1997cddd9 Author: Robert Ransom <rransom.8774(a)gmail.com> Date: Fri Aug 26 04:38:06 2011 -0400 [Linux] Don't specify -geometry when complaining using [g]xmessage velope reported that it could make the dialog too small to show the message text. --- src/RelativeLink/RelativeLink.sh | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/src/RelativeLink/RelativeLink.sh b/src/RelativeLink/RelativeLink.sh index 7df0983..5461539 100755 --- a/src/RelativeLink/RelativeLink.sh +++ b/src/RelativeLink/RelativeLink.sh @@ -87,7 +87,6 @@ complain () { -center \ -buttons OK \ -default OK \ - -geometry 300 \ -xrm '*message.scrollVertical: Never' \ "$complain_message" if [ "$?" -ne 127 ]; then @@ -103,7 +102,6 @@ complain () { -center \ -buttons GTK_STOCK_OK \ -default OK \ - -geometry 300 \ "$complain_message" if [ "$?" -ne 127 ]; then return

1 0

[torbrowser/master] [Linux] Use ` ` instead of $( ) for consistency
by erinn＠torproject.org 28 Aug '11

28 Aug '11

commit 756d8db1ecadd09a8d8f947187ef31e8c40ff912 Author: Robert Ransom <rransom.8774(a)gmail.com> Date: Wed Aug 24 03:21:10 2011 -0400 [Linux] Use ` ` instead of $( ) for consistency --- src/RelativeLink/RelativeLink.sh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/RelativeLink/RelativeLink.sh b/src/RelativeLink/RelativeLink.sh index 7c2dc7d..5fd0acc 100755 --- a/src/RelativeLink/RelativeLink.sh +++ b/src/RelativeLink/RelativeLink.sh @@ -120,7 +120,7 @@ done # Try to be agnostic to where we're being started from, chdir to where # the script is. -mydir="$(dirname "$myname")" +mydir="`dirname "$myname"`" test -d "$mydir" && cd "$mydir" # If ${PWD} results in a zero length HOME, we can try something else...

1 0

[torbrowser/master] [Linux] Correct bugs in RelativeLink.sh debug output (spotted by velope)
by erinn＠torproject.org 28 Aug '11

28 Aug '11

commit 792b995928b7e107abb50c1dcd8659869f40ee93 Author: Robert Ransom <rransom.8774(a)gmail.com> Date: Fri Aug 26 04:45:03 2011 -0400 [Linux] Correct bugs in RelativeLink.sh debug output (spotted by velope) --- src/RelativeLink/RelativeLink.sh | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/RelativeLink/RelativeLink.sh b/src/RelativeLink/RelativeLink.sh index 2c95fa3..04d91fa 100755 --- a/src/RelativeLink/RelativeLink.sh +++ b/src/RelativeLink/RelativeLink.sh @@ -205,7 +205,7 @@ if [ "${debug}" ]; then BOUND="`netstat -tan 2>&1|grep 127.0.0.1":${port}[^:]"|grep -v TIME_WAIT`" if [ "${BOUND}" ]; then printf "\nLikely problem detected: It appears that you have something listening on ${port}\n" - printf "\nWe think this because of the following: ${BOUND}\n" + printf "\nWe think this because of the following:\n${BOUND}\n" fi done @@ -227,5 +227,5 @@ if [ "$exitcode" -ne 0 ]; then complain "Vidalia exited abnormally. Exit code: $exitcode" exit "$exitcode" else - echo '\nVidalia exited cleanly.\n' + printf '\nVidalia exited cleanly.\n' fi

1 0

[torbrowser/master] [Linux] Use $complain_dialog_title for generality
by erinn＠torproject.org 28 Aug '11

28 Aug '11

commit 0b1c288a7f7d41dcaeb76ee6cc14e10481d121c2 Author: Robert Ransom <rransom.8774(a)gmail.com> Date: Fri Aug 26 03:50:53 2011 -0400 [Linux] Use $complain_dialog_title for generality --- src/RelativeLink/RelativeLink.sh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/RelativeLink/RelativeLink.sh b/src/RelativeLink/RelativeLink.sh index 8013f38..a1a1510 100755 --- a/src/RelativeLink/RelativeLink.sh +++ b/src/RelativeLink/RelativeLink.sh @@ -12,7 +12,7 @@ complain_dialog_title="Tor Browser Bundle" # First, make sure DISPLAY is set. If it isn't, we're hosed; scream # at stderr and die. if [ "x$DISPLAY" = "x" ]; then - echo "The Tor Browser Bundle for Linux must be run within the X Window System." >&2 + echo "$complain_dialog_title must be run within the X Window System." >&2 echo "Exiting." >&2 exit 1 fi

1 0

[torbrowser/master] [Linux] Add missing quotes (spotted by velope)
by erinn＠torproject.org 28 Aug '11

28 Aug '11

commit 7dc48b20ea1e4cb0783fb842fdd060b0c22f7ccb Author: Robert Ransom <rransom.8774(a)gmail.com> Date: Fri Aug 26 04:40:18 2011 -0400 [Linux] Add missing quotes (spotted by velope) --- src/RelativeLink/RelativeLink.sh | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/RelativeLink/RelativeLink.sh b/src/RelativeLink/RelativeLink.sh index 5461539..2c95fa3 100755 --- a/src/RelativeLink/RelativeLink.sh +++ b/src/RelativeLink/RelativeLink.sh @@ -118,10 +118,10 @@ if [ "$#" -eq 1 -a $ "x$1" = "x--debug" -o "x$1" = "x-debug" $ ]; then debug=1 printf "\nDebug enabled.\n\n" elif [ "$#" -eq 1 -a $ "x$1" = "x--help" -o "x$1" = "x-help" $ ]; then - echo $usage_message + echo "$usage_message" exit 1 elif [ "$#" -ne 0 ]; then - complain $usage_message + complain "$usage_message" exit 1 fi

1 0

[torbrowser/master] [Linux] Quote $XAUTHORITY properly
by erinn＠torproject.org 28 Aug '11

28 Aug '11

commit 60e114c5598a6c3b2615745b8c49e1a45fab8052 Author: Robert Ransom <rransom.8774(a)gmail.com> Date: Tue Aug 23 01:46:42 2011 -0400 [Linux] Quote $XAUTHORITY properly I would be moderately surprised if any program put a shell metacharacter in that variable, but it could happen. --- src/RelativeLink/RelativeLink.sh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/RelativeLink/RelativeLink.sh b/src/RelativeLink/RelativeLink.sh index 99e5255..33961c9 100755 --- a/src/RelativeLink/RelativeLink.sh +++ b/src/RelativeLink/RelativeLink.sh @@ -14,7 +14,7 @@ if [ $1 ]; then printf "\nDebug enabled.\n\n" fi -if [ -z $XAUTHORITY ]; then +if [ -z "$XAUTHORITY" ]; then XAUTHORITY=~/.Xauthority export XAUTHORITY fi

1 0

[torbrowser/master] [2824 Linux] Set UID:GID of files in TBB-Linux tarball to 0:0 (root:wheel)
by erinn＠torproject.org 28 Aug '11

28 Aug '11

commit 037f07b7008643793704af280a847a82296591f7 Author: Robert Ransom <rransom.8774(a)gmail.com> Date: Tue Aug 23 01:36:33 2011 -0400 [2824 Linux] Set UID:GID of files in TBB-Linux tarball to 0:0 (root:wheel) As a result of this change, the build process for TBB for Linux now requires 'Tardy' (http://tardy.sourceforge.net/ ; Debian package 'tardy'). (I tested this Tardy command line with version 1.12 from Debian Squeeze, but not as part of the TBB build process.) --- build-scripts/linux.mk | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/build-scripts/linux.mk b/build-scripts/linux.mk index deba909..2c3b7b8 100644 --- a/build-scripts/linux.mk +++ b/build-scripts/linux.mk @@ -457,7 +457,7 @@ bundle-localized: bundle-localized_$(LANGCODE).stamp compressed-bundle-localized: bundle-localized_$(LANGCODE).stamp -rm -f $(DISTDIR)/$(COMPRESSED_NAME)_$(LANGCODE).tar.gz -mkdir $(DISTDIR) - tar -cvzf $(DISTDIR)/$(DEFAULT_COMPRESSED_BASENAME)$(LANGCODE).tar.gz $(NAME)_$(LANGCODE); + tar -cvf - $(NAME)_$(LANGCODE) |tardy -unu 0 -una root -gnu 0 -gna wheel |gzip -c9 >$(DISTDIR)/$(DEFAULT_COMPRESSED_BASENAME)$(LANGCODE).tar.gz rm *.zip *.xpi cp test/torbutton.xpi torbutton.xpi

1 0

[torbrowser/master] [Linux] Document why we need to set XAUTHORITY in this script
by erinn＠torproject.org 28 Aug '11

28 Aug '11

commit 34cdd1dcc58adc55e04549698349c060f6378648 Author: Robert Ransom <rransom.8774(a)gmail.com> Date: Tue Aug 23 01:55:32 2011 -0400 [Linux] Document why we need to set XAUTHORITY in this script Otherwise, some GDM user who doesn't know why it needs to be set here will remove this chunk of script someday. --- src/RelativeLink/RelativeLink.sh | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/RelativeLink/RelativeLink.sh b/src/RelativeLink/RelativeLink.sh index 33961c9..09013a9 100755 --- a/src/RelativeLink/RelativeLink.sh +++ b/src/RelativeLink/RelativeLink.sh @@ -14,6 +14,9 @@ if [ $1 ]; then printf "\nDebug enabled.\n\n" fi +# If XAUTHORITY is unset, set it to its default value of $HOME/.Xauthority +# before we change HOME below. (See xauth(1) and #1945.) XDM and KDM rely +# on applications using this default value. if [ -z "$XAUTHORITY" ]; then XAUTHORITY=~/.Xauthority export XAUTHORITY

1 0

[torbrowser/master] [Linux] Remove a bogus comment
by erinn＠torproject.org 28 Aug '11

28 Aug '11

commit 630326fad2c3321557c438a6ac8c8aeb9e8224e0 Author: Robert Ransom <rransom.8774(a)gmail.com> Date: Tue Aug 23 01:58:56 2011 -0400 [Linux] Remove a bogus comment The commonly used Linux desktop environments' file managers do not allow C programs to have custom icons. --- src/RelativeLink/RelativeLink.sh | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/src/RelativeLink/RelativeLink.sh b/src/RelativeLink/RelativeLink.sh index 09013a9..63c0414 100755 --- a/src/RelativeLink/RelativeLink.sh +++ b/src/RelativeLink/RelativeLink.sh @@ -2,8 +2,6 @@ # # GNU/Linux does not really require something like RelativeLink.c # However, we do want to have the same look and feel with similiar features. -# In the future, we may want this to be a C binary with a custom icon but at the moment -# it's quite simple to just use a shell script # # To run in debug mode simply pass --debug #

1 0