- tor-commits - lists.torproject.org

[tor/release-0.2.2] Avoid running DNS self-tests if we're operating as a bridge
by arma＠torproject.org 24 Oct '11

24 Oct '11

commit 6d027a3823843030fc24d7224da3ca976f121b01 Author: warms0x <warms0x(a)riseup.net> Date: Fri Oct 7 07:04:29 2011 +0000 Avoid running DNS self-tests if we're operating as a bridge --- changes/bug4201 | 5 +++++ src/or/main.c | 2 +- 2 files changed, 6 insertions(+), 1 deletions(-) diff --git a/changes/bug4201 b/changes/bug4201 new file mode 100644 index 0000000..6f7d715 --- /dev/null +++ b/changes/bug4201 @@ -0,0 +1,5 @@ + o Minor bugfixes: + - Bridges now skip DNS self-tests, to act a little more stealthily. + Fixes bug 4201; bugfix on 0.2.0.3-alpha, which first introduced + bridges. Patch by "warms0x". + diff --git a/src/or/main.c b/src/or/main.c index 289d805..95acea4 100644 --- a/src/or/main.c +++ b/src/or/main.c @@ -1241,7 +1241,7 @@ run_scheduled_events(time_t now) /** 9. and if we're a server, check whether our DNS is telling stories to * us. */ - if (is_server && time_to_check_for_correct_dns < now) { + if (public_server_mode(options) && time_to_check_for_correct_dns < now) { if (!time_to_check_for_correct_dns) { time_to_check_for_correct_dns = now + 60 + crypto_rand_int(120); } else {

1 0

[tor/release-0.2.2] Note ticket and source version for feature3951 in changes file
by arma＠torproject.org 24 Oct '11

24 Oct '11

commit f37d24c550a0d8512249f77262c01960af6ed31b Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Oct 7 16:47:43 2011 -0400 Note ticket and source version for feature3951 in changes file --- changes/dirreq-stats-default | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/changes/dirreq-stats-default b/changes/dirreq-stats-default index 673be6a..df7ac11 100644 --- a/changes/dirreq-stats-default +++ b/changes/dirreq-stats-default @@ -1,4 +1,5 @@ o Minor features: - Turn on directory request statistics by default and include them in extra-info descriptors. Don't break if we have no GeoIP database. + Backported from 0.2.3.1-alpha; implements ticket 3951.

1 0

[tor/release-0.2.2] Merge branch 'maint-0.2.1' into maint-0.2.2
by arma＠torproject.org 24 Oct '11

24 Oct '11

commit ac7b6c508dca24a256abc30b4ecaf21019569a38 Merge: 4a351b4 679f617 Author: Roger Dingledine <arma(a)torproject.org> Date: Thu Sep 15 16:34:47 2011 -0400 Merge branch 'maint-0.2.1' into maint-0.2.2

1 0

[tor/release-0.2.2] Fix a potentially useless integer overflow check.
by arma＠torproject.org 24 Oct '11

24 Oct '11

commit 1ba90ab655fab036f00ba0185ca7b456612a12bd Author: Mansour Moufid <mansourmoufid(a)gmail.com> Date: Mon Sep 19 21:25:23 2011 -0400 Fix a potentially useless integer overflow check. GCC 4.2 and maybe other compilers optimize away unsigned integer overflow checks of the form (foo + bar < foo), for all bar. Fix one such check in `src/common/OpenBSD_malloc_Linux.c'. --- src/common/OpenBSD_malloc_Linux.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/common/OpenBSD_malloc_Linux.c b/src/common/OpenBSD_malloc_Linux.c index 19dac77..445135c 100644 --- a/src/common/OpenBSD_malloc_Linux.c +++ b/src/common/OpenBSD_malloc_Linux.c @@ -1236,7 +1236,7 @@ imalloc(size_t size) ptralloc = 1; size = malloc_pagesize; } - if ((size + malloc_pagesize) < size) { /* Check for overflow */ + if (size > SIZE_MAX - malloc_pagesize) { /* Check for overflow */ result = NULL; errno = ENOMEM; } else if (size <= malloc_maxsize)

1 0

[tor/release-0.2.2] changes file for bug 4059
by arma＠torproject.org 24 Oct '11

24 Oct '11

commit bfa75f70bb5eef7b470068df8bf9e3c7fa88c21a Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Sep 20 09:56:26 2011 -0400 changes file for bug 4059 --- changes/bug4059 | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/changes/bug4059 b/changes/bug4059 new file mode 100644 index 0000000..82a4b1a --- /dev/null +++ b/changes/bug4059 @@ -0,0 +1,5 @@ + o Minor bugfixes: + - Change an integer overflow check in the OpenBSD_Malloc code so + that GCC is less likely to eliminate it as impossible. Patch + from Mansour Moufid. Fixes bug 4059. +

1 0

[tor/release-0.2.2] Ticket #4063 - change circuit build timeout log entries from NOTICE to INFO
by arma＠torproject.org 24 Oct '11

24 Oct '11

commit 5835acc6f910e2bb1e3908802717eeff4122a9b8 Author: Tom Lowenthal <me(a)tomlowenthal.com> Date: Sat Sep 24 15:34:32 2011 -0700 Ticket #4063 - change circuit build timeout log entries from NOTICE to INFO --- src/or/circuitbuild.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/or/circuitbuild.c b/src/or/circuitbuild.c index c6be46d..888023d 100644 --- a/src/or/circuitbuild.c +++ b/src/or/circuitbuild.c @@ -1381,7 +1381,7 @@ circuit_build_times_set_timeout_worker(circuit_build_times_t *cbt) cbt->close_ms = MAX(cbt->close_ms, circuit_build_times_initial_timeout()); if (cbt->timeout_ms > max_time) { - log_notice(LD_CIRC, + log_info(LD_CIRC, "Circuit build timeout of %dms is beyond the maximum build " "time we have ever observed. Capping it to %dms.", (int)cbt->timeout_ms, max_time); @@ -1429,7 +1429,7 @@ circuit_build_times_set_timeout(circuit_build_times_t *cbt) timeout_rate = circuit_build_times_timeout_rate(cbt); if (prev_timeout > tor_lround(cbt->timeout_ms/1000)) { - log_notice(LD_CIRC, + log_info(LD_CIRC, "Based on %d circuit times, it looks like we don't need to " "wait so long for circuits to finish. We will now assume a " "circuit is too slow to use after waiting %ld seconds.", @@ -1440,7 +1440,7 @@ circuit_build_times_set_timeout(circuit_build_times_t *cbt) cbt->timeout_ms, cbt->close_ms, cbt->Xm, cbt->alpha, timeout_rate); } else if (prev_timeout < tor_lround(cbt->timeout_ms/1000)) { - log_notice(LD_CIRC, + log_info(LD_CIRC, "Based on %d circuit times, it looks like we need to wait " "longer for circuits to finish. We will now assume a " "circuit is too slow to use after waiting %ld seconds.",

1 0

[tor/release-0.2.2] Add a changes file for Tom Lowenthal's patch for #4063
by arma＠torproject.org 24 Oct '11

24 Oct '11

commit ccceefe13674119768436bd1b9e3c4bf04ffc5ed Author: Nick Mathewson <nickm(a)torproject.org> Date: Sat Sep 24 22:15:13 2011 -0400 Add a changes file for Tom Lowenthal's patch for #4063 --- changes/ticket-4063 | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/changes/ticket-4063 b/changes/ticket-4063 new file mode 100644 index 0000000..6a985b8 --- /dev/null +++ b/changes/ticket-4063 @@ -0,0 +1,6 @@ + o Minor bugfixes (usability): + - Downgrade log messages about circuit timeout calibration from + "notice" to "info": they don't require or suggest any human + intervention. Patch from Tom Lowenthal. Fixes bug 4063; + bugfix on 0.2.2.14-alpha. +

1 0

[tor/release-0.2.2] Trivial whitespace fixes
by arma＠torproject.org 24 Oct '11

24 Oct '11

commit c42a1886cccbcd4f6e6e90526b5132d6a6cbb2a4 Author: Nick Mathewson <nickm(a)torproject.org> Date: Sat Sep 24 22:15:59 2011 -0400 Trivial whitespace fixes --- src/or/connection_edge.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/or/connection_edge.c b/src/or/connection_edge.c index 8609b02..0663787 100644 --- a/src/or/connection_edge.c +++ b/src/or/connection_edge.c @@ -842,8 +842,8 @@ addressmap_clear_excluded_trackexithosts(or_options_t *options) if (len < 6) continue; /* malformed. */ dot = target + len - 6; /* dot now points to just before .exit */ - while(dot > target && *dot != '.') - dot--; + while (dot > target && *dot != '.') + dot--; if (*dot == '.') dot++; nodename = tor_strndup(dot, len-5-(dot-target));; ri = router_get_by_nickname(nodename, 0);

1 0

[tor/release-0.2.2] trivial whitespace changes, take two
by arma＠torproject.org 24 Oct '11

24 Oct '11

commit 1c2e4d13366aee5f0107696e4d621b924a6f39a6 Author: Roger Dingledine <arma(a)torproject.org> Date: Sat Sep 24 22:46:21 2011 -0400 trivial whitespace changes, take two --- src/or/connection_edge.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/or/connection_edge.c b/src/or/connection_edge.c index 0663787..6a69609 100644 --- a/src/or/connection_edge.c +++ b/src/or/connection_edge.c @@ -843,7 +843,7 @@ addressmap_clear_excluded_trackexithosts(or_options_t *options) continue; /* malformed. */ dot = target + len - 6; /* dot now points to just before .exit */ while (dot > target && *dot != '.') - dot--; + dot--; if (*dot == '.') dot++; nodename = tor_strndup(dot, len-5-(dot-target));; ri = router_get_by_nickname(nodename, 0);

1 0

[tor/release-0.2.2] bug 4115: make bridges use begindir for their dir fetches
by arma＠torproject.org 24 Oct '11

24 Oct '11

commit 0b5d2646d56fe351b8b2b4bc97bbad30cb34b6d4 Author: Roger Dingledine <arma(a)torproject.org> Date: Wed Sep 28 14:50:43 2011 -0400 bug 4115: make bridges use begindir for their dir fetches removes another avenue for enumerating bridges. --- changes/bug4115 | 7 +++++++ src/or/directory.c | 3 +-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/changes/bug4115 b/changes/bug4115 new file mode 100644 index 0000000..626791a --- /dev/null +++ b/changes/bug4115 @@ -0,0 +1,7 @@ + o Security fixes: + - Bridge relays now do their directory fetches inside Tor TLS + connections, like all the other clients do, rather than connecting + directly to the DirPort like public relays do. Removes another + avenue for enumerating bridges. Fixes part of bug 4115; bugfix + on 0.2.0.35. + diff --git a/src/or/directory.c b/src/or/directory.c index 52fec6b..e3cc70f 100644 --- a/src/or/directory.c +++ b/src/or/directory.c @@ -785,8 +785,7 @@ directory_command_should_use_begindir(or_options_t *options, return 0; /* We don't know an ORPort -- no chance. */ if (!anonymized_connection) if (!fascist_firewall_allows_address_or(addr, or_port) || - directory_fetches_from_authorities(options) || - (server_mode(options) && !options->Address)) + directory_fetches_from_authorities(options)) return 0; /* We're firewalled or are acting like a relay -- also no. */ if (!options->TunnelDirConns && router_purpose != ROUTER_PURPOSE_BRIDGE)

1 0