- tor-commits - lists.torproject.org

[tor/release-0.2.2] Get rid of an unused parameter warning on win
by arma＠torproject.org 22 Nov '11

22 Nov '11

commit 3dc2a1c62cf01218f1a1afc03e54b0b2b52046e7 Author: Sebastian Hahn <sebastian(a)torproject.org> Date: Tue Aug 9 11:00:25 2011 +0200 Get rid of an unused parameter warning on win This is a backport of bed79c47f4ec0ee72b19e2b81c54131d516d07ef which accidentally only went into master --- src/common/util.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/common/util.c b/src/common/util.c index de1ca36..7675ede 100644 --- a/src/common/util.c +++ b/src/common/util.c @@ -1698,6 +1698,8 @@ check_private_dir(const char *dirname, cpd_check_t check, struct passwd *pw = NULL; uid_t running_uid; gid_t running_gid; +#else + (void)effective_user; #endif tor_assert(dirname);

1 0

[tor/release-0.2.2] Sockets are unsigned on windows
by arma＠torproject.org 22 Nov '11

22 Nov '11

commit 2efa6eb652d9eb2dd6d91a5e4ef3e9eea1ac7d22 Author: Sebastian Hahn <sebastian(a)torproject.org> Date: Tue Aug 9 10:59:03 2011 +0200 Sockets are unsigned on windows this gets rid of a warning about signed/unsigned comparison This is a backport of 0a5338e03cdf14ef80584c6ff8adeb49200b8a76 that accidentally only went into master --- src/common/compat.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/common/compat.h b/src/common/compat.h index 7e6058a..011b9c8 100644 --- a/src/common/compat.h +++ b/src/common/compat.h @@ -396,7 +396,7 @@ typedef int socklen_t; #ifdef MS_WINDOWS #define tor_socket_t intptr_t -#define SOCKET_OK(s) ((s) != INVALID_SOCKET) +#define SOCKET_OK(s) ((unsigned)(s) != INVALID_SOCKET) #else #define tor_socket_t int #define SOCKET_OK(s) ((s) >= 0)

1 0

[tor/release-0.2.2] Merge remote-tracking branch 'public/bug3963' into maint-0.2.2
by arma＠torproject.org 22 Nov '11

22 Nov '11

commit b3c988f0d7e18c243074e3e583c10b204521088f Merge: fbcd7c0 45eadf3 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Nov 21 10:52:15 2011 -0500 Merge remote-tracking branch 'public/bug3963' into maint-0.2.2 changes/bug3963 | 5 +++++ src/or/ntmain.c | 2 +- 2 files changed, 6 insertions(+), 1 deletions(-)

1 0

[tor/release-0.2.2] Merge branch 'bug4518' into maint-0.2.2
by arma＠torproject.org 22 Nov '11

22 Nov '11

commit f4e053d6dff0b868449a8c225c2062b42083733f Merge: b3c988f 8e388bc Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Nov 21 17:25:51 2011 -0500 Merge branch 'bug4518' into maint-0.2.2 changes/bug4518 | 4 ++++ src/or/cpuworker.c | 14 ++++++++++++-- 2 files changed, 16 insertions(+), 2 deletions(-)

1 0

[tor/release-0.2.2] man page entries for AuthDir{Fast, GuardBW}Guarantee
by arma＠torproject.org 22 Nov '11

22 Nov '11

commit 97a209ea28f1b64fba51157e3e695c676eb0cf8e Author: Roger Dingledine <arma(a)torproject.org> Date: Mon Nov 21 18:32:32 2011 -0500 man page entries for AuthDir{Fast,GuardBW}Guarantee --- doc/tor.1.txt | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/doc/tor.1.txt b/doc/tor.1.txt index 703cc82..d91f873 100644 --- a/doc/tor.1.txt +++ b/doc/tor.1.txt @@ -1284,6 +1284,16 @@ DIRECTORY AUTHORITY SERVER OPTIONS Authoritative directories only. Like AuthDirMaxServersPerAddr, but applies to addresses shared with directory authorities. (Default: 5) +**AuthDirFastGuarantee** __N__ **bytes**|**KB**|**MB**|**GB**:: + Authoritative directories only. If non-zero, always vote the + Fast flag for any relay advertising this amount of capacity or + more. (Default: 20 KB) + +**AuthDirGuardBWGuarantee** __N__ **bytes**|**KB**|**MB**|**GB**:: + Authoritative directories only. If non-zero, this advertised capacity + or more is always sufficient to satisfy the bandwidth requirement + for the Guard flag. (Default: 250 KB) + **BridgePassword** __Password__:: If set, contains an HTTP authenticator that tells a bridge authority to serve all requested bridge information. Used for debugging. (Default:

1 0

[tor/release-0.2.2] parameterize bw cutoffs to guarantee Fast and Guard flags
by arma＠torproject.org 22 Nov '11

22 Nov '11

commit c0ec4eafc54d84089536caf51b1367e8d9ddacef Author: Roger Dingledine <arma(a)torproject.org> Date: Wed Nov 16 20:55:33 2011 -0500 parameterize bw cutoffs to guarantee Fast and Guard flags Now it will be easier for researchers to simulate Tor networks with different values. Resolves ticket 4484. --- changes/feature4484 | 8 ++++++++ src/or/config.c | 8 ++++++++ src/or/dirserv.c | 24 ++++++++++++------------ src/or/or.h | 8 ++++++++ 4 files changed, 36 insertions(+), 12 deletions(-) diff --git a/changes/feature4484 b/changes/feature4484 new file mode 100644 index 0000000..78154e9 --- /dev/null +++ b/changes/feature4484 @@ -0,0 +1,8 @@ + o Minor features: + - Add two new config options for directory authorities: + AuthDirFastGuarantee sets a bandwidth threshold for guaranteeing the + Fast flag, and AuthDirGuardBWGuarantee sets a bandwidth threshold + that is always sufficient to satisfy the bandwidth requirement for + the Guard flag. Now it will be easier for researchers to simulate + Tor networks with different values. Resolves ticket 4484. + diff --git a/src/or/config.c b/src/or/config.c index ffa763e..94a6538 100644 --- a/src/or/config.c +++ b/src/or/config.c @@ -175,6 +175,8 @@ static config_var_t _option_vars[] = { V(AuthDirBadDir, LINELIST, NULL), V(AuthDirBadExit, LINELIST, NULL), V(AuthDirInvalid, LINELIST, NULL), + V(AuthDirFastGuarantee, MEMUNIT, "20 KB"), + V(AuthDirGuardBWGuarantee, MEMUNIT, "250 KB"), V(AuthDirReject, LINELIST, NULL), V(AuthDirRejectUnlisted, BOOL, "0"), V(AuthDirListBadDirs, BOOL, "0"), @@ -3373,6 +3375,12 @@ options_validate(or_options_t *old_options, or_options_t *options, if (ensure_bandwidth_cap(&options->PerConnBWBurst, "PerConnBWBurst", msg) < 0) return -1; + if (ensure_bandwidth_cap(&options->AuthDirFastGuarantee, + "AuthDirFastGuarantee", msg) < 0) + return -1; + if (ensure_bandwidth_cap(&options->AuthDirGuardBWGuarantee, + "AuthDirGuardBWGuarantee", msg) < 0) + return -1; if (options->RelayBandwidthRate && !options->RelayBandwidthBurst) options->RelayBandwidthBurst = options->RelayBandwidthRate; diff --git a/src/or/dirserv.c b/src/or/dirserv.c index c427fe2..19d9702 100644 --- a/src/or/dirserv.c +++ b/src/or/dirserv.c @@ -1692,12 +1692,6 @@ should_generate_v2_networkstatus(void) /** If a router's MTBF is at least this value, then it is always stable. * See above. (Corresponds to about 7 days for current decay rates.) */ #define MTBF_TO_GUARANTEE_STABLE (60*60*24*5) -/** Similarly, we protect sufficiently fast nodes from being pushed - * out of the set of Fast nodes. */ -#define BANDWIDTH_TO_GUARANTEE_FAST ROUTER_REQUIRED_MIN_BANDWIDTH -/** Similarly, every node with sufficient bandwidth can be considered - * for Guard status. */ -#define BANDWIDTH_TO_GUARANTEE_GUARD (250*1024) /** Similarly, every node with at least this much weighted time known can be * considered familiar enough to be a guard. Corresponds to about 20 days for * current decay rates. @@ -1841,6 +1835,7 @@ dirserv_compute_performance_thresholds(routerlist_t *rl) long *tks; double *mtbfs, *wfus; time_t now = time(NULL); + or_options_t *options = get_options(); /* initialize these all here, in case there are no routers */ stable_uptime = 0; @@ -1910,8 +1905,11 @@ dirserv_compute_performance_thresholds(routerlist_t *rl) if (guard_tk > TIME_KNOWN_TO_GUARANTEE_FAMILIAR) guard_tk = TIME_KNOWN_TO_GUARANTEE_FAMILIAR; - if (fast_bandwidth > BANDWIDTH_TO_GUARANTEE_FAST) - fast_bandwidth = BANDWIDTH_TO_GUARANTEE_FAST; + /* Protect sufficiently fast nodes from being pushed out of the set + * of Fast nodes. */ + if (options->AuthDirFastGuarantee && + fast_bandwidth > options->AuthDirFastGuarantee) + fast_bandwidth = options->AuthDirFastGuarantee; /* Now that we have a time-known that 7/8 routers are known longer than, * fill wfus with the wfu of every such "familiar" router. */ @@ -2335,6 +2333,8 @@ set_routerstatus_from_routerinfo(routerstatus_t *rs, const or_options_t *options = get_options(); int unstable_version = !tor_version_as_new_as(ri->platform,"0.1.1.16-rc-cvs"); + uint32_t routerbw = router_get_advertised_bandwidth(ri); + memset(rs, 0, sizeof(routerstatus_t)); rs->is_authority = @@ -2360,10 +2360,10 @@ set_routerstatus_from_routerinfo(routerstatus_t *rs, rs->is_valid = ri->is_valid; if (rs->is_fast && - (router_get_advertised_bandwidth(ri) >= BANDWIDTH_TO_GUARANTEE_GUARD || - router_get_advertised_bandwidth(ri) >= - MIN(guard_bandwidth_including_exits, - guard_bandwidth_excluding_exits)) && + ((options->AuthDirGuardBWGuarantee && + routerbw >= options->AuthDirGuardBWGuarantee) || + routerbw >= MIN(guard_bandwidth_including_exits, + guard_bandwidth_excluding_exits)) && (options->GiveGuardFlagTo_CVE_2011_2768_VulnerableRelays || is_router_version_good_for_possible_guard(ri->platform))) { long tk = rep_hist_get_weighted_time_known( diff --git a/src/or/or.h b/src/or/or.h index 7d50e1f..c0714ee 100644 --- a/src/or/or.h +++ b/src/or/or.h @@ -2676,6 +2676,14 @@ typedef struct { * exploitation of CVE-2011-2768 against their clients? */ int GiveGuardFlagTo_CVE_2011_2768_VulnerableRelays; + /** If non-zero, always vote the Fast flag for any relay advertising + * this amount of capacity or more. */ + uint64_t AuthDirFastGuarantee; + + /** If non-zero, this advertised capacity or more is always sufficient + * to satisfy the bandwidth requirement for the Guard flag. */ + uint64_t AuthDirGuardBWGuarantee; + char *AccountingStart; /**< How long is the accounting interval, and when * does it start? */ uint64_t AccountingMax; /**< How many bytes do we allow per accounting

1 0

[tor/release-0.2.2] Merge branch 'maint-0.2.2' into release-0.2.2
by arma＠torproject.org 22 Nov '11

22 Nov '11

commit 3f41df30056181e9f4c80436e088c8ed58f01677 Merge: 8955b25 97a209e Author: Roger Dingledine <arma(a)torproject.org> Date: Mon Nov 21 19:18:09 2011 -0500 Merge branch 'maint-0.2.2' into release-0.2.2 changes/bug3963 | 5 +++++ changes/bug4518 | 4 ++++ changes/bug4521 | 3 +++ changes/feature4484 | 8 ++++++++ doc/tor.1.txt | 10 ++++++++++ src/common/compat.h | 2 +- src/common/util.c | 2 ++ src/or/config.c | 8 ++++++++ src/or/cpuworker.c | 14 ++++++++++++-- src/or/dirserv.c | 24 ++++++++++++------------ src/or/ntmain.c | 2 +- src/or/or.h | 8 ++++++++ 12 files changed, 74 insertions(+), 16 deletions(-)

1 0

[tor/master] raise AuthDirFastGuarantee from 20KB to 100KB
by arma＠torproject.org 21 Nov '11

21 Nov '11

commit fce107b11e2bd38d060224a7918d40edd4727da0 Author: Roger Dingledine <arma(a)torproject.org> Date: Wed Nov 16 22:08:01 2011 -0500 raise AuthDirFastGuarantee from 20KB to 100KB This patch reverts part of 39ceda7e05d7 (where it used to be 100KB). --- changes/bug4489 | 8 ++++++++ src/or/config.c | 2 +- 2 files changed, 9 insertions(+), 1 deletions(-) diff --git a/changes/bug4489 b/changes/bug4489 new file mode 100644 index 0000000..0f976c8 --- /dev/null +++ b/changes/bug4489 @@ -0,0 +1,8 @@ + o Major bugfixes (performance): + - Remove the artificially low cutoff of 20KB to guarantee the Fast + flag. In the past few years the average relay speed has picked + up, and while the "top 7/8 of the network get the Fast flag" and + "all relays with 20KB or more of capacity get the Fast flag" rules + used to have the same result, now the top 7/8 of the network has + a capacity more like 32KB. Bugfix on 0.2.1.14-rc. Fixes bug 4489. + diff --git a/src/or/config.c b/src/or/config.c index 7cbadc2..06d7d5c 100644 --- a/src/or/config.c +++ b/src/or/config.c @@ -184,7 +184,7 @@ static config_var_t _option_vars[] = { V(AuthDirBadDir, LINELIST, NULL), V(AuthDirBadExit, LINELIST, NULL), V(AuthDirInvalid, LINELIST, NULL), - V(AuthDirFastGuarantee, MEMUNIT, "20 KB"), + V(AuthDirFastGuarantee, MEMUNIT, "100 KB"), V(AuthDirGuardBWGuarantee, MEMUNIT, "250 KB"), V(AuthDirReject, LINELIST, NULL), V(AuthDirRejectUnlisted, BOOL, "0"),

1 0

[tor/master] update the man page for the new AuthDirFastGuarantee value
by arma＠torproject.org 21 Nov '11

21 Nov '11

commit 023d8b6cf8116919987500853f22f0a4a632d99f Author: Roger Dingledine <arma(a)torproject.org> Date: Mon Nov 21 18:45:44 2011 -0500 update the man page for the new AuthDirFastGuarantee value --- doc/tor.1.txt | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/doc/tor.1.txt b/doc/tor.1.txt index bc0435d..f5be391 100644 --- a/doc/tor.1.txt +++ b/doc/tor.1.txt @@ -1409,7 +1409,7 @@ DIRECTORY AUTHORITY SERVER OPTIONS **AuthDirFastGuarantee** __N__ **bytes**|**KB**|**MB**|**GB**:: Authoritative directories only. If non-zero, always vote the Fast flag for any relay advertising this amount of capacity or - more. (Default: 20 KB) + more. (Default: 100 KB) **AuthDirGuardBWGuarantee** __N__ **bytes**|**KB**|**MB**|**GB**:: Authoritative directories only. If non-zero, this advertised capacity

1 0

[tor/master] Only call cull_wedged_cpuworkers once every 60 seconds.
by arma＠torproject.org 21 Nov '11

21 Nov '11

commit 8e388bc39ceb9b1a642359005b320cdc994f8a4e Author: Nick Mathewson <nickm(a)torproject.org> Date: Sat Nov 19 18:29:42 2011 -0500 Only call cull_wedged_cpuworkers once every 60 seconds. The function is over 10 or 20% on some of Moritz's profiles, depending on how you could. Since it's checking for a multi-hour timeout, this is safe to do. Fixes bug 4518. --- changes/bug4518 | 4 ++++ src/or/cpuworker.c | 14 ++++++++++++-- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/changes/bug4518 b/changes/bug4518 new file mode 100644 index 0000000..8dcb93b --- /dev/null +++ b/changes/bug4518 @@ -0,0 +1,4 @@ + o Minor bugfixes (performance): + - Avoid frequent calls to the fairly expensive cull_wedged_cpuworkers + function. This was eating up hideously large amounts of time on some + busy servers. Fixes bug 4518. diff --git a/src/or/cpuworker.c b/src/or/cpuworker.c index c5e4863..9d196d3 100644 --- a/src/or/cpuworker.c +++ b/src/or/cpuworker.c @@ -446,9 +446,19 @@ assign_onionskin_to_cpuworker(connection_t *cpuworker, { char qbuf[1]; char tag[TAG_LEN]; + time_t now = approx_time(); + static time_t last_culled_cpuworkers = 0; - cull_wedged_cpuworkers(); - spawn_enough_cpuworkers(); + /* Checking for wedged cpuworkers requires a linear search over all + * connections, so let's do it only once a minute. + */ +#define CULL_CPUWORKERS_INTERVAL 60 + + if (last_culled_cpuworkers + CULL_CPUWORKERS_INTERVAL <= now) { + cull_wedged_cpuworkers(); + spawn_enough_cpuworkers(); + last_culled_cpuworkers = now; + } if (1) { if (num_cpuworkers_busy == num_cpuworkers) {

1 0