- tor-commits - lists.torproject.org

[vidalia/alpha] Adds a warning regarding plaintext storage of the passphrase
by chiiph＠torproject.org 23 Jan '12

23 Jan '12

commit 500b509451890d203c2dfb9252e4b08c05ebb968 Author: Tomás Touceda <chiiph(a)torproject.org> Date: Thu Jan 19 15:40:11 2012 -0300 Adds a warning regarding plaintext storage of the passphrase --- src/vidalia/config/AdvancedPage.cpp | 11 +++++++++++ src/vidalia/config/AdvancedPage.h | 3 +++ src/vidalia/config/AdvancedPage.ui | 14 ++++++++++++-- 3 files changed, 26 insertions(+), 2 deletions(-) diff --git a/src/vidalia/config/AdvancedPage.cpp b/src/vidalia/config/AdvancedPage.cpp index b4e5827..ebee44f 100644 --- a/src/vidalia/config/AdvancedPage.cpp +++ b/src/vidalia/config/AdvancedPage.cpp @@ -60,6 +60,8 @@ AdvancedPage::AdvancedPage(QWidget *parent) this, SLOT(authMethodChanged(int))); connect(ui.chkRandomPassword, SIGNAL(toggled(bool)), ui.linePassword, SLOT(setDisabled(bool))); + connect(ui.chkRandomPassword, SIGNAL(toggled(bool)), + this, SLOT(displayWarning(bool))); connect(ui.btnEditTorConfig, SIGNAL(clicked()), this, SLOT(displayTorrcDialog())); connect(ui.rdoControlPort, SIGNAL(toggled(bool)), this, SLOT(toggleControl(bool))); @@ -257,6 +259,7 @@ AdvancedPage::authMethodChanged(int index) bool usePassword = (indexToAuthMethod(index) == TorSettings::PasswordAuth); ui.linePassword->setEnabled(usePassword && !ui.chkRandomPassword->isChecked()); ui.chkRandomPassword->setEnabled(usePassword); + ui.lblWarn->setVisible((ui.chkRandomPassword->checkState() == Qt::Unchecked) and usePassword); } /** Returns the authentication method for the given <b>index</b>. */ @@ -432,3 +435,11 @@ AdvancedPage::toggleAuto(bool) ui.label->setVisible(!ui.chkAuto->isChecked()); ui.lineControlPort->setVisible(!ui.chkAuto->isChecked()); } + +void +AdvancedPage::displayWarning(bool checked) +{ + ui.lblWarn->setVisible(!checked and + indexToAuthMethod(ui.cmbAuthMethod->currentIndex()) == + TorSettings::PasswordAuth); +} diff --git a/src/vidalia/config/AdvancedPage.h b/src/vidalia/config/AdvancedPage.h index 4510310..df2587f 100644 --- a/src/vidalia/config/AdvancedPage.h +++ b/src/vidalia/config/AdvancedPage.h @@ -78,6 +78,9 @@ private slots: /** Called when the user checks "Configure ControlPort automatically" */ void toggleAuto(bool); + /** Called when the user checks "Randomly Generate" checkbox */ + void displayWarning(bool); + private: /** Returns the authentication method for the given <b>index</b>. */ TorSettings::AuthenticationMethod indexToAuthMethod(int index); diff --git a/src/vidalia/config/AdvancedPage.ui b/src/vidalia/config/AdvancedPage.ui index 7776a18..664d322 100644 --- a/src/vidalia/config/AdvancedPage.ui +++ b/src/vidalia/config/AdvancedPage.ui @@ -6,8 +6,8 @@ <rect> <x>0</x> <y>0</y> - <width>578</width> - <height>543</height> + <width>586</width> + <height>522</height> </rect> </property> <property name="contextMenuPolicy"> @@ -249,6 +249,16 @@ </item> </layout> </item> + <item> + <widget class="QLabel" name="lblWarn"> + <property name="text"> + <string>WARNING: If you hand pick the password it will be saved as plain text in Vidalia's configuration file. Using a random password is safer.</string> + </property> + <property name="wordWrap"> + <bool>true</bool> + </property> + </widget> + </item> </layout> </widget> </item>

1 0

[vidalia/alpha] Add a changes file
by chiiph＠torproject.org 23 Jan '12

23 Jan '12

commit 40156d7345188d1c5aac5d866b41f10c945733a8 Author: Tomás Touceda <chiiph(a)torproject.org> Date: Mon Jan 23 10:59:18 2012 -0300 Add a changes file --- changes/bug3146 | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/changes/bug3146 b/changes/bug3146 new file mode 100644 index 0000000..5efbf87 --- /dev/null +++ b/changes/bug3146 @@ -0,0 +1,2 @@ + o Add an option in the Tor menu to exit the application. Fixes bug + 3146. \ No newline at end of file

1 0

[vidalia/alpha] Add a changes file
by chiiph＠torproject.org 23 Jan '12

23 Jan '12

commit d303f9affa0a788124b269548b1b8b72ab095da7 Author: Tomás Touceda <chiiph(a)torproject.org> Date: Mon Jan 23 11:10:23 2012 -0300 Add a changes file --- changes/bug4833 | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/changes/bug4833 b/changes/bug4833 new file mode 100644 index 0000000..2b31765 --- /dev/null +++ b/changes/bug4833 @@ -0,0 +1,2 @@ + o Sets __ReloadTorrcOnSIGHUP to 0 if SAVECONF failed, which means + the user can't write the torrc file. Fixes bug 4833. \ No newline at end of file

1 0

[vidalia/alpha] Merge branch 'bug3064_passphrase' into alpha
by chiiph＠torproject.org 23 Jan '12

23 Jan '12

commit e25686f77ff06874445d3c25f23cefa9ff6c5c61 Merge: 7041eb8 f927240 Author: Tomás Touceda <chiiph(a)torproject.org> Date: Mon Jan 23 10:59:53 2012 -0300 Merge branch 'bug3064_passphrase' into alpha changes/bug3064 | 2 ++ src/vidalia/config/AdvancedPage.cpp | 11 +++++++++++ src/vidalia/config/AdvancedPage.h | 3 +++ src/vidalia/config/AdvancedPage.ui | 14 ++++++++++++-- 4 files changed, 28 insertions(+), 2 deletions(-)

1 0

[vidalia/alpha] Merge branch 'bug3146_exit' into alpha
by chiiph＠torproject.org 23 Jan '12

23 Jan '12

commit 264fcce23e2f67690955e246bfb9d4d91f6cc513 Merge: e25686f 40156d7 Author: Tomás Touceda <chiiph(a)torproject.org> Date: Mon Jan 23 10:59:59 2012 -0300 Merge branch 'bug3146_exit' into alpha changes/bug3146 | 2 ++ src/vidalia/MainWindow.cpp | 2 ++ 2 files changed, 4 insertions(+), 0 deletions(-)

1 0

[vidalia/alpha] Merge branch 'bug4833_sighuptorrc' into alpha
by chiiph＠torproject.org 23 Jan '12

23 Jan '12

commit d10bf241430e8ad22a9c11d6579a4f8dc4d75805 Merge: 3a16b0d d303f9a Author: Tomás Touceda <chiiph(a)torproject.org> Date: Mon Jan 23 11:10:44 2012 -0300 Merge branch 'bug4833_sighuptorrc' into alpha changes/bug4833 | 2 ++ src/torcontrol/TorControl.cpp | 9 ++++++++- 2 files changed, 10 insertions(+), 1 deletions(-)

1 0

[vidalia/alpha] Merge branch 'bug3463_takeownership' into alpha
by chiiph＠torproject.org 23 Jan '12

23 Jan '12

commit 3a16b0dcdc37e42116d3d0b1555a5aea9e2b9ee0 Merge: 264fcce 12d4e66 Author: Tomás Touceda <chiiph(a)torproject.org> Date: Mon Jan 23 11:05:50 2012 -0300 Merge branch 'bug3463_takeownership' into alpha changes/bug3463 | 3 +++ src/torcontrol/TorControl.cpp | 7 +++++++ src/torcontrol/TorControl.h | 3 +++ src/vidalia/MainWindow.cpp | 7 +++++++ 4 files changed, 20 insertions(+), 0 deletions(-)

1 0

[vidalia/alpha] Merge branch 'bug4656_squeeze' into alpha
by chiiph＠torproject.org 23 Jan '12

23 Jan '12

commit 04a5994272ef504734dca7280dfe9ea919cbbb9d Merge: d10bf24 4c2fa1a Author: Tomás Touceda <chiiph(a)torproject.org> Date: Mon Jan 23 11:15:52 2012 -0300 Merge branch 'bug4656_squeeze' into alpha changes/bug4656 | 2 ++ src/vidalia/config/ServerPage.ui | 32 +++++++++++++++++++------------- 2 files changed, 21 insertions(+), 13 deletions(-)

1 0

[vidalia/alpha] Add a changes file
by chiiph＠torproject.org 23 Jan '12

23 Jan '12

commit 4c2fa1af0065faf09803edf0210e9d5a177aa03d Author: Tomás Touceda <chiiph(a)torproject.org> Date: Mon Jan 23 11:15:01 2012 -0300 Add a changes file --- changes/bug4656 | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/changes/bug4656 b/changes/bug4656 new file mode 100644 index 0000000..d958b92 --- /dev/null +++ b/changes/bug4656 @@ -0,0 +1,2 @@ + o Sets the preferred size for the GUI layout so it doesn't squeeze + widges when the size isn't big enough. Fixes bug 4656. \ No newline at end of file

1 0

[vidalia/alpha] Add a changes file
by chiiph＠torproject.org 23 Jan '12

23 Jan '12

commit 12d4e66cf906fe1ad315f32e9d244d209fd0402a Author: Tomás Touceda <chiiph(a)torproject.org> Date: Mon Jan 23 11:05:20 2012 -0300 Add a changes file --- changes/bug3463 | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/changes/bug3463 b/changes/bug3463 new file mode 100644 index 0000000..3e23e08 --- /dev/null +++ b/changes/bug3463 @@ -0,0 +1,3 @@ + o Uses TAKEOWNERSHIP and __OwningControllerProcess to avoid leaving + tor running in background if Vidalia exits unexpectedly. Fixes bug + 3463. \ No newline at end of file

1 0