- tor-commits - lists.torproject.org

[tor/maint-0.2.3] Clean up check-spaces block; make it cover the right files
by nickm＠torproject.org 28 Jun '12

28 Jun '12

commit aad40483b3b7e9a26a0324b7c86b496fb2f4de87 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Jun 28 11:04:52 2012 -0400 Clean up check-spaces block; make it cover the right files --- Makefile.am | 15 ++++++++------- 1 files changed, 8 insertions(+), 7 deletions(-) diff --git a/Makefile.am b/Makefile.am index b8d18d4..a80763d 100644 --- a/Makefile.am +++ b/Makefile.am @@ -54,13 +54,14 @@ test: all # eventdns.[hc], tinytest*.[ch] check-spaces: ./contrib/checkSpace.pl -C \ - src/common/*.h \ - src/common/[^asO]*.c \ - src/common/address.c \ - src/or/[^e]*.[ch] \ - src/or/eventdns_tor.h \ - src/test/test*.[ch] \ - src/tools/*.[ch] \ + src/common/*.h \ + src/common/[^asO]*.c \ + src/common/address.c \ + src/or/[^e]*.[ch] \ + src/or/eventdns_tor.h \ + src/test/test*.[ch] \ + src/test/[^t]*.[ch] \ + src/tools/*.[ch] \ src/tools/tor-fw-helper/*.[ch] check-docs:

1 0

[tor/master] Fix GETINFO address-mappings/... with wildcarded addresses.
by nickm＠torproject.org 28 Jun '12

28 Jun '12

commit 28c42fe029a2a6029b17cc35821d82ba2b9bf318 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Jun 27 23:55:01 2012 -0400 Fix GETINFO address-mappings/... with wildcarded addresses. --- changes/bug6244_part2 | 4 ++++ src/or/connection_edge.c | 13 +++++++++---- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/changes/bug6244_part2 b/changes/bug6244_part2 new file mode 100644 index 0000000..ffeb5cd --- /dev/null +++ b/changes/bug6244_part2 @@ -0,0 +1,4 @@ + o Minor bugfixes: + - When formatting wildcarded address mappings for the controller, + be sure to include "*." as appropriate. Partial fix for bug 6244; + bugfix on 0.2.3.9-alpha. diff --git a/src/or/connection_edge.c b/src/or/connection_edge.c index 9892078..3c8b4bc 100644 --- a/src/or/connection_edge.c +++ b/src/or/connection_edge.c @@ -1702,17 +1702,22 @@ addressmap_get_mappings(smartlist_t *sl, time_t min_expires, addressmap_ent_remove(key, val); continue; } else if (val->new_address) { + const char *src_wc = val->src_wildcard ? "*." : ""; + const char *dst_wc = val->dst_wildcard ? "*." : ""; if (want_expiry) { if (val->expires < 3 || val->expires == TIME_MAX) - smartlist_add_asprintf(sl, "%s %s NEVER", key, val->new_address); + smartlist_add_asprintf(sl, "%s%s %s%s NEVER", + src_wc, key, dst_wc, val->new_address); else { char time[ISO_TIME_LEN+1]; format_iso_time(time, val->expires); - smartlist_add_asprintf(sl, "%s %s \"%s\"", key, val->new_address, - time); + smartlist_add_asprintf(sl, "%s%s %s%s \"%s\"", + src_wc, key, dst_wc, val->new_address, + time); } } else { - smartlist_add_asprintf(sl, "%s %s", key, val->new_address); + smartlist_add_asprintf(sl, "%s%s %s%s", + src_wc, key, dst_wc, val->new_address); } } }

1 0

[tor/master] Merge remote-tracking branch 'public/bug6244_part2' into maint-0.2.3
by nickm＠torproject.org 28 Jun '12

28 Jun '12

commit 217862b3172490d5a620d947d7d56be47ccf1dde Merge: dc9dd23 28c42fe Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Jun 28 10:49:32 2012 -0400 Merge remote-tracking branch 'public/bug6244_part2' into maint-0.2.3 changes/bug6244_part2 | 4 ++++ src/or/connection_edge.c | 13 +++++++++---- 2 files changed, 13 insertions(+), 4 deletions(-)

1 0

[tor/master] Merge remote-tracking branch 'origin/maint-0.2.3'
by nickm＠torproject.org 28 Jun '12

28 Jun '12

commit 96746e39f6623d025e1ffae518761ecca4579168 Merge: d4a64fd 217862b Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Jun 28 10:57:23 2012 -0400 Merge remote-tracking branch 'origin/maint-0.2.3' changes/bug6244_part2 | 4 ++++ src/or/connection_edge.c | 13 +++++++++---- 2 files changed, 13 insertions(+), 4 deletions(-)

1 0

[tor/maint-0.2.3] Fix GETINFO address-mappings/... with wildcarded addresses.
by nickm＠torproject.org 28 Jun '12

28 Jun '12

commit 28c42fe029a2a6029b17cc35821d82ba2b9bf318 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Jun 27 23:55:01 2012 -0400 Fix GETINFO address-mappings/... with wildcarded addresses. --- changes/bug6244_part2 | 4 ++++ src/or/connection_edge.c | 13 +++++++++---- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/changes/bug6244_part2 b/changes/bug6244_part2 new file mode 100644 index 0000000..ffeb5cd --- /dev/null +++ b/changes/bug6244_part2 @@ -0,0 +1,4 @@ + o Minor bugfixes: + - When formatting wildcarded address mappings for the controller, + be sure to include "*." as appropriate. Partial fix for bug 6244; + bugfix on 0.2.3.9-alpha. diff --git a/src/or/connection_edge.c b/src/or/connection_edge.c index 9892078..3c8b4bc 100644 --- a/src/or/connection_edge.c +++ b/src/or/connection_edge.c @@ -1702,17 +1702,22 @@ addressmap_get_mappings(smartlist_t *sl, time_t min_expires, addressmap_ent_remove(key, val); continue; } else if (val->new_address) { + const char *src_wc = val->src_wildcard ? "*." : ""; + const char *dst_wc = val->dst_wildcard ? "*." : ""; if (want_expiry) { if (val->expires < 3 || val->expires == TIME_MAX) - smartlist_add_asprintf(sl, "%s %s NEVER", key, val->new_address); + smartlist_add_asprintf(sl, "%s%s %s%s NEVER", + src_wc, key, dst_wc, val->new_address); else { char time[ISO_TIME_LEN+1]; format_iso_time(time, val->expires); - smartlist_add_asprintf(sl, "%s %s \"%s\"", key, val->new_address, - time); + smartlist_add_asprintf(sl, "%s%s %s%s \"%s\"", + src_wc, key, dst_wc, val->new_address, + time); } } else { - smartlist_add_asprintf(sl, "%s %s", key, val->new_address); + smartlist_add_asprintf(sl, "%s%s %s%s", + src_wc, key, dst_wc, val->new_address); } } }

1 0

[tor/maint-0.2.3] Merge remote-tracking branch 'public/bug6244_part2' into maint-0.2.3
by nickm＠torproject.org 28 Jun '12

28 Jun '12

commit 217862b3172490d5a620d947d7d56be47ccf1dde Merge: dc9dd23 28c42fe Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Jun 28 10:49:32 2012 -0400 Merge remote-tracking branch 'public/bug6244_part2' into maint-0.2.3 changes/bug6244_part2 | 4 ++++ src/or/connection_edge.c | 13 +++++++++---- 2 files changed, 13 insertions(+), 4 deletions(-)

1 0

[tor/master] Downgrade 'Got a certificate, but we already have it' log message from warning to info, except when we're a dirauth (fixes bug 5238)
by nickm＠torproject.org 28 Jun '12

28 Jun '12

commit bdc8270280b345f0e02a6615f8670f3c47d99a22 Author: Andrea Shepard <andrea(a)persephoneslair.org> Date: Thu Jun 28 00:21:06 2012 -0700 Downgrade 'Got a certificate, but we already have it' log message from warning to info, except when we're a dirauth (fixes bug 5238) --- changes/bug5238 | 3 +++ src/or/routerlist.c | 15 ++++++++++++--- 2 files changed, 15 insertions(+), 3 deletions(-) diff --git a/changes/bug5238 b/changes/bug5238 new file mode 100644 index 0000000..2f18707 --- /dev/null +++ b/changes/bug5238 @@ -0,0 +1,3 @@ + o Minor bugfixes: + - Downgrade "Got a certificate, but we already have it" log mesages from + warning to info, except when we're a dirauth. diff --git a/src/or/routerlist.c b/src/or/routerlist.c index 490c123..8349b7a 100644 --- a/src/or/routerlist.c +++ b/src/or/routerlist.c @@ -217,9 +217,18 @@ trusted_dirs_load_certs_from_string(const char *contents, int from_store, * probably means we wanted a different secret key or we are trying to * replace an expired cert that has not in fact been updated. */ if (!from_store) { - log_warn(LD_DIR, "Got a certificate for %s, but we already have it. " - "Maybe they haven't updated it. Waiting for a while.", - ds ? ds->nickname : "an old or new authority"); + if (authdir_mode(get_options())) { + log_warn(LD_DIR, + "Got a certificate for %s, but we already have it. " + "Maybe they haven't updated it. Waiting for a while.", + ds ? ds->nickname : "an old or new authority"); + } else { + log_info(LD_DIR, + "Got a certificate for %s, but we already have it. " + "Maybe they haven't updated it. Waiting for a while.", + ds ? ds->nickname : "an old or new authority"); + } + authority_cert_dl_failed(cert->cache_info.identity_digest, 404); }

1 0

[tor/master] Add version and bug number to 5238 changes file
by nickm＠torproject.org 28 Jun '12

28 Jun '12

commit dc9dd2324b848643908082442207469c50a46f43 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Jun 28 10:45:56 2012 -0400 Add version and bug number to 5238 changes file --- changes/bug5238 | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/changes/bug5238 b/changes/bug5238 index 2f18707..866f796 100644 --- a/changes/bug5238 +++ b/changes/bug5238 @@ -1,3 +1,4 @@ o Minor bugfixes: - Downgrade "Got a certificate, but we already have it" log mesages from - warning to info, except when we're a dirauth. + warning to info, except when we're a dirauth. Fixes bug #5238; bugfix + on 0.2.1.7-alpha.

1 0

[tor/master] Merge remote-tracking branch 'origin/maint-0.2.3'
by nickm＠torproject.org 28 Jun '12

28 Jun '12

commit d4a64fdc02e7aa6dc30dcb3cf15f3d6cf9e74f20 Merge: 5a73df0 dc9dd23 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Jun 28 10:48:06 2012 -0400 Merge remote-tracking branch 'origin/maint-0.2.3' changes/bug5238 | 4 ++++ src/or/routerlist.c | 15 ++++++++++++--- 2 files changed, 16 insertions(+), 3 deletions(-)

1 0

[tor/maint-0.2.3] Downgrade 'Got a certificate, but we already have it' log message from warning to info, except when we're a dirauth (fixes bug 5238)
by nickm＠torproject.org 28 Jun '12

28 Jun '12

commit bdc8270280b345f0e02a6615f8670f3c47d99a22 Author: Andrea Shepard <andrea(a)persephoneslair.org> Date: Thu Jun 28 00:21:06 2012 -0700 Downgrade 'Got a certificate, but we already have it' log message from warning to info, except when we're a dirauth (fixes bug 5238) --- changes/bug5238 | 3 +++ src/or/routerlist.c | 15 ++++++++++++--- 2 files changed, 15 insertions(+), 3 deletions(-) diff --git a/changes/bug5238 b/changes/bug5238 new file mode 100644 index 0000000..2f18707 --- /dev/null +++ b/changes/bug5238 @@ -0,0 +1,3 @@ + o Minor bugfixes: + - Downgrade "Got a certificate, but we already have it" log mesages from + warning to info, except when we're a dirauth. diff --git a/src/or/routerlist.c b/src/or/routerlist.c index 490c123..8349b7a 100644 --- a/src/or/routerlist.c +++ b/src/or/routerlist.c @@ -217,9 +217,18 @@ trusted_dirs_load_certs_from_string(const char *contents, int from_store, * probably means we wanted a different secret key or we are trying to * replace an expired cert that has not in fact been updated. */ if (!from_store) { - log_warn(LD_DIR, "Got a certificate for %s, but we already have it. " - "Maybe they haven't updated it. Waiting for a while.", - ds ? ds->nickname : "an old or new authority"); + if (authdir_mode(get_options())) { + log_warn(LD_DIR, + "Got a certificate for %s, but we already have it. " + "Maybe they haven't updated it. Waiting for a while.", + ds ? ds->nickname : "an old or new authority"); + } else { + log_info(LD_DIR, + "Got a certificate for %s, but we already have it. " + "Maybe they haven't updated it. Waiting for a while.", + ds ? ds->nickname : "an old or new authority"); + } + authority_cert_dl_failed(cert->cache_info.identity_digest, 404); }

1 0