- tor-commits - lists.torproject.org

[tor/maint-0.2.3] changes file for bug 6436.
by nickm＠torproject.org 20 Jul '12

20 Jul '12

commit 6cf8e38eca78bfb5d4fd38733deb5b358ac4fdea Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Jul 20 09:50:19 2012 -0400 changes file for bug 6436. --- changes/bug6436 | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/changes/bug6436 b/changes/bug6436 new file mode 100644 index 0000000..2c163df --- /dev/null +++ b/changes/bug6436 @@ -0,0 +1,3 @@ + o Minor features: + - Provide a better error message about possible OSX Asciidoc failure + reasons. Fix for bug 6436.

1 0

[tor/maint-0.2.3] Clarify how to build asciidoc files using homebrew on Mac OS X
by nickm＠torproject.org 20 Jul '12

20 Jul '12

commit 5b853612fbc928e9477b06095838e76f37bce6fc Author: Steven Murdoch <Steven.Murdoch(a)cl.cam.ac.uk> Date: Fri Jul 20 14:29:20 2012 +0100 Clarify how to build asciidoc files using homebrew on Mac OS X --- doc/asciidoc-helper.sh | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/doc/asciidoc-helper.sh b/doc/asciidoc-helper.sh index 33e1360..dd420f7 100755 --- a/doc/asciidoc-helper.sh +++ b/doc/asciidoc-helper.sh @@ -54,7 +54,9 @@ You need a working asciidoc installed to be able to build the manpage. a2x is installed, but for some reason it isn't working. Sometimes This happens because required docbook support files are missing. Please install docbook-xsl, docbook-xml, and libxml2-utils (Debian) or -similar. +similar. If you use homebrew on Mac OS X, install the docbook formula +and add "export XML_CATALOG_FILES=/usr/local/etc/xml/catalog" to your +.bashrc Alternatively, to build without manpages, use the --disable-asciidoc argument when calling configure.

1 0

[translation/vidalia_alpha] Update translations for vidalia_alpha
by translation＠torproject.org 20 Jul '12

20 Jul '12

commit 5b3092eaec6644421a4fb9154b35aa2df5e66c27 Author: Translation commit bot <translation(a)torproject.org> Date: Fri Jul 20 12:45:10 2012 +0000 Update translations for vidalia_alpha --- tr/vidalia_tr.po | 46 +++++++++++++++++++++++----------------------- 1 files changed, 23 insertions(+), 23 deletions(-) diff --git a/tr/vidalia_tr.po b/tr/vidalia_tr.po index 6fa9224..8733f63 100644 --- a/tr/vidalia_tr.po +++ b/tr/vidalia_tr.po @@ -7,7 +7,7 @@ msgstr "" "Project-Id-Version: The Tor Project\n" "Report-Msgid-Bugs-To: https://trac.torproject.org/projects/tor\n" "POT-Creation-Date: 2012-03-21 17:46+0000\n" -"PO-Revision-Date: 2012-07-20 07:47+0000\n" +"PO-Revision-Date: 2012-07-20 12:44+0000\n" "Last-Translator: erg26 <ergungorler(a)gmail.com>\n" "Language-Team: translations(a)vidalia-project.net\n" "MIME-Version: 1.0\n" @@ -2659,11 +2659,11 @@ msgstr "Tip:" msgctxt "NetworkPage" msgid "You must select the proxy type." -msgstr "" +msgstr "Vekil sunucu türünü seçmelisiniz." msgctxt "NetworkPage" msgid "SOCKS 4" -msgstr "" +msgstr "SOCKS 4" msgctxt "NetworkPage" msgid "SOCKS 5" @@ -3510,19 +3510,19 @@ msgstr "" msgctxt "StatusTab" msgid "Status" -msgstr "" +msgstr "Durum" msgctxt "StatusTab" msgid "Message Log" -msgstr "" +msgstr "Mesaj Günlüğü" msgctxt "StatusTab" msgid "Tor Status" -msgstr "" +msgstr "Tor Durumu" msgctxt "StatusTab" msgid "Show on startup" -msgstr "" +msgstr "Başlangıçta göster" msgctxt "Stream" msgid "New" @@ -3564,7 +3564,7 @@ msgctxt "TorControl" msgid "" "Vidalia has not started Tor. You need to stop Tor through the interface you " "started it." -msgstr "" +msgstr "Vidalia Tor 'u başlatmadı. Tor başlattığınız arayüzü kullanarak durdurmalısınız." msgctxt "TorControl" msgid "Start failed: %1" @@ -3600,63 +3600,63 @@ msgstr "Kontrol şifresinin hash kodunda hata oluştu." msgctxt "TorrcDialog" msgid "Editing torrc" -msgstr "" +msgstr "Torrc düzenleniyor" msgctxt "TorrcDialog" msgid "Cut" -msgstr "" +msgstr "Kes" msgctxt "TorrcDialog" msgid "Copy" -msgstr "" +msgstr "Kopyala" msgctxt "TorrcDialog" msgid "Paste" -msgstr "" +msgstr "Yapıştır" msgctxt "TorrcDialog" msgid "Undo" -msgstr "" +msgstr "Geri Al" msgctxt "TorrcDialog" msgid "Redo" -msgstr "" +msgstr "Yeniden Yap" msgctxt "TorrcDialog" msgid "Select All" -msgstr "" +msgstr "Hepsini Seç" msgctxt "TorrcDialog" msgid "Error" -msgstr "" +msgstr "Hata" msgctxt "TorrcDialog" msgid "An error ocurred while opening torrc file" -msgstr "" +msgstr "Torrc dosyasını açarken bir hata oluştu." msgctxt "TorrcDialog" msgid "Ctrl+X" -msgstr "" +msgstr "Ctrl+X" msgctxt "TorrcDialog" msgid "Ctrl+C" -msgstr "" +msgstr "Ctrl+C" msgctxt "TorrcDialog" msgid "Ctrl+V" -msgstr "" +msgstr "Ctrl+V" msgctxt "TorrcDialog" msgid "Ctrl+Z" -msgstr "" +msgstr "Ctrl+Z" msgctxt "TorrcDialog" msgid "Ctrl+Shift+Z" -msgstr "" +msgstr "Ctrl+Shift+Z" msgctxt "TorrcDialog" msgid "Ctrl+A" -msgstr "" +msgstr "Ctrl+A" msgctxt "UPNPControl" msgid "Success"

1 0

[translation/vidalia_alpha] Update translations for vidalia_alpha
by translation＠torproject.org 20 Jul '12

20 Jul '12

commit 1400cf45bb440d98d8babead30df480dfc3dcb95 Author: Translation commit bot <translation(a)torproject.org> Date: Fri Jul 20 08:15:14 2012 +0000 Update translations for vidalia_alpha --- tr/vidalia_tr.po | 18 +++++++++--------- 1 files changed, 9 insertions(+), 9 deletions(-) diff --git a/tr/vidalia_tr.po b/tr/vidalia_tr.po index f387bef..6fa9224 100644 --- a/tr/vidalia_tr.po +++ b/tr/vidalia_tr.po @@ -7,7 +7,7 @@ msgstr "" "Project-Id-Version: The Tor Project\n" "Report-Msgid-Bugs-To: https://trac.torproject.org/projects/tor\n" "POT-Creation-Date: 2012-03-21 17:46+0000\n" -"PO-Revision-Date: 2012-07-20 05:58+0000\n" +"PO-Revision-Date: 2012-07-20 07:47+0000\n" "Last-Translator: erg26 <ergungorler(a)gmail.com>\n" "Language-Team: translations(a)vidalia-project.net\n" "MIME-Version: 1.0\n" @@ -2001,7 +2001,7 @@ msgstr "Ayarları yeniden yüklerken hata oluştu" msgctxt "MainWindow" msgid "Vidalia was unable to reload Tor's configuration." -msgstr "" +msgstr "Vidalia Tor ayarlarını yeniden yükleyemedi." msgctxt "MainWindow" msgid "No dettached tabs" @@ -2354,7 +2354,7 @@ msgstr "Yeni günlük mesajlarını otomatik kaydet" msgctxt "MessageLog" msgid "toolbar" -msgstr "" +msgstr "Araç Çubuğu" msgctxt "MessageLog" msgid "Always Save New Log Messages" @@ -2501,19 +2501,19 @@ msgstr "Ctrl+F" msgctxt "NetViewer" msgid "Network Map" -msgstr "" +msgstr "Ağ Haritası" msgctxt "NetViewer" msgid "Relay" -msgstr "" +msgstr "Anahtarlama" msgctxt "NetViewer" msgid "Connection" -msgstr "" +msgstr "Bağlantı" msgctxt "NetViewer" msgid "Status" -msgstr "" +msgstr "Durum" msgctxt "NetViewer" msgid "<a href=\"server.offline\">Why is my relay offline?</a>" @@ -2651,11 +2651,11 @@ msgstr "Yeni köprü bulmanın diğer yöntemlerini görmek için Yardım'a tık msgctxt "NetworkPage" msgid "Address:" -msgstr "" +msgstr "Adres:" msgctxt "NetworkPage" msgid "Type:" -msgstr "" +msgstr "Tip:" msgctxt "NetworkPage" msgid "You must select the proxy type."

1 0

[onionoo/master] Add path selection probabilities to details files.
by karsten＠torproject.org 20 Jul '12

20 Jul '12

commit 86fae9e607668a1768041ac6cf19ee0b41cb7aea Author: Karsten Loesing <karsten.loesing(a)gmx.net> Date: Thu Jul 19 22:32:28 2012 +0200 Add path selection probabilities to details files. --- src/org/torproject/onionoo/CurrentNodes.java | 7 + src/org/torproject/onionoo/DetailDataWriter.java | 137 ++++++++++++++++++++++ src/org/torproject/onionoo/Main.java | 1 + src/org/torproject/onionoo/Node.java | 36 ++++++ web/index.html | 48 ++++++++ 5 files changed, 229 insertions(+), 0 deletions(-) diff --git a/src/org/torproject/onionoo/CurrentNodes.java b/src/org/torproject/onionoo/CurrentNodes.java index 7c4bec8..7ef1473 100644 --- a/src/org/torproject/onionoo/CurrentNodes.java +++ b/src/org/torproject/onionoo/CurrentNodes.java @@ -250,6 +250,10 @@ public class CurrentNodes { } } + SortedMap<String, Integer> lastBandwidthWeights = null; + public SortedMap<String, Integer> getLastBandwidthWeights() { + return this.lastBandwidthWeights; + } private void updateRelayNetworkStatusConsensus( RelayNetworkStatusConsensus consensus) { long validAfterMillis = consensus.getValidAfterMillis(); @@ -268,6 +272,9 @@ public class CurrentNodes { null, validAfterMillis, orPort, dirPort, relayFlags, consensusWeight, null, null, -1L); } + if (this.lastValidAfterMillis == validAfterMillis) { + this.lastBandwidthWeights = consensus.getBandwidthWeights(); + } } public void addRelay(String nickname, String fingerprint, diff --git a/src/org/torproject/onionoo/DetailDataWriter.java b/src/org/torproject/onionoo/DetailDataWriter.java index 155c4eb..2961de9 100644 --- a/src/org/torproject/onionoo/DetailDataWriter.java +++ b/src/org/torproject/onionoo/DetailDataWriter.java @@ -13,6 +13,7 @@ import java.net.UnknownHostException; import java.text.ParseException; import java.text.SimpleDateFormat; import java.util.ArrayList; +import java.util.Arrays; import java.util.HashMap; import java.util.HashSet; import java.util.Iterator; @@ -194,6 +195,115 @@ public class DetailDataWriter { } } + public void calculatePathSelectionProbabilities( + SortedMap<String, Integer> bandwidthWeights) { + boolean consensusContainsBandwidthWeights = false; + double wgg = 0.0, wgd = 0.0, wmg = 0.0, wmm = 0.0, wme = 0.0, + wmd = 0.0, wee = 0.0, wed = 0.0; + if (bandwidthWeights != null) { + SortedSet<String> weightKeys = new TreeSet<String>(Arrays.asList( + "Wgg,Wgd,Wmg,Wmm,Wme,Wmd,Wee,Wed".split(","))); + weightKeys.removeAll(bandwidthWeights.keySet()); + if (weightKeys.isEmpty()) { + consensusContainsBandwidthWeights = true; + wgg = ((double) bandwidthWeights.get("Wgg")) / 10000.0; + wgd = ((double) bandwidthWeights.get("Wgd")) / 10000.0; + wmg = ((double) bandwidthWeights.get("Wmg")) / 10000.0; + wmm = ((double) bandwidthWeights.get("Wmm")) / 10000.0; + wme = ((double) bandwidthWeights.get("Wme")) / 10000.0; + wmd = ((double) bandwidthWeights.get("Wmd")) / 10000.0; + wee = ((double) bandwidthWeights.get("Wee")) / 10000.0; + wed = ((double) bandwidthWeights.get("Wed")) / 10000.0; + } + } + SortedMap<String, Double> + advertisedBandwidths = new TreeMap<String, Double>(), + consensusWeights = new TreeMap<String, Double>(), + guardWeights = new TreeMap<String, Double>(), + middleWeights = new TreeMap<String, Double>(), + exitWeights = new TreeMap<String, Double>(); + double totalAdvertisedBandwidth = 0.0; + double totalConsensusWeight = 0.0; + double totalGuardWeight = 0.0; + double totalMiddleWeight = 0.0; + double totalExitWeight = 0.0; + for (Map.Entry<String, Node> e : this.relays.entrySet()) { + String fingerprint = e.getKey(); + Node relay = e.getValue(); + if (!relay.getRunning()) { + continue; + } + boolean isExit = relay.getRelayFlags().contains("Exit") && + !relay.getRelayFlags().contains("BadExit"); + boolean isGuard = relay.getRelayFlags().contains("Guard"); + if (this.relayServerDescriptors.containsKey(fingerprint)) { + ServerDescriptor serverDescriptor = + this.relayServerDescriptors.get(fingerprint); + double advertisedBandwidth = (double) Math.min(Math.min( + serverDescriptor.getBandwidthBurst(), + serverDescriptor.getBandwidthObserved()), + serverDescriptor.getBandwidthRate()); + advertisedBandwidths.put(fingerprint, advertisedBandwidth); + totalAdvertisedBandwidth += advertisedBandwidth; + } + double consensusWeight = (double) relay.getConsensusWeight(); + consensusWeights.put(fingerprint, consensusWeight); + totalConsensusWeight += consensusWeight; + if (consensusContainsBandwidthWeights) { + double guardWeight = consensusWeight, + middleWeight = consensusWeight, + exitWeight = consensusWeight; + if (isGuard && isExit) { + guardWeight *= wgd; + middleWeight *= wmd; + exitWeight *= wed; + } else if (isGuard) { + guardWeight *= wgg; + middleWeight *= wmg; + exitWeight = 0.0; + } else if (isExit) { + guardWeight = 0.0; + middleWeight *= wme; + exitWeight *= wee; + } else { + guardWeight = 0.0; + middleWeight *= wmm; + exitWeight = 0.0; + } + guardWeights.put(fingerprint, guardWeight); + middleWeights.put(fingerprint, middleWeight); + exitWeights.put(fingerprint, exitWeight); + totalGuardWeight += guardWeight; + totalMiddleWeight += middleWeight; + totalExitWeight += exitWeight; + } + } + for (Map.Entry<String, Node> e : this.relays.entrySet()) { + String fingerprint = e.getKey(); + Node relay = e.getValue(); + if (advertisedBandwidths.containsKey(fingerprint)) { + relay.setAdvertisedBandwidthFraction(advertisedBandwidths.get( + fingerprint) / totalAdvertisedBandwidth); + } + if (consensusWeights.containsKey(fingerprint)) { + relay.setConsensusWeightFraction(consensusWeights.get(fingerprint) + / totalConsensusWeight); + } + if (guardWeights.containsKey(fingerprint)) { + relay.setGuardProbability(guardWeights.get(fingerprint) + / totalGuardWeight); + } + if (middleWeights.containsKey(fingerprint)) { + relay.setMiddleProbability(middleWeights.get(fingerprint) + / totalMiddleWeight); + } + if (exitWeights.containsKey(fingerprint)) { + relay.setExitProbability(exitWeights.get(fingerprint) + / totalExitWeight); + } + } + } + private long now = System.currentTimeMillis(); private Map<String, Set<ExitListEntry>> exitListEntries = new HashMap<String, Set<ExitListEntry>>(); @@ -444,6 +554,12 @@ public class DetailDataWriter { String aSName = entry.getASName(); long consensusWeight = entry.getConsensusWeight(); String hostName = entry.getHostName(); + double advertisedBandwidthFraction = + entry.getAdvertisedBandwidthFraction(); + double consensusWeightFraction = entry.getConsensusWeightFraction(); + double guardProbability = entry.getGuardProbability(); + double middleProbability = entry.getMiddleProbability(); + double exitProbability = entry.getExitProbability(); StringBuilder sb = new StringBuilder(); sb.append("{\"version\":1,\n" + "\"nickname\":\"" + nickname + "\",\n" @@ -501,6 +617,27 @@ public class DetailDataWriter { sb.append(",\n\"host_name\":\"" + escapeJSON(hostName) + "\""); } + if (advertisedBandwidthFraction >= 0.0) { + sb.append(String.format( + ",\n\"advertised_bandwidth_fraction\":%.9f", + advertisedBandwidthFraction)); + } + if (consensusWeightFraction >= 0.0) { + sb.append(String.format(",\n\"consensus_weight_fraction\":%.9f", + consensusWeightFraction)); + } + if (guardProbability >= 0.0) { + sb.append(String.format(",\n\"guard_probability\":%.9f", + guardProbability)); + } + if (middleProbability >= 0.0) { + sb.append(String.format(",\n\"middle_probability\":%.9f", + middleProbability)); + } + if (exitProbability >= 0.0) { + sb.append(String.format(",\n\"exit_probability\":%.9f", + exitProbability)); + } /* Add exit addresses if at least one of them is distinct from the * onion-routing addresses. */ diff --git a/src/org/torproject/onionoo/Main.java b/src/org/torproject/onionoo/Main.java index 5cac8de..175176c 100644 --- a/src/org/torproject/onionoo/Main.java +++ b/src/org/torproject/onionoo/Main.java @@ -24,6 +24,7 @@ public class Main { ddw.setCurrentBridges(cn.getCurrentBridges()); ddw.startReverseDomainNameLookups(); ddw.readRelayServerDescriptors(); + ddw.calculatePathSelectionProbabilities(cn.getLastBandwidthWeights()); ddw.readExitLists(); ddw.readBridgeServerDescriptors(); ddw.readBridgePoolAssignments(); diff --git a/src/org/torproject/onionoo/Node.java b/src/org/torproject/onionoo/Node.java index 88ca71c..61a26ed 100644 --- a/src/org/torproject/onionoo/Node.java +++ b/src/org/torproject/onionoo/Node.java @@ -35,6 +35,11 @@ public class Node { private boolean running; private String hostName; private long lastRdnsLookup = -1L; + private double advertisedBandwidthFraction = -1.0; + private double consensusWeightFraction = -1.0; + private double guardProbability = -1.0; + private double middleProbability = -1.0; + private double exitProbability = -1.0; public Node(String nickname, String fingerprint, String address, SortedSet<String> orAddressesAndPorts, SortedSet<String> exitAddresses, long lastSeenMillis, int orPort, @@ -194,5 +199,36 @@ public class Node { public long getLastRdnsLookup() { return this.lastRdnsLookup; } + public void setAdvertisedBandwidthFraction( + double advertisedBandwidthFraction) { + this.advertisedBandwidthFraction = advertisedBandwidthFraction; + } + public double getAdvertisedBandwidthFraction() { + return this.advertisedBandwidthFraction; + } + public void setConsensusWeightFraction(double consensusWeightFraction) { + this.consensusWeightFraction = consensusWeightFraction; + } + public double getConsensusWeightFraction() { + return this.consensusWeightFraction; + } + public void setGuardProbability(double guardProbability) { + this.guardProbability = guardProbability; + } + public double getGuardProbability() { + return this.guardProbability; + } + public void setMiddleProbability(double middleProbability) { + this.middleProbability = middleProbability; + } + public double getMiddleProbability() { + return this.middleProbability; + } + public void setExitProbability(double exitProbability) { + this.exitProbability = exitProbability; + } + public double getExitProbability() { + return this.exitProbability; + } } diff --git a/web/index.html b/web/index.html index 5788bf9..0578843 100755 --- a/web/index.html +++ b/web/index.html @@ -276,6 +276,54 @@ same family as this relay. Optional field. Omitted if empty or if descriptor containing this information cannot be found.</li> +<li>"advertised_bandwidth_fraction": +Relative advertised bandwidth of this relay compared to the total +advertised bandwidth in the network. +If there were no bandwidth authorities, this fraction would be a very +rough approximation of the probability of this relay to be selected by +clients. +Optional field. +Omitted if the relay is not running, or router descriptor containing this +information cannot be found. +Added field on July 19, 2012.</li> +<li>"consensus_weight_fraction": +Fraction of this relay's consensus weight compared to the sum of all +consensus weights in the network. +This fraction is a very rough approximation of the probability of this +relay to be selected by clients. +Optional field. +Omitted if the relay is not running. +Added field on July 19, 2012.</li> +<li>"guard_probability": +Probability of this relay to be selected for the guard position. +This probability is calculated based on consensus weights, relay flags, +and bandwidth weights in the consensus. +Path selection depends on more factors, so that this probability can only +be an approximation. +Optional field. +Omitted if the relay is not running, or the consensus does not contain +bandwidth weights. +Added field on July 19, 2012.</li> +<li>"middle_probability": +Probability of this relay to be selected for the middle position. +This probability is calculated based on consensus weights, relay flags, +and bandwidth weights in the consensus. +Path selection depends on more factors, so that this probability can only +be an approximation. +Optional field. +Omitted if the relay is not running, or the consensus does not contain +bandwidth weights. +Added field on July 19, 2012.</li> +<li>"exit_probability": +Probability of this relay to be selected for the exit position. +This probability is calculated based on consensus weights, relay flags, +and bandwidth weights in the consensus. +Path selection depends on more factors, so that this probability can only +be an approximation. +Optional field. +Omitted if the relay is not running, or the consensus does not contain +bandwidth weights. +Added field on July 19, 2012.</li> </ul> </li> <li>"bridges_published": UTC timestamp (YYYY-MM-DD hh:mm:ss) when

1 0

[translation/vidalia_alpha] Update translations for vidalia_alpha
by translation＠torproject.org 20 Jul '12

20 Jul '12

commit acbcf0071f4d436c9d1c5a37425a7882e9e70e2b Author: Translation commit bot <translation(a)torproject.org> Date: Fri Jul 20 06:15:10 2012 +0000 Update translations for vidalia_alpha --- tr/vidalia_tr.po | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tr/vidalia_tr.po b/tr/vidalia_tr.po index 3eafd48..f387bef 100644 --- a/tr/vidalia_tr.po +++ b/tr/vidalia_tr.po @@ -7,7 +7,7 @@ msgstr "" "Project-Id-Version: The Tor Project\n" "Report-Msgid-Bugs-To: https://trac.torproject.org/projects/tor\n" "POT-Creation-Date: 2012-03-21 17:46+0000\n" -"PO-Revision-Date: 2012-07-19 09:10+0000\n" +"PO-Revision-Date: 2012-07-20 05:58+0000\n" "Last-Translator: erg26 <ergungorler(a)gmail.com>\n" "Language-Team: translations(a)vidalia-project.net\n" "MIME-Version: 1.0\n" @@ -1997,7 +1997,7 @@ msgstr "Vidalia Tor 'u yeniden başlatmayı denedi, ancak başaramadı. Lütfen msgctxt "MainWindow" msgid "Error reloading configuration" -msgstr "" +msgstr "Ayarları yeniden yüklerken hata oluştu" msgctxt "MainWindow" msgid "Vidalia was unable to reload Tor's configuration."

1 0

[tor/master] Don't put unreachable IPv6 OR port in routerstatus.
by nickm＠torproject.org 19 Jul '12

19 Jul '12

commit 6d99c51f15d664ff6b33957b1043c73448a72711 Author: Linus Nordberg <linus(a)nordberg.se> Date: Thu May 10 17:08:22 2012 +0200 Don't put unreachable IPv6 OR port in routerstatus. To have only reachable ports in "a" lines. --- src/or/dirserv.c | 10 ++++++++-- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/or/dirserv.c b/src/or/dirserv.c index 2af4e68..abbc123 100644 --- a/src/or/dirserv.c +++ b/src/or/dirserv.c @@ -2468,8 +2468,14 @@ set_routerstatus_from_routerinfo(routerstatus_t *rs, strlcpy(rs->nickname, ri->nickname, sizeof(rs->nickname)); rs->or_port = ri->or_port; rs->dir_port = ri->dir_port; - tor_addr_copy(&rs->ipv6_addr, &ri->ipv6_addr); - rs->ipv6_orport = ri->ipv6_orport; + if (!tor_addr_is_null(&ri->ipv6_addr) && + node->last_reachable6 >= now - REACHABLE_TIMEOUT) { + /* There's an IPv6 OR port and it's reachable so copy it to the + routerstatus. FIXME: If we're not on IPv6, copy it regardless + of reachability. */ + tor_addr_copy(&rs->ipv6_addr, &ri->ipv6_addr); + rs->ipv6_orport = ri->ipv6_orport; + } } /** Routerstatus rs is part of a group of routers that are on

1 0

[tor/master] Move last_reachable and testing_since from routerinfo_t to node_t.
by nickm＠torproject.org 19 Jul '12

19 Jul '12

commit 631ec5c4fe4d5535d91e8e1e3597fbaa687b8790 Author: Linus Nordberg <linus(a)nordberg.se> Date: Tue Mar 27 15:00:34 2012 +0200 Move last_reachable and testing_since from routerinfo_t to node_t. --- changes/bug5529 | 3 ++ src/or/dirserv.c | 31 +++++++++++++++++----------- src/or/nodelist.c | 55 ++++++++++++++++++++++++++++++++++++++++++++++---- src/or/nodelist.h | 3 +- src/or/or.h | 17 +++++++-------- src/or/routerlist.c | 10 +------- 6 files changed, 84 insertions(+), 35 deletions(-) diff --git a/changes/bug5529 b/changes/bug5529 new file mode 100644 index 0000000..3f56e82 --- /dev/null +++ b/changes/bug5529 @@ -0,0 +1,3 @@ + o Code refactoring: + - Move last_reachable and testing_since from routerinfo_t to + node_t. Implements enhancement 5529. diff --git a/src/or/dirserv.c b/src/or/dirserv.c index e21f511..8f65b7f 100644 --- a/src/or/dirserv.c +++ b/src/or/dirserv.c @@ -988,7 +988,7 @@ dirserv_set_router_is_running(routerinfo_t *router, time_t now) answer = ! we_are_hibernating(); } else if (router->is_hibernating && (router->cache_info.published_on + - HIBERNATION_PUBLICATION_SKEW) > router->last_reachable) { + HIBERNATION_PUBLICATION_SKEW) > node->last_reachable) { /* A hibernating router is down unless we (somehow) had contact with it * since it declared itself to be hibernating. */ answer = 0; @@ -998,7 +998,7 @@ dirserv_set_router_is_running(routerinfo_t *router, time_t now) } else { /* Otherwise, a router counts as up if we found it reachable in the last REACHABLE_TIMEOUT seconds. */ - answer = (now < router->last_reachable + REACHABLE_TIMEOUT); + answer = (now < node->last_reachable + REACHABLE_TIMEOUT); } if (!answer && running_long_enough_to_decide_unreachable()) { @@ -1010,9 +1010,9 @@ dirserv_set_router_is_running(routerinfo_t *router, time_t now) it. */ time_t when = now; - if (router->last_reachable && - router->last_reachable + REACHABILITY_TEST_CYCLE_PERIOD < now) - when = router->last_reachable + REACHABILITY_TEST_CYCLE_PERIOD; + if (node->last_reachable && + node->last_reachable + REACHABILITY_TEST_CYCLE_PERIOD < now) + when = node->last_reachable + REACHABILITY_TEST_CYCLE_PERIOD; rep_hist_note_router_unreachable(router->cache_info.identity_digest, when); } @@ -3277,15 +3277,17 @@ dirserv_orconn_tls_done(const char *address, uint16_t or_port, const char *digest_rcvd) { - routerinfo_t *ri; + node_t *node = NULL; + routerinfo_t *ri = NULL; time_t now = time(NULL); tor_assert(address); tor_assert(digest_rcvd); - ri = router_get_mutable_by_digest(digest_rcvd); - - if (ri == NULL) + node = node_get_mutable_by_id(digest_rcvd); + if (node == NULL) return; + ri = node->ri; + tor_assert(ri); if (!strcasecmp(address, ri->address) && or_port == ri->or_port) { /* Found the right router. */ @@ -3302,7 +3304,7 @@ dirserv_orconn_tls_done(const char *address, else log_warn(LD_BUG, "Couldn't parse IP address \"%s\"", ri->address); rep_hist_note_router_reachable(digest_rcvd, addrp, or_port, now); - ri->last_reachable = now; + node->last_reachable = now; } } } @@ -3338,12 +3340,17 @@ dirserv_should_launch_reachability_test(const routerinfo_t *ri, void dirserv_single_reachability_test(time_t now, routerinfo_t *router) { + node_t *node = NULL; tor_addr_t router_addr; + + tor_assert(router); + node = node_get_mutable_by_id(router->cache_info.identity_digest); + tor_assert(node); log_debug(LD_OR,"Testing reachability of %s at %s:%u.", router->nickname, router->address, router->or_port); /* Remember when we started trying to determine reachability */ - if (!router->testing_since) - router->testing_since = now; + if (!node->testing_since) + node->testing_since = now; tor_addr_from_ipv4h(&router_addr, router->addr); connection_or_connect(&router_addr, router->or_port, router->cache_info.identity_digest); diff --git a/src/or/nodelist.c b/src/or/nodelist.c index d178508..1e07c82 100644 --- a/src/or/nodelist.c +++ b/src/or/nodelist.c @@ -115,13 +115,58 @@ node_get_or_create(const char *identity_digest) return node; } -/** Add ri to the nodelist. */ +/** Replace old router with new in nodelist. If + * old and new in fact are the same relays (having the + * same identity_digest) the node_t of old is used for + * new. Otherwise the node_t of old is dropped and + * new gets a new one (which might be a recycled node_t in + * case we already have one matching its identity). + */ +node_t * +nodelist_replace_routerinfo(routerinfo_t *old, routerinfo_t *new) +{ + node_t *node = NULL; + tor_assert(old); + tor_assert(new); + + if (tor_memeq(old->cache_info.identity_digest, + new->cache_info.identity_digest, DIGEST_LEN)) { + /* NEW == OLD, reuse node_t. */ + node = node_get_mutable_by_id(old->cache_info.identity_digest); + if (node) { + tor_assert(node->ri == old); + /* XXXX prop186 we may have more than one address. */ + if (!routers_have_same_or_addr(old, new)) { + /* These mustn't carry over when the address and orport + change. */ + node->last_reachable = 0; + node->testing_since = 0; + } + } + } else { + /* NEW != OLD, get a new node_t. */ + nodelist_remove_routerinfo(old); + } + node = nodelist_add_routerinfo(node, new); + + return node; +} + + +/** Add ri to the nodelist. If node_in is not NULL, use + that node rather than creating a new. */ node_t * -nodelist_add_routerinfo(routerinfo_t *ri) +nodelist_add_routerinfo(node_t *node_in, routerinfo_t *ri) { - node_t *node; - init_nodelist(); - node = node_get_or_create(ri->cache_info.identity_digest); + node_t *node = NULL; + + if (node_in) { + node = node_in; + } else { + tor_assert(ri); + init_nodelist(); + node = node_get_or_create(ri->cache_info.identity_digest); + } node->ri = ri; if (node->country == -1) diff --git a/src/or/nodelist.h b/src/or/nodelist.h index 1e9da88..b110fe5 100644 --- a/src/or/nodelist.h +++ b/src/or/nodelist.h @@ -15,7 +15,8 @@ node_t *node_get_mutable_by_id(const char *identity_digest); const node_t *node_get_by_id(const char *identity_digest); const node_t *node_get_by_hex_id(const char *identity_digest); -node_t *nodelist_add_routerinfo(routerinfo_t *ri); +node_t *nodelist_replace_routerinfo(routerinfo_t *old, routerinfo_t *new); +node_t *nodelist_add_routerinfo(node_t *node, routerinfo_t *ri); node_t *nodelist_add_microdesc(microdesc_t *md); void nodelist_set_consensus(networkstatus_t *ns); diff --git a/src/or/or.h b/src/or/or.h index 3a53e5e..a330f77 100644 --- a/src/or/or.h +++ b/src/or/or.h @@ -1793,15 +1793,6 @@ typedef struct { * things; see notes on ROUTER_PURPOSE_* macros above. */ uint8_t purpose; - - /* The below items are used only by authdirservers for - * reachability testing. */ - - /** When was the last time we could reach this OR? */ - time_t last_reachable; - /** When did we start testing reachability for this OR? */ - time_t testing_since; - } routerinfo_t; /** Information needed to keep and cache a signed extra-info document. */ @@ -2037,6 +2028,14 @@ typedef struct node_t { /** According to the geoip db what country is this router in? */ country_t country; + + /* The below items are used only by authdirservers for + * reachability testing. */ + + /** When was the last time we could reach this OR? */ + time_t last_reachable; /* IPv4 */ + /** When did we start testing reachability for this OR? */ + time_t testing_since; /* IPv4 */ } node_t; /** How many times will we try to download a router's descriptor before giving diff --git a/src/or/routerlist.c b/src/or/routerlist.c index de1a66c..f984d93 100644 --- a/src/or/routerlist.c +++ b/src/or/routerlist.c @@ -2875,7 +2875,7 @@ routerlist_insert(routerlist_t *rl, routerinfo_t *ri) &ri->cache_info); smartlist_add(rl->routers, ri); ri->cache_info.routerlist_index = smartlist_len(rl->routers) - 1; - nodelist_add_routerinfo(ri); + nodelist_add_routerinfo(NULL, ri); router_dir_info_changed(); #ifdef DEBUG_ROUTERLIST routerlist_assert_ok(rl); @@ -3104,8 +3104,7 @@ routerlist_replace(routerlist_t *rl, routerinfo_t *ri_old, tor_assert(0 <= idx && idx < smartlist_len(rl->routers)); tor_assert(smartlist_get(rl->routers, idx) == ri_old); - nodelist_remove_routerinfo(ri_old); - nodelist_add_routerinfo(ri_new); + nodelist_replace_routerinfo(ri_old, ri_new); router_dir_info_changed(); if (idx >= 0) { @@ -3442,11 +3441,6 @@ router_add_to_routerlist(routerinfo_t *router, const char **msg, /* Same key, and either new, or listed in the consensus. */ log_debug(LD_DIR, "Replacing entry for router %s", router_describe(router)); - if (routers_have_same_or_addr(router, old_router)) { - /* these carry over when the address and orport are unchanged. */ - router->last_reachable = old_router->last_reachable; - router->testing_since = old_router->testing_since; - } routerlist_replace(routerlist, old_router, router); if (!from_cache) { signed_desc_append_to_journal(&router->cache_info,

1 0

[tor/master] Don't assume that a node has routerinfo.
by nickm＠torproject.org 19 Jul '12

19 Jul '12

commit c1ff07440e67f1ae690acbfceddb6174fdb092df Author: Linus Nordberg <linus(a)nordberg.se> Date: Tue May 8 14:53:59 2012 +0200 Don't assume that a node has routerinfo. We can end up in dirserv_orconn_tls_done() with a node missing routerinfo in at least two cases -- command_process_certs_cell() and connection_or_check_valid_tls_handshake() -- and probably more. --- src/or/dirserv.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/src/or/dirserv.c b/src/or/dirserv.c index 8f65b7f..3518d9e 100644 --- a/src/or/dirserv.c +++ b/src/or/dirserv.c @@ -3284,10 +3284,9 @@ dirserv_orconn_tls_done(const char *address, tor_assert(digest_rcvd); node = node_get_mutable_by_id(digest_rcvd); - if (node == NULL) + if (node == NULL || node->ri == NULL) return; ri = node->ri; - tor_assert(ri); if (!strcasecmp(address, ri->address) && or_port == ri->or_port) { /* Found the right router. */

1 0

[tor/master] Add last_reachable and testing_since for IPv6 OR port.
by nickm＠torproject.org 19 Jul '12

19 Jul '12

commit 4cce8ab742999900a4c5f1f3f8faf13d217014e0 Author: Linus Nordberg <linus(a)nordberg.se> Date: Wed May 9 17:58:01 2012 +0200 Add last_reachable and testing_since for IPv6 OR port. --- src/or/connection_or.c | 2 +- src/or/dirserv.c | 42 +++++++++++++++++++++++++++++++----------- src/or/dirserv.h | 2 +- src/or/nodelist.c | 4 ++-- src/or/or.h | 14 +++++++++----- src/or/router.c | 20 ++++++++++++++++++++ src/or/router.h | 2 ++ src/or/routerlist.c | 4 +++- 8 files changed, 69 insertions(+), 21 deletions(-) diff --git a/src/or/connection_or.c b/src/or/connection_or.c index d016387..55ea32e 100644 --- a/src/or/connection_or.c +++ b/src/or/connection_or.c @@ -1540,7 +1540,7 @@ connection_or_client_learned_peer_id(or_connection_t *conn, return -1; } if (authdir_mode_tests_reachability(options)) { - dirserv_orconn_tls_done(conn->_base.address, conn->_base.port, + dirserv_orconn_tls_done(&conn->_base.addr, conn->_base.port, (const char*)peer_id); } diff --git a/src/or/dirserv.c b/src/or/dirserv.c index 3518d9e..ad3c45d 100644 --- a/src/or/dirserv.c +++ b/src/or/dirserv.c @@ -3273,14 +3273,15 @@ dirserv_get_routerdescs(smartlist_t *descs_out, const char *key, * Inform the reachability checker that we could get to this guy. */ void -dirserv_orconn_tls_done(const char *address, +dirserv_orconn_tls_done(const tor_addr_t *addr, uint16_t or_port, const char *digest_rcvd) { node_t *node = NULL; + tor_addr_port_t orport; routerinfo_t *ri = NULL; time_t now = time(NULL); - tor_assert(address); + tor_assert(addr); tor_assert(digest_rcvd); node = node_get_mutable_by_id(digest_rcvd); @@ -3288,22 +3289,26 @@ dirserv_orconn_tls_done(const char *address, return; ri = node->ri; - if (!strcasecmp(address, ri->address) && or_port == ri->or_port) { + tor_addr_copy(&orport.addr, addr); + orport.port = or_port; + if (router_has_orport(ri, &orport)) { /* Found the right router. */ if (!authdir_mode_bridge(get_options()) || ri->purpose == ROUTER_PURPOSE_BRIDGE) { + char addrstr[TOR_ADDR_BUF_LEN]; /* This is a bridge or we're not a bridge authorititative -- mark it as reachable. */ - tor_addr_t addr, *addrp=NULL; log_info(LD_DIRSERV, "Found router %s to be reachable at %s:%d. Yay.", router_describe(ri), - address, ri->or_port); - if (tor_addr_parse(&addr, ri->address) != -1) - addrp = &addr; - else - log_warn(LD_BUG, "Couldn't parse IP address \"%s\"", ri->address); - rep_hist_note_router_reachable(digest_rcvd, addrp, or_port, now); - node->last_reachable = now; + tor_addr_to_str(addrstr, addr, sizeof(addrstr), 1), + ri->or_port); + if (tor_addr_family(addr) == AF_INET) { + rep_hist_note_router_reachable(digest_rcvd, addr, or_port, now); + node->last_reachable = now; + } else if (tor_addr_family(addr) == AF_INET6) { + /* No rephist for IPv6. */ + node->last_reachable6 = now; + } } } } @@ -3345,6 +3350,8 @@ dirserv_single_reachability_test(time_t now, routerinfo_t *router) tor_assert(router); node = node_get_mutable_by_id(router->cache_info.identity_digest); tor_assert(node); + + /* IPv4. */ log_debug(LD_OR,"Testing reachability of %s at %s:%u.", router->nickname, router->address, router->or_port); /* Remember when we started trying to determine reachability */ @@ -3353,6 +3360,19 @@ dirserv_single_reachability_test(time_t now, routerinfo_t *router) tor_addr_from_ipv4h(&router_addr, router->addr); connection_or_connect(&router_addr, router->or_port, router->cache_info.identity_digest); + + /* Possible IPv6. */ + if (!tor_addr_is_null(&router->ipv6_addr)) { + char addrstr[TOR_ADDR_BUF_LEN]; + log_debug(LD_OR, "Testing reachability of %s at %s:%u.", + router->nickname, + tor_addr_to_str(addrstr, &router->ipv6_addr, sizeof(addrstr), 1), + router->ipv6_orport); + if (!node->testing_since6) + node->testing_since6 = now; + connection_or_connect(&router->ipv6_addr, router->ipv6_orport, + router->cache_info.identity_digest); + } } /** Auth dir server only: load balance such that we only diff --git a/src/or/dirserv.h b/src/or/dirserv.h index 22269b2..8508c93 100644 --- a/src/or/dirserv.h +++ b/src/or/dirserv.h @@ -107,7 +107,7 @@ int dirserv_get_routerdesc_fingerprints(smartlist_t *fps_out, const char *key, int is_extrainfo); int dirserv_get_routerdescs(smartlist_t *descs_out, const char *key, const char **msg); -void dirserv_orconn_tls_done(const char *address, +void dirserv_orconn_tls_done(const tor_addr_t *addr, uint16_t or_port, const char *digest_rcvd); int dirserv_should_launch_reachability_test(const routerinfo_t *ri, diff --git a/src/or/nodelist.c b/src/or/nodelist.c index 1e07c82..cb94173 100644 --- a/src/or/nodelist.c +++ b/src/or/nodelist.c @@ -139,8 +139,8 @@ nodelist_replace_routerinfo(routerinfo_t *old, routerinfo_t *new) if (!routers_have_same_or_addr(old, new)) { /* These mustn't carry over when the address and orport change. */ - node->last_reachable = 0; - node->testing_since = 0; + node->last_reachable = node->last_reachable6 = 0; + node->testing_since = node->testing_since6 = 0; } } } else { diff --git a/src/or/or.h b/src/or/or.h index a330f77..0684b9d 100644 --- a/src/or/or.h +++ b/src/or/or.h @@ -1997,13 +1997,13 @@ typedef struct node_t { routerstatus_t *rs; /* local info: copied from routerstatus, then possibly frobbed based - * on experience. Authorities set this stuff directly. */ + * on experience. Authorities set this stuff directly. Note that + * these reflect knowledge of the primary (IPv4) OR port only. */ unsigned int is_running:1; /**< As far as we know, is this OR currently * running? */ unsigned int is_valid:1; /**< Has a trusted dirserver validated this OR? - * (For Authdir: Have we validated this OR?) - */ + * (For Authdir: Have we validated this OR?) */ unsigned int is_fast:1; /** Do we think this is a fast OR? */ unsigned int is_stable:1; /** Do we think this is a stable OR? */ unsigned int is_possible_guard:1; /**< Do we think this is an OK guard? */ @@ -2027,15 +2027,19 @@ typedef struct node_t { /* Local info: derived. */ /** According to the geoip db what country is this router in? */ + /* XXXprop186 what is this suppose to mean with multiple OR ports? */ country_t country; /* The below items are used only by authdirservers for * reachability testing. */ /** When was the last time we could reach this OR? */ - time_t last_reachable; /* IPv4 */ + time_t last_reachable; /* IPv4. */ + time_t last_reachable6; /* IPv6. */ + /** When did we start testing reachability for this OR? */ - time_t testing_since; /* IPv4 */ + time_t testing_since; /* IPv4. */ + time_t testing_since6; /* IPv6. */ } node_t; /** How many times will we try to download a router's descriptor before giving diff --git a/src/or/router.c b/src/or/router.c index df44a76..20767d8 100644 --- a/src/or/router.c +++ b/src/or/router.c @@ -2230,6 +2230,26 @@ router_get_pref_ipv6_orport(const routerinfo_t *router, ap_out->port = router->ipv6_orport; } +/** Return 1 if any of router's addresses are addr. + * Otherwise return 0. */ +int +router_has_addr(const routerinfo_t *router, const tor_addr_t *addr) +{ + return + tor_addr_eq_ipv4h(addr, router->addr) || + tor_addr_eq(&router->ipv6_addr, addr); +} + +int +router_has_orport(const routerinfo_t *router, const tor_addr_port_t *orport) +{ + return + (tor_addr_eq_ipv4h(&orport->addr, router->addr) && + orport->port == router->or_port) || + (tor_addr_eq(&orport->addr, &router->ipv6_addr) && + orport->port == router->ipv6_orport); +} + /** Load the contents of filename, find the last line starting with * end_line, ensure that its timestamp is not more than 25 hours in * the past or more than 1 hour in the future with respect to now, diff --git a/src/or/router.h b/src/or/router.h index 69805d6..81df183 100644 --- a/src/or/router.h +++ b/src/or/router.h @@ -93,6 +93,8 @@ void router_get_pref_orport(const routerinfo_t *router, void router_get_pref_ipv6_orport(const routerinfo_t *router, tor_addr_port_t *addr_port_out); int router_ipv6_preferred(const routerinfo_t *router); +int router_has_addr(const routerinfo_t *router, const tor_addr_t *addr); +int router_has_orport(const routerinfo_t *router, const tor_addr_port_t *orport); int extrainfo_dump_to_string(char **s, extrainfo_t *extrainfo, crypto_pk_t *ident_key); int is_legal_nickname(const char *s); diff --git a/src/or/routerlist.c b/src/or/routerlist.c index f984d93..cc47299 100644 --- a/src/or/routerlist.c +++ b/src/or/routerlist.c @@ -1345,7 +1345,9 @@ mark_all_trusteddirservers_up(void) int routers_have_same_or_addr(const routerinfo_t *r1, const routerinfo_t *r2) { - return r1->addr == r2->addr && r1->or_port == r2->or_port; + return r1->addr == r2->addr && r1->or_port == r2->or_port && + tor_addr_eq(&r1->ipv6_addr, &r2->ipv6_addr) && + r1->ipv6_orport == r2->ipv6_orport; } /** Reset all internal variables used to count failed downloads of network

1 0