tor-commits

tor-commits@lists.torproject.org

1 participants
212369 discussions

[Git][tpo/applications/tor-browser][tor-browser-128.5.0esr-14.5-2] 2 commits: fixup! TB 31286: Implementation of bridge, proxy, and firewall settings in...
by morgan (＠morgan) 19 Dec '24

19 Dec '24

morgan pushed to branch tor-browser-128.5.0esr-14.5-2 at The Tor Project / Applications / Tor Browser Commits: 46eb7528 by Henry Wilkes at 2024-12-19T11:13:03+00:00 fixup! TB 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection TB 43320: Exclude hidden elements from the settings search. We hide elements using the `hidden` attribute instead of `display: none`, which will exclude them from the search. We also always hide the options menu and screen reader announcement area using `data-hidden-from-search`. - - - - - 018492cc by Henry Wilkes at 2024-12-19T11:13:15+00:00 fixup! TB 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection TB 43320: Add duplicate headings that only appear in search results. These duplicate search headings have the same content but are one heading level higher, to preserve the heading level hierarchy in a search result. - - - - - 3 changed files: - browser/components/torpreferences/content/connectionPane.js - browser/components/torpreferences/content/connectionPane.xhtml - browser/components/torpreferences/content/torPreferences.css Changes: ===================================== browser/components/torpreferences/content/connectionPane.js ===================================== @@ -346,7 +346,7 @@ const gBridgeGrid = { Services.obs.addObserver(this, TorProviderTopics.BridgeChanged); - this._grid.classList.add("grid-active"); + this._grid.hidden = false; this._updateConnectedBridge(); }, @@ -363,7 +363,7 @@ const gBridgeGrid = { this._forceCloseRowMenus(); - this._grid.classList.remove("grid-active"); + this._grid.hidden = true; Services.obs.removeObserver(this, TorProviderTopics.BridgeChanged); }, @@ -1023,7 +1023,7 @@ const gBuiltinBridgesArea = { Services.obs.addObserver(this, TorProviderTopics.BridgeChanged); - this._area.classList.add("built-in-active"); + this._area.hidden = false; this._updateBridgeIds(); this._updateConnectedBridge(); @@ -1038,7 +1038,7 @@ const gBuiltinBridgesArea = { } this._active = false; - this._area.classList.remove("built-in-active"); + this._area.hidden = true; Services.obs.removeObserver(this, TorProviderTopics.BridgeChanged); }, @@ -1243,11 +1243,19 @@ const gLoxStatus = { */ _detailsArea: null, /** - * The day counter for the next unlock. + * The list items showing the next unlocks. * - * @type {Element?} + * @type {?Object<string, Element>} + */ + _nextUnlockItems: null, + /** + * The day counter headings for the next unlock. + * + * One heading is shown during a search, the other is shown otherwise. + * + * @type {?Element[]} */ - _nextUnlockCounterEl: null, + _nextUnlockCounterEls: null, /** * Shows the number of remaining invites. * @@ -1266,6 +1274,12 @@ const gLoxStatus = { * @type {Element?} */ _unlockAlert: null, + /** + * The list items showing the unlocks. + * + * @type {?Object<string, Element>} + */ + _unlockItems: null, /** * The alert title. * @@ -1296,8 +1310,19 @@ const gLoxStatus = { this._area = document.getElementById("tor-bridges-lox-status"); this._detailsArea = document.getElementById("tor-bridges-lox-details"); - this._nextUnlockCounterEl = document.getElementById( - "tor-bridges-lox-next-unlock-counter" + this._nextUnlockItems = { + gainBridges: document.getElementById( + "tor-bridges-lox-next-unlock-gain-bridges" + ), + firstInvites: document.getElementById( + "tor-bridges-lox-next-unlock-first-invites" + ), + moreInvites: document.getElementById( + "tor-bridges-lox-next-unlock-more-invites" + ), + }; + this._nextUnlockCounterEls = Array.from( + document.querySelectorAll(".tor-bridges-lox-next-unlock-counter") ); this._remainingInvitesEl = document.getElementById( "tor-bridges-lox-remaining-invites" @@ -1306,6 +1331,15 @@ const gLoxStatus = { "tor-bridges-lox-show-invites-button" ); this._unlockAlert = document.getElementById("tor-bridges-lox-unlock-alert"); + this._unlockItems = { + gainBridges: document.getElementById( + "tor-bridges-lox-unlock-alert-gain-bridges" + ), + newBridges: document.getElementById( + "tor-bridges-lox-unlock-alert-new-bridges" + ), + invites: document.getElementById("tor-bridges-lox-unlock-alert-invites"), + }; this._unlockAlertTitle = document.getElementById( "tor-bridge-unlock-alert-title" ); @@ -1404,6 +1438,7 @@ const gLoxStatus = { return; } this._loxId = loxId; + this._area.hidden = !loxId; // We unset _nextUnlock to ensure the areas no longer use the old value for // the new loxId. this._updateNextUnlock(true); @@ -1518,8 +1553,8 @@ const gLoxStatus = { // Uninitialized or no Lox source. // NOTE: This area may already be hidden by the change in Lox source, // but we clean up for the next non-empty id. - this._area.classList.remove("show-unlock-alert"); - this._area.classList.remove("show-next-unlock"); + this._unlockAlert.hidden = true; + this._detailsArea.hidden = true; return; } @@ -1529,8 +1564,8 @@ const gLoxStatus = { const pendingEvents = this._pendingEvents; const showAlert = !!pendingEvents.length; - this._area.classList.toggle("show-unlock-alert", showAlert); - this._area.classList.toggle("show-next-unlock", !showAlert); + this._unlockAlert.hidden = !showAlert; + this._detailsArea.hidden = showAlert; if (showAlert) { // At level 0 and level 1, we do not have any invites. @@ -1567,6 +1602,7 @@ const gLoxStatus = { blockage = true; } } + let alertTitleId; if (levelUp && !blockage) { alertTitleId = "tor-bridges-lox-upgrade"; @@ -1585,9 +1621,9 @@ const gLoxStatus = { "lox-unlock-upgrade", levelUp && !blockage ); - this._unlockAlert.classList.toggle("lox-unlock-new-bridges", blockage); - this._unlockAlert.classList.toggle("lox-unlock-gain-bridges", bridgeGain); - this._unlockAlert.classList.toggle("lox-unlock-invites", showInvites); + this._unlockItems.gainBridges.hidden = !bridgeGain; + this._unlockItems.newBridges.hidden = !blockage; + this._unlockItems.invites.hidden = !showInvites; } else { // Show next unlock. // Number of days until the next unlock, rounded up. @@ -1598,29 +1634,42 @@ const gLoxStatus = { (24 * 60 * 60 * 1000) ) ); - document.l10n.setAttributes( - this._nextUnlockCounterEl, - "tor-bridges-lox-days-until-unlock", - { numDays } - ); + for (const counterEl of this._nextUnlockCounterEls) { + document.l10n.setAttributes( + counterEl, + "tor-bridges-lox-days-until-unlock", + { numDays } + ); + } // Gain 2 bridges from level 0 to 1. After that gain invites. - const bridgeGain = this._nextUnlock.nextLevel === 1; - const firstInvites = this._nextUnlock.nextLevel === 2; - const moreInvites = this._nextUnlock.nextLevel > 2; - - this._detailsArea.classList.toggle("lox-next-gain-bridges", bridgeGain); - this._detailsArea.classList.toggle( - "lox-next-first-invites", - firstInvites - ); - this._detailsArea.classList.toggle("lox-next-more-invites", moreInvites); + this._nextUnlockItems.gainBridges.hidden = + this._nextUnlock.nextLevel !== 1; + this._nextUnlockItems.firstInvites.hidden = + this._nextUnlock.nextLevel !== 2; + this._nextUnlockItems.moreInvites.hidden = + this._nextUnlock.nextLevel <= 2; } if (alertHadFocus && !showAlert) { // Alert has become hidden, move focus back up to the now revealed details // area. - this._nextUnlockCounterEl.focus(); + // NOTE: We have two headings: one shown during a search and one shown + // otherwise. We focus the heading that is currently visible. + // See tor-browser#43320. + // TODO: It might be better if we could use the # named anchor to + // re-orient the screen reader position instead of using tabIndex=-1, but + // about:preferences currently uses the anchor for showing categories + // only. See bugzilla bug 1799153. + if ( + this._nextUnlockCounterEls[0].checkVisibility({ + visibilityProperty: true, + }) + ) { + this._nextUnlockCounterEls[0].focus(); + } else { + this._nextUnlockCounterEls[1].focus(); + } } else if (detailsHadFocus && showAlert) { this._unlockAlertButton.focus(); } @@ -1642,21 +1691,21 @@ const gLoxStatus = { hasInvites = this._haveExistingInvites || !!this._remainingInvites; } - if (!hasInvites) { - if ( - this._remainingInvitesEl.contains(document.activeElement) || - this._invitesButton.contains(document.activeElement) - ) { - // About to loose focus. - // Unexpected for the lox level to loose all invites. - // Move to the top of the details area, which should be visible if we - // just had focus. - this._nextUnlockCounterEl.focus(); - } + if ( + !hasInvites && + (this._remainingInvitesEl.contains(document.activeElement) || + this._invitesButton.contains(document.activeElement)) + ) { + // About to loose focus. + // Unexpected for the lox level to loose all invites. + // Move to the top of the details area, which should be visible if we + // just had focus. + this._nextUnlockCounterEl.focus(); } // Hide the invite elements if we have no historic invites or a way of // creating new ones. - this._detailsArea.classList.toggle("lox-has-invites", hasInvites); + this._remainingInvitesEl.hidden = !hasInvites; + this._invitesButton.hidden = !hasInvites; if (hasInvites) { document.l10n.setAttributes( @@ -1691,17 +1740,27 @@ const gBridgeSettings = { */ _bridgesEl: null, /** - * The heading for the bridge settings. + * The area for sharing bridge addresses. * * @type {Element?} */ - _bridgesSettingsHeading: null, + _shareEl: null, + /** + * The two headings for the bridge settings. + * + * One heading is shown during a search, the other is shown otherwise. + * + * @type {?Element[]} + */ + _bridgesSettingsHeadings: null, /** - * The current bridges heading, at the start of the area. + * The two headings for the current bridges, at the start of the area. + * + * One heading is shown during a search, the other is shown otherwise. * * @type {Element?} */ - _currentBridgesHeading: null, + _currentBridgesHeadings: null, /** * The area for showing no bridges. * @@ -1709,17 +1768,25 @@ const gBridgeSettings = { */ _noBridgesEl: null, /** - * The heading element for changing bridges. + * The heading elements for changing bridges. * - * @type {Element?} + * One heading is shown during a search, the other is shown otherwise. + * + * @type {?Element[]} */ - _changeHeadingEl: null, + _changeHeadingEls: null, /** * The button for user to provide a bridge address or share code. * * @type {Element?} */ _userProvideButton: null, + /** + * A map from the bridge source to its corresponding label. + * + * @type {?Map<number, Element>} + */ + _sourceLabels: null, /** * Initialize the bridge settings. @@ -1727,15 +1794,33 @@ const gBridgeSettings = { init() { gBridgesNotification.init(); - this._bridgesSettingsHeading = document.getElementById( - "torPreferences-bridges-header" + this._bridgesSettingsHeadings = Array.from( + document.querySelectorAll(".tor-bridges-subcategory-heading") ); - this._currentBridgesHeading = document.getElementById( - "tor-bridges-current-heading" + this._currentBridgesHeadings = Array.from( + document.querySelectorAll(".tor-bridges-current-heading") ); this._bridgesEl = document.getElementById("tor-bridges-current"); this._noBridgesEl = document.getElementById("tor-bridges-none"); this._groupEl = document.getElementById("torPreferences-bridges-group"); + + this._sourceLabels = new Map([ + [ + TorBridgeSource.BuiltIn, + document.getElementById("tor-bridges-built-in-label"), + ], + [ + TorBridgeSource.UserProvided, + document.getElementById("tor-bridges-user-label"), + ], + [ + TorBridgeSource.BridgeDB, + document.getElementById("tor-bridges-requested-label"), + ], + [TorBridgeSource.Lox, document.getElementById("tor-bridges-lox-label")], + ]); + this._shareEl = document.getElementById("tor-bridges-share"); + this._toggleButton = document.getElementById("tor-bridges-enabled-toggle"); // Initially disabled whilst TorSettings may not be initialized. this._toggleButton.disabled = true; @@ -1749,8 +1834,8 @@ const gBridgeSettings = { }); }); - this._changeHeadingEl = document.getElementById( - "tor-bridges-change-heading" + this._changeHeadingEls = Array.from( + document.querySelectorAll(".tor-bridges-change-heading") ); this._userProvideButton = document.getElementById( "tor-bridges-open-user-provide-dialog-button" @@ -1855,6 +1940,12 @@ const gBridgeSettings = { * @type {integer?} */ _bridgeSource: null, + /** + * Whether the user is encouraged to share their bridge addresses. + * + * @type {boolean} + */ + _canShare: false, /** * Update _bridgeSource. @@ -1876,22 +1967,15 @@ const gBridgeSettings = { this._bridgesEl.contains(document.activeElement) || this._noBridgesEl.contains(document.activeElement); - this._bridgesEl.classList.toggle( - "source-built-in", - bridgeSource === TorBridgeSource.BuiltIn - ); - this._bridgesEl.classList.toggle( - "source-user", - bridgeSource === TorBridgeSource.UserProvided - ); - this._bridgesEl.classList.toggle( - "source-requested", - bridgeSource === TorBridgeSource.BridgeDB - ); - this._bridgesEl.classList.toggle( - "source-lox", - bridgeSource === TorBridgeSource.Lox - ); + for (const [source, labelEl] of this._sourceLabels.entries()) { + labelEl.hidden = source !== bridgeSource; + } + + this._canShare = + bridgeSource === TorBridgeSource.UserProvided || + bridgeSource === TorBridgeSource.BridgeDB; + + this._shareEl.hidden = !this._canShare; // Force the menu to close whenever the source changes. // NOTE: If the menu had focus then hadFocus will be true, and focus will be @@ -1937,15 +2021,18 @@ const gBridgeSettings = { // Add classes to show or hide the "no bridges" and "Your bridges" sections. // NOTE: Before haveBridges is set, neither class is added, so both sections // and hidden. - this._groupEl.classList.toggle("no-bridges", !haveBridges); - this._groupEl.classList.toggle("have-bridges", haveBridges); + this._groupEl.classList.add("bridges-initialized"); + this._bridgesEl.hidden = !haveBridges; + this._noBridgesEl.hidden = haveBridges; - document.l10n.setAttributes( - this._changeHeadingEl, - haveBridges - ? "tor-bridges-replace-bridges-heading" - : "tor-bridges-add-bridges-heading" - ); + for (const headingEl of this._changeHeadingEls) { + document.l10n.setAttributes( + headingEl, + haveBridges + ? "tor-bridges-replace-bridges-heading" + : "tor-bridges-add-bridges-heading" + ); + } document.l10n.setAttributes( this._userProvideButton, haveBridges ? "tor-bridges-replace-button" : "tor-bridges-add-new-button" @@ -1964,17 +2051,27 @@ const gBridgeSettings = { } // Make sure we have the latest value for _haveBridges. - // We also ensure that the _currentBridgesHeading element is visible before + // We also ensure that the _currentBridgesHeadings element is visible before // we focus it. this._updateHaveBridges(); - if (this._haveBridges) { - // Move focus to the start of the area, which is the heading. - // It has tabindex="-1" so should be focusable, even though it is not part - // of the usual tab navigation. - this._currentBridgesHeading.focus(); + + // Move focus to the start of the relevant section, which is a heading. + // They have tabindex="-1" so should be focusable, even though they are not + // part of the usual tab navigation. + // NOTE: We have two headings: one shown during a search and one shown + // otherwise. We focus the heading that is currently visible. + // See tor-browser#43320. + // TODO: It might be better if we could use the # named anchor to + // re-orient the screen reader position instead of using tabIndex=-1, but + // about:preferences currently uses the anchor for showing categories + // only. See bugzilla bug 1799153. + const focusHeadings = this._haveBridges + ? this._currentBridgesHeadings // The heading above the new bridges. + : this._bridgesSettingsHeadings; // The top of the bridge settings. + if (focusHeadings[0].checkVisibility({ visibilityProperty: true })) { + focusHeadings[0].focus(); } else { - // Move focus to the top of the bridge settings. - this._bridgesSettingsHeading.focus(); + focusHeadings[1].focus(); } }, @@ -2126,10 +2223,7 @@ const gBridgeSettings = { }); this._bridgesMenu.addEventListener("showing", () => { - const canShare = - this._bridgeSource === TorBridgeSource.UserProvided || - this._bridgeSource === TorBridgeSource.BridgeDB; - qrItem.hidden = !canShare || !this._canQRBridges; + qrItem.hidden = !this._canShare || !this._canQRBridges; editItem.hidden = this._bridgeSource !== TorBridgeSource.UserProvided; }); ===================================== browser/components/torpreferences/content/connectionPane.xhtml ===================================== @@ -97,8 +97,8 @@  <hbox class="subcategory" data-category="paneConnection" hidden="true"> <html:h1 - id="torPreferences-bridges-header" - class="tor-focusable-heading" + id="tor-bridges-subcategory-heading-non-search" + class="tor-bridges-subcategory-heading tor-focusable-heading" tabindex="-1" data-l10n-id="tor-bridges-heading" ></html:h1> @@ -107,7 +107,22 @@ id="torPreferences-bridges-group" data-category="paneConnection" hidden="true" + aria-labelledby="tor-bridges-subcategory-heading-non-search" > +  + <label class="search-header" hidden="true"> + <html:h2 + class="tor-bridges-subcategory-heading tor-focusable-heading" + tabindex="-1" + data-l10n-id="tor-bridges-heading" + ></html:h2> + </label> <description class="description-deemphasized" flex="1"> <html:span data-l10n-id="tor-bridges-overview"></html:span> <label @@ -164,8 +179,13 @@ - See https://github.com/WICG/proposals/issues/112 -->  - <html:div id="tor-bridges-update-area" hidden="hidden"> + - when a notification is added. It should never match with search + - queries. --> + <html:div + id="tor-bridges-update-area" + hidden="hidden" + data-hidden-from-search="true" + >  + <html:h3 + class="tor-bridges-current-heading tor-focusable-heading tor-small-heading tor-search-heading" + tabindex="-1" + data-l10n-id="tor-bridges-your-bridges" + ></html:h3> <html:span id="tor-bridges-user-label" class="tor-bridges-source-label" @@ -221,7 +256,10 @@ aria-controls="tor-bridges-all-options-menu" data-l10n-id="tor-bridges-options-button" ></html:button> - <html:panel-list id="tor-bridges-all-options-menu"> + <html:panel-list + id="tor-bridges-all-options-menu" + data-hidden-from-search="true" + > <html:panel-item id="tor-bridges-options-qr-all-menu-item" data-l10n-attrs="accesskey" @@ -244,7 +282,7 @@ ></html:panel-item> </html:panel-list> </html:div> - <html:div id="tor-bridges-built-in-display"> + <html:div id="tor-bridges-built-in-display" hidden="hidden"> <html:div id="tor-bridges-built-in-type-name"></html:div> <html:div id="tor-bridges-built-in-connected" @@ -261,7 +299,8 @@ id="tor-bridges-grid-display" class="tor-bridges-grid" role="grid" - aria-labelledby="tor-bridges-current-heading" + aria-labelledby="tor-bridges-current-heading-non-search" + hidden="hidden" ></html:div> <html:template id="tor-bridges-grid-row-template"> <html:div class="tor-bridges-grid-row" role="row"> @@ -297,7 +336,10 @@ aria-expanded="false" data-l10n-id="tor-bridges-individual-bridge-options-button" ></html:button> - <html:panel-list class="tor-bridges-individual-options-menu"> + <html:panel-list + class="tor-bridges-individual-options-menu" + data-hidden-from-search="true" + > <html:panel-item class="tor-bridges-options-qr-one-menu-item" data-l10n-attrs="accesskey" @@ -318,11 +360,20 @@ </html:span> </html:div> </html:template> - <html:div id="tor-bridges-share" class="tor-bridges-details-box"> + <html:div + id="tor-bridges-share" + class="tor-bridges-details-box" + hidden="hidden" + > <html:h3 - id="tor-bridges-share-heading" + class="tor-bridges-share-heading tor-small-heading tor-non-search-heading" data-l10n-id="tor-bridges-share-heading" ></html:h3> +  + <html:h4 + class="tor-bridges-share-heading tor-small-heading tor-search-heading" + data-l10n-id="tor-bridges-share-heading" + ></html:h4> <html:span id="tor-bridges-share-description" data-l10n-id="tor-bridges-share-description" @@ -336,68 +387,84 @@ data-l10n-id="tor-bridges-qr-addresses-button" ></html:button> </html:div> - <html:div id="tor-bridges-lox-status"> + <html:div id="tor-bridges-lox-status" hidden="hidden"> <html:div data-l10n-id="tor-bridges-lox-description"></html:div> <html:div id="tor-bridges-lox-details" class="tor-bridges-details-box tor-bridges-lox-box" + hidden="hidden" > <html:img alt="" class="tor-bridges-lox-image-inner" /> <html:img alt="" class="tor-bridges-lox-image-outer" /> <html:h3 - id="tor-bridges-lox-next-unlock-counter" - class="tor-bridges-lox-intro tor-focusable-heading" + class="tor-bridges-lox-next-unlock-counter tor-small-heading tor-bridges-lox-intro tor-focusable-heading tor-non-search-heading" tabindex="-1" ></html:h3> +  + <html:h4 + class="tor-bridges-lox-next-unlock-counter tor-small-heading tor-bridges-lox-intro tor-focusable-heading tor-search-heading" + tabindex="-1" + ></html:h4> <html:ul class="tor-bridges-lox-list"> <html:li id="tor-bridges-lox-next-unlock-gain-bridges" class="tor-bridges-lox-list-item tor-bridges-lox-list-item-bridge" data-l10n-id="tor-bridges-lox-unlock-two-bridges" + hidden="hidden" ></html:li> <html:li id="tor-bridges-lox-next-unlock-first-invites" class="tor-bridges-lox-list-item tor-bridges-lox-list-item-invite" data-l10n-id="tor-bridges-lox-unlock-first-invites" + hidden="hidden" ></html:li> <html:li id="tor-bridges-lox-next-unlock-more-invites" class="tor-bridges-lox-list-item tor-bridges-lox-list-item-invite" data-l10n-id="tor-bridges-lox-unlock-more-invites" + hidden="hidden" ></html:li> </html:ul> - <html:div id="tor-bridges-lox-remaining-invites"></html:div> + <html:div + id="tor-bridges-lox-remaining-invites" + hidden="hidden" + ></html:div> <html:button id="tor-bridges-lox-show-invites-button" class="tor-bridges-lox-button" data-l10n-id="tor-bridges-lox-show-invites-button" + hidden="hidden" ></html:button> </html:div> <html:div id="tor-bridges-lox-unlock-alert" role="alert" class="tor-bridges-details-box tor-bridges-lox-box" + hidden="hidden" > <html:img alt="" class="tor-bridges-lox-image-inner" /> <html:img alt="" class="tor-bridges-lox-image-outer" /> <html:div id="tor-bridge-unlock-alert-title" - class="tor-bridges-lox-intro" + class="tor-small-heading tor-bridges-lox-intro" ></html:div> <html:ul class="tor-bridges-lox-list"> <html:li id="tor-bridges-lox-unlock-alert-gain-bridges" class="tor-bridges-lox-list-item tor-bridges-lox-list-item-bridge" data-l10n-id="tor-bridges-lox-gained-two-bridges" + hidden="hidden" ></html:li> <html:li id="tor-bridges-lox-unlock-alert-new-bridges" class="tor-bridges-lox-list-item tor-bridges-lox-list-item-bridge" data-l10n-id="tor-bridges-lox-new-bridges" + hidden="hidden" ></html:li> <html:li id="tor-bridges-lox-unlock-alert-invites" class="tor-bridges-lox-list-item tor-bridges-lox-list-item-invite" + hidden="hidden" ></html:li> </html:ul> <html:button @@ -408,7 +475,14 @@ </html:div> </html:div> </html:div> - <html:h2 id="tor-bridges-change-heading"></html:h2> + <html:h2 + class="tor-bridges-change-heading tor-medium-heading tor-non-search-heading" + ></html:h2> +  + <html:h3 + class="tor-bridges-change-heading tor-small-heading tor-search-heading" + ></html:h3> <hbox align="center"> <description flex="1" @@ -428,9 +502,15 @@ ></html:button> </hbox> <html:h3 - id="tor-bridges-provider-heading" + class="tor-bridges-provider-heading tor-medium-heading tor-non-search-heading" data-l10n-id="tor-bridges-find-more-heading" ></html:h3> +  + <html:h4 + class="tor-bridges-provider-heading tor-small-heading tor-search-heading" + data-l10n-id="tor-bridges-find-more-heading" + ></html:h4> <description data-l10n-id="tor-bridges-find-more-description" class="description-deemphasized" @@ -511,15 +591,29 @@  <hbox class="subcategory" data-category="paneConnection" hidden="true"> - <html:h1 data-l10n-id="tor-advanced-settings-heading"></html:h1> + <html:h1 + id="tor-advanced-subcategory-heading-non-search" + data-l10n-id="tor-advanced-settings-heading" + ></html:h1> </hbox> <groupbox id="torPreferences-advanced-group" data-category="paneConnection" hidden="true" + aria-labelledby="tor-advanced-subcategory-heading-non-search" > +  + <label class="search-header" hidden="true"> + <html:h2 data-l10n-id="tor-advanced-settings-heading"></html:h2> + </label> <hbox align="center"> - <label data-l10n-id="tor-advanced-settings-description" flex="1" /> + <description data-l10n-id="tor-advanced-settings-description" flex="1" /> <html:button id="torPreferences-advanced-button" class="accessory-button" @@ -527,7 +621,7 @@ ></html:button> </hbox> <hbox align="center" data-subcategory="viewlogs"> - <label data-l10n-id="tor-view-log-description" flex="1" /> + <description data-l10n-id="tor-view-log-description" flex="1" /> <html:button id="torPreferences-buttonTorLogs" class="accessory-button" ===================================== browser/components/torpreferences/content/torPreferences.css ===================================== @@ -118,6 +118,48 @@ button.spoof-button-disabled { /* Bridge settings */ +.tor-medium-heading { + /* Same font size as mozilla preferences h2. */ + font-size: var(--font-size-large); + font-weight: var(--font-weight-bold); + margin: 0; +} + +.tor-small-heading { + font-size: inherit; + font-weight: var(--font-weight-bold); + margin: 0; +} + +/* Hide the tor-search-heading elements when the group's search header is + * hidden. These only appear in search results. + * See tor-browser#43320. + * NOTE: `.search-header[hidden] ~ :is(* .tor-search-heading)` will not match + * (possibly because the `~` selector is unsure how to integrate with the + * non-compound `* .tor-search-heading` selector). So we need to duplicate the + * `.search-header[hidden]` rule. */ +#torPreferences-bridges-group :is( + .search-header[hidden] ~ * .tor-search-heading, + .search-header[hidden] ~ .tor-search-heading +) { + display: none; +} + +/* Hide the tor-non-search-heading elements when the group's search header is + * not hidden. These only appear outside of search results. + * See tor-browser#43320. */ +#torPreferences-bridges-group :is( + .search-header:not([hidden]) ~ * .tor-non-search-heading, + .search-header:not([hidden]) ~ .tor-non-search-heading +) { + display: none; +} + +.tor-focusable-heading { + /* Do not occupy more horizontal space than necessary. */ + width: fit-content; +} + .tor-focusable-heading:focus-visible { outline-offset: var(--in-content-focus-outline-offset); } @@ -182,53 +224,18 @@ button.spoof-button-disabled { clip-path: inset(50%); } -#torPreferences-bridges-group:not(.have-bridges, .no-bridges) { +#torPreferences-bridges-group:not(.bridges-initialized) { /* Hide bridge settings whilst not initialized. */ display: none; } -#torPreferences-bridges-group:not(.have-bridges) #tor-bridges-current { - display: none; -} - -#torPreferences-bridges-group:not(.no-bridges) #tor-bridges-none { - display: none; -} - -#tor-bridges-current:not(.source-built-in) #tor-bridges-built-in-label { - display: none; -} - -#tor-bridges-current:not(.source-user) #tor-bridges-user-label { - display: none; -} - -#tor-bridges-current:not(.source-requested) #tor-bridges-requested-label { - display: none; -} - -#tor-bridges-current:not(.source-lox) #tor-bridges-lox-label { - display: none; -} - -#tor-bridges-current:not( - .source-user, - .source-requested -) #tor-bridges-share { - display: none; -} - -#tor-bridges-current:not(.source-lox) #tor-bridges-lox-status { - display: none; -} - #tor-bridges-none, #tor-bridges-current { margin-inline: 0; margin-block: 32px; } -#tor-bridges-none { +#tor-bridges-none:not([hidden]) { display: grid; justify-items: center; text-align: center; @@ -265,9 +272,7 @@ button.spoof-button-disabled { white-space: nowrap; } -#tor-bridges-current-heading { - margin: 0; - font-size: inherit; +.tor-bridges-current-heading { grid-area: heading; } @@ -282,7 +287,7 @@ button.spoof-button-disabled { grid-area: button; } -#tor-bridges-lox-label { +#tor-bridges-lox-label:not([hidden]) { display: flex; align-items: center; gap: 6px; @@ -317,7 +322,7 @@ button.spoof-button-disabled { fill: currentColor; } -#tor-bridges-built-in-display { +#tor-bridges-built-in-display:not([hidden]) { display: grid; grid-template: "type status" min-content @@ -327,10 +332,6 @@ button.spoof-button-disabled { margin-block-end: 16px; } -#tor-bridges-built-in-display:not(.built-in-active) { - display: none; -} - #tor-bridges-built-in-type-name { font-weight: 700; grid-area: type; @@ -345,7 +346,7 @@ button.spoof-button-disabled { grid-area: description; } -.tor-bridges-grid { +.tor-bridges-grid:not([hidden]) { display: grid; grid-template-columns: max-content repeat(4, max-content) 1fr; --tor-bridges-grid-column-gap: 8px; @@ -355,10 +356,6 @@ button.spoof-button-disabled { align-items: stretch; } -#tor-bridges-grid-display:not(.grid-active) { - display: none; -} - .tor-bridges-grid-row { /* We want each row to act as a row of three items in the * .tor-bridges-grid grid layout. @@ -483,7 +480,7 @@ button.spoof-button-disabled { padding: 16px; } -#tor-bridges-share { +#tor-bridges-share:not([hidden]) { display: grid; grid-template: "heading heading heading" min-content @@ -496,12 +493,9 @@ button.spoof-button-disabled { align-items: center; } -#tor-bridges-share-heading { +.tor-bridges-share-heading { grid-area: heading; - font-size: inherit; - margin: 0; margin-block-end: 4px; - font-weight: 700; } #tor-bridges-share-description { @@ -538,15 +532,7 @@ button.spoof-button-disabled { margin-block-start: 8px; } -#tor-bridges-lox-status:not(.show-next-unlock) #tor-bridges-lox-details { - display: none; -} - -#tor-bridges-lox-status:not(.show-unlock-alert) #tor-bridges-lox-unlock-alert { - display: none; -} - -.tor-bridges-lox-box { +.tor-bridges-lox-box:not([hidden]) { display: grid; grid-template: "image intro intro" min-content @@ -601,11 +587,8 @@ button.spoof-button-disabled { .tor-bridges-lox-intro { grid-area: intro; - font-weight: 700; - font-size: inherit; align-self: center; justify-self: start; - margin: 0; } .tor-bridges-lox-list { @@ -619,11 +602,11 @@ button.spoof-button-disabled { gap: 8px 0; } -.tor-bridges-lox-list-item { +.tor-bridges-lox-list-item:not([hidden]) { display: contents; } -.tor-bridges-lox-list-item::before { +.tor-bridges-lox-list-item:not([hidden])::before { /* We use ::before rather than list-style-image to have more control. */ box-sizing: content-box; width: 18px; @@ -655,52 +638,19 @@ button.spoof-button-disabled { stroke: var(--in-content-success-icon-color); } -#tor-bridges-lox-details:not(.lox-next-gain-bridges) #tor-bridges-lox-next-unlock-gain-bridges { - display: none; -} - -#tor-bridges-lox-details:not(.lox-next-first-invites) #tor-bridges-lox-next-unlock-first-invites { - display: none; -} - -#tor-bridges-lox-details:not(.lox-next-more-invites) #tor-bridges-lox-next-unlock-more-invites { - display: none; -} - - -#tor-bridges-lox-unlock-alert:not(.lox-unlock-gain-bridges) #tor-bridges-lox-unlock-alert-gain-bridges { - display: none; -} - -#tor-bridges-lox-unlock-alert:not(.lox-unlock-new-bridges) #tor-bridges-lox-unlock-alert-new-bridges { - display: none; -} - -#tor-bridges-lox-unlock-alert:not(.lox-unlock-invites) #tor-bridges-lox-unlock-alert-invites { - display: none; -} - #tor-bridges-lox-remaining-invites { grid-area: invites; justify-self: end; align-self: center; } -#tor-bridges-lox-details:not(.lox-has-invites) :is( - #tor-bridges-lox-remaining-invites, - #tor-bridges-lox-show-invites-button -) { - display: none; -} - .tor-bridges-lox-button { grid-area: button; margin: 0; align-self: center; } -#tor-bridges-provider-heading { - font-size: 1.14em; +.tor-bridges-provider-heading { margin-block: 48px 8px; } View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/87cdcd… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/87cdcd… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser] Pushed new branch mullvad-browser-128.5.0esr-14.5-2
by Pier Angelo Vendrame (＠pierov) 19 Dec '24

19 Dec '24

Pier Angelo Vendrame pushed new branch mullvad-browser-128.5.0esr-14.5-2 at The Tor Project / Applications / Mullvad Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/tree/mullv… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser] Pushed new tag base-browser-128.5.0esr-14.5-2-build1
by Pier Angelo Vendrame (＠pierov) 19 Dec '24

19 Dec '24

Pier Angelo Vendrame pushed new tag base-browser-128.5.0esr-14.5-2-build1 at The Tor Project / Applications / Mullvad Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/tree/base-… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag base-browser-128.5.0esr-14.5-2-build1
by Pier Angelo Vendrame (＠pierov) 19 Dec '24

19 Dec '24

Pier Angelo Vendrame pushed new tag base-browser-128.5.0esr-14.5-2-build1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/base-brow… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new branch base-browser-128.5.0esr-14.5-2
by Pier Angelo Vendrame (＠pierov) 19 Dec '24

19 Dec '24

Pier Angelo Vendrame pushed new branch base-browser-128.5.0esr-14.5-2 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/base-brow… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag tor-browser-128.5.0esr-14.5-2-build1
by Pier Angelo Vendrame (＠pierov) 19 Dec '24

19 Dec '24

Pier Angelo Vendrame pushed new tag tor-browser-128.5.0esr-14.5-2-build1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.5.0esr-14.5-2] 223 commits: Bug 1899180. If a channel is not nsIPrivateBrowsingChannel and has no load...
by Pier Angelo Vendrame (＠pierov) 19 Dec '24

19 Dec '24

Pier Angelo Vendrame pushed to branch tor-browser-128.5.0esr-14.5-2 at The Tor Project / Applications / Tor Browser Commits: 50df7f68 by Timothy Nikkel at 2024-12-02T18:08:38+01:00 Bug 1899180. If a channel is not nsIPrivateBrowsingChannel and has no load context, use the private browsing field from it's origin attributes. r=necko-reviewers,anti-tracking-reviewers,valentin If the channel is not a nsIPrivateBrowsingChannel, and it also has no load context (eg inside svg images) then we will over write a non-zero mPrivateBrowsingId on the OriginAttributes of the channel with 0, making NS_UsePrivateBrowsing return false for the channel. Differential Revision: https://phabricator.services.mozilla.com/D212083 - - - - - f2067a30 by Jon Coppeard at 2024-12-02T18:08:38+01:00 Bug 1904011 - Ignore finalized scripts when iterating code covarage tables r=iain Differential Revision: https://phabricator.services.mozilla.com/D214799 - - - - - 7d02cc90 by Arturo Mejia at 2024-12-02T18:08:38+01:00 Bug 1908344 - Improve prompts showing a=dmeehan - BP, tor-browser#43005 Original Revision: https://phabricator.services.mozilla.com/D216996 Differential Revision: https://phabricator.services.mozilla.com/D217718 - - - - - 10101210 by Sam Foster at 2024-12-02T18:08:38+01:00 Bug 1909099 - Always clean up old session restore and sync log files. r=markh,sessionstore-reviewers,dao Differential Revision: https://phabricator.services.mozilla.com/D217520 - - - - - 33ac2b5c by pollymce at 2024-12-02T18:08:39+01:00 Bug 1902996 - Improve messaging for fullscreen notifications. r=android-reviewers,gl Instead of explaining to users that they are in fullscreen mode, which may be obvious, we explain how to get out of it :) Also use a Toast rather than a custom Dialog. Update Focus too. Fix lint errors. Differential Revision: https://phabricator.services.mozilla.com/D215782 - - - - - d2d1c982 by Roger Yang at 2024-12-02T18:08:39+01:00 Bug 1862537 - Do not try to go back when it's a initial load r=android-reviewers,harrisono, a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D219782 - - - - - 15a89bdf by Henry Wilkes at 2024-12-02T18:08:39+01:00 Bug 1436462 - Use "Open in new private window" for bookmarks when in PBM. r=places-reviewers,mak This makes the bookmark menu consistent with the "File" and context menu when using private browsing mode. We also share the same hide item logic for these "open" items in one place in PlacesUIUtils so that they can be shared between the two consumers (regular bookmarks and managed bookmarks). This ensures that the "Open in container" item if hidden for managed bookmarks in a private window. Differential Revision: https://phabricator.services.mozilla.com/D220120 - - - - - 30875a1e by Fatih at 2024-12-02T18:08:40+01:00 Bug 1834307: Change StaticPrefs::general_smoothScroll() calls with nsLayoutUtils::IsSmoothScrollingEnabled. r=tjr Differential Revision: https://phabricator.services.mozilla.com/D221363 - - - - - 13a51a68 by Fatih at 2024-12-02T18:08:40+01:00 Bug 1834307: Check RFPTarget::CSSPrefersReducedMotion in nsLayoutUtils::IsSmoothScrollingEnabled. r=tjr Differential Revision: https://phabricator.services.mozilla.com/D221364 - - - - - 50179f2a by Henry Wilkes at 2024-12-02T18:08:40+01:00 Bug 1919363 - Only show one app menu "new window" item in permanent private browsing. r=mconley We also update the browser_private_browsing_window.js test. The previous test was limited because it was referring to non-existent "appmenu_newNavigator" and "appmenu_newPrivateWindow". Differential Revision: https://phabricator.services.mozilla.com/D222507 - - - - - ca1bbec0 by rahulsainani at 2024-12-02T18:08:40+01:00 Bug 1906024 - Format download file names better a=diannaS Original Revision: https://phabricator.services.mozilla.com/D220559 Differential Revision: https://phabricator.services.mozilla.com/D222254 - - - - - 34f2f24f by rahulsainani at 2024-12-02T18:08:41+01:00 Bug 1906024 - Format download file names a=diannaS Original Revision: https://phabricator.services.mozilla.com/D221771 Differential Revision: https://phabricator.services.mozilla.com/D222259 - - - - - 05d6702a by Nika Layzell at 2024-12-02T18:08:41+01:00 Bug 1911745 - Unify BrowsingContext flag coherency checks, r=mccr8 Previously these checks were largely diagnostic tools for finding bugs in other code as it evolves. This unifies the checks a bit more and makes them stronger for BrowsingContexts created over IPC, providing a place for more coherency checks to be added in the future. Differential Revision: https://phabricator.services.mozilla.com/D218860 - - - - - d8e388c3 by Pier Angelo Vendrame at 2024-12-02T18:08:41+01:00 Bug 1918009 - Fix the RFP-spoofed User-Agent header. r=tjr The spoofed value of the HTTP user-agent header is not consistent with the value of navigator.userAgent on Windows, and this can lead to compatibility issues. Differential Revision: https://phabricator.services.mozilla.com/D223745 - - - - - 5bbb2a17 by Fatih at 2024-12-02T18:08:41+01:00 Bug 1607032: Spoof screen orientation and angle to primary values. r=tjr,geckoview-reviewers,owlish Differential Revision: https://phabricator.services.mozilla.com/D220904 - - - - - d1ee9918 by Fatih at 2024-12-02T18:08:42+01:00 Bug 1918202: Spoof orientation based on screen size. r=tjr Differential Revision: https://phabricator.services.mozilla.com/D221863 - - - - - 783e35a0 by Fatih at 2024-12-02T18:08:42+01:00 Bug 1922204: fixup square spoofed orientation. r=tjr Differential Revision: https://phabricator.services.mozilla.com/D224312 - - - - - 6aad7349 by Pier Angelo Vendrame at 2024-12-02T18:08:42+01:00 Bug 1923264 - Discard unsupported updates in selectUpdate. r=bytesized,nalexander UpdateService.#selectUpdate currently chooses always the most recent update even when unsupported and an older but supported one is available. This commit makes #selectUpdate discard the unsupported update if a supported alternative is found. Differential Revision: https://phabricator.services.mozilla.com/D224905 - - - - - 2c920af1 by stransky at 2024-12-02T18:08:42+01:00 Bug 1501744 [Linux] Fill PointerEvents on the Gtk backend r=emilio Patch author is tpxp <tpxp(a)live.fr> Differential Revision: https://phabricator.services.mozilla.com/D215201 - - - - - 52da819e by Fatih at 2024-12-02T18:08:42+01:00 Bug 1436226: Ignore user prefs and hardware support for media capabilities when RFPTarget::MediaCapabilities is enabled. r=tjr,media-playback-reviewers,padenot This patch mostly targeted Android, as media.mediasource.vp9.enabled is disabled on only Android and HW support takes precedence over pref, hence leaking HW support for VP9. However, we ended up modifying the patch to ignore prefs or HW support, fixing both possible user pref leak and HW support leak. Differential Revision: https://phabricator.services.mozilla.com/D221338 - - - - - a2279ecd by hackademix at 2024-12-02T18:08:43+01:00 Bug 1556002 - Update initial window size and letterboxing stepping. r=tjr Differential Revision: https://phabricator.services.mozilla.com/D226598 - - - - - 9815f375 by Arturo Mejia at 2024-12-02T18:08:43+01:00 Bug 1836921 - Improve dialogs a=dmeehan Original Revision: https://phabricator.services.mozilla.com/D226961 Differential Revision: https://phabricator.services.mozilla.com/D228842 - - - - - cca59bb0 by Makoto Kato at 2024-12-02T18:08:43+01:00 Bug 1776646 - Support EXTRA_IS_SENSITIVE for clipboard. r=geckoview-reviewers,owlish When nsITransferable.isPrivateData is true, such as coping password or private mode, we should set EXTRA_IS_SENSITIVE to ClipData. AndroidJunit test runner doesn't often get `ClipDescription.extras` from clipboard service in test runner. So we cannot write a unit test using AndroidJUnit test runner. Differential Revision: https://phabricator.services.mozilla.com/D225326 - - - - - 62aa3300 by Malte Juergens at 2024-12-02T18:08:43+01:00 Bug 1909396 - Remove HTTPS-Only exception button in iframes r=freddyb,fluent-reviewers Rationale for this can be read in Bug 1909396, but the main reason is that the iframe will get blocked regardless by mixed content blocking. Differential Revision: https://phabricator.services.mozilla.com/D220257 - - - - - 39251f49 by Cathy Lu at 2024-12-02T18:08:44+01:00 Bug 1914797 - Part 1 + 2 + partial backout (details below) Bug 1914797 - Part 1 - Revert bug 1868469 r=android-reviewers,jonalmeida, a=dmeehan Differential Revision: https://phabricator.services.mozilla.com/D226431 Bug 1914797 - Part 2 - Add url change during onPageStart for slow loading sites r=android-reviewers,jonalmeida, a=dmeehan Differential Revision: https://phabricator.services.mozilla.com/D226432 Backed out 1 changesets (bug 1914797) for causing Bug 1929028 Backed out changeset a79554879d7b (bug 1914797) - - - - - 0cbc88cc by Emilio Cobos Álvarez at 2024-12-09T17:46:25+01:00 Bug 1909625 - Ignore CSS zoom and text zoom for canvas. r=gfx-reviewers,lsalzman The spec doesn't mention anything about applying them, and other browsers don't, so let's just be consistent... Differential Revision: https://phabricator.services.mozilla.com/D221709 - - - - - fb7d9af0 by Emilio Cobos Álvarez at 2024-12-09T17:46:25+01:00 Bug 1918454 - Prevent divide by zero when inverting effective zoom. r=firefox-style-system-reviewers,layout-reviewers,boris See comment. Differential Revision: https://phabricator.services.mozilla.com/D222090 - - - - - 5d38f95e by Filipe Laíns at 2024-12-10T15:20:54+01:00 Bug 1935621 - Fix virtual environment sysconfig path calculation r=firefox-build-system-reviewers,ahochheiden Signed-off-by: Filipe Laíns <lains(a)riseup.net> Signed-off-by: Filipe Laíns <lains(a)riseup.net> Signed-off-by: Filipe Laíns <lains(a)riseup.net> Differential Revision: https://phabricator.services.mozilla.com/D231480 - - - - - ef3a3030 by Henry Wilkes at 2024-12-10T15:20:54+01:00 BB 41454: Move focus after calling openPreferences for a sub-category. Temporary fix until mozilla bug 1799153 gets a patch upstream. - - - - - af44ac41 by Henry Wilkes at 2024-12-10T15:20:55+01:00 BB 43072: Add aria label and description to moz-message-bar. Ensures that moz-message-bar, including notifications, are announced on Orca. This addresses upstream bugzilla bug 1895857 and should likely be replaced when it is fixed. - - - - - de754a2d by Henry Wilkes at 2024-12-10T15:20:55+01:00 BB 42739: Use the brand name for profile error messages. Some messages in profileSelection.properties use gAppData->name as variable inputs. However, gAppData->name is still "Firefox" for our base-browser builds, rather than the user-facing browser name. We swap these instances with the displayed brand name instead. - - - - - a5ec35d4 by hackademix at 2024-12-10T15:20:55+01:00 BB 42194: Fix blank net error page on failed DNS resolution with active proxy. - - - - - fd29389a by Henry Wilkes at 2024-12-10T15:20:55+01:00 BB 41483: Remove the firefox override for appstrings.properties Remove this patch after upstream bugzilla bug 1790187 - - - - - 1a86c15b by hackademix at 2024-12-10T15:20:56+01:00 BB 43101: Deep link to the startup security warning explanation. - - - - - c068578d by Marco Simonelli at 2024-12-10T15:20:56+01:00 BB 41459: WebRTC fails to build under mingw (Part 1) - properly define NOMINMAX for just MSVC builds - - - - - 166470a4 by Marco Simonelli at 2024-12-10T15:20:56+01:00 BB 41459: WebRTC fails to build under mingw (Part 2) - fixes required to build third_party/libwebrtc - - - - - 5a44ee7e by Marco Simonelli at 2024-12-10T15:20:56+01:00 BB 41459: WebRTC fails to build under mingw (Part 3) - fixes required to build third_party/sipcc - - - - - 7de8e1b1 by Marco Simonelli at 2024-12-10T15:20:56+01:00 BB 41459: WebRTC fails to build under mingw (Part 4) - fixes requried to build netwerk/sctp - - - - - fb4c2f59 by Marco Simonelli at 2024-12-10T15:20:57+01:00 BB 41459: WebRTC fails to build under mingw (Part 5) - fixes required to build dom/media/webrtc - - - - - ab017c8f by Marco Simonelli at 2024-12-10T15:20:57+01:00 BB 41459: WebRTC fails to build under mingw (Part 6) - fixes required to build dom/media/systemservices - - - - - ac9b85b9 by june wilde at 2024-12-10T15:20:57+01:00 BB 42758: Fix WebRTC build errors. - - - - - fe559695 by hackademix at 2024-12-10T15:20:57+01:00 BB 41854: Allow overriding download spam protection. - - - - - a64455f1 by hackademix at 2024-12-10T15:20:58+01:00 BB 42832: Download spam prevention exemption for browser extensions. - - - - - 8cb37328 by Pier Angelo Vendrame at 2024-12-10T15:20:58+01:00 BB 42220: Allow for more file types to be forced-inline. Firefox allows to open some files in the browser without any confirmation, but this will result in a disk leak, because the file will be downloaded to the temporary directory first (and not deleted, in some cases). A preference allows PDFs to be opened without being downloaded to disk. So, we introduce a similar one to do the same for all the files that are set to be opened automatically in the browser. - - - - - 10fa087e by hackademix at 2024-12-10T15:20:58+01:00 BB 42835: Create an actor to filter file data transfers - - - - - d989d938 by Beatriz Rizental at 2024-12-10T15:20:58+01:00 BB 42728: Modify ./mach lint to skip unused linters - - - - - 70f7cee0 by Gaba at 2024-12-10T15:20:59+01:00 Adding issue and merge request templates - - - - - 04acf83e by Richard Pospesel at 2024-12-10T15:20:59+01:00 BB 42683: Create script to generate issue triage csv file from bugzilla query and git logs - - - - - abb5e69f by Beatriz Rizental at 2024-12-19T12:01:47+01:00 Add CI for Base Browser - - - - - 8f860d84 by Pier Angelo Vendrame at 2024-12-19T12:01:49+01:00 Base Browser's .mozconfigs. Bug 17858: Cannot create incremental MARs for hardened builds. Define HOST_CFLAGS, etc. to avoid compiling programs such as mbsdiff (which is part of mar-tools and is not distributed to end-users) with ASan. Bug 21849: Don't allow SSL key logging. Bug 25741 - TBA: Disable features at compile-time Define MOZ_ANDROID_NETWORK_STATE and MOZ_ANDROID_LOCATION Bug 27623 - Export MOZILLA_OFFICIAL during desktop builds This fixes a problem where some preferences had the wrong default value. Also see bug 27472 where we made a similar fix for Android. Bug 29859: Disable HLS support for now Bug 30463: Explicitly disable MOZ_TELEMETRY_REPORTING Bug 32493: Disable MOZ_SERVICES_HEALTHREPORT Bug 33734: Set MOZ_NORMANDY to False Bug 33851: Omit Parental Controls. Bug 40252: Add --enable-rust-simd to our tor-browser mozconfig files Bug 41584: Move some configuration options to base-browser level - - - - - ba0e457b by Pier Angelo Vendrame at 2024-12-19T12:01:49+01:00 Tweaks to the build system Bug 40857: Modified the fat .aar creation file This is a workaround to build fat .aars with the compiling enviornment disabled. Mozilla does not use a similar configuration, but either runs a Firefox build and discards its output, or uses artifacts build. We might switch to artifact builds too, and drop this patch, or write a better one to upstream. But until then we need this patch. See also https://bugzilla.mozilla.org/show_bug.cgi?id=1763770. Bug 41458: Prevent `mach package-multi-locale` from actually creating a package macOS builds need some files to be moved around with ./mach package-multi-locale to create multi-locale packages. The required command isn't exposed through any other mach command. So, we patch package-multi-locale both to prevent it from failing when doing official builds and to detect any future changes on it. - - - - - 6b0a841c by Pier Angelo Vendrame at 2024-12-19T12:01:50+01:00 BB 29320: Replace the gnu target with gnullvm for Rust. - - - - - 31a48a8f by Pier Angelo Vendrame at 2024-12-19T12:01:50+01:00 BB 42616: Remove VideoCaptureTest.kt. This is a workaround to fix the GeckoView build with WebRTC disabled. We should replace this workaround with a proper solution, that excludes this test when MOZ_WEBRTC is undefined/False. - - - - - d3bdd19a by Pier Angelo Vendrame at 2024-12-19T12:01:50+01:00 BB 41108: Remove privileged macOS installation from 102 - - - - - 33b3d064 by Dan Ballard at 2024-12-19T12:01:51+01:00 BB 41149: Re-enable DLL injection protection in all builds not just nightlies - - - - - b66930aa by Henry Wilkes at 2024-12-19T12:01:51+01:00 BB 43092: Disable wayland by default in Base Browser. - - - - - 86988899 by Matthew Finkel at 2024-12-19T12:01:51+01:00 BB 24796: Comment out excess permissions from GeckoView The GeckoView AndroidManifest.xml is not preprocessed unlike Fennec's manifest, so we can't use the ifdef preprocessor guards around the permissions we do not want. Commenting the permissions is the next-best-thing. - - - - - ba5daa70 by Matthew Finkel at 2024-12-19T12:01:52+01:00 BB 28125: Prevent non-Necko network connections - - - - - 53c1f63a by Mike Perry at 2024-12-19T12:01:52+01:00 BB 12974: Disable NTLM and Negotiate HTTP Auth The Mozilla bugs: https://bugzilla.mozilla.org/show_bug.cgi?id=1046421, https://bugzilla.mozilla.org/show_bug.cgi?id=1261591, tor-browser#27602 - - - - - e0cdcb34 by cypherpunks1 at 2024-12-19T12:01:52+01:00 BB 40717: Hide Windows SSO in settings - - - - - ab3aed9f by Georg Koppen at 2024-12-19T12:01:53+01:00 BB 16285: Exclude ClearKey system for now In the past the ClearKey system had not been compiled when specifying --disable-eme. But that changed and it is even bundled nowadays (see: Mozilla's bug 1300654). We don't want to ship it right now as the use case for it is not really visible while the code had security vulnerabilities in the past. - - - - - c577cc5b by Kathy Brade at 2024-12-19T12:01:53+01:00 BB 21431: Clean-up system extensions shipped in Firefox Only ship the pdfjs extension. - - - - - f9a662fb by Henry Wilkes at 2024-12-19T12:01:53+01:00 BB 42831: Remove the shopping components. - - - - - 3d8aa55a by Kathy Brade at 2024-12-19T12:01:54+01:00 BB 33852: Clean up about:logins (LockWise) to avoid mentioning sync, etc. Hide elements on about:logins that mention sync, "Firefox LockWise", and Mozilla's LockWise mobile apps. Disable the "Create New Login" button when security.nocertdb is true. - - - - - b5c3254d by Alex Catarineu at 2024-12-19T12:01:54+01:00 BB 41457: Remove Mozilla permissions Bug 40025: Remove Mozilla add-on install permissions - - - - - 4b31899d by Kathy Brade at 2024-12-19T12:01:55+01:00 BB 40002: Remove about:ion Firefox Ion (previously Firefox Pioneer) is an opt-in program in which people volunteer to participate in studies that collect detailed, sensitive data about how they use their browser. Bug 41662: Disable about:sync-logs Even though we disable sync by default with `identity.fxaccounts.enabled`, this about: page is still avilable. We could throw an exception on the constructor of the related component, but it would result only in an error in the console, without a visible "this address does not look right" error page. If we fix the issues with MOZ_SERVICES_SYNC, we can restore the component. - - - - - 18c1f96b by Morgan at 2024-12-19T12:01:55+01:00 BB 42716: Disable unwanted about: pages - - - - - a11a1a73 by Arthur Edelstein at 2024-12-19T12:01:55+01:00 BB 26353: Prevent speculative connect that violated FPI. Connections were observed in the catch-all circuit when the user entered an https or http URL in the URL bar, or typed a search term. - - - - - 3b6e7868 by Alex Catarineu at 2024-12-19T12:01:56+01:00 BB 31740: Remove some unnecessary RemoteSettings instances More concretely, SearchService.jsm 'hijack-blocklists' and url-classifier-skip-urls. Avoid creating instance for 'anti-tracking-url-decoration'. If prefs are disabling their usage, avoid creating instances for 'cert-revocations' and 'intermediates'. Do not ship JSON dumps for collections we do not expect to need. For the ones in the 'main' bucket, this prevents them from being synced unnecessarily (the code in remote-settings does so for collections in the main bucket for which a dump or local data exists). For the collections in the other buckets, we just save some size by not shipping their dumps. We also clear the collections database on the v2 -> v3 migration. - - - - - bf46aff1 by cypherpunks1 at 2024-12-19T12:01:56+01:00 BB 41092: Add a RemoteSettings JSON dump for query-stripping - - - - - c31315de by cypherpunks1 at 2024-12-19T12:01:56+01:00 BB 42730: Patch RemoteSettings to use only local dumps as a data source - - - - - beb1c34a by Pier Angelo Vendrame at 2024-12-19T12:01:57+01:00 BB 41635: Disable the Normandy component Do not include Normandy at all whenever MOZ_NORMANDY is False. - - - - - e3513fc8 by Georg Koppen at 2024-12-19T12:01:57+01:00 BB 30541: Disable WebGL readPixel() for web content Related Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1428034 - - - - - 2fa03a79 by Alex Catarineu at 2024-12-19T12:01:57+01:00 BB 28369: Stop shipping pingsender executable - - - - - 075de59a by Henry Wilkes at 2024-12-19T12:01:58+01:00 BB 42630: Disable LaterRun module. - - - - - f956138b by Pier Angelo Vendrame at 2024-12-19T12:01:58+01:00 BB 41599: Always return an empty string as network ID Firefox computes an internal network ID used to detect network changes and act consequently (e.g., to improve WebSocket UX). However, there are a few ways to get this internal network ID, so we patch them out, to be sure any new code will not be able to use them and possibly link users. We also sent a patch to Mozilla to seed the internal network ID, to prevent any accidental leak in the future. Upstream: https://bugzilla.mozilla.org/show_bug.cgi?id=1817756 - - - - - b872add4 by Pier Angelo Vendrame at 2024-12-19T12:01:59+01:00 BB 42647: Make OS HTTP User-Agent OS spoofing configurable by pref This commits makes it possible to disable OS spoofing in the HTTP User-Agent header, to see if matching header and JS property improve usability. - - - - - b9508f9b by Richard Pospesel at 2024-12-19T12:01:59+01:00 BB 41327: Disable UrlbarProviderInterventions - - - - - be864fb4 by Richard Pospesel at 2024-12-19T12:01:59+01:00 BB 42037: Disable about:firefoxview page - - - - - f9b6cd45 by Mike Perry at 2024-12-19T12:02:00+01:00 Firefox preference overrides. - - - - - a108b73e by Pier Angelo Vendrame at 2024-12-19T12:02:00+01:00 BB 43140: Tighten up fonts on Linux. We ship a fontconfig configuration to esnure all Linux users have the same defaults and reduce the chances of fingerprinting. We used to add this file in tor-browser-build, but some users might skip it by using the browser executable without the wrapper script. Therefore, we decided to activate the file with the FontConfig API instead of the environment variables. Bug 41043: Hardcode the UI font on Linux The mechanism to choose the UI font does not play well with our fontconfig configuration. As a result, the final criterion to choose the font for the UI was its version. Since we hardcode Arimo as a default sans-serif on preferences, we use it also for the UI. FontConfig will fall back to some other font for scripts Arimo does not cover as expected (we tested with Japanese). Bug 43141: Hardcode system-ui to Arimo. - - - - - b7f06c47 by Pier Angelo Vendrame at 2024-12-19T12:02:00+01:00 BB 41901: Hardcode normalized FontSubstitutes. Windows has a system to set font aliases through the registry. This allows some customization that could be used as a fingerprinting vector. Moreover, this mechanism is used by Windows itself, and different SKUs might have different default FontSubstitutes. - - - - - c0099e1d by Pier Angelo Vendrame at 2024-12-19T12:02:01+01:00 BB 43322: Customize the font visibility lists. Customize the lists of fonts to assign base visibility to in base browser and derivatives. Also, rename the files with the upstream lists, to make sure we do not use them by mistake. - - - - - dea815a8 by Alex Catarineu at 2024-12-19T12:02:01+01:00 BB 30605: Honor privacy.spoof_english in Android This checks `privacy.spoof_english` whenever `setLocales` is called from Fenix side and sets `intl.accept_languages` accordingly. Bug 40198: Expose privacy.spoof_english pref in GeckoView - - - - - d3ea5533 by Pier Angelo Vendrame at 2024-12-19T12:02:01+01:00 BB 42562: Normalized the Accepted Languages on Android. The OS language might be outside the list of actually supported languages and it might leak the user's region. Therefore, we force the locale reported in Accept-Language to match one we support with translations, even when it means using a not exact region tag. - - - - - 7c5698db by Alex Catarineu at 2024-12-19T12:02:02+01:00 BB 40171: Make WebRequest and GeckoWebExecutor First-Party aware - - - - - aabf4a6e by Alex Catarineu at 2024-12-19T12:02:02+01:00 BB 26345: Hide tracking protection UI - - - - - 758bd7f7 by Henry Wilkes at 2024-12-19T12:02:03+01:00 BB 43109: Hide Firefox Relay from settings. This should remain disabled, see tor-browser#42814. - - - - - 8afe46fb by Henry Wilkes at 2024-12-19T12:02:03+01:00 BB 42777: Hide Website Privacy Preferences. We hide the Website Privacy Preferences section, which controls the "global privacy control" (GPC) and "do not track" (DNT) settings. - - - - - 9878481e by Morgan at 2024-12-19T12:02:05+01:00 BB 42070: Hide "Use smooth scrolling" from settings - - - - - 8bf48b3a by Arthur Edelstein at 2024-12-19T12:02:06+01:00 BB 18905: Hide unwanted items from help menu Bug 25660: Remove the "New Private Window" option - - - - - d948bd5a by Pier Angelo Vendrame at 2024-12-19T12:02:06+01:00 BB 41739: Remove "Website appearance" from about:preferences. It is ignored because of RFP and it is confusing for users. - - - - - f2317acc by Henry Wilkes at 2024-12-19T12:02:06+01:00 BB 43117: Hide "Always underline links" from settings. - - - - - 125fd15b by Pier Angelo Vendrame at 2024-12-19T12:02:07+01:00 BB 42774: Always hide the third-pary certs UI. - - - - - de9ea06f by Henry Wilkes at 2024-12-19T12:02:07+01:00 BB 43118: Hide feature recommendation (CFR) settings. - - - - - 868e3bbb by Pier Angelo Vendrame at 2024-12-19T12:02:08+01:00 BB 9173: Change the default Firefox profile directory to be relative. This commit makes Firefox look for the default profile directory in a directory relative to the binary path. The directory can be specified through the --with-relative-data-dir. This is relative to the same directory as the firefox main binary for Linux and Windows. On macOS, we remove Contents/MacOS from it. Or, in other words, the directory is relative to the application bundle. This behavior can be overriden at runtime, by placing a file called system-install adjacent to the firefox main binary (also on macOS). - - - - - 38418d33 by Pier Angelo Vendrame at 2024-12-19T12:02:08+01:00 BB 42773: Replace ~ with the original home. In Bug 93141, Mozilla started sending users to their home when they type ~ in the URL bar. On Linux, we change $HOME for various reason, therefore you would be redirected to the spoofed home directory when typing ~. So, we check if the original home directory is known, and use that, instead. - - - - - c868a9f0 by Alex Catarineu at 2024-12-19T12:02:08+01:00 BB 27604: Fix addon issues when moving the profile directory Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1429838 - - - - - 34853cda by Mike Perry at 2024-12-19T12:02:09+01:00 BB 13028: Prevent potential proxy bypass cases. It looks like these cases should only be invoked in the NSS command line tools, and not the browser, but I decided to patch them anyway because there literally is a maze of network function pointers being passed around, and it's very hard to tell if some random code might not pass in the proper proxied versions of the networking code here by accident. Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1433509 - - - - - ef13b6cd by Pier Angelo Vendrame at 2024-12-19T12:02:09+01:00 BB 40309: Avoid using regional OS locales Avoid regional OS locales if the pref `intl.regional_prefs.use_os_locales` is false but RFP is enabled. - - - - - 38671a19 by Matthew Finkel at 2024-12-19T12:02:09+01:00 BB 40432: Prevent probing installed applications Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1711084 - - - - - a252e9a2 by cypherpunks1 at 2024-12-19T12:02:10+01:00 BB 33955: When copying an image only copy the image contents to the clipboard - - - - - 94658bcd by cypherpunks1 at 2024-12-19T12:02:10+01:00 BB 41791: Omit the source URL when copying page contents to the clipboard - - - - - 1c29f937 by hackademix at 2024-12-19T12:02:10+01:00 BB 42288: Allow language spoofing in status messages. - - - - - 91fbce7f by Pier Angelo Vendrame at 2024-12-19T12:02:11+01:00 BB 43196: Remove the vendor name from media notifications on Linux. Firefox shows "vendor remoteName" as a title of the "... is playing media" notification on Linux. However, for our browser the remote name is enough, and prepending the vendor to it creates a string users usually never see. - - - - - c6aff243 by Pier Angelo Vendrame at 2024-12-19T12:02:11+01:00 Base Browser strings This commit adds all the strings needed by following Base Browser patches. - - - - - 51a194f9 by Henry Wilkes at 2024-12-19T12:02:11+01:00 BB 42583: Modify moz-support-link for Base Browser. - - - - - 33ae13e1 by Pier Angelo Vendrame at 2024-12-19T12:02:12+01:00 BB 41369: Improve Firefox language settings for multi-lingual packages Change the language selector to be sorted by language code, rather than name, and to display the language code to the user. Bug 41372: Handle Japanese as a special case in preferences on macOS Japanese is treated in a special way on macOS. However, seeing the Japanese language tag could be confusing for users, and moreover the language name is not localized correctly like other langs. Bug 41378: Tell users that they can change their language at the first start With multi-lingual builds, Tor Browser matches the user's system language, but some users might want to change it. So, we tell them that it is possible, but only once. - - - - - 00d4d25b by p13dz at 2024-12-19T12:02:12+01:00 BB 40283: Workaround for the file upload bug - - - - - db2f9468 by hackademix at 2024-12-19T12:02:13+01:00 BB 42019: Empty browser's clipboard on browser shutdown - - - - - 07a99870 by hackademix at 2024-12-19T12:02:13+01:00 BB 42084: Ensure English spoofing works even if preferences are set out of order. - - - - - c678351c by Pier Angelo Vendrame at 2024-12-19T12:02:13+01:00 BB 41930: Remove the UI to customize accept_languages. - - - - - 07a691f5 by hackademix at 2024-12-19T12:02:14+01:00 BB 41434: Letterboxing, improve logging. - - - - - 246d4ca3 by hackademix at 2024-12-19T12:02:14+01:00 BB 41434: Letterboxing, preemptively apply margins in a global CSS rule to mitigate race conditions on newly created windows and tabs. - - - - - f2b88908 by hackademix at 2024-12-19T12:02:14+01:00 BB 31064: Letterboxing, exempt browser extensions. - - - - - a46d6323 by hackademix at 2024-12-19T12:02:15+01:00 BB 32411: Letterboxing, exempt view-source: URIs. - - - - - a9aee91e by hackademix at 2024-12-19T12:02:15+01:00 BB 42574: Letterboxing, exempt pdf.js. - - - - - 1fec08ef by hackademix at 2024-12-19T12:02:15+01:00 BB 32308: Use direct browser sizing for letterboxing. Bug 30556: align letterboxing with 200x100 new win width stepping - - - - - 14272b99 by hackademix at 2024-12-19T12:02:16+01:00 BB 41631: Prevent weird initial window dimensions caused by subpixel computations - - - - - b461424b by hackademix at 2024-12-19T12:02:16+01:00 BB 41918: Option to reuse last window size when letterboxing is enabled. - - - - - 8466f4c3 by hackademix at 2024-12-19T12:02:17+01:00 BB 41916: Letterboxing preferences UI - - - - - 62a94fe6 by hackademix at 2024-12-19T12:02:17+01:00 BB 41695: Warn on window maximization without letterboxing in RFPHelper module - - - - - 2217f09c by hackademix at 2024-12-19T12:02:17+01:00 BB 42443: Shrink window to match letterboxing size when the emtpy area is clicked. - - - - - 84929c5a by Henry Wilkes at 2024-12-19T12:02:18+01:00 BB 42528: Don't leak system scrollbar size on windows. - - - - - b94ced07 by Henry Wilkes at 2024-12-19T12:02:18+01:00 BB 31575: Disable Firefox Home (Activity Stream) Treat about:blank as the default home page and new tab page. Avoid loading AboutNewTab in BrowserGlue.sys.mjs in order to avoid several network requests that we do not need. Bug 41624: Disable about:pocket-* pages. Bug 40144: Redirect about:privatebrowsing to the user's home - - - - - e004fed1 by Kathy Brade at 2024-12-19T12:02:18+01:00 BB 4234: Use the Firefox Update Process for Base Browser. Windows: disable "runas" code path in updater (15201). Windows: avoid writing to the registry (16236). Also includes fixes for tickets 13047, 13301, 13356, 13594, 15406, 16014, 16909, 24476, and 25909. Also fix bug 27221: purge the startup cache if the Base Browser version changed (even if the Firefox version and build ID did not change), e.g., after a minor Base Browser update. Also fix 32616: Disable GetSecureOutputDirectoryPath() functionality. Bug 26048: potentially confusing "restart to update" message Within the update doorhanger, remove the misleading message that mentions that windows will be restored after an update is applied, and replace the "Restart and Restore" button label with an existing "Restart to update Tor Browser" string. Bug 28885: notify users that update is downloading Add a "Downloading Base Browser update" item which appears in the hamburger (app) menu while the update service is downloading a MAR file. Before this change, the browser did not indicate to the user that an update was in progress, which is especially confusing in Tor Browser because downloads often take some time. If the user clicks on the new menu item, the about dialog is opened to allow the user to see download progress. As part of this fix, the update service was changed to always show update-related messages in the hamburger menu, even if the update was started in the foreground via the about dialog or via the "Check for Tor Browser Update" toolbar menu item. This change is consistent with the Tor Browser goal of making sure users are informed about the update process. Removed #28885 parts of this patch which have been uplifted to Firefox. - - - - - eb753633 by Pier Angelo Vendrame at 2024-12-19T12:02:19+01:00 BB 42061: Create an alpha update channel. - - - - - ef559ac0 by Nicolas Vigier at 2024-12-19T12:02:19+01:00 BB 41682: Add base-browser nightly mar signing key - - - - - 433064e1 by Pier Angelo Vendrame at 2024-12-19T12:02:19+01:00 BB 41603: Customize the creation of MOZ_SOURCE_URL MOZ_SOURCE_URL is created by combining MOZ_SOURCE_REPO and MOZ_SOURCE_CHANGESET. But the code takes for granted that it refers to a Hg instance, so it combines them as `$MOZ_SOURCE_REPO/rev/$MOZ_SOURCE_CHANGESET`. With this commit, we change this logic to combine them to create a URL that is valid for GitLab. $MOZ_SOURCE_CHANGESET needs to be a commit hash, not a branch or a tag. If that is needed, we could use /-/tree/, instead of /-/commit/. - - - - - 1f38001d by Pier Angelo Vendrame at 2024-12-19T12:02:23+01:00 BB 41698: Reword the recommendation badges in about:addons Firefox strings use { -brand-product-name }. As a result, it seems that the fork is recommending extensions, whereas AMO curators are doing that. So, we replace the strings with custom ones that clarify that Mozilla is recommending them. We assign the strings with JS because our translation backend does not support Fluent attributes, yet, but once it does, we should switch to them, instead. Upstream bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1825033 - - - - - 792eec77 by Pier Angelo Vendrame at 2024-12-19T12:02:24+01:00 BB 42438: Tweaks to the migration wizard. Remove the items not compatible with our features (such as history) from the migration wizard. On Linux, allow to specify an alternative home directory, since we usually change $HOME in our startup script. - - - - - acc5fbfe by Alex Catarineu at 2024-12-19T12:02:24+01:00 BB 40069: Add helpers for message passing with extensions - - - - - 8f983aa1 by Matthew Finkel at 2024-12-19T12:02:24+01:00 BB 41598: Prevent NoScript from being removed/disabled. Bug 40253: Explicitly allow NoScript in Private Browsing mode. - - - - - 2a72fed7 by Henry Wilkes at 2024-12-19T12:02:25+01:00 BB 41581: Hide NoScript extension's toolbar button by default. This hides it from both the toolbar and the unified extensions panel. We also hide the unified-extension-button if the panel would be empty: not including the NoScript button when it is hidden. As a result, this will be hidden by default until a user installs another extension (or shows the NoScript button and unpins it). - - - - - ecf73dfd by hackademix at 2024-12-19T12:02:25+01:00 BB 41834: Hide "Can't Be Removed - learn more" menu line for uninstallable add-ons - - - - - 9433cbec by Pier Angelo Vendrame at 2024-12-19T12:02:25+01:00 BB 40925: Implemented the Security Level component This component adds a new Security Level toolbar button which visually indicates the current global security level via icon (as defined by the extensions.torbutton.security_slider pref), a drop-down hanger with a short description of the current security level, and a new section in the about:preferences#privacy page where users can change their current security level. In addition, the hanger and the preferences page will show a visual warning when the user has modified prefs associated with the security level and provide a one-click 'Restore Defaults' button to get the user back on recommended settings. Bug 40125: Expose Security Level pref in GeckoView - - - - - 7ceb0933 by Pier Angelo Vendrame at 2024-12-19T12:02:26+01:00 BB 40926: Implemented the New Identity feature - - - - - 31fa720c by Henry Wilkes at 2024-12-19T12:02:26+01:00 BB 41736: Customize toolbar for base-browser. - - - - - b0b8981a by Pier Angelo Vendrame at 2024-12-19T12:02:27+01:00 BB 42027: Base Browser migration procedures. This commit implmenents the the Base Browser's version of _migrateUI. - - - - - 973df0ca by Henry Wilkes at 2024-12-19T12:02:27+01:00 TB 42308: Create README for tor-browser. We drop the README.txt that comes from Mozilla Firefox and add README.md for tor-browser. - - - - - b4bfe937 by Richard Pospesel at 2024-12-19T12:02:27+01:00 TB 41649: Create rebase and security backport gitlab issue templates - - - - - ebc7a34d by Beatriz Rizental at 2024-12-19T12:02:28+01:00 Add CI for Tor Browser - - - - - 6e784018 by Richard Pospesel at 2024-12-19T12:02:29+01:00 TB 41089: Add tor-browser build scripts + Makefile to tor-browser - - - - - 4f591ed6 by Henry Wilkes at 2024-12-19T12:02:29+01:00 TB 41803: Add some developer tools for working on tor-browser. - - - - - d8214740 by Kathy Brade at 2024-12-19T12:02:29+01:00 TB 11641: Disable remoting by default. Unless the -osint command line flag is used, the browser now defaults to the equivalent of -no-remote. There is a new -allow-remote flag that may be used to restore the original (Firefox-like) default behavior. - - - - - 270b1ac3 by Alex Catarineu at 2024-12-19T12:02:30+01:00 Add TorStrings module for localization - - - - - 289204a0 by Henry Wilkes at 2024-12-19T12:02:30+01:00 Tor Browser strings This commit adds all the strings needed for Tor Browser patches. - - - - - 2ce959d3 by Henry Wilkes at 2024-12-19T12:02:31+01:00 Tor Browser localization migration scripts. - - - - - 88bfe426 by Henry Wilkes at 2024-12-19T12:02:31+01:00 TB 42305: Add script to combine translation files across versions. - - - - - 561512fd by Mike Perry at 2024-12-19T12:02:31+01:00 TB 2176: Rebrand Firefox to TorBrowser See also Bugs #5194, #7187, #8115, #8219. This patch does some basic renaming of Firefox to TorBrowser. The rest of the branding is done by images and icons. Also fix bug 27905. Bug 25702: Update Tor Browser icon to follow design guidelines - Updated all of the branding in /browser/branding/official with new 'stable' icon series. - Updated /extensions/onboarding/content/img/tor-watermark.png with new icon and add the source svg in the same directory - Copied /browser/branding/official over /browser/branding/nightly and the new /browser/branding/alpha directories. Replaced content with 'nightly' and 'alpha' icon series. Updated VisualElements_70.png and VisualElements_150.png with updated icons in each branding directory (fixes #22654) - Updated firefox.VisualElementsManfiest.xml with updated colors in each branding directory - Added firefox.svg to each branding directory from which all the other icons are derived (apart from document.icns and document.ico) - Added default256.png and default512.png icons - Updated aboutTBUpdate.css to point to branding-aware icon128.png and removed original icon - Use the Tor Browser icon within devtools/client/themes/images/. Bug 30631: Blurry Tor Browser icon on macOS app switcher It would seem the png2icns tool does not generate correct icns files and so on macOS the larger icons were missing resulting in blurry icons in the OS chrome. Regenerated the padded icons in a macOS VM using iconutil. Bug 28196: preparations for using torbutton tor-browser-brand.ftl A small change to Fluent FileSource class is required so that we can register a new source without its supported locales being counted as available locales for the browser. Bug 31803: Replaced about:debugging logo with flat version Bug 21724: Make Firefox and Tor Browser distinct macOS apps When macOS opens a document or selects a default browser, it sometimes uses the CFBundleSignature. Changing from the Firefox MOZB signature to a different signature TORB allows macOS to distinguish between Firefox and Tor Browser. Bug 32092: Fix Tor Browser Support link in preferences For bug 40562, we moved onionPattern* from bug 27476 to here, as about:tor needs these files but it is included earlier. Bug 41278: Create Tor Browser styled pdf logo similar to the vanilla Firefox one Bug 42088: New application icons (used in-app and on linux). Bug 42087: New application icons (windows). - - - - - 845d2b28 by Henry Wilkes at 2024-12-19T12:02:32+01:00 Customize moz-toggle for tor-browser. - - - - - 69214685 by Henry Wilkes at 2024-12-19T12:02:32+01:00 TB 43087: Add onion-pattern to be used on Tor pages. - - - - - 8ad11712 by hackademix at 2024-12-19T12:02:32+01:00 TB 41917: Tor brand-specific styles. - - - - - 55250587 by Henry Wilkes at 2024-12-19T12:02:33+01:00 TB 41817: tor-browser semantic colors. - - - - - 30f6acea by Henry Wilkes at 2024-12-19T12:02:33+01:00 TB 42110: Add TorUIUtils module for common tor component methods. - - - - - f3fd4e77 by Henry Wilkes at 2024-12-19T12:02:33+01:00 Add purple tor version of the loading APNG. - - - - - 8e232855 by Henry Wilkes at 2024-12-19T12:02:34+01:00 TB 42583: Modify moz-support-link for Tor Browser. - - - - - 0b3568d4 by sanketh at 2024-12-19T12:02:34+01:00 TB 40209: Implement Basic Crypto Safety Adds a CryptoSafety actor which detects when you've copied a crypto address from a HTTP webpage and shows a warning. Closes #40209. Bug 40428: Fix string attribute names - - - - - 738b3a59 by Mike Perry at 2024-12-19T12:02:34+01:00 TB3: Tor Browser's official .mozconfigs. Also: Add an --enable-tor-browser-data-outside-app-dir configure option Add --with-tor-browser-version configure option Bug 31457: disable per-installation profiles The dedicated profiles (per-installation) feature does not interact well with our bundled profiles on Linux and Windows, and it also causes multiple profiles to be created on macOS under TorBrowser-Data. Bug 31935: Disable profile downgrade protection. Since Tor Browser does not support more than one profile, disable the prompt and associated code that offers to create one when a version downgrade situation is detected. Add --enable-tor-browser-update build option Bug 40793: moved Tor configuration options from old-configure.in to moz.configure Bug 41584: Move some configuration options to base-browser level - - - - - 4c6f0cc4 by Henry Wilkes at 2024-12-19T12:02:35+01:00 TB 41340: Enable TOR_BROWSER_NIGHTLY_BUILD features for dev and nightly builds tor-browser#41285: Enable fluent warnings. - - - - - 51fc51ed by Pier Angelo Vendrame at 2024-12-19T12:02:35+01:00 TB 40562: Added Tor Browser preferences to 000-tor-browser.js Before reordering patches, we used to keep the Tor-related patches (torbutton and tor-launcher) at the beginning. After that issue, we decided to move them towards the end. In addition to that, we have decided to move Tor Browser-only preferences there, too, to make Base Browser-only fixups easier to apply. - - - - - 00a32d42 by Pier Angelo Vendrame at 2024-12-19T12:02:36+01:00 TB 13252: Customize profile management on macOS On macOS we allow both portable mode and system installation. However, in the latter case, we customize Firefox's directories to match the hierarchy we use for the portable mode. Also, display an informative error message if the TorBrowser-Data directory cannot be created due to an "access denied" or a "read only volume" error. - - - - - e9fcd5ee by Pier Angelo Vendrame at 2024-12-19T12:02:36+01:00 TB 40933: Add tor-launcher functionality Bug 41926: Reimplement the control port - - - - - 28f191f0 by Cecylia Bocovich at 2024-12-19T12:02:36+01:00 Lox integration - - - - - 4e137343 by Richard Pospesel at 2024-12-19T12:02:37+01:00 TB 40597: Implement TorSettings module - migrated in-page settings read/write implementation from about:preferences#tor to the TorSettings module - TorSettings initially loads settings from the tor daemon, and saves them to firefox prefs - TorSettings notifies observers when a setting has changed; currently only QuickStart notification is implemented for parity with previous preference notify logic in about:torconnect and about:preferences#tor - about:preferences#tor, and about:torconnect now read and write settings thorugh the TorSettings module - all tor settings live in the torbrowser.settings.* preference branch - removed unused pref modify permission for about:torconnect content page from AsyncPrefs.jsm Bug 40645: Migrate Moat APIs to Moat.jsm module - - - - - f36eb17d by Arthur Edelstein at 2024-12-19T12:02:37+01:00 TB 3455: Add DomainIsolator, for isolating circuit by domain. Add an XPCOM component that registers a ProtocolProxyChannelFilter which sets the username/password for each web request according to url bar domain. Bug 9442: Add New Circuit button Bug 13766: Set a 10 minute circuit dirty timeout for the catch-all circ. Bug 19206: Include a 128 bit random tag as part of the domain isolator nonce. Bug 19206: Clear out the domain isolator state on `New Identity`. Bug 21201.2: Isolate by firstPartyDomain from OriginAttributes Bug 21745: Fix handling of catch-all circuit Bug 41741: Refactor the domain isolator and new circuit - - - - - 0b5bfd94 by Henry Wilkes at 2024-12-19T12:02:40+01:00 TB 41600: Add a tor circuit display panel. - - - - - d9a89527 by Pier Angelo Vendrame at 2024-12-19T12:02:40+01:00 TB 42247: Android helpers for the TorProvider GeckoView is missing some API we use on desktop for the integration with the tor daemon, such as subprocess. Therefore, we need to implement them in Java and plumb the data back and forth between JS and Java. - - - - - 78145aed by hackademix at 2024-12-19T12:02:41+01:00 TB 8324: Prevent DNS proxy bypasses caused by Drag&Drop Bug 41613: Skip Drang & Drop filtering for DNS-safe URLs - - - - - 9312c5d0 by Matthew Finkel at 2024-12-19T12:02:41+01:00 TB 25741: TBA: Disable GeckoNetworkManager The browser should not need information related to the network interface or network state, tor should take care of that. - - - - - b755ebc9 by Pier Angelo Vendrame at 2024-12-19T12:02:42+01:00 TB 40807: Added QRCode.js to toolkit/modules - - - - - 488d0d6b by Richard Pospesel at 2024-12-19T12:02:42+01:00 TB 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection This patch adds a new about:preferences#connection page which allows modifying bridge, proxy, and firewall settings from within Tor Browser. All of the functionality present in tor-launcher's Network Configuration panel is present: - Setting built-in bridges - Requesting bridges from BridgeDB via moat - Using user-provided bridges - Configuring SOCKS4, SOCKS5, and HTTP/HTTPS proxies - Setting firewall ports - Viewing and Copying Tor's logs - The Networking Settings in General preferences has been removed Bug 40774: Update about:preferences page to match new UI designs - - - - - b78a266b by Richard Pospesel at 2024-12-19T12:02:42+01:00 TB 27476: Implement about:torconnect captive portal within Tor Browser - implements new about:torconnect page as tor-launcher replacement - adds new torconnect component to browser - tor process management functionality remains implemented in tor-launcher through the TorProtocolService module - adds warning/error box to about:preferences#tor when not connected to tor Bug 40773: Update the about:torconnect frontend page to match additional UI flows. Bug 41608: Add a toolbar status button and a urlbar "Connect" button. - - - - - bb664d03 by Pier Angelo Vendrame at 2024-12-19T12:02:43+01:00 Temporary changes to about:torconnect for Android. We are planning of tempoorarily using about:torconnect on Android, until the native UX is ready. - - - - - ee8a82e7 by Henry Wilkes at 2024-12-19T12:02:43+01:00 TB 7494: Create local home page for TBB. Bug 41333: Update about:tor to new design. Including: + make the favicon match the branding icon. + make the location bar show a search icon. - - - - - 5b613c98 by Pier Angelo Vendrame at 2024-12-19T12:02:43+01:00 TB 41668: Tweaks to the Base Browser updater for Tor Browser This commit was once part of "Bug 4234: Use the Firefox Update Process for Tor Browser.". However, some parts of it were not needed for Base Browser and some derivative browsers. Therefore, we extracted from that commit the parts for Tor Browser legacy, and we add them back to the patch set with this commit. - - - - - b2921586 by Kathy Brade at 2024-12-19T12:02:44+01:00 TB 12647: Support symlinks in the updater. - - - - - 02dee94a by Georg Koppen at 2024-12-19T12:02:44+01:00 TB 32658: Create a new MAR signing key It's time for our rotation again: Move the backup key in the front position and add a new backup key. Bug 33803: Move our primary nightly MAR signing key to tor-browser Bug 33803: Add a secondary nightly MAR signing key - - - - - 7512508a by Pier Angelo Vendrame at 2024-12-19T12:02:45+01:00 TB 42891: Set the bundled search engine for Tor Browser. After upstream changes between Firefox 115 and 128, we had to completely rework the way in which we define our search engines. This commit replaces the old "Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing". With that commit, we customized a list of addons IDs to ship as built-in search engines, but then upsteam moved to using only RemoteSettings. The configuration has many more fields, and it would be quite long to include it in the source code. Therefore, we use some local JSON files and load the settings from them. - - - - - 7e845ac2 by Alex Catarineu at 2024-12-19T12:02:45+01:00 TB 40073: Disable remote Public Suffix List fetching In https://bugzilla.mozilla.org/show_bug.cgi?id=1563246 Firefox implemented fetching the Public Suffix List via RemoteSettings and replacing the default one at runtime, which we do not want. - - - - - eb9cd978 by Henry Wilkes at 2024-12-19T12:02:45+01:00 TB 41906: Hide DNS over HTTPS preferences. - - - - - 2830ae7d by Richard Pospesel at 2024-12-19T12:02:46+01:00 TB 23247: Communicating security expectations for .onion Encrypting pages hosted on Onion Services with SSL/TLS is redundant (in terms of hiding content) as all traffic within the Tor network is already fully encrypted. Therefore, serving HTTP pages from an Onion Service is more or less fine. Prior to this patch, Tor Browser would mostly treat pages delivered via Onion Services as well as pages delivered in the ordinary fashion over the internet in the same way. This created some inconsistencies in behaviour and misinformation presented to the user relating to the security of pages delivered via Onion Services: - HTTP Onion Service pages did not have any 'lock' icon indicating the site was secure - HTTP Onion Service pages would be marked as unencrypted in the Page Info screen - Mixed-mode content restrictions did not apply to HTTP Onion Service pages embedding Non-Onion HTTP content This patch fixes the above issues, and also adds several new 'Onion' icons to the mix to indicate all of the various permutations of Onion Services hosted HTTP or HTTPS pages with HTTP or HTTPS content. Strings for Onion Service Page Info page are pulled from Torbutton's localization strings. - - - - - 32db0454 by Kathy Brade at 2024-12-19T12:02:46+01:00 TB 30237: Add v3 onion services client authentication prompt When Tor informs the browser that client authentication is needed, temporarily load about:blank instead of about:neterror and prompt for the user's key. If a correctly formatted key is entered, use Tor's ONION_CLIENT_AUTH_ADD control port command to add the key (via Torbutton's control port module) and reload the page. If the user cancels the prompt, display the standard about:neterror "Unable to connect" page. This requires a small change to browser/actors/NetErrorChild.jsm to account for the fact that the docShell no longer has the failedChannel information. The failedChannel is used to extract TLS-related error info, which is not applicable in the case of a canceled .onion authentication prompt. Add a leaveOpen option to PopupNotifications.show so we can display error messages within the popup notification doorhanger without closing the prompt. Add support for onion services strings to the TorStrings module. Add support for Tor extended SOCKS errors (Tor proposal 304) to the socket transport and SOCKS layers. Improved display of all of these errors will be implemented as part of bug 30025. Also fixes bug 19757: Add a "Remember this key" checkbox to the client auth prompt. Add an "Onion Services Authentication" section within the about:preferences "Privacy & Security section" to allow viewing and removal of v3 onion client auth keys that have been stored on disk. Also fixes bug 19251: use enhanced error pages for onion service errors. - - - - - 15d9694e by Alex Catarineu at 2024-12-19T12:02:46+01:00 TB 21952: Implement Onion-Location Whenever a valid Onion-Location HTTP header (or corresponding HTML <meta> http-equiv attribute) is found in a document load, we either redirect to it (if the user opted-in via preference) or notify the presence of an onionsite alternative with a badge in the urlbar. - - - - - 90c8876e by Pier Angelo Vendrame at 2024-12-19T12:02:47+01:00 TB 40458: Implement .tor.onion aliases We have enabled HTTPS-Only mode, therefore we do not need HTTPS-Everywhere anymore. However, we want to keep supporting .tor.onion aliases (especially for securedrop). Therefore, in this patch we implemented the parsing of HTTPS-Everywhere rulesets, and the redirect of .tor.onion domains. Actually, Tor Browser believes they are actual domains. We change them on the fly on the SOCKS proxy requests to resolve the domain, and on the code that verifies HTTPS certificates. - - - - - a4b2c661 by Pier Angelo Vendrame at 2024-12-19T12:02:47+01:00 TB 11698: Incorporate Tor Browser Manual pages into Tor Browser This patch associates the about:manual page to a translated page that must be injected to browser/omni.ja after the build. The content must be placed in chrome/browser/content/browser/manual/, so that is then available at chrome://browser/content/manual/. We preferred giving absolute freedom to the web team, rather than having to change the patch in case of changes on the documentation. - - - - - c1b60ccb by Pier Angelo Vendrame at 2024-12-19T12:02:48+01:00 TB 41435: Add a Tor Browser migration function For now this function only deletes old language packs for which we are already packaging the strings with the application. - - - - - d5be827b by Dan Ballard at 2024-12-19T12:02:48+01:00 TB 40701: Add security warning when downloading a file Shown in the downloads panel, about:downloads and places.xhtml. - - - - - f5b6f5f1 by Henry Wilkes at 2024-12-19T12:02:48+01:00 TB 41736: Customize toolbar for tor-browser. - - - - - 8c78ba68 by hackademix at 2024-12-19T12:02:49+01:00 TB 41728: Pin bridges.torproject.org domains to Let's Encrypt's root cert public key - - - - - d7c65e6c by Richard Pospesel at 2024-12-19T12:02:49+01:00 TB 41822: Unconditionally disable default browser UX in about:preferences - - - - - 11e1f8b2 by Cecylia Bocovich at 2024-12-19T12:02:49+01:00 Temporary commit: manually place generated wasm files These files are built reproducibly using tor-browser-build: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_re… We're manually adding them here while working on the interface, but eventually these should be placed in the right location using tor-browser-build. - - - - - ab1ff834 by Pier Angelo Vendrame at 2024-12-19T12:02:50+01:00 [android] TBA strings - - - - - 94ad82f6 by Dan Ballard at 2024-12-19T12:02:50+01:00 TB 42660: Disable ProxySelector.openConnectionWithProxy and NOPify CrashReporter.sendCrashReport - - - - - eb811185 by Dan Ballard at 2024-12-19T12:02:50+01:00 TB 43006: Disable RFP for Font Visibility on Android - - - - - 695955d2 by Matthew Finkel at 2024-12-19T12:02:51+01:00 TB 40005: [android] Modify Default toolbar menu Originally android-components#40005. - - - - - 9d13a54f by Alex Catarineu at 2024-12-19T12:02:51+01:00 TB 34378: [android] Port external helper app prompting Together with the corresponding fenix patch, this allows all `startActivity` that may open external apps to be replaced by `TorUtils.startActivityPrompt`. Originally, android-components#40007 and fenix#34378. - - - - - aac8fc19 by Alex Catarineu at 2024-12-19T12:02:52+01:00 TB 40002: [android] Ensure system download manager is not used Originally, android-components#40002. android-components#40075: Support scoped storage to enable downloads on API < 29 - in android-components!7, we blocked all usage of Scoped Storage in an attempt to block usage of Android's DownloadManager, which is known to cause proxy bypasses - as of Android API 29, downloads will not work without Scoped Storage, causing all downlaods to fail (see: fenix##40192) - here, we enable usage of scoped storage for API >= 29, but block calls to DownloadManager on API < 29 - - - - - 5b737918 by Alex Catarineu at 2024-12-19T12:02:52+01:00 TB 40009: [android] Change the default search engines Originally, android-components#40009. This matches the search engines from desktop, that is: DDG as the default, then YouTube, Google, DDGOnion, Startpage, Twitter, Wikipedia and Yahoo. android-components#40062: Update DuckDuckGo onion search plugin - - - - - 34327845 by hackademix at 2024-12-19T12:02:52+01:00 TB 42191: [android] Temporary StrictMode relaxation to clear the thumbnail cache. - - - - - bafbe3d3 by hackademix at 2024-12-19T12:02:53+01:00 [android] Modify add-on support Bug 41160: One-time ultimate switch Tor Browser Android to HTTPS-Only. Bug 41159: Remove HTTPS-Everywhere extension from Tor Browser Android. Bug 41094: Enable HTTPS-Only Mode by default in Tor Browser Android. Turn shouldUseHttpsOnly's default to true. Bug 40225: Bundled extensions don't get updated with Android Tor Browser updates. Bug 40030: Install NoScript addon on startup. Also 40070: Consider storing the list of recommended addons This implements our own AddonsProvider, which loads the list of available addons from assets instead of fetching it from an endpoint. Also, we hide the uninstall button for builtin addons. Bug 40058: Hide option for disallowing addon in private mode - - - - - 359f072a by Alex Catarineu at 2024-12-19T12:02:53+01:00 [android] Modify Addon support android-components#40011: Hide option for disallowing addons in private mode android-components#40016: Allow inheriting from AddonCollectionProvider This will allow implementing our own AddonsProvider in fenix. - - - - - 71904c1c by Alex Catarineu at 2024-12-19T12:02:53+01:00 TB 40015: [android] Port padlock states for .onion services Originally, android-components#40015. - - - - - c4d9e157 by Matthew Finkel at 2024-12-19T12:02:54+01:00 [android] Modify Tracking Protection configuration android-components#40020: Disable third-party cookies android-components#40024: Disable tracking protection by default - - - - - 1b87fed3 by Matthew Finkel at 2024-12-19T12:02:54+01:00 TB 40023: [android] Stop PrivateNotificationService Originally, android-components#40023. - - - - - 1f314d5d by Alex Catarineu at 2024-12-19T12:02:55+01:00 TB 34439 [android]: Isolate Icon loader on Android. Originally, android-components#34439. - - - - - c6cc6178 by Matthew Finkel at 2024-12-19T12:02:56+01:00 [android] Disable features and functionality Bug 33594: Disable data collection by default (Glean) Bug 40019: Adjust is disabled on Release when data collection is disabled Bug 34338: Disable the crash reporter Bug 40014: Neuter Google Advertising ID Bug 40018: Disable Push service Bug 40034: Disable PWA onboading Bug 40072: Disable Tracking Protection Bug 40061: Do not show "Send to device" in sharing menu Bug 40109: Reduce requested permissions Exclude LOCATION and NETWORK_STATE - - - - - 33a0ad86 by Matthew Finkel at 2024-12-19T12:02:56+01:00 TB 40032 [android]: Set usesCleartextTraffic as false Originally, fenix#40032. - - - - - e6959d47 by Matthew Finkel at 2024-12-19T12:02:56+01:00 [android] Rename as Tor Browser Bug 40020: Change applicationId Bug 40020: Change app name Bug 40020: Change deeplink scheme Bug 40020: Change App icons Bug 40073: Use correct branding on About page Bug 40088: Use Tor Browser logo in migration screen - - - - - ad20e633 by Georg Koppen at 2024-12-19T12:02:57+01:00 [android] Modify build system Bug 40083: Make locale ordering in BuildConfig deterministic Bug 40042: Add option do overwrite timestamp in extension version Bug 40059: Use MOZ_BUILD_DATE for versionCode At the same time we adapt MOZ_BUILD_DATE to our needs where it is actually used and not in tor-browser-build. This gives us more flexibility. See: tor-browser-build#40084. Bug 40067: Fix reproducibility issue in classes2.dex We make sure our MOZ_BUILD_DATE gets used as a source for showing date related information on the Fenix about page. Bug 40071: Show only supported locales Bug 40064: Use Gecko Beta for Nightly and Debug variants Bug 40123: Allow building the instrumented tests apks for variants other than debug This allows to specify the variant of the instrumented tests via a `testBuildType` gradle argument. It also applies a workaround for a R8 issue from https://issuetracker.google.com/issues/140851070. Bug 40143: Use deterministic date in Test apk The build config was using Date() when generating the Test apk's versionName. - - - - - 05dd39c2 by Matthew Finkel at 2024-12-19T12:02:57+01:00 TB 40185: [android] Use NimbusDisabled Originally, fenix#40185. - - - - - 729e18f3 by Alex Catarineu at 2024-12-19T12:02:58+01:00 TB 40087 [android]: Implement a switch for spoof English. Originally, fenix#40087 and android-components#40019. - - - - - e5994bea by Matthew Finkel at 2024-12-19T12:02:58+01:00 TB 34403 [android]: Disable Normal mode by default. Originally, fenix#34403. - - - - - e8829c8e by Matthew Finkel at 2024-12-19T12:02:58+01:00 TB 40016 [android]: Don't install WebCompat webext. Originally, fenix#40016. - - - - - 6a026c93 by Matthew Finkel at 2024-12-19T12:02:59+01:00 [android] Modify UI/UX Bug 40015: Modify Home menu Bug 40016: Hide unwanted Settings Bug 40016: Modify Default toolbar menu Bug 40016: Add Donate settings button Bug 40016: Move Allow Screenshots under Advanced Bug 40016: Don't install WebCompat webext Bug 40016: Don't onboard Search Suggestions Bug 40094: Do not use MasterPasswordTipProvider in HomeFragment Bug 40095: Hide "Sign in to sync" in bookmarks Bug 40031: Hide Mozilla-specific items on About page Bug 40063: Do not sort search engines alphabetically Bug 40141: Hide EME site permission Bug 40166: Hide "Normal" tab (again) and Sync tab in TabTray Bug 40167: Hide "Save to Collection" in menu Bug 40172: Find the Quit button Bug 40186: Hide Credit Cards in Settings Bug 40198: Spoof English toggle now overlaps with locale list - - - - - 4e5f11be by Matthew Finkel at 2024-12-19T12:02:59+01:00 TB 40026 [android]: Implement Security Level settings on Android. Originally, fenix#40026. - - - - - 395b9d5e by Dan Ballard at 2024-12-19T12:02:59+01:00 TB 41972: [android] Disable Mozilla onboarding - - - - - d0d4a76d by Dan Ballard at 2024-12-19T12:03:00+01:00 TB 41878: [android] Add standalone Tor Bootstrap - - - - - 2d728dde by Matthew Finkel at 2024-12-19T12:03:00+01:00 TB 40041 [android]: Implement Tor Network Settings Originally, fenix#40041. - - - - - 4922cfa8 by clairehurst at 2024-12-19T12:03:00+01:00 [android] Implement Android-native Connection Assist UI - - - - - 5f8340fa by clairehurst at 2024-12-19T12:03:01+01:00 TB 42655 [android]: Implement "New circuit for this site" on Android - - - - - 12e0f988 by clairehurst at 2024-12-19T12:03:01+01:00 TB 42089: [android] Remove ability to submit site support requests - - - - - 87cdcd52 by clairehurst at 2024-12-19T12:03:02+01:00 [android] Delete unused media - - - - - 30 changed files: - .eslintignore - .gitignore - + .gitlab-ci.yml - + .gitlab/ci/containers/base/Containerfile - + .gitlab/ci/jobs/lint/helpers.py - + .gitlab/ci/jobs/lint/lint.yml - + .gitlab/ci/jobs/startup-test/startup-test.py - + .gitlab/ci/jobs/startup-test/startup-test.yml - + .gitlab/ci/jobs/update-containers.yml - + .gitlab/ci/jobs/update-translations.yml - + .gitlab/ci/mixins.yml - + .gitlab/issue_templates/Backport Android Security Fixes.md - + .gitlab/issue_templates/Emergency Security Issue.md - + .gitlab/issue_templates/QA - Android.md - + .gitlab/issue_templates/QA - Desktop.md - + .gitlab/issue_templates/Rebase Browser - Alpha.md - + .gitlab/issue_templates/Rebase Browser - Legacy.md - + .gitlab/issue_templates/Rebase Browser - Stable.md - + .gitlab/issue_templates/bug.md - + .gitlab/merge_request_templates/Rebase.md - + .gitlab/merge_request_templates/default.md - .prettierignore - + README.md - − README.txt - + browser/actors/CryptoSafetyChild.sys.mjs - + browser/actors/CryptoSafetyParent.sys.mjs - − browser/actors/RFPHelperChild.sys.mjs - − browser/actors/RFPHelperParent.sys.mjs - browser/actors/moz.build - browser/app/Makefile.in The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/0fd07c… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/0fd07c… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.5.0esr-14.5-1] fixup! Add CI for Tor Browser
by morgan (＠morgan) 19 Dec '24

19 Dec '24

morgan pushed to branch tor-browser-128.5.0esr-14.5-1 at The Tor Project / Applications / Tor Browser Commits: b72302ee by Henry Wilkes at 2024-12-19T10:51:08+00:00 fixup! Add CI for Tor Browser Bug 43374: Run translation CI independent of other stages and jobs. - - - - - 1 changed file: - .gitlab/ci/jobs/update-translations.yml Changes: ===================================== .gitlab/ci/jobs/update-translations.yml ===================================== @@ -17,6 +17,7 @@ combine-en-US-translations: extends: .update-translation-base + needs: [] image: python variables: PIP_CACHE_DIR: "$CI_PROJECT_DIR/.cache/pip" View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/b72302e… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/b72302e… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.5.0esr-14.5-1] fixup! Add CI for Base Browser
by morgan (＠morgan) 19 Dec '24

19 Dec '24

morgan pushed to branch mullvad-browser-128.5.0esr-14.5-1 at The Tor Project / Applications / Mullvad Browser Commits: 4dd13c2d by Henry Wilkes at 2024-12-19T10:46:09+00:00 fixup! Add CI for Base Browser Bug 43373: Only run lint CI for push events and merge requests. - - - - - 1 changed file: - .gitlab/ci/lint.yml Changes: ===================================== .gitlab/ci/lint.yml ===================================== @@ -58,7 +58,7 @@ eslint: - 'tools/lint/eslint/eslint-plugin-mozilla/**' - 'tools/lint/eslint/eslint-plugin-spidermonkey-js/**' # Run job whenever a commit is merged to a protected branch - - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true') + - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true' && $CI_PIPELINE_SOURCE == 'push') stylelint: extends: .base @@ -76,7 +76,7 @@ stylelint: - '**/.stylelintignore' - '**/*stylelintrc*' # Run job whenever a commit is merged to a protected branch - - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true') + - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true' && $CI_PIPELINE_SOURCE == 'push') py-black: extends: .base @@ -95,7 +95,7 @@ py-black: - 'pyproject.toml' - 'tools/lint/black.yml' # Run job whenever a commit is merged to a protected branch - - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true') + - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true' && $CI_PIPELINE_SOURCE == 'push') py-ruff: extends: .base @@ -114,7 +114,7 @@ py-ruff: - 'tools/lint/python/ruff.py' - 'tools/lint/python/ruff_requirements.txt' # Run job whenever a commit is merged to a protected branch - - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true') + - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true' && $CI_PIPELINE_SOURCE == 'push') yaml: extends: .base @@ -129,7 +129,7 @@ yaml: - '**/*.yaml' - '**/.ymllint' # Run job whenever a commit is merged to a protected branch - - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true') + - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true' && $CI_PIPELINE_SOURCE == 'push') shellcheck: extends: .base @@ -143,7 +143,7 @@ shellcheck: - '**/*.sh' - 'tools/lint/shellcheck.yml' # Run job whenever a commit is merged to a protected branch - - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true') + - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true' && $CI_PIPELINE_SOURCE == 'push') clang-format: extends: .base @@ -163,7 +163,7 @@ clang-format: - '**/*.mm' - 'tools/lint/clang-format.yml' # Run job whenever a commit is merged to a protected branch - - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true') + - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true' && $CI_PIPELINE_SOURCE == 'push') rustfmt: extends: .base @@ -177,7 +177,7 @@ rustfmt: - '**/*.rs' - 'tools/lint/rustfmt.yml' # Run job whenever a commit is merged to a protected branch - - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true') + - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true' && $CI_PIPELINE_SOURCE == 'push') fluent-lint: extends: .base @@ -192,7 +192,7 @@ fluent-lint: - 'tools/lint/fluent-lint.yml' - 'tools/lint/fluent-lint/exclusions.yml' # Run job whenever a commit is merged to a protected branch - - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true') + - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true' && $CI_PIPELINE_SOURCE == 'push') localization: extends: .base @@ -209,7 +209,7 @@ localization: - 'third_party/python/fluent/**' - 'tools/lint/l10n.yml' # Run job whenever a commit is merged to a protected branch - - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true') + - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true' && $CI_PIPELINE_SOURCE == 'push') mingw-capitalization: extends: .base @@ -226,7 +226,7 @@ mingw-capitalization: - '**/*.h' - 'tools/lint/mingw-capitalization.yml' # Run job whenever a commit is merged to a protected branch - - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true') + - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true' && $CI_PIPELINE_SOURCE == 'push') mscom-init: extends: .base @@ -243,7 +243,7 @@ mscom-init: - '**/*.h' - 'tools/lint/mscom-init.yml' # Run job whenever a commit is merged to a protected branch - - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true') + - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true' && $CI_PIPELINE_SOURCE == 'push') file-whitespace: extends: .base @@ -273,7 +273,7 @@ file-whitespace: - '**/*.java' - 'tools/lint/file-whitespace.yml' # Run job whenever a commit is merged to a protected branch - - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true') + - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true' && $CI_PIPELINE_SOURCE == 'push') test-manifest: extends: .base @@ -288,7 +288,7 @@ test-manifest: - 'python/mozlint/**' - 'tools/lint/**' # Run job whenever a commit is merged to a protected branch - - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true') + - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true' && $CI_PIPELINE_SOURCE == 'push') trojan-source: extends: .base @@ -307,4 +307,4 @@ trojan-source: - '**/*.rs' - 'tools/lint/trojan-source.yml' # Run job whenever a commit is merged to a protected branch - - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true') + - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true' && $CI_PIPELINE_SOURCE == 'push') View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/4dd… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/4dd… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-128.5.0esr-14.5-1] fixup! Add CI for Base Browser
by morgan (＠morgan) 19 Dec '24

19 Dec '24

morgan pushed to branch base-browser-128.5.0esr-14.5-1 at The Tor Project / Applications / Tor Browser Commits: c0a4164a by Henry Wilkes at 2024-12-19T10:45:02+00:00 fixup! Add CI for Base Browser Bug 43373: Only run lint CI for push events and merge requests. - - - - - 1 changed file: - .gitlab/ci/lint.yml Changes: ===================================== .gitlab/ci/lint.yml ===================================== @@ -58,7 +58,7 @@ eslint: - 'tools/lint/eslint/eslint-plugin-mozilla/**' - 'tools/lint/eslint/eslint-plugin-spidermonkey-js/**' # Run job whenever a commit is merged to a protected branch - - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true') + - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true' && $CI_PIPELINE_SOURCE == 'push') stylelint: extends: .base @@ -76,7 +76,7 @@ stylelint: - '**/.stylelintignore' - '**/*stylelintrc*' # Run job whenever a commit is merged to a protected branch - - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true') + - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true' && $CI_PIPELINE_SOURCE == 'push') py-black: extends: .base @@ -95,7 +95,7 @@ py-black: - 'pyproject.toml' - 'tools/lint/black.yml' # Run job whenever a commit is merged to a protected branch - - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true') + - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true' && $CI_PIPELINE_SOURCE == 'push') py-ruff: extends: .base @@ -114,7 +114,7 @@ py-ruff: - 'tools/lint/python/ruff.py' - 'tools/lint/python/ruff_requirements.txt' # Run job whenever a commit is merged to a protected branch - - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true') + - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true' && $CI_PIPELINE_SOURCE == 'push') yaml: extends: .base @@ -129,7 +129,7 @@ yaml: - '**/*.yaml' - '**/.ymllint' # Run job whenever a commit is merged to a protected branch - - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true') + - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true' && $CI_PIPELINE_SOURCE == 'push') shellcheck: extends: .base @@ -143,7 +143,7 @@ shellcheck: - '**/*.sh' - 'tools/lint/shellcheck.yml' # Run job whenever a commit is merged to a protected branch - - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true') + - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true' && $CI_PIPELINE_SOURCE == 'push') clang-format: extends: .base @@ -163,7 +163,7 @@ clang-format: - '**/*.mm' - 'tools/lint/clang-format.yml' # Run job whenever a commit is merged to a protected branch - - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true') + - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true' && $CI_PIPELINE_SOURCE == 'push') rustfmt: extends: .base @@ -177,7 +177,7 @@ rustfmt: - '**/*.rs' - 'tools/lint/rustfmt.yml' # Run job whenever a commit is merged to a protected branch - - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true') + - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true' && $CI_PIPELINE_SOURCE == 'push') fluent-lint: extends: .base @@ -192,7 +192,7 @@ fluent-lint: - 'tools/lint/fluent-lint.yml' - 'tools/lint/fluent-lint/exclusions.yml' # Run job whenever a commit is merged to a protected branch - - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true') + - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true' && $CI_PIPELINE_SOURCE == 'push') localization: extends: .base @@ -209,7 +209,7 @@ localization: - 'third_party/python/fluent/**' - 'tools/lint/l10n.yml' # Run job whenever a commit is merged to a protected branch - - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true') + - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true' && $CI_PIPELINE_SOURCE == 'push') mingw-capitalization: extends: .base @@ -226,7 +226,7 @@ mingw-capitalization: - '**/*.h' - 'tools/lint/mingw-capitalization.yml' # Run job whenever a commit is merged to a protected branch - - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true') + - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true' && $CI_PIPELINE_SOURCE == 'push') mscom-init: extends: .base @@ -243,7 +243,7 @@ mscom-init: - '**/*.h' - 'tools/lint/mscom-init.yml' # Run job whenever a commit is merged to a protected branch - - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true') + - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true' && $CI_PIPELINE_SOURCE == 'push') file-whitespace: extends: .base @@ -273,7 +273,7 @@ file-whitespace: - '**/*.java' - 'tools/lint/file-whitespace.yml' # Run job whenever a commit is merged to a protected branch - - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true') + - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true' && $CI_PIPELINE_SOURCE == 'push') test-manifest: extends: .base @@ -288,7 +288,7 @@ test-manifest: - 'python/mozlint/**' - 'tools/lint/**' # Run job whenever a commit is merged to a protected branch - - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true') + - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true' && $CI_PIPELINE_SOURCE == 'push') trojan-source: extends: .base @@ -307,4 +307,4 @@ trojan-source: - '**/*.rs' - 'tools/lint/trojan-source.yml' # Run job whenever a commit is merged to a protected branch - - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true') + - if: ($CI_COMMIT_BRANCH && $CI_COMMIT_REF_PROTECTED == 'true' && $CI_PIPELINE_SOURCE == 'push') View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/c0a4164… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/c0a4164… You're receiving this email because of your account on gitlab.torproject.org.

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

tor-commits