- tor-commits - lists.torproject.org

[tor/master] Remove bogus comment claiming that an assertion is triggerable by consensus
by nickm＠torproject.org 03 Aug '12

03 Aug '12

commit 82c5e385cbddec4fd80618d6e96111ad73d5a22e Author: Robert Ransom <rransom.8774(a)gmail.com> Date: Thu Jun 14 15:41:11 2012 +0000 Remove bogus comment claiming that an assertion is triggerable by consensus --- src/or/routerlist.c | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/or/routerlist.c b/src/or/routerlist.c index de1a66c..37de70f 100644 --- a/src/or/routerlist.c +++ b/src/or/routerlist.c @@ -1983,9 +1983,10 @@ smartlist_choose_node_by_bandwidth(smartlist_t *sl, if (is_guard) bitarray_set(guard_bits, i); if (is_known) { - bandwidths[i] = (int32_t) this_bw; // safe since MAX_BELIEVABLE<INT32_MAX - // XXX this is no longer true! We don't always cap the bw anymore. Can - // a consensus make us overflow?-sh + bandwidths[i] = (int32_t) this_bw; + /* Casting this_bw to int32_t is safe because both kb_to_bytes + and bridge_get_advertised_bandwidth_bounded limit it to below + INT32_MAX. */ tor_assert(bandwidths[i] >= 0); if (is_guard) total_guard_bw += this_bw;

1 0

[tor/master] Merge remote-tracking branch 'origin/maint-0.2.3'
by nickm＠torproject.org 03 Aug '12

03 Aug '12

commit 860c4fc81166568f2909708c455ca6a70d81a2f8 Merge: 6c64681 82c5e38 Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Aug 3 11:46:03 2012 -0400 Merge remote-tracking branch 'origin/maint-0.2.3' src/or/routerlist.c | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-)

1 0

[tor/maint-0.2.3] Remove bogus comment claiming that an assertion is triggerable by consensus
by nickm＠torproject.org 03 Aug '12

03 Aug '12

commit 82c5e385cbddec4fd80618d6e96111ad73d5a22e Author: Robert Ransom <rransom.8774(a)gmail.com> Date: Thu Jun 14 15:41:11 2012 +0000 Remove bogus comment claiming that an assertion is triggerable by consensus --- src/or/routerlist.c | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/or/routerlist.c b/src/or/routerlist.c index de1a66c..37de70f 100644 --- a/src/or/routerlist.c +++ b/src/or/routerlist.c @@ -1983,9 +1983,10 @@ smartlist_choose_node_by_bandwidth(smartlist_t *sl, if (is_guard) bitarray_set(guard_bits, i); if (is_known) { - bandwidths[i] = (int32_t) this_bw; // safe since MAX_BELIEVABLE<INT32_MAX - // XXX this is no longer true! We don't always cap the bw anymore. Can - // a consensus make us overflow?-sh + bandwidths[i] = (int32_t) this_bw; + /* Casting this_bw to int32_t is safe because both kb_to_bytes + and bridge_get_advertised_bandwidth_bounded limit it to below + INT32_MAX. */ tor_assert(bandwidths[i] >= 0); if (is_guard) total_guard_bw += this_bw;

1 0

[tor/master] Avoid possible segfault when handling networkstatus vote with bad flavor
by nickm＠torproject.org 03 Aug '12

03 Aug '12

commit 57e35ad3d91724882c345ac709666a551a977f0f Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Aug 3 10:53:00 2012 -0400 Avoid possible segfault when handling networkstatus vote with bad flavor Fix for 6530; fix on 0.2.2.6-alpha. --- changes/bug6530 | 4 ++++ src/or/routerparse.c | 2 +- 2 files changed, 5 insertions(+), 1 deletions(-) diff --git a/changes/bug6530 b/changes/bug6530 new file mode 100644 index 0000000..a6b7caa --- /dev/null +++ b/changes/bug6530 @@ -0,0 +1,4 @@ + o Major bugfixes: + - Avoid a read of uninitializd RAM when reading a vote or consensus + document with an unrecognized flavor name. Fixes bug 6530; bugfix on + 0.2.2.6-alpha. diff --git a/src/or/routerparse.c b/src/or/routerparse.c index 8c4f582..2ff546b 100644 --- a/src/or/routerparse.c +++ b/src/or/routerparse.c @@ -2821,7 +2821,7 @@ networkstatus_parse_vote_from_string(const char *s, const char **eos_out, int flavor = networkstatus_parse_flavor_name(tok->args[1]); if (flavor < 0) { log_warn(LD_DIR, "Can't parse document with unknown flavor %s", - escaped(tok->args[2])); + escaped(tok->args[1])); goto err; } ns->flavor = flav = flavor;

1 0

[tor/master] Clarify security impact of bug 6530
by nickm＠torproject.org 03 Aug '12

03 Aug '12

commit 55f635745afacefffdaafc72cc176ca7ab817546 Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Aug 3 11:16:13 2012 -0400 Clarify security impact of bug 6530 --- changes/bug6530 | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/changes/bug6530 b/changes/bug6530 index a6b7caa..825bbb7 100644 --- a/changes/bug6530 +++ b/changes/bug6530 @@ -1,4 +1,5 @@ - o Major bugfixes: + o Major security fixes: - Avoid a read of uninitializd RAM when reading a vote or consensus - document with an unrecognized flavor name. Fixes bug 6530; bugfix on - 0.2.2.6-alpha. + document with an unrecognized flavor name. This could lead to a + remote crash bug. Fixes bug 6530; bugfix on 0.2.2.6-alpha. +

1 0

[tor/master] Merge remote-tracking branch 'origin/maint-0.2.3'
by nickm＠torproject.org 03 Aug '12

03 Aug '12

commit babf8e2a859f56befa9a9f8da6697a954ce53f7c Merge: b50eb14 1040afb Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Aug 3 11:23:06 2012 -0400 Merge remote-tracking branch 'origin/maint-0.2.3' changes/bug6530 | 5 +++++ src/or/routerparse.c | 2 +- 2 files changed, 6 insertions(+), 1 deletions(-)

1 0

[tor/master] Merge remote-tracking branch 'origin/maint-0.2.2' into maint-0.2.3
by nickm＠torproject.org 03 Aug '12

03 Aug '12

commit 1040afb2425a8056dc41b35e6d825fc329663ee6 Merge: 122c8ef 55f6357 Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Aug 3 11:18:40 2012 -0400 Merge remote-tracking branch 'origin/maint-0.2.2' into maint-0.2.3 changes/bug6530 | 5 +++++ src/or/routerparse.c | 2 +- 2 files changed, 6 insertions(+), 1 deletions(-)

1 0

[tor/master] Fix a bunch of "implicit 64->32" warnings from introduce refactoring
by nickm＠torproject.org 03 Aug '12

03 Aug '12

commit 6c64681879cca488c2cc017b99ed1e7104da5049 Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Aug 3 11:31:04 2012 -0400 Fix a bunch of "implicit 64->32" warnings from introduce refactoring --- src/or/rendservice.c | 2 +- src/test/test_introduce.c | 2 +- src/test/test_replay.c | 22 +++++++++++----------- 3 files changed, 13 insertions(+), 13 deletions(-) diff --git a/src/or/rendservice.c b/src/or/rendservice.c index 3c5d821..3d8d3e9 100644 --- a/src/or/rendservice.c +++ b/src/or/rendservice.c @@ -1206,7 +1206,7 @@ rend_service_introduce(origin_circuit_t *circuit, const uint8_t *request, /* check for replay of PK-encrypted portion. */ replay = replaycache_add_test_and_elapsed( intro_point->accepted_intro_rsa_parts, - parsed_req->ciphertext, parsed_req->ciphertext_len, + parsed_req->ciphertext, (int)parsed_req->ciphertext_len, &elapsed); if (replay) { diff --git a/src/test/test_introduce.c b/src/test/test_introduce.c index 4fbfd18..992d9cd 100644 --- a/src/test/test_introduce.c +++ b/src/test/test_introduce.c @@ -281,7 +281,7 @@ static void do_parse_test(uint8_t *plaintext, size_t plaintext_len, int phase) { crypto_pk_t *k = NULL; - int r; + ssize_t r; uint8_t *cell = NULL; size_t cell_len; rend_intro_cell_t *parsed_req = NULL; diff --git a/src/test/test_replay.c b/src/test/test_replay.c index 217b555..b08818f 100644 --- a/src/test/test_replay.c +++ b/src/test/test_replay.c @@ -44,7 +44,7 @@ test_replaycache_miss(void) result = replaycache_add_and_test_internal(1200, r, test_buffer, - strlen(test_buffer), NULL); + (int)strlen(test_buffer), NULL); test_eq(result, 0); done: @@ -65,12 +65,12 @@ test_replaycache_hit(void) result = replaycache_add_and_test_internal(1200, r, test_buffer, - strlen(test_buffer), NULL); + (int)strlen(test_buffer), NULL); test_eq(result, 0); result = replaycache_add_and_test_internal(1300, r, test_buffer, - strlen(test_buffer), NULL); + (int)strlen(test_buffer), NULL); test_eq(result, 1); done: @@ -91,17 +91,17 @@ test_replaycache_age(void) result = replaycache_add_and_test_internal(1200, r, test_buffer, - strlen(test_buffer), NULL); + (int)strlen(test_buffer), NULL); test_eq(result, 0); result = replaycache_add_and_test_internal(1300, r, test_buffer, - strlen(test_buffer), NULL); + (int)strlen(test_buffer), NULL); test_eq(result, 1); result = replaycache_add_and_test_internal(3000, r, test_buffer, - strlen(test_buffer), NULL); + (int)strlen(test_buffer), NULL); test_eq(result, 0); done: @@ -123,12 +123,12 @@ test_replaycache_elapsed(void) result = replaycache_add_and_test_internal(1200, r, test_buffer, - strlen(test_buffer), NULL); + (int)strlen(test_buffer), NULL); test_eq(result, 0); result = replaycache_add_and_test_internal(1300, r, test_buffer, - strlen(test_buffer), &elapsed); + (int)strlen(test_buffer), &elapsed); test_eq(result, 1); test_eq(elapsed, 100); @@ -150,17 +150,17 @@ test_replaycache_noexpire(void) result = replaycache_add_and_test_internal(1200, r, test_buffer, - strlen(test_buffer), NULL); + (int)strlen(test_buffer), NULL); test_eq(result, 0); result = replaycache_add_and_test_internal(1300, r, test_buffer, - strlen(test_buffer), NULL); + (int)strlen(test_buffer), NULL); test_eq(result, 1); result = replaycache_add_and_test_internal(3000, r, test_buffer, - strlen(test_buffer), NULL); + (int)strlen(test_buffer), NULL); test_eq(result, 1); done:

1 0

[tor/maint-0.2.3] Avoid possible segfault when handling networkstatus vote with bad flavor
by nickm＠torproject.org 03 Aug '12

03 Aug '12

commit 57e35ad3d91724882c345ac709666a551a977f0f Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Aug 3 10:53:00 2012 -0400 Avoid possible segfault when handling networkstatus vote with bad flavor Fix for 6530; fix on 0.2.2.6-alpha. --- changes/bug6530 | 4 ++++ src/or/routerparse.c | 2 +- 2 files changed, 5 insertions(+), 1 deletions(-) diff --git a/changes/bug6530 b/changes/bug6530 new file mode 100644 index 0000000..a6b7caa --- /dev/null +++ b/changes/bug6530 @@ -0,0 +1,4 @@ + o Major bugfixes: + - Avoid a read of uninitializd RAM when reading a vote or consensus + document with an unrecognized flavor name. Fixes bug 6530; bugfix on + 0.2.2.6-alpha. diff --git a/src/or/routerparse.c b/src/or/routerparse.c index 8c4f582..2ff546b 100644 --- a/src/or/routerparse.c +++ b/src/or/routerparse.c @@ -2821,7 +2821,7 @@ networkstatus_parse_vote_from_string(const char *s, const char **eos_out, int flavor = networkstatus_parse_flavor_name(tok->args[1]); if (flavor < 0) { log_warn(LD_DIR, "Can't parse document with unknown flavor %s", - escaped(tok->args[2])); + escaped(tok->args[1])); goto err; } ns->flavor = flav = flavor;

1 0

[tor/maint-0.2.3] Clarify security impact of bug 6530
by nickm＠torproject.org 03 Aug '12

03 Aug '12

commit 55f635745afacefffdaafc72cc176ca7ab817546 Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Aug 3 11:16:13 2012 -0400 Clarify security impact of bug 6530 --- changes/bug6530 | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/changes/bug6530 b/changes/bug6530 index a6b7caa..825bbb7 100644 --- a/changes/bug6530 +++ b/changes/bug6530 @@ -1,4 +1,5 @@ - o Major bugfixes: + o Major security fixes: - Avoid a read of uninitializd RAM when reading a vote or consensus - document with an unrecognized flavor name. Fixes bug 6530; bugfix on - 0.2.2.6-alpha. + document with an unrecognized flavor name. This could lead to a + remote crash bug. Fixes bug 6530; bugfix on 0.2.2.6-alpha. +

1 0