- tor-commits - lists.torproject.org

[flashproxy/master] Explicitly log to /dev/null to disable a Debian default.
by dcf＠torproject.org 16 Dec '12

16 Dec '12

commit e4a70cf8516fc2140a2fe36e9dcbe7b0f0353c7f Author: David Fifield <david(a)bamsoftware.com> Date: Sun Dec 16 10:35:45 2012 -0800 Explicitly log to /dev/null to disable a Debian default. I thought that omitting a CustomLog line would prevent logging of requests. But Debian has a default configuration file /etc/apache2/conf.d/other-vhosts-access-log with a default log if you don't give your own: # Define an access log for VirtualHosts that don't define their own logfile CustomLog ${APACHE_LOG_DIR}/other_vhosts_access.log vhost_combined --- doc/facilitator-howto.txt | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/doc/facilitator-howto.txt b/doc/facilitator-howto.txt index 1defc9c..9ea5c1f 100644 --- a/doc/facilitator-howto.txt +++ b/doc/facilitator-howto.txt @@ -126,6 +126,7 @@ these contents: ServerName tor-facilitator.bamsoftware.com DocumentRoot /dev/null ScriptAliasMatch ^(.*) /usr/local/bin/facilitator.cgi$1 + CustomLog /dev/null common ErrorLog ${APACHE_LOG_DIR}/error.log LogLevel warn SSLEngine on @@ -136,9 +137,6 @@ intermediate.pem is a possible intermediate certificate file provided by the CA; if you did not get one, then leave off the SSLCertificateChainFile line. -We purposely do not include a CustomLog directive so as to not to log -client and proxy IP addresses. - === HTTPS setup The HTTP server should serve only over HTTPS and not unencrypted HTTP.

1 0

[translation/torbirdy_completed] Update translations for torbirdy_completed
by translation＠torproject.org 16 Dec '12

16 Dec '12

commit 586ea6647459d371de8b727d13a7ca6b1943b146 Author: Translation commit bot <translation(a)torproject.org> Date: Sun Dec 16 10:46:03 2012 +0000 Update translations for torbirdy_completed --- pl/torbirdy.properties | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/pl/torbirdy.properties b/pl/torbirdy.properties index 54c1c97..286ecfa 100644 --- a/pl/torbirdy.properties +++ b/pl/torbirdy.properties @@ -11,3 +11,5 @@ torbirdy.email.prompt=TorBirdy wyłączył kreatora auto-konfiguracji Thunderbir torbirdy.email.advanced=Zmiana ustawień zaawansowanych TorBirdy NIE jest zalecana.\n\nKontynuuj tylko jeśli wiesz, co robisz. torbirdy.email.advanced.nextwarning=Pokaż to ostrzeżenie następnym razem torbirdy.email.advanced.title=Zaawansowane Ustawienia TorBirdy + +torbirdy.restart=Aby ustawienie strefy czasowej odniosło skutek, proszę zamknąć Thunderbirda i ponownie go uruchomić.

1 0

[translation/torbirdy] Update translations for torbirdy
by translation＠torproject.org 16 Dec '12

16 Dec '12

commit 24ba2d56ac8b617b4e85b3ea354aa8f4e748c84f Author: Translation commit bot <translation(a)torproject.org> Date: Sun Dec 16 10:46:00 2012 +0000 Update translations for torbirdy --- pl/torbirdy.properties | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/pl/torbirdy.properties b/pl/torbirdy.properties index 0077b36..286ecfa 100644 --- a/pl/torbirdy.properties +++ b/pl/torbirdy.properties @@ -12,4 +12,4 @@ torbirdy.email.advanced=Zmiana ustawień zaawansowanych TorBirdy NIE jest zaleca torbirdy.email.advanced.nextwarning=Pokaż to ostrzeżenie następnym razem torbirdy.email.advanced.title=Zaawansowane Ustawienia TorBirdy -# torbirdy.restart=For the time zone preference to take effect, please close Thunderbird and start it again. +torbirdy.restart=Aby ustawienie strefy czasowej odniosło skutek, proszę zamknąć Thunderbirda i ponownie go uruchomić.

1 0

[translation/torbirdy_completed] Update translations for torbirdy_completed
by translation＠torproject.org 16 Dec '12

16 Dec '12

commit f63d992126e3b4da290f33c8afa136e0cc350106 Author: Translation commit bot <translation(a)torproject.org> Date: Sun Dec 16 10:16:12 2012 +0000 Update translations for torbirdy_completed --- pl/torbirdy.dtd | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/pl/torbirdy.dtd b/pl/torbirdy.dtd index 7e0d560..5e978c2 100644 --- a/pl/torbirdy.dtd +++ b/pl/torbirdy.dtd @@ -33,6 +33,8 @@ <!ENTITY torbirdy.prefs.imap.key "e"> <!ENTITY torbirdy.prefs.startup_folder.label "Przejdź do ostatniego folderu pocztowego przy uruchomieniu [domyślne: wyłączone, wybierze Foldery Lokalne]"> <!ENTITY torbirdy.prefs.startup_folder.key "l"> +<!ENTITY torbirdy.prefs.timezone.label "Nie ustawiaj strefy czasowej Thunderbirda na UTC [domyślne: ustaw na UTC]"> +<!ENTITY torbirdy.prefs.timezone.key "s"> <!ENTITY torbirdy.prefs.enigmail_throwkeyid.label "Wyłącz GPG '--throw-keyids' [domyślne: włączone]"> <!ENTITY torbirdy.prefs.enigmail_throwkeyid.key "g"> <!ENTITY torbirdy.prefs.account_specific "Specyficzne dla konta">

1 0

[translation/torbirdy] Update translations for torbirdy
by translation＠torproject.org 16 Dec '12

16 Dec '12

commit 71947551e783025d6921a77ab6b18f72319f3fb5 Author: Translation commit bot <translation(a)torproject.org> Date: Sun Dec 16 10:16:08 2012 +0000 Update translations for torbirdy --- pl/torbirdy.dtd | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pl/torbirdy.dtd b/pl/torbirdy.dtd index 6c58ac5..5e978c2 100644 --- a/pl/torbirdy.dtd +++ b/pl/torbirdy.dtd @@ -33,8 +33,8 @@ <!ENTITY torbirdy.prefs.imap.key "e"> <!ENTITY torbirdy.prefs.startup_folder.label "Przejdź do ostatniego folderu pocztowego przy uruchomieniu [domyślne: wyłączone, wybierze Foldery Lokalne]"> <!ENTITY torbirdy.prefs.startup_folder.key "l"> -<!ENTITY torbirdy.prefs.timezone.label ""> -<!ENTITY torbirdy.prefs.timezone.key ""> +<!ENTITY torbirdy.prefs.timezone.label "Nie ustawiaj strefy czasowej Thunderbirda na UTC [domyślne: ustaw na UTC]"> +<!ENTITY torbirdy.prefs.timezone.key "s"> <!ENTITY torbirdy.prefs.enigmail_throwkeyid.label "Wyłącz GPG '--throw-keyids' [domyślne: włączone]"> <!ENTITY torbirdy.prefs.enigmail_throwkeyid.key "g"> <!ENTITY torbirdy.prefs.account_specific "Specyficzne dla konta">

1 0

r25944: {website} add a cute little 'internet freedom' badge next to the flash (website/trunk/docs/en)
by Roger Dingledine 16 Dec '12

16 Dec '12

Author: arma Date: 2012-12-16 09:43:22 +0000 (Sun, 16 Dec 2012) New Revision: 25944 Modified: website/trunk/docs/en/pluggable-transports.wml Log: add a cute little 'internet freedom' badge next to the flashproxy stanza Modified: website/trunk/docs/en/pluggable-transports.wml =================================================================== --- website/trunk/docs/en/pluggable-transports.wml 2012-12-15 06:27:01 UTC (rev 25943) +++ website/trunk/docs/en/pluggable-transports.wml 2012-12-16 09:43:22 UTC (rev 25944) @@ -53,7 +53,10 @@ <a href="https://gitweb.torproject.org/flashproxy.git">git repository</a>, and <a href="http://crypto.stanford.edu/flashproxy/flashproxy.pdf">design paper</a>. - Maintained by David Fifield. <br> + Maintained by David Fifield. + <iframe src="//crypto.stanford.edu/flashproxy/embed.html" width="80" + height="15" frameborder="0" scrolling="no"></iframe> + <br> Status: <em>Implemented and tested, but there are no bundles yet; <a href="https://crypto.stanford.edu/flashproxy/#how-to">need manual setup.</a></em>

1 0

[stem/master] The str_tools functions didn't handle negative values
by atagar＠torproject.org 16 Dec '12

16 Dec '12

commit fc4bdf7ab686b4bbd12e3aefc83d78d0a171df60 Author: Damian Johnson <atagar(a)torproject.org> Date: Sat Dec 15 16:22:30 2012 -0800 The str_tools functions didn't handle negative values Functions like str_tools.get_size_label() provided labels using the smallest unit type if the count was negative. For instance, '-2000000' would be translated into '-2000000 B' rather than '-1 MB'. An inline comment seems to indicate that this was on purpose, but I haven't a clue why. Fixing it. --- stem/util/str_tools.py | 8 +++++--- test/unit/util/str_tools.py | 1 + 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/stem/util/str_tools.py b/stem/util/str_tools.py index 6c36cd0..776ed48 100644 --- a/stem/util/str_tools.py +++ b/stem/util/str_tools.py @@ -280,14 +280,16 @@ def _get_label(units, count, decimal, is_long): (count_per_unit, short_label, long_label) :param int count: number of base units being converted :param int decimal: decimal precision of label - :param bool is_long: uses the long label if **True&&, short label otherwise + :param bool is_long: uses the long label if **True**, short label otherwise """ # formatted string for the requested number of digits label_format = "%%.%if" % decimal - # for zero or negative values use the smallest units - if count < 1: + if count < 0: + label_format = "-" + label_format + count = abs(count) + elif count == 0: units_label = units[-1][2] + "s" if is_long else units[-1][1] return "%s%s" % (label_format % count, units_label) diff --git a/test/unit/util/str_tools.py b/test/unit/util/str_tools.py index e91e324..84fd850 100644 --- a/test/unit/util/str_tools.py +++ b/test/unit/util/str_tools.py @@ -39,6 +39,7 @@ class TestStrTools(unittest.TestCase): self.assertEquals('0.00 B', str_tools.get_size_label(0, 2)) self.assertEquals('-10 B', str_tools.get_size_label(-10)) self.assertEquals('80 b', str_tools.get_size_label(10, is_bytes = False)) + self.assertEquals('-1 MB', str_tools.get_size_label(-2000000)) # checking that we round down self.assertEquals('23.43 Kb', str_tools.get_size_label(3000, 2, is_bytes = False))

1 0

[stem/master] Add test cases for BUILDTIMEOUT_SET events
by atagar＠torproject.org 15 Dec '12

15 Dec '12

commit 48daff039d95d8223ecd83cbd3af59a2ee00dc37 Author: Sean Robinson <seankrobinson(a)gmail.com> Date: Fri Dec 14 14:58:08 2012 -0700 Add test cases for BUILDTIMEOUT_SET events Check integer and float conversion failures raise a ProtocolError. Signed-off-by: Sean Robinson <seankrobinson(a)gmail.com> --- test/unit/response/events.py | 23 +++++++++++++++++++++++ 1 files changed, 23 insertions(+), 0 deletions(-) diff --git a/test/unit/response/events.py b/test/unit/response/events.py index 595ae8c..18ce4bd 100644 --- a/test/unit/response/events.py +++ b/test/unit/response/events.py @@ -36,6 +36,26 @@ TIMEOUT_RATE=0.137097 \ CLOSE_MS=21850 \ CLOSE_RATE=0.072581" +BUILD_TIMEOUT_EVENT_BAD_1 = "650 BUILDTIMEOUT_SET COMPUTED \ +TOTAL_TIMES=one_twenty_four \ +TIMEOUT_MS=9019 \ +XM=1375 \ +ALPHA=0.855662 \ +CUTOFF_QUANTILE=0.800000 \ +TIMEOUT_RATE=0.137097 \ +CLOSE_MS=21850 \ +CLOSE_RATE=0.072581" + +BUILD_TIMEOUT_EVENT_BAD_2 = "650 BUILDTIMEOUT_SET COMPUTED \ +TOTAL_TIMES=124 \ +TIMEOUT_MS=9019 \ +XM=1375 \ +ALPHA=0.855662 \ +CUTOFF_QUANTILE=zero_point_eight \ +TIMEOUT_RATE=0.137097 \ +CLOSE_MS=21850 \ +CLOSE_RATE=0.072581" + # CIRC events from tor v0.2.3.16 CIRC_LAUNCHED = "650 CIRC 7 LAUNCHED \ @@ -316,6 +336,9 @@ class TestEvents(unittest.TestCase): self.assertEqual(0.137097, event.timeout_rate) self.assertEqual(21850, event.close_timeout) self.assertEqual(0.072581, event.close_rate) + + self.assertRaises(ProtocolError, _get_event, BUILD_TIMEOUT_EVENT_BAD_1) + self.assertRaises(ProtocolError, _get_event, BUILD_TIMEOUT_EVENT_BAD_2) def test_bw_event(self): event = _get_event("650 BW 15 25")

1 0

[stem/master] Add test case for missing BW read value
by atagar＠torproject.org 15 Dec '12

15 Dec '12

commit 97dc4108404a1c0f676845538a542f98085ffb4a Author: Sean Robinson <seankrobinson(a)gmail.com> Date: Fri Dec 14 14:34:59 2012 -0700 Add test case for missing BW read value Signed-off-by: Sean Robinson <seankrobinson(a)gmail.com> --- test/unit/response/events.py | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/test/unit/response/events.py b/test/unit/response/events.py index 5422f50..595ae8c 100644 --- a/test/unit/response/events.py +++ b/test/unit/response/events.py @@ -338,6 +338,7 @@ class TestEvents(unittest.TestCase): self.assertEqual(20, event.written) self.assertEqual({'OR': '5', 'EXIT': '500'}, event.keyword_args) + self.assertRaises(ProtocolError, _get_event, "650 BW") self.assertRaises(ProtocolError, _get_event, "650 BW 15") self.assertRaises(ProtocolError, _get_event, "650 BW -15 25") self.assertRaises(ProtocolError, _get_event, "650 BW 15 -25")

1 0

[stem/master] Test error conditions for ADDRMAP events
by atagar＠torproject.org 15 Dec '12

15 Dec '12

commit f1b81e062c2b1ec646f99b346b98dd3d4ec38057 Author: Sean Robinson <seankrobinson(a)gmail.com> Date: Fri Dec 14 14:30:40 2012 -0700 Test error conditions for ADDRMAP events Add tests for missing quotes before (ADDRMAP_BAD_1) and after (ADDRMAP_BAD_2) the expiry positional argument. Add a test for an error event (ADDRMAP_BAD_3), constructed from control-spec.txt. Also, move the sample event lines to their alphabetic position in the list of other event samples. Signed-off-by: Sean Robinson <seankrobinson(a)gmail.com> --- test/unit/response/events.py | 30 ++++++++++++++++++++++++------ 1 files changed, 24 insertions(+), 6 deletions(-) diff --git a/test/unit/response/events.py b/test/unit/response/events.py index 91eaa18..5422f50 100644 --- a/test/unit/response/events.py +++ b/test/unit/response/events.py @@ -13,6 +13,17 @@ import stem.util.log from stem import * # enums and exceptions from test import mocking +# ADDRMAP event + +ADDRMAP = '650 ADDRMAP www.atagar.com 75.119.206.243 "2012-11-19 00:50:13" \ +EXPIRES="2012-11-19 08:50:13"' +ADDRMAP_BAD_1 = '650 ADDRMAP www.atagar.com 75.119.206.243 2012-11-19 00:50:13" \ +EXPIRES="2012-11-19 08:50:13"' +ADDRMAP_BAD_2 = '650 ADDRMAP www.atagar.com 75.119.206.243 "2012-11-19 00:50:13 \ +EXPIRES="2012-11-19 08:50:13"' +ADDRMAP_BAD_3 = '650 ADDRMAP www.atagar.com <error> "2012-11-19 00:50:13" \ +error=yes EXPIRES="2012-11-19 08:50:13"' + # BUILDTIMEOUT_SET event from tor 0.2.3.16. BUILD_TIMEOUT_EVENT = "650 BUILDTIMEOUT_SET COMPUTED \ @@ -193,12 +204,6 @@ NEWDESC_SINGLE = "650 NEWDESC $B3FA3110CC6F42443F039220C134CBD2FC4F0493=Sakura" NEWDESC_MULTIPLE = "650 NEWDESC $BE938957B2CA5F804B3AFC2C1EE6673170CDBBF8=Moonshine \ $B4BE08B22D4D2923EDC3970FD1B93D0448C6D8FF~Unnamed" -# ADDRMAP event -# TODO: it would be nice to have an example of an error event - -ADDRMAP = '650 ADDRMAP www.atagar.com 75.119.206.243 "2012-11-19 00:50:13" \ -EXPIRES="2012-11-19 08:50:13"' - def _get_event(content): controller_event = mocking.get_message(content) stem.response.convert("EVENT", controller_event, arrived_at = 25) @@ -274,6 +279,19 @@ class TestEvents(unittest.TestCase): self.assertEqual(datetime.datetime(2012, 11, 19, 0, 50, 13), event.expiry) self.assertEqual(None, event.error) self.assertEqual(datetime.datetime(2012, 11, 19, 8, 50, 13), event.utc_expiry) + + self.assertRaises(ProtocolError, _get_event, ADDRMAP_BAD_1) + self.assertRaises(ProtocolError, _get_event, ADDRMAP_BAD_2) + + event = _get_event(ADDRMAP_BAD_3) + + self.assertTrue(isinstance(event, stem.response.events.AddrMapEvent)) + self.assertEqual(ADDRMAP_BAD_3.lstrip("650 "), str(event)) + self.assertEqual("www.atagar.com", event.hostname) + self.assertEqual(None, event.destination) + self.assertEqual(datetime.datetime(2012, 11, 19, 0, 50, 13), event.expiry) + self.assertEqual("yes", event.error) + self.assertEqual(datetime.datetime(2012, 11, 19, 8, 50, 13), event.utc_expiry) def test_authdir_newdesc_event(self): # TODO: awaiting test data - https://trac.torproject.org/7534

1 0