- tor-commits - lists.torproject.org

[torbutton/master] Bug 40047: New string for Security Level panel
by sysrqb＠torproject.org 28 Sep '21

28 Sep '21

commit 775ba23e4753c0692b0e32c7e36a716ad1d85dbb Author: Richard Pospesel <richard(a)torproject.org> Date: Wed Sep 15 18:16:21 2021 -0500 Bug 40047: New string for Security Level panel --- chrome/locale/en-US/torbutton.dtd | 1 + 1 file changed, 1 insertion(+) diff --git a/chrome/locale/en-US/torbutton.dtd b/chrome/locale/en-US/torbutton.dtd index b9ae0f00..e5d56b64 100644 --- a/chrome/locale/en-US/torbutton.dtd +++ b/chrome/locale/en-US/torbutton.dtd @@ -45,6 +45,7 @@ <!ENTITY torbutton.prefs.sec_custom_summary "Your custom browser preferences have resulted in unusual security settings. For security and privacy reasons, we recommend you choose one of the default security levels."> <!ENTITY torbutton.prefs.sec_restore_defaults "Restore Defaults"> <!ENTITY torbutton.prefs.sec_advanced_security_settings "Advanced Security Settings…"> +<!ENTITY torbutton.prefs.sec_change "Change…"> <!ENTITY torbutton.circuit_display.title "Tor Circuit"> <!ENTITY torbutton.circuit_display.new_circuit "New Circuit for this Site">

1 0

[torbutton/master] Merge remote-tracking branch 'richardgl/40047'
by sysrqb＠torproject.org 28 Sep '21

28 Sep '21

commit c35cfae73c2fbdd67cd85ae1f49c05475c28744f Merge: f3fa2a7a 775ba23e Author: Matthew Finkel <sysrqb(a)torproject.org> Date: Tue Sep 28 20:25:38 2021 +0000 Merge remote-tracking branch 'richardgl/40047' chrome/locale/en-US/torbutton.dtd | 1 + 1 file changed, 1 insertion(+)

1 0

[torbutton/master] Merge remote-tracking branch 'richardgl/40048'
by sysrqb＠torproject.org 28 Sep '21

28 Sep '21

commit 77d1306c3b8de9a0ce5eb62b80c68cee1629ab79 Merge: c35cfae7 61da3213 Author: Matthew Finkel <sysrqb(a)torproject.org> Date: Tue Sep 28 20:25:44 2021 +0000 Merge remote-tracking branch 'richardgl/40048' chrome/skin/tor-circuit-display.css | 131 ++++++++++++++++++--------------- chrome/skin/tor-circuit-line-first.svg | 10 +-- chrome/skin/tor-circuit-line-last.svg | 10 +-- chrome/skin/tor-circuit-line.svg | 9 ++- 4 files changed, 85 insertions(+), 75 deletions(-)

1 0

[torbutton/master] Bug 40048: Protonify Circuit Display Panel
by sysrqb＠torproject.org 28 Sep '21

28 Sep '21

commit 61da3213a2e22836d2c1b0c4069ddb776ca3ac0d Author: Richard Pospesel <richard(a)torproject.org> Date: Mon Sep 20 16:01:51 2021 -0500 Bug 40048: Protonify Circuit Display Panel --- chrome/skin/tor-circuit-display.css | 131 ++++++++++++++++++--------------- chrome/skin/tor-circuit-line-first.svg | 10 +-- chrome/skin/tor-circuit-line-last.svg | 10 +-- chrome/skin/tor-circuit-line.svg | 9 ++- 4 files changed, 85 insertions(+), 75 deletions(-) diff --git a/chrome/skin/tor-circuit-display.css b/chrome/skin/tor-circuit-display.css index 6f132db8..5f37bb71 100644 --- a/chrome/skin/tor-circuit-display.css +++ b/chrome/skin/tor-circuit-display.css @@ -6,39 +6,64 @@ Each bullet in the circuit node list is supposed to represent a Tor circuit node and lines drawn between them to represent Tor network inter-relay connections. */ +#circuit-display-container { + margin-inline: 8px; + margin-top: 0px; + margin-bottom: 4px; + padding: 0px 3px; +} + +#circuit-display-container > toolbarseparator { + margin-block: 0px; + margin-inline: -3px; + width: calc(100% + 6px); +} + #circuit-display-headline { - margin: 0; + margin-inline-start: 8px; } #circuit-display-header { background-image: url(chrome://torbutton/skin/torbutton.svg); background-repeat: no-repeat; - background-position: 0 50%; + background-position: 4px 50%; background-size: 16px auto; min-height: 16px; -moz-context-properties: fill, fill-opacity; fill: currentColor; - /* icon indent + 16px icon width + 6px description margin - (total of 12px margin with the native 6px description margin) */ - padding-inline: calc(2em + 22px) 1em; - /* 16px icon width + 12px margin */ - padding-inline-start: 28px; + margin-block: 8px; } #circuit-display-header:-moz-locale-dir(rtl) { background-position-x: right; } +#circuit-display-header > hbox { + margin-inline-start: 16px; +} + #circuit-display-content { - padding-inline: 2em 1em; - padding-block: 1em; + width: 100%; +} + +#circuit-display-content > * { + margin-inline: 0px; + margin-inline-start: 16px; + margin-top: 0px; + margin-bottom: 8px; +} + +#circuit-display-content > hbox { + display: flex; +} + +#circuit-reload-button-container { + padding-top: 8px; + justify-content: flex-end; } #circuit-reload-content { cursor: default; - padding: 0 0 1em; - padding-inline-end: 3em; - padding-inline-start: calc(2em + 24px); width: 100%; } @@ -54,10 +79,8 @@ and lines drawn between them to represent Tor network inter-relay connections. /* Format the circuit node list. */ ul#circuit-display-nodes { - line-height: 26px; - margin-top: 8px; - margin-bottom: 0; - padding-inline-start: 28px; + line-height:32px; + padding-inline-start: 8px; } /* Hide default bullets, and draw our own bullets */ @@ -68,6 +91,10 @@ ul#circuit-display-nodes li { list-style: none; padding-inline-start: 1.5em; white-space: nowrap; + max-height: 32px; + -moz-context-properties: stroke, stroke-opacity; + stroke: currentColor; + stroke-opacity: 100%; } ul#circuit-display-nodes li:dir(rtl) { @@ -82,78 +109,51 @@ ul#circuit-display-nodes li:last-child { background-image: url(chrome://torbutton/skin/tor-circuit-line-last.svg); } -.circuit-guard-help { - -moz-context-properties: fill, stroke; - fill: #6200a4; - stroke: #6200a4; -} - -.circuit-guard-help:-moz-lwtheme-brighttext { - fill: #D476FF; - stroke: #D476FF; -} - .circuit-ip-address { font-size: 80%; - opacity: 0.4; + opacity: 0.7; padding-inline-start: 3px; } .circuit-guard-info { font-size: 80%; + color: var(--button-primary-bgcolor); font-weight: bold; - color: #6200a4; padding-inline-start: 3px; } -.circuit-guard-info:-moz-lwtheme-brighttext { - color:#D476FF; -} - #circuit-reload-button { - background-color: #0060df; - border-radius: 3px; - border: none; - color: white; - cursor: pointer; - font-size: 18px; - padding: 10px; + background-color: var(--button-primary-bgcolor); + border-radius: 4px; + border-width: 0px; + color: var(--button-primary-color); + font-weight: 600; + padding: 8px 16px; + margin: 0; } - #circuit-reload-button:hover { - background-color: #0058cf; + background-color: var(--button-primary-hover-bgcolor); } #circuit-reload-button:active { - background-color: #0050bf; + background-color: var(--button-primary-active-bgcolor); } #circuit-guard-note-container { - margin-top: 10px; + } #circuit-guard-note-container div { - margin-left: 3px; - margin-right: 3px; + margin-inline-start: 8px; } .circuit-guard-name { font-weight: bold; - color: #6200a4; -} - -.circuit-guard-name:-moz-lwtheme-brighttext { - color:#D476FF; } .circuit-link { cursor: pointer; - color: #0000ee; -} - - -.circuit-link:-moz-lwtheme-brighttext { - color: #A9A9A9; + color: var(--lwt-popup-brighttext-url-color); } .circuit-link:hover { @@ -169,18 +169,27 @@ ul#circuit-display-nodes li:last-child { } .circuit-onion::after { - background-color: #e3e3e3; - border-radius: 2px; - color: black; + background-color: var(--button-bgcolor);; + border-radius: 4px; + color: var(--button-color); content: attr(data-text-clicktocopy); font-size: 80%; opacity: 0; - padding: 5px; + padding: 5px 10px; margin: 10px; text-align: center; transition: opacity 0.3s cubic-bezier(0.07, 0.95, 0, 1); } +.circuit-onion:hover::after { + background-color: var(--button-hover-bgcolor); +} + +.circuit-onion:active::after { + background-color: var(--button-active-bgcolor); +} + + .circuit-onion-copied::after { content: attr(data-text-copied); opacity: 1; diff --git a/chrome/skin/tor-circuit-line-first.svg b/chrome/skin/tor-circuit-line-first.svg index 6c070daa..1981ee87 100644 --- a/chrome/skin/tor-circuit-line-first.svg +++ b/chrome/skin/tor-circuit-line-first.svg @@ -1,6 +1,6 @@ -<svg xmlns="http://www.w3.org/2000/svg" width="15" height="40"> - <g stroke="#9a9a9a" stroke-width="3" fill="white"> - <line x1='50%' y1='50%' x2='50%' y2='100%'/> - <circle cx='50%' cy='50%' r='4.5'/> +<svg xmlns="http://www.w3.org/2000/svg" width="16" height="32"> + <g stroke="context-stroke" opacity="context-stroke-opacity" stroke-width="2" fill="transparent"> + <circle cx="50%" cy="50%" r="6"/> + <line x1="50%" y1="22" x2="50%" y2="100%"/> </g> -</svg> \ No newline at end of file +</svg> diff --git a/chrome/skin/tor-circuit-line-last.svg b/chrome/skin/tor-circuit-line-last.svg index 4ed0ff05..19c4adaa 100644 --- a/chrome/skin/tor-circuit-line-last.svg +++ b/chrome/skin/tor-circuit-line-last.svg @@ -1,6 +1,6 @@ -<svg xmlns="http://www.w3.org/2000/svg" width="15" height="40"> - <g stroke="#9a9a9a" stroke-width="3" fill="white"> - <line x1='50%' y1='0%' x2='50%' y2='50%'/> - <circle cx='50%' cy='50%' r='4.5'/> +<svg xmlns="http://www.w3.org/2000/svg" width="16" height="32"> + <g stroke="context-stroke" opacity="context-stroke-opacity" stroke-width="2" fill="transparent"> + <line x1="50%" y1="0%" x2="50%" y2="10"/> + <circle cx="50%" cy="50%" r="6"/> </g> -</svg> \ No newline at end of file +</svg> diff --git a/chrome/skin/tor-circuit-line.svg b/chrome/skin/tor-circuit-line.svg index ada7cd59..00717f6c 100644 --- a/chrome/skin/tor-circuit-line.svg +++ b/chrome/skin/tor-circuit-line.svg @@ -1,6 +1,7 @@ -<svg xmlns="http://www.w3.org/2000/svg" width="15" height="40"> - <g stroke="#9a9a9a" stroke-width="3" fill="white"> - <line x1="50%" y1="0%" x2="50%" y2="100%"/> - <circle cx="50%" cy="50%" r="4.5"/> +<svg xmlns="http://www.w3.org/2000/svg" width="16" height="32"> + <g stroke="context-stroke" opacity="context-stroke-opacity" stroke-width="2" fill="transparent"> + <line x1="50%" y1="0%" x2="50%" y2="10"/> + <circle cx="50%" cy="50%" r="6"/> + <line x1="50%" y1="22" x2="50%" y2="100%"/> </g> </svg>

1 0

[tor-browser-build/maint-10.5] Bug 40352: Add desktop-only (Windows/macOS/Linux) Makefile rules
by sysrqb＠torproject.org 28 Sep '21

28 Sep '21

commit 13167b5d52bf30eeb115afec4e283916b5ea292c Author: Nicolas Vigier <boklm(a)torproject.org> Date: Thu Sep 2 12:01:34 2021 +0200 Bug 40352: Add desktop-only (Windows/macOS/Linux) Makefile rules --- Makefile | 12 ++++++++++++ doc/MAKEFILE.txt | 10 ++++++---- 2 files changed, 18 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index a3393fc..0660389 100644 --- a/Makefile +++ b/Makefile @@ -20,6 +20,9 @@ release-android-x86_64: submodule-update release-android-aarch64: submodule-update $(rbm) build release --target release --target torbrowser-android-aarch64 +release-desktop: submodule-update + $(rbm) build release --target release --target torbrowser-all-desktop + release-linux-x86_64: submodule-update $(rbm) build release --target release --target torbrowser-linux-x86_64 @@ -59,6 +62,9 @@ alpha-android-x86_64: submodule-update alpha-android-aarch64: submodule-update $(rbm) build release --target alpha --target torbrowser-android-aarch64 +alpha-desktop: submodule-update + $(rbm) build release --target alpha --target torbrowser-all-desktop + alpha-linux-x86_64: submodule-update $(rbm) build release --target alpha --target torbrowser-linux-x86_64 @@ -98,6 +104,9 @@ nightly-android-x86_64: submodule-update nightly-android-aarch64: submodule-update $(rbm) build release --target nightly --target torbrowser-android-aarch64 +nightly-desktop: submodule-update + $(rbm) build release --target nightly --target torbrowser-all-desktop + nightly-linux-x86_64: submodule-update $(rbm) build release --target nightly --target torbrowser-linux-x86_64 @@ -137,6 +146,9 @@ testbuild-android-x86_64: submodule-update testbuild-android-aarch64: submodule-update $(rbm) build release --target testbuild --target torbrowser-android-aarch64 +testbuild-desktop: submodule-update + $(rbm) build release --target testbuild --target torbrowser-all-desktop + testbuild-linux-x86_64: submodule-update $(rbm) build release --target testbuild --target torbrowser-linux-x86_64 diff --git a/doc/MAKEFILE.txt b/doc/MAKEFILE.txt index b198985..9603463 100644 --- a/doc/MAKEFILE.txt +++ b/doc/MAKEFILE.txt @@ -8,9 +8,11 @@ Build Tor Browser for the release channel, for all supported platforms. The resulting build can be found in directory release/$version. release-{linux-x86_64,linux-i686,windows-i686,osx-x86_64,android-armv7, - android-x86,android-x86_64,android-aarch64} + android-x86,android-x86_64,android-aarch64,desktop,android} ----------------------------------------------------------------------- -Same as release, for the selected platform only. +Same as release, for the selected platform only. The "desktop" platform +means Linux, Windows and macOS. The "android" platform means android for +all architectures we support. alpha ----- @@ -18,7 +20,7 @@ Build Tor Browser for the alpha channel, for all supported platforms. The resulting build can be found in directory alpha/$version. alpha-{linux-x86_64,linux-i686,windows-i686,osx-x86_64,android-armv7, - android-x86,android-x86_64,android-aarch64} + android-x86,android-x86_64,android-aarch64,desktop,android} --------------------------------------------------------------------- Same as alpha, for the selected platform only. @@ -32,7 +34,7 @@ components. The resulting build can be found in directory nightly/$date nightly-{linux-x86_64,linux-i686,windows-i686,osx-x86_64,android-armv7, - android-x86,android-x86_64,android-aarch64} + android-x86,android-x86_64,android-aarch64,desktop,android} ----------------------------------------------------------------------- Same as nightly, for the selected platform only.

1 0

[tor-browser-build/maint-10.5] Release preparations for 10.5.8
by sysrqb＠torproject.org 28 Sep '21

28 Sep '21

commit 0cbe590953c4592f06e5b487708f86efc80a026d Author: Matthew Finkel <sysrqb(a)torproject.org> Date: Tue Sep 28 20:07:16 2021 +0000 Release preparations for 10.5.8 Version and Changelog updates --- projects/firefox/config | 2 +- projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt | 4 ++++ rbm.conf | 4 ++-- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/projects/firefox/config b/projects/firefox/config index 28bed9c..169da33 100644 --- a/projects/firefox/config +++ b/projects/firefox/config @@ -8,7 +8,7 @@ git_submodule: 1 gpg_keyring: torbutton.gpg var: - firefox_platform_version: 78.14.0 + firefox_platform_version: 78.15.0 firefox_version: '[% c("var/firefox_platform_version") %]esr' torbrowser_branch: 10.5 branding_directory: 'browser/branding/alpha' diff --git a/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt b/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt index 20c46d5..6fcda75 100644 --- a/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt +++ b/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt @@ -1,3 +1,7 @@ +Tor Browser 10.5.8 -- October 5 2021 + * Windows + OS X + Linux + * Update Firefox to 78.15.0esr + Tor Browser 10.5.7 -- September 24 2021 * Android * Update Openssl to 1.1.1l diff --git a/rbm.conf b/rbm.conf index 2c57f88..a72b586 100644 --- a/rbm.conf +++ b/rbm.conf @@ -57,10 +57,10 @@ buildconf: git_signtag_opt: '-s' var: - torbrowser_version: '10.5.7' + torbrowser_version: '10.5.8' torbrowser_build: 'build1' torbrowser_incremental_from: - - 10.5.5 + - 10.5.6 project_name: tor-browser multi_lingual: 0 build_mar: 1

1 0

[tor-browser/tor-browser-78.15.0esr-10.5-1] Bug 40475: Include clearing CORS preflight cache
by sysrqb＠torproject.org 28 Sep '21

28 Sep '21

commit afbb515b6a0524ee3e1f0d745721bfee6f07ab04 Author: Matthew Finkel <sysrqb(a)torproject.org> Date: Sun Jun 6 20:32:23 2021 +0000 Bug 40475: Include clearing CORS preflight cache --- netwerk/protocol/http/nsCORSListenerProxy.cpp | 7 +++++++ netwerk/protocol/http/nsCORSListenerProxy.h | 1 + netwerk/protocol/http/nsHttpHandler.cpp | 2 ++ 3 files changed, 10 insertions(+) diff --git a/netwerk/protocol/http/nsCORSListenerProxy.cpp b/netwerk/protocol/http/nsCORSListenerProxy.cpp index 76870e6cea3f..6d2e160c2a9b 100644 --- a/netwerk/protocol/http/nsCORSListenerProxy.cpp +++ b/netwerk/protocol/http/nsCORSListenerProxy.cpp @@ -346,6 +346,13 @@ void nsCORSListenerProxy::Shutdown() { sPreflightCache = nullptr; } +/* static */ +void nsCORSListenerProxy::Clear() { + if (sPreflightCache) { + sPreflightCache->Clear(); + } +} + nsCORSListenerProxy::nsCORSListenerProxy(nsIStreamListener* aOuter, nsIPrincipal* aRequestingPrincipal, bool aWithCredentials) diff --git a/netwerk/protocol/http/nsCORSListenerProxy.h b/netwerk/protocol/http/nsCORSListenerProxy.h index 8c0df2e0ff28..3f76be33f209 100644 --- a/netwerk/protocol/http/nsCORSListenerProxy.h +++ b/netwerk/protocol/http/nsCORSListenerProxy.h @@ -54,6 +54,7 @@ class nsCORSListenerProxy final : public nsIStreamListener, NS_DECL_NSITHREADRETARGETABLESTREAMLISTENER static void Shutdown(); + static void Clear(); [[nodiscard]] nsresult Init(nsIChannel* aChannel, DataURIHandling aAllowDataURI); diff --git a/netwerk/protocol/http/nsHttpHandler.cpp b/netwerk/protocol/http/nsHttpHandler.cpp index d5e2c61dbec9..c6cb95ca7fcc 100644 --- a/netwerk/protocol/http/nsHttpHandler.cpp +++ b/netwerk/protocol/http/nsHttpHandler.cpp @@ -10,6 +10,7 @@ #include "prsystem.h" #include "AltServiceChild.h" +#include "nsCORSListenerProxy.h" #include "nsError.h" #include "nsHttp.h" #include "nsHttpHandler.h" @@ -2290,6 +2291,7 @@ nsHttpHandler::Observe(nsISupports* subject, const char* topic, mAltSvcCache->ClearAltServiceMappings(); } } + nsCORSListenerProxy::Clear(); } else if (!strcmp(topic, NS_NETWORK_LINK_TOPIC)) { nsAutoCString converted = NS_ConvertUTF16toUTF8(data); if (!strcmp(converted.get(), NS_NETWORK_LINK_DATA_CHANGED)) {

1 0

[tor-browser/tor-browser-78.15.0esr-10.5-1] Adding issue template for bugs.
by sysrqb＠torproject.org 28 Sep '21

28 Sep '21

commit 6556e2a522a286a316d7c6755f1f9eea2f67ca9a Author: Gaba <gaba(a)torproject.org> Date: Mon Jun 28 11:44:16 2021 -0700 Adding issue template for bugs. --- .gitlab/issue_templates/UXBug.md | 29 +++++++++++++++++++++++++++++ .gitlab/issue_templates/bug.md | 32 ++++++++++++++++++++++++++++++++ 2 files changed, 61 insertions(+) diff --git a/.gitlab/issue_templates/UXBug.md b/.gitlab/issue_templates/UXBug.md new file mode 100644 index 000000000000..8e7cb2a5e163 --- /dev/null +++ b/.gitlab/issue_templates/UXBug.md @@ -0,0 +1,29 @@ + + +### Summary +**Summarize the bug encountered concisely.** + + +### Steps to reproduce: +**How one can reproduce the issue - this is very important.** + +1. Step 1 +2. Step 2 +3. ... + +### What is the current bug behavior? +**What actually happens.** + + +### What is the expected behavior? +**What you want to see instead** + + + +## Relevant logs and/or screenshots +**Do you have screenshots? Attach them to this ticket please.** + +/label ~tor-ux ~needs-investigation ~bug +/assign @nah diff --git a/.gitlab/issue_templates/bug.md b/.gitlab/issue_templates/bug.md new file mode 100644 index 000000000000..6ce85a4864be --- /dev/null +++ b/.gitlab/issue_templates/bug.md @@ -0,0 +1,32 @@ + + +### Summary +**Summarize the bug encountered concisely.** + + +### Steps to reproduce: +**How one can reproduce the issue - this is very important.** + +1. Step 1 +2. Step 2 +3. ... + +### What is the current bug behavior? +**What actually happens.** + + +### What is the expected behavior? +**What you want to see instead** + + + +### Environment +**Which operating system are you using? For example: Debian GNU/Linux 10.1, Windows 10, Ubuntu Xenial, FreeBSD 12.2, etc.** +**Which installation method did you use? Distribution package (apt, pkg, homebrew), from source tarball, from Git, etc.** + +### Relevant logs and/or screenshots + + +/label ~bug

1 0

[tor-browser/tor-browser-78.15.0esr-10.5-1] Bug 40432: Prevent probing installed applications
by sysrqb＠torproject.org 28 Sep '21

28 Sep '21

commit d7eff41b8dcd161b5477db69620a3d53da14a7de Author: Matthew Finkel <sysrqb(a)torproject.org> Date: Mon May 17 18:09:09 2021 +0000 Bug 40432: Prevent probing installed applications --- .../exthandler/nsExternalHelperAppService.cpp | 30 ++++++++++++++++++---- 1 file changed, 25 insertions(+), 5 deletions(-) diff --git a/uriloader/exthandler/nsExternalHelperAppService.cpp b/uriloader/exthandler/nsExternalHelperAppService.cpp index 0dcc1d3ed6ab..7ff9c5b626a3 100644 --- a/uriloader/exthandler/nsExternalHelperAppService.cpp +++ b/uriloader/exthandler/nsExternalHelperAppService.cpp @@ -1002,8 +1002,33 @@ nsresult nsExternalHelperAppService::GetFileTokenForPath( ////////////////////////////////////////////////////////////////////////////////////////////////////// // begin external protocol service default implementation... ////////////////////////////////////////////////////////////////////////////////////////////////////// + +static const char kExternalProtocolPrefPrefix[] = + "network.protocol-handler.external."; +static const char kExternalProtocolDefaultPref[] = + "network.protocol-handler.external-default"; + NS_IMETHODIMP nsExternalHelperAppService::ExternalProtocolHandlerExists( const char* aProtocolScheme, bool* aHandlerExists) { + + // Replicate the same check performed in LoadURI. + // Deny load if the prefs say to do so + nsAutoCString externalPref(kExternalProtocolPrefPrefix); + externalPref += aProtocolScheme; + bool allowLoad = false; + *aHandlerExists = false; + if (NS_FAILED(Preferences::GetBool(externalPref.get(), &allowLoad))) { + // no scheme-specific value, check the default + if (NS_FAILED( + Preferences::GetBool(kExternalProtocolDefaultPref, &allowLoad))) { + return NS_OK; // missing default pref + } + } + + if (!allowLoad) { + return NS_OK; // explicitly denied + } + nsCOMPtr<nsIHandlerInfo> handlerInfo; nsresult rv = GetProtocolHandlerInfo(nsDependentCString(aProtocolScheme), getter_AddRefs(handlerInfo)); @@ -1046,11 +1071,6 @@ NS_IMETHODIMP nsExternalHelperAppService::IsExposedProtocol( return NS_OK; } -static const char kExternalProtocolPrefPrefix[] = - "network.protocol-handler.external."; -static const char kExternalProtocolDefaultPref[] = - "network.protocol-handler.external-default"; - NS_IMETHODIMP nsExternalHelperAppService::LoadURI(nsIURI* aURI, nsIPrincipal* aTriggeringPrincipal,

1 0

[tor-browser/tor-browser-78.15.0esr-10.5-1] Bug 1715254 - Deny clone3 to force glibc fallback r=gcp
by sysrqb＠torproject.org 28 Sep '21

28 Sep '21

commit 2e596960da79178668924984a25e11c85042b816 Author: Alexandre Lissy <lissyx+mozillians(a)lissyx.dyndns.org> Date: Wed Jun 9 13:45:28 2021 +0000 Bug 1715254 - Deny clone3 to force glibc fallback r=gcp Differential Revision: https://phabricator.services.mozilla.com/D117297 --- security/sandbox/linux/SandboxFilter.cpp | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/security/sandbox/linux/SandboxFilter.cpp b/security/sandbox/linux/SandboxFilter.cpp index b60902e841e4..4ee50a23d461 100644 --- a/security/sandbox/linux/SandboxFilter.cpp +++ b/security/sandbox/linux/SandboxFilter.cpp @@ -633,6 +633,9 @@ class SandboxPolicyCommon : public SandboxPolicyBase { case __NR_clone: return ClonePolicy(InvalidSyscall()); + case __NR_clone3: + return Error(ENOSYS); + // More thread creation. #ifdef __NR_set_robust_list case __NR_set_robust_list: @@ -1311,6 +1314,9 @@ class ContentSandboxPolicy : public SandboxPolicyCommon { case __NR_clone: return ClonePolicy(Error(EPERM)); + case __NR_clone3: + return Error(ENOSYS); + # ifdef __NR_fadvise64 case __NR_fadvise64: return Allow();

1 0