- tor-commits - lists.torproject.org

[Git][tpo/applications/tor-browser] Pushed new branch tor-browser-115.23.0esr-13.5-1
by Pier Angelo Vendrame (＠pierov) 22 Apr '25

22 Apr '25

Pier Angelo Vendrame pushed new branch tor-browser-115.23.0esr-13.5-1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag FIREFOX_115_23_0esr_BUILD1
by Pier Angelo Vendrame (＠pierov) 22 Apr '25

22 Apr '25

Pier Angelo Vendrame pushed new tag FIREFOX_115_23_0esr_BUILD1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/FIREFOX_1… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new branch tor-browser-128.10.0esr-14.5-1
by Pier Angelo Vendrame (＠pierov) 22 Apr '25

22 Apr '25

Pier Angelo Vendrame pushed new branch tor-browser-128.10.0esr-14.5-1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag FIREFOX_128_10_0esr_BUILD1
by Pier Angelo Vendrame (＠pierov) 22 Apr '25

22 Apr '25

Pier Angelo Vendrame pushed new tag FIREFOX_128_10_0esr_BUILD1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/FIREFOX_1… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.9.0esr-14.5-1] 5 commits: fixup! MB 188: Customize Gitlab Issue and Merge templates
by morgan (＠morgan) 17 Apr '25

17 Apr '25

morgan pushed to branch mullvad-browser-128.9.0esr-14.5-1 at The Tor Project / Applications / Mullvad Browser Commits: 75f63014 by Morgan at 2025-04-16T15:29:13+00:00 fixup! MB 188: Customize Gitlab Issue and Merge templates revert - - - - - 976a2fce by Morgan at 2025-04-16T15:29:13+00:00 fixup! Adding issue and merge request templates revert - - - - - d300a9f9 by Morgan at 2025-04-17T15:37:08+00:00 BB 43615: Add Gitlab Issue and Merge Request templates - - - - - 1ee9b56c by Morgan at 2025-04-17T15:37:08+00:00 fixup! BB 43615: Add Gitlab Issue and Merge Request templates add new and modify existing shared Tor/Mullvad browser templates - - - - - 1daa5b6c by Morgan at 2025-04-17T15:46:45+00:00 fixup! MB 188: Customize Gitlab Issue and Merge templates - - - - - 16 changed files: - + .gitlab/issue_templates/000 Bug Report.md - + .gitlab/issue_templates/010 Proposal.md - + .gitlab/issue_templates/020 Web Compatibility.md - + .gitlab/issue_templates/030 Test.md - + .gitlab/issue_templates/040 Feature.md - .gitlab/issue_templates/Backport.md → .gitlab/issue_templates/050 Backport.md - .gitlab/issue_templates/Rebase Browser - Alpha.md → .gitlab/issue_templates/060 Rebase - Alpha.md - .gitlab/issue_templates/Rebase Browser - Stable.md → .gitlab/issue_templates/061 Rebase - Stable.md - .gitlab/issue_templates/Rebase Browser - Rapid.md → .gitlab/issue_templates/063 Rebase - Rapid.md - .gitlab/issue_templates/Emergency Security Issue.md → .gitlab/issue_templates/090 Emergency Security Issue.md - + .gitlab/issue_templates/Default.md - − .gitlab/issue_templates/QA - Android.md - − .gitlab/issue_templates/QA - Desktop.md - − .gitlab/issue_templates/Uplift.md - − .gitlab/issue_templates/bug.md - .gitlab/merge_request_templates/default.md → .gitlab/merge_request_templates/Default.md Changes: ===================================== .gitlab/issue_templates/000 Bug Report.md ===================================== @@ -0,0 +1,117 @@ +# 🐞 Bug Report + + +## Reproduction steps + + +## Expected behaviour + + +## Actual behaviour + + +## Bookkeeping + + +- Browser version: +- Browser channel: + - [ ] Release + - [ ] Alpha + - [ ] Nightly +- Distribution method: + - [ ] Installer/archive from mullvad.net + - [ ] homebrew + - [ ] other (please specify): +- Operating System: + - [ ] Windows + - [ ] macOS + - [ ] Linux + - [ ] Other (please specify): +- Operating System Version: + +### Browser UI language + + +### Have you modified any of the settings in `about:preferences` or `about:config`? If yes, which ones? + + +### Do you have any extra extensions installed? + + +## Troubleshooting + + +### Does this bug occur in a fresh installation? + +### Is this bug new? If it is a regression, in which version of the browser did this bug first appear? + + +### Does this bug occur in the Alpha release channel? + + +### Does this bug occur in Firefox ESR (Desktop only)? + + +### Does this bug occur in Firefox Rapid Release? + + + + +--- + +/label ~"Apps::Product::MullvadBrowser" +/label ~"Apps::Type::Bug" ===================================== .gitlab/issue_templates/010 Proposal.md ===================================== @@ -0,0 +1,72 @@ +# 💡 Proposal + + +## User Story + + +## Security and Privacy Implications + + +### Security + + +### Privacy + + +## Accessibility Implications + + +## Other Trade-Offs + + +## Prior Art + +### Does this feature exist in other browsers? +- [ ] Yes + - [ ] Firefox + - [ ] Firefox ESR + - [ ] Other (please specify) +- [ ] No + +### Does this feature exist as an extension? If yes, which one provides this functionality? + + + +--- + +/label ~"Apps::Product::MullvadBrowser" +/label ~"Apps::Type::Proposal" ===================================== .gitlab/issue_templates/020 Web Compatibility.md ===================================== @@ -0,0 +1,108 @@ +# 🌍 Web Compatibility + + +## URL + + +## Expected behaviour + + +## Actual behaviour + + +## Reproduction steps + + +## Bookkeeping + + +- Browser version: +- Browser channel: + - [ ] Release + - [ ] Alpha + - [ ] Nightly +- Distribution method: + - [ ] Installer/archive from mullvad.net + - [ ] homebrew + - [ ] other (please specify): +- Operating System: + - [ ] Windows + - [ ] macOS + - [ ] Linux + - [ ] Other (please specify): +- Operating System Version: + +### Have you modified any of the settings in `about:preferences` or `about:config`? If yes, which ones? + + +### Do you have any extra extensions installed? + + +## Troubleshooting + + +### Does this bug occur in a fresh installation? + +### Is this bug new? If it is a regression, in which version of the browser did this bug first appear? + + +### Does this bug occur in the Alpha release channel? + + +### Does this bug occur in Firefox ESR (Desktop only)? + + +### Does this bug occur in Firefox Rapid Release? + + + + +--- + +/label ~"Apps::Product::MullvadBrowser" +/label ~"Apps::Type::WebCompatibility" ===================================== .gitlab/issue_templates/030 Test.md ===================================== @@ -0,0 +1,29 @@ +# 💣 Test + + +## Description + + +## Scenarios + + + + +--- + +/label ~"Apps::Product::MullvadBrowser" +/label ~"Apps::Type::Test" ===================================== .gitlab/issue_templates/040 Feature.md ===================================== @@ -0,0 +1,32 @@ +# ✨ Feature + + +## Description + + +## Bookkeeping + +### Proposal + +- mullvad-browser#123 + +### Design + +- tpo/UX/Design#123 + + + +--- + +/label ~"Apps::Product::MullvadBrowser" +/label ~"Apps::Type::Feature" ===================================== .gitlab/issue_templates/Backport.md → .gitlab/issue_templates/050 Backport.md ===================================== @@ -1,30 +1,39 @@ +# ⬅️ Backport Patchset  +please ensure the title has the following format: + +- Backport tor-browser#12345: Title of original issue +- Backport Bugzilla 1234567: Title of original issue -## Backport Patchset +--> -### Book-keeping +## Bookkeeping -#### Gitlab Issue(s) +### Issue(s) - tor-browser#12345 - mullvad-browser#123 - https://bugzilla.mozilla.org/show_bug.cgi?id=1234567 -#### Merge Request(s) -- mullvad-browser!123 +### Merge Request(s) +- tor-browser!123 -#### Target Channels +### Target Channels - [ ] Alpha - [ ] Stable +- [ ] Legacy -### Notes +## Notes  + + + +--- + +/label ~"Apps::Product::TorBrowser" /label ~"Apps::Type::Backport" ===================================== .gitlab/issue_templates/Rebase Browser - Alpha.md → .gitlab/issue_templates/060 Rebase - Alpha.md ===================================== @@ -1,3 +1,5 @@ +# ⤵️ Rebase Alpha + **NOTE:** All examples in this template reference the rebase from 102.7.0esr to 102.8.0esr <details> @@ -85,4 +87,10 @@ ``` - [ ] Push tag to `upstream` + + +--- + +/label ~"Apps::Product::MullvadBrowser" /label ~"Apps::Type::Rebase" +/label ~"Apps::Priority::Blocker" ===================================== .gitlab/issue_templates/Rebase Browser - Stable.md → .gitlab/issue_templates/061 Rebase - Stable.md ===================================== @@ -1,3 +1,4 @@ +# ⤵️ Rebase Stable **NOTE:** All examples in this template reference the rebase from 102.7.0esr to 102.8.0esr <details> @@ -86,4 +87,10 @@ ``` - [ ] Push tag to `upstream` + + +--- + +/label ~"Apps::Product::MullvadBrowser" /label ~"Apps::Type::Rebase" +/label ~"Apps::Priority::Blocker" ===================================== .gitlab/issue_templates/Rebase Browser - Rapid.md → .gitlab/issue_templates/063 Rebase - Rapid.md ===================================== @@ -1,3 +1,5 @@ +# ⤵️ Rebase Rapid + **NOTE**: All examples in this template reference the rebase from Firefox 129.0a1 to 130.0a1, see the tor-browser `Rebase Browser - Rapid.md` template for further info <details> @@ -82,4 +84,10 @@ ``` - [ ] Push tag to `upstream` + + +--- + +/label ~"Apps::Product::MullvadBrowser" /label ~"Apps::Type::Rebase" +/label ~"Apps::Priority::High" ===================================== .gitlab/issue_templates/Emergency Security Issue.md → .gitlab/issue_templates/090 Emergency Security Issue.md ===================================== @@ -1,15 +1,15 @@ +# 🚨 Emergency Security Issue + **NOTE** This is an issue template to standardise our process for responding to and fixing critical security and privacy vulnerabilities, exploits, etc. ## Information ### Related Issue -- tor-browser#AAAAA - mullvad-browser#BBBBB - tor-browser-build#CCCCC #### Affected Platforms -- [ ] Android - [ ] Desktop - [ ] Windows - [ ] macOS @@ -18,7 +18,9 @@ ### Type of Issue: What are we dealing with? - [ ] Security (sandbox escape, remote code execution, etc) -- [ ] Cross-Site Linkability (correlating sessions across websites) +- [ ] Proxy Bypass (traffic contents becoming MITM'able) +- [ ] De-Anonymization (otherwise identifying which website a user is visiting) +- [ ] Cross-Site Linkability (correlating sessions across circuits and websites) - [ ] Disk Leak (persisting session information to disk) - [ ] Other (please explain) @@ -29,16 +31,17 @@ - [ ] **clairehurst** : Android, macOS - [ ] **dan** : Android, macOS - [ ] **henry** : accessibility, frontend, localisation + - [ ] **jwilde** : windows, firefox internals - [ ] **ma1** : firefox internals - [ ] **pierov** : updater, fonts, localisation, general - - [ ] **richard** : signing, release + - [ ] **morgan** : signing, release - [ ] **thorin** : fingerprinting - [ ] Other Engineering Teams - [ ] UX (**donuts**) - [ ] TPA (**anarcat**, **lavamind**) - [ ] External Tor Partners - - [ ] Mozilla (**tjr**) - - [ ] Mullvad (**ruihildt**) + - [ ] Mozilla + - [ ] Mullvad - [ ] Other (please list) ### Urgency: When do we need to act? @@ -65,7 +68,6 @@ Sometimes fixes have side-effects: users lose their data, roadmaps need to be ad - [ ] Start an initial email thread with the following people: - [ ] **bella** - - [ ] **ruihildt**, **support(a)mullvadvpn.net** - [ ] Relevant Applications Developers - [ ] **(Optional)** **micah** - if there are considerations or asks outside the Applications Team @@ -74,12 +76,20 @@ Sometimes fixes have side-effects: users lose their data, roadmaps need to be ad - [ ] **(Optional)** **gazebook** - if there are consequences to the organisation or partners beyond a browser update, then a communication plan may be needed +Godspeed! :pray: + + + +--- + /cc @bella /cc @ma1 /cc @micah -/cc @richard +/cc @morgan /cc @ruihildt /confidential -Godspeed! :pray: +/label ~"Apps::Product::MullvadBrowser" +/label ~"Apps::Type::Bug" +/label ~"Apps::Priority::Blocker" ===================================== .gitlab/issue_templates/Default.md ===================================== @@ -0,0 +1,19 @@ +# Open a new Issue + +Please select the appropriate issue template from the **Description** drop-down. + +--- + +- 🐞 **Bug Report** - report a problem with the browser +- 💡 **Proposal** - suggest a new feature +- 🌐 **Web Compatibility** - report a broken website + +*NOTE*: the following issue types are intended for internal use + +- 💣 **Test** - develop a test or update testing infrastructure +- ✨ **Feature** - implement new features +- ⬅️ **Backport** - cherry-pick change to other release channels +- ⤵️ **Rebase - Alpha** - rebase alpha to latest Firefox ESR version +- ⤵️ **Rebase - Stable** - rebase stable to latest Firefox ESR version +- ⤵️ **Rebase - Rapid** - rebase rapid to latest Firefox Nightly version +- 🚨 **Emergency Security Issue** - manage fixing and publishing a critical security fix ===================================== .gitlab/issue_templates/QA - Android.md deleted ===================================== @@ -1,71 +0,0 @@ -Manual QA test check-list for major android releases. Please copy/paste form into your own comment, fill out relevant info and run through the checklist! -<details> - <summary>Tor Browser Android QA Checklist</summary> -```markdown -# System Information - -- Version: Tor Browser XXX -- OS: Android YYY -- Device + CPU Architecture: ZZZ - -# Features - -## Base functionality -- [ ] Tor Browser launches successfully -- [ ] Connects to the Tor network -- [ ] Localisation (Browser chrome) - - [ ] Check especially the recently added strings -- [ ] Toolbars and menus work -- [ ] Fingerprinting resistance: https://arkenfox.github.io/TZP/tzp.html -- [ ] Security level (Standard, Safer, Safest) - - **TODO**: test pages verifying correct behaviour - -## Proxy safety -- [ ] Tor exit test: https://check.torproject.org -- [ ] Circuit isolation - - Following websites should all report different IP addresses - - https://ifconfig.io - - https://myip.wtf - - https://wtfismyip.com -- [ ] DNS leaks: https://dnsleaktest.com - -## Connectivity + Anti-Censorship -- [ ] Bridges: - - Bootstrap - - Browse: https://check.torproject.org - - [ ] Default bridges: - - [ ] obfs4 - - [ ] meek - - [ ] snowflake - - [ ] User provided bridges: - - [ ] obfs4 from https://bridges.torproject.org - - [ ] webtunnel from https://bridges.torproject.org - - [ ] conjure from [gitlab](https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transpo… - -## Web Browsing -- [ ] HTTPS-Only: http://http.badssl.com -- [ ] .onion: - - [ ] torproject.org onion: http://2gzyxa5ihm7nsggfxnu52rck2vv4rvmdlkiu3zzui5du4xyclen53wid.onion/ - - [ ] Onion service errors - - [ ] invalid onion: http://invalid.onion - - [ ] onion offline: http://wfdn32ds656ycma5gvrh7duvdvxbg2ygzr3no3ijsya25qm6nnko4iqd.onion/ - - [ ] onion baddssl: https://gitlab.torproject.org/tpo/applications/team/-/wikis/Development-Inf… - - **TODO** all the identity block states - - **TODO** client auth -- [ ] **TODO**: .securedrop.tor.onion -- [ ] **TODO**: onion-service alt-svc -- [ ] HTML5 Video: https://tekeye.uk/html/html5-video-test-page - - [ ] MPEG4 - - [ ] WebM - - [ ] Ogg -- [ ] WebSocket Test: https://websocketking.com/ - -## External Components -- [ ] NoScript - - [ ] Latest Version: https://addons.mozilla.org/en-US/firefox/addon/noscript/ - - [ ] Not removable from about:addons - - [ ] Tests: https://test-data.tbb.torproject.org/test-data/noscript/ - - **TODO**: fix test pages -``` - -</details> ===================================== .gitlab/issue_templates/QA - Desktop.md deleted ===================================== @@ -1,164 +0,0 @@ -Manual QA test check-list for major desktop releases. Please copy/paste form into your own comment, fill out relevant info and run through the checklist! - -<details> - <summary>Tor Browser Desktop QA Checklist</summary> - -```markdown -# System Information - -- Version: Tor Browser XXX -- OS: Windows|macOS|Linux YYY -- CPU Architecture: -- Profile: New|Old - -# Features - -## Base functionality -- [ ] Tor Browser launches successfully -- [ ] Connects to the Tor network - - [ ] Homepage loads: - - [ ] about:tor - - [ ] about:blank - - [ ] custom -- [ ] Tor Browser loads URLs passed by command-line after bootstrapped -- [ ] Localisation (Browser chrome) - - [ ] Language notification/message bar - - [ ] Spoof English - - [ ] Check especially the recently added strings -- [ ] UI Customisations: - - [ ] New Identity - - [ ] Toolbar icon - - [ ] Hamburger menu - - [ ] File menu - - [ ] New circuit for this site - - [ ] Circuit display - - [ ] Hamburger menu - - [ ] File menu - - [ ] No Firefox extras (Sync, Pocket, Report broken site, Tracking protection, etc) - - [ ] No unified extensions button (puzzle piece) - - [ ] NoScript button hidden - - [ ] Context Menu Populated -- [ ] Fingerprinting resistance: https://arkenfox.github.io/TZP/tzp.html -- [ ] Security level (Standard, Safer, Safest) - - Displays in: - - toolbar icon - - toolbar panel - - about:preferences#privacy - - [ ] On switch, each UI element is updated - - [ ] On custom config (toggle `svg.disabled`) - - [ ] each UI element displays warning - - [ ] `Restore defaults` reverts custom prefs - - **TODO**: test pages verifying correct behaviour -- [ ] New identity -- [ ] Betterboxing - - [ ] Reuse last window size - - [ ] Content alignment - - [ ] No letterboxing: - - [ ]empty tabs or privileged pages (eg: about:blank, about:about) - - [ ] full-screen video - - [ ] pdf viewer - - [ ] reader-mode -- [ ] Downloads Warning - - [ ] Downloads toolbar panel - - [ ] about:downloads - - [ ] Library window (<kbd>Ctrl</kbd>+<kbd>Shift</kbd>+<kbd>o</kbd>) -- [ ] Drag and Drop protections: - - [ ] Dragging a link from a tab to another tab in the same window works - - [ ] Dragging a link from a tab to another tab in a separate window works - - [ ] Dragging a link into the library creates a bookmark - - [ ] Dragging a link from Tor Browser to Firefox doesn't work - - [ ] Dragging a link from Firefox to Tor Browser works - - [ ] Dragging a link from Tor Browser to another app (e.g., text editor) doesn't work - - [ ] Repeat with page favicon - -## Proxy safety -- [ ] Tor exit test: https://check.torproject.org -- [ ] Circuit isolation - - Following websites should all report different IP addresses - - https://ifconfig.io - - https://myip.wtf - - https://wtfismyip.com -- [ ] DNS leaks: https://dnsleaktest.com -- [ ] Circuit Display - - [ ] Website => circuit - - [ ] Remote PDF => circuit - - [ ] Remote image => circuit - - [ ] .onion Website => circuit with onion-service relays - - [ ] .tor.onion Website => circuit with onion-service relays, link to true onion address - - http://ft.securedrop.tor.onion - - [ ] Website in reader mode => circuit (same as w/o reader mode) - - [ ] Local image => no circuit - - [ ] Local SVG with remote content => catch-all circuit, but not shown - - [ ] Local PDF => no circuit - - [ ] Local HTML `file://` with local resources => no circuit - - [ ] Local HTML `file://` with remote resources => catch-all circuit, but not shown - -## Connectivity + Anti-Censorship -- [ ] Tor daemon config by environment variables - - https://gitlab.torproject.org/tpo/applications/team/-/wikis/Environment-var… -- [ ] Internet Test ( about:preferences#connection ) - - [ ] Fails when offline - - [ ] Succeeds when online -- [ ] Bridges: - - Bootstrap - - Browse: https://check.torproject.org - - Bridge node in circuit-display - - Bridge cards - - Disable - - Remove - - [ ] Default bridges: - - [ ] Removable as a group, not editable - - [ ] obfs4 - - [ ] meek - - [ ] snowflake - - [ ] User provided bridges: - - [ ] Removable and editable individually - - [ ] obfs4 from https://bridges.torproject.org - - [ ] webtunnel from https://bridges.torproject.org - - [ ] conjure from [gitlab](https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transpo… - - [ ] Request bridges... - - [ ] Removable as a group, but not editable - - [ ] Succeeds when bootstrapped - - [ ] Succeeds when not bootstrapped - - **TODO**: Lox -- [ ] Connect Assist - - Useful pref: `torbrowser.debug.censorship_level` - - [ ] Auto-bootstrap updates Tor connection settings on success - - [ ] Auto-bootstrap restore previous Tor connection settings on failure - -## Web Browsing -- [ ] HTTPS-Only: http://http.badssl.com -- [ ] Crypto-currency warning on http website - - **TODO**: we should provide an example page -- [ ] .onion: - - [ ] torproject.org onion: http://2gzyxa5ihm7nsggfxnu52rck2vv4rvmdlkiu3zzui5du4xyclen53wid.onion/ - - [ ] Onion-Location pill - - [ ] Client authentication - - You can create an ephemeral client-auth onion-service using [onion share](https://onionshare.org) - - [ ] Remember key option saves the key between sessions. - - [ ] Saved keys are viewable in preferences (privacy). - - [ ] Can remove individual keys. - - [ ] Can remove all keys at once. - - [ ] Onion service errors - - [ ] invalid onion: http://invalid.onion - - [ ] onion offline: http://wfdn32ds656ycma5gvrh7duvdvxbg2ygzr3no3ijsya25qm6nnko4iqd.onion/ - - [ ] onion baddssl: https://gitlab.torproject.org/tpo/applications/team/-/wikis/Development-Inf… - - **TODO** all the identity block states - - **TODO** client auth -- [ ] **TODO**: .securedrop.tor.onion -- [ ] **TODO**: onion-service alt-svc -- [ ] HTML5 Video: https://tekeye.uk/html/html5-video-test-page - - [ ] MPEG4 - - [ ] WebM - - [ ] Ogg -- [ ] WebSocket Test: https://websocketking.com/ - -## External Components -- [ ] NoScript - - [ ] Latest Version: https://addons.mozilla.org/en-US/firefox/addon/noscript/ - - [ ] Not removable from about:addons - - [ ] Tests: https://test-data.tbb.torproject.org/test-data/noscript/ - - **TODO**: fix test pages -``` - -</details> ===================================== .gitlab/issue_templates/Uplift.md deleted ===================================== @@ -1,26 +0,0 @@ - - -## Uplift Patchset - -### Book-keeping - -#### Gitlab Issue(s) -- tor-browser#12345 -- mullvad-browser#123 - -#### Merge Request(s) -- tor-browser!123 - -#### Upstream Mozilla Issue(s): -- https://bugzilla.mozilla.org/show_bug.cgi?id=12345 - -### Notes - - - -/label ~"Apps::Type::Uplift" ===================================== .gitlab/issue_templates/bug.md deleted ===================================== @@ -1,32 +0,0 @@ - - -### Summary -**Summarize the bug encountered concisely.** - - -### Steps to reproduce: -**How one can reproduce the issue - this is very important.** - -1. Step 1 -2. Step 2 -3. ... - -### What is the current bug behavior? -**What actually happens.** - - -### What is the expected behavior? -**What you want to see instead** - - - -### Environment -**Which operating system are you using? For example: Debian GNU/Linux 10.1, Windows 10, Ubuntu Xenial, FreeBSD 12.2, etc.** -**Which installation method did you use? Distribution package (apt, pkg, homebrew), from source tarball, from Git, etc.** - -### Relevant logs and/or screenshots - - -/label ~"Apps::Type::Bug" ===================================== .gitlab/merge_request_templates/default.md → .gitlab/merge_request_templates/Default.md ===================================== @@ -64,6 +64,7 @@ - **accessibility** : henry - **android** : clairehurst, dan - **build system** : boklm + - **ci/cd**: brizental, henry - **extensions** : ma1 - **firefox internals (XUL/JS/XPCOM)** : jwilde, ma1 - **fonts** : pierov @@ -72,7 +73,7 @@ - **localization** : henry, pierov - **macOS** : clairehurst, dan - **nightly builds** : boklm - - **rebases/release-prep** : dan, ma1, pierov, morgan + - **rebases/release-prep** : brizental, clairehurst, dan, ma1, pierov, morgan - **security** : jwilde, ma1 - **signing** : boklm, morgan - **updater** : pierov View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/95… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/95… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.9.0esr-14.5-1] 6 commits: fixup! TB 41649: Create rebase and security backport gitlab issue templates
by morgan (＠morgan) 17 Apr '25

17 Apr '25

morgan pushed to branch tor-browser-128.9.0esr-14.5-1 at The Tor Project / Applications / Tor Browser Commits: 6ddec96c by Morgan at 2025-04-16T15:28:30+00:00 fixup! TB 41649: Create rebase and security backport gitlab issue templates revert - - - - - ede238fb by Morgan at 2025-04-16T15:28:31+00:00 fixup! Adding issue and merge request templates revert - - - - - 7f040e37 by Morgan at 2025-04-17T14:31:33+00:00 BB 43615: Add Gitlab Issue and Merge Request templates - - - - - ee512804 by Morgan at 2025-04-17T15:36:37+00:00 fixup! BB 43615: Add Gitlab Issue and Merge Request templates add new and modify existing shared Tor/Mullvad browser templates - - - - - 8f2c9d34 by Morgan at 2025-04-17T15:36:37+00:00 TB 43616: Customize Gitlab Issue and Merge Request templates - - - - - 17438f0d by Morgan at 2025-04-17T15:36:38+00:00 fixup! TB 43616: Customize Gitlab Issue and Merge Request templates Tor Browser specific updates - - - - - 22 changed files: - + .gitlab/issue_templates/000 Bug Report.md - + .gitlab/issue_templates/010 Proposal.md - + .gitlab/issue_templates/020 Web Compatibility.md - + .gitlab/issue_templates/030 Test.md - + .gitlab/issue_templates/040 Feature.md - .gitlab/issue_templates/Backport.md → .gitlab/issue_templates/050 Backport.md - .gitlab/issue_templates/Rebase Browser - Alpha.md → .gitlab/issue_templates/060 Rebase - Alpha.md - .gitlab/issue_templates/Rebase Browser - Stable.md → .gitlab/issue_templates/061 Rebase - Stable.md - .gitlab/issue_templates/Rebase Browser - Legacy.md → .gitlab/issue_templates/062 Rebase - Legacy.md - .gitlab/issue_templates/Rebase Browser - Rapid.md → .gitlab/issue_templates/063 Rebase - Rapid.md - .gitlab/issue_templates/Uplift.md → .gitlab/issue_templates/070 Uplift.md - .gitlab/issue_templates/Backport Android Security Fixes.md → .gitlab/issue_templates/080 Security Backports.md - .gitlab/issue_templates/Emergency Security Issue.md → .gitlab/issue_templates/090 Emergency Security Issue.md - .gitlab/issue_templates/QA - Desktop.md → .gitlab/issue_templates/100 Release QA - Desktop.md - .gitlab/issue_templates/QA - Android.md → .gitlab/issue_templates/101 Release QA - Android.md - + .gitlab/issue_templates/110 Bugzilla Triage.md - .gitlab/issue_templates/Bugzilla Audit.md → .gitlab/issue_templates/120 Bugzilla Audit.md - − .gitlab/issue_templates/Bugzilla Triage.md - + .gitlab/issue_templates/Default.md - − .gitlab/issue_templates/bug.md - .gitlab/merge_request_templates/default.md → .gitlab/merge_request_templates/Default.md - − .gitlab/merge_request_templates/Rebase.md Changes: ===================================== .gitlab/issue_templates/000 Bug Report.md ===================================== @@ -0,0 +1,121 @@ +# 🐞 Bug Report + + +## Reproduction steps + + +## Expected behaviour + + +## Actual behaviour + + +## Bookkeeping + + +- Browser version: +- Browser channel: + - [ ] Release + - [ ] Alpha + - [ ] Nightly +- Distribution method: + - [ ] Installer/archive from torproject.org + - [ ] tor-browser-launcher + - [ ] homebrew + - [ ] other (please specify): +- Operating System: + - [ ] Windows + - [ ] macOS + - [ ] Linux + - [ ] Android + - [ ] Tails + - [ ] Other (please specify): +- Operating System Version: + +### Browser UI language + + +### Have you modified any of the settings in `about:preferences` or `about:config`? If yes, which ones? + + +### Do you have any extra extensions installed? + + +## Troubleshooting + + +### Does this bug occur in a fresh installation? + +### Is this bug new? If it is a regression, in which version of the browser did this bug first appear? + + +### Does this bug occur in the Alpha release channel? + + +### Does this bug occur in Firefox ESR (Desktop only)? + + +### Does this bug occur in Firefox Rapid Release? + + + + +--- + +/label ~"Apps::Product::TorBrowser" +/label ~"Apps::Type::Bug" ===================================== .gitlab/issue_templates/010 Proposal.md ===================================== @@ -0,0 +1,70 @@ +# 💡 Proposal + + +## User Story + + +## Security and Privacy Implications + + +### Security + + +### Privacy + + +## Accessibility Implications + + +## Other Trade-Offs + + +## Prior Art + +### Does this feature exist in other browsers? +- [ ] Yes + - [ ] Firefox + - [ ] Firefox ESR + - [ ] Other (please specify) +- [ ] No + +### Does this feature exist as an extension? If yes, which one provides this functionality? + + + +--- + +/label ~"Apps::Product::TorBrowser" +/label ~"Apps::Type::Proposal" ===================================== .gitlab/issue_templates/020 Web Compatibility.md ===================================== @@ -0,0 +1,112 @@ +# 🌍 Web Compatibility + + +## URL + + +## Expected behaviour + + +## Actual behaviour + + +## Reproduction steps + + +## Bookkeeping + + +- Browser version: +- Browser channel: + - [ ] Release + - [ ] Alpha + - [ ] Nightly +- Distribution method: + - [ ] Installer/archive from torproject.org + - [ ] tor-browser-launcher + - [ ] homebrew + - [ ] other (please specify): +- Operating System: + - [ ] Windows + - [ ] macOS + - [ ] Linux + - [ ] Android + - [ ] Tails + - [ ] Other (please specify): +- Operating System Version: + +### Have you modified any of the settings in `about:preferences` or `about:config`? If yes, which ones? + + +### Do you have any extra extensions installed? + + +## Troubleshooting + + +### Does this bug occur in a fresh installation? + +### Is this bug new? If it is a regression, in which version of the browser did this bug first appear? + + +### Does this bug occur in the Alpha release channel? + + +### Does this bug occur in Firefox ESR (Desktop only)? + + +### Does this bug occur in Firefox Rapid Release? + + + + +--- + +/label ~"Apps::Product::TorBrowser" +/label ~"Apps::Type::WebCompatibility" ===================================== .gitlab/issue_templates/030 Test.md ===================================== @@ -0,0 +1,29 @@ +# 💣 Test + + +## Description + + +## Scenarios + + + + +--- + +/label ~"Apps::Product::TorBrowser" +/label ~"Apps::Type::Test" ===================================== .gitlab/issue_templates/040 Feature.md ===================================== @@ -0,0 +1,32 @@ +# ✨ Feature + + +## Description + + +## Bookkeeping + +### Proposal + +- tor-browser#12345 + +### Design + +- tpo/UX/Design#123 + + + +--- + +/label ~"Apps::Product::TorBrowser" +/label ~"Apps::Type::Feature" ===================================== .gitlab/issue_templates/Backport.md → .gitlab/issue_templates/050 Backport.md ===================================== @@ -1,31 +1,39 @@ +# ⬅️ Backport Patchset  +please ensure the title has the following format: + +- Backport tor-browser#12345: Title of original issue +- Backport Bugzilla 1234567: Title of original issue -## Backport Patchset +--> -### Book-keeping +## Bookkeeping -#### Issue(s) +### Issue(s) - tor-browser#12345 - mullvad-browser#123 - https://bugzilla.mozilla.org/show_bug.cgi?id=1234567 -#### Merge Request(s) +### Merge Request(s) - tor-browser!123 -#### Target Channels +### Target Channels - [ ] Alpha - [ ] Stable - [ ] Legacy -### Notes +## Notes  + + + +--- + +/label ~"Apps::Product::TorBrowser" /label ~"Apps::Type::Backport" ===================================== .gitlab/issue_templates/Rebase Browser - Alpha.md → .gitlab/issue_templates/060 Rebase - Alpha.md ===================================== @@ -1,3 +1,5 @@ +# ⤵️ Rebase Alpha + **NOTE:** All examples in this template reference the rebase from 102.7.0esr to 102.8.0esr <details> @@ -152,4 +154,10 @@ - [ ] Update `firefox_platform_version` - [ ] Set `browser_build` to 1 (to prevent failures in alpha testbuilds) + + +--- + +/label ~"Apps::Product::TorBrowser" /label ~"Apps::Type::Rebase" +/label ~"Apps::Priority::Blocker" ===================================== .gitlab/issue_templates/Rebase Browser - Stable.md → .gitlab/issue_templates/061 Rebase - Stable.md ===================================== @@ -1,3 +1,5 @@ +# ⤵️ Rebase Stable + **NOTE:** All examples in this template reference the rebase from 102.7.0esr to 102.8.0esr <details> @@ -114,4 +116,10 @@ ``` - [ ] Push tag to `upstream` + + +--- + +/label ~"Apps::Product::TorBrowser" /label ~"Apps::Type::Rebase" +/label ~"Apps::Priority::Blocker" ===================================== .gitlab/issue_templates/Rebase Browser - Legacy.md → .gitlab/issue_templates/062 Rebase - Legacy.md ===================================== @@ -1,3 +1,5 @@ +# ⤵️ Rebase Legacy + **NOTE:** All examples in this template reference the rebase from 115.17.0esr to 115.18.0esr <details> @@ -110,4 +112,10 @@ ``` - [ ] Push tag to `upstream` + + +--- + +/label ~"Apps::Product::TorBrowser" /label ~"Apps::Type::Rebase" +/label ~"Apps::Priority::Blocker" ===================================== .gitlab/issue_templates/Rebase Browser - Rapid.md → .gitlab/issue_templates/063 Rebase - Rapid.md ===================================== @@ -1,3 +1,5 @@ +# ⤵️ Rebase Rapid + - **NOTE**: All examples in this template reference the rebase from Firefox 129.0a1 to 130.0a1 - **TODO**: - Documentation step for any difficulties or noteworthy things for each rapid rebase @@ -289,4 +291,10 @@ gitGraph: ``` - [ ] Push tag to `upstream` + + +--- + +/label ~"Apps::Product::TorBrowser" /label ~"Apps::Type::Rebase" +/label ~"Apps::Priority::High" ===================================== .gitlab/issue_templates/Uplift.md → .gitlab/issue_templates/070 Uplift.md ===================================== @@ -1,3 +1,4 @@ +# ⬆️ **Uplift**  -## Uplift Patchset +## Book-keeping -### Book-keeping - -#### Gitlab Issue(s) +### Gitlab Issue(s) - tor-browser#12345 - mullvad-browser#123 -#### Merge Request(s) +### Merge Request(s) - tor-browser!123 -#### Upstream Mozilla Issue(s): +### Upstream Mozilla Issue(s): - https://bugzilla.mozilla.org/show_bug.cgi?id=12345 -### Notes +## Notes + + + - +--- +/label ~"Apps::Product::TorBrowser" /label ~"Apps::Type::Uplift" ===================================== .gitlab/issue_templates/Backport Android Security Fixes.md → .gitlab/issue_templates/080 Security Backports.md ===================================== @@ -1,3 +1,5 @@ +# 🛡️ **Security Backports** + <details> <summary>Explanation of Variables</summary> @@ -16,20 +18,14 @@ **NOTE:** It is assumed the `tor-browser` rebases (stable and alpha) have already happened and there exists a `build1` build tags for both `base-browser` and `tor-browser` (stable and alpha) -### **Bookkeeping** +## **Bookkeeping** -- [ ] Link this issue to the appropriate [Release Prep](https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/is… issues (stable and alpha). +- [ ] Link this issue to the appropriate [Release Prep](https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/is… issues (alpha, stable, and legacy). -### **Security Vulnerabilities Report**: https://www.mozilla.org/en-US/security/advisories/ +## **Security Vulnerabilities Report**: https://www.mozilla.org/en-US/security/advisories/ - Potentially Affected Components: - `firefox`/`geckoview`: https://github.com/mozilla/gecko-dev - - `application-services`: https://github.com/mozilla/application-services - - `android-components` (ESR 102 only): https://github.com/mozilla-mobile/firefox-android - - `fenix` (ESR 102 only): https://github.com/mozilla-mobile/firefox-android - - `firefox-android`: https://github.com/mozilla-mobile/firefox-android - -**NOTE:** `android-components` and `fenix` used to have their own repos, but since November 2022 they have converged to a single `firefox-android` repo. Any backports will require manually porting patches over to our legacy repos until we have transitioned to ESR 115. - [ ] Go through the `Security Vulnerabilities fixed in Firefox $(RR_VERSION)` report and create a candidate list of CVEs which potentially need to be backported in this issue: - CVEs which are explicitly labeled as 'Android' only @@ -43,100 +39,49 @@ - To find the `gecko-dev` version of a `mozilla-central`, search for a unique string in the relevant `mozilla-central` commit message in the `gecko-dev/release` branch log. - **NOTE:** This process is unfortunately somewhat poorly defined/ad-hoc given the general variation in how Bugzilla issues are labeled and resolved. In general this is going to involve a bit of hunting to identify needed commits or determining whether or not the fix is relevant. -### CVEs +## CVEs  -### **tor-browser**: https://gitlab.torproject.org/tpo/applications/tor-browser.git +## **tor-browser**: https://gitlab.torproject.org/tpo/applications/tor-browser.git - [ ] Backport any Android-specific security fixes from Firefox rapid-release - [ ] Backport patches to `tor-browser` stable branch - [ ] Open MR - [ ] Merge - - [ ] Rebase patches onto: + - [ ] cherry-pick patches onto: - [ ] `base-browser` stable + - [ ] `mullvad-browser` stable - [ ] `tor-browser` alpha - [ ] `base-browser` alpha + - [ ] `mullvad-browser` alpha - [ ] Sign/Tag commits: - - **Tag**: `$(PROJECT_NAME)-$(ESR_VERSION)-$(TOR_BROWSER_MAJOR).$(TOR_BROWSER_MINOR)-1-$(BUILD_N)` - - **Message**: `Tagging $(BUILD_N) for $(ESR_VERSION)-based stable|alpha)` + - In **tor-browser-build.git**, run signing script: + ```bash + ./tools/browser/sign-tag.${PROJECT_NAME} ${CHANNEL} ${BUILD_N} + ``` - [ ] `base-browser` stable - [ ] `tor-browser` stable + - [ ] `mullvad-browser` stable - [ ] `base-browser` alpha - [ ] `tor-browser` alpha - - [ ] Push tags to `upstream` -- **OR** -- [ ] No backports + - [ ] `mullvad-browser` alpha -### **application-services**: https://gitlab.torproject.org/tpo/applications/application-services -- **NOTE**: we will need to setup a gitlab copy of this repo and update `tor-browser-build` before we can apply security backports here -- [ ] Backport any Android-specific security fixes from Firefox rapid-release - - [ ] Backport patches to `application-services` stable branch - - [ ] Open MR - - [ ] Merge - - [ ] Rebase patches onto `application-services` alpha - - [ ] Sign/Tag commits: - - **Tag**: `application-services-$(ESR_VERSION)-$(TOR_BROWSER_MAJOR).$(TOR_BROWSER_MINOR)-1-$(BUILD_N)` - - **Message**: `Tagging $(BUILD_N) for $(ESR_VERSION)-based stable|alpha` - - [ ] `application-services` stable - - [ ] `application-services` alpha - [ ] Push tags to `upstream` - **OR** - [ ] No backports + -### **android-components (Optional, ESR 102)**: https://gitlab.torproject.org/tpo/applications/android-components.git -- [ ] Backport any Android-specific security fixes from Firefox rapid-release - - **NOTE**: Since November 2022, this repo has been merged with `fenix` into a singular `firefox-android` repo: https://github.com/mozilla-mobile/firefox-android. Any backport will require a patch rewrite to apply to our legacy `android-components` project. - - [ ] Backport patches to `android-components` stable branch - - [ ] Open MR - - [ ] Merge - - [ ] Rebase patches onto `android-components` alpha - - [ ] Sign/Tag commits: - - **Tag**: `android-components-$(ESR_VERSION)-$(TOR_BROWSER_MAJOR).$(TOR_BROWSER_MINOR)-1-$(BUILD_N)` - - **Message**: `Tagging $(BUILD_N) for $(ESR_VERSION)-based stable|alpha)` - - [ ] `android-components` stable - - [ ] `android-components` alpha - - [ ] Push tags to `upstream` -- **OR** -- [ ] No backports - - -### **fenix (Optional, ESR 102)**: https://gitlab.torproject.org/tpo/applications/fenix.git -- [ ] Backport any Android-specific security fixes from Firefox rapid-release - - **NOTE**: Since February 2023, this repo has been merged with `android-components` into a singular `firefox-android` repo: https://github.com/mozilla-mobile/firefox-android. Any backport will require a patch rewrite to apply to our legacy `fenix` project. - - [ ] Backport patches to `fenix` stable branch - - [ ] Open MR - - [ ] Merge - - [ ] Rebase patches onto `fenix` alpha - - [ ] Sign/Tag commits: - - **Tag**: `tor-browser-$(ESR_VERSION)-$(TOR_BROWSER_MAJOR).$(TOR_BROWSER_MINOR)-1-$(BUILD_N)` - - **Message**: `Tagging $(BUILD_N) for $(ESR_VERSION)-based stable|alpha)` - - [ ] `fenix` stable - - [ ] `fenix` alpha - - [ ] Push tags to `upstream` -- **OR** -- [ ] No backports - -### **firefox-android**: https://gitlab.torproject.org/tpo/applications/firefox-android -- [ ] Backport any Android-specific security fixes from Firefox rapid-release - - [ ] Backport patches to `firefox-android` stable branch - - [ ] Open MR - - [ ] Merge - - [ ] Rebase patches onto `fenix` alpha - - [ ] Sign/Tag commits: - - **Tag**: `firefox-android-$(ESR_VERSION)-$(TOR_BROWSER_MAJOR).$(TOR_BROWSER_MINOR)-1-$(BUILD_N)` - - **Message**: `Tagging $(BUILD_N) for $(ESR_VERSION)-based stable|alpha)` - - [ ] `firefox-android` stable - - [ ] `firefox-android` alpha - - [ ] Push tags to `upstream` -- **OR** -- [ ] No backports +--- /confidential +/label ~"Apps::Product::TorBrowser" +/label ~"Apps::Product::MullvadBrowser" +/label ~"Apps::Type::Backport" +/label ~"Apps::Priority::Blocker" ===================================== .gitlab/issue_templates/Emergency Security Issue.md → .gitlab/issue_templates/090 Emergency Security Issue.md ===================================== @@ -1,3 +1,5 @@ +# 🚨 Emergency Security Issue + **NOTE** This is an issue template to standardise our process for responding to and fixing critical security and privacy vulnerabilities, exploits, etc. ## Information @@ -31,9 +33,10 @@ - [ ] **clairehurst** : Android, macOS - [ ] **dan** : Android, macOS - [ ] **henry** : accessibility, frontend, localisation + - [ ] **jwilde** : windows, firefox internals - [ ] **ma1** : firefox internals - [ ] **pierov** : updater, fonts, localisation, general - - [ ] **richard** : signing, release + - [ ] **morgan** : signing, release - [ ] **thorin** : fingerprinting - [ ] Other Engineering Teams - [ ] Networking (**ahf**, **dgoulet**) @@ -80,11 +83,20 @@ Sometimes fixes have side-effects: users lose their data, roadmaps need to be ad - [ ] **(Optional)** **gazebook** - if there are consequences to the organisation or partners beyond a browser update, then a communication plan may be needed +Godspeed! :pray: + + + +--- + /cc @bella /cc @ma1 /cc @micah -/cc @richard +/cc @morgan /confidential -Godspeed! :pray: +/label ~"Apps::Product::TorBrowser" +/label ~"Apps::Product::MullvadBrowser" +/label ~"Apps::Type::Bug" +/label ~"Apps::Priority::Blocker" ===================================== .gitlab/issue_templates/QA - Desktop.md → .gitlab/issue_templates/100 Release QA - Desktop.md ===================================== @@ -1,9 +1,11 @@ +# ✅ Release QA - Desktop + Manual QA test check-list for major desktop releases. Please copy/paste form into your own comment, fill out relevant info and run through the checklist! <details> <summary>Tor Browser Desktop QA Checklist</summary> -```markdown +``` # System Information - Version: Tor Browser XXX @@ -25,6 +27,8 @@ Manual QA test check-list for major desktop releases. Please copy/paste form int - [ ] Language notification/message bar - [ ] Spoof English - [ ] Check especially the recently added strings + - [ ] New Locales + - [ ] Bulgarian, Belarusian, Portuguese (PT) - [ ] UI Customisations: - [ ] New Identity - [ ] Toolbar icon @@ -53,8 +57,9 @@ Manual QA test check-list for major desktop releases. Please copy/paste form int - [ ] Betterboxing - [ ] Reuse last window size - [ ] Content alignment + - [ ] Window size indicator on window resize - [ ] No letterboxing: - - [ ]empty tabs or privileged pages (eg: about:blank, about:about) + - [ ] empty tabs or privileged pages (eg: about:blank, about:about) - [ ] full-screen video - [ ] pdf viewer - [ ] reader-mode @@ -96,8 +101,9 @@ Manual QA test check-list for major desktop releases. Please copy/paste form int ## Connectivity + Anti-Censorship - [ ] Tor daemon config by environment variables - https://gitlab.torproject.org/tpo/applications/team/-/wikis/Environment-var… -- [ ] Internet Test ( about:preferences#connection ) - - [ ] Fails when offline +- [ ] Internet Test ( bootstrap, also visible in about:preferences#connection ) + - [ ] Fails when offline (Goes to offline about:neterror) + - **NOTE**: platform dependent, expected that Linux will just try to bootstrap forever - [ ] Succeeds when online - [ ] Bridges: - Bootstrap @@ -122,7 +128,8 @@ Manual QA test check-list for major desktop releases. Please copy/paste form int - [ ] Succeeds when not bootstrapped - **TODO**: Lox - [ ] Connect Assist - - Useful pref: `torbrowser.debug.censorship_level` + - Useful pref: `torbrowser.debug.censorship_level` (0-5; least to most censored) + - [ ] Connect Automatically checkbox triggers bootstrapping after one successful bootstrap attempt - [ ] Auto-bootstrap updates Tor connection settings on success - [ ] Auto-bootstrap restore previous Tor connection settings on failure @@ -147,10 +154,14 @@ Manual QA test check-list for major desktop releases. Please copy/paste form int - **TODO** client auth - [ ] **TODO**: .securedrop.tor.onion - [ ] **TODO**: onion-service alt-svc -- [ ] HTML5 Video: https://tekeye.uk/html/html5-video-test-page - - [ ] MPEG4 - - [ ] WebM - - [ ] Ogg +- [ ] HTML5 Video: https://onion-tests.pierov.org/video.html + - [ ] H264 + - [ ] VP9 + - [ ] VP8 + - [ ] AV1 + - [ ] Theora + - [ ] MPEG4 + mp3: only audio should work + - [ ] HEVC + AAC: should not work - [ ] WebSocket Test: https://websocketking.com/ ## External Components @@ -159,6 +170,43 @@ Manual QA test check-list for major desktop releases. Please copy/paste form int - [ ] Not removable from about:addons - [ ] Tests: https://test-data.tbb.torproject.org/test-data/noscript/ - **TODO**: fix test pages + +## Tor Settings (about:preferences#connection) +- [ ] Proxy + - [ ] Bad Proxy Address Reports Error; e.g. any bad bad proxy address/port/etc + - [ ] On initial failure gives error modal + - [ ] On browser restart, will also give an error if provided a bad setting + - [ ] Good Proxy Works + - [ ] SOCKS5 +- [ ] Bridge + - [ ] Bad Bridge Fails with error modal; eg: `0:0` + - [ ] Modifying Bridges *during* bootstrap should cancel bootstrap +- [ ] Firewall + - [ ] UI shouldn't accept bad ports (e.g. invalid port numbers, non-numbers, etc) +- [ ] Each individual setting type has it's own validation (i.e. not all or nothing anymore) + ``` </details> + +Please lay claim to a platform in the comments: + +- Windows + - Windows 10, Windows 11 + - x86 + - x86_64 +- macOS + - 10.15, 15.x + - x86_64 + - aarch64 +- Linux + - x86 + - x86_64 + + + +--- + +/label ~"Apps::Product::TorBrowser" +/label ~"Apps::Type::Test" +/label ~"Apps::Priority::Blocker" ===================================== .gitlab/issue_templates/QA - Android.md → .gitlab/issue_templates/101 Release QA - Android.md ===================================== @@ -1,7 +1,11 @@ +# ✅ Release QA - Android + Manual QA test check-list for major android releases. Please copy/paste form into your own comment, fill out relevant info and run through the checklist! + <details> <summary>Tor Browser Android QA Checklist</summary> -```markdown + +``` # System Information - Version: Tor Browser XXX @@ -19,6 +23,11 @@ Manual QA test check-list for major android releases. Please copy/paste form int - [ ] Fingerprinting resistance: https://arkenfox.github.io/TZP/tzp.html - [ ] Security level (Standard, Safer, Safest) - **TODO**: test pages verifying correct behaviour +- [ ] Bookmarks: for now ensure adding/removing/etc work as expected and doesn't busy-spin + +### Localisation +- [ ] New Locales + - [ ] Bulgarian, Belarusian, Portuguese (PT) ## Proxy safety - [ ] Tor exit test: https://check.torproject.org @@ -30,6 +39,8 @@ Manual QA test check-list for major android releases. Please copy/paste form int - [ ] DNS leaks: https://dnsleaktest.com ## Connectivity + Anti-Censorship +- [ ] Internet Test (try connect assist while actually offline) + - [ ] We expect this to fail but we should see what it actually does - [ ] Bridges: - Bootstrap - Browse: https://check.torproject.org @@ -41,6 +52,11 @@ Manual QA test check-list for major android releases. Please copy/paste form int - [ ] obfs4 from https://bridges.torproject.org - [ ] webtunnel from https://bridges.torproject.org - [ ] conjure from [gitlab](https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transpo… +- [ ] Connect Assist + - Useful pref: `torbrowser.debug.censorship_level` (0-5; least to most censored) + - [ ] Connect Automatically checkbox triggers bootstrapping after one successful bootstrap attempt + - [ ] Auto-bootstrap updates Tor connection settings on success + - [ ] Auto-bootstrap restore previous Tor connection settings on failure ## Web Browsing - [ ] HTTPS-Only: http://http.badssl.com @@ -54,10 +70,14 @@ Manual QA test check-list for major android releases. Please copy/paste form int - **TODO** client auth - [ ] **TODO**: .securedrop.tor.onion - [ ] **TODO**: onion-service alt-svc -- [ ] HTML5 Video: https://tekeye.uk/html/html5-video-test-page - - [ ] MPEG4 - - [ ] WebM - - [ ] Ogg +- [ ] HTML5 Video: https://onion-tests.pierov.org/video.html + - [ ] H264 + - [ ] VP9 + - [ ] VP8 + - [ ] AV1 + - [ ] Theora + - [ ] MPEG4 + mp3: only audio should work + - [ ] HEVC + AAC: should not work - [ ] WebSocket Test: https://websocketking.com/ ## External Components @@ -69,3 +89,19 @@ Manual QA test check-list for major android releases. Please copy/paste form int ``` </details> + +Please lay claim to an architecture in the comments: + +Architectures: +- x86 +- x86_64 +- arm32 +- aarch64 + + + +--- + +/label ~"Apps::Product::TorBrowser" +/label ~"Apps::Type::Test" +/label ~"Apps::Priority::Blocker" ===================================== .gitlab/issue_templates/110 Bugzilla Triage.md ===================================== @@ -0,0 +1,56 @@ +# 📋 Bugzilla Triage + +**NOTE** This issue presumes the branches and tags for the next Firefox release have already been created in tor-browser.git + +- [ ] Generate Bugzilla triage CSV + - Run (from `tor-browser-build` root): + ```bash + ./tools/browser/generate-bugzilla-triage-csv ${FIREFOX_VERSION} ${PREVIOUS_NIGHTLY_TAG} ${NEXT_NIGHLTY_TAG} ${TRIAGE_ISSUE_NUMBER} ${REVIEWERS} > out.csv + ``` + - `${FIREFOX_VERSION}`: the major Firefox version of the nightly to review + - **Example**: 129 + - `${PREVIOUS_NIGHTLY_TAG}`: the nightly 'end' tag of the previous major Firefox version + - **Example**: `FIREFOX_NIGHTLY_128_END` + - `${NEXT_NIGHLTY_TAG}`: the nightly 'end' tag of the next major Firefox version we are reviewing + - **Example**: `FIREFOX_NIGHTLY_129_END` + - `${TRIAGE_ISSUE_NUMBER}`: this `tor-browser` issue + - **Example**: `43303` + - `${REVIEWERS}`: `morgan` and two additional devs to triage this Firefox version + - `boklm` + - `brizental` + - `clairehurst` + - `dan` + - `henry` + - `jwilde` + - `ma1` + - `pierov` + - **Example**: + ```bash + ./tools/browser/generate-bugzilla-triage-csv 129 FIREFOX_NIGHTLY_128_END FIREFOX_NIGHTLY_129_END 43303 morgan pierov henry > 129.csv + ``` +- [ ] Attach the generated CSV file to the triage isssue +- [ ] Import to Google Sheets ( https://sheets.google.com ) + - [ ] Create blank spreadsheet + - [ ] **Title**: `Bugzilla Triage ${VERSION}` + - [ ] Import CSV: File > Import > Upload + - **Import location**: "Replace spreadsheet" + - **Separator type**: "Comma" + - **Convert text to numbers, dates, and fomulas**: "✅" + - [ ] Convert 'Review' column's issue cells to check-boxes: + - Select relevant cells (i.e.: `A2:A1554` for in the 129 triage) + - Insert > Checkbox + - [ ] Convert 'Triaged by' cells to check-boxes + - [ ] Share Spreadsheet + - 🔒 Share > General access + - Change `Restricted` to `Anyone with the link` + - Post link in an internal note on this issue +- [ ] Page requested reviewers to this issue +- [ ] Triage Completed by: + - [ ] morgan + - [ ] reviewer 1  + - [ ] reviewer 2  + +/label ~"esr-140" +/label ~"Apps::Product::TorBrowser" +/label ~"Apps::Type::Audit" +/label ~"Apps::Priority::Blocker" ===================================== .gitlab/issue_templates/Bugzilla Audit.md → .gitlab/issue_templates/120 Bugzilla Audit.md ===================================== @@ -1,3 +1,4 @@ +# 🔍 Bugzilla Audit  +## Description + + + + +---  /label ~"esr-140" - -/label ~"Bugzilla Review" ~"Apps::Type::Audit" +/label ~"Apps::Product::TorBrowser" +/label ~"Apps::Type::Audit" +/label ~"Apps::Priority::Blocker" ===================================== .gitlab/issue_templates/Bugzilla Triage.md deleted ===================================== @@ -1,51 +0,0 @@ - # Bugzilla Triage - - **NOTE** This issue presumes the branches and tags for the next Firefox release have already been created in tor-browser.git - - - [ ] Generate Bugzilla triage CSV - - Run (from `tor-browser-build` root): - ```bash - ./tools/browser/generate-bugzilla-triage-csv ${FIREFOX_VERSION} ${PREVIOUS_NIGHTLY_TAG} ${NEXT_NIGHLTY_TAG} ${TRIAGE_ISSUE_NUMBER} ${REVIEWERS} > out.csv - ``` - - `${FIREFOX_VERSION}`: the major Firefox version of the nightly to review - - **Example**: 129 - - `${PREVIOUS_NIGHTLY_TAG}`: the nightly 'end' tag of the previous major Firefox version - - **Example**: `FIREFOX_NIGHTLY_128_END` - - `${NEXT_NIGHLTY_TAG}`: the nightly 'end' tag of the next major Firefox version we are reviewing - - **Example**: `FIREFOX_NIGHTLY_129_END` - - `${TRIAGE_ISSUE_NUMBER}`: this `tor-browser` issue - - **Example**: `43303` - - `${REVIEWERS}`: `morgan` and two additional devs to triage this Firefox version - - `boklm` - - `brizental` - - `clairehurst` - - `dan` - - `henry` - - `jwilde` - - `ma1` - - `pierov` - - **Example**: - ```bash - ./tools/browser/generate-bugzilla-triage-csv 129 FIREFOX_NIGHTLY_128_END FIREFOX_NIGHTLY_129_END 43303 morgan pierov henry > 129.csv - ``` - - [ ] Attach the generated CSV file to the triage isssue - - [ ] Import to Google Sheets ( https://sheets.google.com ) - - [ ] Create blank spreadsheet - - [ ] **Title**: `Bugzilla Triage ${VERSION}` - - [ ] Import CSV: File > Import > Upload - - **Import location**: "Replace spreadsheet" - - **Separator type**: "Comma" - - **Convert text to numbers, dates, and fomulas**: "✅" - - [ ] Convert 'Review' column's issue cells to check-boxes: - - Select relevant cells (i.e.: `A2:A1554` for in the 129 triage) - - Insert > Checkbox - - [ ] Convert 'Triaged by' cells to check-boxes - - [ ] Share Spreadsheet - - 🔒 Share > General access - - Change `Restricted` to `Anyone with the link` - - Post link in an internal note on this issue - - [ ] Page requested reviewers to this issue - - [ ] Triage Completed by: - - [ ] morgan - - [ ] reviewer 1  - - [ ] reviewer 2  ===================================== .gitlab/issue_templates/Default.md ===================================== @@ -0,0 +1,26 @@ +# Open a new Issue + +Please select the appropriate issue template from the **Description** drop-down. + +--- + +- 🐞 **Bug Report** - report a problem with the browser +- 💡 **Proposal** - suggest a new feature +- 🌐 **Web Compatibility** - report a broken website + +*NOTE*: the following issue types are intended for internal use + +- 💣 **Test** - develop a test or update testing infrastructure +- ✨ **Feature** - implement new features +- ⬅️ **Backport** - cherry-pick change to other release channels +- ⤵️ **Rebase - Alpha** - rebase alpha to latest Firefox ESR version +- ⤵️ **Rebase - Stable** - rebase stable to latest Firefox ESR version +- ⤵️ **Rebase - Legacy** - rebase legacy to latest Firefox ESR 115 version +- ⤵️ **Rebase - Rapid** - rebase rapid to latest Firefox Nightly version +- ⬆️ **Uplift** - uplift change to upstream project +- 🛡️ **Security Backports** - cherry-pick security fixes from Firefox +- 🚨 **Emergency Security Issue** - manage fixing and publishing a critical security fix +- ✅ **Release QA - Desktop** - test and verify functionality of our Desktop release +- ✅ **Release QA - Android** - test and verify functionality of our Android release +- 📋 **Bugzilla Triage** - identify upstream Firefox issues which need to be audited +- 🔍 **Bugzilla Audit** - determine if/how an upstream change affects the browser ===================================== .gitlab/issue_templates/bug.md deleted ===================================== @@ -1,32 +0,0 @@ - - -### Summary -**Summarize the bug encountered concisely.** - - -### Steps to reproduce: -**How one can reproduce the issue - this is very important.** - -1. Step 1 -2. Step 2 -3. ... - -### What is the current bug behavior? -**What actually happens.** - - -### What is the expected behavior? -**What you want to see instead** - - - -### Environment -**Which operating system are you using? For example: Debian GNU/Linux 10.1, Windows 10, Ubuntu Xenial, FreeBSD 12.2, etc.** -**Which installation method did you use? Distribution package (apt, pkg, homebrew), from source tarball, from Git, etc.** - -### Relevant logs and/or screenshots - - -/label ~"Apps::Type::Bug" ===================================== .gitlab/merge_request_templates/default.md → .gitlab/merge_request_templates/Default.md ===================================== @@ -66,6 +66,7 @@ - **accessibility** : henry - **android** : clairehurst, dan - **build system** : boklm + - **ci/cd**: brizental, henry - **extensions** : ma1 - **firefox internals (XUL/JS/XPCOM)** : jwilde, ma1 - **fonts** : pierov @@ -74,7 +75,7 @@ - **localization** : henry, pierov - **macOS** : clairehurst, dan - **nightly builds** : boklm - - **rebases/release-prep** : dan, ma1, pierov, morgan + - **rebases/release-prep** : brizental, clairehurst, dan, ma1, pierov, morgan - **security** : jwilde, ma1 - **signing** : boklm, morgan - **updater** : pierov ===================================== .gitlab/merge_request_templates/Rebase.md deleted ===================================== @@ -1,23 +0,0 @@ -## Merge Info - - - -### Rebase Issue -- tor-browser#xxxxx -- mullvad-browser#xxxxx - -### Release Prep Issue -- tor-browser-build#xxxxx - -### Issue Tracking -- [ ] Link rebase issue with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort… for changelog generation - -### Review - -#### Request Reviewer - -- [ ] Request review from a release engineer: boklm, dan, ma1, morgan, pierov - -#### Change Description - - View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/dd6ad9… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/dd6ad9… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][maint-14.5] Bug 41435: Skip update-responses update entries for versions without incremental or full update mar
by morgan (＠morgan) 16 Apr '25

16 Apr '25

morgan pushed to branch maint-14.5 at The Tor Project / Applications / tor-browser-build Commits: 632a5bee by Nicolas Vigier at 2025-04-16T15:22:27+00:00 Bug 41435: Skip update-responses update entries for versions without incremental or full update mar - - - - - 1 changed file: - tools/update-responses/update_responses Changes: ===================================== tools/update-responses/update_responses ===================================== @@ -351,6 +351,11 @@ sub get_response { ); goto CLOSETAGS; } + if (!$config->{versions}{$version}{files}{$os}{complete} && + (!$from_version || + !$config->{versions}{$version}{files}{$os}{partial}{$from_version})) { + next; + } my $minversion = get_config($config, $version, $os, 'minSupportedOSVersion'); my $mininstruc = get_config($config, $version, $os, 'minSupportedInstructionSet'); $writer->startTag('update', View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/6… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/6… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 41435: Skip update-responses update entries for versions without incremental or full update mar
by morgan (＠morgan) 16 Apr '25

16 Apr '25

morgan pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: e6c3db8a by Nicolas Vigier at 2025-04-16T14:53:20+00:00 Bug 41435: Skip update-responses update entries for versions without incremental or full update mar - - - - - 1 changed file: - tools/update-responses/update_responses Changes: ===================================== tools/update-responses/update_responses ===================================== @@ -351,6 +351,11 @@ sub get_response { ); goto CLOSETAGS; } + if (!$config->{versions}{$version}{files}{$os}{complete} && + (!$from_version || + !$config->{versions}{$version}{files}{$os}{partial}{$from_version})) { + next; + } my $minversion = get_config($config, $version, $os, 'minSupportedOSVersion'); my $mininstruc = get_config($config, $version, $os, 'minSupportedInstructionSet'); $writer->startTag('update', View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/e… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/e… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag tor-browser-133.0a1-15.0-1-build2
by ma1 (＠ma1) 16 Apr '25

16 Apr '25

ma1 pushed new tag tor-browser-133.0a1-15.0-1-build2 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 41432: Bump OpenSSL to 3.5.0.
by morgan (＠morgan) 16 Apr '25

16 Apr '25

morgan pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 94cb15b2 by Pier Angelo Vendrame at 2025-04-16T14:11:38+00:00 Bug 41432: Bump OpenSSL to 3.5.0. Also, update relprep.py to take releases from that series. - - - - - 2 changed files: - projects/openssl/config - tools/relprep.py Changes: ===================================== projects/openssl/config ===================================== @@ -1,12 +1,9 @@ # vim: filetype=yaml sw=2 -version: 3.0.16 +version: 3.5.0 filename: '[% project %]-[% c("version") %]-[% c("var/osname") %]-[% c("var/build_id") %].tar.[% c("compress_tar") %]' container: use_container: 1 -var: - openssldir: 'usr/local' - targets: linux-x86_64: var: @@ -36,5 +33,5 @@ input_files: - name: '[% c("var/compiler") %]' project: '[% c("var/compiler") %]' - URL: 'https://github.com/openssl/openssl/releases/download/openssl-[% c("version") %]/openssl-[% c("version") %].tar.gz' - sha256sum: 57e03c50feab5d31b152af2b764f10379aecd8ee92f16c985983ce4a99f7ef86 + sha256sum: 344d0a79f1a9b08029b0744e2cc401a43f9c90acd1044d09a530b4885a8e9fc0 name: openssl ===================================== tools/relprep.py ===================================== @@ -380,7 +380,7 @@ class ReleasePreparation: def update_openssl(self): logger.info("Updating OpenSSL") config = self.load_config("openssl") - version = get_github_release("openssl/openssl", r"openssl-(3.0.\d+)") + version = get_github_release("openssl/openssl", r"openssl-(3.5.\d+)") if version == config["version"]: logger.debug("No need to update OpenSSL, keeping %s.", version) return View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/9… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/9… You're receiving this email because of your account on gitlab.torproject.org.

1 0