- tor-commits - lists.torproject.org

[translation-tools] branch master updated: add https://gitlab.torproject.org/tpo/web/social-bank
by gitolite role 28 Jun '22

28 Jun '22

This is an automated email from the git hooks/post-receive script. emmapeel pushed a commit to branch master in repository translation-tools. The following commit(s) were added to refs/heads/master by this push: new 0e629c8 add https://gitlab.torproject.org/tpo/web/social-bank 0e629c8 is described below commit 0e629c8e43dcf57d869ef4f91465a546f1a5f944 Author: emma peel <emma.peel(a)riseup.net> AuthorDate: Tue Jun 28 12:19:47 2022 +0000 add https://gitlab.torproject.org/tpo/web/social-bank --- config | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/config b/config index 7249f0f..daaf022 100644 --- a/config +++ b/config @@ -24,6 +24,8 @@ orfox-stringsxml orfox-stringsxml_completed policies-code_of_conducttxtpot policies-code_of_conducttxtpot_completed rdsys rdsys_completed snowflakeaddon-messages.json snowflakeaddon-messages.json_completed +social-bank social-bank_completed +support-portal support-portal_completed tails-misc tails-misc_completed tails-misc_release tails-openpgp-applet tails-openpgp-applet_completed tails-openpgp-applet_release tails-onioncircuits tails-onioncircuits_completed tails-onioncircuits_release @@ -41,8 +43,7 @@ torcheck torcheck_completed tor-launcher-properties tor-launcher-properties_completed tor-launcher-network-settings tor-launcher-network-settings_completed tor_outreach_md tor_outreach_md_completed -tpo-web tpo-web_completed -support-portal support-portal_completed" +tpo-web tpo-web_completed" PIDFILE=/srv/translation.torproject.org/run/update_translations.pid -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[nyx] branch master updated: Replace inspect.getargspec usage to support python 3.11
by gitolite role 27 Jun '22

27 Jun '22

This is an automated email from the git hooks/post-receive script. atagar pushed a commit to branch master in repository nyx. The following commit(s) were added to refs/heads/master by this push: new dcaddf2 Replace inspect.getargspec usage to support python 3.11 dcaddf2 is described below commit dcaddf2ab7f9d2ef8649f98bb6870995ebe0b893 Author: Juan Orti Alcaine <jortialc(a)redhat.com> AuthorDate: Mon Jun 27 19:38:34 2022 +0200 Replace inspect.getargspec usage to support python 3.11 --- nyx/panel/__init__.py | 2 +- test/__init__.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/nyx/panel/__init__.py b/nyx/panel/__init__.py index 57ae1e3..99b36d3 100644 --- a/nyx/panel/__init__.py +++ b/nyx/panel/__init__.py @@ -78,7 +78,7 @@ class KeyHandler(collections.namedtuple('Help', ['key', 'description', 'current' is_match = self._key_func(key) if self._key_func else key.match(self.key) if is_match: - if inspect.getargspec(self._action).args == ['key']: + if inspect.getfullargspec(self._action).args == ['key']: self._action(key) else: self._action() diff --git a/test/__init__.py b/test/__init__.py index b259f7b..d9f0875 100644 --- a/test/__init__.py +++ b/test/__init__.py @@ -94,7 +94,7 @@ def render(func, *args, **kwargs): nyx.curses.CURSES_SCREEN.erase() start_time = time.time() - func_args = inspect.getargspec(func).args + func_args = inspect.getfullargspec(func).args if func_args[:1] == ['subwindow'] or func_args[:2] == ['self', 'subwindow']: def _draw(subwindow): -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[nyx] branch master updated: compensate for torrc logfile entry when tab-delimited
by gitolite role 27 Jun '22

27 Jun '22

This is an automated email from the git hooks/post-receive script. atagar pushed a commit to branch master in repository nyx. The following commit(s) were added to refs/heads/master by this push: new 038bd7b compensate for torrc logfile entry when tab-delimited 038bd7b is described below commit 038bd7bdb45b94b21de14cfddb152e73688cc7b7 Author: h3xagonal <genecoleman(a)protonmail.com> AuthorDate: Wed Jun 15 00:00:00 2022 +0000 compensate for torrc logfile entry when tab-delimited --- nyx/log.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nyx/log.py b/nyx/log.py index 80c5faf..806b70d 100644 --- a/nyx/log.py +++ b/nyx/log.py @@ -83,7 +83,7 @@ def log_file_path(controller): """ for log_entry in controller.get_conf('Log', [], True): - entry_comp = log_entry.split() # looking for an entry like: notice file /var/log/tor/notices.log + entry_comp = log_entry.encode('ascii').decode('unicode_escape').split() # compensating for tab delimitation, looking for an entry like: notice file /var/log/tor/notices.log if entry_comp[1] == 'file': return nyx.expand_path(entry_comp[2]) -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[pluggable-transports/snowflake-webext] tag webext-0.6.0 created (now 169c3ea)
by gitolite role 27 Jun '22

27 Jun '22

This is an automated email from the git hooks/post-receive script. shelikhoo pushed a change to tag webext-0.6.0 in repository pluggable-transports/snowflake-webext. at 169c3ea (commit) No new revisions were added by this update. -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[pluggable-transports/snowflake-webext] branch main updated: bump version to 0.6.0
by gitolite role 27 Jun '22

27 Jun '22

This is an automated email from the git hooks/post-receive script. shelikhoo pushed a commit to branch main in repository pluggable-transports/snowflake-webext. The following commit(s) were added to refs/heads/main by this push: new 169c3ea bump version to 0.6.0 169c3ea is described below commit 169c3ea3bee41ad71c71be93c5d5932752924407 Author: Shelikhoo <xiaokangwang(a)outlook.com> AuthorDate: Fri Jun 24 13:47:09 2022 +0100 bump version to 0.6.0 --- package.json | 4 ++-- webext/manifest.json | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/package.json b/package.json index 981f5c5..d03fb57 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "snowflake-pt", - "version": "0.5.5", + "version": "0.6.0", "description": "Snowflake is a WebRTC pluggable transport for Tor.", "main": "build/snowflake.js", "directories": { @@ -33,4 +33,4 @@ "ws": "^5.2.3", "xmlhttprequest": "^1.8.0" } -} \ No newline at end of file +} diff --git a/webext/manifest.json b/webext/manifest.json index d6815b3..4783b4f 100644 --- a/webext/manifest.json +++ b/webext/manifest.json @@ -1,7 +1,7 @@ { "manifest_version": 2, "name": "Snowflake", - "version": "0.5.5", + "version": "0.6.0", "description": "__MSG_appDesc__", "default_locale": "en_US", "icons": { @@ -25,4 +25,4 @@ "permissions": [ "storage" ] -} \ No newline at end of file +} -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[tor-launcher] branch master updated: Tor Brower Bug 41039: set startHidden on tor process
by gitolite role 27 Jun '22

27 Jun '22

This is an automated email from the git hooks/post-receive script. pierov pushed a commit to branch master in repository tor-launcher. The following commit(s) were added to refs/heads/master by this push: new a9b3ea5 Tor Brower Bug 41039: set startHidden on tor process a9b3ea5 is described below commit a9b3ea54e298e891614907274069c2e400744c33 Author: Marco Simonelli <msimonelli(a)protonmail.com> AuthorDate: Mon Jun 27 08:48:28 2022 +0000 Tor Brower Bug 41039: set startHidden on tor process --- src/components/tl-process.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/components/tl-process.js b/src/components/tl-process.js index d57092e..1c830d9 100644 --- a/src/components/tl-process.js +++ b/src/components/tl-process.js @@ -531,6 +531,7 @@ TorProcessService.prototype = this.mTorProcessStatus = this.kStatusStarting; var p = Cc["@mozilla.org/process/util;1"].createInstance(Ci.nsIProcess); + p.startHidden = true; p.init(exeFile); TorLauncherLogger.log(2, "Starting " + exeFile.path); -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[tor-browser] branch tor-browser-91.10.0esr-11.5-1 updated: fixup! Bug 40458: Implement .tor.onion aliases
by gitolite role 24 Jun '22

24 Jun '22

This is an automated email from the git hooks/post-receive script. pierov pushed a commit to branch tor-browser-91.10.0esr-11.5-1 in repository tor-browser. The following commit(s) were added to refs/heads/tor-browser-91.10.0esr-11.5-1 by this push: new 9a5d862212abb fixup! Bug 40458: Implement .tor.onion aliases 9a5d862212abb is described below commit 9a5d862212abbade74b97e4e3dbe87e09ed9ac67 Author: Pier Angelo Vendrame <pierov(a)torproject.org> AuthorDate: Thu Jun 23 17:10:07 2022 +0200 fixup! Bug 40458: Implement .tor.onion aliases Bug 41036: Add a preference to disable Onion Aliases --- .../components/onionservices/OnionAliasStore.jsm | 92 ++++++++++++++++------ modules/libpref/init/StaticPrefList.yaml | 5 ++ netwerk/dns/OnionAliasService.cpp | 5 +- 3 files changed, 79 insertions(+), 23 deletions(-) diff --git a/browser/components/onionservices/OnionAliasStore.jsm b/browser/components/onionservices/OnionAliasStore.jsm index 059bca8f5a2bf..d5849e4b94289 100644 --- a/browser/components/onionservices/OnionAliasStore.jsm +++ b/browser/components/onionservices/OnionAliasStore.jsm @@ -40,6 +40,8 @@ const SECURE_DROP = { currentTimestamp: 0, }; +const kPrefOnionAliasEnabled = "browser.urlbar.onionRewrites.enabled"; + // Logger adapted from CustomizableUI.jsm const kPrefOnionAliasDebug = "browser.onionalias.debug"; XPCOMUtils.defineLazyPreferenceGetter( @@ -299,29 +301,19 @@ class _OnionAliasStore { async init() { await this._loadSettings(); - const dt = Date.now() - this._lastCheck; - let force = false; - for (const ch of this._channels.values()) { - if (ch.enabled && !ch.currentTimestamp) { - // Edited while being offline or some other error happened - force = true; - break; - } - } - if (dt > _OnionAliasStore.RULESET_CHECK_INTERVAL || force) { - log.debug( - `Mappings are stale (${dt}), or force check requested (${force}), checking them immediately` - ); - await this._periodicRulesetCheck(); - } else { - this._scheduleCheck(_OnionAliasStore.RULESET_CHECK_INTERVAL - dt); + if (this.enabled) { + await this._startUpdates(); } + Services.prefs.addObserver(kPrefOnionAliasEnabled, this); } uninit() { this._clear(); - clearTimeout(this._rulesetTimeout); + if (this._rulesetTimeout) { + clearTimeout(this._rulesetTimeout); + } this._rulesetTimeout = null; + Services.prefs.removeObserver(kPrefOnionAliasEnabled, this); } async getChannels() { @@ -362,13 +354,16 @@ class _OnionAliasStore { this._applyMappings(); this._saveSettings(); this._notifyChanges(); - if (enabled && !channel.currentTimestamp) { + if (this.enabled && enabled && !channel.currentTimestamp) { this.updateChannel(name); } } } async updateChannel(name) { + if (!this.enabled) { + throw Error("Onion Aliases are disabled"); + } const channel = this._channels.get(name); if (channel === null) { throw Error("Channel not found"); @@ -469,6 +464,10 @@ class _OnionAliasStore { } async _periodicRulesetCheck() { + if (!this.enabled) { + log.debug("Onion Aliases are disabled, not updating rulesets."); + return; + } log.debug("Begin scheduled ruleset update"); this._lastCheck = Date.now(); let anyUpdated = false; @@ -495,12 +494,46 @@ class _OnionAliasStore { this._scheduleCheck(_OnionAliasStore.RULESET_CHECK_INTERVAL); } + async _startUpdates() { + // This is a "private" function, so we expect the callers to verify wheter + // onion aliases are enabled. + // Callees will also do, so we avoid an additional check here. + const dt = Date.now() - this._lastCheck; + let force = false; + for (const ch of this._channels.values()) { + if (ch.enabled && !ch.currentTimestamp) { + // Edited while being offline or some other error happened + force = true; + break; + } + } + if (dt > _OnionAliasStore.RULESET_CHECK_INTERVAL || force) { + log.debug( + `Mappings are stale (${dt}), or force check requested (${force}), checking them immediately` + ); + await this._periodicRulesetCheck(); + } else { + this._scheduleCheck(_OnionAliasStore.RULESET_CHECK_INTERVAL - dt); + } + } + _scheduleCheck(dt) { + if (this._rulesetTimeout) { + log.warn("The previous update timeout was not null"); + clearTimeout(this._rulesetTimeout); + } + if (!this.enabled) { + log.warn( + "Ignoring the scheduling of a new check because the Onion Alias feature is currently disabled." + ); + this._rulesetTimeout = null; + return; + } log.debug(`Scheduling ruleset update in ${dt}`); - this._rulesetTimeout = setTimeout( - this._periodicRulesetCheck.bind(this), - dt - ); + this._rulesetTimeout = setTimeout(() => { + this._rulesetTimeout = null; + this._periodicRulesetCheck(); + }, dt); } _notifyChanges() { @@ -509,6 +542,21 @@ class _OnionAliasStore { OnionAliasStoreTopics.ChannelsChanged ); } + + get enabled() { + return Services.prefs.getBoolPref(kPrefOnionAliasEnabled, true); + } + + observe(aSubject, aTopic, aData) { + if (aTopic === "nsPref:changed") { + if (this.enabled) { + this._startUpdates(); + } else if (this._rulesetTimeout) { + clearTimeout(this._rulesetTimeout); + this._rulesetTimeout = null; + } + } + } } const OnionAliasStore = new _OnionAliasStore(); diff --git a/modules/libpref/init/StaticPrefList.yaml b/modules/libpref/init/StaticPrefList.yaml index b3e93c5443969..243585deecbf7 100644 --- a/modules/libpref/init/StaticPrefList.yaml +++ b/modules/libpref/init/StaticPrefList.yaml @@ -1338,6 +1338,11 @@ value: true mirror: always +- name: browser.urlbar.onionRewrites.enabled + type: RelaxedAtomicBool + value: true + mirror: always + - name: browser.viewport.desktopWidth type: RelaxedAtomicInt32 value: 980 diff --git a/netwerk/dns/OnionAliasService.cpp b/netwerk/dns/OnionAliasService.cpp index 5140f4fe0d833..a23bf93cee8b0 100644 --- a/netwerk/dns/OnionAliasService.cpp +++ b/netwerk/dns/OnionAliasService.cpp @@ -1,5 +1,7 @@ #include "torproject/OnionAliasService.h" +#include "mozilla/StaticPrefs_browser.h" + #include "nsUnicharUtils.h" /** @@ -74,7 +76,8 @@ NS_IMETHODIMP OnionAliasService::GetOnionAlias(const nsACString& aShortHostname, nsACString& aLongHostname) { aLongHostname = aShortHostname; - if (StringEndsWith(aShortHostname, ".tor.onion"_ns)) { + if (mozilla::StaticPrefs::browser_urlbar_onionRewrites_enabled() && + StringEndsWith(aShortHostname, ".tor.onion"_ns)) { nsAutoCString* alias = nullptr; // We want to keep the string stored in the map alive at least until we // finish to copy it to the output parameter. -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[tor-browser] branch tor-browser-91.10.0esr-11.5-1 updated: fixup! Bug 26961: New user onboarding.
by gitolite role 24 Jun '22

24 Jun '22

This is an automated email from the git hooks/post-receive script. pierov pushed a commit to branch tor-browser-91.10.0esr-11.5-1 in repository tor-browser. The following commit(s) were added to refs/heads/tor-browser-91.10.0esr-11.5-1 by this push: new 5a33be339ce01 fixup! Bug 26961: New user onboarding. 5a33be339ce01 is described below commit 5a33be339ce01ba0537de20ac48ee2ee1e317321 Author: Pier Angelo Vendrame <pierov(a)torproject.org> AuthorDate: Thu Jun 23 14:59:44 2022 +0200 fixup! Bug 26961: New user onboarding. Bug 41037: Fixed the connection preferences on the onboarding --- browser/extensions/onboarding/content/onboarding-tour-agent.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/browser/extensions/onboarding/content/onboarding-tour-agent.js b/browser/extensions/onboarding/content/onboarding-tour-agent.js index 7cdb10063f282..c12419e205ae6 100644 --- a/browser/extensions/onboarding/content/onboarding-tour-agent.js +++ b/browser/extensions/onboarding/content/onboarding-tour-agent.js @@ -25,7 +25,7 @@ let onClick = evt => { Mozilla.UITour.showHighlight("torBrowser-newIdentityButton", "zoom"); break; case "onboarding-tour-tor-network-action-button": - Mozilla.UITour.openPreferences("tor"); + Mozilla.UITour.openPreferences("connection"); break; #if 0 // Firefox onboarding actions. To reduce conflicts when rebasing against -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[tor-launcher] branch master updated: fixup! Bug 40774: Added new localized strings for about:preferences#connection
by gitolite role 23 Jun '22

23 Jun '22

This is an automated email from the git hooks/post-receive script. richard pushed a commit to branch master in repository tor-launcher. The following commit(s) were added to refs/heads/master by this push: new b0294bf fixup! Bug 40774: Added new localized strings for about:preferences#connection b0294bf is described below commit b0294bf3b4b7e09b7c2c94bb82c037af8e2e7f57 Author: emmapeel <emma.peel(a)riseup.net> AuthorDate: Thu Jun 9 17:23:32 2022 +0000 fixup! Bug 40774: Added new localized strings for about:preferences#connection easier to understand. suggestion by translator AO, thanks! --- src/chrome/locale/en-US/network-settings.dtd | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/chrome/locale/en-US/network-settings.dtd b/src/chrome/locale/en-US/network-settings.dtd index cd86d0c..74f2d3b 100644 --- a/src/chrome/locale/en-US/network-settings.dtd +++ b/src/chrome/locale/en-US/network-settings.dtd @@ -89,7 +89,7 @@ <!ENTITY torPreferences.bridgeLocationOther "Other locations"> <!ENTITY torPreferences.bridgeChooseForMe "Choose a Bridge For Me…"> <!ENTITY torPreferences.bridgeBadgeCurrent "Your Current Bridges"> -<!ENTITY torPreferences.bridgeBadgeCurrentDescription "You can keep one or more bridges saved, and Tor will choose which one to use when you connect. Tor will automatically switch to use another bridge when needed."> +<!ENTITY torPreferences.bridgeBadgeCurrentDescription "You can save one or more bridges, and Tor will choose which one to use when you connect. Tor will automatically switch to use another bridge when needed."> <!ENTITY torPreferences.bridgeId "#1 bridge: #2">  <!ENTITY torPreferences.remove "Remove"> <!ENTITY torPreferences.bridgeDisableBuiltIn "Disable built-in bridges"> -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[tor] branch main updated: Revert "cmux: Don't pick a marked for close circuit as active"
by gitolite role 23 Jun '22

23 Jun '22

This is an automated email from the git hooks/post-receive script. dgoulet pushed a commit to branch main in repository tor. The following commit(s) were added to refs/heads/main by this push: new 331204e100 Revert "cmux: Don't pick a marked for close circuit as active" 331204e100 is described below commit 331204e1005b6e14cb28388a852c489c0638e539 Author: David Goulet <dgoulet(a)torproject.org> AuthorDate: Thu Jun 23 10:55:56 2022 -0400 Revert "cmux: Don't pick a marked for close circuit as active" This reverts commit 4f1298e4189f8bda8ecf48cf7ff25445698d747a. --- changes/ticket25312 | 3 --- src/core/or/circuitmux_ewma.c | 12 ++---------- 2 files changed, 2 insertions(+), 13 deletions(-) diff --git a/changes/ticket25312 b/changes/ticket25312 deleted file mode 100644 index 5de1a48260..0000000000 --- a/changes/ticket25312 +++ /dev/null @@ -1,3 +0,0 @@ - o Minor bugfixes (circuit): - - Fix a tiny window where a circuit can be chosen as active but is marked - for close. Fixes bug 25312; bugfix on 0.2.4.4-alpha. diff --git a/src/core/or/circuitmux_ewma.c b/src/core/or/circuitmux_ewma.c index 18c726c9ba..adf256ab05 100644 --- a/src/core/or/circuitmux_ewma.c +++ b/src/core/or/circuitmux_ewma.c @@ -35,7 +35,6 @@ #include <math.h> #include "core/or/or.h" -#include "core/or/circuit_st.h" #include "core/or/circuitmux.h" #include "core/or/circuitmux_ewma.h" #include "lib/crypt_ops/crypto_rand.h" @@ -383,17 +382,10 @@ ewma_pick_active_circuit(circuitmux_t *cmux, pol = TO_EWMA_POL_DATA(pol_data); - for (int i = 0; i < smartlist_len(pol->active_circuit_pqueue); i++) { + if (smartlist_len(pol->active_circuit_pqueue) > 0) { /* Get the head of the queue */ - cell_ewma = smartlist_get(pol->active_circuit_pqueue, i); + cell_ewma = smartlist_get(pol->active_circuit_pqueue, 0); circ = cell_ewma_to_circuit(cell_ewma); - /* Don't send back closed circuit. This is possible because the circuit - * is detached from the cmux before the circuit gets freed and not when - * marked for close. Because of that, there is a window where a closed - * circuit can be picked here. See #25312. */ - if (circ->marked_for_close) { - continue; - } } return circ; -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0