- tor-commits - lists.torproject.org

[Git][tpo/applications/tor-browser-build][main] Bug 41459: Update taskcluster/ci paths in README.md files and comments
by boklm (＠boklm) 13 May '25

13 May '25

boklm pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: fdf8d4c5 by Nicolas Vigier at 2025-05-13T15:19:59+02:00 Bug 41459: Update taskcluster/ci paths in README.md files and comments - - - - - 13 changed files: - projects/cbindgen/README.md - projects/cctools/README.md - projects/cctools/config - projects/clang/README.md - projects/hfsplus-tools/README.md - projects/hfsplus-tools/config - projects/libtapi/README.md - projects/libtapi/config - projects/llvm-project/README.md - projects/macosx-toolchain/README.md - projects/nasm/README.md - projects/node/README.md - projects/wasi-sysroot/README.md Changes: ===================================== projects/cbindgen/README.md ===================================== @@ -4,8 +4,8 @@ libraries which expose a public C API. It is needed to build Firefox and GeckoView, therefore we adhere to the version that is known to work with their version. It can be found in Firefox's source tree by cross-referencing -`taskcluster/ci/toolchain/cbindgen.yml` and -`taskcluster/ci/fetch/toolchains.yml`. +`taskcluster/kinds/toolchain/cbindgen.yml` and +`taskcluster/kinds/fetch/toolchains.yml`. # Vendored dependencies ===================================== projects/cctools/README.md ===================================== @@ -4,7 +4,7 @@ with Linux and other operating systems, therefore we build a [port](https://github.com/tpoechtrager/cctools-port). Firefox also builds this port, therefore we match the version you can find in -`taskcluster/ci/fetch/toolchains.yml` in Firefox's source tree. +`taskcluster/kinds/fetch/toolchains.yml` in Firefox's source tree. # Caveats ===================================== projects/cctools/config ===================================== @@ -2,7 +2,7 @@ filename: '[% project %]-[% c("version") %]-[% c("var/build_id") %].tar.[% c("compress_tar") %]' version: '[% c("abbrev") %]' # This can be found in -# taskcluster/ci/fetch/toolchains.yml +# taskcluster/kinds/fetch/toolchains.yml git_hash: 30518813875aed656aa7f18b6d485feee25f8f87 git_url: https://github.com/tpoechtrager/cctools-port container: ===================================== projects/clang/README.md ===================================== @@ -12,8 +12,8 @@ also add platform-specific libraries and tools. ## Version We use the same version of LLVM as Firefox. -You can cross-reference `taskcluster/ci/toolchain/clang.yml` and -`taskcluster/ci/fetch/toolchains.yml` to get the exact git tree. +You can cross-reference `taskcluster/kinds/toolchain/clang.yml` and +`taskcluster/kinds/fetch/toolchains.yml` to get the exact git tree. However, since we need to use the LLVM source in several projects and its repository is quite big, we fetch it in the `llvm-project` project. ===================================== projects/hfsplus-tools/README.md ===================================== @@ -15,7 +15,7 @@ This tool was written by Apple and released under an open source license, but like other macOS tools, the official source code is macOS-specific. So, we use a Linux port (that can be built only with Clang). We use the same version as Mozilla (it can be checked in -`taskcluster/ci/fetch/toolchains.yml` on Firefox's source tree). +`taskcluster/kinds/fetch/toolchains.yml` on Firefox's source tree). ## Reproducibility patches ===================================== projects/hfsplus-tools/config ===================================== @@ -9,7 +9,7 @@ var: - libssl-dev - uuid-dev input_files: - # See hfsplus-tools in taskcluster/ci/fetch/toolchains.yml + # See hfsplus-tools in taskcluster/kinds/fetch/toolchains.yml - URL: https://src.fedoraproject.org/repo/pkgs/hfsplus-tools/diskdev_cmds-540.1.li… c("version") %].tar.gz sha256: b01b203a97f9a3bf36a027c13ddfc59292730552e62722d690d33bd5c24f5497 - project: container-image ===================================== projects/libtapi/README.md ===================================== @@ -4,7 +4,7 @@ Apple uses to reduce the size of the macOS SDK. We need this library as a dependency of `cctools`. Just like `cctools`, we use the same version as Mozilla (which can be found in -Firefox's `taskcluster/ci/fetch/toolchains.yml`) and from the same Linux port +Firefox's `taskcluster/kinds/fetch/toolchains.yml`) and from the same Linux port they use. Our build script is based on Firefox's ===================================== projects/libtapi/config ===================================== @@ -2,7 +2,7 @@ filename: '[% project %]-[% c("version") %]-[% c("var/build_id") %].tar.[% c("compress_tar") %]' version: '[% c("abbrev") %]' # This can be found in -# taskcluster/ci/fetch/toolchains.yml +# taskcluster/kinds/fetch/toolchains.yml git_hash: b4f141a16c7c82f75973429c92242a8c7de3ddb1 git_url: https://github.com/tpoechtrager/apple-libtapi ===================================== projects/llvm-project/README.md ===================================== @@ -2,5 +2,5 @@ This project is a way to share the LLVM source code between all the projects that need it, without having multiple clones. We keep the same version as Firefox, which you can get by cross-referencing -`taskcluster/ci/toolchain/clang.yml` and `taskcluster/ci/fetch/toolchains.yml` +`taskcluster/kinds/toolchain/clang.yml` and `taskcluster/kinds/fetch/toolchains.yml` in Firefox's source code. ===================================== projects/macosx-toolchain/README.md ===================================== @@ -13,7 +13,7 @@ without notice (the URL is probably the result of reverse engineering). Anyway, we do not change the file we mirror in any way, so users can verify the hash corresponds to the one that was at a certain point versioned in Firefox's -source code (in `taskcluster/ci/toolchain/macos-sdk.yml`). +source code (in `taskcluster/kinds/toolchain/macos-sdk.yml`). # LLVM Runtimes ===================================== projects/nasm/README.md ===================================== @@ -2,5 +2,5 @@ The [Netwide Assembler](https://nasm.us/), required to build some multimedia code of Firefox. We use the same version as Mozilla, which can be found by cross-referencing -`taskcluster/ci/toolchain/nasm.yml` and `taskcluster/ci/fetch/toolchains.yml` in +`taskcluster/kinds/toolchain/nasm.yml` and `taskcluster/kinds/fetch/toolchains.yml` in Firefox's source code. ===================================== projects/node/README.md ===================================== @@ -2,5 +2,5 @@ The Node.js JavaScript runtime, needed to build Firefox (and GeckoView). We use one of the versions supported by Firefox. You can find which ones are by cross-referencing -`taskcluster/ci/fetch/toolchains.yml` and `taskcluster/ci/toolchain/node.yml` in +`taskcluster/kinds/fetch/toolchains.yml` and `taskcluster/kinds/toolchain/node.yml` in Firefox's source. ===================================== projects/wasi-sysroot/README.md ===================================== @@ -26,7 +26,7 @@ If you need to update the version of the WASI SDK, please be sure to update also the hashes of the submodules. We stick to the same version used by Firefox, that can be found in the usual -`taskcluster/ci/fetch/toolchains.yml`. +`taskcluster/kinds/fetch/toolchains.yml`. # Mozilla's build script View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/f… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/f… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-137.0a1-15.0-1] 2 commits: fixup! MB 1: Mullvad Browser branding
by Pier Angelo Vendrame (＠pierov) 13 May '25

13 May '25

Pier Angelo Vendrame pushed to branch mullvad-browser-137.0a1-15.0-1 at The Tor Project / Applications / Mullvad Browser Commits: e0fda933 by Pier Angelo Vendrame at 2025-05-12T18:33:56+02:00 fixup! MB 1: Mullvad Browser branding TB 43776: Mark branding files for l10n merge. - - - - - 9b4e501f by Pier Angelo Vendrame at 2025-05-12T19:05:51+02:00 fixup! MB 80: Enable Mullvad Browser as a default browser Comment a definition since mingw now defines it as well. - - - - - 2 changed files: - browser/locales/l10n.toml - other-licenses/nsis/Contrib/ApplicationID/Set.cpp Changes: ===================================== browser/locales/l10n.toml ===================================== @@ -131,6 +131,18 @@ locales = [ reference = "browser/branding/official/locales/en-US/**" l10n = "{l}browser/branding/official/**" +[[paths]] + reference = "browser/branding/mb-alpha/locales/en-US/**" + l10n = "{l}browser/branding/mb-alpha/**" + +[[paths]] + reference = "browser/branding/mb-nightly/locales/en-US/**" + l10n = "{l}browser/branding/mb-nightly/**" + +[[paths]] + reference = "browser/branding/mb-release/locales/en-US/**" + l10n = "{l}browser/branding/mb-release/**" + [[paths]] reference = "browser/extensions/formautofill/locales/en-US/**" l10n = "{l}browser/extensions/formautofill/**" ===================================== other-licenses/nsis/Contrib/ApplicationID/Set.cpp ===================================== @@ -35,7 +35,8 @@ unsigned int g_stringsize; TCHAR *g_variables; // Indicates that an application supports dual desktop and immersive modes. In Windows 8, this property is only applicable for web browsers. -DEFINE_PROPERTYKEY(PKEY_AppUserModel_IsDualMode, 0x9F4C2855, 0x9F79, 0x4B39, 0xA8, 0xD0, 0xE1, 0xD4, 0x2D, 0xE1, 0xD5, 0xF3, 11); +// mingw already defines this in propkey.h. +// DEFINE_PROPERTYKEY(PKEY_AppUserModel_IsDualMode, 0x9F4C2855, 0x9F79, 0x4B39, 0xA8, 0xD0, 0xE1, 0xD4, 0x2D, 0xE1, 0xD5, 0xF3, 11); int popstring(TCHAR *str, int len); void pushstring(const TCHAR *str, int len); View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/e0… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/e0… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.10.0esr-14.5-1] fixup! Tweaks to the build system
by brizental (＠brizental) 13 May '25

13 May '25

brizental pushed to branch mullvad-browser-128.10.0esr-14.5-1 at The Tor Project / Applications / Mullvad Browser Commits: ca575207 by Beatriz Rizental at 2025-05-13T15:25:29+02:00 fixup! Tweaks to the build system - - - - - 2 changed files: - python/mach/mach/telemetry.py - python/sites/mach.txt Changes: ===================================== python/mach/mach/telemetry.py ===================================== @@ -277,6 +277,7 @@ def prompt_telemetry_message_contributor(): def initialize_telemetry_setting(settings, topsrcdir: str, state_dir: str): """Enables telemetry for employees or prompts the user.""" + return # If the user doesn't care about telemetry for this invocation, then # don't make requests to Bugzilla and/or prompt for whether the # user wants to opt-in. ===================================== python/sites/mach.txt ===================================== @@ -96,7 +96,7 @@ vendored:third_party/python/wheel vendored:third_party/python/zipp # glean-sdk may not be installable if a wheel isn't available # and it has to be built from source. -pypi-optional:glean-sdk==60.1.1:telemetry will not be collected +# pypi-optional:glean-sdk==60.1.1:telemetry will not be collected # Mach gracefully handles the case where `psutil` is unavailable. # We aren't (yet) able to pin packages in automation, so we have to # support down to the oldest locally-installed version (5.4.2). View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/ca5… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/ca5… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-128.10.0esr-14.5-1] fixup! Tweaks to the build system
by brizental (＠brizental) 13 May '25

13 May '25

brizental pushed to branch base-browser-128.10.0esr-14.5-1 at The Tor Project / Applications / Tor Browser Commits: 11d2cb1a by Beatriz Rizental at 2025-05-13T15:21:36+02:00 fixup! Tweaks to the build system - - - - - 2 changed files: - python/mach/mach/telemetry.py - python/sites/mach.txt Changes: ===================================== python/mach/mach/telemetry.py ===================================== @@ -277,6 +277,7 @@ def prompt_telemetry_message_contributor(): def initialize_telemetry_setting(settings, topsrcdir: str, state_dir: str): """Enables telemetry for employees or prompts the user.""" + return # If the user doesn't care about telemetry for this invocation, then # don't make requests to Bugzilla and/or prompt for whether the # user wants to opt-in. ===================================== python/sites/mach.txt ===================================== @@ -96,7 +96,7 @@ vendored:third_party/python/wheel vendored:third_party/python/zipp # glean-sdk may not be installable if a wheel isn't available # and it has to be built from source. -pypi-optional:glean-sdk==60.1.1:telemetry will not be collected +# pypi-optional:glean-sdk==60.1.1:telemetry will not be collected # Mach gracefully handles the case where `psutil` is unavailable. # We aren't (yet) able to pin packages in automation, so we have to # support down to the oldest locally-installed version (5.4.2). View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/11d2cb1… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/11d2cb1… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.10.0esr-14.5-1] fixup! Tweaks to the build system
by brizental (＠brizental) 13 May '25

13 May '25

brizental pushed to branch tor-browser-128.10.0esr-14.5-1 at The Tor Project / Applications / Tor Browser Commits: e540f3db by Beatriz Rizental at 2025-05-13T15:13:27+02:00 fixup! Tweaks to the build system - - - - - 2 changed files: - python/mach/mach/telemetry.py - python/sites/mach.txt Changes: ===================================== python/mach/mach/telemetry.py ===================================== @@ -277,6 +277,7 @@ def prompt_telemetry_message_contributor(): def initialize_telemetry_setting(settings, topsrcdir: str, state_dir: str): """Enables telemetry for employees or prompts the user.""" + return # If the user doesn't care about telemetry for this invocation, then # don't make requests to Bugzilla and/or prompt for whether the # user wants to opt-in. ===================================== python/sites/mach.txt ===================================== @@ -96,7 +96,7 @@ vendored:third_party/python/wheel vendored:third_party/python/zipp # glean-sdk may not be installable if a wheel isn't available # and it has to be built from source. -pypi-optional:glean-sdk==60.1.1:telemetry will not be collected +# pypi-optional:glean-sdk==60.1.1:telemetry will not be collected # Mach gracefully handles the case where `psutil` is unavailable. # We aren't (yet) able to pin packages in automation, so we have to # support down to the oldest locally-installed version (5.4.2). View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/e540f3d… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/e540f3d… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-137.0a1-15.0-1] fixup! BB 42758: Fix WebRTC build errors.
by Pier Angelo Vendrame (＠pierov) 13 May '25

13 May '25

Pier Angelo Vendrame pushed to branch tor-browser-137.0a1-15.0-1 at The Tor Project / Applications / Tor Browser Commits: 0e1a9ffa by Pier Angelo Vendrame at 2025-05-13T11:46:59+02:00 fixup! BB 42758: Fix WebRTC build errors. MB 436: Link to pthread on mingw. - - - - - 2 changed files: - media/libaom/moz.build - third_party/abseil-cpp/absl/base/base_gn/moz.build Changes: ===================================== media/libaom/moz.build ===================================== @@ -143,3 +143,6 @@ LOCAL_INCLUDES += [ # TEST_DIRS += [ # 'test/fuzztest' # ] + +if CONFIG["OS_TARGET"] == "WINNT" and CONFIG["CC_TYPE"] == "clang": + OS_LIBS += ["pthread"] ===================================== third_party/abseil-cpp/absl/base/base_gn/moz.build ===================================== @@ -168,4 +168,7 @@ if CONFIG["OS_TARGET"] == "Linux" and CONFIG["TARGET_CPU"] == "x86_64": DEFINES["_GNU_SOURCE"] = True +if CONFIG["OS_TARGET"] == "WINNT" and CONFIG["CC_TYPE"] == "clang": + OS_LIBS += ["pthread"] + Library("base_gn") View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/0e1a9ff… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/0e1a9ff… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-137.0a1-15.0-1] fixup! BB 42758: Fix WebRTC build errors.
by Pier Angelo Vendrame (＠pierov) 13 May '25

13 May '25

Pier Angelo Vendrame pushed to branch mullvad-browser-137.0a1-15.0-1 at The Tor Project / Applications / Mullvad Browser Commits: e0761819 by Pier Angelo Vendrame at 2025-05-12T17:31:44+02:00 fixup! BB 42758: Fix WebRTC build errors. MB 436: Link to pthread on mingw. - - - - - 2 changed files: - media/libaom/moz.build - third_party/abseil-cpp/absl/base/base_gn/moz.build Changes: ===================================== media/libaom/moz.build ===================================== @@ -143,3 +143,6 @@ LOCAL_INCLUDES += [ # TEST_DIRS += [ # 'test/fuzztest' # ] + +if CONFIG["OS_TARGET"] == "WINNT" and CONFIG["CC_TYPE"] == "clang": + OS_LIBS += ["pthread"] ===================================== third_party/abseil-cpp/absl/base/base_gn/moz.build ===================================== @@ -168,4 +168,7 @@ if CONFIG["OS_TARGET"] == "Linux" and CONFIG["TARGET_CPU"] == "x86_64": DEFINES["_GNU_SOURCE"] = True +if CONFIG["OS_TARGET"] == "WINNT" and CONFIG["CC_TYPE"] == "clang": + OS_LIBS += ["pthread"] + Library("base_gn") View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/e07… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/e07… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-137.0a1-15.0-1] fixup! TB 2176: Rebrand Firefox to TorBrowser
by Pier Angelo Vendrame (＠pierov) 13 May '25

13 May '25

Pier Angelo Vendrame pushed to branch tor-browser-137.0a1-15.0-1 at The Tor Project / Applications / Tor Browser Commits: 51252f53 by Pier Angelo Vendrame at 2025-05-12T19:24:10+02:00 fixup! TB 2176: Rebrand Firefox to TorBrowser TB 43776: Mark branding files for l10n merge. - - - - - 1 changed file: - browser/locales/l10n.toml Changes: ===================================== browser/locales/l10n.toml ===================================== @@ -131,6 +131,18 @@ locales = [ reference = "browser/branding/official/locales/en-US/**" l10n = "{l}browser/branding/official/**" +[[paths]] + reference = "browser/branding/tb-alpha/locales/en-US/**" + l10n = "{l}browser/branding/tb-alpha/**" + +[[paths]] + reference = "browser/branding/tb-nightly/locales/en-US/**" + l10n = "{l}browser/branding/tb-nightly/**" + +[[paths]] + reference = "browser/branding/tb-release/locales/en-US/**" + l10n = "{l}browser/branding/tb-release/**" + [[paths]] reference = "browser/extensions/formautofill/locales/en-US/**" l10n = "{l}browser/extensions/formautofill/**" View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/51252f5… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/51252f5… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-137.0a1-15.0-1] fixup! Base Browser's .mozconfigs.
by Pier Angelo Vendrame (＠pierov) 12 May '25

12 May '25

Pier Angelo Vendrame pushed to branch mullvad-browser-137.0a1-15.0-1 at The Tor Project / Applications / Mullvad Browser Commits: 62f02a4c by Pier Angelo Vendrame at 2025-05-12T10:44:40+02:00 fixup! Base Browser's .mozconfigs. BB 43772: Do not use official branding for BB/TB/MB. We already pass --with-branding in our builds, no need to also pass this option. However, we should further audit what this option does, and try to recall why we added it at a certain point. - - - - - 2 changed files: - browser/config/mozconfigs/base-browser - browser/config/mozconfigs/base-browser-android Changes: ===================================== browser/config/mozconfigs/base-browser ===================================== @@ -8,7 +8,6 @@ fi mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/obj-@CONFIG_GUESS@ -ac_add_options --enable-official-branding export MOZILLA_OFFICIAL=1 ac_add_options --enable-optimize ===================================== browser/config/mozconfigs/base-browser-android ===================================== @@ -5,7 +5,6 @@ export MOZILLA_OFFICIAL=1 ac_add_options --enable-optimize ac_add_options --enable-rust-simd -ac_add_options --enable-official-branding ac_add_options --enable-application=mobile/android View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/62f… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/62f… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-137.0a1-15.0-1] fixup! Base Browser's .mozconfigs.
by Pier Angelo Vendrame (＠pierov) 12 May '25

12 May '25

Pier Angelo Vendrame pushed to branch tor-browser-137.0a1-15.0-1 at The Tor Project / Applications / Tor Browser Commits: 095674b6 by Pier Angelo Vendrame at 2025-05-12T10:26:45+02:00 fixup! Base Browser's .mozconfigs. BB 43772: Do not use official branding for BB/TB/MB. We already pass --with-branding in our builds, no need to also pass this option. However, we should further audit what this option does, and try to recall why we added it at a certain point. - - - - - 2 changed files: - browser/config/mozconfigs/base-browser - browser/config/mozconfigs/base-browser-android Changes: ===================================== browser/config/mozconfigs/base-browser ===================================== @@ -8,7 +8,6 @@ fi mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/obj-@CONFIG_GUESS@ -ac_add_options --enable-official-branding export MOZILLA_OFFICIAL=1 ac_add_options --enable-optimize ===================================== browser/config/mozconfigs/base-browser-android ===================================== @@ -5,7 +5,6 @@ export MOZILLA_OFFICIAL=1 ac_add_options --enable-optimize ac_add_options --enable-rust-simd -ac_add_options --enable-official-branding ac_add_options --enable-application=mobile/android View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/095674b… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/095674b… You're receiving this email because of your account on gitlab.torproject.org.

1 0