- tor-commits - lists.torproject.org

[tor] branch maint-0.4.7 updated (d456885dac -> 35e221688b)
by gitolite role 10 Jan '23

10 Jan '23

This is an automated email from the git hooks/post-receive script. dgoulet pushed a change to branch maint-0.4.7 in repository tor. from d456885dac shellcheck: Fix new warnings new 726e9ec0a3 sandbox: Allow my-consensus-* files for an authority new 35e221688b Merge branch 'tor-gitlab/mr/675' into maint-0.4.7 The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: changes/ticket40729 | 3 +++ src/app/main/main.c | 9 +++++++-- 2 files changed, 10 insertions(+), 2 deletions(-) create mode 100644 changes/ticket40729 -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[tor] branch main updated (7e055c383c -> ce7476cb59)
by gitolite role 10 Jan '23

10 Jan '23

This is an automated email from the git hooks/post-receive script. dgoulet pushed a change to branch main in repository tor. from 7e055c383c Merge branch 'maint-0.4.7' new 726e9ec0a3 sandbox: Allow my-consensus-* files for an authority new 35e221688b Merge branch 'tor-gitlab/mr/675' into maint-0.4.7 new ce7476cb59 Merge branch 'maint-0.4.7' The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: changes/ticket40729 | 3 +++ src/app/main/main.c | 9 +++++++-- 2 files changed, 10 insertions(+), 2 deletions(-) create mode 100644 changes/ticket40729 -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 3

[tor] branch release-0.4.7 updated (2b4651174e -> 695066856c)
by gitolite role 10 Jan '23

10 Jan '23

This is an automated email from the git hooks/post-receive script. dgoulet pushed a change to branch release-0.4.7 in repository tor. from 2b4651174e Merge branch 'maint-0.4.7' into release-0.4.7 new d456885dac shellcheck: Fix new warnings new 695066856c Merge branch 'maint-0.4.7' into release-0.4.7 The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: scripts/ci/ci-driver.sh | 2 +- scripts/maint/code-format.sh | 6 ++++++ src/test/test_include.sh | 3 +++ src/test/test_rebind.sh | 3 +++ 4 files changed, 13 insertions(+), 1 deletion(-) -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 1

[tor] branch maint-0.4.7 updated (1d9166c8c9 -> d456885dac)
by gitolite role 10 Jan '23

10 Jan '23

This is an automated email from the git hooks/post-receive script. dgoulet pushed a change to branch maint-0.4.7 in repository tor. from 1d9166c8c9 Enable IP_BIND_ADDRESS_NO_PORT if supported new d456885dac shellcheck: Fix new warnings The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: scripts/ci/ci-driver.sh | 2 +- scripts/maint/code-format.sh | 6 ++++++ src/test/test_include.sh | 3 +++ src/test/test_rebind.sh | 3 +++ 4 files changed, 13 insertions(+), 1 deletion(-) -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[tor] branch main updated: shellcheck: Fix new warnings
by gitolite role 10 Jan '23

10 Jan '23

This is an automated email from the git hooks/post-receive script. dgoulet pushed a commit to branch main in repository tor. The following commit(s) were added to refs/heads/main by this push: new d456885dac shellcheck: Fix new warnings new 7e055c383c Merge branch 'maint-0.4.7' d456885dac is described below commit d456885dac3b5bdfff663ed502fd11f9e0d0e070 Author: David Goulet <dgoulet(a)torproject.org> AuthorDate: Tue Jan 10 09:11:52 2023 -0500 shellcheck: Fix new warnings Nothing important, mostly false positive except one case. Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- scripts/ci/ci-driver.sh | 2 +- scripts/maint/code-format.sh | 6 ++++++ src/test/test_include.sh | 3 +++ src/test/test_rebind.sh | 3 +++ 4 files changed, 13 insertions(+), 1 deletion(-) diff --git a/scripts/ci/ci-driver.sh b/scripts/ci/ci-driver.sh index ef31da1ca3..93d764f262 100755 --- a/scripts/ci/ci-driver.sh +++ b/scripts/ci/ci-driver.sh @@ -375,7 +375,6 @@ if [[ "$RUN_STAGE_BUILD" = "yes" ]] ; then hooray "Distcheck was successful. Nothing further will be done." # We have to exit early here, since we can't do any other tests. cp tor-*.tar.gz "${CI_SRCDIR}"/artifacts - exit 0 else error "Diagnostics:" runcmd make show-distdir-testlog || true @@ -383,6 +382,7 @@ if [[ "$RUN_STAGE_BUILD" = "yes" ]] ; then die "Unable to continue." fi end_section Distcheck + exit 0 fi fi diff --git a/scripts/maint/code-format.sh b/scripts/maint/code-format.sh index d8f597d70d..5998e96f68 100755 --- a/scripts/maint/code-format.sh +++ b/scripts/maint/code-format.sh @@ -160,11 +160,17 @@ if [[ $GITIDX = 1 ]]; then # partially staged. note "Stashing unstaged changes" git stash -q --keep-index + # For some reasons, shellcheck is not seeing that we can call this + # function from the trap below. + # shellcheck disable=SC2317 function restoregit() { note "Restoring git state" git stash pop -q } else + # For some reasons, shellcheck is not seeing that we can call this + # function from the trap below. + # shellcheck disable=SC2317 function restoregit() { true } diff --git a/src/test/test_include.sh b/src/test/test_include.sh index 6cf695fe44..10d3bc502d 100755 --- a/src/test/test_include.sh +++ b/src/test/test_include.sh @@ -48,6 +48,9 @@ if "${TOR_BINARY}" --list-modules | grep -q "relay: no"; then fi tmpdir= +# For some reasons, shellcheck is not seeing that we can call this +# function from the trap below. +# shellcheck disable=SC2317 clean () { if [ -n "$tmpdir" ] && [ -d "$tmpdir" ]; then rm -rf "$tmpdir" diff --git a/src/test/test_rebind.sh b/src/test/test_rebind.sh index 879008c1c1..aae2a9a6a0 100755 --- a/src/test/test_rebind.sh +++ b/src/test/test_rebind.sh @@ -46,6 +46,9 @@ if "${TOR_BINARY}" --list-modules | grep -q "relay: no"; then fi tmpdir= +# For some reasons, shellcheck is not seeing that we can call this +# function from the trap below. +# shellcheck disable=SC2317 clean () { if [ -n "$tmpdir" ] && [ -d "$tmpdir" ]; then rm -rf "$tmpdir" -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[torspec] branch main updated: New proposal 342: Decoupling hs_interval and SRV lifetime
by gitolite role 10 Jan '23

10 Jan '23

This is an automated email from the git hooks/post-receive script. nickm pushed a commit to branch main in repository torspec. The following commit(s) were added to refs/heads/main by this push: new 578145b New proposal 342: Decoupling hs_interval and SRV lifetime 578145b is described below commit 578145bf1c64a65a652f58425bf3986a65a0ccb2 Author: Nick Mathewson <nickm(a)torproject.org> AuthorDate: Tue Jan 10 08:20:42 2023 -0500 New proposal 342: Decoupling hs_interval and SRV lifetime --- proposals/000-index.txt | 2 + proposals/342-decouple-hs-interval.md | 107 ++++++++++++++++++++++++++++++++++ proposals/BY_INDEX.md | 1 + proposals/README.md | 1 + 4 files changed, 111 insertions(+) diff --git a/proposals/000-index.txt b/proposals/000-index.txt index 0f82741..a838b94 100644 --- a/proposals/000-index.txt +++ b/proposals/000-index.txt @@ -262,6 +262,7 @@ Proposals by number: 339 UDP traffic over Tor [ACCEPTED] 340 Packed and fragmented relay messages [OPEN] 341 A better algorithm for out-of-sockets eviction [OPEN] +342 Decoupling hs_interval and SRV lifetime [DRAFT] Proposals by status: @@ -272,6 +273,7 @@ Proposals by status: 327 A First Take at PoW Over Introduction Circuits 329 Overcoming Tor's Bottlenecks with Traffic Splitting 331 Res tokens: Anonymous Credentials for Onion Service DoS Resilience + 342 Decoupling hs_interval and SRV lifetime NEEDS-REVISION: 212 Increase Acceptable Consensus Age [for 0.2.4.x+] 219 Support for full DNS and DNSSEC resolution in Tor [for 0.2.5.x] diff --git a/proposals/342-decouple-hs-interval.md b/proposals/342-decouple-hs-interval.md new file mode 100644 index 0000000..395c454 --- /dev/null +++ b/proposals/342-decouple-hs-interval.md @@ -0,0 +1,107 @@ +``` +Filename: 342-decouple-hs-interval.md +Title: Decoupling hs_interval and SRV lifetime +Author: Nick Mathewson +Created: 9 January 2023 +Status: Draft +``` + +# Motivation and introduction + +Tor uses shared random values (SRVs) in the consensus to determine +positions of relays within a hash ring. Which shared random value is to +be used for a given time period depends upon the time at which that +shared random value became valid. + +But right now, the consensus voting period is closely tied to the shared +random value voting cycle: and clients need to understand both of these +in order to determine when a shared random value became current. + +This creates tight coupling between: + * The voting schedule + * The SRV liveness schedule + * The hsdir_interval parameter that determines the length of the + an HSDIR index + +To decouple these values, this proposal describes a forward compatible +change to how Tor reports SRVs in consensuses, and how Tor decides which +hash ring to use when. + + +## Reporting SRV timestamps + +In consensus documents, parties should begin to accept +`shared-rand-*-value` lines with an additional argument, in the format +of an IsoTimeNospace timestamp (like "1985-10-26T00:00:00"). When +present, this timestamp indicates the time at which the given shared +random value first became the "current" SRV. + +Additionally, we define a new consensus method that adds these +timestamps to the consensus. + +We specify that, in the absence of such a timestamp, parties are to +assume that the `shared-rand-current-value` SRV became "current" at the +first 00:00 UTC on the UTC day of the consensus's valid-after timestamp, +and that the `shard-rand-previous-value` SRV became "current" at 00:00 +UTC on the previous UTC day. + + +## Generalizing HSDir index scheduling. + +Under the current HSDir design, there is one SRV for each time period, +and one time period for which each SRV is in use. Decoupling +`hsdir_interval` from 24 hours will require that we change this notion +slightly. + +We therefore propose this set of generalized directory behavior rules, +which should be equivalent to the current rules under current +parameters. + +The calculation of time periods remains the same (see `rend-spec-v3.txt` +section `[TIME PERIODS]`). + +A single SRV is associated with each time period: specifically, the SRV +that was "current" at the start of the time period. + +There is a separate hash ring associated with each time period and its +SRV. + +Whenever fetching an onion service descriptor, the client uses the hash +ring for the time period that contains the start of the liveness +interval of the current consensus. Call this the "Consensus" time period. + +Whenever uploading an onion service descriptor, the service uses _two or +three_ hash rings: + * The "consensus" time period (see above). + * The immediately preceding time period, if the SRV to calculate that + hash ring is available in the consensus. + * The immediately following time period, if the SRV to calculate that + hash ring is available in the consensus. + +(Under the current parameters, where `hsdir_interval = SRV_interval`, +there will never be more than two possible time periods for which the +service can qualify.) + +## Migration + +We declare that, for at least the lifetime of the C tor client, we will +not make any changes to the voting interval, the SRV interval, or the +`hsdir_interval`. As such, we do not need to prioritize implementing +these changes in the C client: we can make them in Arti only. + +## Issues left unsolved + +There are likely other lingering issues that would come up if we try to +change the voting interval. This proposal does not attempt to solve +them. + +This proposal does not attempt to add flexibility to the SRV voting +algorithm itself. + +Changing `hsdir_interval` would create a flag day where everybody using +old and new values of `hsdir_interval` would get different hash +rings. We do not try to solve that here. + +## Acknowledgments + +Thanks to David Goulet for explaining all of this stuff to me! diff --git a/proposals/BY_INDEX.md b/proposals/BY_INDEX.md index b64ae55..d0b1214 100644 --- a/proposals/BY_INDEX.md +++ b/proposals/BY_INDEX.md @@ -259,4 +259,5 @@ Below are a list of proposals sorted by their proposal number. See * [`339-udp-over-tor.md`](/proposals/339-udp-over-tor.md): UDP traffic over Tor [ACCEPTED] * [`340-packed-and-fragmented.md`](/proposals/340-packed-and-fragmented.md): Packed and fragmented relay messages [OPEN] * [`341-better-oos.md`](/proposals/341-better-oos.md): A better algorithm for out-of-sockets eviction [OPEN] +* [`342-decouple-hs-interval.md`](/proposals/342-decouple-hs-interval.md): Decoupling hs_interval and SRV lifetime [DRAFT] diff --git a/proposals/README.md b/proposals/README.md index 4127329..0461d6a 100644 --- a/proposals/README.md +++ b/proposals/README.md @@ -109,6 +109,7 @@ discussion. * [`327-pow-over-intro.txt`](/proposals/327-pow-over-intro.txt): A First Take at PoW Over Introduction Circuits * [`329-traffic-splitting.txt`](/proposals/329-traffic-splitting.txt): Overcoming Tor's Bottlenecks with Traffic Splitting * [`331-res-tokens-for-anti-dos.md`](/proposals/331-res-tokens-for-anti-dos.md): Res tokens: Anonymous Credentials for Onion Service DoS Resilience +* [`342-decouple-hs-interval.md`](/proposals/342-decouple-hs-interval.md): Decoupling hs_interval and SRV lifetime ## NEEDS-REVISION proposals: ideas that we can't implement as-is -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[pluggable-transports/snowflake] branch main updated (936a1f8 -> 7db2568)
by gitolite role 09 Jan '23

09 Jan '23

This is an automated email from the git hooks/post-receive script. cohosh pushed a change to branch main in repository pluggable-transports/snowflake. from 936a1f8 Add a num-turbotunnel server transport option. new f6fa51d Switch default proxy STUN server to stun.l.google.com new 8c77556 Remove two suggested STUN servers from client docs new 7db2568 Remove duplicate stun.sonetel.net entry The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: client/README.md | 2 +- client/torrc | 2 +- doc/snowflake-proxy.1 | 2 +- doc/using-the-snowflake-library.md | 4 ++-- proxy/README.md | 2 +- proxy/lib/snowflake.go | 4 ++-- 6 files changed, 8 insertions(+), 8 deletions(-) -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 3

[torspec] branch main updated: Clarify parameters related to hsv3 protocol.
by gitolite role 09 Jan '23

09 Jan '23

This is an automated email from the git hooks/post-receive script. dgoulet pushed a commit to branch main in repository torspec. The following commit(s) were added to refs/heads/main by this push: new 97f1ffb Clarify parameters related to hsv3 protocol. 97f1ffb is described below commit 97f1ffb6b07743125e3accb7d8df2851eadbc63d Author: Nick Mathewson <nickm(a)torproject.org> AuthorDate: Mon Jan 9 12:46:17 2023 -0500 Clarify parameters related to hsv3 protocol. In param-spec, not all of the parameters for onion services had their ranges and defaults listed; I've added those from the code. Also I clarified the units for hsdir_interval, which were not intuitively obvious. --- param-spec.txt | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/param-spec.txt b/param-spec.txt index 67c809d..a63ad3b 100644 --- a/param-spec.txt +++ b/param-spec.txt @@ -252,26 +252,34 @@ Table of Contents Minimum/maximum amount of INTRODUCE2 cells allowed per circuits before rotation (actual amount picked at random between these two values). + Min: 0. Max: INT32_MAX. Defaults: 16384, 32768. "hs_intro_min_lifetime", "hs_intro_max_lifetime" -- Minimum/maximum lifetime in seconds that a service should keep an intro point for (actual lifetime picked at random between these two values). + Min: 0. Max: INT32_MAX. Defaults: 18 hours, 24 hours. "hs_intro_num_extra" -- Number of extra intro points a service is allowed to open. This concept comes from proposal #155. + Min: 0. Max: 128. Default: 2. - "hsdir_interval" -- The length of a time period. See + "hsdir_interval" -- The length of a time period, _in minutes_. See rend-spec-v3.txt section [TIME-PERIODS]. + Min: 30. Max: 14400. Default: 1440. "hsdir_n_replicas" -- Number of HS descriptor replicas. + Min: 1. Max: 16. Default: 2. "hsdir_spread_fetch" -- Total number of HSDirs per replica a tor client should select to try to fetch a descriptor. + Min: 1. Max: 128. Default: 3. "hsdir_spread_store" -- Total number of HSDirs per replica a service will upload its descriptor to. + Min: 1. Max: 128. Default: 4 "HSV3MaxDescriptorSize" -- Maximum descriptor size (in bytes). + Min: 1. Max: INT32_MAX. Default: 50000 "hs_service_max_rdv_failures" -- This parameter determines the maximum number of rendezvous attempt an HS service can make per -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[company/policies] branch master updated: Add minutes for the 2022-11-21 meeting.
by gitolite role 26 Dec '22

26 Dec '22

This is an automated email from the git hooks/post-receive script. julius pushed a commit to branch master in repository company/policies. The following commit(s) were added to refs/heads/master by this push: new a9ae4d4 Add minutes for the 2022-11-21 meeting. a9ae4d4 is described below commit a9ae4d42910d2cd2ca5d9b7f9a7c33a4e22c8e0c Author: Julius Mittenzwei <julius.mittenzwei(a)openpublishing.com> AuthorDate: Mon Dec 26 14:09:48 2022 +0100 Add minutes for the 2022-11-21 meeting. --- minutes/TPI_Board_Meeting_Minutes-2022-11-21.txt | 71 ++++++++++++++++++++++ ...ing_Minutes-2022-11-21.txt.5FA53B246DEA01A5.asc | 16 +++++ 2 files changed, 87 insertions(+) diff --git a/minutes/TPI_Board_Meeting_Minutes-2022-11-21.txt b/minutes/TPI_Board_Meeting_Minutes-2022-11-21.txt new file mode 100644 index 0000000..7de5825 --- /dev/null +++ b/minutes/TPI_Board_Meeting_Minutes-2022-11-21.txt @@ -0,0 +1,71 @@ +Tor Board Meeting Minutes for November 21, 2022 + + + +Video and phone conference meeting called to order at 11:00 am eastern/ 16:00 UTC + + + + Present: Alissa Cooper, Kendra Albert, Julius Mittenzwei, Isabela Fernandes, Desigan Chinniah, Biella Coleman, Nighat Dad, Nick Mathewson, George Rosamond, Roger Dingledine, Sue Abt + + + + + + + +I. Discussion about potential new board members + + + + + +- Alissa on behalf of the search committee proposed Esra’a Al Shafei, Sarah Gran, and Christian Kaufmann as our new board members. +- Discussion of process for moving forward. +- Kendra: Will send an email for the approval of three members for a one year term, pending approval from Tor-Community members, with a start date of December 15, 2022. + + +Dees left meeting (16:20 UTC) + +II. Audits and Financial Reports + +- Sue: The management letter this year had no findings or recommendations, again, which is good as they flag problems in this letter. +- No Adjusting journal entries +- I would like to get an email that everyone has read the audit reports before sending it back. I want to make sure that no one has comments. +- We had a separate SIDA audit, which they do routinely for their funders. We also passed that very well. Sets us up for hopefully going to the next step with SIDA. +- We have also worked Global South Strategy for SIDA. + +III. Future Meetings—Coordination & Purpose + +- We will schedule 6 months in advance to help ease the burden of Doodle polls +- 4 per year, 2 hours +o Q1 strategy of the year +o Q2 Budget +o Q3 Check in +o Q4 is Go over audits + +IV. Other Business + +- Kendra: They have been working on redrafting the bylaws with the help of law clinic. They will share the draft document with the board members in the next week or two with next steps and questions. +- Kendra: We will use NextCloud folders for bylaws, financial materials, roles and responsibilities. This will also be helpful for onboarding new members. +- Kendra: We have finalized the admin position (Anabel Martinez) for help with Tor Board work. +- George: Overview about the process to release community member notes so they don’t get delayed. Encouraged Board to also reach out to the community + +V. Isabela Overview + + + +- DDoS attack has been ongoing for many years through improving. and has been impacting various services. +- The Onion Coalition has provided donations to help deal with these issues, and in specific to pay for 2 developers to work on onion services for 2 years. +- Open Collective: we hope they can be a sponsor for some grants. +- Update about Trademark issues and we might need to register TM in Europe +- State of Onion: Available to watch here and Isa flagged Quiet chat app w/ onion service presentation from the community day as worth watching. +(https://www.youtube.com/watch?v=uSyBZ7GIzJY). + + +Meeting ended at 17 UTC + + +-- + +[Meeting minutes have been approved via email by all board members on 2022-12-23.] diff --git a/minutes/TPI_Board_Meeting_Minutes-2022-11-21.txt.5FA53B246DEA01A5.asc b/minutes/TPI_Board_Meeting_Minutes-2022-11-21.txt.5FA53B246DEA01A5.asc new file mode 100644 index 0000000..e151b84 --- /dev/null +++ b/minutes/TPI_Board_Meeting_Minutes-2022-11-21.txt.5FA53B246DEA01A5.asc @@ -0,0 +1,16 @@ +-----BEGIN PGP SIGNATURE----- + +iQIzBAABCAAdFiEEAvsEvZkfYc+iy7I2X6U7JG3qAaUFAmOpnRwACgkQX6U7JG3q +AaU31A/9GxlmaVl3spqFtPWDKGhJV/J7+LJ+sTJkb0PPvMcryFpS8i2LlTOOu+SB +3ap7L2NF2F//xuB22x05F0UuLhQKHgkDD+nk/NZRcaAUvIgJXGpbs8PP/CJm3QUo +tlccp3lKkNs8WJArgl9l0ma4gYWEsR9LkYy/dUHWTYLTNpWT1JztB6WEMf7Z5hbC +S/Ef+2qi69OYFk1w5oZx9I8rUB3CQv8sRytfeb08kpxILxt8LJC7MBJFHCnFQCZD ++cTd+E0aEV4hnEzaoqGPP1tsr5NoQBMWFpUdJcTFCeTLjPCE8I/hzRYvEpAs5wcT +rJ8bpjuZXuoG4xWydwkAlbMbQ7U8p0YHxZhWWbeGA0qvhvmM2fKl67Kw2ELPMFNG +o6U5jGz9rhpa9sYSbPKxCEXKTf8Ff6DbVO4SN+JDX/z4HjSZqAHkHWoEXJT/lfxj +rTPgYazuOMNOQUXCvuOQw02SgdKenhQJhJ5pKOee/dq2lCTHOALzhNHq7YXHeQW2 +Xa5GaVlYjBQIiRLlqRdhrt+FYAcrbvFWkGVntEGxFaHON2F78EysH3KaoEM8mYgM +MhzQqExhY+qAb29CdQnLpiF+4im6Ka9e4fKeYKXDPcwvmvWdIhB4wI6MxOdLVax0 +aYBrqJldUV4KhqCHBVIlkP2VcTlUg5v82gMx5vwBUkAGXbFO9d4= +=Hhf7 +-----END PGP SIGNATURE----- -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[pluggable-transports/snowflake-webext] branch main updated: fix: occasional infinite `setTimeout(flush` loop
by gitolite role 23 Dec '22

23 Dec '22

This is an automated email from the git hooks/post-receive script. cohosh pushed a commit to branch main in repository pluggable-transports/snowflake-webext. The following commit(s) were added to refs/heads/main by this push: new 2581cf1 fix: occasional infinite `setTimeout(flush` loop 2581cf1 is described below commit 2581cf1e203ddd93942bafd35bc89e8d24e42ff2 Author: WofWca <wofwca(a)protonmail.com> AuthorDate: Wed Nov 9 15:44:04 2022 +0400 fix: occasional infinite `setTimeout(flush` loop Happens if a channel gets closed while its buffer array (e.g. `r2cSchedule`) is not empty. --- proxypair.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/proxypair.js b/proxypair.js index 07670fb..b4dc3c9 100644 --- a/proxypair.js +++ b/proxypair.js @@ -255,6 +255,7 @@ class ProxyPair { clearTimeout(this.connectToRelayTimeoutId); clearTimeout(this.messageTimer); clearTimeout(this.answerTimeoutId); + clearTimeout(this.flush_timeout_id); if (this.webrtcIsReady()) { this.client.close(); } @@ -293,7 +294,7 @@ class ProxyPair { if (this.flush_timeout_id) { clearTimeout(this.flush_timeout_id); - this.flush_timeout_id = null; + this.flush_timeout_id = 0; } if (this.r2cSchedule.length > 0 || this.c2rSchedule.length > 0) { this.flush_timeout_id = setTimeout(this.flush, this.rateLimit.when() * 1000); @@ -330,6 +331,6 @@ ProxyPair.prototype.relay = null; // websocket ProxyPair.prototype.connectToRelayTimeoutId = 0; ProxyPair.prototype.messageTimer = 0; ProxyPair.prototype.answerTimeoutId = 0; -ProxyPair.prototype.flush_timeout_id = null; +ProxyPair.prototype.flush_timeout_id = 0; ProxyPair.prototype.onCleanup = null; -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0