- tor-commits - lists.torproject.org

[Git][tpo/applications/tor-browser-build][maint-13.0] Bug 41055: Prepare Tor Browser Stable 13.0.9
by richard (＠richard) 23 Jan '24

23 Jan '24

richard pushed to branch maint-13.0 at The Tor Project / Applications / tor-browser-build Commits: e5f6056c by Richard Pospesel at 2024-01-23T10:58:37+00:00 Bug 41055: Prepare Tor Browser Stable 13.0.9 - add tor-browser-build#41066 to changelog - - - - - 2 changed files: - projects/browser/Bundle-Data/Docs-TBB/ChangeLog.txt - rbm.conf Changes: ===================================== projects/browser/Bundle-Data/Docs-TBB/ChangeLog.txt ===================================== @@ -28,6 +28,8 @@ Tor Browser 13.0.9 - January 23 2024 * Bug 41016: Switch from bullseye to bookworm for desktop platforms [tor-browser-build] * Windows * Bug 41015: Enable std::filesystem on libc++ on Windows [tor-browser-build] + * Android + * Bug 41066: The Android x86 APK for 13.0.9 is too big [tor-browser-build] Tor Browser 13.5a3 - December 22 2023 * All Platforms ===================================== rbm.conf ===================================== @@ -82,7 +82,7 @@ buildconf: var: torbrowser_version: '13.0.9' - torbrowser_build: 'build1' + torbrowser_build: 'build2' torbrowser_incremental_from: - '[% IF c("var/tor-browser") %]13.0.8[% END %]' - '13.0.7' View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/e… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/e… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][maint-13.0] Bug 41066: Compress the APKs more
by richard (＠richard) 23 Jan '24

23 Jan '24

richard pushed to branch maint-13.0 at The Tor Project / Applications / tor-browser-build Commits: 4ae6c26c by Pier Angelo Vendrame at 2024-01-23T10:48:57+01:00 Bug 41066: Compress the APKs more Our APK was refused by the Play Store as too big. As a workaround, for this release we can try to compress the APK more, by extracting it and repacking it with 7-zip. The preferred and long-term solution would be to switch to Android App Bundles, but this might require some changes to our signing scripts. - - - - - 2 changed files: - projects/browser/build.android - projects/browser/config Changes: ===================================== projects/browser/build.android ===================================== @@ -31,13 +31,19 @@ mv $rootdir/[% c('input_files_by_name/noscript') %] "$noscript_path" mv $rootdir/allowed_addons.json $assets_dir/allowed_addons.json -[% c('zip', { - zip_src => [ '$assets_dir' ], - zip_args => '$apk', - }) %] +mkdir apk +pushd apk +7zz x "$apk" +cp -R ../assets ./ +find -type f -exec touch -m -t '[% USE date; date.format(pc("firefox-android", "timestamp"), format = "%Y%m%d%H%M") %]' {} \; +find -type f ! -name resources.arsc -printf '%P\n' | sort > ../files.txt +7zz a -tzip -mx9 -mtc- -spf ../repacked.apk @../files.txt +# resources.arsc must not be compressed as per the APK specifications +7zz a -tzip -mm=Copy -mtc- ../repacked.apk resources.arsc +popd aligned_apk=$(basename $apk .apk)_aligned.apk -zipalign -vp 4 $apk $aligned_apk +zipalign -vp 4 repacked.apk $aligned_apk # Sign a QA build. This .apk is not a debug version and doesn't contain a debug # flag in the manifest. ===================================== projects/browser/config ===================================== @@ -46,7 +46,13 @@ targets: var: verify_allowed_addons: 1 arch_deps: - - openjdk-11-jdk-headless + - 7zip + - openjdk-17-jdk-headless + container: + # 7zip is in backports in bullseye, and we can already use Java 17 for + # apksigner. + suite: bookworm + arch: amd64 torbrowser: var: prefs_file: 000-tor-browser.js View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/4… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/4… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/firefox-android][firefox-android-115.2.1-13.5-1] fixup! Enable the connect assist experiments on alpha
by Pier Angelo Vendrame (＠pierov) 23 Jan '24

23 Jan '24

Pier Angelo Vendrame pushed to branch firefox-android-115.2.1-13.5-1 at The Tor Project / Applications / firefox-android Commits: 47c80363 by clairehurst at 2024-01-22T12:30:48-07:00 fixup! Enable the connect assist experiments on alpha - - - - - 1 changed file: - fenix/app/src/main/java/org/mozilla/fenix/browser/BaseBrowserFragment.kt Changes: ===================================== fenix/app/src/main/java/org/mozilla/fenix/browser/BaseBrowserFragment.kt ===================================== @@ -1213,19 +1213,22 @@ abstract class BaseBrowserFragment : } private fun handleBetaHtmlTorConnect() { - if (getCurrentTab()?.content?.url == "about:torconnect") { + val currentTab = getCurrentTab() ?: return + if (currentTab.content.url == "about:torconnect") { if (!requireActivity().settings().useNewBootstrap) { - requireContext().components.useCases.tabsUseCases.removeAllTabs() + requireContext().components.useCases.tabsUseCases.removeTab(currentTab.id) (requireActivity() as HomeActivity).navHost.navController.navigate( NavGraphDirections.actionStartupTorbootstrap(), ) } else if (!requireActivity().settings().useNewBootstrapHtmlUi) { - requireContext().components.useCases.tabsUseCases.removeAllTabs() + requireContext().components.useCases.tabsUseCases.removeTab(currentTab.id) (requireActivity() as HomeActivity).navigateToHome() } else { // This just makes it not flash (be visible for a split second) before handleTabSelected() hides it again browserToolbarView.view.visibility = View.GONE } + } else if (currentTab.content.url == "about:tor") { + requireContext().components.useCases.tabsUseCases.removeTab(currentTab.id) } } View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/commit/47c… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/commit/47c… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-115.7.0esr-13.5-1] Bug 1867408 - NSS backport
by ma1 (＠ma1) 22 Jan '24

22 Jan '24

ma1 pushed to branch mullvad-browser-115.7.0esr-13.5-1 at The Tor Project / Applications / Mullvad Browser Commits: 00f5c6d8 by hackademix at 2024-01-22T17:00:26+01:00 Bug 1867408 - NSS backport - - - - - 1 changed file: - security/nss/lib/ssl/sslsecur.c Changes: ===================================== security/nss/lib/ssl/sslsecur.c ===================================== @@ -488,7 +488,12 @@ ssl_SendSavedWriteData(sslSocket *ss) if (rv < 0) { return rv; } - ss->pendingBuf.len -= rv; + if (rv > ss->pendingBuf.len) { + PORT_Assert(0); /* This shouldn't happen */ + ss->pendingBuf.len = 0; + } else { + ss->pendingBuf.len -= rv; + } if (ss->pendingBuf.len > 0 && rv > 0) { /* UGH !! This shifts the whole buffer down by copying it */ PORT_Memmove(ss->pendingBuf.buf, ss->pendingBuf.buf + rv, View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/00f… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/00f… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-115.7.0esr-13.0-1] Bug 1867408 - NSS backport
by ma1 (＠ma1) 22 Jan '24

22 Jan '24

ma1 pushed to branch mullvad-browser-115.7.0esr-13.0-1 at The Tor Project / Applications / Mullvad Browser Commits: e0af4349 by hackademix at 2024-01-22T16:57:26+01:00 Bug 1867408 - NSS backport - - - - - 1 changed file: - security/nss/lib/ssl/sslsecur.c Changes: ===================================== security/nss/lib/ssl/sslsecur.c ===================================== @@ -488,7 +488,12 @@ ssl_SendSavedWriteData(sslSocket *ss) if (rv < 0) { return rv; } - ss->pendingBuf.len -= rv; + if (rv > ss->pendingBuf.len) { + PORT_Assert(0); /* This shouldn't happen */ + ss->pendingBuf.len = 0; + } else { + ss->pendingBuf.len -= rv; + } if (ss->pendingBuf.len > 0 && rv > 0) { /* UGH !! This shifts the whole buffer down by copying it */ PORT_Memmove(ss->pendingBuf.buf, ss->pendingBuf.buf + rv, View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/e0a… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/e0a… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-115.7.0esr-13.5-1] Bug 1867408 - NSS backport
by ma1 (＠ma1) 22 Jan '24

22 Jan '24

ma1 pushed to branch base-browser-115.7.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: eed2de42 by hackademix at 2024-01-22T16:56:41+01:00 Bug 1867408 - NSS backport - - - - - 1 changed file: - security/nss/lib/ssl/sslsecur.c Changes: ===================================== security/nss/lib/ssl/sslsecur.c ===================================== @@ -488,7 +488,12 @@ ssl_SendSavedWriteData(sslSocket *ss) if (rv < 0) { return rv; } - ss->pendingBuf.len -= rv; + if (rv > ss->pendingBuf.len) { + PORT_Assert(0); /* This shouldn't happen */ + ss->pendingBuf.len = 0; + } else { + ss->pendingBuf.len -= rv; + } if (ss->pendingBuf.len > 0 && rv > 0) { /* UGH !! This shifts the whole buffer down by copying it */ PORT_Memmove(ss->pendingBuf.buf, ss->pendingBuf.buf + rv, View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/eed2de4… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/eed2de4… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-115.7.0esr-13.0-1] Bug 1867408 - NSS backport
by ma1 (＠ma1) 22 Jan '24

22 Jan '24

ma1 pushed to branch base-browser-115.7.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 6c906dba by hackademix at 2024-01-22T16:46:05+01:00 Bug 1867408 - NSS backport - - - - - 1 changed file: - security/nss/lib/ssl/sslsecur.c Changes: ===================================== security/nss/lib/ssl/sslsecur.c ===================================== @@ -488,7 +488,12 @@ ssl_SendSavedWriteData(sslSocket *ss) if (rv < 0) { return rv; } - ss->pendingBuf.len -= rv; + if (rv > ss->pendingBuf.len) { + PORT_Assert(0); /* This shouldn't happen */ + ss->pendingBuf.len = 0; + } else { + ss->pendingBuf.len -= rv; + } if (ss->pendingBuf.len > 0 && rv > 0) { /* UGH !! This shifts the whole buffer down by copying it */ PORT_Memmove(ss->pendingBuf.buf, ss->pendingBuf.buf + rv, View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/6c906db… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/6c906db… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.7.0esr-13.5-1] Bug 1867408 - NSS backport
by ma1 (＠ma1) 22 Jan '24

22 Jan '24

ma1 pushed to branch tor-browser-115.7.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: cbeecf99 by hackademix at 2024-01-22T16:29:11+01:00 Bug 1867408 - NSS backport - - - - - 1 changed file: - security/nss/lib/ssl/sslsecur.c Changes: ===================================== security/nss/lib/ssl/sslsecur.c ===================================== @@ -488,7 +488,12 @@ ssl_SendSavedWriteData(sslSocket *ss) if (rv < 0) { return rv; } - ss->pendingBuf.len -= rv; + if (rv > ss->pendingBuf.len) { + PORT_Assert(0); /* This shouldn't happen */ + ss->pendingBuf.len = 0; + } else { + ss->pendingBuf.len -= rv; + } if (ss->pendingBuf.len > 0 && rv > 0) { /* UGH !! This shifts the whole buffer down by copying it */ PORT_Memmove(ss->pendingBuf.buf, ss->pendingBuf.buf + rv, View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/cbeecf9… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/cbeecf9… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-update-responses][main] release: new version, 13.0.9
by richard (＠richard) 22 Jan '24

22 Jan '24

richard pushed to branch main at The Tor Project / Applications / Tor Browser update responses Commits: dae6d47c by Richard Pospesel at 2024-01-22T14:57:04+00:00 release: new version, 13.0.9 - - - - - 30 changed files: - update_3/release/.htaccess - − update_3/release/13.0.5-13.0.8-linux-i686-ALL.xml - − update_3/release/13.0.5-13.0.8-linux-x86_64-ALL.xml - − update_3/release/13.0.5-13.0.8-macos-ALL.xml - − update_3/release/13.0.5-13.0.8-windows-i686-ALL.xml - − update_3/release/13.0.5-13.0.8-windows-x86_64-ALL.xml - − update_3/release/13.0.6-13.0.8-linux-i686-ALL.xml - − update_3/release/13.0.6-13.0.8-linux-x86_64-ALL.xml - − update_3/release/13.0.6-13.0.8-macos-ALL.xml - − update_3/release/13.0.6-13.0.8-windows-i686-ALL.xml - − update_3/release/13.0.6-13.0.8-windows-x86_64-ALL.xml - + update_3/release/13.0.6-13.0.9-linux-i686-ALL.xml - + update_3/release/13.0.6-13.0.9-linux-x86_64-ALL.xml - + update_3/release/13.0.6-13.0.9-macos-ALL.xml - + update_3/release/13.0.6-13.0.9-windows-i686-ALL.xml - + update_3/release/13.0.6-13.0.9-windows-x86_64-ALL.xml - − update_3/release/13.0.7-13.0.8-linux-i686-ALL.xml - − update_3/release/13.0.7-13.0.8-linux-x86_64-ALL.xml - − update_3/release/13.0.7-13.0.8-macos-ALL.xml - − update_3/release/13.0.7-13.0.8-windows-i686-ALL.xml - − update_3/release/13.0.7-13.0.8-windows-x86_64-ALL.xml - + update_3/release/13.0.7-13.0.9-linux-i686-ALL.xml - + update_3/release/13.0.7-13.0.9-linux-x86_64-ALL.xml - + update_3/release/13.0.7-13.0.9-macos-ALL.xml - + update_3/release/13.0.7-13.0.9-windows-i686-ALL.xml - + update_3/release/13.0.7-13.0.9-windows-x86_64-ALL.xml - + update_3/release/13.0.8-13.0.9-linux-i686-ALL.xml - + update_3/release/13.0.8-13.0.9-linux-x86_64-ALL.xml - + update_3/release/13.0.8-13.0.9-macos-ALL.xml - + update_3/release/13.0.8-13.0.9-windows-i686-ALL.xml The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-update-responses… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-update-responses… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.7.0esr-13.0-1] Bug 1867408 - NSS backport
by richard (＠richard) 22 Jan '24

22 Jan '24

richard pushed to branch tor-browser-115.7.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 734de07b by hackademix at 2024-01-19T22:48:05+01:00 Bug 1867408 - NSS backport - - - - - 1 changed file: - security/nss/lib/ssl/sslsecur.c Changes: ===================================== security/nss/lib/ssl/sslsecur.c ===================================== @@ -488,7 +488,12 @@ ssl_SendSavedWriteData(sslSocket *ss) if (rv < 0) { return rv; } - ss->pendingBuf.len -= rv; + if (rv > ss->pendingBuf.len) { + PORT_Assert(0); /* This shouldn't happen */ + ss->pendingBuf.len = 0; + } else { + ss->pendingBuf.len -= rv; + } if (ss->pendingBuf.len > 0 && rv > 0) { /* UGH !! This shifts the whole buffer down by copying it */ PORT_Memmove(ss->pendingBuf.buf, ss->pendingBuf.buf + rv, View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/734de07… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/734de07… You're receiving this email because of your account on gitlab.torproject.org.

1 0