- tor-commits - lists.torproject.org

[tor/master] Merge remote-tracking branch 'rransom-tor/bug3332-v2'
by nickm＠torproject.org 15 Jun '11

15 Jun '11

commit a857f61e278aa5e5980722f9d458424b8790e9b1 Merge: 875a551 44eafa9 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Jun 15 11:33:40 2011 -0400 Merge remote-tracking branch 'rransom-tor/bug3332-v2' changes/bug3332 | 9 +++++++++ src/or/directory.c | 17 +++++++++++++++++ src/or/rendclient.c | 4 ++++ src/or/rendservice.c | 3 +++ 4 files changed, 33 insertions(+), 0 deletions(-) diff --cc src/or/rendservice.c index af1a290,80fa357..4413ae9 --- a/src/or/rendservice.c +++ b/src/or/rendservice.c @@@ -903,8 -903,9 +903,9 @@@ rend_service_introduce(origin_circuit_ time_t now = time(NULL); char diffie_hellman_hash[DIGEST_LEN]; time_t *access_time; - or_options_t *options = get_options(); + const or_options_t *options = get_options(); + tor_assert(!(circuit->build_state->onehop_tunnel)); tor_assert(circuit->rend_data); base32_encode(serviceid, REND_SERVICE_ID_LEN_BASE32+1,

1 0

[metrics-web/master] Provide old relay stats in a single tarball.
by karsten＠torproject.org 15 Jun '11

15 Jun '11

commit e73815094c224dc79e2e73e89d89847e1c5a215e Author: Karsten Loesing <karsten.loesing(a)gmx.net> Date: Wed Jun 15 15:36:29 2011 +0200 Provide old relay stats in a single tarball. --- .../torproject/ernie/web/ResearchDataServlet.java | 31 +-------- web/WEB-INF/data.jsp | 66 +++++--------------- 2 files changed, 18 insertions(+), 79 deletions(-) diff --git a/src/org/torproject/ernie/web/ResearchDataServlet.java b/src/org/torproject/ernie/web/ResearchDataServlet.java index cd39ee6..0cf1564 100644 --- a/src/org/torproject/ernie/web/ResearchDataServlet.java +++ b/src/org/torproject/ernie/web/ResearchDataServlet.java @@ -72,8 +72,7 @@ public class ResearchDataServlet extends HttpServlet { String[] certs = new String[2]; SortedMap<Date, String[]> bridgeDescriptors = new TreeMap<Date, String[]>(java.util.Collections.reverseOrder()); - SortedMap<String, Map<String, String[]>> relayStatistics = - new TreeMap<String, Map<String, String[]>>(); + String[] relayStatistics = new String[2]; SortedMap<String, Map<String, String[]>> torperfData = new TreeMap<String, Map<String, String[]>>(); SortedMap<Date, String[]> exitLists = @@ -151,33 +150,9 @@ public class ResearchDataServlet extends HttpServlet { bridgeDescriptors.get(month)[index] = url; /* URL contains relay statistics. */ - } else if (filename.startsWith("buffer-") || - filename.startsWith("dirreq-") || - filename.startsWith("entry-") || - (filename.startsWith("exit-") && - !filename.startsWith("exit-list-"))) { - String[] parts = filename.split("-"); - if (parts.length != 3) { - continue; - } - String type = parts[0]; - String nickname = parts[1]; - String fingerprint = parts[2]; - fingerprint = fingerprint.substring(0, 8); + } else if (filename.startsWith("relay-statistics.tar.bz2")) { int index = filename.endsWith(".asc") ? 1 : 0; - String nicknameAndFingerprint = nickname + " (" - + fingerprint.toUpperCase() + ")"; - if (!relayStatistics.containsKey(nicknameAndFingerprint)) { - relayStatistics.put(nicknameAndFingerprint, - new HashMap<String, String[]>()); - } - if (!relayStatistics.get(nicknameAndFingerprint).containsKey( - type)) { - relayStatistics.get(nicknameAndFingerprint).put(type, - new String[2]); - } - relayStatistics.get(nicknameAndFingerprint).get(type)[index] = - url; + relayStatistics[index] = url; /* URL contains Torperf data file. */ } else if (filename.endsWith("b.data") || diff --git a/web/WEB-INF/data.jsp b/web/WEB-INF/data.jsp index da4ceb4..85cd3cc 100644 --- a/web/WEB-INF/data.jsp +++ b/web/WEB-INF/data.jsp @@ -28,7 +28,6 @@ <li><a href="#relaydesc">Relay descriptor archives</a></li> <li><a href="#bridgedesc">Bridge descriptor archives</a></li> <li><a href="#bridgeassignments">Bridge pool assignments</a></li> - <li><a href="#stats">Statistics produced by relays</a></li> <li><a href="#performance">Performance data</a></li> <li><a href="#exitlist">Exit lists</a></li> </ul> @@ -106,6 +105,21 @@ </c:if> which is updated whenever new v3 certificates become available.</p> </c:if> + <c:if test="${relayStatistics[0] ne null}"> + <br> + <p>Some of the relays are configured to gather statistics on the + number of requests or connecting clients, the number of + processed cells per queue, or the number of exiting bytes per + port. Relays running version 0.2.2.4-alpha or higher can include + these statistics in extra-info descriptors, so that they are + included in the relay descriptor archives. This + <a href="${relayStatistics[0]}">archive</a> + <c:if test="${relayStatistics[1] ne null}"> + (<a href="${relayStatistics[1]}">sig</a>) + </c:if> + contains the statistics produced by relays running earlier + versions.</p> + </c:if> <br> <a name="bridgedesc"></a> <h3>Bridge descriptor archives</h3> @@ -155,56 +169,6 @@ </c:forEach> </table> <br> - <a name="stats"></a> - <h3>Statistics produced by relays</h3> - <br> - <p>Some of the relays are configured to gather statistics on the - number of requests or connecting clients, the number of processed - cells per queue, or the number of exiting bytes per port. Relays - running version 0.2.2.4-alpha can include these statistics in - extra-info descriptors, so that they are included in the relay - descriptor archives. The following files contain the statistics - produced by relays running earlier versions:</p> - <table width="100%" border="0" cellpadding="5" cellspacing="0" summary=""> - <c:forEach var="item" items="${relayStatistics}" > - <tr> - <td>${item.key}</td> - <td> - <c:if test="${item.value['buffer'] ne null}" > - <a href="${item.value['buffer'][0]}">buffer-stats</a> - <c:if test="${item.value['buffer'][1] ne null}"> - (<a href="${item.value['buffer'][1]}">sig</a>) - </c:if> - </c:if> - </td> - <td> - <c:if test="${item.value['dirreq'] ne null}" > - <a href="${item.value['dirreq'][0]}">dirreq-stats</a> - <c:if test="${item.value['dirreq'][1] ne null}"> - (<a href="${item.value['dirreq'][1]}">sig</a>) - </c:if> - </c:if> - </td> - <td> - <c:if test="${item.value['entry'] ne null}" > - <a href="${item.value['entry'][0]}">entry-stats</a> - <c:if test="${item.value['entry'][1] ne null}"> - (<a href="${item.value['entry'][1]}">sig</a>) - </c:if> - </c:if> - </td> - <td> - <c:if test="${item.value['exit'] ne null}" > - <a href="${item.value['exit'][0]}">exit-stats</a> - <c:if test="${item.value['exit'][1] ne null}"> - (<a href="${item.value['exit'][1]}">sig</a>) - </c:if> - </c:if> - </td> - </tr> - </c:forEach> - </table> - <br> <a name="performance"></a> <h3>Performance data</h3> <br>

1 0

r24822: {} a picture of the old vs new stickers (projects/misc/phobos/tor)
by Andrew Lewman 14 Jun '11

14 Jun '11

Author: phobos Date: 2011-06-14 21:04:07 +0000 (Tue, 14 Jun 2011) New Revision: 24822 Added: projects/misc/phobos/tor/2011-oldsticker-vs-newsticker.jpg Removed: projects/misc/phobos/tor/2011-03-30-12.00.01.jpg Log: a picture of the old vs new stickers Deleted: projects/misc/phobos/tor/2011-03-30-12.00.01.jpg =================================================================== (Binary files differ) Added: projects/misc/phobos/tor/2011-oldsticker-vs-newsticker.jpg =================================================================== (Binary files differ) Property changes on: projects/misc/phobos/tor/2011-oldsticker-vs-newsticker.jpg ___________________________________________________________________ Added: svn:mime-type + image/jpeg

1 0

r24821: {} add the raw html and css for the check.tpo redesign. need to (projects/misc/phobos)
by Andrew Lewman 14 Jun '11

14 Jun '11

Author: phobos Date: 2011-06-14 20:55:20 +0000 (Tue, 14 Jun 2011) New Revision: 24821 Added: projects/misc/phobos/2011-check_redesign_files.tar.gz Log: add the raw html and css for the check.tpo redesign. need to hack this into the python code. Added: projects/misc/phobos/2011-check_redesign_files.tar.gz =================================================================== (Binary files differ) Property changes on: projects/misc/phobos/2011-check_redesign_files.tar.gz ___________________________________________________________________ Added: svn:mime-type + application/octet-stream

1 0

[metrics-db/master] Download votes when v3-status-votes file is truncated.
by karsten＠torproject.org 14 Jun '11

14 Jun '11

commit ff73f5b6820e6ec6f5156bc265a7c6d413c01719 Author: Karsten Loesing <karsten.loesing(a)gmx.net> Date: Tue Jun 14 21:47:36 2011 +0200 Download votes when v3-status-votes file is truncated. In the past, we sometimes had problems rsync'ing the v3-status-votes file from gabelmoo and were left with a truncated file. When parsing this file we successfully parsed the complete votes and failed parsing the last, truncated vote. But we however marked this vote as downloaded and made no further attempts to download it from the directory authorities. The fix is to only mark a vote as downloaded if it contains a valid directory footer. --- .../torproject/ernie/db/RelayDescriptorParser.java | 20 ++++++++++++-------- 1 files changed, 12 insertions(+), 8 deletions(-) diff --git a/src/org/torproject/ernie/db/RelayDescriptorParser.java b/src/org/torproject/ernie/db/RelayDescriptorParser.java index 089b743..3fdd3d8 100644 --- a/src/org/torproject/ernie/db/RelayDescriptorParser.java +++ b/src/org/torproject/ernie/db/RelayDescriptorParser.java @@ -140,11 +140,7 @@ public class RelayDescriptorParser { this.aw.storeConsensus(data, validAfter); } } else { - if (this.rdd != null) { - this.rdd.haveParsedVote(validAfterTime, fingerprint, - serverDescriptors); - } - if (this.aw != null) { + if (this.aw != null || this.rdd != null) { String ascii = new String(data, "US-ASCII"); String startToken = "network-status-version "; String sigToken = "directory-signature "; @@ -155,11 +151,19 @@ public class RelayDescriptorParser { byte[] forDigest = new byte[sig - start]; System.arraycopy(data, start, forDigest, 0, sig - start); String digest = DigestUtils.shaHex(forDigest).toUpperCase(); - this.aw.storeVote(data, validAfter, dirSource, digest); + if (this.aw != null) { + this.aw.storeVote(data, validAfter, dirSource, digest); + } + if (this.rdd != null) { + this.rdd.haveParsedVote(validAfterTime, fingerprint, + serverDescriptors); + } } if (certificateString != null) { - this.aw.storeCertificate(certificateString.getBytes(), - dirSource, dirKeyPublished); + if (this.aw != null) { + this.aw.storeCertificate(certificateString.getBytes(), + dirSource, dirKeyPublished); + } } } }

1 0

[metrics-web/master] Improve display of links on data page.
by karsten＠torproject.org 14 Jun '11

14 Jun '11

commit d50f6d5c90053fc59971c6097bea951cbd8e6b17 Author: Karsten Loesing <karsten.loesing(a)gmx.net> Date: Tue Jun 14 20:19:36 2011 +0200 Improve display of links on data page. Improvements consist of reordering tarballs in descending order and displaying the correct date of Torperf experiment data files. --- .../torproject/ernie/web/ResearchDataServlet.java | 25 +++++++++++-------- 1 files changed, 14 insertions(+), 11 deletions(-) diff --git a/src/org/torproject/ernie/web/ResearchDataServlet.java b/src/org/torproject/ernie/web/ResearchDataServlet.java index b863920..cd39ee6 100644 --- a/src/org/torproject/ernie/web/ResearchDataServlet.java +++ b/src/org/torproject/ernie/web/ResearchDataServlet.java @@ -67,19 +67,21 @@ public class ResearchDataServlet extends HttpServlet { * displaying the files in tables and map values being 2-element * arrays containing the file url and optional signature file. */ SortedMap<Date, Map<String, String[]>> relayDescriptors = - new TreeMap<Date, Map<String, String[]>>(); + new TreeMap<Date, Map<String, String[]>>( + java.util.Collections.reverseOrder()); String[] certs = new String[2]; SortedMap<Date, String[]> bridgeDescriptors = - new TreeMap<Date, String[]>(); + new TreeMap<Date, String[]>(java.util.Collections.reverseOrder()); SortedMap<String, Map<String, String[]>> relayStatistics = new TreeMap<String, Map<String, String[]>>(); SortedMap<String, Map<String, String[]>> torperfData = new TreeMap<String, Map<String, String[]>>(); - SortedMap<Date, String[]> exitLists = new TreeMap<Date, String[]>(); + SortedMap<Date, String[]> exitLists = + new TreeMap<Date, String[]>(java.util.Collections.reverseOrder()); SortedMap<Date, String[]> torperfExperiments = new TreeMap<Date, String[]>(); SortedMap<Date, String[]> bridgePoolAssignments = - new TreeMap<Date, String[]>(); + new TreeMap<Date, String[]>(java.util.Collections.reverseOrder()); /* Prepare rewriting Torperf sources. */ Map<String, String> torperfSources = new HashMap<String, String>(); @@ -91,6 +93,7 @@ public class ResearchDataServlet extends HttpServlet { /* Go through the file list, decide for each file what metrics data * type it is, and put it in the appropriate map. */ SimpleDateFormat monthFormat = new SimpleDateFormat("yyyy-MM"); + SimpleDateFormat dateFormat = new SimpleDateFormat("yyyy-MM-dd"); List<String> torperfFilesizes = Arrays.asList("50kb,1mb,5mb". split(",")); for (String url : dataFileUrls) { @@ -204,19 +207,19 @@ public class ResearchDataServlet extends HttpServlet { /* URL contains Torperf experiment tarball. */ } else if (filename.startsWith("torperf-experiment-20")) { - String yearMonth = filename.substring(filename.indexOf("20")); - yearMonth = yearMonth.substring(0, 7); - Date month = null; + String dateString = filename.substring(filename.indexOf("20")); + dateString = dateString.substring(0, 10); + Date date = null; try { - month = monthFormat.parse(yearMonth); + date = dateFormat.parse(dateString); } catch (ParseException e) { /* Ignore this URL. */ continue; } - if (!torperfExperiments.containsKey(month)) { - torperfExperiments.put(month, new String[2]); + if (!torperfExperiments.containsKey(date)) { + torperfExperiments.put(date, new String[2]); } - torperfExperiments.get(month)[0] = url; + torperfExperiments.get(date)[0] = url; /* URL contains exit list. */ } else if (filename.startsWith("exit-list-20")) {

1 0

[tor/master] Merge remote-tracking branch 'origin/maint-0.2.2'
by nickm＠torproject.org 14 Jun '11

14 Jun '11

commit 875a551409c81fced826336a73cafa36396a43f8 Merge: 19febed a25c0a5 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Jun 14 13:46:46 2011 -0400 Merge remote-tracking branch 'origin/maint-0.2.2' changes/bug3369 | 4 ++++ changes/bug3393 | 5 +++++ src/or/dnsserv.c | 4 ++-- 3 files changed, 11 insertions(+), 2 deletions(-)

1 0

[tor/master] client-side DNS proxy server: reply NOTIMPL to unsupported queries
by nickm＠torproject.org 14 Jun '11

14 Jun '11

commit 910472c5146ad3e436f1b5238570a2802662319b Author: intrigeri <intrigeri(a)boum.org> Date: Sun Jun 12 11:57:31 2011 +0200 client-side DNS proxy server: reply NOTIMPL to unsupported queries Fix for bug 3369. --- src/or/dnsserv.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/or/dnsserv.c b/src/or/dnsserv.c index 009ab5f..f2c473d 100644 --- a/src/or/dnsserv.c +++ b/src/or/dnsserv.c @@ -95,8 +95,8 @@ evdns_server_callback(struct evdns_server_request *req, void *_data) } if (!q) { log_info(LD_APP, "None of the questions we got were ones we're willing " - "to support. Sending NODATA."); - evdns_server_request_respond(req, DNS_ERR_NONE); + "to support. Sending NOTIMPL."); + evdns_server_request_respond(req, DNS_ERR_NOTIMPL); return; } if (q->type != EVDNS_TYPE_A) {

1 0

[tor/master] changelog entry for bug3369
by nickm＠torproject.org 14 Jun '11

14 Jun '11

commit e470f6a8866105c9f6b113aa8eafec5ee202c992 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Jun 13 13:42:00 2011 -0400 changelog entry for bug3369 --- changes/bug3369 | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/changes/bug3369 b/changes/bug3369 new file mode 100644 index 0000000..9c0d0e6 --- /dev/null +++ b/changes/bug3369 @@ -0,0 +1,4 @@ + o Minor bugfixes: + - When asked about a DNS record type we don't support via a + client DNSPort, reply with NOTIMPL rather than an empty + reply. Patch by intrigeri. Fixes bug 3369; bugfix on 2.0.1-alpha.

1 0

[tor/master] Merge remote-tracking branch 'public/bug3369' into maint-0.2.2
by nickm＠torproject.org 14 Jun '11

14 Jun '11

commit a25c0a5bf81768c4d4f6fe377cea48f47333a8c8 Merge: e70e836 e470f6a Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Jun 14 13:46:10 2011 -0400 Merge remote-tracking branch 'public/bug3369' into maint-0.2.2 changes/bug3369 | 4 ++++ src/or/dnsserv.c | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-)

1 0