- tor-commits - lists.torproject.org

[tor/master] Add onion address to the HS_DESC UPLOADED event
by nickm＠torproject.org 22 Feb '16

22 Feb '16

commit 13a857183456307bf3e97aa8338219ca245b1040 Author: David Goulet <dgoulet(a)ev0ke.net> Date: Wed Feb 17 14:34:20 2016 -0500 Add onion address to the HS_DESC UPLOADED event Fixes #16023 Signed-off-by: David Goulet <dgoulet(a)ev0ke.net> --- changes/bug16023 | 4 ++++ src/or/control.c | 14 ++++++++++---- src/or/control.h | 5 ++++- src/or/directory.c | 7 ++++++- 4 files changed, 24 insertions(+), 6 deletions(-) diff --git a/changes/bug16023 b/changes/bug16023 new file mode 100644 index 0000000..7451e27 --- /dev/null +++ b/changes/bug16023 @@ -0,0 +1,4 @@ + o Minor feature (hidden service, control port) + - Add the onion address to the HS_DESC event for the UPLOADED action + both on success or failure. It was previously hardcoded with UNKNOWN. + Fixes #16023; diff --git a/src/or/control.c b/src/or/control.c index 2c0209e..55b287d 100644 --- a/src/or/control.c +++ b/src/or/control.c @@ -6384,6 +6384,7 @@ control_event_hs_descriptor_receive_end(const char *action, */ void control_event_hs_descriptor_upload_end(const char *action, + const char *onion_address, const char *id_digest, const char *reason) { @@ -6400,8 +6401,9 @@ control_event_hs_descriptor_upload_end(const char *action, } send_control_event(EVENT_HS_DESC, - "650 HS_DESC %s UNKNOWN UNKNOWN %s%s\r\n", + "650 HS_DESC %s %s UNKNOWN %s%s\r\n", action, + rend_hsaddress_str_or_unknown(onion_address), node_describe_longname_by_id(id_digest), reason_field ? reason_field : ""); @@ -6431,14 +6433,17 @@ control_event_hs_descriptor_received(const char *onion_address, * called when we successfully uploaded a hidden service descriptor. */ void -control_event_hs_descriptor_uploaded(const char *id_digest) +control_event_hs_descriptor_uploaded(const char *id_digest, + const char *onion_address) { if (!id_digest) { log_warn(LD_BUG, "Called with id_digest==%p", id_digest); return; } - control_event_hs_descriptor_upload_end("UPLOADED", id_digest, NULL); + + control_event_hs_descriptor_upload_end("UPLOADED", onion_address, + id_digest, NULL); } /** Send HS_DESC event to inform controller that query rend_query @@ -6500,6 +6505,7 @@ control_event_hs_descriptor_content(const char *onion_address, */ void control_event_hs_descriptor_upload_failed(const char *id_digest, + const char *onion_address, const char *reason) { if (!id_digest) { @@ -6507,7 +6513,7 @@ control_event_hs_descriptor_upload_failed(const char *id_digest, id_digest); return; } - control_event_hs_descriptor_upload_end("UPLOAD_FAILED", + control_event_hs_descriptor_upload_end("UPLOAD_FAILED", onion_address, id_digest, reason); } diff --git a/src/or/control.h b/src/or/control.h index 1f8e2bc..c5191f9 100644 --- a/src/or/control.h +++ b/src/or/control.h @@ -129,16 +129,19 @@ void control_event_hs_descriptor_receive_end(const char *action, const char *id_digest, const char *reason); void control_event_hs_descriptor_upload_end(const char *action, + const char *onion_address, const char *hs_dir, const char *reason); void control_event_hs_descriptor_received(const char *onion_address, const rend_data_t *rend_data, const char *id_digest); -void control_event_hs_descriptor_uploaded(const char *hs_dir); +void control_event_hs_descriptor_uploaded(const char *hs_dir, + const char *onion_address); void control_event_hs_descriptor_failed(const rend_data_t *rend_data, const char *id_digest, const char *reason); void control_event_hs_descriptor_upload_failed(const char *hs_dir, + const char *onion_address, const char *reason); void control_event_hs_descriptor_content(const char *onion_address, const char *desc_id, diff --git a/src/or/directory.c b/src/or/directory.c index ecf6da8..6c8b6a2 100644 --- a/src/or/directory.c +++ b/src/or/directory.c @@ -2364,16 +2364,21 @@ connection_dir_client_reached_eof(dir_connection_t *conn) if (conn->base_.purpose == DIR_PURPOSE_UPLOAD_RENDDESC_V2) { #define SEND_HS_DESC_UPLOAD_FAILED_EVENT(reason) ( \ control_event_hs_descriptor_upload_failed(conn->identity_digest, \ + conn->rend_data->onion_address, \ reason) ) log_info(LD_REND,"Uploaded rendezvous descriptor (status %d " "(%s))", status_code, escaped(reason)); + /* Without the rend data, we'll have a problem identifying what has been + * uploaded for which service. */ + tor_assert(conn->rend_data); switch (status_code) { case 200: log_info(LD_REND, "Uploading rendezvous descriptor: finished with status " "200 (%s)", escaped(reason)); - control_event_hs_descriptor_uploaded(conn->identity_digest); + control_event_hs_descriptor_uploaded(conn->identity_digest, + conn->rend_data->onion_address); rend_service_desc_has_uploaded(conn->rend_data); break; case 400:

1 0

[tor/master] Merge branch 'bug16023_028_01_squashed'
by nickm＠torproject.org 22 Feb '16

22 Feb '16

commit 2240aa1269b0b72bff678eaa3f144f8ebb3d3931 Merge: a9993a9 13a8571 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Feb 22 13:17:58 2016 -0500 Merge branch 'bug16023_028_01_squashed' changes/bug16023 | 4 ++++ src/or/control.c | 14 ++++++++++---- src/or/control.h | 5 ++++- src/or/directory.c | 7 ++++++- 4 files changed, 24 insertions(+), 6 deletions(-)

1 0

[stem/master] Ignore missing TestingClientBootstrapConsensusAuthorityOnlyMaxDownloadTries
by atagar＠torproject.org 22 Feb '16

22 Feb '16

commit 1970e1b448120e276fc6c04bf86bf5e9f5686e67 Author: Damian Johnson <atagar(a)torproject.org> Date: Mon Feb 22 09:43:34 2016 -0800 Ignore missing TestingClientBootstrapConsensusAuthorityOnlyMaxDownloadTries We've had a ticket about this for a couple month now. Lets stop failing our integ tests over it... https://trac.torproject.org/projects/tor/ticket/17913 --- test/integ/manual.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/test/integ/manual.py b/test/integ/manual.py index d20c407..d877c74 100644 --- a/test/integ/manual.py +++ b/test/integ/manual.py @@ -302,6 +302,9 @@ class TestManual(unittest.TestCase): missing_from_manual = config_options_in_tor.difference(config_options_in_manual) + if 'TestingClientBootstrapConsensusAuthorityOnlyMaxDownloadTries' in missing_from_manual: + missing_from_manual.remove('TestingClientBootstrapConsensusAuthorityOnlyMaxDownloadTries') # https://trac.torproject.org/projects/tor/ticket/17913 + if missing_from_manual: self.fail("The %s config options supported by tor isn't in its man page. Maybe we need to add them?" % ', '.join(missing_from_manual))

1 0

[stem/master] Fix couple online integ tests
by atagar＠torproject.org 22 Feb '16

22 Feb '16

commit a0fb3167b9a76f754a8d8293b58239197544c91a Author: Damian Johnson <atagar(a)torproject.org> Date: Mon Feb 22 09:11:00 2016 -0800 Fix couple online integ tests We don't run tests requiring our ONLINE target by default so they get a little less love. Fixing the following couple... ====================================================================== FAIL: test_authorities_are_up_to_date ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/atagar/Desktop/stem/test/runner.py", line 161, in wrapped return func(self, *args, **kwargs) File "/home/atagar/Desktop/stem/test/runner.py", line 178, in wrapped return func(self, *args, **kwargs) File "/home/atagar/Desktop/stem/test/integ/descriptor/remote.py", line 38, in test_authorities_are_up_to_date self.fail("%s isn't a recognized directory authority in stem" % auth.nickname) AssertionError: dannenberg-legacy isn't a recognized directory authority in stem ---------------------------------------------------------------------- ====================================================================== FAIL: test_attributes ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/atagar/Desktop/stem/test/integ/manual.py", line 198, in test_attributes assert_equal('commandline options', EXPECTED_CLI_OPTIONS, set(manual.commandline_options.keys())) File "/home/atagar/Desktop/stem/test/integ/manual.py", line 190, in assert_equal self.fail("Changed tor's man page? The %s changed as follows...\n\nexpected: %s\n\nactual: %s" % (category, expected, actual)) AssertionError: Changed tor's man page? The commandline options changed as follows... expected: set(['-f FILE', '--ignore-missing-torrc', '--list-fingerprint', '--defaults-torrc FILE', '--allow-missing-torrc', '--nt-service', '--verify-config', '--service remove|start|stop', '--quiet|--hush', '--list-torrc-options', '--service install [--options command-line options]', '--version', '--hash-password PASSWORD', '-h, -help']) actual: set([u'-f FILE', u'--hash-password PASSWORD', u'--ignore-missing-torrc', u'--list-fingerprint', u'--defaults-torrc FILE', u'--allow-missing-torrc', u'--nt-service', u'--verify-config', u'--service remove|start|stop', u'--keygen [--newpass]', u'--list-torrc-options', u'--service install [--options command-line options]', u'--quiet|--hush', u'--version', u'-h, -help']) I'm still getting a couple other failures but one is from #17913 and the rest are spurious. --- test/integ/control/controller.py | 2 +- test/integ/descriptor/remote.py | 3 +++ test/integ/manual.py | 2 +- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/test/integ/control/controller.py b/test/integ/control/controller.py index a755540..7f9edd3 100644 --- a/test/integ/control/controller.py +++ b/test/integ/control/controller.py @@ -1106,7 +1106,7 @@ class TestController(unittest.TestCase): # The response data for our request for request should be an IP address + '\n' ip_addr = response[response.find(b'\r\n\r\n'):].strip() - self.assertTrue(stem.util.connection.is_valid_ipv4_address(stem.util.str_tools._to_unicode(ip_addr))) + self.assertTrue(stem.util.connection.is_valid_ipv4_address(stem.util.str_tools._to_unicode(ip_addr)), "'%s' isn't an address" % ip_addr) @require_controller @require_online diff --git a/test/integ/descriptor/remote.py b/test/integ/descriptor/remote.py index 9ce9b8f..a73bb0e 100644 --- a/test/integ/descriptor/remote.py +++ b/test/integ/descriptor/remote.py @@ -32,6 +32,9 @@ class TestDescriptorDownloader(unittest.TestCase): consensus = downloader.get_consensus(document_handler = stem.descriptor.DocumentHandler.BARE_DOCUMENT).run()[0] for auth in consensus.directory_authorities: + if auth.nickname == 'dannenberg-legacy': + continue # skip due to https://trac.torproject.org/projects/tor/ticket/17906 + stem_auth = stem.descriptor.remote.get_authorities().get(auth.nickname) if not stem_auth: diff --git a/test/integ/manual.py b/test/integ/manual.py index fc679bb..d20c407 100644 --- a/test/integ/manual.py +++ b/test/integ/manual.py @@ -34,7 +34,7 @@ EXPECTED_CATEGORIES = set([ 'AUTHORS', ]) -EXPECTED_CLI_OPTIONS = set(['-h, -help', '-f FILE', '--allow-missing-torrc', '--defaults-torrc FILE', '--ignore-missing-torrc', '--hash-password PASSWORD', '--list-fingerprint', '--verify-config', '--service install [--options command-line options]', '--service remove|start|stop', '--nt-service', '--list-torrc-options', '--version', '--quiet|--hush']) +EXPECTED_CLI_OPTIONS = set(['-h, -help', '-f FILE', '--allow-missing-torrc', '--defaults-torrc FILE', '--ignore-missing-torrc', '--hash-password PASSWORD', '--list-fingerprint', '--verify-config', '--service install [--options command-line options]', '--service remove|start|stop', '--nt-service', '--keygen [--newpass]', '--list-torrc-options', '--version', '--quiet|--hush']) EXPECTED_SIGNALS = set(['SIGTERM', 'SIGINT', 'SIGHUP', 'SIGUSR1', 'SIGUSR2', 'SIGCHLD', 'SIGPIPE', 'SIGXFSZ']) EXPECTED_DESCRIPTION = """

1 0

[tor/master] fix two typos in comments
by arma＠torproject.org 22 Feb '16

22 Feb '16

commit a9993a92fba0e8632635f2423fc4cc30da130a53 Author: Roger Dingledine <arma(a)torproject.org> Date: Mon Feb 22 02:34:50 2016 -0500 fix two typos in comments --- src/or/microdesc.c | 2 +- src/or/routerlist.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/or/microdesc.c b/src/or/microdesc.c index dc23bcb..900a50e 100644 --- a/src/or/microdesc.c +++ b/src/or/microdesc.c @@ -840,7 +840,7 @@ microdesc_list_missing_digest256(networkstatus_t *ns, microdesc_cache_t *cache, /** Launch download requests for microdescriptors as appropriate. * * Specifically, we should launch download requests if we are configured to - * download mirodescriptors, and there are some microdescriptors listed the + * download mirodescriptors, and there are some microdescriptors listed in the * current microdesc consensus that we don't have, and either we never asked * for them, or we failed to download them but we're willing to retry. */ diff --git a/src/or/routerlist.c b/src/or/routerlist.c index f666270..13ef081 100644 --- a/src/or/routerlist.c +++ b/src/or/routerlist.c @@ -4452,7 +4452,7 @@ clear_dir_servers(void) /** For every current directory connection whose purpose is purpose, * and where the resource being downloaded begins with prefix, split * rest of the resource into base16 fingerprints (or base64 fingerprints if - * purpose==DIR_PURPPOSE_FETCH_MICRODESC), decode them, and set the + * purpose==DIR_PURPOSE_FETCH_MICRODESC), decode them, and set the * corresponding elements of result to a nonzero value. */ static void

1 0

[stem/master] Example for using the FallbackDirectories
by atagar＠torproject.org 22 Feb '16

22 Feb '16

commit 4ba079906e7890c0df1ab9602ac8240a8c4158a9 Author: Damian Johnson <atagar(a)torproject.org> Date: Sun Feb 21 18:44:44 2016 -0800 Example for using the FallbackDirectories On reflection might as well include the example I just gave teor on #18177 in our pydocs as well. --- stem/descriptor/remote.py | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/stem/descriptor/remote.py b/stem/descriptor/remote.py index dc40e41..e0923dc 100644 --- a/stem/descriptor/remote.py +++ b/stem/descriptor/remote.py @@ -819,6 +819,30 @@ class FallbackDirectory(Directory): Tor directories tor uses as alternates for the authorities. These relays are `hardcoded in tor <https://gitweb.torproject.org/tor.git/tree/src/or/fallback_dirs.inc>`_. + For example, following checks the performance of tor's fallback directories... + + :: + + import time + from stem.descriptor.remote import DescriptorDownloader, FallbackDirectory + + downloader = DescriptorDownloader() + + for fallback_directory in FallbackDirectory.from_cache().values(): + start = time.time() + downloader.get_consensus(endpoints = [(fallback_directory.address, fallback_directory.dir_port)]).run() + print('Downloading the consensus took %0.2f from %s' % (time.time() - start, fallback_directory.nickname)) + + :: + + % python example.py + Downloading the consensus took 5.07 from Doedel22 + Downloading the consensus took 3.59 from tornoderdednl + Downloading the consensus took 4.16 from Logforme + Downloading the consensus took 6.76 from Doedel21 + Downloading the consensus took 5.21 from kitten4 + ... + .. versionadded:: 1.5.0 """

1 0

[stem/master] Script for caching fallback directories
by atagar＠torproject.org 22 Feb '16

22 Feb '16

commit 9e3f6a2930893bcf4cd69a7e18c00efb2480ff10 Author: Damian Johnson <atagar(a)torproject.org> Date: Sun Feb 21 18:19:16 2016 -0800 Script for caching fallback directories Oops! Forgot to add a couple new files to support fallback directories. --- cache_fallback_directories.py | 64 ++++++++++++++++++++++++ stem/descriptor/fallback_directories.cfg | 86 ++++++++++++++++++++++++++++++++ 2 files changed, 150 insertions(+) diff --git a/cache_fallback_directories.py b/cache_fallback_directories.py new file mode 100755 index 0000000..d6a58a9 --- /dev/null +++ b/cache_fallback_directories.py @@ -0,0 +1,64 @@ +#!/usr/bin/env python +# Copyright 2016, Damian Johnson and The Tor Project +# See LICENSE for licensing information + +""" +Caches tor's latest fallback directories. +""" + +import re +import sys + +import stem.descriptor.remote +import stem.util.conf +import stem.util.system + +try: + # account for urllib's change between python 2.x and 3.x + import urllib.request as urllib +except ImportError: + import urllib2 as urllib + +GITWEB_MAN_LOG = 'https://gitweb.torproject.org/tor.git/log/src/or/fallback_dirs.inc' +FALLBACK_DIR_LINK = "href='/tor.git/commit/src/or/fallback_dirs.inc\?id=([^']*)'" + +if __name__ == '__main__': + try: + fallback_dir_page = urllib.urlopen(GITWEB_MAN_LOG).read() + fallback_dir_commit = re.search(FALLBACK_DIR_LINK, fallback_dir_page).group(1) + except: + print("Unable to determine the latest commit to edit tor's fallback directories: %s" % sys.exc_info()[1]) + sys.exit(1) + + try: + stem_commit = stem.util.system.call('git rev-parse HEAD')[0] + except IOError as exc: + print("Unable to determine stem's current commit: %s" % exc) + sys.exit(1) + + print('Latest tor commit editing fallback directories: %s' % fallback_dir_commit) + print('Current stem commit: %s' % stem_commit) + print('') + + cached_fallback_directories = stem.descriptor.remote.FallbackDirectory.from_cache() + latest_fallback_directories = stem.descriptor.remote.FallbackDirectory.from_remote() + + if cached_fallback_directories == latest_fallback_directories: + print('Fallback directories are already up to date, nothing to do.') + sys.exit(0) + + print('Differences detected...\n') + print(stem.descriptor.remote._fallback_directory_differences(cached_fallback_directories, latest_fallback_directories)) + + conf = stem.util.conf.Config() + conf.set('tor_commit', fallback_dir_commit) + conf.set('stem_commit', stem_commit) + + for directory in latest_fallback_directories.values(): + nickname = directory.nickname + conf.set('%s.address' % nickname, directory.address) + conf.set('%s.or_port' % nickname, str(directory.or_port)) + conf.set('%s.dir_port' % nickname, str(directory.dir_port)) + conf.set('%s.fingerprint' % nickname, directory.fingerprint) + + conf.save(stem.descriptor.remote.CACHE_PATH) diff --git a/stem/descriptor/fallback_directories.cfg b/stem/descriptor/fallback_directories.cfg new file mode 100644 index 0000000..158378d --- /dev/null +++ b/stem/descriptor/fallback_directories.cfg @@ -0,0 +1,86 @@ +tor_commit ab3c86479a516073e0b445846a22b0e24ce8078e +stem_commit 645017a5f8c17b143e90602fdfe6c03a1a994a1c +Doedel22.address 178.254.44.135 +Doedel22.or_port 9001 +Doedel22.dir_port 9030 +Doedel22.fingerprint 8FA37B93397015B2BC5A525C908485260BE9F422 +tornoderdednl.address 178.62.199.226 +tornoderdednl.or_port 443 +tornoderdednl.dir_port 80 +tornoderdednl.fingerprint CBEFF7BA4A4062045133C053F2D70524D8BBE5BE +Logforme.address 84.219.173.60 +Logforme.or_port 443 +Logforme.dir_port 9030 +Logforme.fingerprint 855BC2DABE24C861CD887DB9B2E950424B49FC34 +Doedel21.address 178.254.44.135 +Doedel21.or_port 443 +Doedel21.dir_port 80 +Doedel21.fingerprint AE6A8C18E7499B586CD36246AC4BCAFFBBF93AB2 +BabylonNetwork02.address 149.202.98.161 +BabylonNetwork02.or_port 443 +BabylonNetwork02.dir_port 80 +BabylonNetwork02.fingerprint 54660C671B47E6986B465B80444414BD19E5A34B +fluxe3.address 78.47.18.110 +fluxe3.or_port 80 +fluxe3.dir_port 443 +fluxe3.fingerprint F8D27B163B9247B232A2EEE68DD8B698695C28DE +kili.address 178.62.173.203 +kili.or_port 9001 +kili.dir_port 9030 +kili.fingerprint DD85503F2D1F52EF9EAD621E942298F46CD2FC10 +wagner.address 5.175.233.86 +wagner.or_port 443 +wagner.dir_port 80 +wagner.fingerprint 5525D0429BFE5DC4F1B0E9DE47A4CFA169661E33 +fluxe4.address 131.188.40.188 +fluxe4.or_port 80 +fluxe4.dir_port 443 +fluxe4.fingerprint EBE718E1A49EE229071702964F8DB1F318075FF8 +kitten2.address 62.210.124.124 +kitten2.or_port 9101 +kitten2.dir_port 9130 +kitten2.fingerprint 2EBD117806EE43C3CC885A8F1E4DC60F207E7D3E +coby.address 51.255.33.237 +coby.or_port 9001 +coby.dir_port 9091 +coby.fingerprint A360C21FA87FFA2046D92C17086A6B47E5C68109 +GrmmlLitavis.address 5.39.88.19 +GrmmlLitavis.or_port 9001 +GrmmlLitavis.dir_port 9030 +GrmmlLitavis.fingerprint 7CB8C31432A796731EA7B6BF4025548DFEB25E0C +Doedel24.address 178.254.20.134 +Doedel24.or_port 9001 +Doedel24.dir_port 9030 +Doedel24.fingerprint 2CE96A8A1DA032664C90F574AFFBECE18A6E8DFC +BabylonNetwork03.address 193.111.136.162 +BabylonNetwork03.or_port 443 +BabylonNetwork03.dir_port 80 +BabylonNetwork03.fingerprint C79552275DFCD486B942510EF663ED36ACA1A84B +Unnamed.address 217.12.199.208 +Unnamed.or_port 443 +Unnamed.dir_port 80 +Unnamed.fingerprint DF3AED4322B1824BF5539AE54B2D1B38E080FF05 +eriador.address 85.25.138.93 +eriador.or_port 4029 +eriador.dir_port 9030 +eriador.fingerprint 6DE61A6F72C1E5418A66BFED80DFB63E4C77668F +Doedel26.address 178.254.20.134 +Doedel26.or_port 443 +Doedel26.dir_port 80 +Doedel26.fingerprint 9F5068310818ED7C70B0BC4087AB55CB12CB4377 +PedicaboMundi.address 144.76.14.145 +PedicaboMundi.or_port 143 +PedicaboMundi.dir_port 110 +PedicaboMundi.fingerprint 14419131033443AE6E21DA82B0D307F7CAE42BDB +kitten1.address 62.210.124.124 +kitten1.or_port 9001 +kitten1.dir_port 9030 +kitten1.fingerprint 86E78DD3720C78DA8673182EF96C54B162CD660C +Binnacle.address 108.53.208.157 +Binnacle.or_port 443 +Binnacle.dir_port 80 +Binnacle.fingerprint 4F0DB7E687FC7C0AE55C8F243DA8B0EB27FBF1F2 +kitten4.address 212.47.237.95 +kitten4.or_port 9101 +kitten4.dir_port 9130 +kitten4.fingerprint 6FB38EB22E57EF7ED5EF00238F6A48E553735D88

1 0

[stem/master] Fallback directory information
by atagar＠torproject.org 22 Feb '16

22 Feb '16

commit 332ef6e6fe89d9f0d48e9b95acff7de9f3ec647f Author: Damian Johnson <atagar(a)torproject.org> Date: Sun Feb 21 18:04:40 2016 -0800 Fallback directory information Recently tor added fallback directory authorities to help clients bootstrap when the dirauths are unavailable... https://trac.torproject.org/projects/tor/ticket/17158 To help support this effort teor asked for a DocTor check to notify us when the directories become unavailable... https://trac.torproject.org/projects/tor/ticket/18177 Great idea but I'm expanding this. Stem now has a FallbackDirectory class with two methods for getting this information... * FallbackDirectory.from_remote() - Reads the latest fallback_dirs.inc from gitweb, providing the latest fallback directories in tor's master branch. * FallbackDirectory.from_cache() - Provides the latest fallback directories Stem has cached. This is only as up-to-date as the Stem release you're using but is quicker and avoids relying on gitweb. Advantages are... * Stem's descriptor.remote module now puts less load on the directory authorities since it uses fallback directories as well. * Running Stem's integ tests with the ONLINE target includes a test that exercises all the fallback directories, notifying us if any are down. --- cache_manual.py | 4 +- docs/change_log.rst | 1 + run_tests.py | 1 + setup.py | 2 +- stem/descriptor/remote.py | 266 ++++++++++++++++++++++++++++++++++++---- test/integ/descriptor/remote.py | 38 ++++++ test/unit/descriptor/remote.py | 56 +++++++++ 7 files changed, 341 insertions(+), 27 deletions(-) diff --git a/cache_manual.py b/cache_manual.py index aa55dc5..19e73f0 100755 --- a/cache_manual.py +++ b/cache_manual.py @@ -6,7 +6,6 @@ Caches tor's latest manual content. Run this to pick new man page changes. """ -import os import re import sys @@ -19,7 +18,6 @@ try: except ImportError: import urllib2 as urllib -CACHE_PATH = os.path.join(os.path.dirname(__file__), 'stem', 'cached_tor_manual.cfg') GITWEB_MAN_LOG = 'https://gitweb.torproject.org/tor.git/log/doc/tor.1.txt' MAN_LOG_LINK = "href='/tor.git/commit/doc/tor.1.txt\?id=([^']*)'" @@ -53,4 +51,4 @@ if __name__ == '__main__': latest_manual.man_commit = man_commit latest_manual.stem_commit = stem_commit - latest_manual.save(CACHE_PATH) + latest_manual.save(stem.manual.CACHE_PATH) diff --git a/docs/change_log.rst b/docs/change_log.rst index 81bf5a2..c8dc434 100644 --- a/docs/change_log.rst +++ b/docs/change_log.rst @@ -58,6 +58,7 @@ The following are only available within Stem's `git repository * **Descriptors** + * Fallback directory information, lessing the load of `stem.descriptor.remote <api/descriptor/remote.html>`_ on the directory authorities * Support for ed25519 descriptor fields (:spec:`5a79d67`) * Server descriptor validation fails with 'extra-info-digest line had an invalid value' from additions in proposal 228 (:trac:`16227`) * :class:`~stem.descriptor.server_descriptor.BridgeDescriptor` now has 'ntor_onion_key' like its unsanitized counterparts diff --git a/run_tests.py b/run_tests.py index 3d0f845..2fb93bf 100755 --- a/run_tests.py +++ b/run_tests.py @@ -42,6 +42,7 @@ SRC_PATHS = [os.path.join(STEM_BASE, path) for path in ( 'test', 'run_tests.py', 'cache_manual.py', + 'cache_fallback_directories.py', 'setup.py', 'tor-prompt', os.path.join('docs', 'republish.py'), diff --git a/setup.py b/setup.py index 2a78b9b..2e492d4 100644 --- a/setup.py +++ b/setup.py @@ -17,5 +17,5 @@ distutils.core.setup( packages = ['stem', 'stem.descriptor', 'stem.interpreter', 'stem.response', 'stem.util'], keywords = 'tor onion controller', scripts = ['tor-prompt'], - package_data = {'stem': ['cached_tor_manual.cfg', 'settings.cfg'], 'stem.interpreter': ['settings.cfg'], 'stem.util': ['ports.cfg']}, + package_data = {'stem': ['cached_tor_manual.cfg', 'settings.cfg'], 'stem.descriptor': ['fallback_directories.cfg'], 'stem.interpreter': ['settings.cfg'], 'stem.util': ['ports.cfg']}, ) diff --git a/stem/descriptor/remote.py b/stem/descriptor/remote.py index d199fb2..dc40e41 100644 --- a/stem/descriptor/remote.py +++ b/stem/descriptor/remote.py @@ -44,7 +44,11 @@ itself... get_authorities - Provides tor directory information. - DirectoryAuthority - Information about a tor directory authority. + Directory - Relay we can retrieve directory information from + |- DirectoryAuthority - Information about a tor directory authority + +- FallbackDirectory - Directory mirror tor uses when authories are unavailable + |- from_cache - Provides fallback directories cached with Stem. + +- from_remote - Retrieves fallback directories remotely from tor's latest commit. Query - Asynchronous request to download tor descriptors |- start - issues the query if it isn't already running @@ -73,7 +77,9 @@ itself... """ import io +import os import random +import re import sys import threading import time @@ -88,7 +94,7 @@ except ImportError: import stem.descriptor from stem import Flag -from stem.util import log +from stem.util import connection, log, tor_tools # Tor has a limited number of descriptors we can fetch explicitly by their # fingerprint or hashes due to a limit on the url length by squid proxies. @@ -96,6 +102,9 @@ from stem.util import log MAX_FINGERPRINTS = 96 MAX_MICRODESCRIPTOR_HASHES = 92 +GITWEB_FALLBACK_DIR_URL = 'https://gitweb.torproject.org/tor.git/plain/src/or/fallback_dirs.inc' +CACHE_PATH = os.path.join(os.path.dirname(__file__), 'fallback_directories.cfg') + def _guess_descriptor_type(resource): # Attempts to determine the descriptor type based on the resource url. This @@ -340,8 +349,10 @@ class Query(object): """ if use_authority or not self.endpoints: - authority = random.choice(list(filter(lambda auth: auth.v3ident is not None, get_authorities().values()))) - address, dirport = authority.address, authority.dir_port + directories = get_authorities().values() + FallbackDirectory.from_cache().values() + + picked = random.choice(directories) + address, dirport = picked.address, picked.dir_port else: address, dirport = random.choice(self.endpoints) @@ -390,8 +401,8 @@ class DescriptorDownloader(object): def __init__(self, use_mirrors = False, **default_args): self._default_args = default_args - authorities = filter(lambda auth: auth.v3ident is not None, get_authorities().values()) - self._endpoints = [(auth.address, auth.dir_port) for auth in authorities] + directories = get_authorities().values() + FallbackDirectory.from_cache().values() + self._endpoints = [(directory.address, directory.dir_port) for directory in directories] if use_mirrors: try: @@ -412,8 +423,8 @@ class DescriptorDownloader(object): :raises: **Exception** if unable to determine the directory mirrors """ - authorities = filter(lambda auth: auth.v3ident is not None, get_authorities().values()) - new_endpoints = set([(auth.address, auth.dir_port) for auth in authorities]) + directories = get_authorities().values() + FallbackDirectory.from_cache().values() + new_endpoints = set([(directory.address, directory.dir_port) for directory in directories]) consensus = list(self.get_consensus(document_handler = stem.descriptor.DocumentHandler.DOCUMENT).run())[0] @@ -617,7 +628,39 @@ class DescriptorDownloader(object): ) -class DirectoryAuthority(object): +class Directory(object): + """ + Relay we can constact for directory information + + .. versionadded:: 1.5.0 + + :var str address: IP address of the authority, currently they're all IPv4 but + this may not always be the case + :var int or_port: port on which the relay services relay traffic + :var int dir_port: port on which directory information is available + :var str fingerprint: relay fingerprint + :var str nickname: nickname of the authority + """ + + def __init__(self, address, or_port, dir_port, fingerprint, nickname): + self.address = address + self.or_port = or_port + self.dir_port = dir_port + self.fingerprint = fingerprint + self.nickname = nickname + + def __eq__(self, other): + if not isinstance(other, Directory): + return False + + for attr in ('nickname', 'address', 'or_port', 'dir_port', 'fingerprint'): + if getattr(self, attr) != getattr(other, attr): + return False + + return True + + +class DirectoryAuthority(Directory): """ Tor directory authority, a special type of relay `hardcoded into tor <https://gitweb.torproject.org/tor.git/tree/src/or/config.c#n819>`_ @@ -648,23 +691,21 @@ class DirectoryAuthority(object): .. versionchanged:: 1.3.0 Added the is_bandwidth_authority attribute. - :var str nickname: nickname of the authority - :var str address: IP address of the authority, currently they're all IPv4 but - this may not always be the case - :var int or_port: port on which the relay services relay traffic - :var int dir_port: port on which directory information is available - :var str fingerprint: relay fingerprint :var str v3ident: identity key fingerprint used to sign votes and consensus + :var bool is_bandwidth_authority: **True** if this is a bandwidth authority, + **False** otherwise """ - def __init__(self, nickname = None, address = None, or_port = None, dir_port = None, is_bandwidth_authority = False, fingerprint = None, v3ident = None): - self.nickname = nickname - self.address = address - self.or_port = or_port - self.dir_port = dir_port - self.is_bandwidth_authority = is_bandwidth_authority - self.fingerprint = fingerprint + def __init__(self, address = None, or_port = None, dir_port = None, fingerprint = None, nickname = None, v3ident = None, is_bandwidth_authority = False): + super(DirectoryAuthority, self).__init__(address, or_port, dir_port, fingerprint, nickname) self.v3ident = v3ident + self.is_bandwidth_authority = is_bandwidth_authority + + def __eq__(self, other): + if isinstance(other, DirectoryAuthority) and super(DirectoryAuthority, self).__eq__(other): + return self.v3ident == other.v3ident and self.is_bandwidth_authority == other.is_bandwidth_authority + else: + return False DIRECTORY_AUTHORITIES = { @@ -767,7 +808,186 @@ def get_authorities(): The directory information hardcoded into Tor and occasionally changes, so the information this provides might not necessarily match your version of tor. - :returns: dict of str nicknames to :class:`~stem.descriptor.remote.DirectoryAuthority` instances + :returns: **dict** of **str** nicknames to :class:`~stem.descriptor.remote.DirectoryAuthority` instances """ return dict(DIRECTORY_AUTHORITIES) + + +class FallbackDirectory(Directory): + """ + Tor directories tor uses as alternates for the authorities. These relays are + `hardcoded in tor <https://gitweb.torproject.org/tor.git/tree/src/or/fallback_dirs.inc>`_. + + .. versionadded:: 1.5.0 + """ + + def __init__(self, address = None, or_port = None, dir_port = None, fingerprint = None, nickname = None): + super(FallbackDirectory, self).__init__(address, or_port, dir_port, fingerprint, nickname) + + @staticmethod + def from_cache(): + """ + Provides fallback directory information cached with Stem. Unlike + :func:`~stem.descriptor.remote.FallbackDirectory.from_remote` this doesn't + have any system requirements, and is faster too. Only drawback is that + these fallback directories are only as up to date as the Stem release we're + using. + + :returns: **dict** of **str** fingerprints to their + :class:`~stem.descriptor.remote.FallbackDirectory` + """ + + conf = stem.util.conf.Config() + conf.load(CACHE_PATH) + + results = {} + + for nickname in set([key.split('.')[0] for key in conf.keys()]): + if nickname in ('tor_commit', 'stem_commit'): + continue + + attr = {} + + for attr_name in ('address', 'or_port', 'dir_port', 'fingerprint'): + key = '%s.%s' % (nickname, attr_name) + attr[attr_name] = conf.get(key) + + if not attr[attr_name]: + raise IOError("'%s' is missing from %s" % (key, CACHE_PATH)) + + if not connection.is_valid_ipv4_address(attr['address']): + raise IOError("'%s.address' was an invalid address (%s)" % (nickname, attr['address'])) + elif not connection.is_valid_port(attr['or_port']): + raise IOError("'%s.or_port' was an invalid port (%s)" % (nickname, attr['or_port'])) + elif not connection.is_valid_port(attr['dir_port']): + raise IOError("'%s.dir_port' was an invalid port (%s)" % (nickname, attr['dir_port'])) + elif not tor_tools.is_valid_fingerprint(attr['fingerprint']): + raise IOError("'%s.fingerprint' was an invalid fingerprint (%s)" % (nickname, attr['fingerprint'])) + + results[attr['fingerprint']] = FallbackDirectory( + address = attr['address'], + or_port = int(attr['or_port']), + dir_port = int(attr['dir_port']), + fingerprint = attr['fingerprint'], + nickname = nickname, + ) + + return results + + @staticmethod + def from_remote(timeout = 60): + """ + Reads and parses tor's latest fallback directories `from + gitweb.torproject.org + <https://gitweb.torproject.org/tor.git/plain/src/or/fallback_dirs.inc>`_. + Note that while convenient, this reliance on GitWeb means you should alway + call with a fallback, such as... + + :: + + try: + fallback_directories = stem.descriptor.remote.from_remote() + except IOError: + fallback_directories = stem.descriptor.remote.from_cache() + + :param int timeout: seconds to wait before timing out the request + + :returns: **dict** of **str** fingerprints to their + :class:`~stem.descriptor.remote.FallbackDirectory` + + :raises: **IOError** if unable to retrieve the fallback directories + """ + + try: + fallback_dir_page = urllib.urlopen(GITWEB_FALLBACK_DIR_URL, timeout = timeout).read() + except: + exc = sys.exc_info()[1] + raise IOError("Unable to download tor's fallback directories from %s: %s" % (GITWEB_FALLBACK_DIR_URL, exc)) + + # Example of an entry... + # + # /* + # wagner + # Flags: Fast Guard Running Stable V2Dir Valid + # Fallback Weight: 43680 / 491920 (8.879%) + # Consensus Weight: 62600 / 546000 (11.465%) + # Rarely used email <trff914 AT gmail DOT com> + # */ + # "5.175.233.86:80 orport=443 id=5525D0429BFE5DC4F1B0E9DE47A4CFA169661E33" + # " weight=43680", + + results, nickname, last_line = {}, None, None + + for line in fallback_dir_page.splitlines(): + if last_line == '/*': + nickname = line + elif line.startswith('"'): + addr_line_match = re.match('"([\d\.]+):(\d+) orport=(\d+) id=([\dA-F]{40}).*', line) + + if addr_line_match: + address, dir_port, or_port, fingerprint = addr_line_match.groups() + + if not connection.is_valid_ipv4_address(address): + raise IOError('%s has an invalid address: %s' % (nickname, address)) + elif not connection.is_valid_port(or_port): + raise IOError('%s has an invalid or_port: %s' % (nickname, or_port)) + elif not connection.is_valid_port(dir_port): + raise IOError('%s has an invalid dir_port: %s' % (nickname, dir_port)) + elif not tor_tools.is_valid_fingerprint(fingerprint): + raise IOError('%s has an invalid fingerprint: %s' % (nickname, fingerprint)) + + results[fingerprint] = FallbackDirectory( + address = address, + or_port = int(or_port), + dir_port = int(dir_port), + fingerprint = fingerprint, + nickname = nickname, + ) + + last_line = line + + return results + + +def _fallback_directory_differences(previous_directories, new_directories): + """ + Provides a description of how fallback directories differ. + """ + + lines = [] + + added_fp = set(new_directories.keys()).difference(previous_directories.keys()) + removed_fp = set(previous_directories.keys()).difference(new_directories.keys()) + + for fp in added_fp: + directory = new_directories[fp] + + lines += [ + '* Added %s as a new fallback directory:' % directory.nickname, + ' address: %s' % directory.address, + ' or_port: %s' % directory.or_port, + ' dir_port: %s' % directory.dir_port, + ' fingerprint: %s' % directory.fingerprint, + '', + ] + + for fp in removed_fp: + lines.append('* Removed %s as a fallback directory' % previous_directories[fp].nickname) + + for fp in new_directories: + if fp in added_fp or fp in removed_fp: + continue # already discussed these + + previous_directory = previous_directories[fp] + new_directory = new_directories[fp] + + if previous_directory != new_directory: + for attr in ('nickname', 'address', 'or_port', 'dir_port', 'fingerprint'): + old_attr = getattr(previous_directory, attr) + new_attr = getattr(new_directory, attr) + + if old_attr != new_attr: + lines.append('* Changed the %s of %s from %s to %s' % (attr, fp, old_attr, new_attr)) + + return '\n'.join(lines) diff --git a/test/integ/descriptor/remote.py b/test/integ/descriptor/remote.py index fd37b57..9ce9b8f 100644 --- a/test/integ/descriptor/remote.py +++ b/test/integ/descriptor/remote.py @@ -218,3 +218,41 @@ class TestDescriptorDownloader(unittest.TestCase): self.assertTrue(isinstance(single_query_results[0], stem.descriptor.networkstatus.KeyCertificate)) self.assertEqual(2, len(list(multiple_query))) + + @require_online + def test_that_cache_is_up_to_date(self): + """ + Check if the cached fallback directories bundled with Stem are up to date + or not. + """ + + cached_fallback_directories = stem.descriptor.remote.FallbackDirectory.from_cache() + latest_fallback_directories = stem.descriptor.remote.FallbackDirectory.from_remote() + + if cached_fallback_directories != latest_fallback_directories: + self.fail("Stem's cached fallback directories are out of date. Please run 'cache_fallback_directories.py'...\n\n%s" % stem.descriptor.remote._fallback_directory_differences(cached_fallback_directories, latest_fallback_directories)) + + @require_online + def test_that_fallback_directories_are_reachable(self): + """ + Fetch information from each fallback directory to confirm that it's + available. + """ + + unsuccessful = {} + downloader = stem.descriptor.remote.DescriptorDownloader() + moria1_v3ident = stem.descriptor.remote.get_authorities()['moria1'].v3ident + + for fallback_directory in stem.descriptor.remote.FallbackDirectory.from_cache().values(): + try: + downloader.get_key_certificates(authority_v3idents = moria1_v3ident, endpoints = [(fallback_directory.address, fallback_directory.dir_port)]).run() + except Exception as exc: + unsuccessful[fallback_directory] = exc + + if unsuccessful: + lines = ['We were unable to contact the following fallback directories...\n'] + + for fallback_directory, exc in unsuccessful.items(): + lines.append('* %s:%s (%s): %s' % (fallback_directory.address, fallback_directory.dir_port, fallback_directory.fingerprint, exc)) + + self.fail('\n'.join(lines)) diff --git a/test/unit/descriptor/remote.py b/test/unit/descriptor/remote.py index 19907a7..f0e0dea 100644 --- a/test/unit/descriptor/remote.py +++ b/test/unit/descriptor/remote.py @@ -58,6 +58,32 @@ iO3EUE0AEYah2W9gdz8t+i3Dtr0zgqLS841GC/TyDKCm+MKmN8d098qnwK0NGF9q -----END SIGNATURE----- """ +FALLBACK_DIR_CONTENT = b"""\ +/* Trial fallbacks for 0.2.8.1-alpha with ADDRESS_AND_PORT_STABLE_DAYS = 30 + * This works around an issue where relays post a descriptor without a DirPort + * when restarted. If these relays stay up, they will have been up for 120 days + * by the 0.2.8 stable release -- teor */ +/* +wagner +Flags: Fast Guard Running Stable V2Dir Valid +Fallback Weight: 43680 / 491920 (8.879%) +Consensus Weight: 62600 / 546000 (11.465%) +Rarely used email <trff914 AT gmail DOT com> +*/ +"5.175.233.86:80 orport=443 id=5525D0429BFE5DC4F1B0E9DE47A4CFA169661E33" +" weight=43680", +/* +kitten2 +Flags: Fast Guard HSDir Running Stable V2Dir Valid +Fallback Weight: 43680 / 491920 (8.879%) +Consensus Weight: 59100 / 546000 (10.824%) +0xEFB74277ECE4E222 Aeris <aeris+tor AT imirhil DOT fr> - 1aerisnnLWPchhDSXpxWGYWwLiSFUVFnd +*/ +"62.210.124.124:9130 orport=9101 id=2EBD117806EE43C3CC885A8F1E4DC60F207E7D3E" +" ipv6=[2001:bc8:3f23:100::1]:9101" +" weight=43680", +""" + class TestDescriptorDownloader(unittest.TestCase): @patch(URL_OPEN) @@ -154,3 +180,33 @@ class TestDescriptorDownloader(unittest.TestCase): self.assertEqual(1, len(list(query))) self.assertEqual(1, len(list(query))) self.assertEqual(1, len(list(query))) + + def test_fallback_directories_from_cache(self): + # quick sanity test that we can load cached content + fallback_directories = stem.descriptor.remote.FallbackDirectory.from_cache() + self.assertTrue(len(fallback_directories) > 10) + self.assertEqual('wagner', fallback_directories['5525D0429BFE5DC4F1B0E9DE47A4CFA169661E33'].nickname) + + @patch(URL_OPEN) + def test_fallback_directories_from_remote(self, urlopen_mock): + urlopen_mock.return_value = io.BytesIO(FALLBACK_DIR_CONTENT) + fallback_directories = stem.descriptor.remote.FallbackDirectory.from_remote() + + expected = { + '5525D0429BFE5DC4F1B0E9DE47A4CFA169661E33': stem.descriptor.remote.FallbackDirectory( + nickname = 'wagner', + address = '5.175.233.86', + or_port = 443, + dir_port = 80, + fingerprint = '5525D0429BFE5DC4F1B0E9DE47A4CFA169661E33', + ), + '2EBD117806EE43C3CC885A8F1E4DC60F207E7D3E': stem.descriptor.remote.FallbackDirectory( + nickname = 'kitten2', + address = '62.210.124.124', + or_port = 9101, + dir_port = 9130, + fingerprint = '2EBD117806EE43C3CC885A8F1E4DC60F207E7D3E', + ), + } + + self.assertEqual(expected, fallback_directories)

1 0

[doctor/master] Differentiate between 'no badexit flag' and 'not in consensus'
by atagar＠torproject.org 21 Feb '16

21 Feb '16

commit f1d40c6c736a72f9c607d5b170a0085b5f8053a0 Author: Damian Johnson <atagar(a)torproject.org> Date: Sat Feb 20 17:10:19 2016 -0800 Differentiate between 'no badexit flag' and 'not in consensus' Authorities usually flag bad actors by either BadExit or Rejection. As such when we're out of sync it might be because different authorities chose different methods. Updating our notice to better differentiate this... https://trac.torproject.org/projects/tor/ticket/17441#comment:3 --- consensus_health_checker.py | 21 +++++++++++++++++++-- data/consensus_health.cfg | 2 +- 2 files changed, 20 insertions(+), 3 deletions(-) diff --git a/consensus_health_checker.py b/consensus_health_checker.py index e8de5bf..68fad73 100755 --- a/consensus_health_checker.py +++ b/consensus_health_checker.py @@ -662,9 +662,26 @@ def bad_exits_in_sync(latest_consensus, consensuses, votes): for fingerprint in disagreed_bad_exits: with_flag = set([authority for authority, flagged in bad_exits.items() if fingerprint in flagged]) - without_flag = voting_authorities.difference(with_flag) + without_flag = [] + not_in_consensus = [] - issues.append(Issue(Runlevel.NOTICE, 'BADEXIT_OUT_OF_SYNC', fingerprint = fingerprint, with_flag = ', '.join(with_flag), without_flag = ', '.join(without_flag), to = bad_exits.keys())) + for authority in voting_authorities.difference(with_flag): + vote = votes[authority] + + if fingerprint in vote.routers: + without_flag.append(authority) + else: + not_in_consensus.append(authority) + + attr = ['with flag: %s' % ', '.join(with_flag)] + + if without_flag: + attr.append('without flag: %s' % ', '.join(without_flag)) + + if not_in_consensus: + attr.append('not in consensus: %s' % ', '.join(not_in_consensus)) + + issues.append(Issue(Runlevel.NOTICE, 'BADEXIT_OUT_OF_SYNC', fingerprint = fingerprint, counts = ', '.join(attr), to = bad_exits.keys())) return issues diff --git a/data/consensus_health.cfg b/data/consensus_health.cfg index 2c5652a..6d72cac 100644 --- a/data/consensus_health.cfg +++ b/data/consensus_health.cfg @@ -16,7 +16,7 @@ msg MISSING_AUTHORITIES => The following authorities are missing from the consen msg EXTRA_AUTHORITIES => The following authorities were not expected in the consensus: {authorities} msg FINGERPRINT_MISMATCH => {authority} had a different fingerprint than we expected (expected: {expected}, actual: {actual}) msg TOR_OUT_OF_DATE => The following authorities are an out of date version of tor: {authorities} -msg BADEXIT_OUT_OF_SYNC => Authorities disagree about the BadExit flag for {fingerprint} (with flag: {with_flag}, without flag: {without_flag}) +msg BADEXIT_OUT_OF_SYNC => Authorities disagree about the BadExit flag for {fingerprint} ({counts}) msg BANDWIDTH_AUTHORITIES_OUT_OF_SYNC => Bandwidth authorities have a substantially different number of measured entries: {authorities} msg AUTHORITY_UNAVAILABLE => Unable to retrieve the {fetch_type} from {authority} ({url}): {error}

1 0

[doctor/master] Re-enable check that BadExit flags are in sync
by atagar＠torproject.org 21 Feb '16

21 Feb '16

commit 8ada4e0305b16f6b854dae839db2adb7446b7d37 Author: Damian Johnson <atagar(a)torproject.org> Date: Sat Feb 20 17:58:05 2016 -0800 Re-enable check that BadExit flags are in sync Roger says these are useful to him and that he's willing to invest effort to keep in sync so re-enabling the checks... https://trac.torproject.org/projects/tor/ticket/17441#comment:3 --- consensus_health_checker.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/consensus_health_checker.py b/consensus_health_checker.py index 68fad73..b0efb5c 100755 --- a/consensus_health_checker.py +++ b/consensus_health_checker.py @@ -323,7 +323,7 @@ def run_checks(consensuses, votes): #unmeasured_relays, has_authority_flag, is_recommended_versions, - #bad_exits_in_sync, + bad_exits_in_sync, bandwidth_authorities_in_sync, )

1 0