- tor-commits - lists.torproject.org

[tor/maint-0.2.8] Merge remote-tracking branch 'arma/bug18616-v4' into maint-0.2.8
by nickm＠torproject.org 17 May '16

17 May '16

commit 548d14247e3c8a48e2efb2ca62ee7a05fca843ba Merge: 6cc3397 06031b4 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue May 17 10:48:12 2016 -0400 Merge remote-tracking branch 'arma/bug18616-v4' into maint-0.2.8 changes/bug18616 | 14 +++++ src/or/circuitbuild.c | 2 +- src/or/circuituse.c | 5 +- src/or/config.c | 9 ++-- src/or/control.c | 15 +++--- src/or/dirserv.c | 7 ++- src/or/main.c | 4 +- src/or/rephist.c | 9 ++-- src/or/router.c | 140 ++++++++++++++++++++++++++++++++++--------------- src/or/router.h | 4 +- src/test/test_dir.c | 46 ++++++++++++++++ src/test/test_policy.c | 3 +- 12 files changed, 193 insertions(+), 65 deletions(-) diff --cc src/or/router.c index 3f94703,57c0618..d70756f --- a/src/or/router.c +++ b/src/or/router.c @@@ -1570,15 -1625,9 +1627,15 @@@ decide_if_publishable_server(void return 1; if (!router_get_advertised_or_port(options)) return 0; - if (!check_whether_orport_reachable()) - - return check_whether_orport_reachable(options) && - check_whether_dirport_reachable(options); ++ if (!check_whether_orport_reachable(options)) + return 0; + if (router_have_consensus_path() == CONSENSUS_PATH_INTERNAL) { + /* All set: there are no exits in the consensus (maybe this is a tiny + * test network), so we can't check our DirPort reachability. */ + return 1; + } else { - return check_whether_dirport_reachable(); ++ return check_whether_dirport_reachable(options); + } } /** Initiate server descriptor upload as reasonable (if server is publishable,

1 0

[tor/release-0.2.8] Fix remaining lintChanges warnings.
by nickm＠torproject.org 17 May '16

17 May '16

commit ff5eb7fc625374c29944b9ab7160b86559ce90a4 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue May 17 11:06:41 2016 -0400 Fix remaining lintChanges warnings. --- changes/bug18460 | 2 +- changes/bug19003 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/changes/bug18460 b/changes/bug18460 index c90ee11..a8c1a19 100644 --- a/changes/bug18460 +++ b/changes/bug18460 @@ -1,4 +1,4 @@ o Minor bugfixes (statistics): - We now include consensus downloads via IPv6 in our directory-request statistics. - Fixes 18460; bugfix on 0.2.3.14-alpha. + Fixes bug 18460; bugfix on 0.2.3.14-alpha. diff --git a/changes/bug19003 b/changes/bug19003 index f05c489..ca94938 100644 --- a/changes/bug19003 +++ b/changes/bug19003 @@ -1,5 +1,5 @@ o Minor bugfixes (small networks): - Allow directories in small networks to bootstrap by skipping DirPort checks when the consensus has no exits. - Fixes bug 19003, bugfix on 0.2.8.1-alpha. + Fixes bug 19003; bugfix on 0.2.8.1-alpha. Patch by teor.

1 0

[tor/maint-0.2.8] Resolve lintChanges warnings.
by nickm＠torproject.org 17 May '16

17 May '16

commit e0fb75c349f9646c029d0218e5933e0ca349c702 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue May 17 11:05:57 2016 -0400 Resolve lintChanges warnings. --- changes/bug18286 | 5 +++-- changes/bug18460 | 4 ++-- changes/bug18481 | 2 +- changes/bug18729 | 2 +- changes/bug18816 | 2 +- changes/bug18921 | 2 +- changes/bug18929 | 2 +- changes/bug18943 | 2 +- changes/bug19003 | 2 +- changes/fallbacks-201604 | 16 ++++++++-------- changes/feature18483 | 2 +- changes/geoip-april2016 | 2 +- changes/geoip-may2016 | 2 +- 13 files changed, 23 insertions(+), 22 deletions(-) diff --git a/changes/bug18286 b/changes/bug18286 index 6e9ae3d..e398fb0 100644 --- a/changes/bug18286 +++ b/changes/bug18286 @@ -1,4 +1,5 @@ o Minor features (build): - - Tor now again builds with the recent OpenSSL 1.1 development branch - (tested against 1.1.0-pre4 and 1.1.0-pre5-dev). + - Tor now builds again with the recent OpenSSL 1.1 development branch + (tested against 1.1.0-pre4 and 1.1.0-pre5-dev). Closes ticket 18286. + diff --git a/changes/bug18460 b/changes/bug18460 index 457e5df..c90ee11 100644 --- a/changes/bug18460 +++ b/changes/bug18460 @@ -1,4 +1,4 @@ o Minor bugfixes (statistics): - - Include consensus downloads via IPv6 in directory-request statistics. - Fixes bug 18480; bugfix on 4741aa4 in 0.2.3.14-alpha. + - We now include consensus downloads via IPv6 in our directory-request statistics. + Fixes 18460; bugfix on 0.2.3.14-alpha. diff --git a/changes/bug18481 b/changes/bug18481 index 7fd9e1e..6fd882b 100644 --- a/changes/bug18481 +++ b/changes/bug18481 @@ -2,4 +2,4 @@ - Turn all TestingClientBootstrap* into non-testing torrc options. This changes simply renames them by removing "Testing" in front of them and they do not require TestingTorNetwork to be enabled anymore. Fixes - #18481; bugfix on tor-0.2.8.1-alpha. + bug 18481; bugfix on 0.2.8.1-alpha. diff --git a/changes/bug18729 b/changes/bug18729 index d4312c0..4ec9ca3 100644 --- a/changes/bug18729 +++ b/changes/bug18729 @@ -1,3 +1,3 @@ - o Minor logging changes: + o Minor features (logging): - Stop blasting twelve lines per second from periodic_event_dispatch() at loglevel debug. Resolves ticket 18729; fix on 0.2.8.1-alpha. diff --git a/changes/bug18816 b/changes/bug18816 index 7265f5a..103f816 100644 --- a/changes/bug18816 +++ b/changes/bug18816 @@ -1,4 +1,4 @@ o Minor bugfix (bootstrap): - Consistently use the consensus download schedule for authority certificates. - Resolves ticket 18816; fix on fddb814fe in 0.2.4.13-alpha. + Fixes bug 18816; bugfix on 0.2.4.13-alpha. diff --git a/changes/bug18921 b/changes/bug18921 index 934a604..cdd868a 100644 --- a/changes/bug18921 +++ b/changes/bug18921 @@ -1,4 +1,4 @@ o Major bugfixes (IPv6 bridges): - Fix directory address selection for IPv6 bridges. - Resolves #18921, bugfix on #17840 in 0.2.8.1-alpha. + Fixes bug 18921; bugfix on 0.2.8.1-alpha. Patch by "teor". diff --git a/changes/bug18929 b/changes/bug18929 index f79baca..c607e63 100644 --- a/changes/bug18929 +++ b/changes/bug18929 @@ -1,5 +1,5 @@ o Minor bugfixes (IPv6): - Make directory node selection more reliable, mainly for IPv6-only clients and clients with few reachable addresses. - Resolves #18929, bugfix on #17840 in 0.2.8.1-alpha. + Fixes bug 18929; bugfix on 0.2.8.1-alpha. Patch by "teor". diff --git a/changes/bug18943 b/changes/bug18943 index 53569f0..6bcd868 100644 --- a/changes/bug18943 +++ b/changes/bug18943 @@ -2,5 +2,5 @@ - The SHA3 and SHAKE routines now produce the correct output on Big Endian systems, unbreaking the unit tests. No code calls either algorithm family yet, so this is primarily a build fix. - Closes ticket 18943. + Fixes bug 18943; bugfix on 0.2.8.1-alpha. diff --git a/changes/bug19003 b/changes/bug19003 index d9ef23d..f05c489 100644 --- a/changes/bug19003 +++ b/changes/bug19003 @@ -1,5 +1,5 @@ o Minor bugfixes (small networks): - Allow directories in small networks to bootstrap by skipping DirPort checks when the consensus has no exits. - Resolves #19003, bugfix on #18050 in 0.2.8.1-alpha. + Fixes bug 19003, bugfix on 0.2.8.1-alpha. Patch by teor. diff --git a/changes/fallbacks-201604 b/changes/fallbacks-201604 index d61615a..7acefaa 100644 --- a/changes/fallbacks-201604 +++ b/changes/fallbacks-201604 @@ -1,9 +1,9 @@ - o Minor enhancements (fallback directory mirrors): - - Give each fallback the same weight for client selection. - Restrict fallbacks to one per operator. - Report fallback directory detail changes when rebuilding list. - Add new fallback directory mirrors to the whitelist. - Update fallback directories based on the latest OnionOO data. - Many other minor simplifications and fixes. + o Minor features (fallback directory mirrors): + - Give each fallback the same weight for client selection; + restrict fallbacks to one per operator; + report fallback directory detail changes when rebuilding list; + add new fallback directory mirrors to the whitelist; + update fallback directories based on the latest OnionOO data; + and any other minor simplifications and fixes. Closes tasks 17158, 17905, 18749, bug 18689, and fixes part of - bug 18812 on tor 0.2.8.1-alpha; patch by "teor". + bug 18812 on 0.2.8.1-alpha; patch by "teor". diff --git a/changes/feature18483 b/changes/feature18483 index b3c42e6..d0fa8df 100644 --- a/changes/feature18483 +++ b/changes/feature18483 @@ -1,4 +1,4 @@ o Minor features (clients): - Make clients, onion services, and bridge relays always use an encrypted begindir connection for directory requests. - Resolves #18483. Patch by "teor". + Resolves ticket 18483. Patch by "teor". diff --git a/changes/geoip-april2016 b/changes/geoip-april2016 index 4cd03e5..c55aa17 100644 --- a/changes/geoip-april2016 +++ b/changes/geoip-april2016 @@ -1,4 +1,4 @@ - o Minor features: + o Minor features (geoip): - Update geoip and geoip6 to the April 5 2016 Maxmind GeoLite2 Country database. diff --git a/changes/geoip-may2016 b/changes/geoip-may2016 index 3fd42dc..cf78ab1 100644 --- a/changes/geoip-may2016 +++ b/changes/geoip-may2016 @@ -1,4 +1,4 @@ - o Minor features: + o Minor features (geoip): - Update geoip and geoip6 to the May 4 2016 Maxmind GeoLite2 Country database.

1 0

[tor/maint-0.2.8] Fix remaining lintChanges warnings.
by nickm＠torproject.org 17 May '16

17 May '16

commit ff5eb7fc625374c29944b9ab7160b86559ce90a4 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue May 17 11:06:41 2016 -0400 Fix remaining lintChanges warnings. --- changes/bug18460 | 2 +- changes/bug19003 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/changes/bug18460 b/changes/bug18460 index c90ee11..a8c1a19 100644 --- a/changes/bug18460 +++ b/changes/bug18460 @@ -1,4 +1,4 @@ o Minor bugfixes (statistics): - We now include consensus downloads via IPv6 in our directory-request statistics. - Fixes 18460; bugfix on 0.2.3.14-alpha. + Fixes bug 18460; bugfix on 0.2.3.14-alpha. diff --git a/changes/bug19003 b/changes/bug19003 index f05c489..ca94938 100644 --- a/changes/bug19003 +++ b/changes/bug19003 @@ -1,5 +1,5 @@ o Minor bugfixes (small networks): - Allow directories in small networks to bootstrap by skipping DirPort checks when the consensus has no exits. - Fixes bug 19003, bugfix on 0.2.8.1-alpha. + Fixes bug 19003; bugfix on 0.2.8.1-alpha. Patch by teor.

1 0

[tor/master] Resolve lintChanges warnings.
by nickm＠torproject.org 17 May '16

17 May '16

commit e0fb75c349f9646c029d0218e5933e0ca349c702 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue May 17 11:05:57 2016 -0400 Resolve lintChanges warnings. --- changes/bug18286 | 5 +++-- changes/bug18460 | 4 ++-- changes/bug18481 | 2 +- changes/bug18729 | 2 +- changes/bug18816 | 2 +- changes/bug18921 | 2 +- changes/bug18929 | 2 +- changes/bug18943 | 2 +- changes/bug19003 | 2 +- changes/fallbacks-201604 | 16 ++++++++-------- changes/feature18483 | 2 +- changes/geoip-april2016 | 2 +- changes/geoip-may2016 | 2 +- 13 files changed, 23 insertions(+), 22 deletions(-) diff --git a/changes/bug18286 b/changes/bug18286 index 6e9ae3d..e398fb0 100644 --- a/changes/bug18286 +++ b/changes/bug18286 @@ -1,4 +1,5 @@ o Minor features (build): - - Tor now again builds with the recent OpenSSL 1.1 development branch - (tested against 1.1.0-pre4 and 1.1.0-pre5-dev). + - Tor now builds again with the recent OpenSSL 1.1 development branch + (tested against 1.1.0-pre4 and 1.1.0-pre5-dev). Closes ticket 18286. + diff --git a/changes/bug18460 b/changes/bug18460 index 457e5df..c90ee11 100644 --- a/changes/bug18460 +++ b/changes/bug18460 @@ -1,4 +1,4 @@ o Minor bugfixes (statistics): - - Include consensus downloads via IPv6 in directory-request statistics. - Fixes bug 18480; bugfix on 4741aa4 in 0.2.3.14-alpha. + - We now include consensus downloads via IPv6 in our directory-request statistics. + Fixes 18460; bugfix on 0.2.3.14-alpha. diff --git a/changes/bug18481 b/changes/bug18481 index 7fd9e1e..6fd882b 100644 --- a/changes/bug18481 +++ b/changes/bug18481 @@ -2,4 +2,4 @@ - Turn all TestingClientBootstrap* into non-testing torrc options. This changes simply renames them by removing "Testing" in front of them and they do not require TestingTorNetwork to be enabled anymore. Fixes - #18481; bugfix on tor-0.2.8.1-alpha. + bug 18481; bugfix on 0.2.8.1-alpha. diff --git a/changes/bug18729 b/changes/bug18729 index d4312c0..4ec9ca3 100644 --- a/changes/bug18729 +++ b/changes/bug18729 @@ -1,3 +1,3 @@ - o Minor logging changes: + o Minor features (logging): - Stop blasting twelve lines per second from periodic_event_dispatch() at loglevel debug. Resolves ticket 18729; fix on 0.2.8.1-alpha. diff --git a/changes/bug18816 b/changes/bug18816 index 7265f5a..103f816 100644 --- a/changes/bug18816 +++ b/changes/bug18816 @@ -1,4 +1,4 @@ o Minor bugfix (bootstrap): - Consistently use the consensus download schedule for authority certificates. - Resolves ticket 18816; fix on fddb814fe in 0.2.4.13-alpha. + Fixes bug 18816; bugfix on 0.2.4.13-alpha. diff --git a/changes/bug18921 b/changes/bug18921 index 934a604..cdd868a 100644 --- a/changes/bug18921 +++ b/changes/bug18921 @@ -1,4 +1,4 @@ o Major bugfixes (IPv6 bridges): - Fix directory address selection for IPv6 bridges. - Resolves #18921, bugfix on #17840 in 0.2.8.1-alpha. + Fixes bug 18921; bugfix on 0.2.8.1-alpha. Patch by "teor". diff --git a/changes/bug18929 b/changes/bug18929 index f79baca..c607e63 100644 --- a/changes/bug18929 +++ b/changes/bug18929 @@ -1,5 +1,5 @@ o Minor bugfixes (IPv6): - Make directory node selection more reliable, mainly for IPv6-only clients and clients with few reachable addresses. - Resolves #18929, bugfix on #17840 in 0.2.8.1-alpha. + Fixes bug 18929; bugfix on 0.2.8.1-alpha. Patch by "teor". diff --git a/changes/bug18943 b/changes/bug18943 index 53569f0..6bcd868 100644 --- a/changes/bug18943 +++ b/changes/bug18943 @@ -2,5 +2,5 @@ - The SHA3 and SHAKE routines now produce the correct output on Big Endian systems, unbreaking the unit tests. No code calls either algorithm family yet, so this is primarily a build fix. - Closes ticket 18943. + Fixes bug 18943; bugfix on 0.2.8.1-alpha. diff --git a/changes/bug19003 b/changes/bug19003 index d9ef23d..f05c489 100644 --- a/changes/bug19003 +++ b/changes/bug19003 @@ -1,5 +1,5 @@ o Minor bugfixes (small networks): - Allow directories in small networks to bootstrap by skipping DirPort checks when the consensus has no exits. - Resolves #19003, bugfix on #18050 in 0.2.8.1-alpha. + Fixes bug 19003, bugfix on 0.2.8.1-alpha. Patch by teor. diff --git a/changes/fallbacks-201604 b/changes/fallbacks-201604 index d61615a..7acefaa 100644 --- a/changes/fallbacks-201604 +++ b/changes/fallbacks-201604 @@ -1,9 +1,9 @@ - o Minor enhancements (fallback directory mirrors): - - Give each fallback the same weight for client selection. - Restrict fallbacks to one per operator. - Report fallback directory detail changes when rebuilding list. - Add new fallback directory mirrors to the whitelist. - Update fallback directories based on the latest OnionOO data. - Many other minor simplifications and fixes. + o Minor features (fallback directory mirrors): + - Give each fallback the same weight for client selection; + restrict fallbacks to one per operator; + report fallback directory detail changes when rebuilding list; + add new fallback directory mirrors to the whitelist; + update fallback directories based on the latest OnionOO data; + and any other minor simplifications and fixes. Closes tasks 17158, 17905, 18749, bug 18689, and fixes part of - bug 18812 on tor 0.2.8.1-alpha; patch by "teor". + bug 18812 on 0.2.8.1-alpha; patch by "teor". diff --git a/changes/feature18483 b/changes/feature18483 index b3c42e6..d0fa8df 100644 --- a/changes/feature18483 +++ b/changes/feature18483 @@ -1,4 +1,4 @@ o Minor features (clients): - Make clients, onion services, and bridge relays always use an encrypted begindir connection for directory requests. - Resolves #18483. Patch by "teor". + Resolves ticket 18483. Patch by "teor". diff --git a/changes/geoip-april2016 b/changes/geoip-april2016 index 4cd03e5..c55aa17 100644 --- a/changes/geoip-april2016 +++ b/changes/geoip-april2016 @@ -1,4 +1,4 @@ - o Minor features: + o Minor features (geoip): - Update geoip and geoip6 to the April 5 2016 Maxmind GeoLite2 Country database. diff --git a/changes/geoip-may2016 b/changes/geoip-may2016 index 3fd42dc..cf78ab1 100644 --- a/changes/geoip-may2016 +++ b/changes/geoip-may2016 @@ -1,4 +1,4 @@ - o Minor features: + o Minor features (geoip): - Update geoip and geoip6 to the May 4 2016 Maxmind GeoLite2 Country database.

1 0

[tor/master] Fix remaining lintChanges warnings.
by nickm＠torproject.org 17 May '16

17 May '16

commit ff5eb7fc625374c29944b9ab7160b86559ce90a4 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue May 17 11:06:41 2016 -0400 Fix remaining lintChanges warnings. --- changes/bug18460 | 2 +- changes/bug19003 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/changes/bug18460 b/changes/bug18460 index c90ee11..a8c1a19 100644 --- a/changes/bug18460 +++ b/changes/bug18460 @@ -1,4 +1,4 @@ o Minor bugfixes (statistics): - We now include consensus downloads via IPv6 in our directory-request statistics. - Fixes 18460; bugfix on 0.2.3.14-alpha. + Fixes bug 18460; bugfix on 0.2.3.14-alpha. diff --git a/changes/bug19003 b/changes/bug19003 index f05c489..ca94938 100644 --- a/changes/bug19003 +++ b/changes/bug19003 @@ -1,5 +1,5 @@ o Minor bugfixes (small networks): - Allow directories in small networks to bootstrap by skipping DirPort checks when the consensus has no exits. - Fixes bug 19003, bugfix on 0.2.8.1-alpha. + Fixes bug 19003; bugfix on 0.2.8.1-alpha. Patch by teor.

1 0

[tor/master] Merge branch 'maint-0.2.8'
by nickm＠torproject.org 17 May '16

17 May '16

1 0

[tor/release-0.2.8] Resolve lintChanges warnings.
by nickm＠torproject.org 17 May '16

17 May '16

commit e0fb75c349f9646c029d0218e5933e0ca349c702 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue May 17 11:05:57 2016 -0400 Resolve lintChanges warnings. --- changes/bug18286 | 5 +++-- changes/bug18460 | 4 ++-- changes/bug18481 | 2 +- changes/bug18729 | 2 +- changes/bug18816 | 2 +- changes/bug18921 | 2 +- changes/bug18929 | 2 +- changes/bug18943 | 2 +- changes/bug19003 | 2 +- changes/fallbacks-201604 | 16 ++++++++-------- changes/feature18483 | 2 +- changes/geoip-april2016 | 2 +- changes/geoip-may2016 | 2 +- 13 files changed, 23 insertions(+), 22 deletions(-) diff --git a/changes/bug18286 b/changes/bug18286 index 6e9ae3d..e398fb0 100644 --- a/changes/bug18286 +++ b/changes/bug18286 @@ -1,4 +1,5 @@ o Minor features (build): - - Tor now again builds with the recent OpenSSL 1.1 development branch - (tested against 1.1.0-pre4 and 1.1.0-pre5-dev). + - Tor now builds again with the recent OpenSSL 1.1 development branch + (tested against 1.1.0-pre4 and 1.1.0-pre5-dev). Closes ticket 18286. + diff --git a/changes/bug18460 b/changes/bug18460 index 457e5df..c90ee11 100644 --- a/changes/bug18460 +++ b/changes/bug18460 @@ -1,4 +1,4 @@ o Minor bugfixes (statistics): - - Include consensus downloads via IPv6 in directory-request statistics. - Fixes bug 18480; bugfix on 4741aa4 in 0.2.3.14-alpha. + - We now include consensus downloads via IPv6 in our directory-request statistics. + Fixes 18460; bugfix on 0.2.3.14-alpha. diff --git a/changes/bug18481 b/changes/bug18481 index 7fd9e1e..6fd882b 100644 --- a/changes/bug18481 +++ b/changes/bug18481 @@ -2,4 +2,4 @@ - Turn all TestingClientBootstrap* into non-testing torrc options. This changes simply renames them by removing "Testing" in front of them and they do not require TestingTorNetwork to be enabled anymore. Fixes - #18481; bugfix on tor-0.2.8.1-alpha. + bug 18481; bugfix on 0.2.8.1-alpha. diff --git a/changes/bug18729 b/changes/bug18729 index d4312c0..4ec9ca3 100644 --- a/changes/bug18729 +++ b/changes/bug18729 @@ -1,3 +1,3 @@ - o Minor logging changes: + o Minor features (logging): - Stop blasting twelve lines per second from periodic_event_dispatch() at loglevel debug. Resolves ticket 18729; fix on 0.2.8.1-alpha. diff --git a/changes/bug18816 b/changes/bug18816 index 7265f5a..103f816 100644 --- a/changes/bug18816 +++ b/changes/bug18816 @@ -1,4 +1,4 @@ o Minor bugfix (bootstrap): - Consistently use the consensus download schedule for authority certificates. - Resolves ticket 18816; fix on fddb814fe in 0.2.4.13-alpha. + Fixes bug 18816; bugfix on 0.2.4.13-alpha. diff --git a/changes/bug18921 b/changes/bug18921 index 934a604..cdd868a 100644 --- a/changes/bug18921 +++ b/changes/bug18921 @@ -1,4 +1,4 @@ o Major bugfixes (IPv6 bridges): - Fix directory address selection for IPv6 bridges. - Resolves #18921, bugfix on #17840 in 0.2.8.1-alpha. + Fixes bug 18921; bugfix on 0.2.8.1-alpha. Patch by "teor". diff --git a/changes/bug18929 b/changes/bug18929 index f79baca..c607e63 100644 --- a/changes/bug18929 +++ b/changes/bug18929 @@ -1,5 +1,5 @@ o Minor bugfixes (IPv6): - Make directory node selection more reliable, mainly for IPv6-only clients and clients with few reachable addresses. - Resolves #18929, bugfix on #17840 in 0.2.8.1-alpha. + Fixes bug 18929; bugfix on 0.2.8.1-alpha. Patch by "teor". diff --git a/changes/bug18943 b/changes/bug18943 index 53569f0..6bcd868 100644 --- a/changes/bug18943 +++ b/changes/bug18943 @@ -2,5 +2,5 @@ - The SHA3 and SHAKE routines now produce the correct output on Big Endian systems, unbreaking the unit tests. No code calls either algorithm family yet, so this is primarily a build fix. - Closes ticket 18943. + Fixes bug 18943; bugfix on 0.2.8.1-alpha. diff --git a/changes/bug19003 b/changes/bug19003 index d9ef23d..f05c489 100644 --- a/changes/bug19003 +++ b/changes/bug19003 @@ -1,5 +1,5 @@ o Minor bugfixes (small networks): - Allow directories in small networks to bootstrap by skipping DirPort checks when the consensus has no exits. - Resolves #19003, bugfix on #18050 in 0.2.8.1-alpha. + Fixes bug 19003, bugfix on 0.2.8.1-alpha. Patch by teor. diff --git a/changes/fallbacks-201604 b/changes/fallbacks-201604 index d61615a..7acefaa 100644 --- a/changes/fallbacks-201604 +++ b/changes/fallbacks-201604 @@ -1,9 +1,9 @@ - o Minor enhancements (fallback directory mirrors): - - Give each fallback the same weight for client selection. - Restrict fallbacks to one per operator. - Report fallback directory detail changes when rebuilding list. - Add new fallback directory mirrors to the whitelist. - Update fallback directories based on the latest OnionOO data. - Many other minor simplifications and fixes. + o Minor features (fallback directory mirrors): + - Give each fallback the same weight for client selection; + restrict fallbacks to one per operator; + report fallback directory detail changes when rebuilding list; + add new fallback directory mirrors to the whitelist; + update fallback directories based on the latest OnionOO data; + and any other minor simplifications and fixes. Closes tasks 17158, 17905, 18749, bug 18689, and fixes part of - bug 18812 on tor 0.2.8.1-alpha; patch by "teor". + bug 18812 on 0.2.8.1-alpha; patch by "teor". diff --git a/changes/feature18483 b/changes/feature18483 index b3c42e6..d0fa8df 100644 --- a/changes/feature18483 +++ b/changes/feature18483 @@ -1,4 +1,4 @@ o Minor features (clients): - Make clients, onion services, and bridge relays always use an encrypted begindir connection for directory requests. - Resolves #18483. Patch by "teor". + Resolves ticket 18483. Patch by "teor". diff --git a/changes/geoip-april2016 b/changes/geoip-april2016 index 4cd03e5..c55aa17 100644 --- a/changes/geoip-april2016 +++ b/changes/geoip-april2016 @@ -1,4 +1,4 @@ - o Minor features: + o Minor features (geoip): - Update geoip and geoip6 to the April 5 2016 Maxmind GeoLite2 Country database. diff --git a/changes/geoip-may2016 b/changes/geoip-may2016 index 3fd42dc..cf78ab1 100644 --- a/changes/geoip-may2016 +++ b/changes/geoip-may2016 @@ -1,4 +1,4 @@ - o Minor features: + o Minor features (geoip): - Update geoip and geoip6 to the May 4 2016 Maxmind GeoLite2 Country database.

1 0

[tor-browser/tor-browser-45.1.0esr-6.0-1] Regression tests for Bug 17009: Pref to suppress some modifier key events
by gk＠torproject.org 17 May '16

17 May '16

commit b815400e8aae371dcc55141d202ae96155c4c78d Author: Arthur Edelstein <arthuredelstein(a)gmail.com> Date: Wed Dec 23 09:52:05 2015 -0800 Regression tests for Bug 17009: Pref to suppress some modifier key events --- dom/tests/browser/browser.ini | 2 + dom/tests/browser/browser_tor_bug17009.html | 8 +++ dom/tests/browser/browser_tor_bug17009.js | 98 +++++++++++++++++++++++++++++ 3 files changed, 108 insertions(+) diff --git a/dom/tests/browser/browser.ini b/dom/tests/browser/browser.ini index 363758e..bd07b47 100644 --- a/dom/tests/browser/browser.ini +++ b/dom/tests/browser/browser.ini @@ -2,6 +2,7 @@ skip-if = e10s # Bug ?????? - most of these tests fail for currently unknown reasons. support-files = browser_frame_elements.html + browser_tor_bug17009.html page_privatestorageevent.html position.html test-console-api.html @@ -44,3 +45,4 @@ disabled = re-enable when bug 794920 is fixed [browser_xhr_sandbox.js] skip-if= buildapp == 'mulet' [browser_bug1004814.js] +[browser_tor_bug17009.js] diff --git a/dom/tests/browser/browser_tor_bug17009.html b/dom/tests/browser/browser_tor_bug17009.html new file mode 100644 index 0000000..455d547 --- /dev/null +++ b/dom/tests/browser/browser_tor_bug17009.html @@ -0,0 +1,8 @@ +<!DOCTYPE html> +<head> + <meta charset="utf-8"> + <title>Tor Bug 17009 tests</title> +</head> +<body> + Testing that Alt and Shift keydown/keyup events aren't detected in content. +</body> diff --git a/dom/tests/browser/browser_tor_bug17009.js b/dom/tests/browser/browser_tor_bug17009.js new file mode 100644 index 0000000..794baa4 --- /dev/null +++ b/dom/tests/browser/browser_tor_bug17009.js @@ -0,0 +1,98 @@ +"use strict"; + +/*jshint esnext:true */ + +const CONTENT_PAGE = "http://example.com/browser/dom/tests/browser/browser_tor_bug17009.html"; + +// __pushPref(key, value)__. +// Set the given pref to a value. Returns a promise +// that resolves asynchronously when the pref is +// successfully set. +let pushPref = function (key, value) { + return new Promise(resolve => { + SpecialPowers.pushPrefEnv({"set": [[key, value]]}, resolve); + }); +}; + +// __listen(target, eventType, useCapture)__. +// Returns a promise that resolves after a single event +// of eventType is received by the target. +let listen = function (target, eventType, useCapture) { + return new Promise(function (resolve, reject) { + let listenFunction = function (event) { + target.removeEventListener(eventType, listenFunction, useCapture); + resolve(event); + }; + target.addEventListener(eventType, listenFunction, useCapture); + }); +}; + +// __soon()__. +// Wait a little bit before we continue. Returns a promise. +let soon = function () { + return new Promise(resolve => executeSoon(resolve)); +}; + +// __runTests(contentWindow)__. +// The main tests. We test to make sure that, when +// "privacy.suppressModifierKeyEvents" is true, then content +// will not see Alt or Shift keydown or keyup events, +// but chrome will still see those events. +// If the pref is off, then both content and chrome +// should see all events. +let runTests = function* (contentWindow) { + // Check behavior for both non-resistance and resistance. + for (let resistFingerprinting of [false, true]) { + yield pushPref("privacy.resistFingerprinting", resistFingerprinting); + // Check behavior, both non-suppressing and suppressing. + for (let suppressModifiers of [false, true]) { + yield pushPref("privacy.suppressModifierKeyEvents", suppressModifiers); + // Check both keydown and keyup events. + for (let eventType of ["keydown", "keyup"]) { + // Check Alt and Shift keys. + for (let modifierKey of ["Alt", "Shift"]) { + // Listen for a single key event in the content window. + let contentEventPromise = listen(contentWindow, eventType, false); + // Listen for a single key event in the chrome window. + let chromeEventPromise = listen(window, eventType, false); + // Generate a Alt or Shift key event. + EventUtils.synthesizeKey("VK_" + modifierKey.toUpperCase(), + { type : eventType }, contentWindow); + // Generate a dummy "x" key event that will only be handled if + // modifier key is successfully suppressed. + EventUtils.synthesizeKey("x", { type: eventType }, contentWindow); + // Collect the events received in content and chrome. + let contentEvent = yield contentEventPromise; + let chromeEvent = yield chromeEventPromise; + // We should always see the modifier key in chrome, regardless of the + // pref state. + is(chromeEvent.key, modifierKey, + modifierKey + " key should be seen in chrome."); + // If and only if fingerprinting resistance is active and suppression + // is enabled, we should see the dummy "x" key; otherwise we expect + // to see the modifier key as usual. + let expectedContentKey = resistFingerprinting && suppressModifiers + ? "x" : modifierKey; + is(contentEvent.key, expectedContentKey, + expectedContentKey + " key should be seen in content."); + } + } + } + } +}; + +// Run tests asynchronously to make testing event handling straightforward. +add_task(function* () { + // Set up a content tab and select it. + let tab = gBrowser.addTab(CONTENT_PAGE), + browser = gBrowser.getBrowserForTab(tab); + gBrowser.selectedTab = tab; + + // Wait for tab to be completely loaded, then run the tests. + yield listen(browser, "DOMContentLoaded", false); + yield soon(); + yield runTests(gBrowser.contentWindow); + + // cleanup + gBrowser.removeTab(tab); +});

1 0

[tor-browser/tor-browser-45.1.0esr-6.0-1] Regression tests for Bug 15646: Prevent keyboard layout fingerprinting in KeyboardEvent
by gk＠torproject.org 17 May '16

17 May '16

commit de5346adae7452c79820958873cf6eca473f537f Author: Arthur Edelstein <arthuredelstein(a)gmail.com> Date: Tue Dec 22 12:35:17 2015 -0800 Regression tests for Bug 15646: Prevent keyboard layout fingerprinting in KeyboardEvent --- dom/events/test/mochitest.ini | 1 + dom/events/test/test_tor_bug15646.html | 159 +++++++++++++++++++++++++++++++++ 2 files changed, 160 insertions(+) diff --git a/dom/events/test/mochitest.ini b/dom/events/test/mochitest.ini index e23b950..e7fb89c 100644 --- a/dom/events/test/mochitest.ini +++ b/dom/events/test/mochitest.ini @@ -192,3 +192,4 @@ support-files = [test_bug1013412.html] skip-if = buildapp == 'b2g' # no wheel events on b2g [test_dom_activate_event.html] +[test_tor_bug15646.html] diff --git a/dom/events/test/test_tor_bug15646.html b/dom/events/test/test_tor_bug15646.html new file mode 100644 index 0000000..463781f --- /dev/null +++ b/dom/events/test/test_tor_bug15646.html @@ -0,0 +1,159 @@ +<!DOCTYPE HTML> +<html> + +<head> + <title>Test for Bug 15646</title> + <script type="application/javascript" src="/tests/SimpleTest/SimpleTest.js"></script> + <script type="application/javascript" src="/tests/SimpleTest/SpawnTask.js"></script> + <link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css"/> +</head> +<body> +<a target="_blank" href="https://trac.torproject.org/15466">Tor Bug 15646</a> +<p id="display"></p> +<div id="content" style="display: none"> + +</div> +<pre id="test"> +</pre> +<span id="testTarget" style="border: 1px solid black;">testTarget</span> +<script type="application/javascript;version=1.7"> + SimpleTest.waitForExplicitFinish(); + let miscKeyData = [ + ["Alt", "AltLeft", 18], + ["ArrowDown", "ArrowDown", 40], + ["ArrowLeft", "ArrowLeft", 37], + ["ArrowRight", "ArrowRight", 39], + ["ArrowUp", "ArrowUp", 38], + ["Backspace", "Backspace", 8], + ["CapsLock", "CapsLock", 20], + ["ContextMenu", "ContextMenu", 93], + ["Control", "ControlLeft", 17], + ["Delete", "Delete", 46], + ["End", "End", 35], + ["Enter", "Enter", 13], + ["Escape", "Escape", 27], + ["Help", "Help", 6], + ["Home", "Home", 36], + ["Insert", "Insert", 45], + ["Meta", "OSLeft", 91], + ["PageDown", "PageDown", 34], + ["PageUp", "PageUp", 33], + ["Pause", "Pause", 19], + ["PrintScreen", "PrintScreen", 44], + ["ScrollLock", "ScrollLock", 145], + ["Shift", "ShiftLeft", 16], + ["Tab", "Tab", 9], + [" ", "Space", 32], + [",", "Comma", 188], + [".", "Period", 190], + ["/", "Slash", 191], + [";", "Semicolon", 59], + ["'", "Quote", 222], + ["[", "BracketLeft", 219], + ["]", "BracketRight", 221], + ["`", "Backquote", 192], + ["\\", "Backslash", 220], + ["-", "Minus", 173], + ["=", "Equal", 61], + ]; + let uppers = [], lowers = []; + for (let i = 65; i < 91; ++i) { + let upperChar = String.fromCharCode(i); + lowers.push([upperChar.toLowerCase(), "Key" + upperChar, i]); + uppers.push([upperChar, "Key" + upperChar, i]); + } + let fnKeys = []; + for (let i = 1; i < 25; ++i) { + let keyName = "F" + i, + keyCode = i + 111; + fnKeys.push([keyName, keyName, keyCode]); + } + let digits = []; + for (let i = 0; i < 10; ++i) { + let keyName = "" + i, + keyCode = 48 + i; + digits.push([keyName, "Digit" + keyName, keyCode]); + } + let allKeyData = miscKeyData.concat(lowers).concat(fnKeys).concat(digits); + let pushPref = function (key, value) { + return new Promise(resolve => { + SpecialPowers.pushPrefEnv({"set": [[key, value]]}, resolve); + }); + }; + let miscShiftKeyData = [ + ["!", "Digit1", 49], + ["@", "Digit2", 50], + ["#", "Digit3", 51], + ["$", "Digit4", 52], + ["%", "Digit5", 53], + ["^", "Digit6", 54], + ["&", "Digit7", 55], + ["*", "Digit8", 56], + ["(", "Digit9", 57], + [")", "Digit0", 48], + ["<", "Comma", 188], + [">", "Period", 190], + ["?", "Slash", 191], + [":", "Semicolon", 59], + ["\"", "Quote", 222], + ["{", "BracketLeft", 219], + ["}", "BracketRight", 221], + ["~", "Backquote", 192], + ["|", "Backslash", 220], + ["_", "Minus", 173], + ["+", "Equal", 61], + ]; + let allShiftKeyData = miscShiftKeyData.concat(uppers); + + // __dispatchAndListen(target, eventObject)__. + // Dispatch the given event to the target object. + // Return a promise that resolves to the event when + // that event is received by an event listener. + let dispatchAndListen = function (target, eventObject) { + let eventType = eventObject.type; + return new Promise(function (resolve, reject) { + let listenFunction = function (event) { + target.removeEventListener(eventType, listenFunction); + resolve(event); + }; + target.addEventListener(eventType, listenFunction); + target.dispatchEvent(eventObject); + }); + }; + + // Run tests asynchronously. + spawnTask(function* () { + for (let keyData of [allKeyData, allShiftKeyData]) { + for (let resistFingerprinting of [false, true]) { + let expectedShiftKey = keyData === allShiftKeyData && resistFingerprinting; + yield pushPref("privacy.resistFingerprinting", resistFingerprinting); + for (let [keyName, code, keyCode] of keyData) { + let keyboardEvent = new KeyboardEvent("keydown", { key : keyName, altKey : true, location : 2 }); + let receivedEvent = yield dispatchAndListen(document.body, keyboardEvent); + let expectedKeyCode = resistFingerprinting ? keyCode : 0; + is(receivedEvent.keyCode, expectedKeyCode, + "Event.keyCode should be " + expectedKeyCode); + is(receivedEvent.shiftKey, expectedShiftKey, + "Event.shiftKey should be " + expectedShiftKey); + if (expectedShiftKey) { + ok(!receivedEvent.altKey, + "Alt should be suppressed for fake shift keys."); + } + if (resistFingerprinting) { + let expectedCode = code; + is(receivedEvent.code, expectedCode, + "Event.code should be " + expectedCode); + ok(receivedEvent.location === 0 || receivedEvent.location === 1, + "Event.location should be 0 or 1."); + } + } + } + } + SimpleTest.finish(); + }); + +</script> +</body> +</html>

1 0