August 2025 - tor-commits - lists.torproject.org

[Git][tpo/applications/tor-browser][base-browser-140.1.0esr-15.0-1] BB 43864: Modify the urlbar for Base Browser.
by henry (＠henry) 05 Aug '25

05 Aug '25

henry pushed to branch base-browser-140.1.0esr-15.0-1 at The Tor Project / Applications / Tor Browser Commits: 1d477c7c by henry at 2025-08-05T15:33:07+00:00 BB 43864: Modify the urlbar for Base Browser. (cherry picked from commit 6167738479a9508101c62d2114939c3aa3a5e482) Co-authored-by: Henry Wilkes <henry(a)torproject.org> - - - - - 2 changed files: - browser/components/urlbar/QuickActionsLoaderDefault.sys.mjs - browser/components/urlbar/SearchModeSwitcher.sys.mjs Changes: ===================================== browser/components/urlbar/QuickActionsLoaderDefault.sys.mjs ===================================== @@ -13,6 +13,7 @@ ChromeUtils.defineESModuleGetters(lazy, { ScreenshotsUtils: "resource:///modules/ScreenshotsUtils.sys.mjs", ActionsProviderQuickActions: "resource:///modules/ActionsProviderQuickActions.sys.mjs", + PrivateBrowsingUtils: "resource://gre/modules/PrivateBrowsingUtils.sys.mjs", }); import { AppConstants } from "resource://gre/modules/AppConstants.sys.mjs"; @@ -78,6 +79,9 @@ const DEFAULT_ACTIONS = { icon: "chrome://mozapps/skin/extensions/category-extensions.svg", label: "quickactions-addons", onPick: openAddonsUrl("addons://discover/"), + // Hide in base-browser, since we don't want to open extensions + // "recommendations" tab. tor-browser#43864. + disabled: () => true, }, bookmarks: { l10nCommands: ["quickactions-cmd-bookmarks", "quickactions-bookmarks2"], @@ -100,6 +104,12 @@ const DEFAULT_ACTIONS = { .document.getElementById("Tools:Sanitize") .doCommand(); }, + // Disable in permanent private browsing. tor-browser#43864. + // NOTE: This should also be disabled in private windows, but we don't have + // access to a Window element to check. See mozilla bug 1980912. + disabled: () => { + return lazy.PrivateBrowsingUtils.permanentPrivateBrowsing; + }, }, downloads: { l10nCommands: ["quickactions-cmd-downloads"], @@ -112,13 +122,18 @@ const DEFAULT_ACTIONS = { icon: "chrome://mozapps/skin/extensions/category-extensions.svg", label: "quickactions-extensions", onPick: openAddonsUrl("addons://list/extension"), + // Hide in base-browser since we do not want to encourage users to change + // their extensions/addons. tor-browser#43864. + disabled: () => true, }, help: { l10nCommands: ["quickactions-cmd-help"], icon: "chrome://global/skin/icons/help.svg", label: "quickactions-help", + // Open the base-browser support/help page, rather than Firefox's. + // tor-browser#43864. onPick: openUrlFun( - "https://support.mozilla.org/products/firefox?as=u&utm_source=inproduct" + Services.prefs.getStringPref("browser.base-browser-support-url", "") ), }, firefoxview: { @@ -128,6 +143,9 @@ const DEFAULT_ACTIONS = { onPick: () => { lazy.BrowserWindowTracker.getTopWindow().FirefoxViewHandler.openTab(); }, + // Hide in base-browser since firefoxview is disabled. + // tor-browser#43864 and tor-browser#42037. + disabled: () => true, }, inspect: { l10nCommands: ["quickactions-cmd-inspector2"], @@ -311,6 +329,9 @@ export class QuickActionsLoaderDefault { let keys = Object.keys(DEFAULT_ACTIONS); for (const key of keys) { let actionData = DEFAULT_ACTIONS[key]; + if (actionData.disabled?.()) { + continue; + } let messages = await lazy.gFluentStrings.formatMessages( actionData.l10nCommands.map(id => ({ id })) ); ===================================== browser/components/urlbar/SearchModeSwitcher.sys.mjs ===================================== @@ -413,6 +413,15 @@ export class SearchModeSwitcher { if (!lazy.UrlbarPrefs.get(pref)) { continue; } + if ( + source === lazy.UrlbarUtils.RESULT_SOURCE.HISTORY && + lazy.PrivateBrowsingUtils.permanentPrivateBrowsing + ) { + // Do not show the search history option in PBM. tor-browser#43864. + // Although, it can still be triggered with "^" restrict keyword or + // through an app menu item. See also mozilla bug 1980928. + continue; + } let name = lazy.UrlbarUtils.getResultSourceName(source); let { icon } = await this.#getDisplayedEngineDetails({ source, View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/1d477c7… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/1d477c7… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-140.1.0esr-15.0-1] fixup! BB 42583: Modify moz-support-link for Base Browser.
by henry (＠henry) 05 Aug '25

05 Aug '25

henry pushed to branch base-browser-140.1.0esr-15.0-1 at The Tor Project / Applications / Tor Browser Commits: 36a296b5 by henry at 2025-08-05T15:32:09+00:00 fixup! BB 42583: Modify moz-support-link for Base Browser. TB 43864: Move moz-support-link "preferences" patch to base-browser. (cherry picked from commit be0e53370b89b47cebec8bdc38a3c2385773f249) Co-authored-by: Henry Wilkes <henry(a)torproject.org> - - - - - 1 changed file: - toolkit/content/widgets/moz-support-link/moz-support-link.mjs Changes: ===================================== toolkit/content/widgets/moz-support-link/moz-support-link.mjs ===================================== @@ -125,6 +125,22 @@ export default class MozSupportLink extends HTMLAnchorElement { return; } let supportPage = this.getAttribute("support-page") ?? ""; + // For base-browser we sometimes want to override firefox support links with + // our own. + // See tor-browser#40899. + switch (supportPage) { + case "preferences": + // Shown twice in preferences, both as `{ -brand-short-name } Support`. + // Instead of directing to support for preferences, we link to general + // tor browser support. + // See tor-browser#32092. + this.href = Services.prefs.getStringPref( + "browser.base-browser-support-url", + "" + ); + return; + // Fall through to support.mozilla.org + } let base = MozSupportLink.SUPPORT_URL + supportPage; this.href = this.hasAttribute("utm-content") ? formatUTMParams(this.getAttribute("utm-content"), base) View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/36a296b… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/36a296b… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-140.1.0esr-15.0-1] 4 commits: dropme! fixup! TB 42583: Modify moz-support-link for Tor Browser.
by henry (＠henry) 05 Aug '25

05 Aug '25

henry pushed to branch tor-browser-140.1.0esr-15.0-1 at The Tor Project / Applications / Tor Browser Commits: f5edc9e2 by Henry Wilkes at 2025-08-05T15:30:39+00:00 dropme! fixup! TB 42583: Modify moz-support-link for Tor Browser. TB 43864: Move moz-support-link "preferences" patch out of tor-browser commits. Should be dropped at the next rebase. - - - - - be0e5337 by Henry Wilkes at 2025-08-05T15:30:39+00:00 fixup! BB 42583: Modify moz-support-link for Base Browser. TB 43864: Move moz-support-link "preferences" patch to base-browser. - - - - - 26f33db1 by Henry Wilkes at 2025-08-05T15:30:39+00:00 fixup! TB 40562: Added Tor Browser preferences to 000-tor-browser.js TB 43864: Move to Tor Browser help URL to preferences. - - - - - 61677384 by Henry Wilkes at 2025-08-05T15:30:39+00:00 BB 43864: Modify the urlbar for Base Browser. - - - - - 4 changed files: - browser/app/profile/000-tor-browser.js - browser/components/urlbar/QuickActionsLoaderDefault.sys.mjs - browser/components/urlbar/SearchModeSwitcher.sys.mjs - toolkit/content/widgets/moz-support-link/moz-support-link.mjs Changes: ===================================== browser/app/profile/000-tor-browser.js ===================================== @@ -48,6 +48,9 @@ pref("extensions.torbutton.use_nontor_proxy", false); // Browser home page: pref("browser.startup.homepage", "about:tor"); +// General browser support url. tor-browser#43864 and tor-browser#40899. +pref("browser.base-browser-support-url", "https://support.torproject.org/tbb"); + // tor-browser#40701: Add new download warning pref("browser.download.showTorWarning", true); ===================================== browser/components/urlbar/QuickActionsLoaderDefault.sys.mjs ===================================== @@ -13,6 +13,7 @@ ChromeUtils.defineESModuleGetters(lazy, { ScreenshotsUtils: "resource:///modules/ScreenshotsUtils.sys.mjs", ActionsProviderQuickActions: "resource:///modules/ActionsProviderQuickActions.sys.mjs", + PrivateBrowsingUtils: "resource://gre/modules/PrivateBrowsingUtils.sys.mjs", }); import { AppConstants } from "resource://gre/modules/AppConstants.sys.mjs"; @@ -78,6 +79,9 @@ const DEFAULT_ACTIONS = { icon: "chrome://mozapps/skin/extensions/category-extensions.svg", label: "quickactions-addons", onPick: openAddonsUrl("addons://discover/"), + // Hide in base-browser, since we don't want to open extensions + // "recommendations" tab. tor-browser#43864. + disabled: () => true, }, bookmarks: { l10nCommands: ["quickactions-cmd-bookmarks", "quickactions-bookmarks2"], @@ -100,6 +104,12 @@ const DEFAULT_ACTIONS = { .document.getElementById("Tools:Sanitize") .doCommand(); }, + // Disable in permanent private browsing. tor-browser#43864. + // NOTE: This should also be disabled in private windows, but we don't have + // access to a Window element to check. See mozilla bug 1980912. + disabled: () => { + return lazy.PrivateBrowsingUtils.permanentPrivateBrowsing; + }, }, downloads: { l10nCommands: ["quickactions-cmd-downloads"], @@ -112,13 +122,18 @@ const DEFAULT_ACTIONS = { icon: "chrome://mozapps/skin/extensions/category-extensions.svg", label: "quickactions-extensions", onPick: openAddonsUrl("addons://list/extension"), + // Hide in base-browser since we do not want to encourage users to change + // their extensions/addons. tor-browser#43864. + disabled: () => true, }, help: { l10nCommands: ["quickactions-cmd-help"], icon: "chrome://global/skin/icons/help.svg", label: "quickactions-help", + // Open the base-browser support/help page, rather than Firefox's. + // tor-browser#43864. onPick: openUrlFun( - "https://support.mozilla.org/products/firefox?as=u&utm_source=inproduct" + Services.prefs.getStringPref("browser.base-browser-support-url", "") ), }, firefoxview: { @@ -128,6 +143,9 @@ const DEFAULT_ACTIONS = { onPick: () => { lazy.BrowserWindowTracker.getTopWindow().FirefoxViewHandler.openTab(); }, + // Hide in base-browser since firefoxview is disabled. + // tor-browser#43864 and tor-browser#42037. + disabled: () => true, }, inspect: { l10nCommands: ["quickactions-cmd-inspector2"], @@ -311,6 +329,9 @@ export class QuickActionsLoaderDefault { let keys = Object.keys(DEFAULT_ACTIONS); for (const key of keys) { let actionData = DEFAULT_ACTIONS[key]; + if (actionData.disabled?.()) { + continue; + } let messages = await lazy.gFluentStrings.formatMessages( actionData.l10nCommands.map(id => ({ id })) ); ===================================== browser/components/urlbar/SearchModeSwitcher.sys.mjs ===================================== @@ -413,6 +413,15 @@ export class SearchModeSwitcher { if (!lazy.UrlbarPrefs.get(pref)) { continue; } + if ( + source === lazy.UrlbarUtils.RESULT_SOURCE.HISTORY && + lazy.PrivateBrowsingUtils.permanentPrivateBrowsing + ) { + // Do not show the search history option in PBM. tor-browser#43864. + // Although, it can still be triggered with "^" restrict keyword or + // through an app menu item. See also mozilla bug 1980928. + continue; + } let name = lazy.UrlbarUtils.getResultSourceName(source); let { icon } = await this.#getDisplayedEngineDetails({ source, ===================================== toolkit/content/widgets/moz-support-link/moz-support-link.mjs ===================================== @@ -113,7 +113,7 @@ export default class MozSupportLink extends HTMLAnchorElement { return; } let supportPage = this.getAttribute("support-page") ?? ""; - // For tor-browser we sometimes want to override firefox support links with + // For base-browser we sometimes want to override firefox support links with // our own. // See tor-browser#40899. switch (supportPage) { @@ -122,7 +122,10 @@ export default class MozSupportLink extends HTMLAnchorElement { // Instead of directing to support for preferences, we link to general // tor browser support. // See tor-browser#32092. - this.href = "https://support.torproject.org/tbb"; + this.href = Services.prefs.getStringPref( + "browser.base-browser-support-url", + "" + ); return; // Fall through to support.mozilla.org } View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/17f8c4… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/17f8c4… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.26.0esr-13.5-1] Bug 43912: Make xslt:sort obey spoof English.
by Pier Angelo Vendrame (＠pierov) 05 Aug '25

05 Aug '25

Pier Angelo Vendrame pushed to branch tor-browser-115.26.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: 5e052e8c by Pier Angelo Vendrame at 2025-08-05T16:32:16+02:00 Bug 43912: Make xslt:sort obey spoof English. - - - - - 1 changed file: - dom/xslt/xslt/txNodeSorter.cpp Changes: ===================================== dom/xslt/xslt/txNodeSorter.cpp ===================================== @@ -76,6 +76,9 @@ nsresult txNodeSorter::addSortElement(Expr* aSelectExpr, Expr* aLangExpr, rv = aLangExpr->evaluateToString(aContext, lang); NS_ENSURE_SUCCESS(rv, rv); } + if (lang.IsEmpty() && nsContentUtils::SpoofLocaleEnglish()) { + lang.AssignLiteral("en-US"); + } // Case-order bool upperFirst = false; View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/5e052e8… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/5e052e8… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.13.0esr-14.5-1] Bug 1979608. r=hsivonen
by Pier Angelo Vendrame (＠pierov) 05 Aug '25

05 Aug '25

Pier Angelo Vendrame pushed to branch mullvad-browser-128.13.0esr-14.5-1 at The Tor Project / Applications / Mullvad Browser Commits: 3f58a973 by Pier Angelo Vendrame at 2025-08-05T16:57:44+02:00 Bug 1979608. r=hsivonen Differential Revision: https://phabricator.services.mozilla.com/D258859 - - - - - 1 changed file: - dom/xslt/xslt/txNodeSorter.cpp Changes: ===================================== dom/xslt/xslt/txNodeSorter.cpp ===================================== @@ -77,9 +77,10 @@ nsresult txNodeSorter::addSortElement(Expr* aSelectExpr, Expr* aLangExpr, if (aLangExpr) { rv = aLangExpr->evaluateToString(aContext, lang); NS_ENSURE_SUCCESS(rv, rv); - } else if (aContext->getContextNode() - .OwnerDoc() - ->ShouldResistFingerprinting(RFPTarget::JSLocale)) { + } + if (lang.IsEmpty() && + aContext->getContextNode().OwnerDoc()->ShouldResistFingerprinting( + RFPTarget::JSLocale)) { CopyUTF8toUTF16(nsRFPService::GetSpoofedJSLocale(), lang); } View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/3f5… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/3f5… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-128.13.0esr-14.5-1] Bug 1979608. r=hsivonen
by Pier Angelo Vendrame (＠pierov) 05 Aug '25

05 Aug '25

Pier Angelo Vendrame pushed to branch base-browser-128.13.0esr-14.5-1 at The Tor Project / Applications / Tor Browser Commits: 19f74a4d by Pier Angelo Vendrame at 2025-08-05T16:57:22+02:00 Bug 1979608. r=hsivonen Differential Revision: https://phabricator.services.mozilla.com/D258859 - - - - - 1 changed file: - dom/xslt/xslt/txNodeSorter.cpp Changes: ===================================== dom/xslt/xslt/txNodeSorter.cpp ===================================== @@ -77,9 +77,10 @@ nsresult txNodeSorter::addSortElement(Expr* aSelectExpr, Expr* aLangExpr, if (aLangExpr) { rv = aLangExpr->evaluateToString(aContext, lang); NS_ENSURE_SUCCESS(rv, rv); - } else if (aContext->getContextNode() - .OwnerDoc() - ->ShouldResistFingerprinting(RFPTarget::JSLocale)) { + } + if (lang.IsEmpty() && + aContext->getContextNode().OwnerDoc()->ShouldResistFingerprinting( + RFPTarget::JSLocale)) { CopyUTF8toUTF16(nsRFPService::GetSpoofedJSLocale(), lang); } View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/19f74a4… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/19f74a4… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.13.0esr-14.5-1] Bug 1979608. r=hsivonen
by Pier Angelo Vendrame (＠pierov) 05 Aug '25

05 Aug '25

Pier Angelo Vendrame pushed to branch tor-browser-128.13.0esr-14.5-1 at The Tor Project / Applications / Tor Browser Commits: 749092a5 by Pier Angelo Vendrame at 2025-08-05T16:56:46+02:00 Bug 1979608. r=hsivonen Differential Revision: https://phabricator.services.mozilla.com/D258859 - - - - - 1 changed file: - dom/xslt/xslt/txNodeSorter.cpp Changes: ===================================== dom/xslt/xslt/txNodeSorter.cpp ===================================== @@ -77,9 +77,10 @@ nsresult txNodeSorter::addSortElement(Expr* aSelectExpr, Expr* aLangExpr, if (aLangExpr) { rv = aLangExpr->evaluateToString(aContext, lang); NS_ENSURE_SUCCESS(rv, rv); - } else if (aContext->getContextNode() - .OwnerDoc() - ->ShouldResistFingerprinting(RFPTarget::JSLocale)) { + } + if (lang.IsEmpty() && + aContext->getContextNode().OwnerDoc()->ShouldResistFingerprinting( + RFPTarget::JSLocale)) { CopyUTF8toUTF16(nsRFPService::GetSpoofedJSLocale(), lang); } View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/749092a… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/749092a… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-140.1.0esr-15.0-1] Bug 1979608. r=hsivonen
by Pier Angelo Vendrame (＠pierov) 05 Aug '25

05 Aug '25

Pier Angelo Vendrame pushed to branch mullvad-browser-140.1.0esr-15.0-1 at The Tor Project / Applications / Mullvad Browser Commits: 6ed66bd3 by Pier Angelo Vendrame at 2025-08-05T16:55:44+02:00 Bug 1979608. r=hsivonen Differential Revision: https://phabricator.services.mozilla.com/D258859 - - - - - 1 changed file: - dom/xslt/xslt/txNodeSorter.cpp Changes: ===================================== dom/xslt/xslt/txNodeSorter.cpp ===================================== @@ -77,9 +77,10 @@ nsresult txNodeSorter::addSortElement(Expr* aSelectExpr, Expr* aLangExpr, if (aLangExpr) { rv = aLangExpr->evaluateToString(aContext, lang); NS_ENSURE_SUCCESS(rv, rv); - } else if (aContext->getContextNode() - .OwnerDoc() - ->ShouldResistFingerprinting(RFPTarget::JSLocale)) { + } + if (lang.IsEmpty() && + aContext->getContextNode().OwnerDoc()->ShouldResistFingerprinting( + RFPTarget::JSLocale)) { CopyUTF8toUTF16(nsRFPService::GetSpoofedJSLocale(), lang); } View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/6ed… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/6ed… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-140.1.0esr-15.0-1] Bug 1979608. r=hsivonen
by Pier Angelo Vendrame (＠pierov) 05 Aug '25

05 Aug '25

Pier Angelo Vendrame pushed to branch base-browser-140.1.0esr-15.0-1 at The Tor Project / Applications / Tor Browser Commits: 5ff48f30 by Pier Angelo Vendrame at 2025-08-05T16:55:01+02:00 Bug 1979608. r=hsivonen Differential Revision: https://phabricator.services.mozilla.com/D258859 - - - - - 1 changed file: - dom/xslt/xslt/txNodeSorter.cpp Changes: ===================================== dom/xslt/xslt/txNodeSorter.cpp ===================================== @@ -77,9 +77,10 @@ nsresult txNodeSorter::addSortElement(Expr* aSelectExpr, Expr* aLangExpr, if (aLangExpr) { rv = aLangExpr->evaluateToString(aContext, lang); NS_ENSURE_SUCCESS(rv, rv); - } else if (aContext->getContextNode() - .OwnerDoc() - ->ShouldResistFingerprinting(RFPTarget::JSLocale)) { + } + if (lang.IsEmpty() && + aContext->getContextNode().OwnerDoc()->ShouldResistFingerprinting( + RFPTarget::JSLocale)) { CopyUTF8toUTF16(nsRFPService::GetSpoofedJSLocale(), lang); } View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/5ff48f3… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/5ff48f3… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 41517: Add morgan's key to the setup account on the signing machines
by morgan (＠morgan) 05 Aug '25

05 Aug '25

morgan pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: ca3c9880 by Nicolas Vigier at 2025-08-05T14:52:22+00:00 Bug 41517: Add morgan's key to the setup account on the signing machines - - - - - 1 changed file: - tools/signing/machines-setup/setup-signing-machine Changes: ===================================== tools/signing/machines-setup/setup-signing-machine ===================================== @@ -70,6 +70,7 @@ install_packages sudo vim tmux gnupg create_user setup authorized_keys setup boklm-yk1.pub +authorized_keys setup morgan.pub mkdir -p /signing chmod 0755 /signing chown setup /signing View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/c… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/c… You're receiving this email because of your account on gitlab.torproject.org.

1 0