August 2025 - tor-commits - lists.torproject.org

[Git][tpo/applications/mullvad-browser][mullvad-browser-140.2.0esr-15.0-1] 4 commits: fixup! BB 31740: Remove some unnecessary RemoteSettings instances
by Pier Angelo Vendrame (＠pierov) 20 Aug '25

20 Aug '25

Pier Angelo Vendrame pushed to branch mullvad-browser-140.2.0esr-15.0-1 at The Tor Project / Applications / Mullvad Browser Commits: 46629939 by Pier Angelo Vendrame at 2025-08-20T18:03:50+02:00 fixup! BB 31740: Remove some unnecessary RemoteSettings instances BB 43795: Restore the URL classifier XPCOM components. We are not really interested in removing them. We're interested in them not calling Mozilla. However, we have a central patch for RemoteSettings, so we do not need to patch the single user. Or, if we did, at least we should patch UrlClassifierExceptionListService where it creates its RemoteSettings instance. - - - - - cc561c52 by Pier Angelo Vendrame at 2025-08-20T18:03:51+02:00 fixup! BB 31740: Remove some unnecessary RemoteSettings instances BB 43795: Restore the URL classifier XPCOM components. Remove this page as part of another commit. This comit should go away automatically at the next rebase. - - - - - 2164237e by Pier Angelo Vendrame at 2025-08-20T18:03:52+02:00 fixup! BB 42716: Disable unwanted about: pages BB 43795: Restore the URL classifier XPCOM components. Move the commit where we disable about:urlclassifier. - - - - - 673df9af by Pier Angelo Vendrame at 2025-08-20T18:03:52+02:00 fixup! BB 42730: Patch RemoteSettings to use only local dumps as a data source Make explicit that blanking REMOTE_SETTINGS_SERVER_URL is our change. - - - - - 4 changed files: - docshell/base/nsAboutRedirector.cpp - netwerk/url-classifier/UrlClassifierFeatureBase.cpp - netwerk/url-classifier/components.conf - toolkit/modules/AppConstants.sys.mjs Changes: ===================================== docshell/base/nsAboutRedirector.cpp ===================================== @@ -220,6 +220,8 @@ static const RedirEntry kRedirMap[] = { nsIAboutModule::HIDE_FROM_ABOUTABOUT}, #endif #ifndef BASE_BROWSER_VERSION + // We disable safe browsing and the data update mechanisms. So this page + // will be non-functional or at least unreliable. {"url-classifier", "chrome://global/content/aboutUrlClassifier.xhtml", nsIAboutModule::ALLOW_SCRIPT}, #endif ===================================== netwerk/url-classifier/UrlClassifierFeatureBase.cpp ===================================== @@ -80,7 +80,7 @@ void UrlClassifierFeatureBase::InitializePreferences() { nsCOMPtr<nsIUrlClassifierExceptionListService> exceptionListService = do_GetService("@mozilla.org/url-classifier/exception-list-service;1"); - if (!exceptionListService) { + if (NS_WARN_IF(!exceptionListService)) { return; } ===================================== netwerk/url-classifier/components.conf ===================================== @@ -13,4 +13,24 @@ Classes = [ 'constructor': 'mozilla::net::ChannelClassifierService::GetSingleton', 'headers': ['mozilla/net/ChannelClassifierService.h'], }, + { + 'cid': '{b9f4fd03-9d87-4bfd-9958-85a821750ddc}', + 'contract_ids': ['@mozilla.org/url-classifier/exception-list-service;1'], + 'esModule': 'resource://gre/modules/UrlClassifierExceptionListService.sys.mjs', + 'constructor': 'UrlClassifierExceptionListService', + }, + { + 'cid': '{8753A413-3ED6-4A61-A1DC-B31A7E69B796}', + 'interfaces': ['nsIUrlClassifierExceptionListEntry'], + 'headers': ['mozilla/net/UrlClassifierExceptionListEntry.h'], + 'type': 'mozilla::net::UrlClassifierExceptionListEntry', + 'contract_ids': ['@mozilla.org/url-classifier/exception-list-entry;1'], + }, + { + 'cid': '{807535BF-018E-4300-B8D3-4A6405FB9F65}', + 'interfaces': ['nsIUrlClassifierExceptionList'], + 'headers': ['mozilla/net/UrlClassifierExceptionList.h'], + 'type': 'mozilla::net::UrlClassifierExceptionList', + 'contract_ids': ['@mozilla.org/url-classifier/exception-list;1'], + }, ] ===================================== toolkit/modules/AppConstants.sys.mjs ===================================== @@ -210,10 +210,12 @@ export var AppConstants = Object.freeze({ ENABLE_WEBDRIVER: @ENABLE_WEBDRIVER_BOOL@, REMOTE_SETTINGS_SERVER_URL: -#ifdef MOZ_THUNDERBIRD +#if defined(BASE_BROWSER_VERSION) + "", +#elif defined(MOZ_THUNDERBIRD) "https://thunderbird-settings.thunderbird.net/v1", #else - "", + "https://firefox.settings.services.mozilla.com/v1", #endif REMOTE_SETTINGS_VERIFY_SIGNATURE: View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/dd… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/dd… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-140.2.0esr-15.0-1] 4 commits: fixup! BB 31740: Remove some unnecessary RemoteSettings instances
by Pier Angelo Vendrame (＠pierov) 20 Aug '25

20 Aug '25

Pier Angelo Vendrame pushed to branch base-browser-140.2.0esr-15.0-1 at The Tor Project / Applications / Tor Browser Commits: 978afe83 by Pier Angelo Vendrame at 2025-08-20T18:01:38+02:00 fixup! BB 31740: Remove some unnecessary RemoteSettings instances BB 43795: Restore the URL classifier XPCOM components. We are not really interested in removing them. We're interested in them not calling Mozilla. However, we have a central patch for RemoteSettings, so we do not need to patch the single user. Or, if we did, at least we should patch UrlClassifierExceptionListService where it creates its RemoteSettings instance. - - - - - f183749f by Pier Angelo Vendrame at 2025-08-20T18:01:40+02:00 fixup! BB 31740: Remove some unnecessary RemoteSettings instances BB 43795: Restore the URL classifier XPCOM components. Remove this page as part of another commit. This comit should go away automatically at the next rebase. - - - - - 72840c42 by Pier Angelo Vendrame at 2025-08-20T18:01:40+02:00 fixup! BB 42716: Disable unwanted about: pages BB 43795: Restore the URL classifier XPCOM components. Move the commit where we disable about:urlclassifier. - - - - - 227d47ef by Pier Angelo Vendrame at 2025-08-20T18:01:41+02:00 fixup! BB 42730: Patch RemoteSettings to use only local dumps as a data source Make explicit that blanking REMOTE_SETTINGS_SERVER_URL is our change. - - - - - 4 changed files: - docshell/base/nsAboutRedirector.cpp - netwerk/url-classifier/UrlClassifierFeatureBase.cpp - netwerk/url-classifier/components.conf - toolkit/modules/AppConstants.sys.mjs Changes: ===================================== docshell/base/nsAboutRedirector.cpp ===================================== @@ -218,6 +218,8 @@ static const RedirEntry kRedirMap[] = { nsIAboutModule::HIDE_FROM_ABOUTABOUT}, #endif #ifndef BASE_BROWSER_VERSION + // We disable safe browsing and the data update mechanisms. So this page + // will be non-functional or at least unreliable. {"url-classifier", "chrome://global/content/aboutUrlClassifier.xhtml", nsIAboutModule::ALLOW_SCRIPT}, #endif ===================================== netwerk/url-classifier/UrlClassifierFeatureBase.cpp ===================================== @@ -80,7 +80,7 @@ void UrlClassifierFeatureBase::InitializePreferences() { nsCOMPtr<nsIUrlClassifierExceptionListService> exceptionListService = do_GetService("@mozilla.org/url-classifier/exception-list-service;1"); - if (!exceptionListService) { + if (NS_WARN_IF(!exceptionListService)) { return; } ===================================== netwerk/url-classifier/components.conf ===================================== @@ -13,4 +13,24 @@ Classes = [ 'constructor': 'mozilla::net::ChannelClassifierService::GetSingleton', 'headers': ['mozilla/net/ChannelClassifierService.h'], }, + { + 'cid': '{b9f4fd03-9d87-4bfd-9958-85a821750ddc}', + 'contract_ids': ['@mozilla.org/url-classifier/exception-list-service;1'], + 'esModule': 'resource://gre/modules/UrlClassifierExceptionListService.sys.mjs', + 'constructor': 'UrlClassifierExceptionListService', + }, + { + 'cid': '{8753A413-3ED6-4A61-A1DC-B31A7E69B796}', + 'interfaces': ['nsIUrlClassifierExceptionListEntry'], + 'headers': ['mozilla/net/UrlClassifierExceptionListEntry.h'], + 'type': 'mozilla::net::UrlClassifierExceptionListEntry', + 'contract_ids': ['@mozilla.org/url-classifier/exception-list-entry;1'], + }, + { + 'cid': '{807535BF-018E-4300-B8D3-4A6405FB9F65}', + 'interfaces': ['nsIUrlClassifierExceptionList'], + 'headers': ['mozilla/net/UrlClassifierExceptionList.h'], + 'type': 'mozilla::net::UrlClassifierExceptionList', + 'contract_ids': ['@mozilla.org/url-classifier/exception-list;1'], + }, ] ===================================== toolkit/modules/AppConstants.sys.mjs ===================================== @@ -210,10 +210,12 @@ export var AppConstants = Object.freeze({ ENABLE_WEBDRIVER: @ENABLE_WEBDRIVER_BOOL@, REMOTE_SETTINGS_SERVER_URL: -#ifdef MOZ_THUNDERBIRD +#if defined(BASE_BROWSER_VERSION) + "", +#elif defined(MOZ_THUNDERBIRD) "https://thunderbird-settings.thunderbird.net/v1", #else - "", + "https://firefox.settings.services.mozilla.com/v1", #endif REMOTE_SETTINGS_VERIFY_SIGNATURE: View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/dcfb18… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/dcfb18… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-140.2.0esr-15.0-1] 4 commits: fixup! BB 31740: Remove some unnecessary RemoteSettings instances
by Pier Angelo Vendrame (＠pierov) 20 Aug '25

20 Aug '25

Pier Angelo Vendrame pushed to branch tor-browser-140.2.0esr-15.0-1 at The Tor Project / Applications / Tor Browser Commits: 57dfb0ea by Pier Angelo Vendrame at 2025-08-20T17:59:14+02:00 fixup! BB 31740: Remove some unnecessary RemoteSettings instances BB 43795: Restore the URL classifier XPCOM components. We are not really interested in removing them. We're interested in them not calling Mozilla. However, we have a central patch for RemoteSettings, so we do not need to patch the single user. Or, if we did, at least we should patch UrlClassifierExceptionListService where it creates its RemoteSettings instance. - - - - - 61ec52da by Pier Angelo Vendrame at 2025-08-20T17:59:17+02:00 fixup! BB 31740: Remove some unnecessary RemoteSettings instances BB 43795: Restore the URL classifier XPCOM components. Remove this page as part of another commit. This comit should go away automatically at the next rebase. - - - - - dd621fde by Pier Angelo Vendrame at 2025-08-20T17:59:19+02:00 fixup! BB 42716: Disable unwanted about: pages BB 43795: Restore the URL classifier XPCOM components. Move the commit where we disable about:urlclassifier. - - - - - 4390c5a4 by Pier Angelo Vendrame at 2025-08-20T17:59:21+02:00 fixup! BB 42730: Patch RemoteSettings to use only local dumps as a data source Make explicit that blanking REMOTE_SETTINGS_SERVER_URL is our change. - - - - - 4 changed files: - docshell/base/nsAboutRedirector.cpp - netwerk/url-classifier/UrlClassifierFeatureBase.cpp - netwerk/url-classifier/components.conf - toolkit/modules/AppConstants.sys.mjs Changes: ===================================== docshell/base/nsAboutRedirector.cpp ===================================== @@ -223,6 +223,8 @@ static const RedirEntry kRedirMap[] = { nsIAboutModule::HIDE_FROM_ABOUTABOUT}, #endif #ifndef BASE_BROWSER_VERSION + // We disable safe browsing and the data update mechanisms. So this page + // will be non-functional or at least unreliable. {"url-classifier", "chrome://global/content/aboutUrlClassifier.xhtml", nsIAboutModule::ALLOW_SCRIPT}, #endif ===================================== netwerk/url-classifier/UrlClassifierFeatureBase.cpp ===================================== @@ -80,7 +80,7 @@ void UrlClassifierFeatureBase::InitializePreferences() { nsCOMPtr<nsIUrlClassifierExceptionListService> exceptionListService = do_GetService("@mozilla.org/url-classifier/exception-list-service;1"); - if (!exceptionListService) { + if (NS_WARN_IF(!exceptionListService)) { return; } ===================================== netwerk/url-classifier/components.conf ===================================== @@ -13,4 +13,24 @@ Classes = [ 'constructor': 'mozilla::net::ChannelClassifierService::GetSingleton', 'headers': ['mozilla/net/ChannelClassifierService.h'], }, + { + 'cid': '{b9f4fd03-9d87-4bfd-9958-85a821750ddc}', + 'contract_ids': ['@mozilla.org/url-classifier/exception-list-service;1'], + 'esModule': 'resource://gre/modules/UrlClassifierExceptionListService.sys.mjs', + 'constructor': 'UrlClassifierExceptionListService', + }, + { + 'cid': '{8753A413-3ED6-4A61-A1DC-B31A7E69B796}', + 'interfaces': ['nsIUrlClassifierExceptionListEntry'], + 'headers': ['mozilla/net/UrlClassifierExceptionListEntry.h'], + 'type': 'mozilla::net::UrlClassifierExceptionListEntry', + 'contract_ids': ['@mozilla.org/url-classifier/exception-list-entry;1'], + }, + { + 'cid': '{807535BF-018E-4300-B8D3-4A6405FB9F65}', + 'interfaces': ['nsIUrlClassifierExceptionList'], + 'headers': ['mozilla/net/UrlClassifierExceptionList.h'], + 'type': 'mozilla::net::UrlClassifierExceptionList', + 'contract_ids': ['@mozilla.org/url-classifier/exception-list;1'], + }, ] ===================================== toolkit/modules/AppConstants.sys.mjs ===================================== @@ -210,10 +210,12 @@ export var AppConstants = Object.freeze({ ENABLE_WEBDRIVER: @ENABLE_WEBDRIVER_BOOL@, REMOTE_SETTINGS_SERVER_URL: -#ifdef MOZ_THUNDERBIRD +#if defined(BASE_BROWSER_VERSION) + "", +#elif defined(MOZ_THUNDERBIRD) "https://thunderbird-settings.thunderbird.net/v1", #else - "", + "https://firefox.settings.services.mozilla.com/v1", #endif REMOTE_SETTINGS_VERIFY_SIGNATURE: View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/9691ec… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/9691ec… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 40698: Remove locale from tbb_version.json/version.json
by boklm (＠boklm) 20 Aug '25

20 Aug '25

boklm pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 7d72dc2c by Nicolas Vigier at 2025-08-20T15:23:18+02:00 Bug 40698: Remove locale from tbb_version.json/version.json - - - - - 1 changed file: - projects/browser/build Changes: ===================================== projects/browser/build ===================================== @@ -262,7 +262,7 @@ do rm -rf defaults # create tbb_version.json (torbrowser) or version.json (mullvadbrowser) # file for tor-browser#25020 and tor-browser-build#41044 - echo '{"version":"[% c("var/torbrowser_version") %]","architecture":"[% c("var/mar_osname") %]","channel":"[% c("var/channel") %]","locale":"en-US"}' > ../[% c("var/version_json") %] + echo '{"version":"[% c("var/torbrowser_version") %]","architecture":"[% c("var/mar_osname") %]","channel":"[% c("var/channel") %]"}' > ../[% c("var/version_json") %] popd done View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/7… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/7… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-140.2.0esr-15.0-1] 2 commits: fixup! BB 40926: Implemented the New Identity feature
by morgan (＠morgan) 20 Aug '25

20 Aug '25

morgan pushed to branch mullvad-browser-140.2.0esr-15.0-1 at The Tor Project / Applications / Mullvad Browser Commits: 7535773c by Henry Wilkes at 2025-08-20T13:42:42+00:00 fixup! BB 40926: Implemented the New Identity feature TB 44034: Update new identity checkbox string. TB 44040: Use the prompt API for new identity. - - - - - ddc85dbe by Henry Wilkes at 2025-08-20T13:42:47+00:00 fixup! Base Browser strings TB 44034: Update new identity checkbox string. - - - - - 6 changed files: - − browser/components/newidentity/content/newIdentityDialog.css - − browser/components/newidentity/content/newIdentityDialog.js - − browser/components/newidentity/content/newIdentityDialog.xhtml - browser/components/newidentity/content/newidentity.js - browser/components/newidentity/jar.mn - toolkit/locales/en-US/toolkit/global/base-browser.ftl Changes: ===================================== browser/components/newidentity/content/newIdentityDialog.css deleted ===================================== @@ -1,7 +0,0 @@ -/* This Source Code Form is subject to the terms of the Mozilla Public - * License, v. 2.0. If a copy of the MPL was not distributed with this file, - * You can obtain one at http://mozilla.org/MPL/2.0/. */ - -#infoTitle { - font-weight: 600; -} ===================================== browser/components/newidentity/content/newIdentityDialog.js deleted ===================================== @@ -1,17 +0,0 @@ -/* This Source Code Form is subject to the terms of the Mozilla Public - * License, v. 2.0. If a copy of the MPL was not distributed with this file, - * You can obtain one at http://mozilla.org/MPL/2.0/. */ - -document.addEventListener("dialogaccept", () => { - const retvals = window.arguments[0]; - retvals.confirmed = true; - retvals.neverAskAgain = document.getElementById("neverAskAgain").checked; -}); - -document.addEventListener("DOMContentLoaded", () => { - const dialog = document.getElementById("newIdentityDialog"); - - const accept = dialog.getButton("accept"); - document.l10n.setAttributes(accept, "new-identity-dialog-confirm"); - accept.classList.add("danger-button"); -}); ===================================== browser/components/newidentity/content/newIdentityDialog.xhtml deleted ===================================== @@ -1,65 +0,0 @@ -<?xml version="1.0"?> - - - - - -<?csp default-src chrome: ?> - -<window - id="newIdentityDialogWindow" - xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul" - xmlns:html="http://www.w3.org/1999/xhtml" - xmlns:xul="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul" - aria-labelledby="infoTitle" - aria-describedby="infoBody" -> - <dialog id="newIdentityDialog" buttons="accept,cancel" defaultButton="accept"> - <linkset> - <html:link rel="stylesheet" href="chrome://global/skin/global.css" /> - <html:link - rel="stylesheet" - href="chrome://global/content/commonDialog.css" - /> - <html:link - rel="stylesheet" - href="chrome://global/skin/commonDialog.css" - /> - <html:link - rel="stylesheet" - href="chrome://browser/content/newIdentityDialog.css" - /> - - <html:link rel="localization" href="branding/brand.ftl" /> - <html:link rel="localization" href="toolkit/global/base-browser.ftl" /> - </linkset> - - <div xmlns="http://www.w3.org/1999/xhtml"> - <div id="dialogGrid"> - <div class="dialogRow" id="infoRow"> - <div id="iconContainer"> - <xul:image id="infoIcon" /> - </div> - <div id="infoContainer"> - <xul:description - id="infoTitle" - data-l10n-id="new-identity-dialog-title" - /> - <xul:description - id="infoBody" - data-l10n-id="new-identity-dialog-description" - /> - <xul:checkbox - id="neverAskAgain" - data-l10n-id="new-identity-dialog-never-ask-checkbox" - /> - </div> - </div> - </div> - </div> - - <script src="chrome://browser/content/newIdentityDialog.js" /> - </dialog> -</window> ===================================== browser/components/newidentity/content/newidentity.js ===================================== @@ -513,18 +513,37 @@ ChromeUtils.defineLazyGetter(this, "NewIdentityButton", () => { const prefConfirm = "browser.new_identity.confirm_newnym"; const shouldConfirm = Services.prefs.getBoolPref(prefConfirm, true); if (shouldConfirm) { - const params = { - confirmed: false, - neverAskAgain: false, - }; - await window.gDialogBox.open( - "chrome://browser/content/newIdentityDialog.xhtml", - params + const [titleString, bodyString, checkboxString, restartString] = + await document.l10n.formatValues([ + { id: "new-identity-dialog-title" }, + { id: "new-identity-dialog-description" }, + { id: "restart-warning-dialog-do-not-warn-checkbox" }, + { id: "restart-warning-dialog-restart-button" }, + ]); + const flags = + Services.prompt.BUTTON_POS_0 * + Services.prompt.BUTTON_TITLE_IS_STRING + + Services.prompt.BUTTON_POS_0_DEFAULT + + Services.prompt.BUTTON_DEFAULT_IS_DESTRUCTIVE + + Services.prompt.BUTTON_POS_1 * Services.prompt.BUTTON_TITLE_CANCEL; + const propBag = await Services.prompt.asyncConfirmEx( + window.browsingContext, + Services.prompt.MODAL_TYPE_INTERNAL_WINDOW, + titleString, + bodyString, + flags, + restartString, + null, + null, + checkboxString, + false ); - Services.prefs.setBoolPref(prefConfirm, !params.neverAskAgain); - if (!params.confirmed) { + if (propBag.get("buttonNumClicked") !== 0) { return; } + if (propBag.get("checked")) { + Services.prefs.setBoolPref(prefConfirm, false); + } } const impl = new NewIdentityImpl(); ===================================== browser/components/newidentity/jar.mn ===================================== @@ -1,5 +1,2 @@ browser.jar: content/browser/newidentity.js (content/newidentity.js) - content/browser/newIdentityDialog.xhtml (content/newIdentityDialog.xhtml) - content/browser/newIdentityDialog.css (content/newIdentityDialog.css) - content/browser/newIdentityDialog.js (content/newIdentityDialog.js) ===================================== toolkit/locales/en-US/toolkit/global/base-browser.ftl ===================================== @@ -63,10 +63,6 @@ toolbar-new-identity = new-identity-dialog-title = Reset your identity? new-identity-dialog-description = { -brand-short-name } will close all windows and tabs. All website sessions will be lost. -new-identity-dialog-never-ask-checkbox = - .label = Never ask me again -new-identity-dialog-confirm = - .label = Restart { -brand-short-name } ## New identity: blocked home page notification. View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/8f… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/8f… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-140.2.0esr-15.0-1] 2 commits: fixup! BB 40926: Implemented the New Identity feature
by morgan (＠morgan) 20 Aug '25

20 Aug '25

morgan pushed to branch base-browser-140.2.0esr-15.0-1 at The Tor Project / Applications / Tor Browser Commits: 69cb9a3b by Henry Wilkes at 2025-08-20T13:41:08+00:00 fixup! BB 40926: Implemented the New Identity feature TB 44034: Update new identity checkbox string. TB 44040: Use the prompt API for new identity. - - - - - dcfb181d by Henry Wilkes at 2025-08-20T13:41:09+00:00 fixup! Base Browser strings TB 44034: Update new identity checkbox string. - - - - - 6 changed files: - − browser/components/newidentity/content/newIdentityDialog.css - − browser/components/newidentity/content/newIdentityDialog.js - − browser/components/newidentity/content/newIdentityDialog.xhtml - browser/components/newidentity/content/newidentity.js - browser/components/newidentity/jar.mn - toolkit/locales/en-US/toolkit/global/base-browser.ftl Changes: ===================================== browser/components/newidentity/content/newIdentityDialog.css deleted ===================================== @@ -1,7 +0,0 @@ -/* This Source Code Form is subject to the terms of the Mozilla Public - * License, v. 2.0. If a copy of the MPL was not distributed with this file, - * You can obtain one at http://mozilla.org/MPL/2.0/. */ - -#infoTitle { - font-weight: 600; -} ===================================== browser/components/newidentity/content/newIdentityDialog.js deleted ===================================== @@ -1,17 +0,0 @@ -/* This Source Code Form is subject to the terms of the Mozilla Public - * License, v. 2.0. If a copy of the MPL was not distributed with this file, - * You can obtain one at http://mozilla.org/MPL/2.0/. */ - -document.addEventListener("dialogaccept", () => { - const retvals = window.arguments[0]; - retvals.confirmed = true; - retvals.neverAskAgain = document.getElementById("neverAskAgain").checked; -}); - -document.addEventListener("DOMContentLoaded", () => { - const dialog = document.getElementById("newIdentityDialog"); - - const accept = dialog.getButton("accept"); - document.l10n.setAttributes(accept, "new-identity-dialog-confirm"); - accept.classList.add("danger-button"); -}); ===================================== browser/components/newidentity/content/newIdentityDialog.xhtml deleted ===================================== @@ -1,65 +0,0 @@ -<?xml version="1.0"?> - - - - - -<?csp default-src chrome: ?> - -<window - id="newIdentityDialogWindow" - xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul" - xmlns:html="http://www.w3.org/1999/xhtml" - xmlns:xul="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul" - aria-labelledby="infoTitle" - aria-describedby="infoBody" -> - <dialog id="newIdentityDialog" buttons="accept,cancel" defaultButton="accept"> - <linkset> - <html:link rel="stylesheet" href="chrome://global/skin/global.css" /> - <html:link - rel="stylesheet" - href="chrome://global/content/commonDialog.css" - /> - <html:link - rel="stylesheet" - href="chrome://global/skin/commonDialog.css" - /> - <html:link - rel="stylesheet" - href="chrome://browser/content/newIdentityDialog.css" - /> - - <html:link rel="localization" href="branding/brand.ftl" /> - <html:link rel="localization" href="toolkit/global/base-browser.ftl" /> - </linkset> - - <div xmlns="http://www.w3.org/1999/xhtml"> - <div id="dialogGrid"> - <div class="dialogRow" id="infoRow"> - <div id="iconContainer"> - <xul:image id="infoIcon" /> - </div> - <div id="infoContainer"> - <xul:description - id="infoTitle" - data-l10n-id="new-identity-dialog-title" - /> - <xul:description - id="infoBody" - data-l10n-id="new-identity-dialog-description" - /> - <xul:checkbox - id="neverAskAgain" - data-l10n-id="new-identity-dialog-never-ask-checkbox" - /> - </div> - </div> - </div> - </div> - - <script src="chrome://browser/content/newIdentityDialog.js" /> - </dialog> -</window> ===================================== browser/components/newidentity/content/newidentity.js ===================================== @@ -513,18 +513,37 @@ ChromeUtils.defineLazyGetter(this, "NewIdentityButton", () => { const prefConfirm = "browser.new_identity.confirm_newnym"; const shouldConfirm = Services.prefs.getBoolPref(prefConfirm, true); if (shouldConfirm) { - const params = { - confirmed: false, - neverAskAgain: false, - }; - await window.gDialogBox.open( - "chrome://browser/content/newIdentityDialog.xhtml", - params + const [titleString, bodyString, checkboxString, restartString] = + await document.l10n.formatValues([ + { id: "new-identity-dialog-title" }, + { id: "new-identity-dialog-description" }, + { id: "restart-warning-dialog-do-not-warn-checkbox" }, + { id: "restart-warning-dialog-restart-button" }, + ]); + const flags = + Services.prompt.BUTTON_POS_0 * + Services.prompt.BUTTON_TITLE_IS_STRING + + Services.prompt.BUTTON_POS_0_DEFAULT + + Services.prompt.BUTTON_DEFAULT_IS_DESTRUCTIVE + + Services.prompt.BUTTON_POS_1 * Services.prompt.BUTTON_TITLE_CANCEL; + const propBag = await Services.prompt.asyncConfirmEx( + window.browsingContext, + Services.prompt.MODAL_TYPE_INTERNAL_WINDOW, + titleString, + bodyString, + flags, + restartString, + null, + null, + checkboxString, + false ); - Services.prefs.setBoolPref(prefConfirm, !params.neverAskAgain); - if (!params.confirmed) { + if (propBag.get("buttonNumClicked") !== 0) { return; } + if (propBag.get("checked")) { + Services.prefs.setBoolPref(prefConfirm, false); + } } const impl = new NewIdentityImpl(); ===================================== browser/components/newidentity/jar.mn ===================================== @@ -1,5 +1,2 @@ browser.jar: content/browser/newidentity.js (content/newidentity.js) - content/browser/newIdentityDialog.xhtml (content/newIdentityDialog.xhtml) - content/browser/newIdentityDialog.css (content/newIdentityDialog.css) - content/browser/newIdentityDialog.js (content/newIdentityDialog.js) ===================================== toolkit/locales/en-US/toolkit/global/base-browser.ftl ===================================== @@ -63,10 +63,6 @@ toolbar-new-identity = new-identity-dialog-title = Reset your identity? new-identity-dialog-description = { -brand-short-name } will close all windows and tabs. All website sessions will be lost. -new-identity-dialog-never-ask-checkbox = - .label = Never ask me again -new-identity-dialog-confirm = - .label = Restart { -brand-short-name } ## New identity: blocked home page notification. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/4891bc… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/4891bc… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-140.2.0esr-15.0-1] 2 commits: fixup! BB 40926: Implemented the New Identity feature
by morgan (＠morgan) 20 Aug '25

20 Aug '25

morgan pushed to branch tor-browser-140.2.0esr-15.0-1 at The Tor Project / Applications / Tor Browser Commits: 68e8f5df by Henry Wilkes at 2025-08-20T13:32:15+00:00 fixup! BB 40926: Implemented the New Identity feature TB 44034: Update new identity checkbox string. TB 44040: Use the prompt API for new identity. - - - - - 9691ec21 by Henry Wilkes at 2025-08-20T13:32:15+00:00 fixup! Base Browser strings TB 44034: Update new identity checkbox string. - - - - - 6 changed files: - − browser/components/newidentity/content/newIdentityDialog.css - − browser/components/newidentity/content/newIdentityDialog.js - − browser/components/newidentity/content/newIdentityDialog.xhtml - browser/components/newidentity/content/newidentity.js - browser/components/newidentity/jar.mn - toolkit/locales/en-US/toolkit/global/base-browser.ftl Changes: ===================================== browser/components/newidentity/content/newIdentityDialog.css deleted ===================================== @@ -1,7 +0,0 @@ -/* This Source Code Form is subject to the terms of the Mozilla Public - * License, v. 2.0. If a copy of the MPL was not distributed with this file, - * You can obtain one at http://mozilla.org/MPL/2.0/. */ - -#infoTitle { - font-weight: 600; -} ===================================== browser/components/newidentity/content/newIdentityDialog.js deleted ===================================== @@ -1,17 +0,0 @@ -/* This Source Code Form is subject to the terms of the Mozilla Public - * License, v. 2.0. If a copy of the MPL was not distributed with this file, - * You can obtain one at http://mozilla.org/MPL/2.0/. */ - -document.addEventListener("dialogaccept", () => { - const retvals = window.arguments[0]; - retvals.confirmed = true; - retvals.neverAskAgain = document.getElementById("neverAskAgain").checked; -}); - -document.addEventListener("DOMContentLoaded", () => { - const dialog = document.getElementById("newIdentityDialog"); - - const accept = dialog.getButton("accept"); - document.l10n.setAttributes(accept, "new-identity-dialog-confirm"); - accept.classList.add("danger-button"); -}); ===================================== browser/components/newidentity/content/newIdentityDialog.xhtml deleted ===================================== @@ -1,65 +0,0 @@ -<?xml version="1.0"?> - - - - - -<?csp default-src chrome: ?> - -<window - id="newIdentityDialogWindow" - xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul" - xmlns:html="http://www.w3.org/1999/xhtml" - xmlns:xul="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul" - aria-labelledby="infoTitle" - aria-describedby="infoBody" -> - <dialog id="newIdentityDialog" buttons="accept,cancel" defaultButton="accept"> - <linkset> - <html:link rel="stylesheet" href="chrome://global/skin/global.css" /> - <html:link - rel="stylesheet" - href="chrome://global/content/commonDialog.css" - /> - <html:link - rel="stylesheet" - href="chrome://global/skin/commonDialog.css" - /> - <html:link - rel="stylesheet" - href="chrome://browser/content/newIdentityDialog.css" - /> - - <html:link rel="localization" href="branding/brand.ftl" /> - <html:link rel="localization" href="toolkit/global/base-browser.ftl" /> - </linkset> - - <div xmlns="http://www.w3.org/1999/xhtml"> - <div id="dialogGrid"> - <div class="dialogRow" id="infoRow"> - <div id="iconContainer"> - <xul:image id="infoIcon" /> - </div> - <div id="infoContainer"> - <xul:description - id="infoTitle" - data-l10n-id="new-identity-dialog-title" - /> - <xul:description - id="infoBody" - data-l10n-id="new-identity-dialog-description" - /> - <xul:checkbox - id="neverAskAgain" - data-l10n-id="new-identity-dialog-never-ask-checkbox" - /> - </div> - </div> - </div> - </div> - - <script src="chrome://browser/content/newIdentityDialog.js" /> - </dialog> -</window> ===================================== browser/components/newidentity/content/newidentity.js ===================================== @@ -513,18 +513,37 @@ ChromeUtils.defineLazyGetter(this, "NewIdentityButton", () => { const prefConfirm = "browser.new_identity.confirm_newnym"; const shouldConfirm = Services.prefs.getBoolPref(prefConfirm, true); if (shouldConfirm) { - const params = { - confirmed: false, - neverAskAgain: false, - }; - await window.gDialogBox.open( - "chrome://browser/content/newIdentityDialog.xhtml", - params + const [titleString, bodyString, checkboxString, restartString] = + await document.l10n.formatValues([ + { id: "new-identity-dialog-title" }, + { id: "new-identity-dialog-description" }, + { id: "restart-warning-dialog-do-not-warn-checkbox" }, + { id: "restart-warning-dialog-restart-button" }, + ]); + const flags = + Services.prompt.BUTTON_POS_0 * + Services.prompt.BUTTON_TITLE_IS_STRING + + Services.prompt.BUTTON_POS_0_DEFAULT + + Services.prompt.BUTTON_DEFAULT_IS_DESTRUCTIVE + + Services.prompt.BUTTON_POS_1 * Services.prompt.BUTTON_TITLE_CANCEL; + const propBag = await Services.prompt.asyncConfirmEx( + window.browsingContext, + Services.prompt.MODAL_TYPE_INTERNAL_WINDOW, + titleString, + bodyString, + flags, + restartString, + null, + null, + checkboxString, + false ); - Services.prefs.setBoolPref(prefConfirm, !params.neverAskAgain); - if (!params.confirmed) { + if (propBag.get("buttonNumClicked") !== 0) { return; } + if (propBag.get("checked")) { + Services.prefs.setBoolPref(prefConfirm, false); + } } const impl = new NewIdentityImpl(); ===================================== browser/components/newidentity/jar.mn ===================================== @@ -1,5 +1,2 @@ browser.jar: content/browser/newidentity.js (content/newidentity.js) - content/browser/newIdentityDialog.xhtml (content/newIdentityDialog.xhtml) - content/browser/newIdentityDialog.css (content/newIdentityDialog.css) - content/browser/newIdentityDialog.js (content/newIdentityDialog.js) ===================================== toolkit/locales/en-US/toolkit/global/base-browser.ftl ===================================== @@ -63,10 +63,6 @@ toolbar-new-identity = new-identity-dialog-title = Reset your identity? new-identity-dialog-description = { -brand-short-name } will close all windows and tabs. All website sessions will be lost. -new-identity-dialog-never-ask-checkbox = - .label = Never ask me again -new-identity-dialog-confirm = - .label = Restart { -brand-short-name } ## New identity: blocked home page notification. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/b66d9c… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/b66d9c… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 40697: Remove repackage_browser.sh.
by Pier Angelo Vendrame (＠pierov) 20 Aug '25

20 Aug '25

Pier Angelo Vendrame pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 427fdb1b by Pier Angelo Vendrame at 2025-08-20T09:20:47+02:00 Bug 40697: Remove repackage_browser.sh. This script is very old, has not been maintained and does not work with the current versions of Tor Browser anymore. Use the scripts in tor-browser.git/tools/torbrowser, instead. - - - - - 1 changed file: - − tools/repackage_browser.sh Changes: ===================================== tools/repackage_browser.sh deleted ===================================== @@ -1,58 +0,0 @@ -#!/bin/bash - -# This script allows you to repackage a Tor Browser bundle using an -# obj-x86_64-pc-linux-gnu directory from a local tor-browser.git build. -# -# This script will download the current Tor Browser version (using -# var/torbrowser_version from rbm config, or an optional second argument) -# and repackage it with the specified obj directory. -# -# The new repackaged bundle can be found in the _repackaged directory. - -set -e - -display_usage() { - echo -e "\\nUsage: $0 firefox_obj_path [torbrowser-version]\\n" -} -if [ $# -lt 1 ] || [ $# -gt 2 ] -then - display_usage - exit 1 -fi - -DIRNAME="$( cd "$(dirname "$0")" >/dev/null 2>&1 ; pwd -P )" -OBJ_PATH=$1 -if [ $# -eq 2 ] -then - TOR_VERSION="$2" -else - TOR_VERSION=$("$DIRNAME"/../rbm/rbm showconf tor-browser var/torbrowser_version) -fi -TOR_FILENAME=tor-browser-linux64-${TOR_VERSION}_en-US.tar.xz -TOR_BROWSER_URL=https://dist.torproject.org/torbrowser/"${TOR_VERSION}"/"${TOR_FILENAME}" -TMPDIR="$(mktemp -d)" - -( -cd "$TMPDIR" -wget "$TOR_BROWSER_URL" -wget "$TOR_BROWSER_URL".asc -gpg --no-default-keyring --keyring "$DIRNAME"/../keyring/torbrowser.gpg --verify "${TOR_FILENAME}".asc "${TOR_FILENAME}" - -# From projects/firefox/build: replace firefox binary by the wrapper and strip libraries/binaries -tar xf "${TOR_FILENAME}" -cp -r "${OBJ_PATH}"/dist/firefox . -rm firefox/firefox-bin -mv firefox/firefox firefox/firefox.real -for LIB in firefox/*.so firefox/gtk2/*.so firefox/firefox.real firefox/plugin-container firefox/updater -do - strip "$LIB" -done - -# Overwrite extracted tor-browser with locally built files and move to _repackaged folder -cp -r firefox/* tor-browser_en-US/Browser -rm -rf firefox "${TOR_FILENAME}" -REPACKAGED_DIR="$DIRNAME"/_repackaged/ -mkdir -p "$REPACKAGED_DIR" -mv tor-browser_en-US "$REPACKAGED_DIR"/tor-browser-"$(date '+%Y%m%d%H%M%S')" -rm -rf "$TMPDIR" -) View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/4… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/4… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-140.2.0esr-15.0-1] fixup! Firefox preference overrides.
by brizental (＠brizental) 20 Aug '25

20 Aug '25

brizental pushed to branch mullvad-browser-140.2.0esr-15.0-1 at The Tor Project / Applications / Mullvad Browser Commits: 8f29664e by Beatriz Rizental at 2025-08-20T14:39:14+02:00 fixup! Firefox preference overrides. - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -282,6 +282,8 @@ pref("privacy.trackingprotection.annotate_channels", false); pref("privacy.trackingprotection.cryptomining.enabled", false); pref("privacy.trackingprotection.fingerprinting.enabled", false); pref("privacy.trackingprotection.socialtracking.enabled", false); +// tor-browser#43986: Explicitly disable bounce tracking protection +pref("privacy.bounceTrackingProtection.mode", 0); pref("privacy.socialtracking.block_cookies.enabled", false); pref("privacy.annotate_channels.strict_list.enabled", false); // tor-browser#43178: for defense-in-depth, avoid remote overrides to FPP. View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/8f2… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/8f2… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-140.2.0esr-15.0-1] fixup! Firefox preference overrides.
by brizental (＠brizental) 20 Aug '25

20 Aug '25

brizental pushed to branch base-browser-140.2.0esr-15.0-1 at The Tor Project / Applications / Tor Browser Commits: 4891bcd3 by Beatriz Rizental at 2025-08-20T14:38:13+02:00 fixup! Firefox preference overrides. - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -282,6 +282,8 @@ pref("privacy.trackingprotection.annotate_channels", false); pref("privacy.trackingprotection.cryptomining.enabled", false); pref("privacy.trackingprotection.fingerprinting.enabled", false); pref("privacy.trackingprotection.socialtracking.enabled", false); +// tor-browser#43986: Explicitly disable bounce tracking protection +pref("privacy.bounceTrackingProtection.mode", 0); pref("privacy.socialtracking.block_cookies.enabled", false); pref("privacy.annotate_channels.strict_list.enabled", false); // tor-browser#43178: for defense-in-depth, avoid remote overrides to FPP. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/4891bcd… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/4891bcd… You're receiving this email because of your account on gitlab.torproject.org.

1 0