March 2025 - tor-commits - lists.torproject.org

[Git][tpo/applications/tor-browser] Pushed new tag tor-browser-115.22.0esr-13.5-1-build3
by ma1 (＠ma1) 31 Mar '25

31 Mar '25

ma1 pushed new tag tor-browser-115.22.0esr-13.5-1-build3 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Deleted tag tor-browser-115.22.0esr-13.5-1-build3
by ma1 (＠ma1) 31 Mar '25

31 Mar '25

ma1 deleted tag tor-browser-115.22.0esr-13.5-1-build3 at The Tor Project / Applications / Tor Browser -- You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build] Pushed new tag tbb-13.5.15-build2
by Pier Angelo Vendrame (＠pierov) 31 Mar '25

31 Mar '25

Pier Angelo Vendrame pushed new tag tbb-13.5.15-build2 at The Tor Project / Applications / tor-browser-build -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/tree/tbb… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag tor-browser-115.22.0esr-13.5-1-build3
by ma1 (＠ma1) 31 Mar '25

31 Mar '25

ma1 pushed new tag tor-browser-115.22.0esr-13.5-1-build3 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][maint-13.5] Bug 41388: Prepare Tor Browser 13.5.15 (build 2).
by Pier Angelo Vendrame (＠pierov) 31 Mar '25

31 Mar '25

Pier Angelo Vendrame pushed to branch maint-13.5 at The Tor Project / Applications / tor-browser-build Commits: a40d61b5 by Pier Angelo Vendrame at 2025-03-31T23:33:06+02:00 Bug 41388: Prepare Tor Browser 13.5.15 (build 2). - - - - - 2 changed files: - projects/firefox/config - rbm.conf Changes: ===================================== projects/firefox/config ===================================== @@ -20,7 +20,7 @@ var: browser_series: '13.5' browser_rebase: 1 browser_branch: '[% c("var/browser_series") %]-[% c("var/browser_rebase") %]' - browser_build: 2 + browser_build: 3 branding_directory_prefix: 'tb' copyright_year: '[% exec("git show -s --format=%ci").remove("-.*") %]' nightly_updates_publish_dir: '[% c("var/nightly_updates_publish_dir_prefix") %]nightly-[% c("var/osname") %]' ===================================== rbm.conf ===================================== @@ -74,7 +74,7 @@ buildconf: var: torbrowser_version: '13.5.15' - torbrowser_build: 'build1' + torbrowser_build: 'build2' # This should be the date of when the build is started. For the build # to be reproducible, browser_release_date should always be in the past. browser_release_date: '2025/03/31 18:28:08' View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/a… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/a… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.22.0esr-13.5-1] 2 commits: Revert "Bug 1951494 - ensure socket control is released on the socket thread a=pascalc"
by ma1 (＠ma1) 31 Mar '25

31 Mar '25

ma1 pushed to branch tor-browser-115.22.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: 91cc9ef9 by hackademix at 2025-03-31T23:29:20+02:00 Revert "Bug 1951494 - ensure socket control is released on the socket thread a=pascalc" This reverts commit b26d6ce0b10411433b83e4f3782f314d8225751d. - - - - - 94b6018b by hackademix at 2025-03-31T23:32:17+02:00 fixup! Bug 1950056 - extend use of FOS_NODEREFERENCELINKS r=Gijs,win-reviewers,gstoll - - - - - 2 changed files: - security/manager/ssl/SSLServerCertVerification.cpp - widget/windows/nsFilePicker.cpp Changes: ===================================== security/manager/ssl/SSLServerCertVerification.cpp ===================================== @@ -1211,9 +1211,6 @@ SSLServerCertVerificationResult::Run() { } mSocketControl->SetCertVerificationResult(mFinalError); - // Release this reference to the socket control so that it will be freed on - // the socket thread. - mSocketControl = nullptr; return NS_OK; } ===================================== widget/windows/nsFilePicker.cpp ===================================== @@ -13,6 +13,7 @@ #include "mozilla/Assertions.h" #include "mozilla/BackgroundHangMonitor.h" #include "mozilla/ProfilerLabels.h" +#include "mozilla/StaticPrefs_widget.h" #include "mozilla/UniquePtr.h" #include "mozilla/WindowsVersion.h" #include "nsReadableUtils.h" View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/b26d6c… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/b26d6c… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-128.9.0esr-14.0-2] Bug 1950056 - extend use of FOS_NODEREFERENCELINKS r=Gijs,win-reviewers,gstoll
by ma1 (＠ma1) 31 Mar '25

31 Mar '25

ma1 pushed to branch base-browser-128.9.0esr-14.0-2 at The Tor Project / Applications / Tor Browser Commits: 5b1e5fc3 by Ray Kraesig at 2025-03-31T22:55:30+02:00 Bug 1950056 - extend use of FOS_NODEREFERENCELINKS r=Gijs,win-reviewers,gstoll In the modern era of user-customizable Quick Access sidebars on every file dialog, navigating via `.lnk` files is rather less useful than it was twenty years ago. Disable link-following in file-open dialogs by default, to prevent any of the usual security issues involving symlink smuggling. Allow overriding this behavior via a pref, for users who don't care. (File-save dialogs have a more nuanced guard against that sort of thing; this patch doesn't affect that.) Differential Revision: https://phabricator.services.mozilla.com/D239833 - - - - - 2 changed files: - modules/libpref/init/StaticPrefList.yaml - widget/windows/nsFilePicker.cpp Changes: ===================================== modules/libpref/init/StaticPrefList.yaml ===================================== @@ -16899,6 +16899,17 @@ value: 0 mirror: always +# Whether to follow `.lnk` (etc.) shortcuts in the Windows file-open dialog. +# +# Valid values: +# * 0: never +# * 1: always +# * 2: auto +- name: widget.windows.follow_shortcuts_on_file_open + type: RelaxedAtomicInt32 + value: 2 + mirror: always + # The number of messages of each type to keep for display in # about:windows-messages - name: widget.windows.messages_to_log ===================================== widget/windows/nsFilePicker.cpp ===================================== @@ -614,19 +614,29 @@ nsFilePicker::ShowFilePicker(const nsString& aInitialDir) { // mode specific switch (mMode) { + case modeOpenMultiple: + fos |= FOS_ALLOWMULTISELECT; + [[fallthrough]]; + case modeOpen: fos |= FOS_FILEMUSTEXIST; - break; - - case modeOpenMultiple: - fos |= FOS_FILEMUSTEXIST | FOS_ALLOWMULTISELECT; + switch (mozilla::StaticPrefs:: + widget_windows_follow_shortcuts_on_file_open()) { + case 1: + break; + default: + fos |= FOS_NODEREFERENCELINKS; + } break; case modeSave: fos |= FOS_NOREADONLYRETURN; - // Don't follow shortcuts when saving a shortcut, this can be used - // to trick users (bug 271732) - if (IsDefaultPathLink()) fos |= FOS_NODEREFERENCELINKS; + // Don't follow shortcuts when saving a shortcut; this can be used to + // trick users (bug 271732). _Do_ follow shortcuts when not saving a + // shortcut (bug 283730). + if (IsDefaultPathLink()) { + fos |= FOS_NODEREFERENCELINKS; + } break; case modeGetFolder: View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/5b1e5fc… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/5b1e5fc… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser] Pushed new tag mullvad-browser-128.9.0esr-14.0-2-build2
by ma1 (＠ma1) 31 Mar '25

31 Mar '25

ma1 pushed new tag mullvad-browser-128.9.0esr-14.0-2-build2 at The Tor Project / Applications / Mullvad Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/tree/mullv… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.9.0esr-14.0-2] Bug 1950056 - extend use of FOS_NODEREFERENCELINKS r=Gijs,win-reviewers,gstoll
by ma1 (＠ma1) 31 Mar '25

31 Mar '25

ma1 pushed to branch mullvad-browser-128.9.0esr-14.0-2 at The Tor Project / Applications / Mullvad Browser Commits: 5bdfb5dc by Ray Kraesig at 2025-03-31T22:51:04+02:00 Bug 1950056 - extend use of FOS_NODEREFERENCELINKS r=Gijs,win-reviewers,gstoll In the modern era of user-customizable Quick Access sidebars on every file dialog, navigating via `.lnk` files is rather less useful than it was twenty years ago. Disable link-following in file-open dialogs by default, to prevent any of the usual security issues involving symlink smuggling. Allow overriding this behavior via a pref, for users who don't care. (File-save dialogs have a more nuanced guard against that sort of thing; this patch doesn't affect that.) Differential Revision: https://phabricator.services.mozilla.com/D239833 - - - - - 2 changed files: - modules/libpref/init/StaticPrefList.yaml - widget/windows/nsFilePicker.cpp Changes: ===================================== modules/libpref/init/StaticPrefList.yaml ===================================== @@ -16899,6 +16899,17 @@ value: 0 mirror: always +# Whether to follow `.lnk` (etc.) shortcuts in the Windows file-open dialog. +# +# Valid values: +# * 0: never +# * 1: always +# * 2: auto +- name: widget.windows.follow_shortcuts_on_file_open + type: RelaxedAtomicInt32 + value: 2 + mirror: always + # The number of messages of each type to keep for display in # about:windows-messages - name: widget.windows.messages_to_log ===================================== widget/windows/nsFilePicker.cpp ===================================== @@ -614,19 +614,29 @@ nsFilePicker::ShowFilePicker(const nsString& aInitialDir) { // mode specific switch (mMode) { + case modeOpenMultiple: + fos |= FOS_ALLOWMULTISELECT; + [[fallthrough]]; + case modeOpen: fos |= FOS_FILEMUSTEXIST; - break; - - case modeOpenMultiple: - fos |= FOS_FILEMUSTEXIST | FOS_ALLOWMULTISELECT; + switch (mozilla::StaticPrefs:: + widget_windows_follow_shortcuts_on_file_open()) { + case 1: + break; + default: + fos |= FOS_NODEREFERENCELINKS; + } break; case modeSave: fos |= FOS_NOREADONLYRETURN; - // Don't follow shortcuts when saving a shortcut, this can be used - // to trick users (bug 271732) - if (IsDefaultPathLink()) fos |= FOS_NODEREFERENCELINKS; + // Don't follow shortcuts when saving a shortcut; this can be used to + // trick users (bug 271732). _Do_ follow shortcuts when not saving a + // shortcut (bug 283730). + if (IsDefaultPathLink()) { + fos |= FOS_NODEREFERENCELINKS; + } break; case modeGetFolder: View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/5bd… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/5bd… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag tor-browser-115.22.0esr-13.5-1-build2
by ma1 (＠ma1) 31 Mar '25

31 Mar '25

ma1 pushed new tag tor-browser-115.22.0esr-13.5-1-build2 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0