August 2024 - tor-commits - lists.torproject.org

[Git][tpo/applications/tor-browser][tor-browser-128.1.0esr-14.0-1] fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in...
by morgan (＠morgan) 14 Aug '24

14 Aug '24

morgan pushed to branch tor-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 5ed33f3d by Henry Wilkes at 2024-08-14T15:43:59+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42696: Update the tor bridge provider mail icon. - - - - - 3 changed files: - + browser/components/torpreferences/content/mail.svg - browser/components/torpreferences/content/torPreferences.css - browser/components/torpreferences/jar.mn Changes: ===================================== browser/components/torpreferences/content/mail.svg ===================================== @@ -0,0 +1,3 @@ +<svg width="16" height="16" viewBox="0 0 16 16" xmlns="http://www.w3.org/2000/svg"> + <path fill-rule="evenodd" d="M13 2.5H3C1.89543 2.5 1 3.39543 1 4.5V11.5C1 12.6046 1.89543 13.5 3 13.5H13C14.1046 13.5 15 12.6046 15 11.5V4.5C15 3.39543 14.1046 2.5 13 2.5ZM12.8023 3.75H3.19766L7.7466 7.91986C7.88997 8.05129 8.11003 8.05129 8.2534 7.91986L12.8023 3.75ZM2.25 4.57702V11.5C2.25 11.9142 2.58579 12.25 3 12.25H13C13.4142 12.25 13.75 11.9142 13.75 11.5V4.57702L9.09805 8.84131C8.47678 9.41081 7.52322 9.41081 6.90195 8.84131L2.25 4.57702Z" fill="context-fill" /> +</svg> ===================================== browser/components/torpreferences/content/torPreferences.css ===================================== @@ -753,7 +753,7 @@ button.spoof-button-disabled { } #tor-bridges-provider-icon-email { - content: url("chrome://browser/skin/mail.svg"); + content: url("chrome://browser/content/torpreferences/mail.svg"); } .tor-bridges-provider-name { ===================================== browser/components/torpreferences/jar.mn ===================================== @@ -19,6 +19,7 @@ browser.jar: content/browser/torpreferences/connectionSettingsDialog.js (content/connectionSettingsDialog.js) content/browser/torpreferences/network.svg (content/network.svg) content/browser/torpreferences/network-broken.svg (content/network-broken.svg) + content/browser/torpreferences/mail.svg (content/mail.svg) content/browser/torpreferences/provideBridgeDialog.xhtml (content/provideBridgeDialog.xhtml) content/browser/torpreferences/provideBridgeDialog.js (content/provideBridgeDialog.js) content/browser/torpreferences/requestBridgeDialog.xhtml (content/requestBridgeDialog.xhtml) View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/5ed33f3… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/5ed33f3… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.1.0esr-14.0-1] fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in...
by morgan (＠morgan) 14 Aug '24

14 Aug '24

morgan pushed to branch tor-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: b34904a2 by Henry Wilkes at 2024-08-14T15:31:24+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42691: Allow users to copy built-in addresses. - - - - - 1 changed file: - browser/components/torpreferences/content/connectionPane.js Changes: ===================================== browser/components/torpreferences/content/connectionPane.js ===================================== @@ -2126,12 +2126,10 @@ const gBridgeSettings = { }); this._bridgesMenu.addEventListener("showing", () => { - const canCopy = this._bridgeSource !== TorBridgeSource.BuiltIn; const canShare = this._bridgeSource === TorBridgeSource.UserProvided || this._bridgeSource === TorBridgeSource.BridgeDB; qrItem.hidden = !canShare || !this._canQRBridges; - copyItem.hidden = !canCopy; editItem.hidden = this._bridgeSource !== TorBridgeSource.UserProvided; }); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/b34904a… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/b34904a… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.1.0esr-14.0-1] Bug 42774: Always hide the third-pary certs UI.
by morgan (＠morgan) 14 Aug '24

14 Aug '24

morgan pushed to branch mullvad-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser Commits: 8a678c43 by Pier Angelo Vendrame at 2024-08-14T15:28:04+00:00 Bug 42774: Always hide the third-pary certs UI. - - - - - 1 changed file: - browser/components/preferences/privacy.js Changes: ===================================== browser/components/preferences/privacy.js ===================================== @@ -505,7 +505,8 @@ var gPrivacyPane = { let canConfigureThirdPartyCerts = (AppConstants.platform == "win" || AppConstants.platform == "macosx") && typeof Services.policies.getActivePolicies()?.Certificates - ?.ImportEnterpriseRoots == "undefined"; + ?.ImportEnterpriseRoots == "undefined" && + !AppConstants.BASE_BROWSER_VERSION; document.getElementById("certEnableThirdPartyToggleBox").hidden = !canConfigureThirdPartyCerts; View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/8a6… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/8a6… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-128.1.0esr-14.0-1] Bug 42774: Always hide the third-pary certs UI.
by morgan (＠morgan) 14 Aug '24

14 Aug '24

morgan pushed to branch base-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 2c237b4a by Pier Angelo Vendrame at 2024-08-14T15:27:19+00:00 Bug 42774: Always hide the third-pary certs UI. - - - - - 1 changed file: - browser/components/preferences/privacy.js Changes: ===================================== browser/components/preferences/privacy.js ===================================== @@ -505,7 +505,8 @@ var gPrivacyPane = { let canConfigureThirdPartyCerts = (AppConstants.platform == "win" || AppConstants.platform == "macosx") && typeof Services.policies.getActivePolicies()?.Certificates - ?.ImportEnterpriseRoots == "undefined"; + ?.ImportEnterpriseRoots == "undefined" && + !AppConstants.BASE_BROWSER_VERSION; document.getElementById("certEnableThirdPartyToggleBox").hidden = !canConfigureThirdPartyCerts; View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/2c237b4… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/2c237b4… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.1.0esr-14.0-1] Bug 42774: Always hide the third-pary certs UI.
by morgan (＠morgan) 14 Aug '24

14 Aug '24

morgan pushed to branch tor-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 8d6703a7 by Pier Angelo Vendrame at 2024-08-14T15:15:59+00:00 Bug 42774: Always hide the third-pary certs UI. - - - - - 1 changed file: - browser/components/preferences/privacy.js Changes: ===================================== browser/components/preferences/privacy.js ===================================== @@ -511,7 +511,8 @@ var gPrivacyPane = { let canConfigureThirdPartyCerts = (AppConstants.platform == "win" || AppConstants.platform == "macosx") && typeof Services.policies.getActivePolicies()?.Certificates - ?.ImportEnterpriseRoots == "undefined"; + ?.ImportEnterpriseRoots == "undefined" && + !AppConstants.BASE_BROWSER_VERSION; document.getElementById("certEnableThirdPartyToggleBox").hidden = !canConfigureThirdPartyCerts; View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/8d6703a… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/8d6703a… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.1.0esr-14.0-1] fixup! Firefox preference overrides.
by morgan (＠morgan) 14 Aug '24

14 Aug '24

morgan pushed to branch mullvad-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser Commits: d76318ef by Pier Angelo Vendrame at 2024-08-14T15:13:42+00:00 fixup! Firefox preference overrides. Bug 43051: Hide the checkbox to open the browser automatically on Windows startup. - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -660,6 +660,9 @@ pref("browser.privacySegmentation.createdShortcut", true); // Do not re-open the browser automatically after reboots when "Restart apps" is // enabled (tor-browser#41503) pref("toolkit.winRegisterApplicationRestart", false); +// tor-browser#43051: Hide the checkbox to open the browser automatically on +// Windows startup. +pref("browser.startup.windowsLaunchOnLogin.enabled", false); #endif // If we are bundling fonts, whitelist those bundled fonts, and restrict system fonts to a selection. View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/d76… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/d76… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-128.1.0esr-14.0-1] fixup! Firefox preference overrides.
by morgan (＠morgan) 14 Aug '24

14 Aug '24

morgan pushed to branch base-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: fa88d8d5 by Pier Angelo Vendrame at 2024-08-14T15:05:01+00:00 fixup! Firefox preference overrides. Bug 43051: Hide the checkbox to open the browser automatically on Windows startup. - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -662,6 +662,9 @@ pref("browser.privacySegmentation.createdShortcut", true); // Do not re-open the browser automatically after reboots when "Restart apps" is // enabled (tor-browser#41503) pref("toolkit.winRegisterApplicationRestart", false); +// tor-browser#43051: Hide the checkbox to open the browser automatically on +// Windows startup. +pref("browser.startup.windowsLaunchOnLogin.enabled", false); #endif // If we are bundling fonts, whitelist those bundled fonts, and restrict system fonts to a selection. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/fa88d8d… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/fa88d8d… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.1.0esr-14.0-1] fixup! Firefox preference overrides.
by morgan (＠morgan) 14 Aug '24

14 Aug '24

morgan pushed to branch tor-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 983e902d by Pier Angelo Vendrame at 2024-08-14T14:53:47+00:00 fixup! Firefox preference overrides. Bug 43051: Hide the checkbox to open the browser automatically on Windows startup. - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -664,6 +664,9 @@ pref("browser.privacySegmentation.createdShortcut", true); // Do not re-open the browser automatically after reboots when "Restart apps" is // enabled (tor-browser#41503) pref("toolkit.winRegisterApplicationRestart", false); +// tor-browser#43051: Hide the checkbox to open the browser automatically on +// Windows startup. +pref("browser.startup.windowsLaunchOnLogin.enabled", false); #endif // If we are bundling fonts, whitelist those bundled fonts, and restrict system fonts to a selection. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/983e902… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/983e902… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.1.0esr-14.0-1] 2 commits: fixup! Bug 26345: Hide tracking protection UI
by Pier Angelo Vendrame (＠pierov) 14 Aug '24

14 Aug '24

Pier Angelo Vendrame pushed to branch mullvad-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser Commits: 9c70dce5 by Henry Wilkes at 2024-08-14T11:21:37+02:00 fixup! Bug 26345: Hide tracking protection UI Bug 42679: Revert change to hide tracking protection toolbar icon and preferences. - - - - - a201460d by Henry Wilkes at 2024-08-14T11:21:39+02:00 fixup! Bug 26345: Hide tracking protection UI Bug 42679: Re-hide the tracking protections UI. We hide the toolbar button with CSS. We hide the preferences using data-hidden-from-search. - - - - - 4 changed files: - browser/base/content/browser-siteIdentity.js - browser/components/preferences/privacy.inc.xhtml - browser/themes/shared/identity-block/identity-block.css - browser/themes/shared/preferences/privacy.css Changes: ===================================== browser/base/content/browser-siteIdentity.js ===================================== @@ -942,10 +942,10 @@ var gIdentityHandler = { gPermissionPanel.refreshPermissionIcons(); } - // Bug 26345: Hide tracking protection UI. + // Hide the shield icon if it is a chrome page. gProtectionsHandler._trackingProtectionIconContainer.classList.toggle( "chromeUI", - true + this._isSecureInternalUI ); }, ===================================== browser/components/preferences/privacy.inc.xhtml ===================================== @@ -15,7 +15,7 @@ </hbox>  -<groupbox id="trackingGroup" data-category="panePrivacy" hidden="true" aria-describedby="contentBlockingDescription" class="highlighting-group"> +<groupbox id="trackingGroup" data-category="panePrivacy" data-hidden-from-search="true" hidden="true" aria-describedby="contentBlockingDescription" class="highlighting-group"> <label id="contentBlockingHeader"><html:h2 data-l10n-id="content-blocking-enhanced-tracking-protection"/></label> <vbox data-subcategory="trackingprotection"> <hbox align="start"> ===================================== browser/themes/shared/identity-block/identity-block.css ===================================== @@ -230,6 +230,9 @@ /* TRACKING PROTECTION ICON */ #tracking-protection-icon-container { + /* Always hide the tracking toolbar button in Base Browser. + * tor-browser#26345. */ + display: none !important; padding-inline: var(--urlbar-icon-padding); border-radius: var(--urlbar-icon-border-radius); /* This is needed in order to position the blue dot indicator. */ ===================================== browser/themes/shared/preferences/privacy.css ===================================== @@ -63,10 +63,6 @@ /* Content Blocking */ -#trackingGroup { - display: none; -} - /* Override styling that sets descriptions as grey */ #trackingGroup description.indent, #trackingGroup .indent > description { View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/b2… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/b2… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-128.1.0esr-14.0-1] 2 commits: fixup! Bug 26345: Hide tracking protection UI
by Pier Angelo Vendrame (＠pierov) 14 Aug '24

14 Aug '24

Pier Angelo Vendrame pushed to branch base-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: df3f7281 by Henry Wilkes at 2024-08-14T11:20:54+02:00 fixup! Bug 26345: Hide tracking protection UI Bug 42679: Revert change to hide tracking protection toolbar icon and preferences. - - - - - c66e7939 by Henry Wilkes at 2024-08-14T11:20:55+02:00 fixup! Bug 26345: Hide tracking protection UI Bug 42679: Re-hide the tracking protections UI. We hide the toolbar button with CSS. We hide the preferences using data-hidden-from-search. - - - - - 4 changed files: - browser/base/content/browser-siteIdentity.js - browser/components/preferences/privacy.inc.xhtml - browser/themes/shared/identity-block/identity-block.css - browser/themes/shared/preferences/privacy.css Changes: ===================================== browser/base/content/browser-siteIdentity.js ===================================== @@ -942,10 +942,10 @@ var gIdentityHandler = { gPermissionPanel.refreshPermissionIcons(); } - // Bug 26345: Hide tracking protection UI. + // Hide the shield icon if it is a chrome page. gProtectionsHandler._trackingProtectionIconContainer.classList.toggle( "chromeUI", - true + this._isSecureInternalUI ); }, ===================================== browser/components/preferences/privacy.inc.xhtml ===================================== @@ -15,7 +15,7 @@ </hbox>  -<groupbox id="trackingGroup" data-category="panePrivacy" hidden="true" aria-describedby="contentBlockingDescription" class="highlighting-group"> +<groupbox id="trackingGroup" data-category="panePrivacy" data-hidden-from-search="true" hidden="true" aria-describedby="contentBlockingDescription" class="highlighting-group"> <label id="contentBlockingHeader"><html:h2 data-l10n-id="content-blocking-enhanced-tracking-protection"/></label> <vbox data-subcategory="trackingprotection"> <hbox align="start"> ===================================== browser/themes/shared/identity-block/identity-block.css ===================================== @@ -230,6 +230,9 @@ /* TRACKING PROTECTION ICON */ #tracking-protection-icon-container { + /* Always hide the tracking toolbar button in Base Browser. + * tor-browser#26345. */ + display: none !important; padding-inline: var(--urlbar-icon-padding); border-radius: var(--urlbar-icon-border-radius); /* This is needed in order to position the blue dot indicator. */ ===================================== browser/themes/shared/preferences/privacy.css ===================================== @@ -63,10 +63,6 @@ /* Content Blocking */ -#trackingGroup { - display: none; -} - /* Override styling that sets descriptions as grey */ #trackingGroup description.indent, #trackingGroup .indent > description { View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/cf4fca… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/cf4fca… You're receiving this email because of your account on gitlab.torproject.org.

1 0