July 2024 - tor-commits - lists.torproject.org

[Git][tpo/applications/tor-browser] Pushed new tag FIREFOX_128_0esr_RELEASE
by Pier Angelo Vendrame (＠pierov) 09 Jul '24

09 Jul '24

Pier Angelo Vendrame pushed new tag FIREFOX_128_0esr_RELEASE at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/FIREFOX_1… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/firefox-android][firefox-android-115.2.1-13.5-1] Bug 1836786 - Improve prompts a=dmeehan - BP, tor-browser#42693
by ma1 (＠ma1) 09 Jul '24

09 Jul '24

ma1 pushed to branch firefox-android-115.2.1-13.5-1 at The Tor Project / Applications / firefox-android Commits: 6271d708 by hackademix at 2024-07-09T14:38:08+02:00 Bug 1836786 - Improve prompts a=dmeehan - BP, tor-browser#42693 Note (ma1): backporting needed to update feature-sitepermissions dependency, relocate the PromptAbuserDetector import, de-internalize the class and patch its constructor, because of the refactorings happened in Bug 1903828. - - - - - 4 changed files: - android-components/.buildconfig.yml - android-components/components/feature/prompts/src/main/java/mozilla/components/feature/prompts/dialog/PromptAbuserDetector.kt - android-components/components/feature/sitepermissions/build.gradle - android-components/components/feature/sitepermissions/src/main/java/mozilla/components/feature/sitepermissions/SitePermissionsDialogFragment.kt Changes: ===================================== android-components/.buildconfig.yml ===================================== @@ -1150,6 +1150,7 @@ projects: - concept-tabstray - concept-toolbar - feature-session + - feature-prompts - feature-tabs - lib-publicsuffixlist - lib-state ===================================== android-components/components/feature/prompts/src/main/java/mozilla/components/feature/prompts/dialog/PromptAbuserDetector.kt ===================================== @@ -9,7 +9,7 @@ import java.util.Date /** * Helper class to identify if a website has shown many dialogs. */ -internal class PromptAbuserDetector { +class PromptAbuserDetector(private val maxSuccessiveDialogSecondsLimit: Int = MAX_SUCCESSIVE_DIALOG_SECONDS_LIMIT) { internal var jsAlertCount = 0 internal var lastDialogShownAt = Date() @@ -43,7 +43,7 @@ internal class PromptAbuserDetector { } else { val now = Date() val diffInSeconds = (now.time - lastDialogShownAt.time) / SECOND_MS - diffInSeconds < MAX_SUCCESSIVE_DIALOG_SECONDS_LIMIT + diffInSeconds < maxSuccessiveDialogSecondsLimit } } ===================================== android-components/components/feature/sitepermissions/build.gradle ===================================== @@ -58,6 +58,7 @@ dependencies { implementation project(':concept-engine') implementation project(':ui-icons') implementation project(':support-ktx') + implementation project(':feature-prompts') implementation project(':feature-tabs') implementation ComponentsDependencies.kotlin_coroutines ===================================== android-components/components/feature/sitepermissions/src/main/java/mozilla/components/feature/sitepermissions/SitePermissionsDialogFragment.kt ===================================== @@ -20,8 +20,10 @@ import android.widget.CheckBox import android.widget.ImageView import android.widget.LinearLayout.LayoutParams import android.widget.TextView +import androidx.annotation.VisibleForTesting import androidx.appcompat.app.AppCompatDialogFragment import androidx.core.content.ContextCompat +import mozilla.components.feature.prompts.dialog.PromptAbuserDetector internal const val KEY_SESSION_ID = "KEY_SESSION_ID" internal const val KEY_TITLE = "KEY_TITLE" @@ -41,6 +43,9 @@ private const val KEY_PERMISSION_ID = "KEY_PERMISSION_ID" internal open class SitePermissionsDialogFragment : AppCompatDialogFragment() { + @VisibleForTesting + internal var promptAbuserDetector = + PromptAbuserDetector(maxSuccessiveDialogSecondsLimit = TIME_SHOWN_OFFSET_SECONDS) // Safe Arguments private val safeArguments get() = requireNotNull(arguments) @@ -106,6 +111,8 @@ internal open class SitePermissionsDialogFragment : AppCompatDialogFragment() { } } + promptAbuserDetector.updateJSDialogAbusedState() + return sheetDialog } @@ -159,8 +166,16 @@ internal open class SitePermissionsDialogFragment : AppCompatDialogFragment() { val negativeButton = rootView.findViewById<Button>(R.id.deny_button) positiveButton.setOnClickListener { - feature?.onPositiveButtonPress(permissionRequestId, sessionId, userSelectionCheckBox) - dismiss() + if (promptAbuserDetector.areDialogsBeingAbused()) { + promptAbuserDetector.updateJSDialogAbusedState() + } else { + feature?.onPositiveButtonPress( + permissionRequestId, + sessionId, + userSelectionCheckBox, + ) + dismiss() + } } if (positiveButtonBackgroundColor != DEFAULT_VALUE) { @@ -255,5 +270,7 @@ internal open class SitePermissionsDialogFragment : AppCompatDialogFragment() { fragment.arguments = arguments return fragment } + + private const val TIME_SHOWN_OFFSET_SECONDS = 1 } } View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/commit/627… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/commit/627… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][maint-13.5] MB 314: Update desktop file
by Pier Angelo Vendrame (＠pierov) 08 Jul '24

08 Jul '24

Pier Angelo Vendrame pushed to branch maint-13.5 at The Tor Project / Applications / tor-browser-build Commits: 3879df70 by Nicolas Vigier at 2024-07-08T11:54:02+02:00 MB 314: Update desktop file Following @ruihildt's suggestions we update the desktop file: - Added MimeType field (to have the browser listed as a possible default browser application) - Removed `X-MullvadBrowser-ExecShell` which is not used - Removed the "Security" category - Added the Version (of the desktop entry specification we use) - Added Terminal - - - - - 1 changed file: - projects/linux-packages/browser.desktop.in Changes: ===================================== projects/linux-packages/browser.desktop.in ===================================== @@ -1,10 +1,14 @@ [Desktop Entry] +Version=1.0 Type=Application Name=[% c("var/Project_Name") %] GenericName=Web Browser Comment=[% c("var/system_pkg/pkg_description") %] -Categories=Network;WebBrowser;Security; +Categories=Network;WebBrowser; Exec=/[% c("var/system_pkg/install_path") %]/start-[% c("var/project-name") %] --detach -X-[% c("var/ProjectName") %]-ExecShell=/[% c("var/system_pkg/install_path") %]/start-[% c("var/project-name") %] --detach Icon=[% c("var/system_pkg/pkg_name") %] StartupWMClass=[% c("var/display_name") %] +[% IF ! c("var/tor-browser") -%] +MimeType=text/html;text/xml;application/xhtml_xml;x-scheme-handler/http;x-scheme-handler/https; +[% END -%] +Terminal=false View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/3… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/3… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] MB 314: Update desktop file
by Pier Angelo Vendrame (＠pierov) 08 Jul '24

08 Jul '24

Pier Angelo Vendrame pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 75a548af by Nicolas Vigier at 2024-06-27T15:22:18+02:00 MB 314: Update desktop file Following @ruihildt's suggestions we update the desktop file: - Added MimeType field (to have the browser listed as a possible default browser application) - Removed `X-MullvadBrowser-ExecShell` which is not used - Removed the "Security" category - Added the Version (of the desktop entry specification we use) - Added Terminal - - - - - 1 changed file: - projects/linux-packages/browser.desktop.in Changes: ===================================== projects/linux-packages/browser.desktop.in ===================================== @@ -1,10 +1,14 @@ [Desktop Entry] +Version=1.0 Type=Application Name=[% c("var/Project_Name") %] GenericName=Web Browser Comment=[% c("var/system_pkg/pkg_description") %] -Categories=Network;WebBrowser;Security; +Categories=Network;WebBrowser; Exec=/[% c("var/system_pkg/install_path") %]/start-[% c("var/project-name") %] --detach -X-[% c("var/ProjectName") %]-ExecShell=/[% c("var/system_pkg/install_path") %]/start-[% c("var/project-name") %] --detach Icon=[% c("var/system_pkg/pkg_name") %] StartupWMClass=[% c("var/display_name") %] +[% IF ! c("var/tor-browser") -%] +MimeType=text/html;text/xml;application/xhtml_xml;x-scheme-handler/http;x-scheme-handler/https; +[% END -%] +Terminal=false View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/7… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/7… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser] Pushed new tag mullvad-browser-115.13.0esr-13.5-1-build1
by Pier Angelo Vendrame (＠pierov) 08 Jul '24

08 Jul '24

Pier Angelo Vendrame pushed new tag mullvad-browser-115.13.0esr-13.5-1-build1 at The Tor Project / Applications / Mullvad Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/tree/mullv… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-115.13.0esr-13.5-1] 21 commits: MB 38: Mullvad Browser configuration
by Pier Angelo Vendrame (＠pierov) 08 Jul '24

08 Jul '24

Pier Angelo Vendrame pushed to branch mullvad-browser-115.13.0esr-13.5-1 at The Tor Project / Applications / Mullvad Browser Commits: e8071fe2 by Pier Angelo Vendrame at 2024-07-08T09:22:57+02:00 MB 38: Mullvad Browser configuration - - - - - 5cb0462e by Pier Angelo Vendrame at 2024-07-08T09:22:58+02:00 MB 1: Mullvad Browser branding See also: mullvad-browser#5: Product name and directory customization mullvad-browser#12: Create new branding directories and integrate Mullvad icons+branding mullvad-browser#14: Remove Default Built-in bookmarks mullvad-browser#35: Add custom PDF icons for Windows builds mullvad-browser#48: Replace Mozilla copyright and legal trademarks in mullvadbrowser.exe metadata mullvad-browser#51: Update trademark string mullvad-browser#104: Update shipped dll metadata copyright/licensing info mullvad-browser#107: Add alpha and nightly icons - - - - - c46cead3 by Pier Angelo Vendrame at 2024-07-08T09:22:59+02:00 MB 20: Allow packaged-addons in PBM. We install a few addons from the distribution directory, but they are not automatically enabled for PBM mode. This commit modifies the code that installs them to also add the PBM permission to the known ones. - - - - - 9ae18aa4 by Pier Angelo Vendrame at 2024-07-08T09:22:59+02:00 MB 63: Customize some about pages for Mullvad Browser Also: mullvad-browser#57: Purge unneeded about: pages - - - - - a061f565 by Pier Angelo Vendrame at 2024-07-08T09:22:59+02:00 MB 37: Customization for the about dialog - - - - - 04814410 by Henry Wilkes at 2024-07-08T09:23:00+02:00 MB 39: Add home page about:mullvad-browser - - - - - fbfbe8e0 by hackademix at 2024-07-08T09:23:00+02:00 MB 97: Remove UI cues to install new extensions. - - - - - 98be6718 by hackademix at 2024-07-08T09:23:00+02:00 MB 47: uBlock Origin customization - - - - - 18000d17 by Pier Angelo Vendrame at 2024-07-08T09:23:01+02:00 MB 21: Disable the password manager This commit disables the about:login page and removes the "Login and Password" section of about:preferences. We do not do anything to the real password manager of Firefox, that is in toolkit: it contains C++ parts that make it difficult to actually prevent it from being built.. Finally, we modify the the function that opens about:login to report an error in the console so that we can quickly get a backtrace to the code that tries to use it. - - - - - 1e27ca7f by Pier Angelo Vendrame at 2024-07-08T09:23:01+02:00 MB 112: Updater customization for Mullvad Browser MB 71: Set the updater base URL to Mullvad domain - - - - - f341437e by Nicolas Vigier at 2024-07-08T09:23:01+02:00 MB 79: Add Mullvad Browser MAR signing keys MB 256: Add mullvad-browser nightly mar signing key - - - - - 9125bb97 by Pier Angelo Vendrame at 2024-07-08T09:23:02+02:00 MB 34: Hide unsafe and unwanted preferences UI about:preferences allow to override some of our defaults, that could be fingeprintable or have some other unwanted consequences. - - - - - 1a5e3762 by Pier Angelo Vendrame at 2024-07-08T09:23:02+02:00 MB 160: Disable the cookie exceptions button Besides disabling the "Delete on close checkbox", disable also the "Manage Exceptions" button when always using PBM. - - - - - 8608e89f by hackademix at 2024-07-08T09:23:02+02:00 MB 163: prevent uBlock Origin from being uninstalled/disabled - - - - - 5e066d9c by Richard Pospesel at 2024-07-08T09:23:03+02:00 MB 188: Customize Gitlab Issue and Merge templates - - - - - 8cc44325 by rui hildt at 2024-07-08T09:23:03+02:00 MB 213: Customize the search engines list - - - - - 566d375f by hackademix at 2024-07-08T09:23:03+02:00 MB 214: Enable cross-tab identity leak protection in "quiet" mode - - - - - 4d846834 by Pier Angelo Vendrame at 2024-07-08T09:23:03+02:00 MB 234: Disable OS spoofing in HTTP User-Agent. This commits makes it possible to disable OS spoofing in the HTTP User-Agent header, to see if matching header and JS property improve usability. - - - - - b7bf9ed8 by Pier Angelo Vendrame at 2024-07-08T09:23:04+02:00 MB 80: Enable Mullvad Browser as a default browser - - - - - 1318e9d7 by Dan Ballard at 2024-07-08T09:23:04+02:00 MB 290: Add default bookmarks in alpha channel for testing - - - - - 0b81f7d8 by june wilde at 2024-07-08T09:23:04+02:00 MB 305: Disable setting default browser on Windows Until we can pull in upstream changes to fix breakage in setting the Mullvad Browser as default in Windows 10/11 we're disabling the ability to do so via about:preferences as well as via the startup query dialog - - - - - 30 changed files: - .gitlab/issue_templates/Emergency Security Issue.md - + .gitlab/issue_templates/Rebase Browser - Alpha.md - + .gitlab/issue_templates/Rebase Browser - Stable.md - .gitlab/merge_request_templates/default.md - browser/app/Makefile.in - browser/app/macbuild/Contents/Info.plist.in - browser/app/module.ver - browser/app/firefox.exe.manifest → browser/app/mullvadbrowser.exe.manifest - + browser/app/profile/000-mullvad-browser.js - browser/app/profile/001-base-profile.js - browser/base/content/aboutDialog.xhtml - browser/base/content/appmenu-viewcache.inc.xhtml - browser/base/content/browser-menubar.inc - browser/base/content/browser-places.js - browser/base/content/browser.js - browser/base/content/default-bookmarks.html - browser/base/content/nsContextMenu.js - browser/base/content/overrides/app-license.html - browser/base/content/pageinfo/pageInfo.xhtml - browser/base/content/utilityOverlay.js - browser/branding/branding-common.mozbuild - + browser/branding/mb-alpha/VisualElements_150.png - + browser/branding/mb-alpha/VisualElements_70.png - + browser/branding/mb-alpha/configure.sh - + browser/branding/mb-alpha/content/about-logo.png - + browser/branding/mb-alpha/content/about-logo.svg - + browser/branding/mb-alpha/content/about-logo(a)2x.png - + browser/branding/mb-alpha/content/about-wordmark.svg - + browser/branding/mb-alpha/content/about.png - + browser/branding/mb-alpha/content/aboutDialog.css The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/9d… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/9d… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser] Pushed new branch mullvad-browser-115.13.0esr-13.5-1
by Pier Angelo Vendrame (＠pierov) 08 Jul '24

08 Jul '24

Pier Angelo Vendrame pushed new branch mullvad-browser-115.13.0esr-13.5-1 at The Tor Project / Applications / Mullvad Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/tree/mullv… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag base-browser-115.13.0esr-13.5-1-build1
by Pier Angelo Vendrame (＠pierov) 08 Jul '24

08 Jul '24

Pier Angelo Vendrame pushed new tag base-browser-115.13.0esr-13.5-1-build1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/base-brow… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new branch base-browser-115.13.0esr-13.5-1
by Pier Angelo Vendrame (＠pierov) 08 Jul '24

08 Jul '24

Pier Angelo Vendrame pushed new branch base-browser-115.13.0esr-13.5-1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/base-brow… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag tor-browser-115.13.0esr-13.5-1-build1
by Pier Angelo Vendrame (＠pierov) 08 Jul '24

08 Jul '24

Pier Angelo Vendrame pushed new tag tor-browser-115.13.0esr-13.5-1-build1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0