May 2023 - tor-commits - lists.torproject.org

[Git][tpo/applications/tor-browser-update-responses][main] alpha: new version, 12.5a6
by richard (＠richard) 24 May '23

24 May '23

richard pushed to branch main at The Tor Project / Applications / Tor Browser update responses Commits: 6dc9b712 by Richard Pospesel at 2023-05-24T20:20:54+00:00 alpha: new version, 12.5a6 - - - - - 30 changed files: - update_3/alpha/.htaccess - − update_3/alpha/12.5a4-12.5a5-linux32-ALL.xml - − update_3/alpha/12.5a4-12.5a5-linux64-ALL.xml - − update_3/alpha/12.5a4-12.5a5-macos-ALL.xml - − update_3/alpha/12.5a4-12.5a5-win32-ALL.xml - − update_3/alpha/12.5a4-12.5a5-win64-ALL.xml - + update_3/alpha/12.5a4-12.5a6-linux32-ALL.xml - + update_3/alpha/12.5a4-12.5a6-linux64-ALL.xml - + update_3/alpha/12.5a4-12.5a6-macos-ALL.xml - + update_3/alpha/12.5a4-12.5a6-win32-ALL.xml - + update_3/alpha/12.5a4-12.5a6-win64-ALL.xml - + update_3/alpha/12.5a5-12.5a6-linux32-ALL.xml - + update_3/alpha/12.5a5-12.5a6-linux64-ALL.xml - + update_3/alpha/12.5a5-12.5a6-macos-ALL.xml - + update_3/alpha/12.5a5-12.5a6-win32-ALL.xml - + update_3/alpha/12.5a5-12.5a6-win64-ALL.xml - − update_3/alpha/12.5a5-linux32-ALL.xml - − update_3/alpha/12.5a5-linux64-ALL.xml - − update_3/alpha/12.5a5-macos-ALL.xml - − update_3/alpha/12.5a5-win32-ALL.xml - − update_3/alpha/12.5a5-win64-ALL.xml - + update_3/alpha/12.5a6-linux32-ALL.xml - + update_3/alpha/12.5a6-linux64-ALL.xml - + update_3/alpha/12.5a6-macos-ALL.xml - + update_3/alpha/12.5a6-win32-ALL.xml - + update_3/alpha/12.5a6-win64-ALL.xml - update_3/alpha/download-android-aarch64.json - update_3/alpha/download-android-armv7.json - update_3/alpha/download-android-x86.json - update_3/alpha/download-android-x86_64.json The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-update-responses… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-update-responses… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[torspec] branch main updated: tor-spec: Revise the CircID selection section
by gitolite role 24 May '23

24 May '23

This is an automated email from the git hooks/post-receive script. dgoulet pushed a commit to branch main in repository torspec. The following commit(s) were added to refs/heads/main by this push: new d612d23 tor-spec: Revise the CircID selection section new 646fbf7 Merge branch 'tor-gitlab/mr/125' d612d23 is described below commit d612d2344a4fe388401af35003ce695616845a97 Author: Emil Engler <me(a)emilengler.com> AuthorDate: Tue May 2 08:48:58 2023 +0200 tor-spec: Revise the CircID selection section This commit updates the "5.1.1. Choosing circuit IDs in create cells" section, in order to clarify its importance, as well as to adjust it to modern link protocol versions. The first goal is achieved, by directly adding a "MUST" in the first paragraph, alongside a reformulation in the paragraph explaining the method in link protocol version 4 or higher. The second goal is achieved by merging the second paragraph with the third paragraph, as the second paragraph only applies to the link protocol versions addressed in the third one. --- tor-spec.txt | 36 ++++++++++++++++++------------------ 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/tor-spec.txt b/tor-spec.txt index 8f30624..c6dbcfd 100644 --- a/tor-spec.txt +++ b/tor-spec.txt @@ -1068,28 +1068,28 @@ see tor-design.pdf. 5.1.1. Choosing circuit IDs in create cells - The CircID for a CREATE/CREATE2 cell is an arbitrarily chosen - nonzero integer, selected by the node (OP or OR) that sends the - CREATE/CREATE2 cell. In link protocol 3 or lower, CircIDs are 2 - bytes long; in protocol 4 or higher, CircIDs are 4 bytes long. - - To prevent CircID collisions, when one node sends a CREATE/CREATE2 - cell to another, it chooses from only one half of the possible - values based on the ORs' public identity keys. - - In link protocol version 3 or lower, if the sending node has a lower - key, it chooses a CircID with an MSB of 0; otherwise, it chooses a - CircID with an MSB of 1. (Public keys are compared numerically by - modulus.) With protocol version 3 or lower, a client with no public key - MAY choose any CircID it wishes, since clients never need to process a - CREATE/CREATE2 cell. + The CircID for a CREATE/CREATE2 cell is a nonzero integer, selected + by the node (OP or OR) that sends the CREATE/CREATED2 cell. + Depending on the link protocol version, there are certain rules for + choosing the value of CircID which MUST be obeyed, as implementations + MAY decide to refuse in case of a violation. In link protocol 3 or + lower, CircIDs are 2 bytes long; in protocol 4 or higher, CircIDs are + 4 bytes long. + + In link protocol version 3 or lower, the nodes choose from only one + half of the possible values based on the ORs' public identity keys, + in order to avoid collisions. If the sending node has a lower key, + it chooses a CircID with an MSB of 0; otherwise, it chooses a CircID + with an MSB of 1. (Public keys are compared numerically by modulus.) + A client with no public key MAY choose any CircID it wishes, since + clients never need to process CREATE/CREATE2 cells. In link protocol version 4 or higher, whichever node initiated the - connection sets its MSB to 1, and whichever node didn't initiate the - connection sets its MSB to 0. + connection MUST set its MSB to 1, and whichever node didn't initiate + the connection MUST set its MSB to 0. The CircID value 0 is specifically reserved for cells that do not - belong to any circuit: CircID 0 must not be used for circuits. No + belong to any circuit: CircID 0 MUST not be used for circuits. No other CircID value, including 0x8000 or 0x80000000, is reserved. Existing Tor implementations choose their CircID values at random from -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[torspec] branch main updated (a1cd058 -> 51e2149)
by gitolite role 24 May '23

24 May '23

This is an automated email from the git hooks/post-receive script. dgoulet pushed a change to branch main in repository torspec. from a1cd058 Merge branch 'tor-gitlab/mr/133' new 0d332d8 Prop329 updates for bug40781 new ee9f341 Note that we need to explicitly allow 2 INTROs new 1473e95 Prop#329: Clarity improvements new 7ea74b9 Prop329: Document Snowflake exemption to Guard restriction. new 51e2149 Merge branch 'tor-gitlab/mr/132' The 5 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: proposals/329-traffic-splitting.txt | 227 ++++++++++++++++++++++-------------- 1 file changed, 137 insertions(+), 90 deletions(-) -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 5

[torspec] branch main updated: rend-spec: Add a set of test vectors for hs-ntor.
by gitolite role 24 May '23

24 May '23

This is an automated email from the git hooks/post-receive script. dgoulet pushed a commit to branch main in repository torspec. The following commit(s) were added to refs/heads/main by this push: new eeb208d rend-spec: Add a set of test vectors for hs-ntor. new a1cd058 Merge branch 'tor-gitlab/mr/133' eeb208d is described below commit eeb208d5777b395412968317095ef82159e82403 Author: Nick Mathewson <nickm(a)torproject.org> AuthorDate: Thu May 18 08:57:34 2023 -0400 rend-spec: Add a set of test vectors for hs-ntor. These were generated using a patched Tor with extra logging info. I've used them to validate (and find bugs in) the arti hs-ntor implementation. (See arti!1189.) --- rend-spec-v3.txt | 92 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 92 insertions(+) diff --git a/rend-spec-v3.txt b/rend-spec-v3.txt index 4a12343..53880db 100644 --- a/rend-spec-v3.txt +++ b/rend-spec-v3.txt @@ -2723,3 +2723,95 @@ Appendix F. Two methods for managing revision counters. Similarly, implementations SHOULD NOT let the revision counter increase forever without resetting it -- doing so links the service across changes in the blinded public key. + +Appendix G. Text vectors + + G.1. Test vectors for hs-ntor / NTOR-WITH-EXTRA-DATA + + Here is a set of test values for the hs-ntor handshake, called + [NTOR-WITH-EXTRA-DATA] in this document. They were generated by + instrumenting Tor's code to dump the values for an INTRODUCE/RENDEZVOUS + handshake, and then by running that code on a Chutney network. + + We assume an onion service with: + + KP_hs_ipd_sid = 34E171E4358E501BFF21ED907E96AC6B + FEF697C779D040BBAF49ACC30FC5D21F + KP_hss_ntor = 8E5127A40E83AABF6493E41F142B6EE3 + 604B85A3961CD7E38D247239AFF71979 + KS_hss_ntor = A0ED5DBF94EEB2EDB3B514E4CF6ABFF6 + 022051CC5F103391F1970A3FCD15296A + N_hs_subcred = 0085D26A9DEBA252263BF0231AEAC59B + 17CA11BAD8A218238AD6487CBAD68B57 + + The client wants to make in INTRODUCE request. It generates + the following header (everything before the ENCRYPTED portion) + of its INTRODUCE1 cell: + + H = 000000000000000000000000000000000000000002002034E171E4358E501BFF + 21ED907E96AC6BFEF697C779D040BBAF49ACC30FC5D21F00 + + It generates the following plaintext body to encrypt. (This + is the "decrypted plaintext body" from [PROCESS_INTRO2]. + + P = 6BD364C12638DD5C3BE23D76ACA05B04E6CE932C0101000100200DE6130E4FCA + C4EDDA24E21220CC3EADAE403EF6B7D11C8273AC71908DE565450300067F0000 + 0113890214F823C4F8CC085C792E0AEE0283FE00AD7520B37D0320728D5DF39B + 7B7077A0118A900FF4456C382F0041300ACF9C58E51C392795EF870000000000 + 0000000000000000000000000000000000000000000000000000000000000000 + 000000000000000000000000000000000000000000000000000000000000 + + The client now begins the hs-ntor handshake. It generates + a curve25519 keypair: + + x = 60B4D6BF5234DCF87A4E9D7487BDF3F4 + A69B6729835E825CA29089CFDDA1E341 + X = BF04348B46D09AED726F1D66C618FDEA + 1DE58E8CB8B89738D7356A0C59111D5D + + Then it calculates: + + ENC_KEY = 9B8917BA3D05F3130DACCE5300C3DC27 + F6D012912F1C733036F822D0ED238706 + MAC_KEY = FC4058DA59D4DF61E7B40985D122F502 + FD59336BC21C30CAF5E7F0D4A2C38FD5 + + With these, it encrypts the plaintext body P with ENC_KEY, getting + an encrypted value C. It computes MAC(MAC_KEY, H | X | C), + getting a MAC value M. It then assembles the final INTRODUCE1 + body as H | X | C | M: + + 000000000000000000000000000000000000000002002034E171E4358E501BFF + 21ED907E96AC6BFEF697C779D040BBAF49ACC30FC5D21F00BF04348B46D09AED + 726F1D66C618FDEA1DE58E8CB8B89738D7356A0C59111D5DADBECCCB38E37830 + 4DCC179D3D9E437B452AF5702CED2CCFEC085BC02C4C175FA446525C1B9D5530 + 563C362FDFFB802DAB8CD9EBC7A5EE17DA62E37DEEB0EB187FBB48C63298B0E8 + 3F391B7566F42ADC97C46BA7588278273A44CE96BC68FFDAE31EF5F0913B9A9C + 7E0F173DBC0BDDCD4ACB4C4600980A7DDD9EAEC6E7F3FA3FC37CD95E5B8BFB3E + 35717012B78B4930569F895CB349A07538E42309C993223AEA77EF8AEA64F25D + DEE97DA623F1AEC0A47F150002150455845C385E5606E41A9A199E7111D54EF2 + D1A51B7554D8B3692D85AC587FB9E69DF990EFB776D8 + + Later the service receives that body in an INTRODUCE2 cell. It + processes it according to the hs-ntor handshake, and recovers + the client's plaintext P. To continue the hs-ntor handshake, + the service chooses a curve25519 keypair: + + y = 68CB5188CA0CD7924250404FAB54EE13 + 92D3D2B9C049A2E446513875952F8F55 + Y = 8FBE0DB4D4A9C7FF46701E3E0EE7FD05 + CD28BE4F302460ADDEEC9E93354EE700 + + From this and the client's input, it computes: + + AUTH_INPUT_MAC = 4A92E8437B8424D5E5EC279245D5C72B + 25A0327ACF6DAF902079FCB643D8B208 + NTOR_KEY_SEED = 4D0C72FE8AFF35559D95ECC18EB5A368 + 83402B28CDFD48C8A530A5A3D7D578DB + + The service sends back Y | AUTH_INPUT_MAC in its RENDEZVOUS1 cell + body. From these, the client finishes the handshake, validates + AUTH_INPUT_MAC, and computes the same NTOR_KEY_SEED. + + Now that both parties have the same NTOR_KEY_SEED, they can derive + the shared key material they will use for their circuit. -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[torspec] branch main updated (0d91005 -> 9c55db4)
by gitolite role 24 May '23

24 May '23

This is an automated email from the git hooks/post-receive script. dgoulet pushed a change to branch main in repository torspec. from 0d91005 Add info that onion v3 URLs use SHA3-256 new a3c88e1 proposal 327: Editing pass to align the spec with our implementation new 97c0c12 Describe identity-binding defense for intro-point POW new 9c55db4 Merge branch 'tor-gitlab/mr/134' The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: control-spec.txt | 5 + proposals/327-pow-over-intro.txt | 408 +++++++++++++++++++++++++-------------- 2 files changed, 272 insertions(+), 141 deletions(-) -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 3

[torspec] branch main updated: Add info that onion v3 URLs use SHA3-256
by gitolite role 24 May '23

24 May '23

This is an automated email from the git hooks/post-receive script. dgoulet pushed a commit to branch main in repository torspec. The following commit(s) were added to refs/heads/main by this push: new 0d91005 Add info that onion v3 URLs use SHA3-256 0d91005 is described below commit 0d91005ea655edaeda08cd9188066cf182c63868 Author: zocker1999net <me+tor-gitlab(a)banananet.work> AuthorDate: Tue May 23 21:31:51 2023 +0000 Add info that onion v3 URLs use SHA3-256 --- address-spec.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/address-spec.txt b/address-spec.txt index 98e7068..1e90e6e 100644 --- a/address-spec.txt +++ b/address-spec.txt @@ -1,4 +1,3 @@ - Special Hostnames in Tor Nick Mathewson @@ -71,6 +70,7 @@ Table of Contents - PUBKEY is the 32 bytes ed25519 master pubkey of the onion service. - VERSION is a one byte version field (default value '\x03') - ".onion checksum" is a constant string + - H is SHA3-256 - CHECKSUM is truncated to two bytes before inserting it in onion_address When Tor sees an address in this format, it tries to look up and connect to -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[tor] branch main updated (9976da9367 -> a2ec9a1199)
by gitolite role 24 May '23

24 May '23

This is an automated email from the git hooks/post-receive script. dgoulet pushed a change to branch main in repository tor. from 9976da9367 Merge branch 'tor-gitlab/mr/709' new c71b6a14a3 equix: avoid a coverity warning in hashx_alloc() new a3ff3155c2 test_crypto: avoid memory leak in some hashx test failures new 23f4a28f97 token_bucket_ctr: replace 32-bit wallclock time with monotime new a2ec9a1199 Merge branch 'tor-gitlab/mr/711' The 4 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: src/core/or/dos.c | 6 ++- src/ext/equix/hashx/src/context.c | 1 + src/feature/hs/hs_circuit.c | 3 +- src/feature/hs/hs_dos.c | 5 +- src/feature/hs/hs_intropoint.c | 3 +- src/feature/hs/hs_service.c | 3 +- src/lib/evloop/token_bucket.c | 111 +++++++++++++++++++------------------- src/lib/evloop/token_bucket.h | 12 ++--- src/lib/time/compat_time.c | 17 ++++++ src/lib/time/compat_time.h | 16 +++++- src/test/test_bwmgt.c | 24 ++++++++- src/test/test_crypto.c | 9 ++-- src/test/test_dos.c | 15 ++++-- src/test/test_hs_dos.c | 18 ++++--- src/test/test_hs_intropoint.c | 3 +- 15 files changed, 160 insertions(+), 86 deletions(-) -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 4

[tor] branch main updated (0781c2968d -> 9976da9367)
by gitolite role 24 May '23

24 May '23

This is an automated email from the git hooks/post-receive script. dgoulet pushed a change to branch main in repository tor. from 0781c2968d Merge branch 'tor-gitlab/mr/710' new a98b1d3ab6 Remove two conflux algs: maxrate and cwndrate. new c8341abf82 Clean up and disable switch rate limiting. new a340acb492 Clean up UX decision logic; hardcode for browser UX case. new 0c11577987 Fix unit tests. new 79dab29a05 Add torrc option for conflux client UX. new 032d850a2c Add changes file for conflux. new 9976da9367 Merge branch 'tor-gitlab/mr/709' The 7 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: changes/ticket40593 | 16 +++ doc/man/tor.1.txt | 7 ++ src/app/config/config.c | 18 ++++ src/app/config/or_options_st.h | 4 + src/core/or/conflux.c | 216 ++++++++--------------------------------- src/core/or/conflux_cell.c | 15 +-- src/core/or/conflux_cell.h | 2 +- src/core/or/conflux_pool.c | 41 ++++++-- src/core/or/conflux_pool.h | 2 + src/core/or/conflux_st.h | 2 - src/test/test_conflux_pool.c | 2 + 11 files changed, 126 insertions(+), 199 deletions(-) create mode 100644 changes/ticket40593 -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 7

[tor] branch main updated (6afe03aa51 -> 0781c2968d)
by gitolite role 24 May '23

24 May '23

This is an automated email from the git hooks/post-receive script. dgoulet pushed a change to branch main in repository tor. from 6afe03aa51 Merge branch 'tor-gitlab/mr/708' new 459b775a7e hs_pow: fix insufficient length check in pow-params new 71b2958a62 test_hs_descriptor: Add a test case that fails without the fix for 40793 new 0781c2968d Merge branch 'tor-gitlab/mr/710' The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: src/feature/hs/hs_descriptor.c | 21 ++++++++++--- src/feature/hs/hs_descriptor.h | 7 +++++ src/test/hs_test_helpers.c | 12 ++++++++ src/test/test_hs_descriptor.c | 69 ++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 105 insertions(+), 4 deletions(-) -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 3

[tor] branch main updated: ipv6: Flip ClientUseIPv6 to 1
by gitolite role 24 May '23

24 May '23

This is an automated email from the git hooks/post-receive script. dgoulet pushed a commit to branch main in repository tor. The following commit(s) were added to refs/heads/main by this push: new ffb764949e ipv6: Flip ClientUseIPv6 to 1 new 6afe03aa51 Merge branch 'tor-gitlab/mr/708' ffb764949e is described below commit ffb764949e7c1699af715298ce65279a2ee5df6e Author: agowa338 <gitlab.torproject.org(a)agowa338.de> AuthorDate: Sat Apr 29 17:28:30 2023 +0000 ipv6: Flip ClientUseIPv6 to 1 Fixes #40785 Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- changes/ticket40785 | 4 ++++ doc/man/tor.1.txt | 2 +- src/app/config/config.c | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/changes/ticket40785 b/changes/ticket40785 new file mode 100644 index 0000000000..998120011d --- /dev/null +++ b/changes/ticket40785 @@ -0,0 +1,4 @@ + o Minor feature (client, IPv6): + - Make client able to pick IPv6 relays by default now meaning ClientUseIPv6 + option now defaults to 1. Closes ticket 40785. + diff --git a/doc/man/tor.1.txt b/doc/man/tor.1.txt index 57992cd8d2..755cdfee5c 100644 --- a/doc/man/tor.1.txt +++ b/doc/man/tor.1.txt @@ -1180,7 +1180,7 @@ The following options are useful only for clients (that is, if entry nodes over IPv6. For IPv6 only hosts, you need to also set **ClientUseIPv4** to 0 to disable IPv4. Note that clients configured with an IPv6 address in a **Bridge**, proxy, or pluggable transportline will - try connecting over IPv6 even if **ClientUseIPv6** is set to 0. (Default: 0) + try connecting over IPv6 even if **ClientUseIPv6** is set to 0. (Default: 1) [[ConnectionPadding]] **ConnectionPadding** **0**|**1**|**auto**:: This option governs Tor's use of padding to defend against some forms of diff --git a/src/app/config/config.c b/src/app/config/config.c index 66a8fe5853..c680946c49 100644 --- a/src/app/config/config.c +++ b/src/app/config/config.c @@ -375,7 +375,7 @@ static const config_var_t option_vars_[] = { OBSOLETE("ClientAutoIPv6ORPort"), V(ClientRejectInternalAddresses, BOOL, "1"), V(ClientTransportPlugin, LINELIST, NULL), - V(ClientUseIPv6, BOOL, "0"), + V(ClientUseIPv6, BOOL, "1"), V(ClientUseIPv4, BOOL, "1"), V(ConfluxEnabled, AUTOBOOL, "auto"), V(ConnLimit, POSINT, "1000"), -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0