November 2023 - tor-commits - lists.torproject.org

[Git][tpo/applications/tor-browser][base-browser-115.4.0esr-13.5-1] fixup! Firefox preference overrides.
by ma1 (＠ma1) 14 Nov '23

14 Nov '23

ma1 pushed to branch base-browser-115.4.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: d2547154 by hackademix at 2023-11-14T16:48:51+01:00 fixup! Firefox preference overrides. - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -568,8 +568,6 @@ pref("extensions.abuseReport.enabled", false); // Therefore, do not allow … [View More]

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-115.4.0esr-13.5-1] fixup! Firefox preference overrides.
by ma1 (＠ma1) 14 Nov '23

14 Nov '23

ma1 pushed to branch mullvad-browser-115.4.0esr-13.5-1 at The Tor Project / Applications / Mullvad Browser Commits: c4345c65 by hackademix at 2023-11-14T10:55:14+01:00 fixup! Firefox preference overrides. - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -566,8 +566,6 @@ pref("extensions.abuseReport.enabled", false); // Therefore, do not … [View More]

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 17560: prevent disk leaks in $HOME/.local/share.
by ma1 (＠ma1) 14 Nov '23

14 Nov '23

ma1 pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 0de02285 by hackademix at 2023-11-14T10:18:11+01:00 Bug 17560: prevent disk leaks in $HOME/.local/share. - - - - - 2 changed files: - projects/browser/RelativeLink/start-browser - projects/browser/gtk3-settings.ini Changes: ===================================== projects/browser/RelativeLink/start-browser ===================================== @@ -257,6 +257,20 @@ fi HOME="${PWD}" export HOME +# … [View More]

1 0

[Git][tpo/applications/tor-browser] Pushed new tag FIREFOX_115_5_0esr_BUILD1
by Pier Angelo Vendrame (＠pierov) 13 Nov '23

13 Nov '23

Pier Angelo Vendrame pushed new tag FIREFOX_115_5_0esr_BUILD1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/FIREFOX_1… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.4.0esr-13.5-1] 11 commits: fixup! Bug 41659: Add canonical color definitions to base-browser
by richard (＠richard) 13 Nov '23

13 Nov '23

richard pushed to branch tor-browser-115.4.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: 5752d8e3 by Pier Angelo Vendrame at 2023-11-13T17:11:45+00:00 fixup! Bug 41659: Add canonical color definitions to base-browser Bug 42246: Migrate tor connection stuff from browser to toolkit - - - - - 755d7d23 by Pier Angelo Vendrame at 2023-11-13T17:11:45+00:00 fixup! Add TorStrings module for localization Bug 42246: Migrate tor connection stuff from browser to toolkit - - - - … [View More]- b8154f3f by Pier Angelo Vendrame at 2023-11-13T17:11:45+00:00 fixup! Bug 2176: Rebrand Firefox to TorBrowser Bug 42246: Migrate tor connection stuff from browser to toolkit - - - - - ed46347a by Pier Angelo Vendrame at 2023-11-13T17:11:45+00:00 fixup! Bug 40597: Implement TorSettings module Bug 42246: Migrate tor connection stuff from browser to toolkit - - - - - 8fadf4d1 by Pier Angelo Vendrame at 2023-11-13T17:11:45+00:00 fixup! Bug 40807: Added QRCode.js to toolkit/modules Bug 42246: Migrate tor connection stuff from browser to toolkit - - - - - 46ba3a3d by Pier Angelo Vendrame at 2023-11-13T17:11:45+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42246: Migrate tor connection stuff from browser to toolkit - - - - - e223ab68 by Pier Angelo Vendrame at 2023-11-13T17:11:45+00:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 42246: Migrate tor connection stuff from browser to toolkit - - - - - 1a3c5ebc by Pier Angelo Vendrame at 2023-11-13T17:11:45+00:00 fixup! Bug 7494: Create local home page for TBB. Bug 42246: Migrate tor connection stuff from browser to toolkit - - - - - 7c7d9e4e by Pier Angelo Vendrame at 2023-11-13T17:11:45+00:00 fixup! Bug 30237: Add v3 onion services client authentication prompt Bug 42246: Migrate tor connection stuff from browser to toolkit - - - - - dda97fdf by Pier Angelo Vendrame at 2023-11-13T17:11:45+00:00 fixup! Bug 21952: Implement Onion-Location Bug 42246: Migrate tor connection stuff from browser to toolkit - - - - - 16732592 by Pier Angelo Vendrame at 2023-11-13T17:11:45+00:00 fixup! Bug 40458: Implement .tor.onion aliases Bug 42246: Migrate tor connection stuff from browser to toolkit - - - - - 30 changed files: - browser/base/content/browser.js - browser/base/content/browser.xhtml - browser/base/content/navigator-toolbox.inc.xhtml - browser/components/BrowserGlue.sys.mjs - browser/components/about/AboutRedirector.cpp - browser/components/about/components.conf - browser/components/abouttor/AboutTorParent.sys.mjs - browser/components/abouttor/content/aboutTor.css - browser/components/moz.build - browser/components/onionservices/OnionAliasStore.jsm → browser/components/onionservices/OnionAliasStore.sys.mjs - browser/components/onionservices/OnionLocationChild.jsm → browser/components/onionservices/OnionLocationChild.sys.mjs - browser/components/onionservices/OnionLocationParent.jsm → browser/components/onionservices/OnionLocationParent.sys.mjs - browser/components/onionservices/content/authPreferences.css - browser/components/onionservices/content/authPreferences.js - browser/components/onionservices/content/authPrompt.js - browser/components/onionservices/content/onionlocationPreferences.js - browser/components/onionservices/content/savedKeysDialog.js - browser/components/onionservices/moz.build - − browser/components/rulesets/RulesetsChild.jsm - + browser/components/rulesets/RulesetsChild.sys.mjs - browser/components/rulesets/RulesetsParent.jsm → browser/components/rulesets/RulesetsParent.sys.mjs - browser/components/rulesets/moz.build - − browser/components/torconnect/jar.mn - browser/components/torpreferences/content/bridgeQrDialog.jsm → browser/components/torpreferences/content/bridgeQrDialog.mjs - browser/components/torpreferences/content/builtinBridgeDialog.jsm → browser/components/torpreferences/content/builtinBridgeDialog.mjs - browser/components/torpreferences/content/connectionPane.js - browser/components/torpreferences/content/connectionSettingsDialog.jsm → browser/components/torpreferences/content/connectionSettingsDialog.mjs - browser/components/torpreferences/content/provideBridgeDialog.jsm → browser/components/torpreferences/content/provideBridgeDialog.mjs - browser/components/torpreferences/content/requestBridgeDialog.jsm → browser/components/torpreferences/content/requestBridgeDialog.mjs - browser/components/torpreferences/content/torLogDialog.jsm → browser/components/torpreferences/content/torLogDialog.mjs The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/f68e26… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/f68e26… You're receiving this email because of your account on gitlab.torproject.org. [View Less]

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.4.0esr-13.0-1] 2 commits: fixup! Bug 40933: Add tor-launcher functionality
by Pier Angelo Vendrame (＠pierov) 13 Nov '23

13 Nov '23

Pier Angelo Vendrame pushed to branch tor-browser-115.4.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 2f901371 by Pier Angelo Vendrame at 2023-11-13T17:55:50+01:00 fixup! Bug 40933: Add tor-launcher functionality Bug 42108: Use the sentconnect event to update the circuit display In this way, the circuit might be updated more often, because some circuits will not work for some sites, but it might be what users want, especially when the browser fails and you would like … [View More]to know the exit node that has been blocked. - - - - - 934aa459 by Pier Angelo Vendrame at 2023-11-13T17:55:51+01:00 fixup! Bug 3455: Add DomainIsolator, for isolating circuit by domain. Bug 42108: Use the sentconnect event to update the circuit display Use the new topic name in the domain isolator. - - - - - 4 changed files: - toolkit/components/tor-launcher/TorControlPort.sys.mjs - toolkit/components/tor-launcher/TorDomainIsolator.sys.mjs - toolkit/components/tor-launcher/TorProvider.sys.mjs - toolkit/components/tor-launcher/TorProviderBuilder.sys.mjs Changes: ===================================== toolkit/components/tor-launcher/TorControlPort.sys.mjs ===================================== @@ -1043,15 +1043,15 @@ export class TorController { } break; case "STREAM": - const succeeedEvent = - /^(?<StreamID>[a-zA-Z0-9]{1,16})\sSUCCEEDED\s(?<CircuitID>[a-zA-Z0-9]{1,16})/.exec( + const sentConnectEvent = + /^(?<StreamID>[a-zA-Z0-9]{1,16})\sSENTCONNECT\s(?<CircuitID>[a-zA-Z0-9]{1,16})/.exec( data.groups.data ); - if (succeeedEvent) { + if (sentConnectEvent) { const credentials = this.#parseCredentials(data.groups.data); - this.#eventHandler.onStreamSucceeded( - succeeedEvent.groups.StreamID, - succeeedEvent.groups.CircuitID, + this.#eventHandler.onStreamSentConnect( + sentConnectEvent.groups.StreamID, + sentConnectEvent.groups.CircuitID, credentials?.username ?? null, credentials?.password ?? null ); @@ -1190,8 +1190,9 @@ export class TorController { * (i.e., a CIRC event with a BUILT status) * @property {OnCircuitClosed} onCircuitClosed Called when a circuit is closed * (i.e., a CIRC event with a CLOSED status) - * @property {OnStreamSucceeded} onStreamSucceeded Called when a stream receives - * a reply (i.e., a STREAM event with a SUCCEEDED status) + * @property {OnStreamSentConnect} onStreamSentConnect Called when a stream sent + * a connect cell along a circuit (i.e., a STREAM event with a SENTCONNECT + * status) */ /** * @callback OnBootstrapStatus @@ -1217,7 +1218,7 @@ export class TorController { * @param {CircuitID} id The id of the circuit that has been closed */ /** - * @callback OnStreamSucceeded + * @callback OnStreamSentConnect * * @param {StreamID} streamId The id of the stream that switched to the succeeded * state ===================================== toolkit/components/tor-launcher/TorDomainIsolator.sys.mjs ===================================== @@ -146,7 +146,10 @@ class TorDomainIsolatorImpl { Services.prefs.addObserver(NON_TOR_PROXY_PREF, this); Services.obs.addObserver(this, NEW_IDENTITY_TOPIC); - Services.obs.addObserver(this, lazy.TorProviderTopics.StreamSucceeded); + Services.obs.addObserver( + this, + lazy.TorProviderTopics.CircuitCredentialsMatched + ); this.#cleanupIntervalId = setInterval( this.#clearKnownCircuits.bind(this), @@ -161,7 +164,10 @@ class TorDomainIsolatorImpl { uninit() { Services.prefs.removeObserver(NON_TOR_PROXY_PREF, this); Services.obs.removeObserver(this, NEW_IDENTITY_TOPIC); - Services.obs.removeObserver(this, lazy.TorProviderTopics.StreamSucceeded); + Services.obs.removeObserver( + this, + lazy.TorProviderTopics.CircuitCredentialsMatched + ); clearInterval(this.#cleanupIntervalId); this.#cleanupIntervalId = null; this.clearIsolation(); @@ -266,7 +272,7 @@ class TorDomainIsolatorImpl { logger.error("Could not send the newnym command", e); // TODO: What UX to use here? See tor-browser#41708 } - } else if (topic === lazy.TorProviderTopics.StreamSucceeded) { + } else if (topic === lazy.TorProviderTopics.CircuitCredentialsMatched) { const { username, password, circuit } = subject.wrappedJSObject; this.#updateCircuit(username, password, circuit); } ===================================== toolkit/components/tor-launcher/TorProvider.sys.mjs ===================================== @@ -991,19 +991,19 @@ export class TorProvider { } /** - * Handle a notification about a stream switching to the succeeded state. + * Handle a notification about a stream switching to the sentconnect status. * * @param {StreamID} streamId The ID of the stream that switched to the - * succeeded state. + * sentconnect status. * @param {CircuitID} circuitId The ID of the circuit used by the stream * @param {string} username The SOCKS username * @param {string} password The SOCKS password */ - async onStreamSucceeded(streamId, circuitId, username, password) { + async onStreamSentConnect(streamId, circuitId, username, password) { if (!username || !password) { return; } - logger.debug("Stream succeeded event", username, password, circuitId); + logger.debug("Stream sentconnect event", username, password, circuitId); let circuit = this.#circuits.get(circuitId); if (!circuit) { circuit = new Promise((resolve, reject) => { @@ -1017,7 +1017,7 @@ export class TorProvider { this.#circuits.set(id, nodes); } logger.error( - `Seen a STREAM SUCCEEDED with circuit ${circuitId}, but Tor did not send information about it.` + `Seen a STREAM SENTCONNECT with circuit ${circuitId}, but Tor did not send information about it.` ); reject(); }); @@ -1037,7 +1037,7 @@ export class TorProvider { circuit, }, }, - TorProviderTopics.StreamSucceeded + TorProviderTopics.CircuitCredentialsMatched ); } } ===================================== toolkit/components/tor-launcher/TorProviderBuilder.sys.mjs ===================================== @@ -15,7 +15,7 @@ export const TorProviderTopics = Object.freeze({ BootstrapError: "TorBootstrapError", HasWarnOrErr: "TorLogHasWarnOrErr", BridgeChanged: "TorBridgeChanged", - StreamSucceeded: "TorStreamSucceeded", + CircuitCredentialsMatched: "TorCircuitCredentialsMatched", }); export const TorProviders = Object.freeze({ View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/20f764… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/20f764… You're receiving this email because of your account on gitlab.torproject.org. [View Less]

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.4.0esr-13.5-1] fixup! Bug 42072: 2023 year end campaign for about:tor.
by richard (＠richard) 13 Nov '23

13 Nov '23

richard pushed to branch tor-browser-115.4.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: f68e26b8 by Henry Wilkes at 2023-11-13T16:23:07+00:00 fixup! Bug 42072: 2023 year end campaign for about:tor. Bug 42188: Make the YEC banner closed state persist for the current session. - - - - - 4 changed files: - browser/components/BrowserGlue.sys.mjs - browser/components/abouttor/AboutTorChild.sys.mjs - browser/components/abouttor/AboutTorParent.sys.mjs - browser/components/… [View More]abouttor/content/aboutTor.js Changes: ===================================== browser/components/BrowserGlue.sys.mjs ===================================== @@ -453,6 +453,7 @@ let JSWINDOWACTORS = { events: { DOMContentLoaded: {}, SubmitSearchOnionize: { wantUntrusted: true }, + YECHidden: { wantUntrusted: true }, }, }, ===================================== browser/components/abouttor/AboutTorChild.sys.mjs ===================================== @@ -26,6 +26,11 @@ export class AboutTorChild extends JSWindowActorChild { case "SubmitSearchOnionize": this.sendAsyncMessage("AboutTor:SetSearchOnionize", !!event.detail); break; + case "YECHidden": + // YEC 2023 banner was closed. Persist this for the rest of this + // session. See tor-browser#42188. + this.sendAsyncMessage("AboutTor:HideYEC"); + break; } } } ===================================== browser/components/abouttor/AboutTorParent.sys.mjs ===================================== @@ -7,6 +7,19 @@ ChromeUtils.defineESModuleGetters(lazy, { TorConnect: "resource:///modules/TorConnect.sys.mjs", }); +/** + * Whether we should hide the Year end campaign (YEC) 2023 donation banner for + * new about:tor pages. Applied to all future about:tor pages within this + * session (i.e. new tabs, new windows, and after new identity). + * + * Will reset back to shown at the next full restart. + * + * See tor-browser#42188. + * + * @type {boolean} + */ +let hideYEC = false; + export class AboutTorParent extends JSWindowActorParent { receiveMessage(message) { const onionizePref = "torbrowser.homepage.search.onionize"; @@ -22,10 +35,14 @@ export class AboutTorParent extends JSWindowActorParent { Services.locale.appLocaleAsBCP47 === "ja-JP-macos" ? "ja" : Services.locale.appLocaleAsBCP47, + hideYEC, }); case "AboutTor:SetSearchOnionize": Services.prefs.setBoolPref(onionizePref, message.data); break; + case "AboutTor:HideYEC": + hideYEC = true; + break; } return undefined; } ===================================== browser/components/abouttor/content/aboutTor.js ===================================== @@ -200,6 +200,7 @@ const YecWidget = { this.isActive = now >= yecStart && now < yecEnd; document.getElementById("yec-2023-close").addEventListener("click", () => { + dispatchEvent(new CustomEvent("YECHidden", { bubbles: true })); this.isOpen = false; }); @@ -215,7 +216,7 @@ const YecWidget = { _isStable: false, _isActive: false, - _isOpen: true, + _isOpen: false, /** * Whether this is a stable release. @@ -294,7 +295,8 @@ window.addEventListener("DOMContentLoaded", () => { }); window.addEventListener("InitialData", event => { - const { appLocale, isStable } = event.detail; + const { appLocale, isStable, hideYEC } = event.detail; YecWidget.setDonateLocale(appLocale); YecWidget.isStable = isStable; + YecWidget.isOpen = !hideYEC; }); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/f68e26b… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/f68e26b… You're receiving this email because of your account on gitlab.torproject.org. [View Less]

1 0

[Git][tpo/applications/rbm][main] Bug 40064: Fix usage of exec without git_url/hg_url
by richard (＠richard) 13 Nov '23

13 Nov '23

richard pushed to branch main at The Tor Project / Applications / RBM Commits: 4fd67eea by Nicolas Vigier at 2023-11-08T08:51:23+01:00 Bug 40064: Fix usage of exec without git_url/hg_url - - - - - 2 changed files: - doc/rbm_templates.asc - lib/RBM.pm Changes: ===================================== doc/rbm_templates.asc ===================================== @@ -107,7 +107,9 @@ exec:: considered to be a script, which will be written to a temporary file and executed. The … [View More]

1 0

[Git][tpo/applications/tor-browser][base-browser-115.4.0esr-13.5-1] fixup! Firefox preference overrides.
by Pier Angelo Vendrame (＠pierov) 13 Nov '23

13 Nov '23

Pier Angelo Vendrame pushed to branch base-browser-115.4.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: a7078534 by Pier Angelo Vendrame at 2023-11-13T15:11:18+01:00 fixup! Firefox preference overrides. Bug 42153: Drop dom.enable_resource_timing = false - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -344,7 +344,6 @@ … [View More]

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-115.4.0esr-13.5-1] fixup! Firefox preference overrides.
by Pier Angelo Vendrame (＠pierov) 13 Nov '23

13 Nov '23

Pier Angelo Vendrame pushed to branch mullvad-browser-115.4.0esr-13.5-1 at The Tor Project / Applications / Mullvad Browser Commits: 8c9191c8 by Pier Angelo Vendrame at 2023-11-13T15:10:56+01:00 fixup! Firefox preference overrides. Bug 42153: Drop dom.enable_resource_timing = false - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -344,7 +… [View More]

1 0