Pier Angelo Vendrame pushed to branch maint-13.0 at The Tor Project / Applications / tor-browser-build
Commits:
7ea63162 by Pier Angelo Vendrame at 2023-10-18T09:48:29+02:00
Bug 40984: Include PDBs also from obj-*/dist.
Because of a difference between the investigation on adding PDBs and
the actual implementation, we were missing .pdb files for .exe files.
- - - - -
1 changed file:
- projects/firefox/build
Changes:
=====================================
projects/firefox/build
=====================================
@@ -229,7 +229,7 @@ RBM_TB_EOF
mkdir -p $distdir/Debug/Browser
pushd obj-*
cp -Lr dist/include $distdir/Debug/
- find . \( -path ./dist -o -path ./_tests \) -prune -o -name '*.pdb' -exec cp -l {} $distdir/Debug/Browser/ \;
+ find . -path ./_tests -prune -o -name '*.pdb' -exec cp -l {} $distdir/Debug/Browser/ \;
popd
[% END -%]
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/7…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/7…
You're receiving this email because of your account on gitlab.torproject.org.
Pier Angelo Vendrame pushed to branch main at The Tor Project / Applications / tor-browser-build
Commits:
ffafd421 by Pier Angelo Vendrame at 2023-10-17T18:41:56+02:00
Bug 40984: Include PDBs also from obj-*/dist.
Because of a difference between the investigation on adding PDBs and
the actual implementation, we were missing .pdb files for .exe files.
- - - - -
1 changed file:
- projects/firefox/build
Changes:
=====================================
projects/firefox/build
=====================================
@@ -229,7 +229,7 @@ RBM_TB_EOF
mkdir -p $distdir/Debug/Browser
pushd obj-*
cp -Lr dist/include $distdir/Debug/
- find . \( -path ./dist -o -path ./_tests \) -prune -o -name '*.pdb' -exec cp -l {} $distdir/Debug/Browser/ \;
+ find . -path ./_tests -prune -o -name '*.pdb' -exec cp -l {} $distdir/Debug/Browser/ \;
popd
[% END -%]
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/f…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/f…
You're receiving this email because of your account on gitlab.torproject.org.
richard pushed to branch tor-browser-115.4.0esr-13.5-1 at The Tor Project / Applications / Tor Browser
Commits:
890eb18c by Pier Angelo Vendrame at 2023-10-17T16:26:43+02:00
fixup! Bug 40933: Add tor-launcher functionality
Bug 42108: Use the sentconnect event to update the circuit display
In this way, the circuit might be updated more often, because some
circuits will not work for some sites, but it might be what users want,
especially when the browser fails and you would like to know the exit
node that has been blocked.
- - - - -
d4cf2169 by Pier Angelo Vendrame at 2023-10-17T16:29:23+02:00
fixup! Bug 3455: Add DomainIsolator, for isolating circuit by domain.
Bug 42108: Use the sentconnect event to update the circuit display
Use the new topic name in the domain isolator.
- - - - -
4 changed files:
- toolkit/components/tor-launcher/TorControlPort.sys.mjs
- toolkit/components/tor-launcher/TorDomainIsolator.sys.mjs
- toolkit/components/tor-launcher/TorProvider.sys.mjs
- toolkit/components/tor-launcher/TorProviderBuilder.sys.mjs
Changes:
=====================================
toolkit/components/tor-launcher/TorControlPort.sys.mjs
=====================================
@@ -1043,15 +1043,15 @@ export class TorController {
}
break;
case "STREAM":
- const succeeedEvent =
- /^(?<StreamID>[a-zA-Z0-9]{1,16})\sSUCCEEDED\s(?<CircuitID>[a-zA-Z0-9]{1,16})/.exec(
+ const sentConnectEvent =
+ /^(?<StreamID>[a-zA-Z0-9]{1,16})\sSENTCONNECT\s(?<CircuitID>[a-zA-Z0-9]{1,16})/.exec(
data.groups.data
);
- if (succeeedEvent) {
+ if (sentConnectEvent) {
const credentials = this.#parseCredentials(data.groups.data);
- this.#eventHandler.onStreamSucceeded(
- succeeedEvent.groups.StreamID,
- succeeedEvent.groups.CircuitID,
+ this.#eventHandler.onStreamSentConnect(
+ sentConnectEvent.groups.StreamID,
+ sentConnectEvent.groups.CircuitID,
credentials?.username ?? null,
credentials?.password ?? null
);
@@ -1190,8 +1190,9 @@ export class TorController {
* (i.e., a CIRC event with a BUILT status)
* @property {OnCircuitClosed} onCircuitClosed Called when a circuit is closed
* (i.e., a CIRC event with a CLOSED status)
- * @property {OnStreamSucceeded} onStreamSucceeded Called when a stream receives
- * a reply (i.e., a STREAM event with a SUCCEEDED status)
+ * @property {OnStreamSentConnect} onStreamSentConnect Called when a stream sent
+ * a connect cell along a circuit (i.e., a STREAM event with a SENTCONNECT
+ * status)
*/
/**
* @callback OnBootstrapStatus
@@ -1217,7 +1218,7 @@ export class TorController {
* @param {CircuitID} id The id of the circuit that has been closed
*/
/**
- * @callback OnStreamSucceeded
+ * @callback OnStreamSentConnect
*
* @param {StreamID} streamId The id of the stream that switched to the succeeded
* state
=====================================
toolkit/components/tor-launcher/TorDomainIsolator.sys.mjs
=====================================
@@ -146,7 +146,10 @@ class TorDomainIsolatorImpl {
Services.prefs.addObserver(NON_TOR_PROXY_PREF, this);
Services.obs.addObserver(this, NEW_IDENTITY_TOPIC);
- Services.obs.addObserver(this, lazy.TorProviderTopics.StreamSucceeded);
+ Services.obs.addObserver(
+ this,
+ lazy.TorProviderTopics.CircuitCredentialsMatched
+ );
this.#cleanupIntervalId = setInterval(
this.#clearKnownCircuits.bind(this),
@@ -161,7 +164,10 @@ class TorDomainIsolatorImpl {
uninit() {
Services.prefs.removeObserver(NON_TOR_PROXY_PREF, this);
Services.obs.removeObserver(this, NEW_IDENTITY_TOPIC);
- Services.obs.removeObserver(this, lazy.TorProviderTopics.StreamSucceeded);
+ Services.obs.removeObserver(
+ this,
+ lazy.TorProviderTopics.CircuitCredentialsMatched
+ );
clearInterval(this.#cleanupIntervalId);
this.#cleanupIntervalId = null;
this.clearIsolation();
@@ -266,7 +272,7 @@ class TorDomainIsolatorImpl {
logger.error("Could not send the newnym command", e);
// TODO: What UX to use here? See tor-browser#41708
}
- } else if (topic === lazy.TorProviderTopics.StreamSucceeded) {
+ } else if (topic === lazy.TorProviderTopics.CircuitCredentialsMatched) {
const { username, password, circuit } = subject.wrappedJSObject;
this.#updateCircuit(username, password, circuit);
}
=====================================
toolkit/components/tor-launcher/TorProvider.sys.mjs
=====================================
@@ -991,19 +991,19 @@ export class TorProvider {
}
/**
- * Handle a notification about a stream switching to the succeeded state.
+ * Handle a notification about a stream switching to the sentconnect status.
*
* @param {StreamID} streamId The ID of the stream that switched to the
- * succeeded state.
+ * sentconnect status.
* @param {CircuitID} circuitId The ID of the circuit used by the stream
* @param {string} username The SOCKS username
* @param {string} password The SOCKS password
*/
- async onStreamSucceeded(streamId, circuitId, username, password) {
+ async onStreamSentConnect(streamId, circuitId, username, password) {
if (!username || !password) {
return;
}
- logger.debug("Stream succeeded event", username, password, circuitId);
+ logger.debug("Stream sentconnect event", username, password, circuitId);
let circuit = this.#circuits.get(circuitId);
if (!circuit) {
circuit = new Promise((resolve, reject) => {
@@ -1017,7 +1017,7 @@ export class TorProvider {
this.#circuits.set(id, nodes);
}
logger.error(
- `Seen a STREAM SUCCEEDED with circuit ${circuitId}, but Tor did not send information about it.`
+ `Seen a STREAM SENTCONNECT with circuit ${circuitId}, but Tor did not send information about it.`
);
reject();
});
@@ -1037,7 +1037,7 @@ export class TorProvider {
circuit,
},
},
- TorProviderTopics.StreamSucceeded
+ TorProviderTopics.CircuitCredentialsMatched
);
}
}
=====================================
toolkit/components/tor-launcher/TorProviderBuilder.sys.mjs
=====================================
@@ -15,7 +15,7 @@ export const TorProviderTopics = Object.freeze({
BootstrapError: "TorBootstrapError",
HasWarnOrErr: "TorLogHasWarnOrErr",
BridgeChanged: "TorBridgeChanged",
- StreamSucceeded: "TorStreamSucceeded",
+ CircuitCredentialsMatched: "TorCircuitCredentialsMatched",
});
export const TorProviders = Object.freeze({
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/e1b116…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/e1b116…
You're receiving this email because of your account on gitlab.torproject.org.
Pier Angelo Vendrame pushed to branch mullvad-browser-115.4.0esr-13.5-1 at The Tor Project / Applications / Mullvad Browser
Commits:
0b82d6ad by Pier Angelo Vendrame at 2023-10-17T11:58:14+02:00
MB 38: Mullvad Browser configuration
- - - - -
889c419e by Pier Angelo Vendrame at 2023-10-17T11:58:17+02:00
MB 1: Mullvad Browser branding
See also:
mullvad-browser#5: Product name and directory customization
mullvad-browser#12: Create new branding directories and integrate Mullvad icons+branding
mullvad-browser#14: Remove Default Built-in bookmarks
mullvad-browser#35: Add custom PDF icons for Windows builds
mullvad-browser#48: Replace Mozilla copyright and legal trademarks in mullvadbrowser.exe metadata
mullvad-browser#51: Update trademark string
mullvad-browser#104: Update shipped dll metadata copyright/licensing info
mullvad-browser#107: Add alpha and nightly icons
- - - - -
0303cdbf by Pier Angelo Vendrame at 2023-10-17T12:00:20+02:00
fixup! MB 1: Mullvad Browser branding
MB 244: Fix the link to Mullvad Browser Support
- - - - -
1572b0c3 by Pier Angelo Vendrame at 2023-10-17T12:00:21+02:00
MB 20: Allow packaged-addons in PBM.
We install a few addons from the distribution directory, but they are
not automatically enabled for PBM mode.
This commit modifies the code that installs them to also add the PBM
permission to the known ones.
- - - - -
1b7be33b by Pier Angelo Vendrame at 2023-10-17T12:00:21+02:00
MB 63: Customize some about pages for Mullvad Browser
Also:
mullvad-browser#57: Purge unneeded about: pages
- - - - -
17b628c0 by Pier Angelo Vendrame at 2023-10-17T12:00:22+02:00
MB 37: Customization for the about dialog
- - - - -
cae48cd3 by Henry Wilkes at 2023-10-17T12:00:22+02:00
MB 39: Add home page about:mullvad-browser
- - - - -
b9fe9e6d by Pier Angelo Vendrame at 2023-10-17T12:00:22+02:00
fixup! MB 39: Add home page about:mullvad-browser
MB 243: Make sure about:mullvad-browser is treated as a new tab page
- - - - -
91554b7c by hackademix at 2023-10-17T12:00:23+02:00
MB 97: Remove UI cues to install new extensions.
- - - - -
91c377c1 by hackademix at 2023-10-17T12:00:23+02:00
MB 47: uBlock Origin customization
- - - - -
40bc3d0b by Pier Angelo Vendrame at 2023-10-17T12:00:23+02:00
MB 21: Disable the password manager
This commit disables the about:login page and removes the "Login and
Password" section of about:preferences.
We do not do anything to the real password manager of Firefox, that is
in toolkit: it contains C++ parts that make it difficult to actually
prevent it from being built..
Finally, we modify the the function that opens about:login to report an
error in the console so that we can quickly get a backtrace to the code
that tries to use it.
- - - - -
0bc79af4 by Pier Angelo Vendrame at 2023-10-17T12:00:24+02:00
MB 87: Disable the default browser box on Windows and Linux
Windows and Linux will be distributed only as portable apps at the
beginning, so they should not be settable as default browsers.
We will need to improve the logic once we decide to ship system-wide
installers, too.
- - - - -
7ade1eef by Pier Angelo Vendrame at 2023-10-17T12:00:24+02:00
MB 112: Updater customization for Mullvad Browser
MB 71: Set the updater base URL to Mullvad domain
- - - - -
4e175026 by Nicolas Vigier at 2023-10-17T12:00:25+02:00
MB 79: Add Mullvad Browser MAR signing keys
- - - - -
ffdf2559 by Pier Angelo Vendrame at 2023-10-17T12:00:25+02:00
MB 34: Hide unsafe and unwanted preferences UI
about:preferences allow to override some of our defaults, that could
be fingeprintable or have some other unwanted consequences.
- - - - -
33cbbc4b by Pier Angelo Vendrame at 2023-10-17T12:00:25+02:00
MB 160: Disable the cookie exceptions button
Besides disabling the "Delete on close checkbox", disable also the
"Manage Exceptions" button when always using PBM.
- - - - -
9b840580 by hackademix at 2023-10-17T12:00:26+02:00
MB 163: prevent uBlock Origin from being uninstalled/disabled
- - - - -
65ed1dc2 by Richard Pospesel at 2023-10-17T12:00:26+02:00
MB 188: Customize Gitlab Issue and Merge templates
- - - - -
ca7e7b89 by rui hildt at 2023-10-17T12:00:26+02:00
MB 213: Customize the search engines list
- - - - -
fb39df13 by hackademix at 2023-10-17T12:00:27+02:00
MB 214: Enable cross-tab identity leak protection in "quiet" mode
- - - - -
30 changed files:
- + .gitlab/issue_templates/Rebase Browser - Alpha.md
- + .gitlab/issue_templates/Rebase Browser - Stable.md
- .gitlab/merge_request_templates/default.md
- browser/app/Makefile.in
- browser/app/macbuild/Contents/Info.plist.in
- browser/app/module.ver
- browser/app/firefox.exe.manifest → browser/app/mullvadbrowser.exe.manifest
- + browser/app/profile/000-mullvad-browser.js
- browser/app/profile/001-base-profile.js
- browser/base/content/aboutDialog.xhtml
- browser/base/content/appmenu-viewcache.inc.xhtml
- browser/base/content/browser-menubar.inc
- browser/base/content/browser-places.js
- browser/base/content/browser.js
- browser/base/content/default-bookmarks.html
- browser/base/content/nsContextMenu.js
- browser/base/content/overrides/app-license.html
- browser/base/content/pageinfo/pageInfo.xhtml
- browser/base/content/utilityOverlay.js
- browser/branding/branding-common.mozbuild
- + browser/branding/mb-alpha/VisualElements_150.png
- + browser/branding/mb-alpha/VisualElements_70.png
- + browser/branding/mb-alpha/configure.sh
- + browser/branding/mb-alpha/content/about-logo.png
- + browser/branding/mb-alpha/content/about-logo.svg
- + browser/branding/mb-alpha/content/about-logo(a)2x.png
- + browser/branding/mb-alpha/content/about-wordmark.svg
- + browser/branding/mb-alpha/content/about.png
- + browser/branding/mb-alpha/content/aboutDialog.css
- + browser/branding/mb-alpha/content/firefox-wordmark.svg
The diff was not included because it is too large.
View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/b3…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/b3…
You're receiving this email because of your account on gitlab.torproject.org.