October 2023 - tor-commits - lists.torproject.org

[Git][tpo/applications/mullvad-browser][mullvad-browser-115.3.1esr-13.0-1] fixup! Bug 41454: Move focus after calling openPreferences for a sub-category.
by richard (＠richard) 11 Oct '23

11 Oct '23

richard pushed to branch mullvad-browser-115.3.1esr-13.0-1 at The Tor Project / Applications / Mullvad Browser Commits: 88e111c6 by Henry Wilkes at 2023-10-11T18:31:30+00:00 fixup! Bug 41454: Move focus after calling openPreferences for a sub-category. Bug 42167: Make the auto-focus more reliable. No longer use the setTimeout to wait a loop, but instead wait for the "load" event. - - - - - 1 changed file: - browser/components/preferences/preferences.js Changes: ===================================== browser/components/preferences/preferences.js ===================================== @@ -482,14 +482,23 @@ async function scrollAndHighlight(subcategory, category) { // We assign a tabindex=-1 to the element so that we can focus it. This allows // us to move screen reader's focus to an arbitrary position on the page. - // See tor-browser#41454 and bug 1799153. - element.setAttribute("tabindex", "-1"); - // The element is not always immediately focusable, so we wait until the next - // loop. - setTimeout(() => { + // See tor-browser#41454 and mozilla bug 1799153. + const doFocus = () => { + element.setAttribute("tabindex", "-1"); Services.focus.setFocus(element, Services.focus.FLAG_NOSCROLL); + // Immediately remove again now that it has focus. element.removeAttribute("tabindex"); - }); + }; + // The element is not always immediately focusable, so we wait until document + // load. + if (document.readyState === "complete") { + doFocus(); + } else { + // Wait until document load to move focus. + // NOTE: This should be called after DOMContentLoaded, where the searchInput + // is focused. + window.addEventListener("load", doFocus, { once: true }); + } scrollContentTo(header); element.classList.add("spotlight"); View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/88e… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/88e… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-115.3.1esr-13.0-1] fixup! Bug 41454: Move focus after calling openPreferences for a sub-category.
by richard (＠richard) 11 Oct '23

11 Oct '23

richard pushed to branch base-browser-115.3.1esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 3d78c742 by Henry Wilkes at 2023-10-11T18:30:21+00:00 fixup! Bug 41454: Move focus after calling openPreferences for a sub-category. Bug 42167: Make the auto-focus more reliable. No longer use the setTimeout to wait a loop, but instead wait for the "load" event. - - - - - 1 changed file: - browser/components/preferences/preferences.js Changes: ===================================== browser/components/preferences/preferences.js ===================================== @@ -482,14 +482,23 @@ async function scrollAndHighlight(subcategory, category) { // We assign a tabindex=-1 to the element so that we can focus it. This allows // us to move screen reader's focus to an arbitrary position on the page. - // See tor-browser#41454 and bug 1799153. - element.setAttribute("tabindex", "-1"); - // The element is not always immediately focusable, so we wait until the next - // loop. - setTimeout(() => { + // See tor-browser#41454 and mozilla bug 1799153. + const doFocus = () => { + element.setAttribute("tabindex", "-1"); Services.focus.setFocus(element, Services.focus.FLAG_NOSCROLL); + // Immediately remove again now that it has focus. element.removeAttribute("tabindex"); - }); + }; + // The element is not always immediately focusable, so we wait until document + // load. + if (document.readyState === "complete") { + doFocus(); + } else { + // Wait until document load to move focus. + // NOTE: This should be called after DOMContentLoaded, where the searchInput + // is focused. + window.addEventListener("load", doFocus, { once: true }); + } scrollContentTo(header); element.classList.add("spotlight"); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/3d78c74… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/3d78c74… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-115.3.1esr-13.0-1] fixup! Bug 40926: Implemented the New Identity feature
by richard (＠richard) 11 Oct '23

11 Oct '23

richard pushed to branch mullvad-browser-115.3.1esr-13.0-1 at The Tor Project / Applications / Mullvad Browser Commits: fae8c72e by Henry Wilkes at 2023-10-11T18:11:29+00:00 fixup! Bug 40926: Implemented the New Identity feature Bug 42166: Give new identity dialog an accessible name. - - - - - 1 changed file: - browser/components/newidentity/content/newIdentityDialog.xhtml Changes: ===================================== browser/components/newidentity/content/newIdentityDialog.xhtml ===================================== @@ -16,6 +16,7 @@ xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul" xmlns:html="http://www.w3.org/1999/xhtml" xmlns:xul="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul" + aria-labelledby="infoTitle" aria-describedby="infoBody" > <dialog id="newIdentityDialog" buttons="accept,cancel" defaultButton="accept"> View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/fae… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/fae… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-115.3.1esr-13.0-1] fixup! Bug 40926: Implemented the New Identity feature
by richard (＠richard) 11 Oct '23

11 Oct '23

richard pushed to branch base-browser-115.3.1esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 5c5e5ffb by Henry Wilkes at 2023-10-11T18:10:08+00:00 fixup! Bug 40926: Implemented the New Identity feature Bug 42166: Give new identity dialog an accessible name. - - - - - 1 changed file: - browser/components/newidentity/content/newIdentityDialog.xhtml Changes: ===================================== browser/components/newidentity/content/newIdentityDialog.xhtml ===================================== @@ -16,6 +16,7 @@ xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul" xmlns:html="http://www.w3.org/1999/xhtml" xmlns:xul="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul" + aria-labelledby="infoTitle" aria-describedby="infoBody" > <dialog id="newIdentityDialog" buttons="accept,cancel" defaultButton="accept"> View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/5c5e5ff… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/5c5e5ff… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.3.1esr-13.0-1] fixup! Bug 41454: Move focus after calling openPreferences for a sub-category.
by Pier Angelo Vendrame (＠pierov) 11 Oct '23

11 Oct '23

Pier Angelo Vendrame pushed to branch tor-browser-115.3.1esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 00e9622f by Henry Wilkes at 2023-10-11T11:24:18+01:00 fixup! Bug 41454: Move focus after calling openPreferences for a sub-category. Bug 42167: Make the auto-focus more reliable. No longer use the setTimeout to wait a loop, but instead wait for the "load" event. - - - - - 1 changed file: - browser/components/preferences/preferences.js Changes: ===================================== browser/components/preferences/preferences.js ===================================== @@ -491,14 +491,23 @@ async function scrollAndHighlight(subcategory, category) { // We assign a tabindex=-1 to the element so that we can focus it. This allows // us to move screen reader's focus to an arbitrary position on the page. - // See tor-browser#41454 and bug 1799153. - element.setAttribute("tabindex", "-1"); - // The element is not always immediately focusable, so we wait until the next - // loop. - setTimeout(() => { + // See tor-browser#41454 and mozilla bug 1799153. + const doFocus = () => { + element.setAttribute("tabindex", "-1"); Services.focus.setFocus(element, Services.focus.FLAG_NOSCROLL); + // Immediately remove again now that it has focus. element.removeAttribute("tabindex"); - }); + }; + // The element is not always immediately focusable, so we wait until document + // load. + if (document.readyState === "complete") { + doFocus(); + } else { + // Wait until document load to move focus. + // NOTE: This should be called after DOMContentLoaded, where the searchInput + // is focused. + window.addEventListener("load", doFocus, { once: true }); + } scrollContentTo(header); element.classList.add("spotlight"); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/00e9622… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/00e9622… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.3.1esr-13.0-1] fixup! Bug 40926: Implemented the New Identity feature
by Pier Angelo Vendrame (＠pierov) 11 Oct '23

11 Oct '23

Pier Angelo Vendrame pushed to branch tor-browser-115.3.1esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 6d62dc70 by Henry Wilkes at 2023-10-11T10:18:26+01:00 fixup! Bug 40926: Implemented the New Identity feature Bug 42166: Give new identity dialog an accessible name. - - - - - 1 changed file: - browser/components/newidentity/content/newIdentityDialog.xhtml Changes: ===================================== browser/components/newidentity/content/newIdentityDialog.xhtml ===================================== @@ -16,6 +16,7 @@ xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul" xmlns:html="http://www.w3.org/1999/xhtml" xmlns:xul="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul" + aria-labelledby="infoTitle" aria-describedby="infoBody" > <dialog id="newIdentityDialog" buttons="accept,cancel" defaultButton="accept"> View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/6d62dc7… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/6d62dc7… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/firefox-android][firefox-android-115.2.1-13.0-1] fixup! Modify UI/UX
by Dan Ballard (＠dan) 10 Oct '23

10 Oct '23

Dan Ballard pushed to branch firefox-android-115.2.1-13.0-1 at The Tor Project / Applications / firefox-android Commits: 2854981a by clairehurst at 2023-10-10T18:46:34+00:00 fixup! Modify UI/UX Bug 42158: Remove Customize Homepage button - - - - - 4 changed files: - fenix/app/src/main/java/org/mozilla/fenix/home/HomeMenu.kt - fenix/app/src/main/java/org/mozilla/fenix/home/HomeMenuView.kt - fenix/app/src/main/java/org/mozilla/fenix/settings/SettingsFragment.kt - fenix/app/src/main/res/xml/preferences.xml Changes: ===================================== fenix/app/src/main/java/org/mozilla/fenix/home/HomeMenu.kt ===================================== @@ -56,7 +56,7 @@ class HomeMenu( object ManageAccountAndDevices : Item() object WhatsNew : Item() object Help : Item() - object CustomizeHome : Item() +// object CustomizeHome : Item() object Settings : Item() object Quit : Item() object ReconnectSync : Item() @@ -175,13 +175,13 @@ class HomeMenu( onItemTapped.invoke(Item.Help) } - val customizeHomeItem = BrowserMenuImageText( - context.getString(R.string.browser_menu_customize_home_1), - R.drawable.ic_customize, - primaryTextColor, - ) { - onItemTapped.invoke(Item.CustomizeHome) - } +// val customizeHomeItem = BrowserMenuImageText( +// context.getString(R.string.browser_menu_customize_home_1), +// R.drawable.ic_customize, +// primaryTextColor, +// ) { +// onItemTapped.invoke(Item.CustomizeHome) +// } // Use nimbus to set the icon and title. // val nimbusValidation = FxNimbus.features.nimbusValidation.value() @@ -217,7 +217,7 @@ class HomeMenu( BrowserMenuDivider(), whatsNewItem, helpItem, - customizeHomeItem, +// customizeHomeItem, settingsItem, quitItem ).also { items -> ===================================== fenix/app/src/main/java/org/mozilla/fenix/home/HomeMenuView.kt ===================================== @@ -103,14 +103,14 @@ class HomeMenuView( HomeFragmentDirections.actionGlobalSettingsFragment(), ) } - HomeMenu.Item.CustomizeHome -> { - HomeScreen.customizeHomeClicked.record(NoExtras()) - - navController.nav( - R.id.homeFragment, - HomeFragmentDirections.actionGlobalHomeSettingsFragment(), - ) - } +// HomeMenu.Item.CustomizeHome -> { +// HomeScreen.customizeHomeClicked.record(NoExtras()) +// +// navController.nav( +// R.id.homeFragment, +// HomeFragmentDirections.actionGlobalHomeSettingsFragment(), +// ) +// } is HomeMenu.Item.SyncAccount -> { navController.nav( R.id.homeFragment, ===================================== fenix/app/src/main/java/org/mozilla/fenix/settings/SettingsFragment.kt ===================================== @@ -271,9 +271,9 @@ class SettingsFragment : PreferenceFragmentCompat() { resources.getString(R.string.pref_key_tabs) -> { SettingsFragmentDirections.actionSettingsFragmentToTabsSettingsFragment() } - resources.getString(R.string.pref_key_home) -> { - SettingsFragmentDirections.actionSettingsFragmentToHomeSettingsFragment() - } +// resources.getString(R.string.pref_key_home) -> { +// SettingsFragmentDirections.actionSettingsFragmentToHomeSettingsFragment() +// } resources.getString(R.string.pref_key_search_settings) -> { SettingsFragmentDirections.actionSettingsFragmentToSearchEngineFragment() } @@ -674,19 +674,19 @@ class SettingsFragment : PreferenceFragmentCompat() { @VisibleForTesting internal fun setupHomepagePreference() { - with(requirePreference<Preference>(R.string.pref_key_home)) { - summary = context?.let { - when { - it.settings().alwaysOpenTheHomepageWhenOpeningTheApp -> - getString(R.string.opening_screen_homepage_summary) - it.settings().openHomepageAfterFourHoursOfInactivity -> - getString(R.string.opening_screen_after_four_hours_of_inactivity_summary) - it.settings().alwaysOpenTheLastTabWhenOpeningTheApp -> - getString(R.string.opening_screen_last_tab_summary) - else -> null - } - } - } +// with(requirePreference<Preference>(R.string.pref_key_home)) { +// summary = context?.let { +// when { +// it.settings().alwaysOpenTheHomepageWhenOpeningTheApp -> +// getString(R.string.opening_screen_homepage_summary) +// it.settings().openHomepageAfterFourHoursOfInactivity -> +// getString(R.string.opening_screen_after_four_hours_of_inactivity_summary) +// it.settings().alwaysOpenTheLastTabWhenOpeningTheApp -> +// getString(R.string.opening_screen_last_tab_summary) +// else -> null +// } +// } +// } } @VisibleForTesting ===================================== fenix/app/src/main/res/xml/preferences.xml ===================================== @@ -54,10 +54,10 @@ android:key="@string/pref_key_tabs" android:title="@string/preferences_tabs" /> - <androidx.preference.Preference - app:iconSpaceReserved="false" - android:key="@string/pref_key_home" - android:title="@string/preferences_home_2" /> + + + + <androidx.preference.Preference android:key="@string/pref_key_customize" View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/commit/285… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/commit/285… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.3.1esr-13.0-1] fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser
by richard (＠richard) 10 Oct '23

10 Oct '23

richard pushed to branch tor-browser-115.3.1esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: c02fa5a8 by hackademix at 2023-10-10T16:58:37+00:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 41766: Sanitize about:torconnect redirects. - - - - - 1 changed file: - browser/components/torconnect/content/aboutTorConnect.js Changes: ===================================== browser/components/torconnect/content/aboutTorConnect.js ===================================== @@ -822,15 +822,21 @@ class AboutTorConnect { } async init() { + // if the user gets here manually or via the button in the urlbar + // then we will redirect to about:tor + this.redirect = "about:tor"; + // see if a user has a final destination after bootstrapping let params = new URLSearchParams(new URL(document.location.href).search); if (params.has("redirect")) { - const encodedRedirect = params.get("redirect"); - this.redirect = decodeURIComponent(encodedRedirect); - } else { - // if the user gets here manually or via the button in the urlbar - // then we will redirect to about:tor - this.redirect = "about:tor"; + try { + const redirect = new URL(decodeURIComponent(params.get("redirect"))); + if (/^(?:https?|about):$/.test(redirect.protocol)) { + this.redirect = redirect.href; + } + } catch (e) { + console.error(e, `Invalid redirect URL "${params.get("redirect")}"!`); + } } let args = await RPMSendQuery("torconnect:get-init-args"); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/c02fa5a… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/c02fa5a… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/firefox-android][firefox-android-115.2.1-13.0-1] fixup! Modify UI/UX
by Dan Ballard (＠dan) 10 Oct '23

10 Oct '23

Dan Ballard pushed to branch firefox-android-115.2.1-13.0-1 at The Tor Project / Applications / firefox-android Commits: 1d53ad16 by clairehurst at 2023-10-10T16:18:31+00:00 fixup! Modify UI/UX Bug 42157: Fix Help button URL - - - - - 1 changed file: - fenix/app/src/main/java/org/mozilla/fenix/home/HomeMenuView.kt Changes: ===================================== fenix/app/src/main/java/org/mozilla/fenix/home/HomeMenuView.kt ===================================== @@ -160,10 +160,7 @@ class HomeMenuView( } HomeMenu.Item.Help -> { homeActivity.openToBrowserAndLoad( - searchTermOrURL = SupportUtils.getSumoURLForTopic( - context = context, - topic = SupportUtils.SumoTopic.HELP, - ), + searchTermOrURL = SupportUtils.getTorHelpPageUrl(), newTab = true, from = BrowserDirection.FromHome, ) View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/commit/1d5… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/commit/1d5… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/firefox-android][firefox-android-115.2.1-13.0-1] fixup! Modify UI/UX
by Dan Ballard (＠dan) 10 Oct '23

10 Oct '23

Dan Ballard pushed to branch firefox-android-115.2.1-13.0-1 at The Tor Project / Applications / firefox-android Commits: 3b34325f by clairehurst at 2023-10-05T17:45:17-06:00 fixup! Modify UI/UX Bug 42156: Screenshot allowing still blocks homescreen (android) - - - - - 1 changed file: - fenix/app/src/main/java/org/mozilla/fenix/settings/SettingsFragment.kt Changes: ===================================== fenix/app/src/main/java/org/mozilla/fenix/settings/SettingsFragment.kt ===================================== @@ -14,6 +14,7 @@ import android.os.Bundle import android.os.Handler import android.os.Looper import android.view.LayoutInflater +import android.view.WindowManager import android.widget.Toast import androidx.annotation.VisibleForTesting import androidx.appcompat.app.AlertDialog @@ -471,7 +472,16 @@ class SettingsFragment : PreferenceFragmentCompat() { requirePreference<DefaultBrowserPreference>(R.string.pref_key_make_default_browser) requirePreference<Preference>(R.string.pref_key_allow_screenshots_in_private_mode).apply { - onPreferenceChangeListener = SharedPreferenceUpdater() + onPreferenceChangeListener = object : SharedPreferenceUpdater() { + override fun onPreferenceChange(preference: Preference, newValue: Any?): Boolean { + if (newValue == false) { + activity?.window?.addFlags(WindowManager.LayoutParams.FLAG_SECURE) + } else { + activity?.window?.clearFlags(WindowManager.LayoutParams.FLAG_SECURE) + } + return super.onPreferenceChange(preference, newValue) + } + } } preferencePrioritizeOnions?.setOnPreferenceChangeListener<Boolean> { preference, newValue -> View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/commit/3b3… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/commit/3b3… You're receiving this email because of your account on gitlab.torproject.org.

1 0