tor-commits January 2023

tor-commits@lists.torproject.org

2 participants
154 discussions

[Git][tpo/applications/tor-browser][base-browser-102.7.0esr-12.5-1] fixup! Firefox preference overrides.
by Pier Angelo Vendrame (＠pierov) 30 Jan '23

30 Jan '23

Pier Angelo Vendrame pushed to branch base-browser-102.7.0esr-12.5-1 at The Tor Project / Applications / Tor Browser Commits: 073b5c5d by Pier Angelo Vendrame at 2023-01-30T13:13:30+00:00 fixup! Firefox preference overrides. Bug 41595: Disable page thumbnails (cherry picked from commit 31831ff2e86470fced54745acc28fd0cbfcea23e) - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -55,6 +55,9 @@ pref("media.memory_cache_max_size", 16384); // Disable restore in case of crash (tor-browser#41503) // This should not be needed in PBM, but we added it anyway like other options. pref("browser.sessionstore.resume_from_crash", false); +// Disable capturing thumbnails (tor-browser#41595) +// Also not needed in PBM at the moment. +pref("browser.pagethumbnails.capturing_disabled", true); // Enable HTTPS-Only mode (tor-browser#19850) pref("dom.security.https_only_mode", true); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/073b5c5… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/073b5c5… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-102.7.0esr-12.5-1] fixup! Firefox preference overrides.
by Pier Angelo Vendrame (＠pierov) 30 Jan '23

30 Jan '23

Pier Angelo Vendrame pushed to branch tor-browser-102.7.0esr-12.5-1 at The Tor Project / Applications / Tor Browser Commits: 31831ff2 by Pier Angelo Vendrame at 2023-01-30T10:34:17+01:00 fixup! Firefox preference overrides. Bug 41595: Disable page thumbnails - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -55,6 +55,9 @@ pref("media.memory_cache_max_size", 16384); // Disable restore in case of crash (tor-browser#41503) // This should not be needed in PBM, but we added it anyway like other options. pref("browser.sessionstore.resume_from_crash", false); +// Disable capturing thumbnails (tor-browser#41595) +// Also not needed in PBM at the moment. +pref("browser.pagethumbnails.capturing_disabled", true); // Enable HTTPS-Only mode (tor-browser#19850) pref("dom.security.https_only_mode", true); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/31831ff… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/31831ff… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[torspec] branch main updated (0da1241 -> ad9a003)
by gitolite role 27 Jan '23

27 Jan '23

This is an automated email from the git hooks/post-receive script. dgoulet pushed a change to branch main in repository torspec. from 0da1241 Merge branch 'tor-gitlab/mr/104' new 16d536e prop339: Remove the nul term requirement for hostname new e787831 prop339: Unify the address format into one object new 63cb0fc prop339: trunnel changes from review new ad9a003 Merge branch 'tor-gitlab/mr/74' The 4 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: proposals/339-udp-over-tor.md | 72 +++++++++++++++++++++++++++---------------- 1 file changed, 45 insertions(+), 27 deletions(-) -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 4

[tor] branch main updated: Add a test vector for disaster SRV calculation.
by gitolite role 27 Jan '23

27 Jan '23

This is an automated email from the git hooks/post-receive script. dgoulet pushed a commit to branch main in repository tor. The following commit(s) were added to refs/heads/main by this push: new a5d8c9fef7 Add a test vector for disaster SRV calculation. new 7770c5a2ae Merge branch 'tor-gitlab/mr/686' a5d8c9fef7 is described below commit a5d8c9fef7b4bcfa8eea429c55d7affb4238d5ec Author: Nick Mathewson <nickm(a)torproject.org> AuthorDate: Wed Jan 25 09:04:07 2023 -0500 Add a test vector for disaster SRV calculation. --- src/test/test_hs_common.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/src/test/test_hs_common.c b/src/test/test_hs_common.c index e58945a8c3..4b43a9eb0b 100644 --- a/src/test/test_hs_common.c +++ b/src/test/test_hs_common.c @@ -645,6 +645,19 @@ test_disaster_srv(void *arg) tt_mem_op(cached_disaster_srv_one, OP_EQ, srv_one, DIGEST256_LEN); tt_mem_op(cached_disaster_srv_two, OP_EQ, srv_two, DIGEST256_LEN); + /* For at least one SRV, check that its result was as expected. */ + { + uint8_t srv1_expected[32]; + crypto_digest256( + (char*)srv1_expected, + "shared-random-disaster\0\0\0\0\0\0\x05\xA0\0\0\0\0\0\0\0\1", + strlen("shared-random-disaster")+16, + DIGEST_SHA3_256); + tt_mem_op(srv_one, OP_EQ, srv1_expected, DIGEST256_LEN); + tt_str_op(hex_str((char*)srv_one, DIGEST256_LEN), OP_EQ, + "F8A4948707653837FA44ABB5BBC75A12F6F101E7F8FAF699B9715F4965D3507D"); + } + /* Ask for an SRV that has already been computed */ get_disaster_srv(2, srv_two); /* and check that the cache entries have not changed */ -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[stem] branch master updated: Python 3.11 compatibility fix for deprecated coroutine decorator
by gitolite role 26 Jan '23

26 Jan '23

This is an automated email from the git hooks/post-receive script. atagar pushed a commit to branch master in repository stem. The following commit(s) were added to refs/heads/master by this push: new 89b0a288 Python 3.11 compatibility fix for deprecated coroutine decorator 89b0a288 is described below commit 89b0a288fe9d012cc27a3f94c38f0e8f0f6f76cf Author: Micah Elizabeth Scott <beth(a)torproject.org> AuthorDate: Wed Jan 18 17:53:29 2023 -0800 Python 3.11 compatibility fix for deprecated coroutine decorator The code to run __ainit__ constructors in the Synchronous mixin was using the deprecated asyncio.coroutine() decorator, which was fully removed in Python 3.11. Thankfully we can use the same approach for ainit that this same class uses below for wrapping generators. --- stem/util/asyncio.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/stem/util/asyncio.py b/stem/util/asyncio.py index e677f13d..7dc7250d 100644 --- a/stem/util/asyncio.py +++ b/stem/util/asyncio.py @@ -92,7 +92,10 @@ class Synchronous(object): setattr(self, name, functools.partial(self._run_async_method, name)) Synchronous.start(self) - asyncio.run_coroutine_threadsafe(asyncio.coroutine(self.__ainit__)(), self._loop).result() + + async def convert_ainit(): + return self.__ainit__() + asyncio.run_coroutine_threadsafe(convert_ainit(), self._loop).result() def __ainit__(self): """ -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[Git][tpo/applications/tor-browser][base-browser-102.7.0esr-12.5-1] 5 commits: fixup! Bug 31740: Remove some unnecessary RemoteSettings instances
by Pier Angelo Vendrame (＠pierov) 26 Jan '23

26 Jan '23

Pier Angelo Vendrame pushed to branch base-browser-102.7.0esr-12.5-1 at The Tor Project / Applications / Tor Browser Commits: 0ee79644 by cypherpunks1 at 2023-01-26T19:25:07+01:00 fixup! Bug 31740: Remove some unnecessary RemoteSettings instances Disable activity stream - - - - - ca88729a by cypherpunks1 at 2023-01-26T19:25:15+01:00 fixup! Bug 40002: Remove about:ion Remove this._monitorIonPref() and this._monitorIonStudies() from BrowserGlue - - - - - 125e7f8f by cypherpunks1 at 2023-01-26T19:25:15+01:00 fixup! Firefox preference overrides. Disable toolkit.telemetry.enabled on all builds, set webextensions.storage.sync.enabled to false - - - - - 84ab5401 by cypherpunks1 at 2023-01-26T19:25:34+01:00 Bug 41565: Gate Telemetry Tasks behind MOZ_TELEMETRY_REPORTING - - - - - de007ee5 by Pier Angelo Vendrame at 2023-01-26T19:25:34+01:00 fixup! Firefox preference overrides. Document why we are locking toolkit.telemetry.enabled. - - - - - 5 changed files: - browser/app/profile/001-base-profile.js - browser/base/content/browser.js - browser/components/BrowserGlue.jsm - toolkit/components/telemetry/app/TelemetryEnvironment.jsm - toolkit/xre/nsAppRunner.cpp Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -119,7 +119,8 @@ pref("datareporting.healthreport.uploadEnabled", false); pref("datareporting.policy.dataSubmissionEnabled", false); // Make sure Unified Telemetry is really disabled, see: #18738. pref("toolkit.telemetry.unified", false); -pref("toolkit.telemetry.enabled", false); +// This needs to be locked, or nightly builds will automatically lock it to true +pref("toolkit.telemetry.enabled", false, locked); pref("toolkit.telemetry.server", "data:,"); pref("toolkit.telemetry.archive.enabled", false); pref("toolkit.telemetry.updatePing.enabled", false); // Make sure updater telemetry is disabled; see #25909. @@ -422,6 +423,8 @@ pref("extensions.postDownloadThirdPartyPrompt", false); // Therefore, do not allow download of additional language packs. They are not a // privacy/security threat, we are disabling them for UX reasons. See bug 41377. pref("intl.multilingual.downloadEnabled", false); +// Disk activity: Disable storage.sync (tor-browser#41424) +pref("webextensions.storage.sync.enabled", false); // Toolbar layout pref("browser.uiCustomization.state", "{\"placements\":{\"widget-overflow-fixed-list\":[],\"PersonalToolbar\":[\"personal-bookmarks\"],\"nav-bar\":[\"back-button\",\"forward-button\",\"stop-reload-button\",\"urlbar-container\",\"security-level-button\",\"new-identity-button\",\"downloads-button\"],\"TabsToolbar\":[\"tabbrowser-tabs\",\"new-tab-button\",\"alltabs-button\"],\"toolbar-menubar\":[\"menubar-items\"],\"PanelUI-contents\":[\"home-button\",\"edit-controls\",\"zoom-controls\",\"new-window-button\",\"save-page-button\",\"print-button\",\"bookmarks-menu-button\",\"history-panelmenu\",\"find-button\",\"preferences-button\",\"add-ons-button\",\"developer-button\"],\"addon-bar\":[\"addonbar-closebutton\",\"status-bar\"]},\"seen\":[\"developer-button\"],\"dirtyAreaCache\":[\"PersonalToolbar\",\"nav-bar\",\"TabsToolbar\",\"toolbar-menubar\"],\"currentVersion\":14,\"newElementCount\":1}"); ===================================== browser/base/content/browser.js ===================================== @@ -6004,6 +6004,7 @@ var TabsProgressListener = { onStateChange(aBrowser, aWebProgress, aRequest, aStateFlags, aStatus) { // Collect telemetry data about tab load times. if ( + AppConstants.MOZ_TELEMETRY_REPORTING && aWebProgress.isTopLevel && (!aRequest.originalURI || aRequest.originalURI.scheme != "about") ) { ===================================== browser/components/BrowserGlue.jsm ===================================== @@ -22,9 +22,6 @@ XPCOMUtils.defineLazyModuleGetters(this, { ActorManagerParent: "resource://gre/modules/ActorManagerParent.jsm", AddonManager: "resource://gre/modules/AddonManager.jsm", AppMenuNotifications: "resource://gre/modules/AppMenuNotifications.jsm", - ASRouterDefaultConfig: - "resource://activity-stream/lib/ASRouterDefaultConfig.jsm", - ASRouterNewTabHook: "resource://activity-stream/lib/ASRouterNewTabHook.jsm", ASRouter: "resource://activity-stream/lib/ASRouter.jsm", AsyncShutdown: "resource://gre/modules/AsyncShutdown.jsm", BackgroundUpdate: "resource://gre/modules/BackgroundUpdate.jsm", @@ -717,27 +714,6 @@ let JSWINDOWACTORS = { matches: ["about:studies*"], }, - ASRouter: { - parent: { - moduleURI: "resource:///actors/ASRouterParent.jsm", - }, - child: { - moduleURI: "resource:///actors/ASRouterChild.jsm", - events: { - // This is added so the actor instantiates immediately and makes - // methods available to the page js on load. - DOMDocElementInserted: {}, - }, - }, - matches: [ - "about:home*", - "about:newtab*", - "about:welcome*", - "about:privatebrowsing", - ], - remoteTypes: ["privilegedabout"], - }, - SwitchDocumentDirection: { child: { moduleURI: "resource:///actors/SwitchDocumentDirectionChild.jsm", @@ -1693,7 +1669,9 @@ BrowserGlue.prototype = { this._firstWindowTelemetry(aWindow); this._firstWindowLoaded(); - this._collectStartupConditionsTelemetry(); + if (AppConstants.MOZ_TELEMETRY_REPORTING) { + this._collectStartupConditionsTelemetry(); + } // Set the default favicon size for UI views that use the page-icon protocol. PlacesUtils.favicons.setDefaultIconURIPreferredSize( @@ -2006,7 +1984,6 @@ BrowserGlue.prototype = { () => NewTabUtils.uninit(), () => Normandy.uninit(), () => RFPHelper.uninit(), - () => ASRouterNewTabHook.destroy(), () => UpdateListener.reset(), ]; @@ -2347,8 +2324,6 @@ BrowserGlue.prototype = { this._monitorScreenshotsPref(); this._monitorWebcompatReporterPref(); this._monitorHTTPSOnlyPref(); - this._monitorIonPref(); - this._monitorIonStudies(); this._setupSearchDetection(); this._monitorGPCPref(); @@ -2717,12 +2692,6 @@ BrowserGlue.prototype = { }, }, - { - task: () => { - ASRouterNewTabHook.createInstance(ASRouterDefaultConfig()); - }, - }, - { condition: AppConstants.MOZ_UPDATE_AGENT, task: () => { @@ -2877,13 +2846,21 @@ BrowserGlue.prototype = { } }, - () => BrowserUsageTelemetry.reportProfileCount(), + () => { + if (AppConstants.MOZ_TELEMETRY_REPORTING) { + BrowserUsageTelemetry.reportProfileCount(); + } + }, () => OsEnvironment.reportAllowedAppSources(), () => Services.search.runBackgroundChecks(), - () => BrowserUsageTelemetry.reportInstallationTelemetry(), + () => { + if (AppConstants.MOZ_TELEMETRY_REPORTING) { + BrowserUsageTelemetry.reportInstallationTelemetry(); + } + }, ]; for (let task of idleTasks) { ===================================== toolkit/components/telemetry/app/TelemetryEnvironment.jsm ===================================== @@ -973,7 +973,9 @@ function EnvironmentCache() { p.push(this._addonBuilder.init()); this._currentEnvironment.profile = {}; - p.push(this._updateProfile()); + if (AppConstants.MOZ_TELEMETRY_REPORTING) { + p.push(this._updateProfile()); + } if (AppConstants.MOZ_BUILD_APP == "browser") { p.push(this._loadAttributionAsync()); } ===================================== toolkit/xre/nsAppRunner.cpp ===================================== @@ -2800,7 +2800,9 @@ static ReturnAbortOnError ProfileLockedDialog(nsIFile* aProfileDir, rv = xpcom.Initialize(); NS_ENSURE_SUCCESS(rv, rv); +#if defined(MOZ_TELEMETRY_REPORTING) if (aProfileDir) mozilla::Telemetry::WriteFailedProfileLock(aProfileDir); +#endif rv = xpcom.SetWindowCreator(aNative); NS_ENSURE_SUCCESS(rv, NS_ERROR_FAILURE); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/69be75… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/69be75… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-102.7.0esr-12.5-1] fixup! Firefox preference overrides.
by Pier Angelo Vendrame (＠pierov) 26 Jan '23

26 Jan '23

Pier Angelo Vendrame pushed to branch tor-browser-102.7.0esr-12.5-1 at The Tor Project / Applications / Tor Browser Commits: 933d8c65 by Pier Angelo Vendrame at 2023-01-26T09:55:06+01:00 fixup! Firefox preference overrides. Document why we are locking toolkit.telemetry.enabled. - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -119,6 +119,7 @@ pref("datareporting.healthreport.uploadEnabled", false); pref("datareporting.policy.dataSubmissionEnabled", false); // Make sure Unified Telemetry is really disabled, see: #18738. pref("toolkit.telemetry.unified", false); +// This needs to be locked, or nightly builds will automatically lock it to true pref("toolkit.telemetry.enabled", false, locked); pref("toolkit.telemetry.server", "data:,"); pref("toolkit.telemetry.archive.enabled", false); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/933d8c6… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/933d8c6… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[tor] branch release-0.4.7 updated (ee3173c965 -> f731134697)
by gitolite role 26 Jan '23

26 Jan '23

This is an automated email from the git hooks/post-receive script. dgoulet pushed a change to branch release-0.4.7 in repository tor. from ee3173c965 Merge branch 'maint-0.4.7' into release-0.4.7 new bff6d7a944 relay: Use the right max queue size value in log new e390a7cdee Merge branch 'tor-gitlab/mr/687' into maint-0.4.7 new f731134697 Merge branch 'maint-0.4.7' into release-0.4.7 The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: changes/ticket40745 | 3 +++ src/core/or/relay.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) create mode 100644 changes/ticket40745 -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 1

[tor] branch maint-0.4.7 updated (7b87ecf7e2 -> e390a7cdee)
by gitolite role 26 Jan '23

26 Jan '23

This is an automated email from the git hooks/post-receive script. dgoulet pushed a change to branch maint-0.4.7 in repository tor. from 7b87ecf7e2 Merge branch 'maint-0.4.5' into maint-0.4.7 new bff6d7a944 relay: Use the right max queue size value in log new e390a7cdee Merge branch 'tor-gitlab/mr/687' into maint-0.4.7 The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: changes/ticket40745 | 3 +++ src/core/or/relay.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) create mode 100644 changes/ticket40745 -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[tor] branch main updated (21109ba5d5 -> fc11b38f2a)
by gitolite role 26 Jan '23

26 Jan '23

This is an automated email from the git hooks/post-receive script. dgoulet pushed a change to branch main in repository tor. from 21109ba5d5 Merge branch 'maint-0.4.7' new bff6d7a944 relay: Use the right max queue size value in log new e390a7cdee Merge branch 'tor-gitlab/mr/687' into maint-0.4.7 new fc11b38f2a Merge branch 'maint-0.4.7' The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: changes/ticket40745 | 3 +++ src/core/or/relay.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) create mode 100644 changes/ticket40745 -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 3

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

tor-commits January 2023