January 2023 - tor-commits - lists.torproject.org

[tor] branch release-0.4.7 updated (edf4887e64 -> ae89d6967b)
by gitolite role 11 Jan '23

11 Jan '23

This is an automated email from the git hooks/post-receive script. dgoulet pushed a change to branch release-0.4.7 in repository tor. from edf4887e64 Merge branch 'maint-0.4.7' into release-0.4.7 new 536b5c8059 connection_or_set_identity_digest(): Make errors nonfatal. new a79046f40a Fix logic for whether a channel's Ed25519 ID is changing new 93625da29e connection_or_set_identity_digest: more defensive programming new ecbab95998 Add a changes file for 40563. new 33bb1c5fca connection_or_set_identity_digest(): handle zero ed_id better new 85547a9b5b Merge branch 'tor-gitlab/mr/538' into maint-0.4.5 new b9c7825f0e Merge branch 'maint-0.4.5' into maint-0.4.7 new ae89d6967b Merge branch 'maint-0.4.7' into release-0.4.7 The 8 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: changes/bug40563 | 8 ++++++++ src/core/or/connection_or.c | 16 ++++++++++------ 2 files changed, 18 insertions(+), 6 deletions(-) create mode 100644 changes/bug40563 -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 1

[tor] branch release-0.4.5 updated (a093a82d64 -> e94ba70fcd)
by gitolite role 11 Jan '23

11 Jan '23

This is an automated email from the git hooks/post-receive script. dgoulet pushed a change to branch release-0.4.5 in repository tor. from a093a82d64 Merge branch 'maint-0.4.5' into release-0.4.5 new 536b5c8059 connection_or_set_identity_digest(): Make errors nonfatal. new a79046f40a Fix logic for whether a channel's Ed25519 ID is changing new 93625da29e connection_or_set_identity_digest: more defensive programming new ecbab95998 Add a changes file for 40563. new 33bb1c5fca connection_or_set_identity_digest(): handle zero ed_id better new 85547a9b5b Merge branch 'tor-gitlab/mr/538' into maint-0.4.5 new e94ba70fcd Merge branch 'maint-0.4.5' into release-0.4.5 The 7 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: changes/bug40563 | 8 ++++++++ src/core/or/connection_or.c | 16 ++++++++++------ 2 files changed, 18 insertions(+), 6 deletions(-) create mode 100644 changes/bug40563 -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 1

[tor] branch maint-0.4.7 updated (482cde5931 -> b9c7825f0e)
by gitolite role 11 Jan '23

11 Jan '23

This is an automated email from the git hooks/post-receive script. dgoulet pushed a change to branch maint-0.4.7 in repository tor. from 482cde5931 Do not reset our RTT in slow start. new 536b5c8059 connection_or_set_identity_digest(): Make errors nonfatal. new a79046f40a Fix logic for whether a channel's Ed25519 ID is changing new 93625da29e connection_or_set_identity_digest: more defensive programming new ecbab95998 Add a changes file for 40563. new 33bb1c5fca connection_or_set_identity_digest(): handle zero ed_id better new 85547a9b5b Merge branch 'tor-gitlab/mr/538' into maint-0.4.5 new b9c7825f0e Merge branch 'maint-0.4.5' into maint-0.4.7 The 7 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: changes/bug40563 | 8 ++++++++ src/core/or/connection_or.c | 16 ++++++++++------ 2 files changed, 18 insertions(+), 6 deletions(-) create mode 100644 changes/bug40563 -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[tor] branch maint-0.4.5 updated (b117ce48db -> 85547a9b5b)
by gitolite role 11 Jan '23

11 Jan '23

This is an automated email from the git hooks/post-receive script. dgoulet pushed a change to branch maint-0.4.5 in repository tor. from b117ce48db version: Bump version to 0.4.5.15-dev new 536b5c8059 connection_or_set_identity_digest(): Make errors nonfatal. new a79046f40a Fix logic for whether a channel's Ed25519 ID is changing new 93625da29e connection_or_set_identity_digest: more defensive programming new ecbab95998 Add a changes file for 40563. new 33bb1c5fca connection_or_set_identity_digest(): handle zero ed_id better new 85547a9b5b Merge branch 'tor-gitlab/mr/538' into maint-0.4.5 The 6 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: changes/bug40563 | 8 ++++++++ src/core/or/connection_or.c | 16 ++++++++++------ 2 files changed, 18 insertions(+), 6 deletions(-) create mode 100644 changes/bug40563 -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[tor] branch main updated (5d6e0b8e13 -> b38630ca56)
by gitolite role 11 Jan '23

11 Jan '23

This is an automated email from the git hooks/post-receive script. dgoulet pushed a change to branch main in repository tor. from 5d6e0b8e13 Merge branch 'maint-0.4.7' new 536b5c8059 connection_or_set_identity_digest(): Make errors nonfatal. new a79046f40a Fix logic for whether a channel's Ed25519 ID is changing new 93625da29e connection_or_set_identity_digest: more defensive programming new ecbab95998 Add a changes file for 40563. new 33bb1c5fca connection_or_set_identity_digest(): handle zero ed_id better new 85547a9b5b Merge branch 'tor-gitlab/mr/538' into maint-0.4.5 new b9c7825f0e Merge branch 'maint-0.4.5' into maint-0.4.7 new b38630ca56 Merge branch 'maint-0.4.7' The 8 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: changes/bug40563 | 8 ++++++++ src/core/or/connection_or.c | 16 ++++++++++------ 2 files changed, 18 insertions(+), 6 deletions(-) create mode 100644 changes/bug40563 -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 8

[torspec] branch main updated (c2e057a -> 0bacc73)
by gitolite role 10 Jan '23

10 Jan '23

This is an automated email from the git hooks/post-receive script. dgoulet pushed a change to branch main in repository torspec. from c2e057a Prop 324: RTT should only be reset after slow start. new dabadcc Update Prop#324 clock heuristic spec for bug 40626. new 773fc92 Merge branch 'tor-gitlab/mr/75' new aab9efe prop#324: mention rearranged form for N_EWMA smoothing new 0bacc73 Merge branch 'tor-gitlab/mr/83' The 4 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: proposals/324-rtt-congestion-control.txt | 32 +++++++++++++++++++------------- 1 file changed, 19 insertions(+), 13 deletions(-) -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 4

[torspec] branch main updated: Prop 324: RTT should only be reset after slow start.
by gitolite role 10 Jan '23

10 Jan '23

This is an automated email from the git hooks/post-receive script. dgoulet pushed a commit to branch main in repository torspec. The following commit(s) were added to refs/heads/main by this push: new c2e057a Prop 324: RTT should only be reset after slow start. c2e057a is described below commit c2e057a7c39d0dc63a54fe77dfbefa2f3f86d533 Author: Mike Perry <mikeperry-git(a)torproject.org> AuthorDate: Tue Jan 10 20:53:57 2023 +0000 Prop 324: RTT should only be reset after slow start. --- proposals/324-rtt-congestion-control.txt | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/proposals/324-rtt-congestion-control.txt b/proposals/324-rtt-congestion-control.txt index 4937744..fd79cbd 100644 --- a/proposals/324-rtt-congestion-control.txt +++ b/proposals/324-rtt-congestion-control.txt @@ -389,12 +389,12 @@ Simplifying: BDP = cwnd * RTT_min / RTT_current_ewma -The RTT_min for this calculation comes from the minimum RTT_current_ewma -seen in the lifetime of this circuit. If the congestion window falls to -`cc_cwnd_min`, implementations MAY choose to reset RTT_min for use in this -calculation to either the RTT_current_ewma, or a percentile-weighted average -between RTT_min and RTT_current_ewma, specified by `cc_rtt_reset_pct`. This -helps with escaping starvation conditions. +The RTT_min for this calculation comes from the minimum RTT_current_ewma seen +in the lifetime of this circuit. If the congestion window falls to +`cc_cwnd_min` after slow start, implementations MAY choose to reset RTT_min +for use in this calculation to either the RTT_current_ewma, or a +percentile-weighted average between RTT_min and RTT_current_ewma, specified by +`cc_rtt_reset_pct`. This helps with escaping starvation conditions. The net effect of this estimation is to correct for any overshoot of the cwnd over the actual BDP. It will obviously underestimate BDP if cwnd -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[tor] branch release-0.4.7 updated (c1d8db8ba5 -> edf4887e64)
by gitolite role 10 Jan '23

10 Jan '23

This is an automated email from the git hooks/post-receive script. dgoulet pushed a change to branch release-0.4.7 in repository tor. from c1d8db8ba5 Merge branch 'maint-0.4.7' into release-0.4.7 new 482cde5931 Do not reset our RTT in slow start. new edf4887e64 Merge branch 'maint-0.4.7' into release-0.4.7 The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: src/core/or/congestion_control_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 1

[tor] branch maint-0.4.7 updated (c50496036b -> 482cde5931)
by gitolite role 10 Jan '23

10 Jan '23

This is an automated email from the git hooks/post-receive script. dgoulet pushed a change to branch maint-0.4.7 in repository tor. from c50496036b cc: Rename function to avoid confusion new 482cde5931 Do not reset our RTT in slow start. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: src/core/or/congestion_control_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[tor] branch main updated: Do not reset our RTT in slow start.
by gitolite role 10 Jan '23

10 Jan '23

This is an automated email from the git hooks/post-receive script. dgoulet pushed a commit to branch main in repository tor. The following commit(s) were added to refs/heads/main by this push: new 482cde5931 Do not reset our RTT in slow start. new 5d6e0b8e13 Merge branch 'maint-0.4.7' 482cde5931 is described below commit 482cde5931b537d49dc2535bf7a7771d740f441a Author: Mike Perry <mikeperry-git(a)torproject.org> AuthorDate: Tue Jan 10 20:47:11 2023 +0000 Do not reset our RTT in slow start. If a circuit only sends a tiny amount of data such that its cwnd is not full, it won't increase its cwnd above the minimum. Since slow start circuits should never hit the minimum otherwise, we can just ignore them for RTT reset to handle this. --- src/core/or/congestion_control_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/or/congestion_control_common.c b/src/core/or/congestion_control_common.c index e96d22cbfa..f5b7740bed 100644 --- a/src/core/or/congestion_control_common.c +++ b/src/core/or/congestion_control_common.c @@ -902,7 +902,7 @@ congestion_control_update_circuit_rtt(congestion_control_t *cc, if (cc->min_rtt_usec == 0) { // If we do not have a min_rtt yet, use current ewma cc->min_rtt_usec = cc->ewma_rtt_usec; - } else if (cc->cwnd == cc->cwnd_min) { + } else if (cc->cwnd == cc->cwnd_min && !cc->in_slow_start) { // Raise min rtt if cwnd hit cwnd_min. This gets us out of a wedge state // if we hit cwnd_min due to an abnormally low rtt. uint64_t new_rtt = percent_max_mix(cc->ewma_rtt_usec, cc->min_rtt_usec, -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0