December 2022 - tor-commits - lists.torproject.org

[tor] branch main updated: circ: Add function to learn if queue is full
by gitolite role 20 Dec '22

20 Dec '22

This is an automated email from the git hooks/post-receive script. dgoulet pushed a commit to branch main in repository tor. The following commit(s) were added to refs/heads/main by this push: new cfdc9f9d29 circ: Add function to learn if queue is full cfdc9f9d29 is described below commit cfdc9f9d29fb369a139f4a3a35a829ebe66807bb Author: David Goulet <dgoulet(a)torproject.org> AuthorDate: Wed Dec 14 10:19:14 2022 -0500 circ: Add function to learn if queue is full Related to #40731 Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- src/core/or/circuitlist.c | 24 ++++++++++++++++++++++++ src/core/or/circuitlist.h | 2 ++ 2 files changed, 26 insertions(+) diff --git a/src/core/or/circuitlist.c b/src/core/or/circuitlist.c index 50dc2ee338..cea3a2136f 100644 --- a/src/core/or/circuitlist.c +++ b/src/core/or/circuitlist.c @@ -2831,3 +2831,27 @@ assert_circuit_ok,(const circuit_t *c)) tor_assert(!or_circ || !or_circ->rend_splice); } } + +/** Return true iff the circuit queue for the given direction is full that is + * above the high watermark. */ +bool +circuit_is_queue_full(const circuit_t *circ, cell_direction_t direction) +{ + int queue_size; + + tor_assert(circ); + + /* Gather objects we need based on cell direction. */ + if (direction == CELL_DIRECTION_OUT) { + /* Outbound. */ + queue_size = circ->n_chan_cells.n; + } else { + /* Inbound. */ + queue_size = CONST_TO_OR_CIRCUIT(circ)->p_chan_cells.n; + } + + /* Then check if our cell queue has reached its high watermark as in its + * upper limit. This is so we avoid too much memory pressure by queuing a + * large amount of cells. */ + return queue_size >= cell_queue_highwatermark(); +} diff --git a/src/core/or/circuitlist.h b/src/core/or/circuitlist.h index 541a708de2..49ded11f12 100644 --- a/src/core/or/circuitlist.h +++ b/src/core/or/circuitlist.h @@ -247,6 +247,8 @@ MOCK_DECL(void, channel_note_destroy_not_pending, smartlist_t *circuit_find_circuits_to_upgrade_from_guard_wait(void); +bool circuit_is_queue_full(const circuit_t *circ, cell_direction_t direction); + /* Declare the handle helpers */ HANDLE_DECL(circuit, circuit_t, ) #define circuit_handle_free(h) \ -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[torspec] branch main updated: prop329: Remove unused section and use relay command 19..22
by gitolite role 15 Dec '22

15 Dec '22

This is an automated email from the git hooks/post-receive script. dgoulet pushed a commit to branch main in repository torspec. The following commit(s) were added to refs/heads/main by this push: new 3727309 prop329: Remove unused section and use relay command 19..22 3727309 is described below commit 372730940f916933447f56da7f12167c79c86c4f Author: David Goulet <dgoulet(a)torproject.org> AuthorDate: Thu Dec 15 11:16:58 2022 -0500 prop329: Remove unused section and use relay command 19..22 As per review from nickm in https://gitlab.torproject.org/tpo/core/torspec/-/merge_requests/95 Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- proposals/329-traffic-splitting.txt | 52 +++++-------------------------------- tor-spec.txt | 4 +-- 2 files changed, 8 insertions(+), 48 deletions(-) diff --git a/proposals/329-traffic-splitting.txt b/proposals/329-traffic-splitting.txt index e76e38c..b9f5dce 100644 --- a/proposals/329-traffic-splitting.txt +++ b/proposals/329-traffic-splitting.txt @@ -173,12 +173,12 @@ Status: Draft The first two parts of the handshake establish the link, and enable resumption: - 45 -- RELAY_CONFLUX_LINK + 19 -- RELAY_CONFLUX_LINK Sent from the OP to the exit/service in order to link circuits together at the end point. - 46 -- RELAY_CONFLUX_LINKED + 20 -- RELAY_CONFLUX_LINKED Sent from the exit/service to the OP, to confirm the circuits were linked. @@ -224,7 +224,7 @@ Status: Draft The third stage of the handshake exists to help the exit/service measure initial RTT, for use in [SCHEDULING]: - 47 -- RELAY_CONFLUX_LINKED_ACK + 21 -- RELAY_CONFLUX_LINKED_ACK Sent from the OP to the exit/service, to provide initial RTT measurement for the exit/service. @@ -313,7 +313,7 @@ Status: Draft To achieve this, we propose a new relay command used to indicate a switch to another leg: - 48 -- RELAY_CONFLUX_SWITCH + 22 -- RELAY_CONFLUX_SWITCH Sent from the client to the exit/service when switching leg in an already linked circuit construction. @@ -750,47 +750,7 @@ Status: Draft Appended A [ALTERNATIVES] -A.1 BEGIN/END sequencing [ALTERNATIVE_SEQUENCING] - - In this method of signaling, we increment the sequence number by 1 only - when we switch legs, and use BEGIN/END "bookends" to know that all data - on a leg has been received. - - To achieve this, we add a small sequence number to the common relay - header for all relay cells on linked circuits, as well as a field to - signal the beginning of a sequence, intermediate data, and the end of a - sequence. - - Relay command [1 byte] - Recognized [2 bytes] - StreamID [2 bytes] - Digest [4 bytes] - Length [2 bytes] - > Switching [2 bits] # 01 = BEGIN, 00 = CONTINUE, 10 = END - > Sequencing [6 bits] - Data [PAYLOAD_LEN - 12 - Length bytes] - - These fields MUST be present on ALL end-to-end relay cells on each leg - that come from the endpoint, following a RELAY_CIRCUIT_LINK command. - - They are absent on 'leaky pipe' RELAY_COMMAND_DROP and - RELAY_COMMAND_PADDING_NEGOTIATED cells that come from middle relays, as - opposed to the endpoint, to support padding. - - Sequence numbers are incremented by one when an endpoint switches legs - to transmit a cell. This number will wrap; implementations MUST treat - 0 as the next sequence after 2^6-1. Because we do not expect to support - significantly more than 2 legs, and much fewer than 63, this is not an - issue. - - The first cell on a new circuit MUST use the BEGIN code for switching. - Cells are delivered from that circuit until an END switching signal is - received, even if cells arrive first on another circuit with the next - sequence number before and END switching field. Recipients MUST only - deliver cells with a BEGIN, if their Sequencing number is one more than - the last END. - -A.2 Alternative Link Handshake [ALTERNATIVE_LINKING] +A.1 Alternative Link Handshake [ALTERNATIVE_LINKING] The circuit linking in [LINKING_CIRCUITS] could be done as encrypted ntor onionskin extension fields, similar to those used by v3 onions. @@ -814,7 +774,7 @@ A.2 Alternative Link Handshake [ALTERNATIVE_LINKING] linking phase using Proposal 340, to combine initial RELAY_BEGIN cells with RELAY_CIRCUIT_LINK. -A.3. Alternative RTT measurement [ALTERNATIVE_RTT] +A.2. Alternative RTT measurement [ALTERNATIVE_RTT] Instead of measuring RTTs during [LINKING_CIRCUITS], we could create PING/PONG cells, whose sole purpose is to allow endpoints to measure diff --git a/tor-spec.txt b/tor-spec.txt index 38b8b35..f728478 100644 --- a/tor-spec.txt +++ b/tor-spec.txt @@ -1686,6 +1686,8 @@ see tor-design.pdf. 16..18 -- Reserved for UDP; Not yet in use, see prop339. + 19..22 -- Reserved for Conflux, see prop329. + 32..40 -- Used for hidden services; see rend-spec-{v2,v3}.txt. 41..42 -- Used for circuit padding; see Section 3 of padding-spec.txt. @@ -1694,8 +1696,6 @@ see tor-design.pdf. 43 -- XON [forward or backward] 44 -- XOFF [forward or backward] - 45..48 -- Reserved for Conflux, see prop329. - Commands labelled as "forward" must only be sent by the originator of the circuit. Commands labelled as "backward" must only be sent by other nodes in the circuit back to the originator. Commands marked -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[pluggable-transports/snowflake] branch main updated (53e381e -> 936a1f8)
by gitolite role 15 Dec '22

15 Dec '22

This is an automated email from the git hooks/post-receive script. dcf pushed a change to branch main in repository pluggable-transports/snowflake. from 53e381e Fix server flag name new c6fabb2 Use multiple parallel KCP state machines in the server. new 936a1f8 Add a num-turbotunnel server transport option. The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: server/README.md | 25 ++++++++++++++++++++++++ server/lib/http.go | 52 ++++++++++++++++++++++++++++++++++++++++++++----- server/lib/snowflake.go | 45 +++++++++++++++++++++--------------------- server/server.go | 20 ++++++++++++++++++- 4 files changed, 113 insertions(+), 29 deletions(-) -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[pluggable-transports/snowflake] branch main updated: Fix server flag name
by gitolite role 14 Dec '22

14 Dec '22

This is an automated email from the git hooks/post-receive script. itchyonion pushed a commit to branch main in repository pluggable-transports/snowflake. The following commit(s) were added to refs/heads/main by this push: new 53e381e Fix server flag name 53e381e is described below commit 53e381e45d63b0d0ccebbeece71b2471900c7b6a Author: itchyonion <itchyonion(a)torproject.org> AuthorDate: Tue Dec 13 09:23:34 2022 -0800 Fix server flag name --- server/server.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/server.go b/server/server.go index 484e37a..3d66d35 100644 --- a/server/server.go +++ b/server/server.go @@ -139,7 +139,7 @@ func main() { flag.BoolVar(&disableTLS, "disable-tls", false, "don't use HTTPS") flag.StringVar(&logFilename, "log", "", "log file to write to") flag.BoolVar(&unsafeLogging, "unsafe-logging", false, "prevent logs from being scrubbed") - flag.BoolVar(&versionFlag, "unsafe-logging", false, "display version info to stderr and quit") + flag.BoolVar(&versionFlag, "version", false, "display version info to stderr and quit") flag.Parse() if versionFlag { -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[torspec] branch main updated (1db24dd -> 343f1d7)
by gitolite role 14 Dec '22

14 Dec '22

This is an automated email from the git hooks/post-receive script. dgoulet pushed a change to branch main in repository torspec. from 1db24dd prop329: Remove a whole lot of white spaces new fcfeec2 prop329: Changes after research and discussions new 343f1d7 prop329: Clarifications to SWITCH and other notes The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: proposals/329-traffic-splitting.txt | 195 +++++++++++++++++++++--------------- tor-spec.txt | 2 + 2 files changed, 118 insertions(+), 79 deletions(-) -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 2

[tor-browser-bundle-testsuite] branch main updated: The git.tpo repository is no longer updated, gitlab.tpo should be used instead
by gitolite role 13 Dec '22

13 Dec '22

This is an automated email from the git hooks/post-receive script. richard pushed a commit to branch main in repository tor-browser-bundle-testsuite. The following commit(s) were added to refs/heads/main by this push: new 0342091 The git.tpo repository is no longer updated, gitlab.tpo should be used instead 0342091 is described below commit 03420915806b22536cfb2f35315f169e3db50346 Author: Richard Pospesel <richard(a)torproject.org> AuthorDate: Tue Dec 13 15:15:52 2022 +0000 The git.tpo repository is no longer updated, gitlab.tpo should be used instead The repository at https://gitweb.torproject.org/tor-browser-bundle-testsuite.git/ (git.torproject.org and git-rw.torproject.org) is no longer updated. Please use the gitlab repository instead: https://gitlab.torproject.org/tpo/applications/tor-browser-bundle-testsuite -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[tor-browser-spec] branch main updated: The git.tpo repository is no longer updated, gitlab.tpo should be used instead
by gitolite role 13 Dec '22

13 Dec '22

This is an automated email from the git hooks/post-receive script. richard pushed a commit to branch main in repository tor-browser-spec. The following commit(s) were added to refs/heads/main by this push: new 789b727 The git.tpo repository is no longer updated, gitlab.tpo should be used instead 789b727 is described below commit 789b727494c2e5435e77ed64a426aa15fbff8a53 Author: Richard Pospesel <richard(a)torproject.org> AuthorDate: Tue Dec 13 15:12:45 2022 +0000 The git.tpo repository is no longer updated, gitlab.tpo should be used instead The repository at https://gitweb.torproject.org/tor-browser-spec.git/ (git.torproject.org and git-rw.torproject.org) is no longer updated. Please use the gitlab repository instead: https://gitlab.torproject.org/tpo/applications/tor-browser-spec -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[pluggable-transports/snowflake] branch main updated (8e5af50 -> 839d221)
by gitolite role 08 Dec '22

08 Dec '22

This is an automated email from the git hooks/post-receive script. dcf pushed a change to branch main in repository pluggable-transports/snowflake. from 8e5af50 Increase clientIDAddrMapCapacity to 98304. new 6449146 Manually unlock the mutex in ClientMap.SendQueue. new 77b186a Have SnowflakeClientConn implement io.WriterTo. new d4749d2 Reduce turbotunnel queueSize from 2048 to 512. new 839d221 Take ownership of buffer in QueuePacketConn QueueIncoming/WriteTo. The 4 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: common/turbotunnel/clientmap.go | 5 ++-- common/turbotunnel/clientmap_test.go | 18 +++++++++++++ common/turbotunnel/consts.go | 2 +- common/turbotunnel/queuepacketconn.go | 22 +++++++-------- common/turbotunnel/queuepacketconn_test.go | 43 ++++++++++++++++++++++++++++++ server/lib/snowflake.go | 32 +++++++++++++++++----- server/server.go | 2 +- 7 files changed, 101 insertions(+), 23 deletions(-) create mode 100644 common/turbotunnel/clientmap_test.go create mode 100644 common/turbotunnel/queuepacketconn_test.go -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[depictor] branch master updated: Round clockskew.
by gitolite role 07 Dec '22

07 Dec '22

This is an automated email from the git hooks/post-receive script. tom pushed a commit to branch master in repository depictor. The following commit(s) were added to refs/heads/master by this push: new 66d32a2 Round clockskew. 66d32a2 is described below commit 66d32a2b68be4ea1250c58a2dc2a7768e85e7438 Author: Tom Ritter <tom(a)ritter.vg> AuthorDate: Wed Dec 7 11:58:15 2022 -0500 Round clockskew. --- utility.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utility.py b/utility.py index 4395234..4e2f2de 100755 --- a/utility.py +++ b/utility.py @@ -132,7 +132,7 @@ def get_clockskew(): if processing > 5: clockskew[nickname] -= datetime.timedelta(seconds=(processing / 2)) clockskew[nickname] -= startTimeStamp - clockskew[nickname] = clockskew[nickname].total_seconds() + clockskew[nickname] = round(clockskew[nickname].total_seconds(), 2) except Exception as e: print("Clockskew Exception:", e) continue -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[depictor] branch master updated (e23621d -> 6bfdcdb)
by gitolite role 07 Dec '22

07 Dec '22

This is an automated email from the git hooks/post-receive script. tom pushed a change to branch master in repository depictor. from e23621d Hardcode moria's IP address to avoid an IP block. Fixes #17 new 132572c Update dirauth data new 6bfdcdb Add more known parameters The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: data/consensus.cfg | 21 +++++++++- ...-63a476056017dda5ede35efc4e4f7acfcc1d7d1a.patch | 47 ++++++++++++++++++++++ utility.py | 11 ++++- 3 files changed, 76 insertions(+), 3 deletions(-) create mode 100644 stem-63a476056017dda5ede35efc4e4f7acfcc1d7d1a.patch -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 2