November 2022 - tor-commits - lists.torproject.org

[tor] branch release-0.4.7 updated (af4fff5ec6 -> 0f72752037)
by gitolite role 23 Nov '22

23 Nov '22

This is an automated email from the git hooks/post-receive script. dgoulet pushed a change to branch release-0.4.7 in repository tor. from af4fff5ec6 Merge branch 'maint-0.4.7' into release-0.4.7 new fbc9e92fdb relay: Use the configured number of threads for worker work calculation new 0f72752037 Merge branch 'maint-0.4.7' into release-0.4.7 The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: changes/ticket40719 | 3 +++ src/core/mainloop/cpuworker.c | 10 ++++++++++ src/core/mainloop/cpuworker.h | 2 ++ src/feature/relay/onion_queue.c | 8 +++++++- src/lib/evloop/workqueue.c | 8 ++++++++ src/lib/evloop/workqueue.h | 1 + 6 files changed, 31 insertions(+), 1 deletion(-) create mode 100644 changes/ticket40719 -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 1

[tor] branch maint-0.4.7 updated (cca19a4099 -> fbc9e92fdb)
by gitolite role 23 Nov '22

23 Nov '22

This is an automated email from the git hooks/post-receive script. dgoulet pushed a change to branch maint-0.4.7 in repository tor. from cca19a4099 version: Bump version to 0.4.7.11-dev new fbc9e92fdb relay: Use the configured number of threads for worker work calculation The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: changes/ticket40719 | 3 +++ src/core/mainloop/cpuworker.c | 10 ++++++++++ src/core/mainloop/cpuworker.h | 2 ++ src/feature/relay/onion_queue.c | 8 +++++++- src/lib/evloop/workqueue.c | 8 ++++++++ src/lib/evloop/workqueue.h | 1 + 6 files changed, 31 insertions(+), 1 deletion(-) create mode 100644 changes/ticket40719 -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[tor] branch main updated: relay: Use the configured number of threads for worker work calculation
by gitolite role 23 Nov '22

23 Nov '22

This is an automated email from the git hooks/post-receive script. dgoulet pushed a commit to branch main in repository tor. The following commit(s) were added to refs/heads/main by this push: new fbc9e92fdb relay: Use the configured number of threads for worker work calculation new 04d8753676 Merge branch 'maint-0.4.7' fbc9e92fdb is described below commit fbc9e92fdb364a741a3190fc22c6fa65d90e92e3 Author: David Goulet <dgoulet(a)torproject.org> AuthorDate: Wed Nov 23 13:47:59 2022 -0500 relay: Use the configured number of threads for worker work calculation We cap our number of CPU worker threads to at least 2 even if we have a single core. But also, before we used to always add one extra thread regardless of the number of core. This meant that we were off when re-using the get_num_cpus() function when calculating our onionskin work overhead because we were always off by one. This commit makes it that we always use the number of thread our actual thread pool was configured with. Fixes #40719 Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- changes/ticket40719 | 3 +++ src/core/mainloop/cpuworker.c | 10 ++++++++++ src/core/mainloop/cpuworker.h | 2 ++ src/feature/relay/onion_queue.c | 8 +++++++- src/lib/evloop/workqueue.c | 8 ++++++++ src/lib/evloop/workqueue.h | 1 + 6 files changed, 31 insertions(+), 1 deletion(-) diff --git a/changes/ticket40719 b/changes/ticket40719 new file mode 100644 index 0000000000..eec84dce0f --- /dev/null +++ b/changes/ticket40719 @@ -0,0 +1,3 @@ + o Minor bugfixes (cpuworker, relay): + - Fix an off by one overload calculation on the number of CPUs being used by + our thread pool. Fixes bug 40719; bugfix on 0.3.5.1-alpha. diff --git a/src/core/mainloop/cpuworker.c b/src/core/mainloop/cpuworker.c index 3ad556a184..39d4899075 100644 --- a/src/core/mainloop/cpuworker.c +++ b/src/core/mainloop/cpuworker.c @@ -144,6 +144,16 @@ cpu_init(void) set_max_pending_tasks(NULL); } +/** Return the number of threads configured for our CPU worker. */ +unsigned int +cpuworker_get_n_threads(void) +{ + if (!threadpool) { + return 0; + } + return threadpool_get_n_threads(threadpool); +} + /** Magic numbers to make sure our cpuworker_requests don't grow any * mis-framing bugs. */ #define CPUWORKER_REQUEST_MAGIC 0xda4afeed diff --git a/src/core/mainloop/cpuworker.h b/src/core/mainloop/cpuworker.h index 94545af586..9eee287c1f 100644 --- a/src/core/mainloop/cpuworker.h +++ b/src/core/mainloop/cpuworker.h @@ -38,5 +38,7 @@ void cpuworker_log_onionskin_overhead(int severity, int onionskin_type, const char *onionskin_type_name); void cpuworker_cancel_circ_handshake(or_circuit_t *circ); +unsigned int cpuworker_get_n_threads(void); + #endif /* !defined(TOR_CPUWORKER_H) */ diff --git a/src/feature/relay/onion_queue.c b/src/feature/relay/onion_queue.c index 6d1a6de15c..b844aefcd1 100644 --- a/src/feature/relay/onion_queue.c +++ b/src/feature/relay/onion_queue.c @@ -152,7 +152,13 @@ have_room_for_onionskin(uint16_t type) /* If we've got fewer than 50 entries, we always have room for one more. */ if (ol_entries[type] < 50) return 1; - num_cpus = get_num_cpus(options); + + /* If zero, this means our thread pool was never initialized meaning we can't + * really get here but make sure we don't have such value because we are + * using as a divisor. */ + num_cpus = cpuworker_get_n_threads(); + tor_assert(num_cpus > 0); + max_onion_queue_delay = get_onion_queue_max_delay(options); /* Compute how many microseconds we'd expect to need to clear all diff --git a/src/lib/evloop/workqueue.c b/src/lib/evloop/workqueue.c index 603dddd5a3..bc929148eb 100644 --- a/src/lib/evloop/workqueue.c +++ b/src/lib/evloop/workqueue.c @@ -672,3 +672,11 @@ replyqueue_process(replyqueue_t *queue) tor_mutex_release(&queue->lock); } + +/** Return the number of threads configured for the given pool. */ +unsigned int +threadpool_get_n_threads(threadpool_t *tp) +{ + tor_assert(tp); + return tp->n_threads; +} diff --git a/src/lib/evloop/workqueue.h b/src/lib/evloop/workqueue.h index 50391759bf..134fe7434f 100644 --- a/src/lib/evloop/workqueue.h +++ b/src/lib/evloop/workqueue.h @@ -65,5 +65,6 @@ void replyqueue_process(replyqueue_t *queue); int threadpool_register_reply_event(threadpool_t *tp, void (*cb)(threadpool_t *tp)); +unsigned int threadpool_get_n_threads(threadpool_t *tp); #endif /* !defined(TOR_WORKQUEUE_H) */ -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[tor] branch main updated: log: Remove extra newline in a log statement
by gitolite role 23 Nov '22

23 Nov '22

This is an automated email from the git hooks/post-receive script. dgoulet pushed a commit to branch main in repository tor. The following commit(s) were added to refs/heads/main by this push: new 8713d9762a log: Remove extra newline in a log statement 8713d9762a is described below commit 8713d9762a79c46829891cafbcf1a972f0946065 Author: David Goulet <dgoulet(a)torproject.org> AuthorDate: Wed Nov 23 13:28:22 2022 -0500 log: Remove extra newline in a log statement Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- src/core/or/circuitstats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/or/circuitstats.c b/src/core/or/circuitstats.c index f55771c79e..c759ddf281 100644 --- a/src/core/or/circuitstats.c +++ b/src/core/or/circuitstats.c @@ -709,7 +709,7 @@ circuit_build_times_handle_completed_hop(origin_circuit_t *circ) * Switch their purpose and wait. */ if (circ->base_.purpose != CIRCUIT_PURPOSE_C_MEASURE_TIMEOUT) { log_info(LD_CIRC, - "Deciding to timeout circuit %"PRIu32"\n", + "Deciding to timeout circuit %"PRIu32, (circ->global_identifier)); circuit_build_times_mark_circ_as_measurement_only(circ); } -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[tor-browser-spec] branch main updated: Bug 40037: FF102 Audit
by gitolite role 23 Nov '22

23 Nov '22

This is an automated email from the git hooks/post-receive script. richard pushed a commit to branch main in repository tor-browser-spec. The following commit(s) were added to refs/heads/main by this push: new 89cd77f Bug 40037: FF102 Audit 89cd77f is described below commit 89cd77f35caa56c04f9a63af619e3ac28634fa79 Author: Richard Pospesel <richard(a)torproject.org> AuthorDate: Wed Nov 23 13:44:12 2022 +0000 Bug 40037: FF102 Audit --- audits/FF102_AUDIT | 75 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 75 insertions(+) diff --git a/audits/FF102_AUDIT b/audits/FF102_AUDIT new file mode 100644 index 0000000..b712921 --- /dev/null +++ b/audits/FF102_AUDIT @@ -0,0 +1,75 @@ +Tracking issue: https://gitlab.torproject.org/tpo/applications/tor-browser-spec/-/issues/40… + +# General + +The audit begins at the commit hash where the previous audit ended. Use code_audit.sh for creating the diff and highlighting potentially problematic code. The audit is scoped to a specific language (currently C/C++, Rust, Java/Kotlin, and Javascript). + +The output includes the entire patch where the new problematic code was introduced. Search for `XXX MATCH XXX` to find the next potential violation. + +`code_audit.sh` contains the list of known problematic APIs. New usage of these functions are documented and analyzed in this audit. + +## Firefox: https://github.com/mozilla/gecko-dev.git + +- Start: `856b9168439ef597dbd103cd1e2940a8ad110450` ( `FIREFOX_RELEASE_102_BASE` ) +- End: `4960b7d420528392cc095c247a662670785b18b9` ( `FIREFOX_RELEASE_103_BASE` ) + +### Languages: +- [x] java +- [x] cpp +- [x] js +- [x] rust + +Nothing of interest (using `code_audit.sh`) + +--- + +## Application Services: https://github.com/mozilla/application-services.git + +- Start: `0302b89604bb29adb34fdcd710feabd3dd01992d` ( `v93.5.0` ) +- End: `55cbbddfdcb4ec82d2850e0811e8675fea2686c2` ( `v93.7.0` ) + +### Languages: +- [x] java +- [x] cpp +- [x] js +- [x] rust + +Nothing of interest (using `code_audit.sh`) + +## Android Components: https://github.com/mozilla-mobile/android-components.git + +- Start: `2b414097d4f540948f67f62f57c5ddcb0e2789d9` ( `v102.0.1` ) +- End: `cd19f9a6c5e26c4e57dda6e549a5c63ac7c042ea` ( `v102.0.14` ) + +### Languages: +- [x] java +- [x] cpp +- [x] js +- [x] rust + +Nothing of interest (using `code_audit.sh`) + +## Fenix: https://github.com/mozilla-mobile/fenix.git + +- Start: `cc68c965cbb29eb16244d242d433051327de5f48` ( `v102.0.0-beta.1` ) +- End: `2ec252d5f5d09b3eb73840ce585453b7105a7a7d` ( `releases_v102.0.0` ) + +### Languages: +- [x] java +- [x] cpp +- [x] js +- [x] rust + +Nothing of interest (using `code_audit.sh`) + +## Ticket Review ## + +### 102 https://bugzilla.mozilla.org/buglist.cgi?query_format=advanced&resolution=F… + +- https://bugzilla.mozilla.org/show_bug.cgi?id=1767919 : @pierov https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41152 + - nothing for us to do here +- ~~https://bugzilla.mozilla.org/show_bug.cgi?id=1770881 : @pierov https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41153~~ 102esr is unaffected: the Bugzilla ticket was wrong and then has been fixed +- https://bugzilla.mozilla.org/show_bug.cgi?id=1765167 : @pierov https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41154 + - no security/privacy implications, just a refactor required to maintain functionality +- https://bugzilla.mozilla.org/show_bug.cgi?id=1751450 : @richard https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41155 + - nothing for us to do here -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[builders/tor-browser-build] annotated tag tbb-11.5.9-build1 created (now e76027ca)
by gitolite role 23 Nov '22

23 Nov '22

This is an automated email from the git hooks/post-receive script. richard pushed a change to annotated tag tbb-11.5.9-build1 in repository builders/tor-browser-build. at e76027ca (tag) tagging 22dec89e6d89eb9c14d287396b440570828090c8 (commit) replaces tbb-11.5.8-build1 by Richard Pospesel on Tue Nov 22 21:26:25 2022 +0000 - Log ----------------------------------------------------------------- Tagging build1 for 11.5.9 -----BEGIN PGP SIGNATURE----- iQJLBAABCAA1FiEEvnyRTMkiztnZPSO33kc2A2PzSywFAmN9PoEXHHJpY2hhcmRA dG9ycHJvamVjdC5vcmcACgkQ3kc2A2PzSyx5Uw//faerQzjl9TI8SLHXLL3m+X4I hwB+iz9o5E0RSe3M9UHJonmiVf7EruRJI+vfQ09Bn84pW1hrNIlxMraXctYgKdnr pzPqmQ2Kd0e406qx0JcLaT2rHxmR4ay5UIdTvgw/HdwK1HNG4/FVjsQvJL3cC5m6 5T4HCJAxn7sLSTe+2HPIHpX7Nh4xx6U8/5/6DMTorRqfo+Eui1VJTNQPrXdPn1fv U3FpcfEEXHcicPIyre5XiIPzIz09QOhNk83rAEWF/yYLexWz3mu2w9RQ88CM0Cn+ Z7+/7mPy/wg7lvF3xAC8kkPS6Pk6bKWTuzIwksddybGPYA1R10O3hIpQhgztca6D mX1QmOJ/DVxcclzuOlTyyhNPLpu11T3p4A+5p9ot/GFCBC2AAUdpKKquUM07/eKF b6RUD/uteZVSUBA8GnVD533Sxe2IGwYT9OtVOKt5yDd/8gzaZ0aTjJ6EavAAqMqF v12VCIb+x23B0F+nEEeAupo+ONi23AdllSecV0ZDqmDU/1PavUI5BXOPyo/8Pw+E H3bfS5T49K0IcZWq/vFENFtrK5UoxI1jV3bDUPUtUm59gutjbbvFhxg/BMr5W84g i2taQGwa7K8qRbS6wr8wY0JHrNzTgXqPjJOr1FgA1vUM8ROhbJIVi7y5A1vNDnbL 0kJdEWNRwNeyovr1rPM= =rzEd -----END PGP SIGNATURE----- ----------------------------------------------------------------------- No new revisions were added by this update. -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[builders/tor-browser-build] branch maint-11.5 updated: Bug 40692: Prepare stable release 11.5.9 (Android only)
by gitolite role 23 Nov '22

23 Nov '22

This is an automated email from the git hooks/post-receive script. richard pushed a commit to branch maint-11.5 in repository builders/tor-browser-build. The following commit(s) were added to refs/heads/maint-11.5 by this push: new 22dec89e Bug 40692: Prepare stable release 11.5.9 (Android only) 22dec89e is described below commit 22dec89e6d89eb9c14d287396b440570828090c8 Author: Richard Pospesel <richard(a)torproject.org> AuthorDate: Tue Nov 22 19:04:42 2022 +0000 Bug 40692: Prepare stable release 11.5.9 (Android only) --- projects/fenix/config | 2 +- projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt | 4 ++++ rbm.conf | 3 +-- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/projects/fenix/config b/projects/fenix/config index 48a7777b..779197e9 100644 --- a/projects/fenix/config +++ b/projects/fenix/config @@ -1,7 +1,7 @@ # vim: filetype=yaml sw=2 version: '[% c("abbrev") %]' filename: 'fenix-[% c("version") %]-[% c("var/build_id") %].tar.gz' -git_hash: 'tor-browser-[% c("var/fenix_version") %]-[% c("var/torbrowser_branch") %]-1-build2' +git_hash: 'tor-browser-[% c("var/fenix_version") %]-[% c("var/torbrowser_branch") %]-1-build3' git_url: https://gitlab.torproject.org/tpo/applications/fenix.git tag_gpg_id: 1 gpg_keyring: torbutton.gpg diff --git a/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt b/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt index dcbf4c2e..11a11fbc 100644 --- a/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt +++ b/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt @@ -1,3 +1,7 @@ +Tor Browser 11.5.9 - November 22 2022 +* Android + * Bug 41471: Update targetSdkVersion to 31 [tor-browser] + Tor Browser 11.5.8 - November 18 2022 * All Platforms * Update Translations diff --git a/rbm.conf b/rbm.conf index cb3c3022..9635fbdd 100644 --- a/rbm.conf +++ b/rbm.conf @@ -71,10 +71,9 @@ buildconf: git_signtag_opt: '-s' var: - torbrowser_version: '11.5.8' + torbrowser_version: '11.5.9' torbrowser_build: 'build1' torbrowser_incremental_from: - - 11.5.7 project_name: tor-browser multi_lingual: 0 build_mar: 1 -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[pluggable-transports/snowflake] branch main updated (2c599f8 -> 4ebd85e)
by gitolite role 23 Nov '22

23 Nov '22

This is an automated email from the git hooks/post-receive script. shelikhoo pushed a change to branch main in repository pluggable-transports/snowflake. from 2c599f8 change bandwidth type from int to int64 to prevent overflow new 33248f3 Add Version Output Support to Snowflake new 4ebd85e add version output to log The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: client/snowflake.go | 10 ++++++++++ common/utls/client_hello_id.go | 8 ++++++++ common/utls/client_hello_id_version.go | 24 ++++++++++++++++++++++++ common/version/combined.go | 5 +++++ common/version/detail.go | 13 +++++++++++++ common/version/version.go | 7 +++++++ proxy/main.go | 10 ++++++++++ server/server.go | 10 ++++++++++ 8 files changed, 87 insertions(+) create mode 100644 common/utls/client_hello_id_version.go create mode 100644 common/version/combined.go create mode 100644 common/version/detail.go create mode 100644 common/version/version.go -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 2

[tor-browser] annotated tag tor-browser-102.5.0esr-12.0-1-build2 created (now ccaafafb3e1b)
by gitolite role 22 Nov '22

22 Nov '22

This is an automated email from the git hooks/post-receive script. richard pushed a change to annotated tag tor-browser-102.5.0esr-12.0-1-build2 in repository tor-browser. at ccaafafb3e1b (tag) tagging ee150f0a3ee5690d6ffebab25e3bec60eea4e7b4 (commit) replaces tor-browser-102.5.0esr-12.0-1-build1 by Richard Pospesel on Tue Nov 22 21:44:07 2022 +0000 - Log ----------------------------------------------------------------- Tagging build2 for 102.5esr-based alpha -----BEGIN PGP SIGNATURE----- iQJLBAABCAA1FiEEvnyRTMkiztnZPSO33kc2A2PzSywFAmN9QrcXHHJpY2hhcmRA dG9ycHJvamVjdC5vcmcACgkQ3kc2A2PzSyzMzw/9G5p5k554g7StyUIE5JeuQP/q 3OmBiiVyJUvoNGHwIJ/K8EuO+YRJWyAQG5K7VJcjyhYiAK+g3045VAQnitSN202N kjBK1KYZwi0PYgHVHoJ6BDrrzYOqR4orr9boD8QvYCpN2iOulogSu6JPMuJXWNDh ipHQhY6w+9easRz62qg8ISBUsF7A2QQhPEqp6yRACrL71l8Syko0hLO9NPYj0V7n NLefWOB0TVk/axhsyev5S5CqWEA4irl9JLKr6sAGuNwjKm3LCVtNZU0djBhtQe85 9FKwEp/OWs0NVD21/m8YDDF7ctHCVaoW5Eikt4paP0EXSNZSQzRo8hWG5dnLZyp/ vEc5H6CnxuTH8g3VtfY7QSuq9UVo8a4GzDn0vA8Gc6GYYuKUjHyLkFzfSpRzxzJX mjSgGgUwqvKbKn+lLDJ+BJiy+fnBmICrfgsfMPNmgZSMgyFj3GVJCnQUzO1YEo09 ydraOVyG2PbNPwR8ecQnsag+MDfL0W7IWiMZxRcUu3V5GnlrjTI/U9yFb/Fbm7ZK NDpArp0t8f1gIe72Iml3boQhLqXeVIKcGH+p1KBYG5N4jKyIrIjNLjqzOGUN3q71 ukaxTu6fD6SG84u0OgA+0p3diwuN9EdstxAPka4XDsKWyS+j6Enm2loVBsZiwk0q Xq3kj9TQDjwID+4p1VY= =sX/c -----END PGP SIGNATURE----- ----------------------------------------------------------------------- No new revisions were added by this update. -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[tor-browser] branch tor-browser-102.5.0esr-12.0-1 updated: fixup! Bug 10760: Integrate TorButton to TorBrowser core
by gitolite role 22 Nov '22

22 Nov '22

This is an automated email from the git hooks/post-receive script. richard pushed a commit to branch tor-browser-102.5.0esr-12.0-1 in repository tor-browser. The following commit(s) were added to refs/heads/tor-browser-102.5.0esr-12.0-1 by this push: new ee150f0a3ee5 fixup! Bug 10760: Integrate TorButton to TorBrowser core ee150f0a3ee5 is described below commit ee150f0a3ee5690d6ffebab25e3bec60eea4e7b4 Author: Richard Pospesel <richard(a)torproject.org> AuthorDate: Tue Nov 22 21:43:19 2022 +0000 fixup! Bug 10760: Integrate TorButton to TorBrowser core Bug 41473: Add support for Albanian (sq) --- toolkit/torproject/torbutton | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/toolkit/torproject/torbutton b/toolkit/torproject/torbutton index aadb30c6bcfc..5e6353832389 160000 --- a/toolkit/torproject/torbutton +++ b/toolkit/torproject/torbutton @@ -1 +1 @@ -Subproject commit aadb30c6bcfcc1ff0b9dd31fc9f514f06b757fe3 +Subproject commit 5e6353832389106713311ec96570420ca5563c0b -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0