August 2021 - tor-commits - lists.torproject.org

[tor/release-0.4.5] changelog: Update with security fix stanza
by dgoulet＠torproject.org 16 Aug '21

16 Aug '21

commit 35f0833900c7902179430849734d26b4560a1f9f Author: David Goulet <dgoulet(a)torproject.org> Date: Mon Aug 16 11:53:49 2021 -0400 changelog: Update with security fix stanza Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- ChangeLog | 14 +++++++++++++- ReleaseNotes | 16 ++++++++++++++-- 2 files changed, 27 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index 82631e2673..157aa5fad9 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,17 @@ Changes in version 0.4.5.10 - 2021-08-16 - This version fixes several bugs from earlier versions. + This version fixes several bugs from earlier versions of Tor, including one + that could lead to a denial-of-service attack. Everyone running an earlier + version, whether as a client, a relay, or an onion service, should upgrade + to Tor 0.3.5.16, 0.4.5.10, or 0.4.6.7. + + o Major bugfixes (cryptography, security): + - Resolve an assertion failure caused by a behavior mismatch between + our batch-signature verification code and our single-signature + verification code. This assertion failure could be triggered + remotely, leading to a denial of service attack. We fix this issue + by disabling batch verification. Fixes bug 40078; bugfix on + 0.2.6.1-alpha. This issue is also tracked as TROVE-2021-007 and + CVE-2021-38385. Found by Henry de Valence. o Minor feature (fallbackdir): - Regenerate fallback directories list. Close ticket 40447. diff --git a/ReleaseNotes b/ReleaseNotes index c8b4a12cfa..a6e39c2362 100644 --- a/ReleaseNotes +++ b/ReleaseNotes @@ -2,8 +2,20 @@ This document summarizes new features and bugfixes in each stable release of Tor. If you want to see more detailed descriptions of the changes in each development snapshot, see the ChangeLog file. -Changes in version 0.4.5.10 - 2021-08-13 - This version fixes several bugs from earlier versions. +Changes in version 0.4.5.10 - 2021-08-16 + This version fixes several bugs from earlier versions of Tor, including one + that could lead to a denial-of-service attack. Everyone running an earlier + version, whether as a client, a relay, or an onion service, should upgrade + to Tor 0.3.5.16, 0.4.5.10, or 0.4.6.7. + + o Major bugfixes (cryptography, security): + - Resolve an assertion failure caused by a behavior mismatch between our + batch-signature verification code and our single-signature verification + code. This assertion failure could be triggered remotely, leading to a + denial of service attack. We fix this issue by disabling batch + verification. Fixes bug 40078; bugfix on 0.2.6.1-alpha. This issue is + also tracked as TROVE-2021-007 and CVE-2021-38385. Found by Henry de + Valence. o Minor feature (fallbackdir): - Regenerate fallback directories list. Close ticket 40447.

1 0

[tor/release-0.4.5] changelog: Run format_changelog.py
by dgoulet＠torproject.org 16 Aug '21

16 Aug '21

commit fd74f7628eba25258817addb059512cd0eef1d80 Author: David Goulet <dgoulet(a)torproject.org> Date: Mon Aug 16 15:26:28 2021 -0400 changelog: Run format_changelog.py Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- ChangeLog | 34 ++++++++++++++++++---------------- 1 file changed, 18 insertions(+), 16 deletions(-) diff --git a/ChangeLog b/ChangeLog index 157aa5fad9..c60d9fa7b2 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,8 +1,8 @@ Changes in version 0.4.5.10 - 2021-08-16 - This version fixes several bugs from earlier versions of Tor, including one - that could lead to a denial-of-service attack. Everyone running an earlier - version, whether as a client, a relay, or an onion service, should upgrade - to Tor 0.3.5.16, 0.4.5.10, or 0.4.6.7. + This version fixes several bugs from earlier versions of Tor, + including one that could lead to a denial-of-service attack. Everyone + running an earlier version, whether as a client, a relay, or an onion + service, should upgrade to Tor 0.3.5.16, 0.4.5.10, or 0.4.6.7. o Major bugfixes (cryptography, security): - Resolve an assertion failure caused by a behavior mismatch between @@ -17,32 +17,34 @@ Changes in version 0.4.5.10 - 2021-08-16 - Regenerate fallback directories list. Close ticket 40447. o Minor features (geoip data): - - Update the geoip files to match the IPFire Location Database, - as retrieved on 2021/08/12. + - Update the geoip files to match the IPFire Location Database, as + retrieved on 2021/08/12. o Minor features (testing): - - Enable the deterministic RNG for unit tests that covers the address set - bloomfilter-based API's. Fixes bug 40419; bugfix on 0.3.3.2-alpha. + - Enable the deterministic RNG for unit tests that covers the + address set bloomfilter-based API's. Fixes bug 40419; bugfix + on 0.3.3.2-alpha. o Minor bugfix (crypto, backport from 0.4.6.7): - - Disable the unused batch verification feature of ed25519-donna. Fixes - bug 40078; bugfix on 0.2.6.1-alpha. Found by Henry de Valence. + - Disable the unused batch verification feature of ed25519-donna. + Fixes bug 40078; bugfix on 0.2.6.1-alpha. Found by Henry + de Valence. o Minor bugfixes (relay, backport from 0.4.6.7): - - Reduce the compression level for data streaming from HIGH to LOW. Fixes - bug 40301; bugfix on 0.3.5.1-alpha. + - Reduce the compression level for data streaming from HIGH to LOW. + Fixes bug 40301; bugfix on 0.3.5.1-alpha. o Minor bugfixes (timekeeping, backport from 0.4.6.7): - Calculate the time of day correctly on systems where the time_t type includes leap seconds. (This is not the case on most operating systems, but on those where it occurs, our tor_timegm function did not correctly invert the system's gmtime function, - which could result in assertion failures when calculating - voting schedules.) Fixes bug 40383; bugfix on 0.2.0.3-alpha. + which could result in assertion failures when calculating voting + schedules.) Fixes bug 40383; bugfix on 0.2.0.3-alpha. o Minor bugfixes (warnings, portability, backport from 0.4.6.6): - - Suppress a strict-prototype warning when building with some versions - of NSS. Fixes bug 40409; bugfix on 0.3.5.1-alpha. + - Suppress a strict-prototype warning when building with some + versions of NSS. Fixes bug 40409; bugfix on 0.3.5.1-alpha. Changes in version 0.4.5.9 - 2021-06-14

1 0

[tor/release-0.4.6] changelog: Update with security fix stanza
by dgoulet＠torproject.org 16 Aug '21

16 Aug '21

commit fde7ffb13f974dca75546188ee38fd762277a850 Author: David Goulet <dgoulet(a)torproject.org> Date: Mon Aug 16 11:54:01 2021 -0400 changelog: Update with security fix stanza Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- ChangeLog | 14 +++++++++++++- ReleaseNotes | 16 ++++++++++++++-- 2 files changed, 27 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index 04dec5a0de..12c4ff66ac 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,17 @@ Changes in version 0.4.6.7 - 2021-08-16 - This version fixes several bugs from earlier versions. + This version fixes several bugs from earlier versions of Tor, including one + that could lead to a denial-of-service attack. Everyone running an earlier + version, whether as a client, a relay, or an onion service, should upgrade + to Tor 0.3.5.16, 0.4.5.10, or 0.4.6.7. + + o Major bugfixes (cryptography, security): + - Resolve an assertion failure caused by a behavior mismatch between + our batch-signature verification code and our single-signature + verification code. This assertion failure could be triggered + remotely, leading to a denial of service attack. We fix this issue + by disabling batch verification. Fixes bug 40078; bugfix on + 0.2.6.1-alpha. This issue is also tracked as TROVE-2021-007 and + CVE-2021-38385. Found by Henry de Valence. o Minor feature (fallbackdir): - Regenerate fallback directories list. Close ticket 40447. diff --git a/ReleaseNotes b/ReleaseNotes index 20287f185a..aa54953aa7 100644 --- a/ReleaseNotes +++ b/ReleaseNotes @@ -2,8 +2,20 @@ This document summarizes new features and bugfixes in each stable release of Tor. If you want to see more detailed descriptions of the changes in each development snapshot, see the ChangeLog file. -Changes in version 0.4.6.7 - 2021-08-13 - This version fixes several bugs from earlier versions. +Changes in version 0.4.6.7 - 2021-08-16 + This version fixes several bugs from earlier versions of Tor, including one + that could lead to a denial-of-service attack. Everyone running an earlier + version, whether as a client, a relay, or an onion service, should upgrade + to Tor 0.3.5.16, 0.4.5.10, or 0.4.6.7. + + o Major bugfixes (cryptography, security): + - Resolve an assertion failure caused by a behavior mismatch between our + batch-signature verification code and our single-signature verification + code. This assertion failure could be triggered remotely, leading to a + denial of service attack. We fix this issue by disabling batch + verification. Fixes bug 40078; bugfix on 0.2.6.1-alpha. This issue is + also tracked as TROVE-2021-007 and CVE-2021-38385. Found by Henry de + Valence. o Minor feature (fallbackdir): - Regenerate fallback directories list. Close ticket 40447.

1 0

[tor/release-0.4.6] changelog: Run format_changelog.py
by dgoulet＠torproject.org 16 Aug '21

16 Aug '21

commit 31728f4ad386042d3088f015e28f15d91ae3e283 Author: David Goulet <dgoulet(a)torproject.org> Date: Mon Aug 16 15:26:18 2021 -0400 changelog: Run format_changelog.py Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- ChangeLog | 32 +++++++++++++++++--------------- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/ChangeLog b/ChangeLog index 12c4ff66ac..6411324083 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,8 +1,8 @@ Changes in version 0.4.6.7 - 2021-08-16 - This version fixes several bugs from earlier versions of Tor, including one - that could lead to a denial-of-service attack. Everyone running an earlier - version, whether as a client, a relay, or an onion service, should upgrade - to Tor 0.3.5.16, 0.4.5.10, or 0.4.6.7. + This version fixes several bugs from earlier versions of Tor, + including one that could lead to a denial-of-service attack. Everyone + running an earlier version, whether as a client, a relay, or an onion + service, should upgrade to Tor 0.3.5.16, 0.4.5.10, or 0.4.6.7. o Major bugfixes (cryptography, security): - Resolve an assertion failure caused by a behavior mismatch between @@ -17,29 +17,31 @@ Changes in version 0.4.6.7 - 2021-08-16 - Regenerate fallback directories list. Close ticket 40447. o Minor features (geoip data): - - Update the geoip files to match the IPFire Location Database, - as retrieved on 2021/08/12. + - Update the geoip files to match the IPFire Location Database, as + retrieved on 2021/08/12. o Minor bugfix (crypto): - - Disable the unused batch verification feature of ed25519-donna. Fixes - bug 40078; bugfix on 0.2.6.1-alpha. Found by Henry de Valence. + - Disable the unused batch verification feature of ed25519-donna. + Fixes bug 40078; bugfix on 0.2.6.1-alpha. Found by Henry + de Valence. o Minor bugfixes (onion service): - - Send back the extended SOCKS error 0xF6 (Onion Service Invalid Address) - for a v2 onion address. Fixes bug 40421; bugfix on 0.4.6.2-alpha. + - Send back the extended SOCKS error 0xF6 (Onion Service Invalid + Address) for a v2 onion address. Fixes bug 40421; bugfix + on 0.4.6.2-alpha. o Minor bugfixes (relay): - - Reduce the compression level for data streaming from HIGH to LOW in - order to reduce CPU load on the directory relays. Fixes bug 40301; - bugfix on 0.3.5.1-alpha. + - Reduce the compression level for data streaming from HIGH to LOW + in order to reduce CPU load on the directory relays. Fixes bug + 40301; bugfix on 0.3.5.1-alpha. o Minor bugfixes (timekeeping): - Calculate the time of day correctly on systems where the time_t type includes leap seconds. (This is not the case on most operating systems, but on those where it occurs, our tor_timegm function did not correctly invert the system's gmtime function, - which could result in assertion failures when calculating - voting schedules.) Fixes bug 40383; bugfix on 0.2.0.3-alpha. + which could result in assertion failures when calculating voting + schedules.) Fixes bug 40383; bugfix on 0.2.0.3-alpha. Changes in version 0.4.6.6 - 2021-06-30

1 0

[torspec/main] Specify the exact "fraction of paths" calculation that Tor uses.
by nickm＠torproject.org 16 Aug '21

16 Aug '21

commit 764abbfdea60b6a709801b244a2e3a798858a491 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Aug 16 12:25:27 2021 -0400 Specify the exact "fraction of paths" calculation that Tor uses. --- path-spec.txt | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/path-spec.txt b/path-spec.txt index 092e8d4..f02bee6 100644 --- a/path-spec.txt +++ b/path-spec.txt @@ -144,6 +144,23 @@ of their choices. NUM_GUARDS_TO_USE guards among our primary guards. (see guard-spec.txt) + We define the "fraction of bandwidth-weighted paths" as the product of + these three fractions. + + * The fraction of descriptors that we have for nodes with the Guard + flag, weighted by their bandwidth for the guard position. + * The fraction of descriptors that we have for all nodes, + weighted by their bandwidth for the middle position position. + * The fraction of descriptors that we have for nodes with the Exit + flag, weighted by their bandwidth for the exit position. + + If the consensus has zero weighted bandwidth for a given kind of + relay (Guard, Middle, or Exit), Tor instead uses the fraction of relays + for which it has the descriptor (not weighted by bandwidth at all). + + If the consensus lists zero exit-flagged relays, Tor instead uses the + fraction of middle relays. + 2.1.1. Clients build circuits preemptively

1 0

[torspec/main] fix trivial typo / whitespace
by arma＠torproject.org 16 Aug '21

16 Aug '21

commit 8b911a241e4294aeb7b6bf249e22682989ef81c2 Author: Roger Dingledine <arma(a)torproject.org> Date: Mon Aug 16 11:46:01 2021 -0400 fix trivial typo / whitespace --- rend-spec-v2.txt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/rend-spec-v2.txt b/rend-spec-v2.txt index 7ea0362..0306f4b 100644 --- a/rend-spec-v2.txt +++ b/rend-spec-v2.txt @@ -673,7 +673,7 @@ v1, and v2 since 0.1.1.x. As of Tor 0.2.0.7-alpha and 0.1.2.18, clients switched to using the v2 intro format. - The Timestampe (TS) field is no longer used in Tor 0.2.3.9-alpha and + The Timestamp (TS) field is no longer used in Tor 0.2.3.9-alpha and later. Clients MAY refrain from sending it; see the "Support022HiddenServices" parameter in dir-spec.txt. Clients SHOULD NOT send a precise timestamp, and should instead round to the nearest @@ -1039,7 +1039,6 @@ e.g., for Tor controllers; nothing in Tor itself requires or uses it. - 3. Hidden service directory operation This section has been introduced with the v2 hidden service descriptor

1 0

[torspec/main] spec change cleanup
by arma＠torproject.org 16 Aug '21

16 Aug '21

commit 6d1e05d47d66f4a243471a8573d3809f5116f166 Author: Roger Dingledine <arma(a)torproject.org> Date: Mon Aug 16 11:44:45 2021 -0400 spec change cleanup (hopefully i picked the right fix :) --- tor-spec.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tor-spec.txt b/tor-spec.txt index 4d9513e..de95acb 100644 --- a/tor-spec.txt +++ b/tor-spec.txt @@ -1967,7 +1967,7 @@ see tor-design.pdf. range bounds for randomized padding timeouts may be specified as unsigned integer values in milliseconds. The ito_low_ms field should not be lower than the current consensus parameter value for nf_ito_low (default: - 1500). The ito_high_ms field must should not be lower than ito_low_ms. + 1500). The ito_high_ms field should not be lower than ito_low_ms. (If any party receives an out-of-range value, they clamp it so that it is in-range.)

1 0

[torspec/main] Document supported range for bandwdith values in netstatus
by nickm＠torproject.org 16 Aug '21

16 Aug '21

commit fe5b008aea1be9ec89421f8c943ccd8d5b529b8c Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Aug 16 11:34:52 2021 -0400 Document supported range for bandwdith values in netstatus --- dir-spec.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/dir-spec.txt b/dir-spec.txt index 39a0318..7ba11c0 100644 --- a/dir-spec.txt +++ b/dir-spec.txt @@ -2324,6 +2324,9 @@ a measured bandwidth currently produced by measuring stream capacities. It does not occur in consensuses. + 'Bandwidth=' and 'Measured=' values must be between 0 and + 2^32 - 1 inclusive. + The "Unmeasured=1" value is included in consensuses generated with method 17 or later when the 'Bandwidth=' value is not based on a threshold of 3 or more measurements for this relay.

1 0

[torspec/main] Specify case in BEGIN messages.
by nickm＠torproject.org 16 Aug '21

16 Aug '21

commit ea4f88cc54e26b422db8828bed88ff156958d5f0 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Aug 16 11:24:36 2021 -0400 Specify case in BEGIN messages. --- tor-spec.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tor-spec.txt b/tor-spec.txt index d7b2c53..a3a0ffd 100644 --- a/tor-spec.txt +++ b/tor-spec.txt @@ -1693,6 +1693,9 @@ see tor-design.pdf. dotted-quad format, or an IPv6 address surrounded by square brackets; and where PORT is a decimal integer between 1 and 65535, inclusive. + The ADDRPORT string SHOULD be sent in lower case, to avoid + fingerprinting. Implementations MUST accept strings in any case. + The FLAGS value has one or more of the following bits set, where "bit 1" is the LSB of the 32-bit value, and "bit 32" is the MSB. (Remember that all values in Tor are big-endian (see 0.1.1 above), so

1 0

[torspec/main] Clarify handling of dubious RELAY_END cell formats.
by nickm＠torproject.org 16 Aug '21

16 Aug '21

commit a681521b9d04135d2cff5d20b82927162c6626cc Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Aug 16 11:25:08 2021 -0400 Clarify handling of dubious RELAY_END cell formats. --- tor-spec.txt | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/tor-spec.txt b/tor-spec.txt index a3a0ffd..4d9513e 100644 --- a/tor-spec.txt +++ b/tor-spec.txt @@ -1817,25 +1817,31 @@ see tor-design.pdf. 14 -- REASON_NOTDIRECTORY (Client sent RELAY_BEGIN_DIR to a non-directory relay.) + [*] Older versions of Tor also send this reason when connections are + reset. + + OPs and ORs MUST accept reasons not on the above list, since future + versions of Tor may provide more fine-grained reasons. - For most reasons, the format is: + For most reasons, the format of RELAY_END is: Reason [1 byte] - For REASON_EXITPOLICY, the format is: + For REASON_EXITPOLICY, the format of RELAY_END is: Reason [1 byte] IPv4 or IPv6 address [4 bytes or 16 bytes] TTL [4 bytes] - OPs and ORs MUST accept reasons not on the above list, since future - versions of Tor may provide more fine-grained reasons. + (If the TTL is absent, it should be treated as if it were 0xffffffff. + If the address is absent or is the wrong length, the RELAY_END message + should be processed anyway.) Tors SHOULD NOT send any reason except REASON_MISC for a stream that they have originated. - [*] Older versions of Tor also send this reason when connections are - reset. + Implementations SHOULD accept empty RELAY_END messages, and treat them + as if they specified REASON_MISC. Upon receiving a RELAY_END cell, the recipient may be sure that no further cells will arrive on that stream, and can treat such cells as a protocol

1 0