June 2021 - tor-commits - lists.torproject.org

[tor/release-0.4.5] Merge branch 'maint-0.4.4' into maint-0.4.5
by nickm＠torproject.org 14 Jun '21

14 Jun '21

commit e2d01aac9e2f45f2c8f0de057f3104d6cfcdaa80 Merge: d60f8fe98a 7c19a4d924 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Jun 10 08:37:34 2021 -0400 Merge branch 'maint-0.4.4' into maint-0.4.5 changes/ticket40390 | 8 ++++++++ src/lib/crypt_ops/crypto_rand.c | 4 ++-- 2 files changed, 10 insertions(+), 2 deletions(-)

1 0

[tor/release-0.4.5] Merge branch 'maint-0.3.5' into maint-0.4.4
by nickm＠torproject.org 14 Jun '21

14 Jun '21

commit 7c19a4d924120f42c224ea357b388b73d05c2d89 Merge: 57a41348ee 7fdfc2ea54 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Jun 10 08:37:26 2021 -0400 Merge branch 'maint-0.3.5' into maint-0.4.4 changes/ticket40390 | 8 ++++++++ src/lib/crypt_ops/crypto_rand.c | 4 ++-- 2 files changed, 10 insertions(+), 2 deletions(-)

1 0

[tor/release-0.4.5] Merge branch 'maint-0.4.5' into release-0.4.5
by nickm＠torproject.org 14 Jun '21

14 Jun '21

commit be54257cf9f31dc2501d770cc6551a0f03aa56b6 Merge: 5dd45ccffc e2d01aac9e Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Jun 10 08:37:34 2021 -0400 Merge branch 'maint-0.4.5' into release-0.4.5 changes/ticket40390 | 8 ++++++++ src/lib/crypt_ops/crypto_rand.c | 4 ++-- 2 files changed, 10 insertions(+), 2 deletions(-)

1 0

[tor/release-0.4.5] Assert on _all_ failures from RAND_bytes().
by nickm＠torproject.org 14 Jun '21

14 Jun '21

commit c0aa9e0a1b1633d3b221199d516294e14a5db9c6 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon May 17 08:50:01 2021 -0400 Assert on _all_ failures from RAND_bytes(). Previously, we would detect errors from a missing RNG implementation, but not failures from the RNG code itself. Fortunately, it appears those failures do not happen in practice when Tor is using OpenSSL's default RNG implementation. Fixes bug 40390; bugfix on 0.2.8.1-alpha. This issue is also tracked as TROVE-2021-004. Reported by Jann Horn at Google's Project Zero. --- changes/ticket40390 | 8 ++++++++ src/lib/crypt_ops/crypto_rand.c | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/changes/ticket40390 b/changes/ticket40390 new file mode 100644 index 0000000000..b56fa4d9da --- /dev/null +++ b/changes/ticket40390 @@ -0,0 +1,8 @@ + o Major bugfixes (security, defense-in-depth): + - Detect a wider variety of failure conditions from the OpenSSL RNG + code. Previously, we would detect errors from a missing RNG + implementation, but not failures from the RNG code itself. + Fortunately, it appears those failures do not happen in practice + when Tor is using OpenSSL's default RNG implementation. + Fixes bug 40390; bugfix on 0.2.8.1-alpha. This issue is also tracked as + TROVE-2021-004. Reported by Jann Horn at Google's Project Zero. diff --git a/src/lib/crypt_ops/crypto_rand.c b/src/lib/crypt_ops/crypto_rand.c index 915fe0870d..206929d6b3 100644 --- a/src/lib/crypt_ops/crypto_rand.c +++ b/src/lib/crypt_ops/crypto_rand.c @@ -525,7 +525,7 @@ crypto_rand_unmocked(char *to, size_t n) /* We consider a PRNG failure non-survivable. Let's assert so that we get a * stack trace about where it happened. */ - tor_assert(r >= 0); + tor_assert(r == 1); #endif }

1 0

[tor/release-0.4.5] Merge branch 'maint-0.3.5' into maint-0.4.4
by nickm＠torproject.org 14 Jun '21

14 Jun '21

commit 31eaa81f59749ed7e9d4f1bad24225d23eb6f654 Merge: 7c19a4d924 d71bf986b4 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Jun 10 08:42:15 2021 -0400 Merge branch 'maint-0.3.5' into maint-0.4.4 changes/bug40391 | 9 +++++++++ src/core/or/circuitmux.c | 7 ++++--- 2 files changed, 13 insertions(+), 3 deletions(-) diff --cc src/core/or/circuitmux.c index b770e40bf2,e7309553c4..be54ae6ec6 --- a/src/core/or/circuitmux.c +++ b/src/core/or/circuitmux.c @@@ -169,17 -216,21 +169,18 @@@ chanid_circid_entries_eq(chanid_circid_ static inline unsigned int chanid_circid_entry_hash(chanid_circid_muxinfo_t *a) { - return (((unsigned int)(a->circ_id) << 8) ^ - ((unsigned int)((a->chan_id >> 32) & 0xffffffff)) ^ - ((unsigned int)(a->chan_id & 0xffffffff))); + uint8_t data[8 + 4]; + set_uint64(data, a->chan_id); + set_uint32(data + 8, a->circ_id); + return (unsigned) siphash24g(data, sizeof(data)); } -/* Declare the struct chanid_circid_muxinfo_map type */ -HT_HEAD(chanid_circid_muxinfo_map, chanid_circid_muxinfo_t); - /* Emit a bunch of hash table stuff */ HT_PROTOTYPE(chanid_circid_muxinfo_map, chanid_circid_muxinfo_t, node, - chanid_circid_entry_hash, chanid_circid_entries_eq) + chanid_circid_entry_hash, chanid_circid_entries_eq); HT_GENERATE2(chanid_circid_muxinfo_map, chanid_circid_muxinfo_t, node, chanid_circid_entry_hash, chanid_circid_entries_eq, 0.6, - tor_reallocarray_, tor_free_) + tor_reallocarray_, tor_free_); /* * Circuitmux alloc/free functions

1 0

[tor/release-0.4.5] Merge branch 'maint-0.4.4' into maint-0.4.5
by nickm＠torproject.org 14 Jun '21

14 Jun '21

commit d60f8fe98a59ce13809e65de67e53b3dcf6199f0 Merge: c80b98520b 57a41348ee Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Jun 10 08:21:48 2021 -0400 Merge branch 'maint-0.4.4' into maint-0.4.5 changes/geoip-2021-06-10 | 3 + src/config/geoip | 4764 +++++++++++++++++++++++++++------------------- src/config/geoip6 | 2826 ++++++++++++++++----------- 3 files changed, 4536 insertions(+), 3057 deletions(-)

1 0

[tor/release-0.4.5] Merge branch 'bug40391_035' into maint-0.3.5
by nickm＠torproject.org 14 Jun '21

14 Jun '21

commit d71bf986b4faf7cb3b654192bc67d5b674cfcf02 Merge: 7fdfc2ea54 4c06c619fa Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Jun 10 08:41:59 2021 -0400 Merge branch 'bug40391_035' into maint-0.3.5 changes/bug40391 | 9 +++++++++ src/core/or/circuitmux.c | 8 ++++---- 2 files changed, 13 insertions(+), 4 deletions(-)

1 0

[tor/release-0.4.5] Merge branch 'bug40390_035_squashed' into maint-0.3.5
by nickm＠torproject.org 14 Jun '21

14 Jun '21

commit 7fdfc2ea5470c572a113321e19cdb5144b10cdd8 Merge: 520d5c108f c0aa9e0a1b Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Jun 10 08:34:25 2021 -0400 Merge branch 'bug40390_035_squashed' into maint-0.3.5 changes/ticket40390 | 8 ++++++++ src/lib/crypt_ops/crypto_rand.c | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-)

1 0

[tor/release-0.4.5] Merge branch 'maint-0.4.4' into maint-0.4.5
by nickm＠torproject.org 14 Jun '21

14 Jun '21

commit 1da8621c0aef1f3fa694802b2bbea888a8d82d99 Merge: e2d01aac9e 31eaa81f59 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Jun 10 08:42:15 2021 -0400 Merge branch 'maint-0.4.4' into maint-0.4.5 changes/bug40391 | 9 +++++++++ src/core/or/circuitmux.c | 7 ++++--- 2 files changed, 13 insertions(+), 3 deletions(-)

1 0

[tor/release-0.4.5] Merge branch 'maint-0.4.5' into release-0.4.5
by nickm＠torproject.org 14 Jun '21

14 Jun '21

commit 436c18510f5c77e1ec340e9540243af9eb5e16c9 Merge: be54257cf9 1da8621c0a Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Jun 10 08:42:15 2021 -0400 Merge branch 'maint-0.4.5' into release-0.4.5 changes/bug40391 | 9 +++++++++ src/core/or/circuitmux.c | 7 ++++--- 2 files changed, 13 insertions(+), 3 deletions(-)

1 0