May 2021 - tor-commits - lists.torproject.org

[tor/release-0.4.6] Merge branch 'maint-0.4.5' into release-0.4.5
by dgoulet＠torproject.org 07 May '21

07 May '21

commit 366bb3c427f1878bf4b0b0a41d45844c924dfb49 Merge: 135b8eea36 2f87b2ab75 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Nov 23 14:04:35 2020 -0500 Merge branch 'maint-0.4.5' into release-0.4.5 configure.ac | 4 ++-- contrib/win32build/tor-mingw.nsi.in | 2 +- src/win32/orconfig.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)

1 0

[tor/release-0.4.6] Edit the 0.4.5.2-alpha configlog entries.
by dgoulet＠torproject.org 07 May '21

07 May '21

commit 82cd1d30dd7e6f050f618d44d394eb3a7891317e Author: Nick Mathewson <nickm(a)torproject.org> Date: Sat Nov 21 15:37:26 2020 -0500 Edit the 0.4.5.2-alpha configlog entries. --- ChangeLog | 92 ++++++++++++++++++++++++++++++++++----------------------------- 1 file changed, 50 insertions(+), 42 deletions(-) diff --git a/ChangeLog b/ChangeLog index d1beed5fc9..a88ce75757 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,29 +1,30 @@ Changes in version 0.4.5.2-alpha - 2020-11-23 Tor 0.4.5.2-alpha is the second alpha release in the 0.4.5.2-alpha - series. It fixes several bugs present in earlier releases. - - - In the v3 handshaking code, Use connection_or_change_state() to - change the state. Previously, we changed the state directly, but this - did not pass a state change to the pubsub or channel object. Fixes bug - 32880; bugfix on 0.2.3.6-alpha. Patch by Neel Chauhan. + series. It fixes several bugs present in earlier releases, including + one that made it impractical to run relays on Windows. It also adds a + few small safety features to improve tor's behavior in the presence of + strange compile-time options, misbehaving proxies, and future versions + of OpenSSL. o Major bugfixes (relay, windows): - - Fix bug where running a relay on Windows would use 100% CPU after - running for some time. This causes Tor to require Windows Vista or - later to build and run. bug 30187; bugfix on 0.4.5.1-alpha. Patch - by Daniel Pinto. + - Fix a bug in our implementation of condition variables on Windows. + Previously, a relay on Windows would use 100% CPU after running + for some time. Because of this change, Tor now require Windows + Vista or later to build and run. Fixes bug 30187; bugfix on + 0.2.6.3-alpha. (This bug became more serious in 0.3.1.1-alpha with + the introduction of consensus diffs.) Patch by Daniel Pinto. o Minor features (compilation): - Disable deprecation warnings when building with OpenSSL 3.0.0 or - later. There are a number of newly deprecated APIs in OpenSSL + later. There are a number of APIs newly deprecated in OpenSSL 3.0.0 that Tor still requires. (A later version of Tor will try to - stop depending on these.) Closes ticket 40165. + stop depending on these APIs.) Closes ticket 40165. o Minor features (protocol, proxy support, defense in depth): - Respond more deliberately to misbehaving proxies that leave - leftover data on their connections, so as to be even less likely - as to allow them to pass their data off as having come from a - relay. Closes ticket 40017. + leftover data on their connections, so as to make Tor even less + likely to allow the proxies to pass their data off as having come + from a relay. Closes ticket 40017. o Minor features (safety): - Log a warning at startup if Tor is built with compile-time options @@ -31,53 +32,60 @@ Changes in version 0.4.5.2-alpha - 2020-11-23 ticket 18888. o Minor bugfixes (circuit, handshake): + - In the v3 handshaking code, use connection_or_change_state() to + change the state. Previously, we changed the state directly, but + this did not pass a state change to the pubsub or channel objects, + potentially leading to bugs. Fixes bug 32880; bugfix on + 0.2.3.6-alpha. Patch by Neel Chauhan. o Minor bugfixes (compilation): - - Fix a compilation issue in which the correct 'ranlib' program was - not used when building libtor.a. Fixes bug 40172; bugfix - on 0.4.5.1-alpha. + - Use the correct 'ranlib' program when building libtor.a. + Previously we used the default ranlib, which broke some kinds of + cross-compilation. Fixes bug 40172; bugfix on 0.4.5.1-alpha. - Remove a duplicate typedef in metrics_store.c. Fixes bug 40177; bugfix on 0.4.5.1-alpha. - - With USDT tracing enabled, if STAP_PROBEV() is missing, don't + - When USDT tracing is enabled, and STAP_PROBEV() is missing, don't attempt to build. Linux supports that macro but not the BSDs. Fixes bug 40174; bugfix on 0.4.5.1-alpha. o Minor bugfixes (configuration): - - Exit tor on a misconfiguration when the Bridge line has a - transport but no corresponding ClientTransportPlugin can be found. - Prior to this fix, tor would attempt to connect to the bridge - directly without using the transport leading to a possible leak on - the wire. Fixes bug 25528; bugfix on 0.2.6.1-alpha. + - Exit Tor on a misconfiguration when the Bridge line is configured + to use a transport but no corresponding ClientTransportPlugin can + be found. Prior to this fix, Tor would attempt to connect to the + bridge directly without using the transport, making it easier for + adversaries to notice the bridge. Fixes bug 25528; bugfix + on 0.2.6.1-alpha. - Fix an issue where an ORPort was validated against other type of - ports when it should have been only checked against other ORPorts. - This lead to "DirPort auto" to be ignored and failing to be used. - Fixes bug 40195; bugfix on 0.4.5.1-alpha. - - Second non ORPort of a different family (ex: SocksPort [::1]:9050) - was ignored due to a logical configuration parsing error. Fixes - bug 40183; bugfix on 0.4.5.1-alpha. + ports, when it should have been only checked against other + ORPorts. This bug lead to "DirPort auto" getting ignored. Fixes + bug 40195; bugfix on 0.4.5.1-alpha. + - Fix a bug where the second non-ORPort with a variant family (ex: + SocksPort [::1]:9050) was ignored due to a logical configuration + parsing error. Fixes bug 40183; bugfix on 0.4.5.1-alpha. o Minor bugfixes (crash, relay, signing key): - - Avoid asserts when we run Tor from the command line with - `--key-expiration sign` when an ORPort is not set. Fixes bug + - Avoid assertion failures when we run Tor from the command line + with `--key-expiration sign`, but an ORPort is not set. Fixes bug 40015; bugfix on 0.3.2.1-alpha. Patch by Neel Chauhan. o Minor bugfixes (logging): - Remove trailing whitespaces from control event log messages. Fixes bug 32178; bugfix on 0.1.1.1-alpha. Based on a patch by Amadeusz Pawlik. - - Turn a SENDME failure log warning into a debug. It can actually - happen naturally. Fixes bug 40142; bugfix on 0.4.1.1-alpha. + - Turn warning-level log message about SENDME failure into a debug- + level message. (This event can happen naturally, and is no reason + for concern). Fixes bug 40142; bugfix on 0.4.1.1-alpha. - o Minor bugfixes (relay, address): - - Don't trigger an IP change if no new valid IP can be found. Fixes - bug 40071; bugfix on 0.4.5.1-alpha. - - When attempting to discover our IP, don't launch a descriptor - fetch anymore but rather a simple test circuit since the address - discovery is through the NETINFO cell now from the authorities. + o Minor bugfixes (relay, address discovery): + - Don't trigger an IP change when no new valid IP can be found. Fixes bug 40071; bugfix on 0.4.5.1-alpha. + - When attempting to discover our IP, use a simple test circuit, + rather than a descriptor fetch: the same address information is + present in NETINFO cells, and is better authenticated there. Fixes + bug 40071; bugfix on 0.4.5.1-alpha. o Minor bugfixes (testing): - - Fix the config/parse_tcp_proxy_line test so that it works + - Fix the `config/parse_tcp_proxy_line` test so that it works correctly on systems where the DNS provider hijacks invalid queries. Fixes part of bug 40179; bugfix on 0.4.3.1-alpha. - Fix unit tests that used newly generated list of routers so that @@ -88,7 +96,7 @@ Changes in version 0.4.5.2-alpha - 2020-11-23 handshake so that it works correctly with the version of hashlib provided by Python 3.9. Fixes part of bug 40179; bugfix on 0.3.1.6-rc. - - Fix the "tortls/openssl/log_one_error" test to work with OpenSSL + - Fix the `tortls/openssl/log_one_error` test to work with OpenSSL 3.0.0. Fixes bug 40170; bugfix on 0.2.8.1-alpha. o Removed features (controller):

1 0

[tor/release-0.4.6] Changelog: I have decided "whitespace" is a mass noun.
by dgoulet＠torproject.org 07 May '21

07 May '21

commit d2d60efcc3d4b93d8c5143c6c899de4436d8867a Author: Nick Mathewson <nickm(a)torproject.org> Date: Sat Nov 21 17:27:24 2020 -0500 Changelog: I have decided "whitespace" is a mass noun. --- ChangeLog | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index a88ce75757..7f1346fea0 100644 --- a/ChangeLog +++ b/ChangeLog @@ -69,7 +69,7 @@ Changes in version 0.4.5.2-alpha - 2020-11-23 40015; bugfix on 0.3.2.1-alpha. Patch by Neel Chauhan. o Minor bugfixes (logging): - - Remove trailing whitespaces from control event log messages. Fixes + - Remove trailing whitespace from control event log messages. Fixes bug 32178; bugfix on 0.1.1.1-alpha. Based on a patch by Amadeusz Pawlik. - Turn warning-level log message about SENDME failure into a debug-

1 0

[tor/release-0.4.6] A couple of edits for the 0.4.5.2-alpha changelog.
by dgoulet＠torproject.org 07 May '21

07 May '21

commit 3d6146a41c6a837979d4629621ec12472eb763f0 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Nov 23 11:56:55 2020 -0500 A couple of edits for the 0.4.5.2-alpha changelog. --- ChangeLog | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/ChangeLog b/ChangeLog index 7f1346fea0..5e778eaf51 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,9 +1,9 @@ Changes in version 0.4.5.2-alpha - 2020-11-23 - Tor 0.4.5.2-alpha is the second alpha release in the 0.4.5.2-alpha - series. It fixes several bugs present in earlier releases, including - one that made it impractical to run relays on Windows. It also adds a - few small safety features to improve tor's behavior in the presence of - strange compile-time options, misbehaving proxies, and future versions + Tor 0.4.5.2-alpha is the second alpha release in the 0.4.5.x series. + It fixes several bugs present in earlier releases, including one that + made it impractical to run relays on Windows. It also adds a few small + safety features to improve Tor's behavior in the presence of strange + compile-time options, misbehaving proxies, and future versions of OpenSSL. o Major bugfixes (relay, windows): @@ -34,8 +34,8 @@ Changes in version 0.4.5.2-alpha - 2020-11-23 o Minor bugfixes (circuit, handshake): - In the v3 handshaking code, use connection_or_change_state() to change the state. Previously, we changed the state directly, but - this did not pass a state change to the pubsub or channel objects, - potentially leading to bugs. Fixes bug 32880; bugfix on + this did not pass the state change to the pubsub or channel + objects, potentially leading to bugs. Fixes bug 32880; bugfix on 0.2.3.6-alpha. Patch by Neel Chauhan. o Minor bugfixes (compilation): @@ -55,13 +55,13 @@ Changes in version 0.4.5.2-alpha - 2020-11-23 bridge directly without using the transport, making it easier for adversaries to notice the bridge. Fixes bug 25528; bugfix on 0.2.6.1-alpha. - - Fix an issue where an ORPort was validated against other type of + - Fix an issue where an ORPort was compared with other kinds of ports, when it should have been only checked against other ORPorts. This bug lead to "DirPort auto" getting ignored. Fixes bug 40195; bugfix on 0.4.5.1-alpha. - - Fix a bug where the second non-ORPort with a variant family (ex: - SocksPort [::1]:9050) was ignored due to a logical configuration - parsing error. Fixes bug 40183; bugfix on 0.4.5.1-alpha. + - Fix a bug where a second non-ORPort with a variant family (ex: + SocksPort [::1]:9050) would ignored due to a configuration parsing + error. Fixes bug 40183; bugfix on 0.4.5.1-alpha. o Minor bugfixes (crash, relay, signing key): - Avoid assertion failures when we run Tor from the command line

1 0

[tor/release-0.4.6] Merge branch 'maint-0.4.5' into release-0.4.5
by dgoulet＠torproject.org 07 May '21

07 May '21

commit 8970d7f7ae7d3a48f93e24d66ef252ead732d216 Merge: 5d1db8fdfd e74f168bb4 Author: David Goulet <dgoulet(a)torproject.org> Date: Tue Dec 8 14:51:43 2020 -0500 Merge branch 'maint-0.4.5' into release-0.4.5 changes/ticket40205 | 5 +++++ src/feature/relay/selftest.c | 7 ++++++- 2 files changed, 11 insertions(+), 1 deletion(-)

1 0

[tor/release-0.4.6] Merge branch 'maint-0.4.5' into release-0.4.5
by dgoulet＠torproject.org 07 May '21

07 May '21

commit 878b067c69c1e40b8a0abd55bee63b15f270d706 Merge: 6a167d2123 4a77aa6e82 Author: David Goulet <dgoulet(a)torproject.org> Date: Tue Dec 15 11:58:22 2020 -0500 Merge branch 'maint-0.4.5' into release-0.4.5 changes/bug40190 | 4 ++++ src/core/proto/proto_socks.c | 7 ++++++- 2 files changed, 10 insertions(+), 1 deletion(-)

1 0

[tor/release-0.4.6] Merge branch 'maint-0.4.5' into release-0.4.5
by dgoulet＠torproject.org 07 May '21

07 May '21

commit 6ffa0f3e6b1caadfa3f9c2d2b3c2b8ceb5723f8f Merge: 878b067c69 7998ea2f18 Author: Alexander Færøy <ahf(a)torproject.org> Date: Wed Dec 16 20:29:19 2020 +0000 Merge branch 'maint-0.4.5' into release-0.4.5 changes/ticket40188 | 4 ++++ doc/man/tor.1.txt | 8 +++++--- 2 files changed, 9 insertions(+), 3 deletions(-)

1 0

[tor/release-0.4.6] Merge branch 'maint-0.4.5' into release-0.4.5
by dgoulet＠torproject.org 07 May '21

07 May '21

commit 6a167d21236c5437d03296daaf48fd9268e014ed Merge: 8970d7f7ae c731a4efec Author: George Kadianakis <desnacked(a)riseup.net> Date: Tue Dec 15 16:29:01 2020 +0200 Merge branch 'maint-0.4.5' into release-0.4.5 src/lib/fs/conffile.c | 41 +++++++++++++++++++++++++++++++---------- src/lib/fs/path.c | 15 ++++++++++++++- src/lib/sandbox/sandbox.c | 39 ++++++++++++++++++++++++++++++++++++--- src/lib/sandbox/sandbox.h | 5 ++--- 4 files changed, 83 insertions(+), 17 deletions(-)

1 0

[tor/maint-0.4.5] Log warning when connecting to soon-to-be-deprecated v2 onions.
by dgoulet＠torproject.org 07 May '21

07 May '21

commit 80c404c4b79f3bcba3fc4585d4c62a62a04f3ed9 Author: George Kadianakis <desnacked(a)riseup.net> Date: Wed May 5 10:50:29 2021 +0300 Log warning when connecting to soon-to-be-deprecated v2 onions. --- changes/ticket40373 | 3 +++ src/core/or/connection_edge.c | 10 ++++++++++ 2 files changed, 13 insertions(+) diff --git a/changes/ticket40373 b/changes/ticket40373 new file mode 100644 index 0000000000..e2ea297bc2 --- /dev/null +++ b/changes/ticket40373 @@ -0,0 +1,3 @@ + o Minor features (onion services): + - Add warning message when connecting to soon-to-be-deprecated v2 onions. + Closes ticket 40373. diff --git a/src/core/or/connection_edge.c b/src/core/or/connection_edge.c index a33c64fe19..7f260ba185 100644 --- a/src/core/or/connection_edge.c +++ b/src/core/or/connection_edge.c @@ -2582,6 +2582,16 @@ connection_ap_handshake_rewrite_and_attach(entry_connection_t *conn, tor_assert(addresstype == ONION_V2_HOSTNAME || addresstype == ONION_V3_HOSTNAME); tor_assert(!automap); + + if (addresstype == ONION_V2_HOSTNAME) { + log_warn(LD_PROTOCOL, + "Warning! You've just connected to a v2 onion address. These " + "addresses are deprecated for security reasons, and are no " + "longer supported in Tor. Please encourage the site operator " + "to upgrade. For more information see " + "https://blog.torproject.org/v2-deprecation-timeline"); + } + return connection_ap_handle_onion(conn, socks, circ, addresstype); }

1 0

[tor/maint-0.4.6] Add warning when trying to connect to deprecated v2 onions.
by dgoulet＠torproject.org 07 May '21

07 May '21

commit 5e836eb80c31b97f87b152351b6a7a932aeffaed Author: George Kadianakis <desnacked(a)riseup.net> Date: Wed May 5 11:10:28 2021 +0300 Add warning when trying to connect to deprecated v2 onions. --- changes/ticket40373 | 3 +++ src/core/or/connection_edge.c | 15 ++++++++++++++- 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/changes/ticket40373 b/changes/ticket40373 new file mode 100644 index 0000000000..3b2edd0652 --- /dev/null +++ b/changes/ticket40373 @@ -0,0 +1,3 @@ + o Minor features (onion services): + - Add warning message when connecting to deprecated v2 onions. + Closes ticket 40373. \ No newline at end of file diff --git a/src/core/or/connection_edge.c b/src/core/or/connection_edge.c index 8e13161348..a307249967 100644 --- a/src/core/or/connection_edge.c +++ b/src/core/or/connection_edge.c @@ -2242,7 +2242,7 @@ connection_ap_handshake_rewrite_and_attach(entry_connection_t *conn, } /* Now, we handle everything that isn't a .onion address. */ - if (addresstype != ONION_V3_HOSTNAME) { + if (addresstype != ONION_V3_HOSTNAME && addresstype != ONION_V2_HOSTNAME) { /* Not a hidden-service request. It's either a hostname or an IP, * possibly with a .exit that we stripped off. We're going to check * if we're allowed to connect/resolve there, and then launch the @@ -2527,6 +2527,19 @@ connection_ap_handshake_rewrite_and_attach(entry_connection_t *conn, return 0; } else { /* If we get here, it's a request for a .onion address! */ + + /* We don't support v2 onions anymore. Log a warning and bail. */ + if (addresstype == ONION_V2_HOSTNAME) { + log_warn(LD_PROTOCOL, "Tried to connect to a v2 onion address, but this " + "version of Tor no longer supports them. Please encourage the " + "site operator to upgrade. For more information see " + "https://blog.torproject.org/v2-deprecation-timeline."); + control_event_client_status(LOG_WARN, "SOCKS_BAD_HOSTNAME HOSTNAME=%s", + escaped(socks->address)); + connection_mark_unattached_ap(conn, END_STREAM_REASON_TORPROTOCOL); + return -1; + } + tor_assert(addresstype == ONION_V3_HOSTNAME); tor_assert(!automap); return connection_ap_handle_onion(conn, socks, circ);

1 0