February 2021 - tor-commits - lists.torproject.org

[tor/master] Raise the circuit close time quantile to 99.
by asn＠torproject.org 19 Feb '21

19 Feb '21

commit c90b0cb6fb4e5fd2dcc1b711f5ee5ca04576646e Author: Mike Perry <mikeperry-git(a)torproject.org> Date: Tue Nov 3 14:28:43 2020 -0600 Raise the circuit close time quantile to 99. This should allow us to more accurately estimate pareto parameters without relying on "right-censorship" of circuit build timeout values. --- src/core/or/circuitstats.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/or/circuitstats.h b/src/core/or/circuitstats.h index 1cd16b6f2b..e7262e9e82 100644 --- a/src/core/or/circuitstats.h +++ b/src/core/or/circuitstats.h @@ -78,7 +78,7 @@ void circuit_build_times_mark_circ_as_measurement_only(origin_circuit_t *circ); * How long to wait before actually closing circuits that take too long to * build in terms of CDF quantile. */ -#define CBT_DEFAULT_CLOSE_QUANTILE 95 +#define CBT_DEFAULT_CLOSE_QUANTILE 99 #define CBT_MIN_CLOSE_QUANTILE CBT_MIN_QUANTILE_CUTOFF #define CBT_MAX_CLOSE_QUANTILE CBT_MAX_QUANTILE_CUTOFF

1 0

[tor/master] Completely ignore abandoned circs from circ timeout calc
by asn＠torproject.org 19 Feb '21

19 Feb '21

commit 37b21591502d080b5f8ba9c1d0b37bd226b7f183 Author: Mike Perry <mikeperry-git(a)torproject.org> Date: Tue Oct 20 10:50:27 2020 -0500 Completely ignore abandoned circs from circ timeout calc This prevents the timeout curve from getting spread out as much, resulting in more accurate timeout values for quantiles from 60-80. --- src/core/or/circuitstats.c | 64 ++++++++++------------------------------------ src/test/test.c | 10 +------- 2 files changed, 15 insertions(+), 59 deletions(-) diff --git a/src/core/or/circuitstats.c b/src/core/or/circuitstats.c index 2cde21fa1f..d4eb23c966 100644 --- a/src/core/or/circuitstats.c +++ b/src/core/or/circuitstats.c @@ -1009,43 +1009,6 @@ circuit_build_times_shuffle_and_store_array(circuit_build_times_t *cbt, } } -/** - * Filter old synthetic timeouts that were created before the - * new right-censored Pareto calculation was deployed. - * - * Once all clients before 0.2.1.13-alpha are gone, this code - * will be unused. - */ -static int -circuit_build_times_filter_timeouts(circuit_build_times_t *cbt) -{ - int num_filtered=0, i=0; - double timeout_rate = 0; - build_time_t max_timeout = 0; - - timeout_rate = circuit_build_times_timeout_rate(cbt); - max_timeout = (build_time_t)cbt->close_ms; - - for (i = 0; i < CBT_NCIRCUITS_TO_OBSERVE; i++) { - if (cbt->circuit_build_times[i] > max_timeout) { - build_time_t replaced = cbt->circuit_build_times[i]; - num_filtered++; - cbt->circuit_build_times[i] = CBT_BUILD_ABANDONED; - - log_debug(LD_CIRC, "Replaced timeout %d with %d", replaced, - cbt->circuit_build_times[i]); - } - } - - log_info(LD_CIRC, - "We had %d timeouts out of %d build times, " - "and filtered %d above the max of %u", - (int)(cbt->total_build_times*timeout_rate), - cbt->total_build_times, num_filtered, max_timeout); - - return num_filtered; -} - /** * Load histogram from <b>state</b>, shuffling the resulting array * after we do so. Use this result to estimate parameters and @@ -1171,10 +1134,6 @@ circuit_build_times_parse_state(circuit_build_times_t *cbt, circuit_build_times_set_timeout(cbt); - if (!state->CircuitBuildAbandonedCount && cbt->total_build_times) { - circuit_build_times_filter_timeouts(cbt); - } - done: tor_free(loaded_times); return err ? -1 : 0; @@ -1215,14 +1174,15 @@ circuit_build_times_update_alpha(circuit_build_times_t *cbt) if (x[i] < cbt->Xm) { a += tor_mathlog(cbt->Xm); + n++; } else if (x[i] == CBT_BUILD_ABANDONED) { abandoned_count++; } else { a += tor_mathlog(x[i]); if (x[i] > max_time) max_time = x[i]; + n++; } - n++; } /* @@ -1231,11 +1191,11 @@ circuit_build_times_update_alpha(circuit_build_times_t *cbt) * performs this same check, and resets state if it hits it. If we * hit it at runtime, something serious has gone wrong. */ - if (n!=cbt->total_build_times) { + if (n!=cbt->total_build_times-abandoned_count) { log_err(LD_CIRC, "Discrepancy in build times count: %d vs %d", n, cbt->total_build_times); } - tor_assert(n==cbt->total_build_times); + tor_assert_nonfatal(n==cbt->total_build_times-abandoned_count); if (max_time <= 0) { /* This can happen if Xm is actually the *maximum* value in the set. @@ -1248,13 +1208,17 @@ circuit_build_times_update_alpha(circuit_build_times_t *cbt) return 0; } - a += abandoned_count*tor_mathlog(max_time); - + /* This is the "Maximum Likelihood Estimator" for parameter alpha of a Pareto + * Distribution. See: + * https://en.wikipedia.org/wiki/Pareto_distribution#Estimation_of_parameters + * + * The division in the estimator is done with subtraction outside the ln(), + * with the sum occurring in the for loop above. + * + * This done is to avoid the precision issues of logs of small values. + */ a -= n*tor_mathlog(cbt->Xm); - // Estimator comes from Eq #4 in: - // "Bayesian estimation based on trimmed samples from Pareto populations" - // by Arturo J. Fernández. We are right-censored only. - a = (n-abandoned_count)/a; + a = n/a; cbt->alpha = a; diff --git a/src/test/test.c b/src/test/test.c index 58b468775c..cd21a37409 100644 --- a/src/test/test.c +++ b/src/test/test.c @@ -384,7 +384,6 @@ test_circuit_timeout(void *arg) double timeout1, timeout2; or_state_t *state=NULL; int i, runs; - double close_ms; (void)arg; initialize_periodic_events(); @@ -406,18 +405,11 @@ test_circuit_timeout(void *arg) circuit_build_times_initial_alpha(&initial, CBT_DEFAULT_QUANTILE_CUTOFF/100.0, timeout0); - close_ms = MAX(circuit_build_times_calculate_timeout(&initial, - CBT_DEFAULT_CLOSE_QUANTILE/100.0), - CBT_DEFAULT_TIMEOUT_INITIAL_VALUE); do { for (i=0; i < CBT_DEFAULT_MIN_CIRCUITS_TO_OBSERVE; i++) { build_time_t sample = circuit_build_times_generate_sample(&initial,0,1); - if (sample > close_ms) { - circuit_build_times_add_time(&estimate, CBT_BUILD_ABANDONED); - } else { - circuit_build_times_add_time(&estimate, sample); - } + circuit_build_times_add_time(&estimate, sample); } circuit_build_times_update_alpha(&estimate); timeout1 = circuit_build_times_calculate_timeout(&estimate,

1 0

[tor/master] Lower min circ timeout from 1.5s to bin width (10ms)
by asn＠torproject.org 19 Feb '21

19 Feb '21

commit 761dd9f2ab240fb6ce80087e1c2feecd095d71f9 Author: Mike Perry <mikeperry-git(a)torproject.org> Date: Wed Oct 21 18:17:30 2020 -0500 Lower min circ timeout from 1.5s to bin width (10ms) --- src/core/or/circuitstats.c | 2 +- src/core/or/circuitstats.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/core/or/circuitstats.c b/src/core/or/circuitstats.c index d4eb23c966..7cc69b3b4c 100644 --- a/src/core/or/circuitstats.c +++ b/src/core/or/circuitstats.c @@ -1794,7 +1794,7 @@ circuit_build_times_set_timeout(circuit_build_times_t *cbt) return; if (cbt->timeout_ms < circuit_build_times_min_timeout()) { - log_info(LD_CIRC, "Set buildtimeout to low value %fms. Setting to %dms", + log_notice(LD_CIRC, "Set buildtimeout to low value %fms. Setting to %dms", cbt->timeout_ms, circuit_build_times_min_timeout()); cbt->timeout_ms = circuit_build_times_min_timeout(); if (cbt->close_ms < cbt->timeout_ms) { diff --git a/src/core/or/circuitstats.h b/src/core/or/circuitstats.h index 845d7b6722..1cd16b6f2b 100644 --- a/src/core/or/circuitstats.h +++ b/src/core/or/circuitstats.h @@ -119,8 +119,8 @@ double circuit_build_times_quantile_cutoff(void); #define CBT_MAX_TEST_FREQUENCY INT32_MAX /** Lowest allowable value for CircuitBuildTimeout in milliseconds */ -#define CBT_DEFAULT_TIMEOUT_MIN_VALUE (1500) -#define CBT_MIN_TIMEOUT_MIN_VALUE 500 +#define CBT_DEFAULT_TIMEOUT_MIN_VALUE (CBT_BIN_WIDTH) +#define CBT_MIN_TIMEOUT_MIN_VALUE CBT_BIN_WIDTH #define CBT_MAX_TIMEOUT_MIN_VALUE INT32_MAX /** Initial circuit build timeout in milliseconds */

1 0

[tor/master] Lower circuit build time bin width to 10ms.
by asn＠torproject.org 19 Feb '21

19 Feb '21

commit 406400a74d917ec997d26afdf4ae97d9826820fe Author: Mike Perry <mikeperry-git(a)torproject.org> Date: Wed Nov 4 12:30:50 2020 -0600 Lower circuit build time bin width to 10ms. 50ms is not enough resolution. CBT can be as low as 80ms in datacenter clients close to their relays. --- src/core/or/circuitstats.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/or/circuitstats.h b/src/core/or/circuitstats.h index e7262e9e82..15fe23641e 100644 --- a/src/core/or/circuitstats.h +++ b/src/core/or/circuitstats.h @@ -55,7 +55,7 @@ void circuit_build_times_mark_circ_as_measurement_only(origin_circuit_t *circ); #define CBT_NCIRCUITS_TO_OBSERVE 1000 /** Width of the histogram bins in milliseconds */ -#define CBT_BIN_WIDTH ((build_time_t)50) +#define CBT_BIN_WIDTH ((build_time_t)10) /** Number of modes to use in the weighted-avg computation of Xm */ #define CBT_DEFAULT_NUM_XM_MODES 3

1 0

[tor/master] Log circuit timeout in milliseconds
by asn＠torproject.org 19 Feb '21

19 Feb '21

commit 86acd4d940572db16c3a4ccfa6059f1b76a3f5f6 Author: Mike Perry <mikeperry-git(a)torproject.org> Date: Tue Nov 3 15:37:43 2020 -0600 Log circuit timeout in milliseconds --- src/core/or/circuitstats.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/src/core/or/circuitstats.c b/src/core/or/circuitstats.c index 7cc69b3b4c..d92f35fdc2 100644 --- a/src/core/or/circuitstats.c +++ b/src/core/or/circuitstats.c @@ -1626,9 +1626,8 @@ circuit_build_times_network_check_changed(circuit_build_times_t *cbt) log_notice(LD_CIRC, "Your network connection speed appears to have changed. Resetting " - "timeout to %lds after %d timeouts and %d buildtimes.", - tor_lround(cbt->timeout_ms/1000), timeout_count, - total_build_times); + "timeout to %ldms after %d timeouts and %d buildtimes.", + tor_lround(cbt->timeout_ms), timeout_count, total_build_times); return 1; } @@ -1812,9 +1811,9 @@ circuit_build_times_set_timeout(circuit_build_times_t *cbt) log_info(LD_CIRC, "Based on %d circuit times, it looks like we don't need to " "wait so long for circuits to finish. We will now assume a " - "circuit is too slow to use after waiting %ld seconds.", + "circuit is too slow to use after waiting %ld milliseconds.", cbt->total_build_times, - tor_lround(cbt->timeout_ms/1000)); + tor_lround(cbt->timeout_ms)); log_info(LD_CIRC, "Circuit timeout data: %fms, %fms, Xm: %d, a: %f, r: %f", cbt->timeout_ms, cbt->close_ms, cbt->Xm, cbt->alpha, @@ -1823,18 +1822,18 @@ circuit_build_times_set_timeout(circuit_build_times_t *cbt) log_info(LD_CIRC, "Based on %d circuit times, it looks like we need to wait " "longer for circuits to finish. We will now assume a " - "circuit is too slow to use after waiting %ld seconds.", + "circuit is too slow to use after waiting %ld milliseconds.", cbt->total_build_times, - tor_lround(cbt->timeout_ms/1000)); + tor_lround(cbt->timeout_ms)); log_info(LD_CIRC, "Circuit timeout data: %fms, %fms, Xm: %d, a: %f, r: %f", cbt->timeout_ms, cbt->close_ms, cbt->Xm, cbt->alpha, timeout_rate); } else { log_info(LD_CIRC, - "Set circuit build timeout to %lds (%fms, %fms, Xm: %d, a: %f," + "Set circuit build timeout to %ldms (%fms, %fms, Xm: %d, a: %f," " r: %f) based on %d circuit times", - tor_lround(cbt->timeout_ms/1000), + tor_lround(cbt->timeout_ms), cbt->timeout_ms, cbt->close_ms, cbt->Xm, cbt->alpha, timeout_rate, cbt->total_build_times); }

1 0

[tor/master] Bug 40168 changes file
by asn＠torproject.org 19 Feb '21

19 Feb '21

commit 1fadb1bdf12610970af0ae9c7affd300830c3509 Author: Mike Perry <mikeperry-git(a)torproject.org> Date: Tue Nov 3 14:39:10 2020 -0600 Bug 40168 changes file --- changes/bug40168 | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/changes/bug40168 b/changes/bug40168 new file mode 100644 index 0000000000..c52a0352c2 --- /dev/null +++ b/changes/bug40168 @@ -0,0 +1,16 @@ + o Minor bugfixes (circuit build timeout): + - Improve the accuracy of our circuit build timeout calculation for 60%, + 70%, and 80% build rates for various guard choices. We now use a maximum + likelihood estimator for Pareto parameters of the circuit build time + distribution, instead of a "right-censored estimator". This causes + clients to ignore circuits that never finish building in their timeout + calculations. Previously, clients were counting such unfinished circuits + as having the highest possible build time value, when in reality these + circuits most likely just contain relays that are offline. We also now + wait a bit longer to let circuits complete for measurement purposes, + lower the minimum possible effective timeout from 1.5 seconds to 10ms, + and increase the resolution of the circuit build time histogram from + 50ms bin widths to 10ms bin widths. Additionally, we alter our estimate + Xm by taking the maximum of the top 10 most common build time values + of the 10ms histogram, and compute Xm as the average of these. + Fixes bug 40168; bugfix on 0.2.2.14-alpha.

1 0

[tor/master] Bug 34088: Changes file
by asn＠torproject.org 19 Feb '21

19 Feb '21

commit 525195a7153d47295de430002f28b4c27192b5c1 Author: Mike Perry <mikeperry-git(a)torproject.org> Date: Mon Nov 23 21:44:55 2020 -0600 Bug 34088: Changes file --- changes/bug34088 | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/changes/bug34088 b/changes/bug34088 new file mode 100644 index 0000000000..172d890898 --- /dev/null +++ b/changes/bug34088 @@ -0,0 +1,4 @@ + o Minor bugfixes (circuit build timeout): + - Remove max_time calculation and associated warn from circuit build + timeout 'alpha' parameter estimation, as this is no longer needed + by our new estimator from 40168. Fixes bug 34088; bugfix on 0.2.2.9-alpha.

1 0

[tor/master] Fix Xm mode calculation to properly average N=10 modes.
by asn＠torproject.org 19 Feb '21

19 Feb '21

commit ed9d60cb92efbf5bc2a3c22ade6ffee4e1c8116a Author: Mike Perry <mikeperry-git(a)torproject.org> Date: Fri Nov 6 16:30:16 2020 -0600 Fix Xm mode calculation to properly average N=10 modes. This is still fast enough. ~100usec on my laptop with 1000 build times. --- src/core/or/circuitstats.c | 61 +++++++++++++++++++--------------------------- src/core/or/circuitstats.h | 2 +- 2 files changed, 26 insertions(+), 37 deletions(-) diff --git a/src/core/or/circuitstats.c b/src/core/or/circuitstats.c index d92f35fdc2..57d45d2240 100644 --- a/src/core/or/circuitstats.c +++ b/src/core/or/circuitstats.c @@ -853,58 +853,49 @@ circuit_build_times_create_histogram(const circuit_build_times_t *cbt, * Return the Pareto start-of-curve parameter Xm. * * Because we are not a true Pareto curve, we compute this as the - * weighted average of the N most frequent build time bins. N is either - * 1 if we don't have enough circuit build time data collected, or - * determined by the consensus parameter cbtnummodes (default 3). + * weighted average of the 10 most frequent build time bins. This + * heuristic allowed for the actual timeout rate to be closest + * to the chosen quantile cutoff, for quantiles 60-80%, out of + * many variant approaches (see #40157 for analysis). */ static build_time_t circuit_build_times_get_xm(circuit_build_times_t *cbt) { - build_time_t i, nbins; + build_time_t nbins = 0; build_time_t *nth_max_bin; - int32_t bin_counts=0; - build_time_t ret = 0; - uint32_t *histogram = circuit_build_times_create_histogram(cbt, &nbins); - int n=0; + build_time_t xm_total = 0; + build_time_t Xm = 0; + int32_t xm_counts=0; int num_modes = circuit_build_times_default_num_xm_modes(); + uint32_t *histogram = circuit_build_times_create_histogram(cbt, &nbins); tor_assert(nbins > 0); tor_assert(num_modes > 0); - // Only use one mode if < 1000 buildtimes. Not enough data - // for multiple. - if (cbt->total_build_times < CBT_NCIRCUITS_TO_OBSERVE) - num_modes = 1; - nth_max_bin = tor_calloc(num_modes, sizeof(build_time_t)); - /* Determine the N most common build times */ - for (i = 0; i < nbins; i++) { - if (histogram[i] >= histogram[nth_max_bin[0]]) { - nth_max_bin[0] = i; - } - - for (n = 1; n < num_modes; n++) { - if (histogram[i] >= histogram[nth_max_bin[n]] && - (!histogram[nth_max_bin[n-1]] - || histogram[i] < histogram[nth_max_bin[n-1]])) { + /* Determine the N most common build times, by selecting the + * nth largest mode, counting it, and removing it from the histogram. */ + for (int n = 0; n < num_modes; n++) { + /* Get nth mode */ + for (build_time_t i = 0; i < nbins; i++) { + if (histogram[i] > histogram[nth_max_bin[n]]) { nth_max_bin[n] = i; } } - } - for (n = 0; n < num_modes; n++) { - bin_counts += histogram[nth_max_bin[n]]; - ret += CBT_BIN_TO_MS(nth_max_bin[n])*histogram[nth_max_bin[n]]; - log_info(LD_CIRC, "Xm mode #%d: %u %u", n, CBT_BIN_TO_MS(nth_max_bin[n]), - histogram[nth_max_bin[n]]); + /* Update average */ + xm_counts += histogram[nth_max_bin[n]]; + xm_total += CBT_BIN_TO_MS(nth_max_bin[n])*histogram[nth_max_bin[n]]; + + /* Prevent from re-counting this value */ + histogram[nth_max_bin[n]] = 0; } - /* bin_counts can become zero if all of our last CBT_NCIRCUITS_TO_OBSERVE + /* xm_counts can become zero if all of our last CBT_NCIRCUITS_TO_OBSERVE * circuits were abandoned before they completed. This shouldn't happen, * though. We should have reset/re-learned a lower timeout first. */ - if (bin_counts == 0) { - ret = 0; + if (xm_counts == 0) { log_warn(LD_CIRC, "No valid circuit build time data out of %d times, %u modes, " "have_timeout=%d, %lfms", cbt->total_build_times, num_modes, @@ -912,15 +903,13 @@ circuit_build_times_get_xm(circuit_build_times_t *cbt) goto done; } - tor_assert(bin_counts > 0); - - ret /= bin_counts; + Xm = xm_total / xm_counts; done: tor_free(histogram); tor_free(nth_max_bin); - return ret; + return Xm; } /** diff --git a/src/core/or/circuitstats.h b/src/core/or/circuitstats.h index 15fe23641e..864b3b5f43 100644 --- a/src/core/or/circuitstats.h +++ b/src/core/or/circuitstats.h @@ -58,7 +58,7 @@ void circuit_build_times_mark_circ_as_measurement_only(origin_circuit_t *circ); #define CBT_BIN_WIDTH ((build_time_t)10) /** Number of modes to use in the weighted-avg computation of Xm */ -#define CBT_DEFAULT_NUM_XM_MODES 3 +#define CBT_DEFAULT_NUM_XM_MODES 10 #define CBT_MIN_NUM_XM_MODES 1 #define CBT_MAX_NUM_XM_MODES 20

1 0

[tor/master] Bug 34088: Remove max timeout calculation and warning.
by asn＠torproject.org 19 Feb '21

19 Feb '21

commit d16b3d12a140af11f313bee3f5c0fbddf6a4e19e Author: Mike Perry <mikeperry-git(a)torproject.org> Date: Mon Nov 23 21:37:51 2020 -0600 Bug 34088: Remove max timeout calculation and warning. With the maximum likelihood estimator for alpha from #40168, we no longer need max_time to calculate alpha. --- src/core/or/circuitstats.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/src/core/or/circuitstats.c b/src/core/or/circuitstats.c index 57d45d2240..449c055973 100644 --- a/src/core/or/circuitstats.c +++ b/src/core/or/circuitstats.c @@ -1143,7 +1143,6 @@ circuit_build_times_update_alpha(circuit_build_times_t *cbt) build_time_t *x=cbt->circuit_build_times; double a = 0; int n=0,i=0,abandoned_count=0; - build_time_t max_time=0; /* http://en.wikipedia.org/wiki/Pareto_distribution#Parameter_estimation */ /* We sort of cheat here and make our samples slightly more pareto-like @@ -1168,8 +1167,6 @@ circuit_build_times_update_alpha(circuit_build_times_t *cbt) abandoned_count++; } else { a += tor_mathlog(x[i]); - if (x[i] > max_time) - max_time = x[i]; n++; } } @@ -1186,17 +1183,6 @@ circuit_build_times_update_alpha(circuit_build_times_t *cbt) } tor_assert_nonfatal(n==cbt->total_build_times-abandoned_count); - if (max_time <= 0) { - /* This can happen if Xm is actually the *maximum* value in the set. - * It can also happen if we've abandoned every single circuit somehow. - * In either case, tell the caller not to compute a new build timeout. */ - log_warn(LD_BUG, - "Could not determine largest build time (%d). " - "Xm is %dms and we've abandoned %d out of %d circuits.", max_time, - cbt->Xm, abandoned_count, n); - return 0; - } - /* This is the "Maximum Likelihood Estimator" for parameter alpha of a Pareto * Distribution. See: * https://en.wikipedia.org/wiki/Pareto_distribution#Estimation_of_parameters

1 0

[tor/master] Update documentation for the number of modes for Xm estimator.
by asn＠torproject.org 19 Feb '21

19 Feb '21

commit a0690f079d29e13ee6ccaf94e2dca06953a05460 Author: Mike Perry <mikeperry-git(a)torproject.org> Date: Thu Dec 10 17:27:55 2020 -0600 Update documentation for the number of modes for Xm estimator. --- src/core/or/circuitstats.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/core/or/circuitstats.c b/src/core/or/circuitstats.c index 449c055973..066c275b2b 100644 --- a/src/core/or/circuitstats.c +++ b/src/core/or/circuitstats.c @@ -205,10 +205,10 @@ circuit_build_times_max_timeouts(void) * Retrieve and bounds-check the cbtnummodes consensus parameter. * * Effect: This value governs how many modes to use in the weighted - * average calculation of Pareto parameter Xm. A value of 3 introduces - * some bias (2-5% of CDF) under ideal conditions, but allows for better - * performance in the event that a client chooses guard nodes of radically - * different performance characteristics. + * average calculation of Pareto parameter Xm. Analysis of pairs of + * geographically near, far, and mixed guaeds has shown that a value of + * 10 introduces some allows for the actual timeout rate to be within + * 2-7% of the cutoff quantile, for quantiles between 60-80%. */ static int32_t circuit_build_times_default_num_xm_modes(void)

1 0