February 2021 - tor-commits - lists.torproject.org

[tor/release-0.4.5] Merge branch 'maint-0.4.5' into release-0.4.5
by ahf＠torproject.org 05 Feb '21

05 Feb '21

commit 3929dc3010e8201fa0332112d8210ec039991002 Merge: 33a0e016e0 3496804827 Author: Alexander Færøy <ahf(a)torproject.org> Date: Fri Feb 5 17:17:05 2021 +0000 Merge branch 'maint-0.4.5' into release-0.4.5 scripts/maint/practracker/exceptions.txt | 1 + src/test/test_switch_id.c | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-)

1 0

[tor/maint-0.4.5] Merge branch 'maint-0.4.4' into maint-0.4.5
by ahf＠torproject.org 05 Feb '21

05 Feb '21

commit 34968048273faf0cde4d0c69d466b4d8d7275ab7 Merge: 0a40892e8c 62b98716ff Author: Alexander Færøy <ahf(a)torproject.org> Date: Fri Feb 5 17:17:05 2021 +0000 Merge branch 'maint-0.4.4' into maint-0.4.5 scripts/maint/practracker/exceptions.txt | 1 + src/test/test_switch_id.c | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-)

1 0

[tor/maint-0.4.5] Fix Windows build.
by ahf＠torproject.org 05 Feb '21

05 Feb '21

commit af9107aff2a76d390426079b2d267269e7215027 Author: Alexander Færøy <ahf(a)torproject.org> Date: Fri Feb 5 17:12:52 2021 +0000 Fix Windows build. While trying to resolve our CI issues, the Windows build broke with an unused function error: src/test/test_switch_id.c:37:1: error: ‘unprivileged_port_range_start’ defined but not used [-Werror=unused-function] We solve this by moving the `#if !defined(_WIN32)` test above the `unprivileged_port_range_start()` function defintion such that it is included in its body. This is an unreviewed commit. See: tor#40275 --- src/test/test_switch_id.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/test/test_switch_id.c b/src/test/test_switch_id.c index a911269c99..f97af55d17 100644 --- a/src/test/test_switch_id.c +++ b/src/test/test_switch_id.c @@ -31,6 +31,8 @@ static const struct { { NULL, 0 } }; +#if !defined(_WIN32) + /* Returns the first port that we think we can bind to without special * permissions. Usually this function returns 1024. */ static uint16_t @@ -67,8 +69,6 @@ unprivileged_port_range_start(void) return result; } -#if !defined(_WIN32) - #define PORT_TEST_RANGE_START 600 #define PORT_TEST_RANGE_END 1024

1 0

[tor/maint-0.4.4] Fix Windows build.
by ahf＠torproject.org 05 Feb '21

05 Feb '21

commit af9107aff2a76d390426079b2d267269e7215027 Author: Alexander Færøy <ahf(a)torproject.org> Date: Fri Feb 5 17:12:52 2021 +0000 Fix Windows build. While trying to resolve our CI issues, the Windows build broke with an unused function error: src/test/test_switch_id.c:37:1: error: ‘unprivileged_port_range_start’ defined but not used [-Werror=unused-function] We solve this by moving the `#if !defined(_WIN32)` test above the `unprivileged_port_range_start()` function defintion such that it is included in its body. This is an unreviewed commit. See: tor#40275 --- src/test/test_switch_id.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/test/test_switch_id.c b/src/test/test_switch_id.c index a911269c99..f97af55d17 100644 --- a/src/test/test_switch_id.c +++ b/src/test/test_switch_id.c @@ -31,6 +31,8 @@ static const struct { { NULL, 0 } }; +#if !defined(_WIN32) + /* Returns the first port that we think we can bind to without special * permissions. Usually this function returns 1024. */ static uint16_t @@ -67,8 +69,6 @@ unprivileged_port_range_start(void) return result; } -#if !defined(_WIN32) - #define PORT_TEST_RANGE_START 600 #define PORT_TEST_RANGE_END 1024

1 0

[tor/maint-0.4.5] Fix CI build: practracker error in connection_edge.c.
by ahf＠torproject.org 05 Feb '21

05 Feb '21

commit 62b98716ff4823cff6f8e70c262766d1f25f252f Author: Alexander Færøy <ahf(a)torproject.org> Date: Fri Feb 5 17:16:05 2021 +0000 Fix CI build: practracker error in connection_edge.c. We solve this error by allowing the connection_exit_connect() function to be 130 lines long. Unreviewed build fix commit. See: tor#40275. --- scripts/maint/practracker/exceptions.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/maint/practracker/exceptions.txt b/scripts/maint/practracker/exceptions.txt index 35e860d8b1..a84a434cd6 100644 --- a/scripts/maint/practracker/exceptions.txt +++ b/scripts/maint/practracker/exceptions.txt @@ -130,6 +130,7 @@ problem function-size /src/core/or/command.c:command_process_create_cell() 156 problem function-size /src/core/or/command.c:command_process_relay_cell() 132 problem dependency-violation /src/core/or/command.c 9 problem file-size /src/core/or/connection_edge.c 4655 +problem function-size /src/core/or/connection_edge.c:connection_exit_connect() 130 problem include-count /src/core/or/connection_edge.c 65 problem function-size /src/core/or/connection_edge.c:connection_ap_expire_beginning() 117 problem function-size /src/core/or/connection_edge.c:connection_ap_handshake_rewrite() 193

1 0

[tor/maint-0.4.4] Fix CI build: practracker error in connection_edge.c.
by ahf＠torproject.org 05 Feb '21

05 Feb '21

commit 62b98716ff4823cff6f8e70c262766d1f25f252f Author: Alexander Færøy <ahf(a)torproject.org> Date: Fri Feb 5 17:16:05 2021 +0000 Fix CI build: practracker error in connection_edge.c. We solve this error by allowing the connection_exit_connect() function to be 130 lines long. Unreviewed build fix commit. See: tor#40275. --- scripts/maint/practracker/exceptions.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/maint/practracker/exceptions.txt b/scripts/maint/practracker/exceptions.txt index 35e860d8b1..a84a434cd6 100644 --- a/scripts/maint/practracker/exceptions.txt +++ b/scripts/maint/practracker/exceptions.txt @@ -130,6 +130,7 @@ problem function-size /src/core/or/command.c:command_process_create_cell() 156 problem function-size /src/core/or/command.c:command_process_relay_cell() 132 problem dependency-violation /src/core/or/command.c 9 problem file-size /src/core/or/connection_edge.c 4655 +problem function-size /src/core/or/connection_edge.c:connection_exit_connect() 130 problem include-count /src/core/or/connection_edge.c 65 problem function-size /src/core/or/connection_edge.c:connection_ap_expire_beginning() 117 problem function-size /src/core/or/connection_edge.c:connection_ap_handshake_rewrite() 193

1 0

[tor/master] Fix Windows build.
by ahf＠torproject.org 05 Feb '21

05 Feb '21

commit af9107aff2a76d390426079b2d267269e7215027 Author: Alexander Færøy <ahf(a)torproject.org> Date: Fri Feb 5 17:12:52 2021 +0000 Fix Windows build. While trying to resolve our CI issues, the Windows build broke with an unused function error: src/test/test_switch_id.c:37:1: error: ‘unprivileged_port_range_start’ defined but not used [-Werror=unused-function] We solve this by moving the `#if !defined(_WIN32)` test above the `unprivileged_port_range_start()` function defintion such that it is included in its body. This is an unreviewed commit. See: tor#40275 --- src/test/test_switch_id.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/test/test_switch_id.c b/src/test/test_switch_id.c index a911269c99..f97af55d17 100644 --- a/src/test/test_switch_id.c +++ b/src/test/test_switch_id.c @@ -31,6 +31,8 @@ static const struct { { NULL, 0 } }; +#if !defined(_WIN32) + /* Returns the first port that we think we can bind to without special * permissions. Usually this function returns 1024. */ static uint16_t @@ -67,8 +69,6 @@ unprivileged_port_range_start(void) return result; } -#if !defined(_WIN32) - #define PORT_TEST_RANGE_START 600 #define PORT_TEST_RANGE_END 1024

1 0

[tor/master] Merge branch 'maint-0.4.4' into maint-0.4.5
by ahf＠torproject.org 05 Feb '21

05 Feb '21

commit 34968048273faf0cde4d0c69d466b4d8d7275ab7 Merge: 0a40892e8c 62b98716ff Author: Alexander Færøy <ahf(a)torproject.org> Date: Fri Feb 5 17:17:05 2021 +0000 Merge branch 'maint-0.4.4' into maint-0.4.5 scripts/maint/practracker/exceptions.txt | 1 + src/test/test_switch_id.c | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-)

1 0

[tor/master] Fix CI build: practracker error in connection_edge.c.
by ahf＠torproject.org 05 Feb '21

05 Feb '21

commit 62b98716ff4823cff6f8e70c262766d1f25f252f Author: Alexander Færøy <ahf(a)torproject.org> Date: Fri Feb 5 17:16:05 2021 +0000 Fix CI build: practracker error in connection_edge.c. We solve this error by allowing the connection_exit_connect() function to be 130 lines long. Unreviewed build fix commit. See: tor#40275. --- scripts/maint/practracker/exceptions.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/maint/practracker/exceptions.txt b/scripts/maint/practracker/exceptions.txt index 35e860d8b1..a84a434cd6 100644 --- a/scripts/maint/practracker/exceptions.txt +++ b/scripts/maint/practracker/exceptions.txt @@ -130,6 +130,7 @@ problem function-size /src/core/or/command.c:command_process_create_cell() 156 problem function-size /src/core/or/command.c:command_process_relay_cell() 132 problem dependency-violation /src/core/or/command.c 9 problem file-size /src/core/or/connection_edge.c 4655 +problem function-size /src/core/or/connection_edge.c:connection_exit_connect() 130 problem include-count /src/core/or/connection_edge.c 65 problem function-size /src/core/or/connection_edge.c:connection_ap_expire_beginning() 117 problem function-size /src/core/or/connection_edge.c:connection_ap_handshake_rewrite() 193

1 0

[tor-browser/tor-browser-78.7.1esr-10.0-1] Bug 21907: Fix runtime error on CentOS 6
by sysrqb＠torproject.org 05 Feb '21

05 Feb '21

commit 55fc0119a7cb1162bd10ddca16598a6bf8307618 Author: Nicolas Vigier <boklm(a)torproject.org> Date: Mon Apr 10 16:07:23 2017 +0200 Bug 21907: Fix runtime error on CentOS 6 In Mozilla bug 1324780, support for building with glib 2.28 (the version available in CentOS 6) was added. However we are building on Debian Wheezy which has glib 2.32. We fix that by backing out all glib > 2.28 code paths. --- gfx/harfbuzz/src/hb-glib.cc | 53 --------------------------------------------- gfx/harfbuzz/src/hb-glib.h | 5 ----- 2 files changed, 58 deletions(-) diff --git a/gfx/harfbuzz/src/hb-glib.cc b/gfx/harfbuzz/src/hb-glib.cc index 058f65ae69c3..2fd39610203d 100644 --- a/gfx/harfbuzz/src/hb-glib.cc +++ b/gfx/harfbuzz/src/hb-glib.cc @@ -49,7 +49,6 @@ **/ -#if !GLIB_CHECK_VERSION(2,29,14) static const hb_script_t glib_script_to_script[] = { @@ -171,7 +170,6 @@ glib_script_to_script[] = HB_SCRIPT_SORA_SOMPENG, HB_SCRIPT_TAKRI }; -#endif /** * hb_glib_script_to_script: @@ -187,9 +185,6 @@ glib_script_to_script[] = hb_script_t hb_glib_script_to_script (GUnicodeScript script) { -#if GLIB_CHECK_VERSION(2,29,14) - return (hb_script_t) g_unicode_script_to_iso15924 (script); -#else if (likely ((unsigned int) script < ARRAY_LENGTH (glib_script_to_script))) return glib_script_to_script[script]; @@ -197,7 +192,6 @@ hb_glib_script_to_script (GUnicodeScript script) return HB_SCRIPT_INVALID; return HB_SCRIPT_UNKNOWN; -#endif } /** @@ -214,9 +208,6 @@ hb_glib_script_to_script (GUnicodeScript script) GUnicodeScript hb_glib_script_from_script (hb_script_t script) { -#if GLIB_CHECK_VERSION(2,29,14) - return g_unicode_script_from_iso15924 (script); -#else unsigned int count = ARRAY_LENGTH (glib_script_to_script); for (unsigned int i = 0; i < count; i++) if (glib_script_to_script[i] == script) @@ -226,7 +217,6 @@ hb_glib_script_from_script (hb_script_t script) return G_UNICODE_SCRIPT_INVALID_CODE; return G_UNICODE_SCRIPT_UNKNOWN; -#endif } @@ -273,10 +263,6 @@ hb_glib_unicode_compose (hb_unicode_funcs_t *ufuncs HB_UNUSED, hb_codepoint_t *ab, void *user_data HB_UNUSED) { -#if GLIB_CHECK_VERSION(2,29,12) - return g_unichar_compose (a, b, ab); -#endif - /* We don't ifdef-out the fallback code such that compiler always * sees it and makes sure it's compilable. */ @@ -310,10 +296,6 @@ hb_glib_unicode_decompose (hb_unicode_funcs_t *ufuncs HB_UNUSED, hb_codepoint_t *b, void *user_data HB_UNUSED) { -#if GLIB_CHECK_VERSION(2,29,12) - return g_unichar_decompose (ab, a, b); -#endif - /* We don't ifdef-out the fallback code such that compiler always * sees it and makes sure it's compilable. */ @@ -415,39 +397,4 @@ hb_glib_get_unicode_funcs () return static_glib_funcs.get_unconst (); } - - -#if GLIB_CHECK_VERSION(2,31,10) - -static void -_hb_g_bytes_unref (void *data) -{ - g_bytes_unref ((GBytes *) data); -} - -/** - * hb_glib_blob_create: - * @gbytes: the GBytes structure to work upon - * - * Creates an #hb_blob_t blob from the specified - * GBytes data structure. - * - * Return value: (transfer full): the new #hb_blob_t blob object - * - * Since: 0.9.38 - **/ -hb_blob_t * -hb_glib_blob_create (GBytes *gbytes) -{ - gsize size = 0; - gconstpointer data = g_bytes_get_data (gbytes, &size); - return hb_blob_create ((const char *) data, - size, - HB_MEMORY_MODE_READONLY, - g_bytes_ref (gbytes), - _hb_g_bytes_unref); -} -#endif - - #endif diff --git a/gfx/harfbuzz/src/hb-glib.h b/gfx/harfbuzz/src/hb-glib.h index 5f04183ba19f..4adbd7c332cb 100644 --- a/gfx/harfbuzz/src/hb-glib.h +++ b/gfx/harfbuzz/src/hb-glib.h @@ -46,11 +46,6 @@ hb_glib_script_from_script (hb_script_t script); HB_EXTERN hb_unicode_funcs_t * hb_glib_get_unicode_funcs (void); -#if GLIB_CHECK_VERSION(2,31,10) -HB_EXTERN hb_blob_t * -hb_glib_blob_create (GBytes *gbytes); -#endif - HB_END_DECLS #endif /* HB_GLIB_H */

1 0