October 2021 - tor-commits - lists.torproject.org

[tor/maint-0.4.5] hs-v2: Only log once the connection warning to v2
by dgoulet＠torproject.org 06 Oct '21

06 Oct '21

commit f0d1240a07c60b3a01d730d9379bdbe72d41b552 Author: David Goulet <dgoulet(a)torproject.org> Date: Mon Oct 4 14:38:50 2021 -0400 hs-v2: Only log once the connection warning to v2 Closes #40474 Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- changes/ticket40474 | 5 +++++ src/core/or/connection_edge.c | 16 ++++++++++------ 2 files changed, 15 insertions(+), 6 deletions(-) diff --git a/changes/ticket40474 b/changes/ticket40474 new file mode 100644 index 0000000000..d2a7231106 --- /dev/null +++ b/changes/ticket40474 @@ -0,0 +1,5 @@ + o Minor bugfixes (onion service, TROVE-2021-008): + - Only log once any v2 access attempts in order to not pollute the logs + with warnings and avoid recording the times on disk when v2 access was + attempted. Important to note that the onion address was _never_ logged. + That is a Low security issue. Fixes bug 40474; bugfix on 0.4.5.8. diff --git a/src/core/or/connection_edge.c b/src/core/or/connection_edge.c index 7f260ba185..82e8ead5e0 100644 --- a/src/core/or/connection_edge.c +++ b/src/core/or/connection_edge.c @@ -2584,12 +2584,16 @@ connection_ap_handshake_rewrite_and_attach(entry_connection_t *conn, tor_assert(!automap); if (addresstype == ONION_V2_HOSTNAME) { - log_warn(LD_PROTOCOL, - "Warning! You've just connected to a v2 onion address. These " - "addresses are deprecated for security reasons, and are no " - "longer supported in Tor. Please encourage the site operator " - "to upgrade. For more information see " - "https://blog.torproject.org/v2-deprecation-timeline"); + static bool log_once = false; + if (!log_once) { + log_warn(LD_PROTOCOL, + "Warning! You've just connected to a v2 onion address. These " + "addresses are deprecated for security reasons, and are no " + "longer supported in Tor. Please encourage the site operator " + "to upgrade. For more information see " + "https://blog.torproject.org/v2-deprecation-timeline"); + log_once = true; + } } return connection_ap_handle_onion(conn, socks, circ, addresstype);

1 0

[tor/maint-0.4.6] hs-v2: Only log once the connection warning to v2
by dgoulet＠torproject.org 06 Oct '21

06 Oct '21

commit 602dcd8e3774b09242787ba3b0f0e0599530638a Author: David Goulet <dgoulet(a)torproject.org> Date: Mon Oct 4 14:36:05 2021 -0400 hs-v2: Only log once the connection warning to v2 Closes #40474 Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- changes/ticket40474 | 5 +++++ src/core/or/connection_edge.c | 13 +++++++++---- 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/changes/ticket40474 b/changes/ticket40474 new file mode 100644 index 0000000000..d2a7231106 --- /dev/null +++ b/changes/ticket40474 @@ -0,0 +1,5 @@ + o Minor bugfixes (onion service, TROVE-2021-008): + - Only log once any v2 access attempts in order to not pollute the logs + with warnings and avoid recording the times on disk when v2 access was + attempted. Important to note that the onion address was _never_ logged. + That is a Low security issue. Fixes bug 40474; bugfix on 0.4.5.8. diff --git a/src/core/or/connection_edge.c b/src/core/or/connection_edge.c index 6f6f22a0d4..d3979b3a7e 100644 --- a/src/core/or/connection_edge.c +++ b/src/core/or/connection_edge.c @@ -2530,10 +2530,15 @@ connection_ap_handshake_rewrite_and_attach(entry_connection_t *conn, /* We don't support v2 onions anymore. Log a warning and bail. */ if (addresstype == ONION_V2_HOSTNAME) { - log_warn(LD_PROTOCOL, "Tried to connect to a v2 onion address, but this " - "version of Tor no longer supports them. Please encourage the " - "site operator to upgrade. For more information see " - "https://blog.torproject.org/v2-deprecation-timeline."); + static bool log_once = false; + if (!log_once) { + log_warn(LD_PROTOCOL, "Tried to connect to a v2 onion address, but " + "this version of Tor no longer supports them. Please " + "encourage the site operator to upgrade. For more " + "information see " + "https://blog.torproject.org/v2-deprecation-timeline."); + log_once = true; + } control_event_client_status(LOG_WARN, "SOCKS_BAD_HOSTNAME HOSTNAME=%s", escaped(socks->address)); /* Send back the 0xF6 extended code indicating a bad hostname. This is

1 0

[tor/maint-0.4.6] hs-v2: Only log once the connection warning to v2
by dgoulet＠torproject.org 06 Oct '21

06 Oct '21

commit f0d1240a07c60b3a01d730d9379bdbe72d41b552 Author: David Goulet <dgoulet(a)torproject.org> Date: Mon Oct 4 14:38:50 2021 -0400 hs-v2: Only log once the connection warning to v2 Closes #40474 Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- changes/ticket40474 | 5 +++++ src/core/or/connection_edge.c | 16 ++++++++++------ 2 files changed, 15 insertions(+), 6 deletions(-) diff --git a/changes/ticket40474 b/changes/ticket40474 new file mode 100644 index 0000000000..d2a7231106 --- /dev/null +++ b/changes/ticket40474 @@ -0,0 +1,5 @@ + o Minor bugfixes (onion service, TROVE-2021-008): + - Only log once any v2 access attempts in order to not pollute the logs + with warnings and avoid recording the times on disk when v2 access was + attempted. Important to note that the onion address was _never_ logged. + That is a Low security issue. Fixes bug 40474; bugfix on 0.4.5.8. diff --git a/src/core/or/connection_edge.c b/src/core/or/connection_edge.c index 7f260ba185..82e8ead5e0 100644 --- a/src/core/or/connection_edge.c +++ b/src/core/or/connection_edge.c @@ -2584,12 +2584,16 @@ connection_ap_handshake_rewrite_and_attach(entry_connection_t *conn, tor_assert(!automap); if (addresstype == ONION_V2_HOSTNAME) { - log_warn(LD_PROTOCOL, - "Warning! You've just connected to a v2 onion address. These " - "addresses are deprecated for security reasons, and are no " - "longer supported in Tor. Please encourage the site operator " - "to upgrade. For more information see " - "https://blog.torproject.org/v2-deprecation-timeline"); + static bool log_once = false; + if (!log_once) { + log_warn(LD_PROTOCOL, + "Warning! You've just connected to a v2 onion address. These " + "addresses are deprecated for security reasons, and are no " + "longer supported in Tor. Please encourage the site operator " + "to upgrade. For more information see " + "https://blog.torproject.org/v2-deprecation-timeline"); + log_once = true; + } } return connection_ap_handle_onion(conn, socks, circ, addresstype);

1 0

[tor/maint-0.4.6] Merge branch 'maint-0.4.5' into maint-0.4.6
by dgoulet＠torproject.org 06 Oct '21

06 Oct '21

commit 82b7939d197e64cd21e5246060499018dcb95f2c Merge: 602dcd8e37 f0d1240a07 Author: David Goulet <dgoulet(a)torproject.org> Date: Wed Oct 6 13:25:02 2021 -0400 Merge branch 'maint-0.4.5' into maint-0.4.6

1 0

[tor/release-0.4.5] hs-v2: Only log once the connection warning to v2
by dgoulet＠torproject.org 06 Oct '21

06 Oct '21

commit f0d1240a07c60b3a01d730d9379bdbe72d41b552 Author: David Goulet <dgoulet(a)torproject.org> Date: Mon Oct 4 14:38:50 2021 -0400 hs-v2: Only log once the connection warning to v2 Closes #40474 Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- changes/ticket40474 | 5 +++++ src/core/or/connection_edge.c | 16 ++++++++++------ 2 files changed, 15 insertions(+), 6 deletions(-) diff --git a/changes/ticket40474 b/changes/ticket40474 new file mode 100644 index 0000000000..d2a7231106 --- /dev/null +++ b/changes/ticket40474 @@ -0,0 +1,5 @@ + o Minor bugfixes (onion service, TROVE-2021-008): + - Only log once any v2 access attempts in order to not pollute the logs + with warnings and avoid recording the times on disk when v2 access was + attempted. Important to note that the onion address was _never_ logged. + That is a Low security issue. Fixes bug 40474; bugfix on 0.4.5.8. diff --git a/src/core/or/connection_edge.c b/src/core/or/connection_edge.c index 7f260ba185..82e8ead5e0 100644 --- a/src/core/or/connection_edge.c +++ b/src/core/or/connection_edge.c @@ -2584,12 +2584,16 @@ connection_ap_handshake_rewrite_and_attach(entry_connection_t *conn, tor_assert(!automap); if (addresstype == ONION_V2_HOSTNAME) { - log_warn(LD_PROTOCOL, - "Warning! You've just connected to a v2 onion address. These " - "addresses are deprecated for security reasons, and are no " - "longer supported in Tor. Please encourage the site operator " - "to upgrade. For more information see " - "https://blog.torproject.org/v2-deprecation-timeline"); + static bool log_once = false; + if (!log_once) { + log_warn(LD_PROTOCOL, + "Warning! You've just connected to a v2 onion address. These " + "addresses are deprecated for security reasons, and are no " + "longer supported in Tor. Please encourage the site operator " + "to upgrade. For more information see " + "https://blog.torproject.org/v2-deprecation-timeline"); + log_once = true; + } } return connection_ap_handle_onion(conn, socks, circ, addresstype);

1 0

[tor/release-0.4.6] hs-v2: Only log once the connection warning to v2
by dgoulet＠torproject.org 06 Oct '21

06 Oct '21

commit f0d1240a07c60b3a01d730d9379bdbe72d41b552 Author: David Goulet <dgoulet(a)torproject.org> Date: Mon Oct 4 14:38:50 2021 -0400 hs-v2: Only log once the connection warning to v2 Closes #40474 Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- changes/ticket40474 | 5 +++++ src/core/or/connection_edge.c | 16 ++++++++++------ 2 files changed, 15 insertions(+), 6 deletions(-) diff --git a/changes/ticket40474 b/changes/ticket40474 new file mode 100644 index 0000000000..d2a7231106 --- /dev/null +++ b/changes/ticket40474 @@ -0,0 +1,5 @@ + o Minor bugfixes (onion service, TROVE-2021-008): + - Only log once any v2 access attempts in order to not pollute the logs + with warnings and avoid recording the times on disk when v2 access was + attempted. Important to note that the onion address was _never_ logged. + That is a Low security issue. Fixes bug 40474; bugfix on 0.4.5.8. diff --git a/src/core/or/connection_edge.c b/src/core/or/connection_edge.c index 7f260ba185..82e8ead5e0 100644 --- a/src/core/or/connection_edge.c +++ b/src/core/or/connection_edge.c @@ -2584,12 +2584,16 @@ connection_ap_handshake_rewrite_and_attach(entry_connection_t *conn, tor_assert(!automap); if (addresstype == ONION_V2_HOSTNAME) { - log_warn(LD_PROTOCOL, - "Warning! You've just connected to a v2 onion address. These " - "addresses are deprecated for security reasons, and are no " - "longer supported in Tor. Please encourage the site operator " - "to upgrade. For more information see " - "https://blog.torproject.org/v2-deprecation-timeline"); + static bool log_once = false; + if (!log_once) { + log_warn(LD_PROTOCOL, + "Warning! You've just connected to a v2 onion address. These " + "addresses are deprecated for security reasons, and are no " + "longer supported in Tor. Please encourage the site operator " + "to upgrade. For more information see " + "https://blog.torproject.org/v2-deprecation-timeline"); + log_once = true; + } } return connection_ap_handle_onion(conn, socks, circ, addresstype);

1 0

[tor/release-0.4.5] Merge branch 'maint-0.4.5' into release-0.4.5
by dgoulet＠torproject.org 06 Oct '21

06 Oct '21

commit ac623fa2ac69d00d5e19c1440242bdaf7914c8ca Merge: 0a02fd7445 f0d1240a07 Author: David Goulet <dgoulet(a)torproject.org> Date: Wed Oct 6 13:24:22 2021 -0400 Merge branch 'maint-0.4.5' into release-0.4.5 changes/ticket40474 | 5 +++++ src/core/or/connection_edge.c | 16 ++++++++++------ 2 files changed, 15 insertions(+), 6 deletions(-)

1 0

[tor/release-0.4.6] Merge branch 'maint-0.4.6' into release-0.4.6
by dgoulet＠torproject.org 06 Oct '21

06 Oct '21

commit fd640bbeae9cd36b3b202f3d64474e68c9fd38cf Merge: fb7c832597 82b7939d19 Author: David Goulet <dgoulet(a)torproject.org> Date: Wed Oct 6 13:25:08 2021 -0400 Merge branch 'maint-0.4.6' into release-0.4.6 changes/ticket40474 | 5 +++++ src/core/or/connection_edge.c | 13 +++++++++---- 2 files changed, 14 insertions(+), 4 deletions(-)

1 0

[tor/release-0.4.6] hs-v2: Only log once the connection warning to v2
by dgoulet＠torproject.org 06 Oct '21

06 Oct '21

commit 602dcd8e3774b09242787ba3b0f0e0599530638a Author: David Goulet <dgoulet(a)torproject.org> Date: Mon Oct 4 14:36:05 2021 -0400 hs-v2: Only log once the connection warning to v2 Closes #40474 Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- changes/ticket40474 | 5 +++++ src/core/or/connection_edge.c | 13 +++++++++---- 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/changes/ticket40474 b/changes/ticket40474 new file mode 100644 index 0000000000..d2a7231106 --- /dev/null +++ b/changes/ticket40474 @@ -0,0 +1,5 @@ + o Minor bugfixes (onion service, TROVE-2021-008): + - Only log once any v2 access attempts in order to not pollute the logs + with warnings and avoid recording the times on disk when v2 access was + attempted. Important to note that the onion address was _never_ logged. + That is a Low security issue. Fixes bug 40474; bugfix on 0.4.5.8. diff --git a/src/core/or/connection_edge.c b/src/core/or/connection_edge.c index 6f6f22a0d4..d3979b3a7e 100644 --- a/src/core/or/connection_edge.c +++ b/src/core/or/connection_edge.c @@ -2530,10 +2530,15 @@ connection_ap_handshake_rewrite_and_attach(entry_connection_t *conn, /* We don't support v2 onions anymore. Log a warning and bail. */ if (addresstype == ONION_V2_HOSTNAME) { - log_warn(LD_PROTOCOL, "Tried to connect to a v2 onion address, but this " - "version of Tor no longer supports them. Please encourage the " - "site operator to upgrade. For more information see " - "https://blog.torproject.org/v2-deprecation-timeline."); + static bool log_once = false; + if (!log_once) { + log_warn(LD_PROTOCOL, "Tried to connect to a v2 onion address, but " + "this version of Tor no longer supports them. Please " + "encourage the site operator to upgrade. For more " + "information see " + "https://blog.torproject.org/v2-deprecation-timeline."); + log_once = true; + } control_event_client_status(LOG_WARN, "SOCKS_BAD_HOSTNAME HOSTNAME=%s", escaped(socks->address)); /* Send back the 0xF6 extended code indicating a bad hostname. This is

1 0

[tor/release-0.4.6] Merge branch 'maint-0.4.5' into maint-0.4.6
by dgoulet＠torproject.org 06 Oct '21

06 Oct '21

commit 82b7939d197e64cd21e5246060499018dcb95f2c Merge: 602dcd8e37 f0d1240a07 Author: David Goulet <dgoulet(a)torproject.org> Date: Wed Oct 6 13:25:02 2021 -0400 Merge branch 'maint-0.4.5' into maint-0.4.6

1 0