commit 39830b6408f8a720ce71ccb6b853663c6e6047e9
Author: Nick Mathewson <nickm(a)torproject.org>
Date: Tue Jun 30 11:54:13 2020 -0400
Downgrade "Bug: No entry found in extrainfo map" message.
This is not actually a bug! It can happen for a bunch of reasons,
which all boil down to "trying to add an extrainfo for which we no
longer have the corresponding routerinfo".
Fixes #16016; bugfix on 0.2.6.3-alpha.
---
changes/bug16016 | 4 ++++
src/feature/nodelist/routerlist.c | 6 +++++-
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/changes/bug16016 b/changes/bug16016
new file mode 100644
index 000000000..313ef672e
--- /dev/null
+++ b/changes/bug16016
@@ -0,0 +1,4 @@
+ o Minor bugfixes (logging):
+ - Downgrade a noisy log message that could occur naturally when
+ receiving an extrainfo document that we no longer want.
+ Fixes bug 16016; bugfix on 0.2.6.3-alpha.
diff --git a/src/feature/nodelist/routerlist.c b/src/feature/nodelist/routerlist.c
index e48675aad..c7fa86892 100644
--- a/src/feature/nodelist/routerlist.c
+++ b/src/feature/nodelist/routerlist.c
@@ -1087,7 +1087,11 @@ extrainfo_insert,(routerlist_t *rl, extrainfo_t *ei, int warn_if_incompatible))
* This just won't work. */;
static ratelim_t no_sd_ratelim = RATELIM_INIT(1800);
r = ROUTER_BAD_EI;
- log_fn_ratelim(&no_sd_ratelim, severity, LD_BUG,
+ /* This is a DEBUG because it can happen naturally, if we tried
+ * to add an extrainfo for which we no longer have the
+ * corresponding routerinfo.
+ */
+ log_fn_ratelim(&no_sd_ratelim, LOG_DEBUG, LD_DIR,
"No entry found in extrainfo map.");
goto done;
}