tor-commits May 2020

tor-commits@lists.torproject.org

18 participants
1587 discussions

[tor/release-0.4.3] 0.4.3.5 ReleaseNotes: remove bugfixes on 0.4.3.
by nickm＠torproject.org 14 May '20

14 May '20

commit c56f01fd0e459076b294e86c940e8b0d29bb7178 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu May 14 11:47:11 2020 -0400 0.4.3.5 ReleaseNotes: remove bugfixes on 0.4.3. (These are not "changes since 0.4.2") --- ReleaseNotes | 59 ----------------------------------------------------------- 1 file changed, 59 deletions(-) diff --git a/ReleaseNotes b/ReleaseNotes index 0592d9674..9859f1e58 100644 --- a/ReleaseNotes +++ b/ReleaseNotes @@ -92,11 +92,6 @@ Changes in version 0.4.3.5 - 2020-05-15 and accept strings as well as binary addresses. Fixes bug 32315; bugfix on 0.3.5.1-alpha. - o Major bugfixes (onion service client, authorization): - - On a NEWNYM signal, purge entries from the ephemeral client - authorization cache. The permanent ones are kept. Fixes bug 33139; - bugfix on 0.4.3.1-alpha. - o Major bugfixes (onion service): - Report HS circuit failure back into the HS subsystem so we take appropriate action with regards to the client introduction point @@ -280,47 +275,14 @@ Changes in version 0.4.3.5 - 2020-05-15 relay to get rejected in the future. Fixes bug 33361; bugfix on 0.1.1.10-alpha. - o Minor bugfixes (--disable-module-relay): - - Fix an assertion failure when Tor is built without the relay - module, and then invoked with the "User" option. Fixes bug 33668; - bugfix on 0.4.3.1-alpha. - - o Minor bugfixes (--disable-module-relay,--disable-module-dirauth): - - Set some output arguments in the relay and dirauth module stubs, - to guard against future stub argument handling bugs like 33668. - Fixes bug 33674; bugfix on 0.4.3.1-alpha. - o Minor bugfixes (bridges): - Lowercase the configured value of BridgeDistribution before adding it to the descriptor. Fixes bug 32753; bugfix on 0.3.2.3-alpha. o Minor bugfixes (build system): - - Correctly output the enabled module in the configure summary. - Before that, the list shown was just plain wrong. Fixes bug 33646; - bugfix on 0.4.3.2-alpha. - - Revise configure options that were either missing or incorrect in - the configure summary. Fixes bug 32230; bugfix on 0.4.3.1-alpha. - Fix "make autostyle" for out-of-tree builds. Fixes bug 32370; bugfix on 0.4.1.2-alpha. - o Minor bugfixes (client, IPv6): - - Stop forcing all non-SocksPorts to prefer IPv6 exit connections. - Instead, prefer IPv6 connections by default, but allow users to - change their configs using the "NoPreferIPv6" port flag. Fixes bug - 33608; bugfix on 0.4.3.1-alpha. - - Revert PreferIPv6 set by default on the SocksPort because it broke - the torsocks use case. Tor doesn't have a way for an application - to request the hostname to be resolved for a specific IP version, - but torsocks requires that. Up until now, IPv4 was used by default - so torsocks is expecting that, and can't handle a possible IPv6 - being returned. Fixes bug 33804; bugfix on 0.4.3.1-alpha. - - o Minor bugfixes (coding best practices checks): - - Allow the "practracker" script to read unicode files when using - Python 2. We made the script use unicode literals in 0.4.3.1-alpha, - but didn't change the codec for opening files. Fixes bug 33374; - bugfix on 0.4.3.1-alpha. - o Minor bugfixes (compiler compatibility): - Avoid compiler warnings from Clang 10 related to the use of GCC- style "/* falls through */" comments. Both Clang and GCC allow @@ -355,10 +317,6 @@ Changes in version 0.4.3.5 - 2020-05-15 on 0.3.2.2-alpha. o Minor bugfixes (controller protocol): - - Fix a memory leak introduced by refactoring of control reply - formatting code. Fixes bug 33039; bugfix on 0.4.3.1-alpha. - - Fix a memory leak in GETINFO responses. Fixes bug 33103; bugfix - on 0.4.3.1-alpha. - When receiving "ACTIVE" or "DORMANT" signals on the control port, report them as SIGNAL events. Previously we would log a bug warning. Fixes bug 33104; bugfix on 0.4.0.1-alpha. @@ -414,10 +372,6 @@ Changes in version 0.4.3.5 - 2020-05-15 o Minor bugfixes (logging): - Stop truncating IPv6 addresses and ports in channel and connection logs. Fixes bug 33918; bugfix on 0.2.4.4-alpha. - - Fix a logic error in a log message about whether an address was - invalid. Previously, the code would never report that onion - addresses were onion addresses. Fixes bug 34131; bugfix - on 0.4.3.1-alpha. - Flush stderr, stdout, and file logs during shutdown, if supported by the OS. This change helps make sure that any final logs are recorded. Fixes bug 33087; bugfix on 0.4.1.6. @@ -449,12 +403,6 @@ Changes in version 0.4.3.5 - 2020-05-15 timeout values. Fixes bug 25568; bugfix on 0.2.7.3-rc. Patch by Neel Chauhan. - o Minor bugfixes (onion service v3, client authorization): - - When removing client authorization credentials using the control - port, also remove the associated descriptor, so the onion service - can no longer be contacted. Fixes bug 33148; bugfix - on 0.4.3.1-alpha. - o Minor bugfixes (onion service v3, client): - Remove a BUG() warning that would cause a stack trace if an onion service descriptor was freed while we were waiting for a @@ -466,9 +414,6 @@ Changes in version 0.4.3.5 - 2020-05-15 decoding onion service descriptors as a relay. Also add some diagnostics to debug any future bugs in that area. Fixes bug 31669; bugfix on 0.3.0.1-alpha. - - Block a client-side assertion by disallowing the registration of - an x25519 client auth key that's all zeroes. Fixes bug 33545; - bugfix on 0.4.3.1-alpha. Based on patch from "cypherpunks". - Fix an assertion failure that could result from a corrupted ADD_ONION control port command. Found by Saibato. Fixes bug 33137; bugfix on 0.3.3.1-alpha. This issue is also tracked @@ -534,10 +479,6 @@ Changes in version 0.4.3.5 - 2020-05-15 - Initialize the publish/subscribe system when running as a windows service. Fixes bug 32778; bugfix on 0.4.1.1-alpha. - o Code simplification and refactoring: - - Disable our coding standards best practices tracker in our git - hooks. (0.4.3 branches only.) Closes ticket 33678. - o Deprecated features: - Deprecate the ClientAutoIPv6ORPort option. This option was not true "Happy Eyeballs", and often failed on connections that

1 0

[tor/release-0.4.3] 0.4.3.5 release notes: edit section headings
by nickm＠torproject.org 14 May '20

14 May '20

commit fd4f4585ae9726e12da86ff0753d965b5693bc37 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu May 14 11:52:53 2020 -0400 0.4.3.5 release notes: edit section headings --- ReleaseNotes | 54 +++++++++++++++++------------------------------------- 1 file changed, 17 insertions(+), 37 deletions(-) diff --git a/ReleaseNotes b/ReleaseNotes index 9859f1e58..99e1c53fa 100644 --- a/ReleaseNotes +++ b/ReleaseNotes @@ -26,13 +26,11 @@ Changes in version 0.4.3.5 - 2020-05-15 future. Previously, only RSA keys could be banned in approved- routers. Resolves ticket 22029. Patch by Neel Chauhan. - o Major features (onion service, controller): + o Major features (onion services): - New control port commands to manage client-side onion service authorization credentials. The ONION_CLIENT_AUTH_ADD command adds a credential, ONION_CLIENT_AUTH_REMOVE deletes a credential, and ONION_CLIENT_AUTH_VIEW lists the credentials. Closes ticket 30381. - - o Major features (onion service, SOCKS5): - Introduce a new SocksPort flag, ExtendedErrors, to support more detailed error codes in information for applications that support them. Closes ticket 30382; implements proposal 304. @@ -99,10 +97,6 @@ Changes in version 0.4.3.5 - 2020-05-15 now clients notice failing introduction circuits properly. Fixes bug 32020; bugfix on 0.3.2.1-alpha. - o Minor feature (configure, build system): - - Output a list of enabled/disabled features at the end of the - configure process in a pleasing way. Closes ticket 31373. - o Minor feature (heartbeat, onion service): - Add the DoS INTRODUCE2 defenses counter to the heartbeat DoS message. Closes ticket 31371. @@ -133,6 +127,10 @@ Changes in version 0.4.3.5 - 2020-05-15 special type, which prevented us from generating good warnings. Implements ticket 32404. + o Minor features (configure, build system): + - Output a list of enabled/disabled features at the end of the + configure process in a pleasing way. Closes ticket 31373. + o Minor features (continuous integration): - Run Doxygen Makefile target on Travis, so we can learn about regressions in our internal documentation. Closes ticket 32455. @@ -155,12 +153,10 @@ Changes in version 0.4.3.5 - 2020-05-15 function returns an error. Patch by Tobias Stoeckmann. Fixes ticket 31147. - o Minor features (developer tooling): + o Minor features (developer tools): - Remove the 0.2.9.x series branches from git scripts (git-merge- forward.sh, git-pull-all.sh, git-push-all.sh, git-setup-dirs.sh). Closes ticket 32772. - - o Minor features (developer tools): - Add a check_cocci_parse.sh script that checks that new code is parseable by Coccinelle. Add an exceptions file for unparseable files, and run the script from travis CI. Closes ticket 31919. @@ -236,8 +232,6 @@ Changes in version 0.4.3.5 - 2020-05-15 ORPort, DirPort, DirCache, BridgeRelay, ExtORPort, or ServerTransport* options, rather than ignoring the values of these options. Closes part of ticket 32213. - - o Minor features (relay): - When the relay module is disabled, change the default config so that DirCache is 0, and ClientOnly is 1. Closes ticket 32410. @@ -258,8 +252,6 @@ Changes in version 0.4.3.5 - 2020-05-15 - The test_parseconf.sh script now supports result variants for any combination of the optional libraries lzma, nss, and zstd. Closes ticket 32397. - - o Minor features (tests, Android): - When running the unit tests on Android, create temporary files in a subdirectory of /data/local/tmp. Closes ticket 32172. Based on a patch from Hans-Christoph Steiner. @@ -295,8 +287,6 @@ Changes in version 0.4.3.5 - 2020-05-15 - Make control_event_conf_changed() take in a config_line_t instead of a smartlist of alternating key/value entries. Fixes bug 31531; bugfix on 0.2.3.3-alpha. Patch by Neel Chauhan. - - o Minor bugfixes (configuration): - Check for multiplication overflow when parsing memory units inside configuration. Fixes bug 30920; bugfix on 0.0.9rc1. - When dumping the configuration, stop adding a trailing space after @@ -356,12 +346,6 @@ Changes in version 0.4.3.5 - 2020-05-15 - Forward all unrecognised arguments in git-push-all.sh to git push. Closes ticket 32216. - o Minor bugfixes (hidden service v3): - - Do not rely on a "circuit established" flag for intro circuits but - instead always query the HS circuit map. This is to avoid sync - issue with that flag and the map. Fixes bug 32094; bugfix - on 0.3.2.1-alpha. - o Minor bugfixes (key portability): - When reading PEM-encoded key data, tolerate CRLF line-endings even if we are not running on Windows. Previously, non-Windows hosts @@ -393,7 +377,7 @@ Changes in version 0.4.3.5 - 2020-05-15 failure about mismatched magic numbers in configuration objects. Fixes bug 32771; bugfix on 0.4.2.1-alpha. - o Minor bugfixes (onion service v2): + o Minor bugfixes (onion services v2): - Move a series of v2 onion service warnings to protocol-warning level because they can all be triggered remotely by a malformed request. Fixes bug 32706; bugfix on 0.1.1.14-alpha. @@ -403,13 +387,11 @@ Changes in version 0.4.3.5 - 2020-05-15 timeout values. Fixes bug 25568; bugfix on 0.2.7.3-rc. Patch by Neel Chauhan. - o Minor bugfixes (onion service v3, client): + o Minor bugfixes (onion services v3): - Remove a BUG() warning that would cause a stack trace if an onion service descriptor was freed while we were waiting for a rendezvous circuit to complete. Fixes bug 28992; bugfix on 0.3.2.1-alpha. - - o Minor bugfixes (onion services v3): - Relax severity of a log message that can appear naturally when decoding onion service descriptors as a relay. Also add some diagnostics to debug any future bugs in that area. Fixes bug @@ -418,8 +400,6 @@ Changes in version 0.4.3.5 - 2020-05-15 ADD_ONION control port command. Found by Saibato. Fixes bug 33137; bugfix on 0.3.3.1-alpha. This issue is also tracked as TROVE-2020-003. - - o Minor bugfixes (onion services v3, client): - Properly handle the client rendezvous circuit timeout. Previously Tor would sometimes timeout a rendezvous circuit awaiting the introduction ACK, and find itself unable to re-establish all @@ -427,6 +407,12 @@ Changes in version 0.4.3.5 - 2020-05-15 bug 32021; bugfix on 0.3.2.1-alpha. o Minor bugfixes (onion services): + - Do not rely on a "circuit established" flag for intro circuits but + instead always query the HS circuit map. This is to avoid sync + issue with that flag and the map. Fixes bug 32094; bugfix + on 0.3.2.1-alpha. + + o Minor bugfixes (onion services, all): - In cancel_descriptor_fetches(), use connection_list_by_type_purpose() instead of connection_list_by_type_state(). Fixes bug 32639; bugfix on @@ -446,13 +432,11 @@ Changes in version 0.4.3.5 - 2020-05-15 - Fix update_versions.py for out-of-tree builds. Fixes bug 32371; bugfix on 0.4.0.1-alpha. - o Minor bugfixes (test): + o Minor bugfixes (testing): - Use the same code to find the tor binary in all of our test scripts. This change makes sure we are always using the coverage binary when coverage is enabled. Fixes bug 32368; bugfix on 0.2.7.3-rc. - - o Minor bugfixes (testing): - Stop ignoring "tor --dump-config" errors in test_parseconf.sh. Fixes bug 32468; bugfix on 0.4.2.1-alpha. - When TOR_DISABLE_PRACTRACKER is set, do not apply it to the @@ -461,8 +445,6 @@ Changes in version 0.4.3.5 - 2020-05-15 - When TOR_DISABLE_PRACTRACKER is set, log a notice to stderr when skipping practracker checks. Fixes bug 32705; bugfix on 0.4.2.1-alpha. - - o Minor bugfixes (tests): - Our option-validation tests no longer depend on specially configured non-default, non-passing sets of options. Previously, the tests had been written to assume that options would _not_ be @@ -632,7 +614,7 @@ Changes in version 0.4.3.5 - 2020-05-15 SEE ALSO, and BUGS sections. Closes ticket 32176. Based on work by Swati Thacker as part of Google Season of Docs. - o Testing (CI): + o Testing (Appveyor CI): - In our Appveyor Windows CI, copy required DLLs to test and app directories, before running tor's tests. This ensures that tor.exe and test*.exe use the correct version of each DLL. This fix is not @@ -646,10 +628,8 @@ Changes in version 0.4.3.5 - 2020-05-15 - Add unit tests for circuitmux and EWMA subsystems. Closes ticket 32196. - o Testing (continuous integration): - - Use zstd in our Travis Linux builds. Closes ticket 32242. - o Testing (Travis CI): + - Use zstd in our Travis Linux builds. Closes ticket 32242. - Remove a redundant distcheck job. Closes ticket 33194. - Sort the Travis jobs in order of speed: putting the slowest jobs first takes full advantage of Travis job concurrency. Closes

1 0

[tor/master] bump to 0.4.3.5
by nickm＠torproject.org 14 May '20

14 May '20

commit 75fc33f3372b1098d46452b320ef5548d02053a9 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu May 14 10:37:42 2020 -0400 bump to 0.4.3.5 --- configure.ac | 4 ++-- contrib/win32build/tor-mingw.nsi.in | 2 +- src/win32/orconfig.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/configure.ac b/configure.ac index bad4f047d..1ac4db84d 100644 --- a/configure.ac +++ b/configure.ac @@ -4,7 +4,7 @@ dnl Copyright (c) 2007-2019, The Tor Project, Inc. dnl See LICENSE for licensing information AC_PREREQ([2.63]) -AC_INIT([tor],[0.4.3.4-rc-dev]) +AC_INIT([tor],[0.4.3.5]) AC_CONFIG_SRCDIR([src/app/main/tor_main.c]) AC_CONFIG_MACRO_DIR([m4]) @@ -16,7 +16,7 @@ configure_flags="$*" # version number changes. Tor uses it to make sure that it # only shuts down for missing "required protocols" when those protocols # are listed as required by a consensus after this date. -AC_DEFINE(APPROX_RELEASE_DATE, ["2020-04-13"], # for 0.4.3.4-rc-dev +AC_DEFINE(APPROX_RELEASE_DATE, ["2020-05-14"], # for 0.4.3.5 [Approximate date when this software was released. (Updated when the version changes.)]) # "foreign" means we don't follow GNU package layout standards diff --git a/contrib/win32build/tor-mingw.nsi.in b/contrib/win32build/tor-mingw.nsi.in index 28a5c5d93..53dbbe90f 100644 --- a/contrib/win32build/tor-mingw.nsi.in +++ b/contrib/win32build/tor-mingw.nsi.in @@ -8,7 +8,7 @@ !include "LogicLib.nsh" !include "FileFunc.nsh" !insertmacro GetParameters -!define VERSION "0.4.3.4-rc-dev" +!define VERSION "0.4.3.5" !define INSTALLER "tor-${VERSION}-win32.exe" !define WEBSITE "https://www.torproject.org/" !define LICENSE "LICENSE" diff --git a/src/win32/orconfig.h b/src/win32/orconfig.h index c797d4399..ee5c48b44 100644 --- a/src/win32/orconfig.h +++ b/src/win32/orconfig.h @@ -217,7 +217,7 @@ #define USING_TWOS_COMPLEMENT /* Version number of package */ -#define VERSION "0.4.3.4-rc-dev" +#define VERSION "0.4.3.5" #define HAVE_STRUCT_SOCKADDR_IN6 #define HAVE_STRUCT_IN6_ADDR

1 0

[tor/maint-0.4.3] bump to 0.4.3.5
by nickm＠torproject.org 14 May '20

14 May '20

1 0

[tor/master] Fix a python warning in format_changelog.py.
by nickm＠torproject.org 14 May '20

14 May '20

commit bbfdee4c4e2ddebf3d7993ef41a268d91ad78268 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu May 14 10:37:52 2020 -0400 Fix a python warning in format_changelog.py. --- scripts/maint/format_changelog.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/maint/format_changelog.py b/scripts/maint/format_changelog.py index 7cf55a0d9..b37ece04c 100755 --- a/scripts/maint/format_changelog.py +++ b/scripts/maint/format_changelog.py @@ -291,7 +291,7 @@ class ChangeLog(object): self.curgraf.append(line) else: - assert "This" is "unreachable" # noqa: F632 + assert False # This should be unreachable. def lint_head(self, line, head): m = re.match(r'^ *o ([^$]+)((?:\([^$]+\))?):', head)

1 0

[tor/master] Merge branch 'maint-0.4.3'
by nickm＠torproject.org 14 May '20

14 May '20

commit fbd384cf893bb675157fa754014ec63ffa2f5d61 Merge: bbfdee4c4 75fc33f33 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu May 14 10:38:18 2020 -0400 Merge branch 'maint-0.4.3' "ours" to avoid 0.4.3.5 version bump.

1 0

[tor/release-0.4.3] start changelog for 0.4.3.5
by nickm＠torproject.org 14 May '20

14 May '20

commit 2a4c0ce21ee5e8c6e7fecaec963839ebc50d80a1 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu May 14 10:36:00 2020 -0400 start changelog for 0.4.3.5 --- ChangeLog | 39 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 39 insertions(+) diff --git a/ChangeLog b/ChangeLog index 3aa6edceb..87a5fc054 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,42 @@ +Changes in vesion 0.4.3.5 - 2020-05-15 + Tor 0.4.3.5 is the first stable release in the 0.4.3.x series. BLURB + BLURB BLURB BLURB BLURB BLURB BLURB BLURB BLURB + + Per our support policy, we support each stable release series for nine + months after its first stable release, or three months after the first + stable release of the next series: whichever is longer. This means + that 0.4.3.x will be supported until around February 2021--later, if + 0.4.4.x is later than anticipated. + + Note also that support for 0.4.1.x is about to end on May 20 of this + year; 0.4.2.x will be supported until September 15. We still plan to + continue supporting 0.3.5.x, our long-term stable series, until + Feb 2022. + + Below are the changes since 0.4.3.4-rc. For a complete list of changes + since 0.4.2.5, see the ReleaseNotes file. + + o Minor bugfixes (compiler compatibility): + - Avoid compiler warnings from Clang 10 related to the use of GCC- + style "/* falls through */" comments. Both Clang and GCC allow + __attribute__((fallthrough)) instead, so that's what we're using + now. Fixes bug 34078; bugfix on 0.3.1.3-alpha. + + o Minor bugfixes (compiler warnings): + - Fix compilation warnings with GCC 10.0.1. Fixes bug 34077; bugfix + on 0.4.0.3-alpha. + + o Minor bugfixes (IPv6, logging): + - Stop truncating IPv6 addresses and ports in channel and connection + logs. Fixes bug 33918; bugfix on 0.2.4.4-alpha. + + o Minor bugfixes (logging): + - Fix a logic error in a log message about whether an address was + invalid. Previously, the code would never report that onion + addresses were onion addresses. Fixes bug 34131; bugfix + on 0.4.3.1-alpha. + + Changes in version 0.4.3.4-rc - 2020-04-13 Tor 0.4.3.4-rc is the first release candidate in its series. It fixes several bugs from earlier versions, including one affecting DoS

1 0

[tor/release-0.4.3] bump to 0.4.3.5
by nickm＠torproject.org 14 May '20

14 May '20

1 0

[tor/release-0.4.3] Merge branch 'maint-0.4.3' into release-0.4.3
by nickm＠torproject.org 14 May '20

14 May '20

commit 5b8b9a97b4ae0eba050fe9d22dcac67c09996a87 Merge: 2a4c0ce21 75fc33f33 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu May 14 10:39:00 2020 -0400 Merge branch 'maint-0.4.3' into release-0.4.3 configure.ac | 4 ++-- contrib/win32build/tor-mingw.nsi.in | 2 +- src/win32/orconfig.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)

1 0

[tor/maint-0.4.1] Merge branch 'maint-0.3.5' into maint-0.4.1
by nickm＠torproject.org 14 May '20

14 May '20

commit 72312cdbb166e2c0c9d4b6dba049f43c2d35ecdc Merge: d41f1cd3e e63bfca5f Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu May 14 10:20:08 2020 -0400 Merge branch 'maint-0.3.5' into maint-0.4.1 .travis.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

tor-commits May 2020