tor-commits March 2020

tor-commits@lists.torproject.org

21 participants
1780 discussions

[tor/release-0.4.2] Light changelog edit
by nickm＠torproject.org 17 Mar '20

17 Mar '20

commit 40536768b0414703ab59b718ef3cd74b5811dc61 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Mar 17 15:02:45 2020 -0400 Light changelog edit --- ChangeLog | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index a0a139952..106b41c04 100644 --- a/ChangeLog +++ b/ChangeLog @@ -24,7 +24,7 @@ Changes in version 0.4.2.7 - 2020-03-?? - Lowercase the configured value of BridgeDistribution before adding it to the descriptor. Fixes bug 32753; bugfix on 0.3.2.3-alpha. - o Minor bugfixes (hidden services v3, backport from 0.4.3.3-alpha): + o Minor bugfixes (onion services v3, backport from 0.4.3.3-alpha): - Fix an assertion failure that could result from a corrupted ADD_ONION control port command. Found by Saibato. Fixes bug 33137; bugfix on 0.3.3.1-alpha. This issue is also tracked

1 0

[tor/release-0.4.3] Light changelog edit
by nickm＠torproject.org 17 Mar '20

17 Mar '20

commit f54681cba27a0ef9a1a81387ab64037fedcdf7e4 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Mar 17 15:02:04 2020 -0400 Light changelog edit --- ChangeLog | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 03778422f..9c8fecfef 100644 --- a/ChangeLog +++ b/ChangeLog @@ -44,7 +44,7 @@ Changes in version 0.4.3.3-alpha - 2020-03-?? - Remove the buggy and unused mirroring job. Fixes bug 33213; bugfix on 0.3.2.2-alpha. - o Minor bugfixes (hidden services v3): + o Minor bugfixes (onion services v3): - Fix an assertion failure that could result from a corrupted ADD_ONION control port command. Found by Saibato. Fixes bug 33137; bugfix on 0.3.3.1-alpha. This issue is also tracked

1 0

[tor/release-0.3.5] Initial changelog for 0.3.5.10
by nickm＠torproject.org 17 Mar '20

17 Mar '20

commit 261bf5f8632c21d2a1a54450325eab46572b6ee6 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Mar 17 15:00:13 2020 -0400 Initial changelog for 0.3.5.10 --- ChangeLog | 69 ++++++++++++++++++++++++++++++++++++++++++++++++ changes/bug29819 | 8 ------ changes/bug32753 | 3 --- changes/bug33093_logging | 5 ---- changes/ticket32240 | 4 --- changes/ticket32242 | 2 -- changes/ticket32407 | 4 --- changes/ticket32629 | 4 --- changes/ticket32792 | 3 --- changes/ticket33075 | 4 --- changes/ticket33194 | 4 --- changes/ticket33195 | 4 --- changes/ticket33212 | 4 --- changes/trove_2020_003 | 4 --- 14 files changed, 69 insertions(+), 53 deletions(-) diff --git a/ChangeLog b/ChangeLog index dde2a8f71..20a78b5d2 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,72 @@ +Changes in version 0.3.5.10 - 2020-03-?? + blurb. + + o Major bugfixes (linux seccomp sandbox, backport from 0.4.3.1-alpha): + - Correct how we use libseccomp. Particularly, stop assuming that + rules are applied in a particular order or that more rules are + processed after the first match. Neither is the case! In + libseccomp <2.4.0 this lead to some rules having no effect. + libseccomp 2.4.0 changed how rules are generated, leading to a + different ordering, which in turn led to a fatal crash during + startup. Fixes bug 29819; bugfix on 0.2.5.1-alpha. Patch by + Peter Gerber. + + o Minor features (continuous integration, backport from 0.4.3.2-alpha): + - Stop allowing failures on the Travis CI stem tests job. It looks + like all the stem hangs we were seeing before are now fixed. + Closes ticket 33075. + + o Minor bugfixes (bridges, backport from 0.4.3.1-alpha): + - Lowercase the configured value of BridgeDistribution before adding + it to the descriptor. Fixes bug 32753; bugfix on 0.3.2.3-alpha. + + o Minor bugfixes (crash, backport from 0.4.2.4-rc): + - When running Tor with an option like --verify-config or + --dump-config that does not start the event loop, avoid crashing + if we try to exit early because of an error. Fixes bug 32407; + bugfix on 0.3.3.1-alpha. + + o Minor bugfixes (logging, backport from 0.4.3.2-alpha): + - If we encounter a bug when flushing a buffer to a TLS connection, + only log the bug once per invocation of the Tor process. + Previously we would log with every occurrence, which could cause + us to run out of disk space. Fixes bug 33093; bugfix + on 0.3.2.2-alpha. + + o Minor bugfixes (onion services v3, backport from 0.4.3.3-alpha): + - Fix an assertion failure that could result from a corrupted + ADD_ONION control port command. Found by Saibato. Fixes bug 33137; + bugfix on 0.3.3.1-alpha. This issue is also tracked + as TROVE-2020-003. + + o Minor bugfixes (rust, build, backport from 0.4.3.2-alpha): + - Fix a syntax warning given by newer versions of Rust that was + creating problems for our continuous integration. Fixes bug 33212; + bugfix on 0.3.5.1-alpha. + + o Testing (backport from 0.4.3.1-alpha): + - Re-enable the Travis CI macOS Chutney build, but don't let it + prevent the Travis job from finishing. (The Travis macOS jobs are + slow, so we don't want to have it delay the whole CI process.) + Closes ticket 32629. + - Turn off Tor's Sandbox in Chutney jobs, and run those jobs on + Ubuntu Bionic. Turning off the Sandbox is a work-around, until we + fix the sandbox errors in 32722. Closes ticket 32240. + + o Testing (continuous integration, backport from 0.4.3.1-alpha): + - Use zstd in our Travis Linux builds. Closes ticket 32242. + + o Testing (Travis CI, backport from 0.4.3.3-alpha): + - Remove a redundant distcheck job. Closes ticket 33194. + - Sort the Travis jobs in order of speed: putting the slowest jobs + first takes full advantage of Travis job concurrency. Closes + ticket 33194. + - Stop allowing the Chutney IPv6 Travis job to fail. This job was + previously configured to fast_finish (which requires + - When a Travis chutney job fails, use chutney's new "diagnostics.sh" + tool to produce detailed diagnostic output. Closes ticket 32792. + + Changes in version 0.3.5.9 - 2019-12-09 Tor 0.3.5.9 backports serveral fixes from later releases, including several that affect bridge users, relay stability, onion services, diff --git a/changes/bug29819 b/changes/bug29819 deleted file mode 100644 index d37ac83d6..000000000 --- a/changes/bug29819 +++ /dev/null @@ -1,8 +0,0 @@ - o Minor bugfixes (linux seccomp sandbox): - - Correct how we use libseccomp. Particularly, stop assuming that - rules are applied in a particular order or that more rules are - processed after the first match. Neither is the case! In libseccomp - <2.4.0 this lead to some rules having no effect. Libseccomp 2.4.0 - changed how rules are generated leading to a different ordering - which in turn lead to a fatal crash during startup. Fixes bug - 29819; bugfix on 0.2.5.1-alpha. Patch by Peter Gerber. diff --git a/changes/bug32753 b/changes/bug32753 deleted file mode 100644 index 6f59c7729..000000000 --- a/changes/bug32753 +++ /dev/null @@ -1,3 +0,0 @@ - o Minor bugfixes (bridges): - - Lowercase the value of BridgeDistribution from torrc before adding it to - the descriptor. Fixes bug 32753; bugfix on 0.3.2.3-alpha. diff --git a/changes/bug33093_logging b/changes/bug33093_logging deleted file mode 100644 index e26e4a64a..000000000 --- a/changes/bug33093_logging +++ /dev/null @@ -1,5 +0,0 @@ - o Minor bugfixes (logging): - - If we encounter a bug when flushing a buffer to a TLS connection, - only log the bug once per invocation of the Tor process. Previously we - would log with every occurrence, which could cause us to run out of - disk space. Fixes bug 33093; bugfix on 0.3.2.2-alpha. diff --git a/changes/ticket32240 b/changes/ticket32240 deleted file mode 100644 index 35cc3df27..000000000 --- a/changes/ticket32240 +++ /dev/null @@ -1,4 +0,0 @@ - o Testing: - - Turn off Tor's Sandbox in Chutney jobs, and run those jobs on Ubuntu - Bionic. Turning off the Sandbox is a work-around, until we fix the - sandbox errors in 32722. Closes ticket 32240. diff --git a/changes/ticket32242 b/changes/ticket32242 deleted file mode 100644 index d63d5a586..000000000 --- a/changes/ticket32242 +++ /dev/null @@ -1,2 +0,0 @@ - o Testing (continuous integration): - - Use zstd in our Travis Linux builds. Closes ticket 32242. diff --git a/changes/ticket32407 b/changes/ticket32407 deleted file mode 100644 index badb09abf..000000000 --- a/changes/ticket32407 +++ /dev/null @@ -1,4 +0,0 @@ - o Minor bugfixes (crash): - - When running Tor with an option like --verify-config or --dump-config - that does not start the event loop, avoid crashing if we try to exit - early because of an error. Fixes bug 32407; bugfix on 0.3.3.1-alpha. diff --git a/changes/ticket32629 b/changes/ticket32629 deleted file mode 100644 index 740746c57..000000000 --- a/changes/ticket32629 +++ /dev/null @@ -1,4 +0,0 @@ - o Testing: - - Re-enable the Travis CI macOS Chutney build, but allow the job to finish - before it finishes, because the Travis macOS jobs are slow. - Closes ticket 32629. diff --git a/changes/ticket32792 b/changes/ticket32792 deleted file mode 100644 index 553cf0ca8..000000000 --- a/changes/ticket32792 +++ /dev/null @@ -1,3 +0,0 @@ - o Testing: - - When a Travis chutney job fails, use chutney's new "diagnostics.sh" tool - to produce detailed diagnostic output. Closes ticket 32792. diff --git a/changes/ticket33075 b/changes/ticket33075 deleted file mode 100644 index 69698d90b..000000000 --- a/changes/ticket33075 +++ /dev/null @@ -1,4 +0,0 @@ - o Testing: - - Stop allowing failures on the Travis CI stem tests job. It looks like all - the stem hangs we were seeing are now fixed, but let's make sure we see - them if they happen again. Closes ticket 33075. diff --git a/changes/ticket33194 b/changes/ticket33194 deleted file mode 100644 index b87e55348..000000000 --- a/changes/ticket33194 +++ /dev/null @@ -1,4 +0,0 @@ - o Testing: - - Remove a redundant distcheck job. Closes ticket 33194. - - Sort the Travis jobs in order of speed. Putting the slowest jobs first - takes full advantage of Travis job concurrency. Closes ticket 33194. diff --git a/changes/ticket33195 b/changes/ticket33195 deleted file mode 100644 index 11abd4816..000000000 --- a/changes/ticket33195 +++ /dev/null @@ -1,4 +0,0 @@ - o Testing: - - Stop allowing the Chutney IPv6 Travis job to fail. This job was - previously configured to fast_finish (which requires allow_failure), to - speed up the build. Closes ticket 33195. diff --git a/changes/ticket33212 b/changes/ticket33212 deleted file mode 100644 index aeb09e0c6..000000000 --- a/changes/ticket33212 +++ /dev/null @@ -1,4 +0,0 @@ - o Minor bugfixes (rust, build): - - Fix a syntax warning given by newer versions of Rust, and creating - problems for our continuous integration. - Fixes bug 33212; bugfix on 0.3.5.1-alpha. diff --git a/changes/trove_2020_003 b/changes/trove_2020_003 deleted file mode 100644 index aa1a8f1c7..000000000 --- a/changes/trove_2020_003 +++ /dev/null @@ -1,4 +0,0 @@ - o Minor bugfixes (onion services v3): - - Fix assertion failure that could result from a corrupted ADD_ONION control - port command. Found by Saibato. Fixes bug 33137; bugfix on - 0.3.3.1-alpha. This issue is also being tracked as TROVE-2020-003.

1 0

[translation/https_everywhere] https://gitweb.torproject.org/translation.git/commit/?h=https_everywhere
by translation＠torproject.org 17 Mar '20

17 Mar '20

commit 6b38ee3388360a864efbd2550ac45d5e9f8dbb7a Author: Translation commit bot <translation(a)torproject.org> Date: Tue Mar 17 18:46:11 2020 +0000 https://gitweb.torproject.org/translation.git/commit/?h=https_everywhere --- ja/https-everywhere.dtd | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ja/https-everywhere.dtd b/ja/https-everywhere.dtd index 786a969afc..f46a6a5d56 100644 --- a/ja/https-everywhere.dtd +++ b/ja/https-everywhere.dtd @@ -28,7 +28,7 @@ <!ENTITY https-everywhere.options.autoUpdateRulesets "ルールセットを自動更新する"> <!ENTITY https-everywhere.options.userRulesListed "HTTPS Everywhere ユーザールール"> <!ENTITY https-everywhere.options.disabledUrlsListed "HTTPS Everywhereが無効されたサイト"> -<!ENTITY https-everywhere.options.updateChannelsWarning "警告: 更新チャンネルを追加すると、攻撃者にブラウザを乗っ取られる可能性があります。十分な理解の上で、このセクションを編集してください！"> +<!ENTITY https-everywhere.options.updateChannelsWarning "警告: 更新チャンネルを追加すると、攻撃者にブラウザを乗っ取られる可能性があります。十分な理解の上で、この項目を編集してください！"> <!ENTITY https-everywhere.options.addDisabledSite "Add Disabled Site"> <!ENTITY https-everywhere.options.enterDisabledSite "Enter disabled site"> <!ENTITY https-everywhere.options.addUpdateChannel "更新チャンネルを追加"> @@ -51,7 +51,7 @@ <!ENTITY https-everywhere.onboarding.intro "ウェブを暗号化します！多くのウェブサイト上でHTTPSセキュリティを自動的にかけます。"> <!ENTITY https-everywhere.onboarding.header "HTTPS Everywhere has been updated!"> -<!ENTITY https-everywhere.onboarding.details_one "EASE Mode Optimized"> +<!ENTITY https-everywhere.onboarding.details_one "「すべてのサイトを暗号化(EASE)」モードの最適化"> <!ENTITY https-everywhere.onboarding.details_two "You can now whitelist sites to disable in HTTPS Everywhere"> <!ENTITY https-everywhere.onboarding.footer "HTTPS Everywhere is an EFF project">

1 0

[tor/release-0.4.2] Construct initial 0.4.2.7 changelog.
by nickm＠torproject.org 17 Mar '20

17 Mar '20

commit 3751a40dcd836481cd4d75e0574581fd5848b0c2 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Mar 17 14:42:18 2020 -0400 Construct initial 0.4.2.7 changelog. --- ChangeLog | 56 ++++++++++++++++++++++++++++++++++++++++++++++++ changes/bug32753 | 3 --- changes/bug33093_logging | 5 ----- changes/ticket32792 | 3 --- changes/ticket33029 | 5 ----- changes/ticket33075 | 4 ---- changes/ticket33194 | 4 ---- changes/ticket33195 | 4 ---- changes/ticket33212 | 4 ---- changes/ticket33619 | 5 ----- changes/trove_2020_003 | 4 ---- 11 files changed, 56 insertions(+), 41 deletions(-) diff --git a/ChangeLog b/ChangeLog index c9920edbe..a0a139952 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,59 @@ +Changes in version 0.4.2.7 - 2020-03-?? + This is the third stable release in the 0.4.2.x series. + + Blurb. + + o Major bugfixes (circuit padding, memory leak, backport from 0.4.3.3-alpha): + - Avoid a remotely triggered memory leak in the case that a circuit + padding machine is somehow negotiated twice on the same circuit. + Fixes bug 33619; bugfix on 0.4.0.1-alpha. Found by Tobias Pulls. + This is also tracked as TROVE-2020-004. + + o Major bugfixes (directory authority, backport from 0.4.3.3-alpha): + - Directory authorities will now send a 503 (not enough bandwidth) + code to clients when under bandwidth pressure. Known relays and + other authorities will always be answered regardless of the + bandwidth situation. Fixes bug 33029; bugfix on 0.1.2.5-alpha. + + o Minor features (continuous integration, backport from 0.4.3.2-alpha): + - Stop allowing failures on the Travis CI stem tests job. It looks + like all the stem hangs we were seeing before are now fixed. + Closes ticket 33075. + + o Minor bugfixes (bridges, backport from 0.4.3.1-alpha): + - Lowercase the configured value of BridgeDistribution before adding + it to the descriptor. Fixes bug 32753; bugfix on 0.3.2.3-alpha. + + o Minor bugfixes (hidden services v3, backport from 0.4.3.3-alpha): + - Fix an assertion failure that could result from a corrupted + ADD_ONION control port command. Found by Saibato. Fixes bug 33137; + bugfix on 0.3.3.1-alpha. This issue is also tracked + as TROVE-2020-003. + + o Minor bugfixes (logging, backport from 0.4.3.2-alpha): + - If we encounter a bug when flushing a buffer to a TLS connection, + only log the bug once per invocation of the Tor process. + Previously we would log with every occurrence, which could cause + us to run out of disk space. Fixes bug 33093; bugfix + on 0.3.2.2-alpha. + + o Minor bugfixes (rust, build, backport from 0.4.3.2-alpha): + - Fix a syntax warning given by newer versions of Rust that was + creating problems for our continuous integration. Fixes bug 33212; + bugfix on 0.3.5.1-alpha. + + o Testing (Travis CI, backport from 0.4.3.3-alpha): + - Remove a redundant distcheck job. Closes ticket 33194. + - Sort the Travis jobs in order of speed: putting the slowest jobs + first takes full advantage of Travis job concurrency. Closes + ticket 33194. + - Stop allowing the Chutney IPv6 Travis job to fail. This job was + previously configured to fast_finish (which requires + allow_failure), to speed up the build. Closes ticket 33195. + - When a Travis chutney job fails, use chutney's new "diagnostics.sh" + tool to produce detailed diagnostic output. Closes ticket 32792. + + Changes in version 0.4.2.6 - 2020-01-30 This is the second stable release in the 0.4.2.x series. It backports several bugfixes from 0.4.3.1-alpha, including some that had affected diff --git a/changes/bug32753 b/changes/bug32753 deleted file mode 100644 index 6f59c7729..000000000 --- a/changes/bug32753 +++ /dev/null @@ -1,3 +0,0 @@ - o Minor bugfixes (bridges): - - Lowercase the value of BridgeDistribution from torrc before adding it to - the descriptor. Fixes bug 32753; bugfix on 0.3.2.3-alpha. diff --git a/changes/bug33093_logging b/changes/bug33093_logging deleted file mode 100644 index e26e4a64a..000000000 --- a/changes/bug33093_logging +++ /dev/null @@ -1,5 +0,0 @@ - o Minor bugfixes (logging): - - If we encounter a bug when flushing a buffer to a TLS connection, - only log the bug once per invocation of the Tor process. Previously we - would log with every occurrence, which could cause us to run out of - disk space. Fixes bug 33093; bugfix on 0.3.2.2-alpha. diff --git a/changes/ticket32792 b/changes/ticket32792 deleted file mode 100644 index 553cf0ca8..000000000 --- a/changes/ticket32792 +++ /dev/null @@ -1,3 +0,0 @@ - o Testing: - - When a Travis chutney job fails, use chutney's new "diagnostics.sh" tool - to produce detailed diagnostic output. Closes ticket 32792. diff --git a/changes/ticket33029 b/changes/ticket33029 deleted file mode 100644 index c32ee4ad8..000000000 --- a/changes/ticket33029 +++ /dev/null @@ -1,5 +0,0 @@ - o Major bugfixes (directory authority): - - Directory authorities will now send a 503 (not enough bandwidth) code to - clients when under bandwidth pressure. Known relays and other authorities - will always be answered regardless of the bandwidth situation. Fixes bug - 33029; bugfix on 0.1.2.5-alpha. diff --git a/changes/ticket33075 b/changes/ticket33075 deleted file mode 100644 index 69698d90b..000000000 --- a/changes/ticket33075 +++ /dev/null @@ -1,4 +0,0 @@ - o Testing: - - Stop allowing failures on the Travis CI stem tests job. It looks like all - the stem hangs we were seeing are now fixed, but let's make sure we see - them if they happen again. Closes ticket 33075. diff --git a/changes/ticket33194 b/changes/ticket33194 deleted file mode 100644 index b87e55348..000000000 --- a/changes/ticket33194 +++ /dev/null @@ -1,4 +0,0 @@ - o Testing: - - Remove a redundant distcheck job. Closes ticket 33194. - - Sort the Travis jobs in order of speed. Putting the slowest jobs first - takes full advantage of Travis job concurrency. Closes ticket 33194. diff --git a/changes/ticket33195 b/changes/ticket33195 deleted file mode 100644 index 11abd4816..000000000 --- a/changes/ticket33195 +++ /dev/null @@ -1,4 +0,0 @@ - o Testing: - - Stop allowing the Chutney IPv6 Travis job to fail. This job was - previously configured to fast_finish (which requires allow_failure), to - speed up the build. Closes ticket 33195. diff --git a/changes/ticket33212 b/changes/ticket33212 deleted file mode 100644 index aeb09e0c6..000000000 --- a/changes/ticket33212 +++ /dev/null @@ -1,4 +0,0 @@ - o Minor bugfixes (rust, build): - - Fix a syntax warning given by newer versions of Rust, and creating - problems for our continuous integration. - Fixes bug 33212; bugfix on 0.3.5.1-alpha. diff --git a/changes/ticket33619 b/changes/ticket33619 deleted file mode 100644 index 3c52858b3..000000000 --- a/changes/ticket33619 +++ /dev/null @@ -1,5 +0,0 @@ - o Major bugfixes (circuit padding, memory leaks): - - Avoid a remotely triggered memory leak in the case that a circuit - padding machine is somehow negotiated twice on the same circuit. Fixes - bug 33619; bugfix on 0.4.0.1-alpha. Found by Tobias Pulls. This is - also tracked as TROVE-2020-004. diff --git a/changes/trove_2020_003 b/changes/trove_2020_003 deleted file mode 100644 index aa1a8f1c7..000000000 --- a/changes/trove_2020_003 +++ /dev/null @@ -1,4 +0,0 @@ - o Minor bugfixes (onion services v3): - - Fix assertion failure that could result from a corrupted ADD_ONION control - port command. Found by Saibato. Fixes bug 33137; bugfix on - 0.3.3.1-alpha. This issue is also being tracked as TROVE-2020-003.

1 0

[tor/release-0.4.3] Fold new items into 0.4.3.3-alpha changelog.
by nickm＠torproject.org 17 Mar '20

17 Mar '20

commit 4d1d8bde955cc0c1c42dcb0073954893323735ce Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Mar 17 14:22:36 2020 -0400 Fold new items into 0.4.3.3-alpha changelog. --- ChangeLog | 19 +++++++++++++++++++ changes/ticket32672 | 4 ---- changes/ticket32792 | 3 --- changes/ticket33619 | 5 ----- changes/trove_2020_003 | 4 ---- 5 files changed, 19 insertions(+), 16 deletions(-) diff --git a/ChangeLog b/ChangeLog index 461126330..03778422f 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,6 +1,12 @@ Changes in version 0.4.3.3-alpha - 2020-03-?? blurb here. + o Major bugfixes (circuit padding, memory leak): + - Avoid a remotely triggered memory leak in the case that a circuit + padding machine is somehow negotiated twice on the same circuit. + Fixes bug 33619; bugfix on 0.4.0.1-alpha. Found by Tobias Pulls. + This is also tracked as TROVE-2020-004. + o Major bugfixes (directory authority): - Directory authorities will now send a 503 (not enough bandwidth) code to clients when under bandwidth pressure. Known relays and @@ -12,6 +18,11 @@ Changes in version 0.4.3.3-alpha - 2020-03-?? track down possible causes of a rare crash (32564) in the EWMA code. Closes ticket 33290. + o Minor features (directory authorities): + - Directory authorities now reject descriptors from relays running + Tor versions from the 0.2.9 and 0.4.0 series. The 0.3.5 series is + still allowed. Resolves ticket 32672. Patch by Neel Chauhan. + o Minor features (usability): - Include more information when failing to parse a configuration value. This should make it easier to tell what's going wrong when @@ -33,6 +44,12 @@ Changes in version 0.4.3.3-alpha - 2020-03-?? - Remove the buggy and unused mirroring job. Fixes bug 33213; bugfix on 0.3.2.2-alpha. + o Minor bugfixes (hidden services v3): + - Fix an assertion failure that could result from a corrupted + ADD_ONION control port command. Found by Saibato. Fixes bug 33137; + bugfix on 0.3.3.1-alpha. This issue is also tracked + as TROVE-2020-003. + o Minor bugfixes (onion service v3, client): - Remove a BUG() warning that would cause a stack trace if an onion service descriptor was freed while we were waiting for a @@ -55,6 +72,8 @@ Changes in version 0.4.3.3-alpha - 2020-03-?? - Stop allowing the Chutney IPv6 Travis job to fail. This job was previously configured to fast_finish (which requires allow_failure), to speed up the build. Closes ticket 33195. + - When a Travis chutney job fails, use chutney's new "diagnostics.sh" + tool to produce detailed diagnostic output. Closes ticket 32792. Changes in version 0.4.3.2-alpha - 2020-02-10 diff --git a/changes/ticket32672 b/changes/ticket32672 deleted file mode 100644 index 351329ba2..000000000 --- a/changes/ticket32672 +++ /dev/null @@ -1,4 +0,0 @@ - o Minor features (directory authorities): - - Directory authorities now reject descriptors from relays running Tor - versions from the 0.2.9 and 0.4.0 series, but still allow the 0.3.5 - series. Resolves ticket 32672. Patch by Neel Chauhan. diff --git a/changes/ticket32792 b/changes/ticket32792 deleted file mode 100644 index 553cf0ca8..000000000 --- a/changes/ticket32792 +++ /dev/null @@ -1,3 +0,0 @@ - o Testing: - - When a Travis chutney job fails, use chutney's new "diagnostics.sh" tool - to produce detailed diagnostic output. Closes ticket 32792. diff --git a/changes/ticket33619 b/changes/ticket33619 deleted file mode 100644 index 3c52858b3..000000000 --- a/changes/ticket33619 +++ /dev/null @@ -1,5 +0,0 @@ - o Major bugfixes (circuit padding, memory leaks): - - Avoid a remotely triggered memory leak in the case that a circuit - padding machine is somehow negotiated twice on the same circuit. Fixes - bug 33619; bugfix on 0.4.0.1-alpha. Found by Tobias Pulls. This is - also tracked as TROVE-2020-004. diff --git a/changes/trove_2020_003 b/changes/trove_2020_003 deleted file mode 100644 index aa1a8f1c7..000000000 --- a/changes/trove_2020_003 +++ /dev/null @@ -1,4 +0,0 @@ - o Minor bugfixes (onion services v3): - - Fix assertion failure that could result from a corrupted ADD_ONION control - port command. Found by Saibato. Fixes bug 33137; bugfix on - 0.3.3.1-alpha. This issue is also being tracked as TROVE-2020-003.

1 0

[snowflake/master] Remove the abandoned server-webrtc test code
by cohosh＠torproject.org 17 Mar '20

17 Mar '20

commit 6054c09949dfeb807a898e369c546344e26373dd Author: Cecylia Bocovich <cohosh(a)torproject.org> Date: Tue Mar 17 12:36:12 2020 -0400 Remove the abandoned server-webrtc test code This existed solely for testing purposes and is no longer being maintained. --- README.md | 7 +- server-webrtc/README.md | 26 ----- server-webrtc/http.go | 74 ------------- server-webrtc/snowflake.go | 255 --------------------------------------------- server-webrtc/torrc | 8 -- 5 files changed, 1 insertion(+), 369 deletions(-) diff --git a/README.md b/README.md index fdb039c..05fb5f7 100644 --- a/README.md +++ b/README.md @@ -15,7 +15,7 @@ Pluggable Transport using WebRTC, inspired by Flashproxy. - [Test Environment](#test-environment) - [FAQ](#faq) - [Appendix](#appendix) - - [-- Testing directly via WebRTC Server --](#---testing-directly-via-webrtc-server---) + - [-- Testing with Standalone Proxy --](#---testing-with-standalone-proxy---)  @@ -142,11 +142,6 @@ go build ./proxy-go ``` -##### -- Testing directly via WebRTC Server -- - -See server-webrtc/README.md for information on connecting directly to a -WebRTC server transport plugin, bypassing the Broker and browser proxy. - More documentation on the way. Also available at: diff --git a/server-webrtc/README.md b/server-webrtc/README.md deleted file mode 100644 index 53cad14..0000000 --- a/server-webrtc/README.md +++ /dev/null @@ -1,26 +0,0 @@ -Ordinarily, the WebRTC client plugin speaks with a Broker which helps -match and signal with a browser proxy, which ultimately speaks with a default -websocket server. - - -However, this directory contains a WebRTC server plugin which uses an -HTTP server that simulates the interaction that a client would have with -the broker, for direct testing. - -Edit server-webrtc/torrc and add "-http 127.0.0.1:8080" to the end of the -ServerTransportPlugin line: -``` -ServerTransportPlugin snowflake exec ./server-webrtc -http 127.0.0.1:8080 -``` - -``` -cd server-webrtc/ -go build -tor -f torrc -``` - -Edit client/torrc and add "-url http://127.0.0.1:8080" to the end of the -ClientTransportPlugin line: -``` -ClientTransportPlugin snowflake exec ./client -url http://127.0.0.1:8080/ -``` diff --git a/server-webrtc/http.go b/server-webrtc/http.go deleted file mode 100644 index 1232239..0000000 --- a/server-webrtc/http.go +++ /dev/null @@ -1,74 +0,0 @@ -// An HTTP-based signaling channel for the WebRTC server. It imitates the -// broker as seen by clients, but it doesn't connect them to an -// intermediate WebRTC proxy, rather connects them directly to this WebRTC -// server. This code should be deleted when we have proxies in place. - -package main - -import ( - "fmt" - "io/ioutil" - "log" - "net/http" - - "github.com/keroserene/go-webrtc" -) - -type httpHandler struct { - config *webrtc.Configuration -} - -func (h *httpHandler) ServeHTTP(w http.ResponseWriter, req *http.Request) { - switch req.Method { - case "GET": - w.Header().Set("Content-Type", "text/plain; charset=utf-8") - w.WriteHeader(http.StatusOK) - _, err := w.Write([]byte(`HTTP signaling channel - -Send a POST request containing an SDP offer. The response will -contain an SDP answer. -`)) - if err != nil { - log.Printf("GET request write failed with error: %v", err) - } - return - case "POST": - break - default: - http.Error(w, "Bad request.", http.StatusBadRequest) - return - } - - // POST handling begins here. - body, err := ioutil.ReadAll(http.MaxBytesReader(w, req.Body, 100000)) - if err != nil { - http.Error(w, "Bad request.", http.StatusBadRequest) - return - } - offer := webrtc.DeserializeSessionDescription(string(body)) - if offer == nil { - http.Error(w, "Bad request.", http.StatusBadRequest) - return - } - - pc, err := makePeerConnectionFromOffer(offer, h.config) - if err != nil { - http.Error(w, fmt.Sprintf("Cannot create offer: %s", err), http.StatusInternalServerError) - return - } - - log.Println("answering HTTP POST") - - w.WriteHeader(http.StatusOK) - _, err = w.Write([]byte(pc.LocalDescription().Serialize())) - if err != nil { - log.Printf("answering HTTP POST write failed with error %v", err) - } - -} - -func receiveSignalsHTTP(addr string, config *webrtc.Configuration) error { - http.Handle("/", &httpHandler{config}) - log.Printf("listening HTTP on %s", addr) - return http.ListenAndServe(addr, nil) -} diff --git a/server-webrtc/snowflake.go b/server-webrtc/snowflake.go deleted file mode 100644 index 9ca82cb..0000000 --- a/server-webrtc/snowflake.go +++ /dev/null @@ -1,255 +0,0 @@ -package main - -import ( - "flag" - "fmt" - "io" - "io/ioutil" - "log" - "net" - "os" - "os/signal" - "sync" - "syscall" - "time" - - pt "git.torproject.org/pluggable-transports/goptlib.git" - "github.com/keroserene/go-webrtc" -) - -var ptMethodName = "snowflake" -var ptInfo pt.ServerInfo -var logFile *os.File - -func copyLoop(webRTC, orPort net.Conn) { - var wg sync.WaitGroup - wg.Add(2) - go func() { - if _, err := io.Copy(orPort, webRTC); err != nil { - log.Printf("copy WebRTC to ORPort error in copyLoop: %v", err) - } - wg.Done() - }() - go func() { - if _, err := io.Copy(webRTC, orPort); err != nil { - log.Printf("copy ORPort to WebRTC error in copyLoop: %v", err) - } - wg.Done() - }() - wg.Wait() -} - -type webRTCConn struct { - dc *webrtc.DataChannel - pc *webrtc.PeerConnection - pr *io.PipeReader - - lock sync.Mutex // Synchronization for DataChannel destruction - once sync.Once // Synchronization for PeerConnection destruction -} - -func (c *webRTCConn) Read(b []byte) (int, error) { - return c.pr.Read(b) -} - -func (c *webRTCConn) Write(b []byte) (int, error) { - c.lock.Lock() - defer c.lock.Unlock() - // log.Printf("webrtc Write %d %+q", len(b), string(b)) - log.Printf("Write %d bytes --> WebRTC", len(b)) - if c.dc != nil { - c.dc.Send(b) - } - return len(b), nil -} - -func (c *webRTCConn) Close() (err error) { - c.once.Do(func() { - err = c.pc.Destroy() - }) - return -} - -func (c *webRTCConn) LocalAddr() net.Addr { - return nil -} - -func (c *webRTCConn) RemoteAddr() net.Addr { - return nil -} - -func (c *webRTCConn) SetDeadline(t time.Time) error { - // nolint:golint - return fmt.Errorf("SetDeadline not implemented") -} - -func (c *webRTCConn) SetReadDeadline(t time.Time) error { - // nolint:golint - return fmt.Errorf("SetReadDeadline not implemented") -} - -func (c *webRTCConn) SetWriteDeadline(t time.Time) error { - // nolint:golint - return fmt.Errorf("SetWriteDeadline not implemented") -} - -func datachannelHandler(conn *webRTCConn) { - defer conn.Close() - - or, err := pt.DialOr(&ptInfo, "", ptMethodName) // TODO: Extended OR - if err != nil { - log.Printf("Failed to connect to ORPort: " + err.Error()) - return - } - defer or.Close() - - copyLoop(conn, or) -} - -// Create a PeerConnection from an SDP offer. Blocks until the gathering of ICE -// candidates is complete and the answer is available in LocalDescription. -// Installs an OnDataChannel callback that creates a webRTCConn and passes it to -// datachannelHandler. -func makePeerConnectionFromOffer(sdp *webrtc.SessionDescription, config *webrtc.Configuration) (*webrtc.PeerConnection, error) { - pc, err := webrtc.NewPeerConnection(config) - if err != nil { - return nil, fmt.Errorf("accept: NewPeerConnection: %s", err) - } - pc.OnNegotiationNeeded = func() { - panic("OnNegotiationNeeded") - } - pc.OnDataChannel = func(dc *webrtc.DataChannel) { - log.Println("OnDataChannel") - - pr, pw := io.Pipe() - conn := &webRTCConn{pc: pc, dc: dc, pr: pr} - - dc.OnOpen = func() { - log.Println("OnOpen channel") - } - dc.OnClose = func() { - conn.lock.Lock() - defer conn.lock.Unlock() - log.Println("OnClose channel") - conn.dc = nil - pc.DeleteDataChannel(dc) - pw.Close() - } - dc.OnMessage = func(msg []byte) { - log.Printf("OnMessage <--- %d bytes", len(msg)) - var n int - n, err = pw.Write(msg) - if err != nil { - if inerr := pw.CloseWithError(err); inerr != nil { - log.Printf("close with error returned error: %v", inerr) - } - } - if n != len(msg) { - panic("short write") - } - } - - go datachannelHandler(conn) - } - - err = pc.SetRemoteDescription(sdp) - if err != nil { - if err = pc.Destroy(); err != nil { - log.Printf("pc.Destroy returned an error: %v", err) - } - return nil, fmt.Errorf("accept: SetRemoteDescription: %s", err) - } - log.Println("sdp offer successfully received.") - - log.Println("Generating answer...") - answer, err := pc.CreateAnswer() - if err != nil { - if err = pc.Destroy(); err != nil { - log.Printf("pc.Destroy returned an error: %v", err) - } - return nil, err - } - - if answer == nil { - if err = pc.Destroy(); err != nil { - log.Printf("pc.Destroy returned an error: %v", err) - } - return nil, fmt.Errorf("failed gathering ICE candidates") - } - - err = pc.SetLocalDescription(answer) - if err != nil { - if err = pc.Destroy(); err != nil { - log.Printf("pc.Destroy returned an error: %v", err) - } - return nil, err - } - - return pc, nil -} - -func main() { - var httpAddr string - var logFilename string - - flag.StringVar(&httpAddr, "http", "", "listen for HTTP signaling") - flag.StringVar(&logFilename, "log", "", "log file to write to") - flag.Parse() - - log.SetFlags(log.LstdFlags | log.LUTC) - if logFilename != "" { - f, err := os.OpenFile(logFilename, os.O_CREATE|os.O_APPEND|os.O_WRONLY, 0600) - if err != nil { - log.Fatalf("can't open log file: %s", err) - } - defer logFile.Close() - log.SetOutput(f) - } - - log.Println("starting") - webrtc.SetLoggingVerbosity(1) - var err error - ptInfo, err = pt.ServerSetup(nil) - if err != nil { - log.Fatal(err) - } - - webRTCConfig := webrtc.NewConfiguration(webrtc.OptionIceServer("stun:stun.l.google.com:19302")) - - // Start HTTP-based signaling receiver. - go func() { - err := receiveSignalsHTTP(httpAddr, webRTCConfig) - if err != nil { - log.Printf("receiveSignalsHTTP: %s", err) - } - }() - - for _, bindaddr := range ptInfo.Bindaddrs { - switch bindaddr.MethodName { - case ptMethodName: - bindaddr.Addr.Port = 12345 // lies!!! - pt.Smethod(bindaddr.MethodName, bindaddr.Addr) - default: - pt.SmethodError(bindaddr.MethodName, "no such method") - } - } - pt.SmethodsDone() - - sigChan := make(chan os.Signal, 1) - signal.Notify(sigChan, syscall.SIGTERM) - - if os.Getenv("TOR_PT_EXIT_ON_STDIN_CLOSE") == "1" { - // This environment variable means we should treat EOF on stdin - // just like SIGTERM: https://bugs.torproject.org/15435. - go func() { - if _, err := io.Copy(ioutil.Discard, os.Stdin); err != nil { - log.Printf("error copying os.Stdin to ioutil.Discard: %v", err) - } - log.Printf("synthesizing SIGTERM because of stdin close") - sigChan <- syscall.SIGTERM - }() - } - - // wait for a signal - <-sigChan -} diff --git a/server-webrtc/torrc b/server-webrtc/torrc deleted file mode 100644 index e037c97..0000000 --- a/server-webrtc/torrc +++ /dev/null @@ -1,8 +0,0 @@ -BridgeRelay 1 -ORPort 9001 -ExtORPort auto -SocksPort 0 -ExitPolicy reject *:* -DataDirectory datadir - -ServerTransportPlugin snowflake exec ./server-webrtc

1 0

[tor/maint-0.4.1] circpad_setup_machine_on_circ(): exit early on error.
by nickm＠torproject.org 17 Mar '20

17 Mar '20

commit 78bcfc1280b322ba57a10a116457616eeb742ab6 Author: Nick Mathewson <nickm(a)torproject.org> Date: Sat Mar 14 14:44:33 2020 -0400 circpad_setup_machine_on_circ(): exit early on error. This function does a nonfatal assertion to make sure that a machine is not registered twice, but Tobias Pulls found a case where it happens. Instead, make the function exit early so that it doesn't cause a remotely triggered memory leak. Fixes bug 33619; bugfix on 0.4.0.1-alpha. This is also tracked as TROVE-2020-004. --- changes/ticket33619 | 5 +++++ src/core/or/circuitpadding.c | 9 ++++++--- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/changes/ticket33619 b/changes/ticket33619 new file mode 100644 index 000000000..3c52858b3 --- /dev/null +++ b/changes/ticket33619 @@ -0,0 +1,5 @@ + o Major bugfixes (circuit padding, memory leaks): + - Avoid a remotely triggered memory leak in the case that a circuit + padding machine is somehow negotiated twice on the same circuit. Fixes + bug 33619; bugfix on 0.4.0.1-alpha. Found by Tobias Pulls. This is + also tracked as TROVE-2020-004. diff --git a/src/core/or/circuitpadding.c b/src/core/or/circuitpadding.c index a62cdcf9e..72b770113 100644 --- a/src/core/or/circuitpadding.c +++ b/src/core/or/circuitpadding.c @@ -2381,9 +2381,12 @@ circpad_setup_machine_on_circ(circuit_t *on_circ, return; } - tor_assert_nonfatal(on_circ->padding_machine[machine->machine_index] - == NULL); - tor_assert_nonfatal(on_circ->padding_info[machine->machine_index] == NULL); + IF_BUG_ONCE(on_circ->padding_machine[machine->machine_index] != NULL) { + return; + } + IF_BUG_ONCE(on_circ->padding_info[machine->machine_index] != NULL) { + return; + } /* Log message */ if (CIRCUIT_IS_ORIGIN(on_circ)) {

1 0

[tor/maint-0.4.1] Merge branch 'trove_2020_004_041_v2' into maint-0.4.1
by nickm＠torproject.org 17 Mar '20

17 Mar '20

commit cec647ff3eab20c97a744a59b808eb49760acfd3 Merge: 5f4e14b8c 78bcfc128 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Mar 17 13:56:03 2020 -0400 Merge branch 'trove_2020_004_041_v2' into maint-0.4.1 changes/ticket33619 | 5 +++++ src/core/or/circuitpadding.c | 9 ++++++--- 2 files changed, 11 insertions(+), 3 deletions(-)

1 0

[tor/maint-0.4.2] Merge branch 'maint-0.4.1' into maint-0.4.2
by nickm＠torproject.org 17 Mar '20

17 Mar '20

commit 4ee2699416dc612b859f6ba77e6fcd2e7e55c1b7 Merge: e15a621ac cec647ff3 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Mar 17 13:56:10 2020 -0400 Merge branch 'maint-0.4.1' into maint-0.4.2 changes/ticket33619 | 5 +++++ src/core/or/circuitpadding.c | 9 ++++++--- 2 files changed, 11 insertions(+), 3 deletions(-)

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

tor-commits March 2020