March 2020 - tor-commits - lists.torproject.org

[tor/master] config: Improve some comments
by teor＠torproject.org 13 Mar '20

13 Mar '20

commit 9cf7839df7478d74d6c14d56c884b8d9e2aad4f3 Author: teor <teor(a)torproject.org> Date: Fri Mar 13 18:53:48 2020 +1000 config: Improve some comments Document the namelen argument to port_cfg_new(). Fix a typo in a comment in port_cfg_line_extract_addrport(). Comment-only changes. --- src/app/config/config.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/app/config/config.c b/src/app/config/config.c index ad664873e..062338909 100644 --- a/src/app/config/config.c +++ b/src/app/config/config.c @@ -5880,7 +5880,11 @@ parse_dir_fallback_line(const char *line, return r; } -/** Allocate and return a new port_cfg_t with reasonable defaults. */ +/** Allocate and return a new port_cfg_t with reasonable defaults. + * + * <b>namelen</b> is the length of the unix socket name + * (typically the filesystem path), not including the trailing NUL. + * It should be 0 for ports that are not zunix sockets. */ port_cfg_t * port_cfg_new(size_t namelen) { @@ -6000,7 +6004,7 @@ port_cfg_line_extract_addrport(const char *line, size_t sz; *is_unix_out = 1; *addrport_out = NULL; - line += strlen(unix_socket_prefix); /*No q: Keep the quote */ + line += strlen(unix_socket_prefix); /* No 'unix:', but keep the quote */ *rest_out = unescape_string(line, addrport_out, &sz); if (!*rest_out || (*addrport_out && sz != strlen(*addrport_out))) { tor_free(*addrport_out);

1 0

[chutney/master] warnings: Ignore new ContactInfo warning
by teor＠torproject.org 13 Mar '20

13 Mar '20

commit 0e73c446b5b1fb1589a44ca8deec917795752dd1 Author: teor <teor(a)torproject.org> Date: Fri Mar 13 13:21:02 2020 +1000 warnings: Ignore new ContactInfo warning Cleanup after 33361. --- tools/ignore.warnings | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/ignore.warnings b/tools/ignore.warnings index a95e48a..036f5c2 100644 --- a/tools/ignore.warnings +++ b/tools/ignore.warnings @@ -77,5 +77,6 @@ V3AuthVotingInterval is very low We don't have a consensus, so we can't perform v2 rendezvous operations We don't have enough votes to generate a consensus We only have [1-4] introduction points established for +Your ContactInfo config option is not set You have used DirAuthority or AlternateDirAuthority Your log may contain sensitive information

1 0

[chutney/master] Travis: Actually allow 2 failures per test
by teor＠torproject.org 13 Mar '20

13 Mar '20

commit 7c945cc2bcaaec2a04e8cc561c6f460cfa44d633 Author: teor <teor(a)torproject.org> Date: Fri Mar 13 13:12:00 2020 +1000 Travis: Actually allow 2 failures per test Previously, the script reset the number of failures to 1. Fix on 33583. --- .travis.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.travis.yml b/.travis.yml index dcb65fd..ff8f540 100644 --- a/.travis.yml +++ b/.travis.yml @@ -16,6 +16,8 @@ env: ## triggered by Ubuntu Xenial and Bionic. See #32722. - CHUTNEY_TOR_SANDBOX="0" ## Tolerate a small number of failures in chutney jobs + ## Tor 0.3.5 seems particularly unstable, later versions seem to cope well + ## with CHUTNEY_ALLOW_FAILURES="1" - CHUTNEY_ALLOW_FAILURES="2" matrix: ## This matrix entry is required, but it doesn't actually create any jobs @@ -262,10 +264,8 @@ script: ## Basic tests - if command -v shellcheck ; then tests/shellcheck-tests.sh; fi - tests/unit-tests.sh - ## Quick smoke test - - tools/test-network.sh --dry-run - ## Now, allow one failure for each test (--allow-failures 1) - - export CHUTNEY_ALLOW_FAILURES=1 + ## Quick smoke test, don't allow failures + - CHUTNEY_ALLOW_FAILURES=0 tools/test-network.sh --dry-run ## Different data directory - tools/test-network.sh --net-dir "$(mktemp -d)" ## IP address handling

1 0

[tor/release-0.3.5] Merge branch 'maint-0.3.5' into release-0.3.5
by teor＠torproject.org 13 Mar '20

13 Mar '20

commit 47e0ac3561aad79f1647d9d926277300ee78434f Merge: d8cef680f add387c50 Author: teor <teor(a)torproject.org> Date: Fri Mar 13 13:01:14 2020 +1000 Merge branch 'maint-0.3.5' into release-0.3.5 .travis.yml | 57 ++++++++++++++++++++++++++++++++--------------------- changes/ticket33194 | 4 ++++ changes/ticket33195 | 4 ++++ 3 files changed, 42 insertions(+), 23 deletions(-)

1 0

[tor/release-0.3.5] Travis: Remove a redundant distcheck job
by teor＠torproject.org 13 Mar '20

13 Mar '20

commit fc3555100f26201213f4da19d2d2904edc76a229 Author: teor <teor(a)torproject.org> Date: Thu Feb 13 13:22:19 2020 +1000 Travis: Remove a redundant distcheck job Part of 33194. --- .travis.yml | 4 ---- changes/ticket33194 | 2 ++ 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/.travis.yml b/.travis.yml index 323ebf5b3..38519db62 100644 --- a/.travis.yml +++ b/.travis.yml @@ -53,16 +53,12 @@ matrix: - env: CHUTNEY="yes" CHUTNEY_ALLOW_FAILURES="2" SKIP_MAKE_CHECK="yes" compiler: clang ## We check asciidoc with distcheck, to make sure we remove doc products - ## We use Linux clang, because there are no other Linux clang jobs - env: DISTCHECK="yes" ASCIIDOC_OPTIONS="" SKIP_MAKE_CHECK="yes" - compiler: clang ## We include a single coverage build with the best options for coverage - env: COVERAGE_OPTIONS="--enable-coverage" HARDENING_OPTIONS="" ## We run rust on Linux, because it's faster than rust on macOS ## We check rust offline - env: RUST_OPTIONS="--enable-rust" TOR_RUST_DEPENDENCIES=true - ## We check asciidoc with distcheck, to make sure we remove doc products - - env: DISTCHECK="yes" ASCIIDOC_OPTIONS="" SKIP_MAKE_CHECK="yes" ## We check disable module dirauth - env: MODULES_OPTIONS="--disable-module-dirauth" ## macOS builds are very slow, and we have a limited number of diff --git a/changes/ticket33194 b/changes/ticket33194 new file mode 100644 index 000000000..fd9efda51 --- /dev/null +++ b/changes/ticket33194 @@ -0,0 +1,2 @@ + o Testing: + - Remove a redundant distcheck job. Closes ticket 33194.

1 0

[tor/release-0.3.5] Travis: Sort jobs in order of speed
by teor＠torproject.org 13 Mar '20

13 Mar '20

commit add387c5071a1ee7889e3789e7b4143bb8856d0a Author: teor <teor(a)torproject.org> Date: Thu Feb 13 13:37:02 2020 +1000 Travis: Sort jobs in order of speed Putting the slowest jobs first takes full advantage of Travis concurrency. Closes 33194. --- .travis.yml | 47 ++++++++++++++++++++++++++++++----------------- changes/ticket33194 | 2 ++ 2 files changed, 32 insertions(+), 17 deletions(-) diff --git a/.travis.yml b/.travis.yml index 38519db62..6047c4470 100644 --- a/.travis.yml +++ b/.travis.yml @@ -39,28 +39,42 @@ env: matrix: ## include creates builds with gcc, linux, unless we override those defaults include: - ## We run basic tests on macOS + ## We run chutney on macOS, because macOS Travis has IPv6 + - env: CHUTNEY="yes" CHUTNEY_ALLOW_FAILURES="2" SKIP_MAKE_CHECK="yes" + os: osx + + ## We also run basic tests on macOS - compiler: clang os: osx ## Turn off some newer features, turn on clang's -Wtypedef-redefinition env: C_DIALECT_OPTIONS="-std=gnu99" - ## We check NSS - ## Use -std=gnu99 to turn off some newer features, and maybe turn on some - ## extra gcc warnings? - - env: NSS_OPTIONS="--enable-nss" C_DIALECT_OPTIONS="-std=gnu99" + ## We run chutney on Linux, because it's faster than chutney on macOS ## Chutney is a fast job, clang is slower on Linux, so we do Chutney clang - env: CHUTNEY="yes" CHUTNEY_ALLOW_FAILURES="2" SKIP_MAKE_CHECK="yes" compiler: clang + ## We check asciidoc with distcheck, to make sure we remove doc products - env: DISTCHECK="yes" ASCIIDOC_OPTIONS="" SKIP_MAKE_CHECK="yes" - ## We include a single coverage build with the best options for coverage - - env: COVERAGE_OPTIONS="--enable-coverage" HARDENING_OPTIONS="" + + ## We check disable module dirauth + - env: MODULES_OPTIONS="--disable-module-dirauth" + ## We run rust on Linux, because it's faster than rust on macOS ## We check rust offline - env: RUST_OPTIONS="--enable-rust" TOR_RUST_DEPENDENCIES=true - ## We check disable module dirauth - - env: MODULES_OPTIONS="--disable-module-dirauth" + + ## We check NSS + ## Use -std=gnu99 to turn off some newer features, and maybe turn on some + ## extra gcc warnings? + - env: NSS_OPTIONS="--enable-nss" C_DIALECT_OPTIONS="-std=gnu99" + + ## We include a single coverage build with the best options for coverage + - env: COVERAGE_OPTIONS="--enable-coverage" HARDENING_OPTIONS="" + + ## We clone our stem repo and run `make test-stem` + - env: TEST_STEM="yes" SKIP_MAKE_CHECK="yes" + ## macOS builds are very slow, and we have a limited number of ## concurrent macOS jobs. We're not actively developing Rust, so it is ## the lowest priority. @@ -68,11 +82,6 @@ matrix: #- env: RUST_OPTIONS="--enable-rust --enable-cargo-online-mode" # compiler: clang # os: osx - ## We run chutney on macOS, because macOS Travis has IPv6 - - env: CHUTNEY="yes" CHUTNEY_ALLOW_FAILURES="2" SKIP_MAKE_CHECK="yes" - os: osx - ## We clone our stem repo and run `make test-stem` - - env: TEST_STEM="yes" SKIP_MAKE_CHECK="yes" ## Allow the build to report success (with non-required sub-builds ## continuing to run) if all required sub-builds have succeeded. @@ -84,9 +93,13 @@ matrix: ## macOS rust and chutney are very slow, so we let the build finish before ## they are done. We'd like to fast finish, but still eventually show ## any failures in the build status. But Travis doesn't have that ability. - - env: RUST_OPTIONS="--enable-rust --enable-cargo-online-mode" - compiler: clang - os: osx + + ## Since this job is disabled, there's not much point having an exception + ## for it + #- env: RUST_OPTIONS="--enable-rust --enable-cargo-online-mode" + # compiler: clang + # os: osx + ## Since we're actively developing IPv6, we want to require the IPv6 ## chutney tests #- env: CHUTNEY="yes" CHUTNEY_ALLOW_FAILURES="2" SKIP_MAKE_CHECK="yes" diff --git a/changes/ticket33194 b/changes/ticket33194 index fd9efda51..b87e55348 100644 --- a/changes/ticket33194 +++ b/changes/ticket33194 @@ -1,2 +1,4 @@ o Testing: - Remove a redundant distcheck job. Closes ticket 33194. + - Sort the Travis jobs in order of speed. Putting the slowest jobs first + takes full advantage of Travis job concurrency. Closes ticket 33194.

1 0

[tor/release-0.4.1] Travis: Require the macOS IPv6 chutney job
by teor＠torproject.org 13 Mar '20

13 Mar '20

commit 03650e0f60ec37c758f90f3e02bf2ace05959a7e Author: teor <teor(a)torproject.org> Date: Thu Feb 13 13:13:40 2020 +1000 Travis: Require the macOS IPv6 chutney job The job was previously set to fast_finish / allow_failure, to speed up the build. Closes ticket 33195. --- .travis.yml | 6 ++++-- changes/ticket33195 | 4 ++++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index 28a45788b..323ebf5b3 100644 --- a/.travis.yml +++ b/.travis.yml @@ -91,8 +91,10 @@ matrix: - env: RUST_OPTIONS="--enable-rust --enable-cargo-online-mode" compiler: clang os: osx - - env: CHUTNEY="yes" CHUTNEY_ALLOW_FAILURES="2" SKIP_MAKE_CHECK="yes" - os: osx + ## Since we're actively developing IPv6, we want to require the IPv6 + ## chutney tests + #- env: CHUTNEY="yes" CHUTNEY_ALLOW_FAILURES="2" SKIP_MAKE_CHECK="yes" + # os: osx ## (Linux only) Use a recent Linux image (Ubuntu Bionic) dist: bionic diff --git a/changes/ticket33195 b/changes/ticket33195 new file mode 100644 index 000000000..11abd4816 --- /dev/null +++ b/changes/ticket33195 @@ -0,0 +1,4 @@ + o Testing: + - Stop allowing the Chutney IPv6 Travis job to fail. This job was + previously configured to fast_finish (which requires allow_failure), to + speed up the build. Closes ticket 33195.

1 0

[tor/release-0.3.5] Travis: Require the macOS IPv6 chutney job
by teor＠torproject.org 13 Mar '20

13 Mar '20

commit 03650e0f60ec37c758f90f3e02bf2ace05959a7e Author: teor <teor(a)torproject.org> Date: Thu Feb 13 13:13:40 2020 +1000 Travis: Require the macOS IPv6 chutney job The job was previously set to fast_finish / allow_failure, to speed up the build. Closes ticket 33195. --- .travis.yml | 6 ++++-- changes/ticket33195 | 4 ++++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index 28a45788b..323ebf5b3 100644 --- a/.travis.yml +++ b/.travis.yml @@ -91,8 +91,10 @@ matrix: - env: RUST_OPTIONS="--enable-rust --enable-cargo-online-mode" compiler: clang os: osx - - env: CHUTNEY="yes" CHUTNEY_ALLOW_FAILURES="2" SKIP_MAKE_CHECK="yes" - os: osx + ## Since we're actively developing IPv6, we want to require the IPv6 + ## chutney tests + #- env: CHUTNEY="yes" CHUTNEY_ALLOW_FAILURES="2" SKIP_MAKE_CHECK="yes" + # os: osx ## (Linux only) Use a recent Linux image (Ubuntu Bionic) dist: bionic diff --git a/changes/ticket33195 b/changes/ticket33195 new file mode 100644 index 000000000..11abd4816 --- /dev/null +++ b/changes/ticket33195 @@ -0,0 +1,4 @@ + o Testing: + - Stop allowing the Chutney IPv6 Travis job to fail. This job was + previously configured to fast_finish (which requires allow_failure), to + speed up the build. Closes ticket 33195.

1 0

[tor/release-0.4.1] Travis: Remove a redundant distcheck job
by teor＠torproject.org 13 Mar '20

13 Mar '20

commit fc3555100f26201213f4da19d2d2904edc76a229 Author: teor <teor(a)torproject.org> Date: Thu Feb 13 13:22:19 2020 +1000 Travis: Remove a redundant distcheck job Part of 33194. --- .travis.yml | 4 ---- changes/ticket33194 | 2 ++ 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/.travis.yml b/.travis.yml index 323ebf5b3..38519db62 100644 --- a/.travis.yml +++ b/.travis.yml @@ -53,16 +53,12 @@ matrix: - env: CHUTNEY="yes" CHUTNEY_ALLOW_FAILURES="2" SKIP_MAKE_CHECK="yes" compiler: clang ## We check asciidoc with distcheck, to make sure we remove doc products - ## We use Linux clang, because there are no other Linux clang jobs - env: DISTCHECK="yes" ASCIIDOC_OPTIONS="" SKIP_MAKE_CHECK="yes" - compiler: clang ## We include a single coverage build with the best options for coverage - env: COVERAGE_OPTIONS="--enable-coverage" HARDENING_OPTIONS="" ## We run rust on Linux, because it's faster than rust on macOS ## We check rust offline - env: RUST_OPTIONS="--enable-rust" TOR_RUST_DEPENDENCIES=true - ## We check asciidoc with distcheck, to make sure we remove doc products - - env: DISTCHECK="yes" ASCIIDOC_OPTIONS="" SKIP_MAKE_CHECK="yes" ## We check disable module dirauth - env: MODULES_OPTIONS="--disable-module-dirauth" ## macOS builds are very slow, and we have a limited number of diff --git a/changes/ticket33194 b/changes/ticket33194 new file mode 100644 index 000000000..fd9efda51 --- /dev/null +++ b/changes/ticket33194 @@ -0,0 +1,2 @@ + o Testing: + - Remove a redundant distcheck job. Closes ticket 33194.

1 0

[tor/release-0.4.2] Travis: Remove a redundant distcheck job
by teor＠torproject.org 13 Mar '20

13 Mar '20

commit fc3555100f26201213f4da19d2d2904edc76a229 Author: teor <teor(a)torproject.org> Date: Thu Feb 13 13:22:19 2020 +1000 Travis: Remove a redundant distcheck job Part of 33194. --- .travis.yml | 4 ---- changes/ticket33194 | 2 ++ 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/.travis.yml b/.travis.yml index 323ebf5b3..38519db62 100644 --- a/.travis.yml +++ b/.travis.yml @@ -53,16 +53,12 @@ matrix: - env: CHUTNEY="yes" CHUTNEY_ALLOW_FAILURES="2" SKIP_MAKE_CHECK="yes" compiler: clang ## We check asciidoc with distcheck, to make sure we remove doc products - ## We use Linux clang, because there are no other Linux clang jobs - env: DISTCHECK="yes" ASCIIDOC_OPTIONS="" SKIP_MAKE_CHECK="yes" - compiler: clang ## We include a single coverage build with the best options for coverage - env: COVERAGE_OPTIONS="--enable-coverage" HARDENING_OPTIONS="" ## We run rust on Linux, because it's faster than rust on macOS ## We check rust offline - env: RUST_OPTIONS="--enable-rust" TOR_RUST_DEPENDENCIES=true - ## We check asciidoc with distcheck, to make sure we remove doc products - - env: DISTCHECK="yes" ASCIIDOC_OPTIONS="" SKIP_MAKE_CHECK="yes" ## We check disable module dirauth - env: MODULES_OPTIONS="--disable-module-dirauth" ## macOS builds are very slow, and we have a limited number of diff --git a/changes/ticket33194 b/changes/ticket33194 new file mode 100644 index 000000000..fd9efda51 --- /dev/null +++ b/changes/ticket33194 @@ -0,0 +1,2 @@ + o Testing: + - Remove a redundant distcheck job. Closes ticket 33194.

1 0