October 2020 - tor-commits - lists.torproject.org

[tor/maint-0.4.3] Treat all extorport connections with un-set addresses as remote
by nickm＠torproject.org 07 Oct '20

07 Oct '20

commit ceb6585a4bc2beadde2fb194395711e72ee8559d Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Jul 22 15:20:41 2020 -0400 Treat all extorport connections with un-set addresses as remote Without this fix, if an PT forgets to send a USERADDR command, that results in a connection getting treated as local for the purposes of rate-limiting. If the PT _does_ use USERADDR, we still believe it. Closes ticket 33747. --- changes/ticket33747 | 7 +++++++ src/core/mainloop/connection.c | 7 ++++++- src/core/or/connection_st.h | 3 +++ src/feature/relay/ext_orport.c | 5 ++++- 4 files changed, 20 insertions(+), 2 deletions(-) diff --git a/changes/ticket33747 b/changes/ticket33747 new file mode 100644 index 0000000000..57c72e9d0a --- /dev/null +++ b/changes/ticket33747 @@ -0,0 +1,7 @@ + o Minor bugfixes (rate limiting, bridges, pluggable transports): + - On a bridge, treat all connections from an ExtORPort as remote + by default for the purposes of rate-limiting. Previously, + bridges would treat the connection as local unless they explicitly + received a "USERADDR" command. ExtORPort connections still + count as local if there is a USERADDR command with an explicit local + address. Fixes bug 33747; bugfix on 0.2.5.1-alpha. diff --git a/src/core/mainloop/connection.c b/src/core/mainloop/connection.c index 3595bba85c..e895f8a73d 100644 --- a/src/core/mainloop/connection.c +++ b/src/core/mainloop/connection.c @@ -379,8 +379,12 @@ or_connection_new(int type, int socket_family) connection_or_set_canonical(or_conn, 0); - if (type == CONN_TYPE_EXT_OR) + if (type == CONN_TYPE_EXT_OR) { + /* If we aren't told an address for this connection, we should + * presume it isn't local, and should be rate-limited. */ + TO_CONN(or_conn)->always_rate_limit_as_remote = 1; connection_or_set_ext_or_identifier(or_conn); + } return or_conn; } @@ -3025,6 +3029,7 @@ connection_is_rate_limited(connection_t *conn) if (conn->linked) return 0; /* Internal connection */ else if (! options->CountPrivateBandwidth && + ! conn->always_rate_limit_as_remote && (tor_addr_family(&conn->addr) == AF_UNSPEC || /* no address */ tor_addr_family(&conn->addr) == AF_UNIX || /* no address */ tor_addr_is_internal(&conn->addr, 0))) diff --git a/src/core/or/connection_st.h b/src/core/or/connection_st.h index d1430eda14..c197a81340 100644 --- a/src/core/or/connection_st.h +++ b/src/core/or/connection_st.h @@ -64,6 +64,9 @@ struct connection_t { /** True if connection_handle_write is currently running on this connection. */ unsigned int in_connection_handle_write:1; + /** If true, then we treat this connection as remote for the purpose of + * rate-limiting, no matter what its address is. */ + unsigned int always_rate_limit_as_remote:1; /* For linked connections: */ diff --git a/src/feature/relay/ext_orport.c b/src/feature/relay/ext_orport.c index 56c5bb96f5..136aee3084 100644 --- a/src/feature/relay/ext_orport.c +++ b/src/feature/relay/ext_orport.c @@ -494,6 +494,10 @@ connection_ext_or_handle_cmd_useraddr(connection_t *conn, } conn->address = tor_addr_to_str_dup(&addr); + /* Now that we know the address, we don't have to manually override rate + * limiting. */ + conn->always_rate_limit_as_remote = 0; + return 0; } @@ -659,4 +663,3 @@ ext_orport_free_all(void) if (ext_or_auth_cookie) /* Free the auth cookie */ tor_free(ext_or_auth_cookie); } -

1 0

[tor/maint-0.4.3] Merge branch 'maint-0.3.5' into maint-0.4.3
by nickm＠torproject.org 07 Oct '20

07 Oct '20

commit 701a1936fae48c6887cadd90dbe50ae84a00a29f Merge: a49373844c ad7ffa5240 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Oct 7 08:26:04 2020 -0400 Merge branch 'maint-0.3.5' into maint-0.4.3 changes/ticket33747 | 7 +++++++ src/core/mainloop/connection.c | 7 ++++++- src/core/or/connection_st.h | 3 +++ src/feature/relay/ext_orport.c | 4 ++++ 4 files changed, 20 insertions(+), 1 deletion(-)

1 0

[tor/maint-0.4.4] Merge branch 'maint-0.4.3' into maint-0.4.4
by nickm＠torproject.org 07 Oct '20

07 Oct '20

commit ad62cf2ac9100c66dcd51f0adbb22ff4bc64faa4 Merge: a44bcc309d 701a1936fa Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Oct 7 08:26:04 2020 -0400 Merge branch 'maint-0.4.3' into maint-0.4.4

1 0

[tor/maint-0.4.4] Merge branch 'maint-0.3.5' into maint-0.4.3
by nickm＠torproject.org 07 Oct '20

07 Oct '20

commit 701a1936fae48c6887cadd90dbe50ae84a00a29f Merge: a49373844c ad7ffa5240 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Oct 7 08:26:04 2020 -0400 Merge branch 'maint-0.3.5' into maint-0.4.3 changes/ticket33747 | 7 +++++++ src/core/mainloop/connection.c | 7 ++++++- src/core/or/connection_st.h | 3 +++ src/feature/relay/ext_orport.c | 4 ++++ 4 files changed, 20 insertions(+), 1 deletion(-)

1 0

[tor/maint-0.4.4] Merge remote-tracking branch 'tor-gitlab/mr/79' into maint-0.3.5
by nickm＠torproject.org 07 Oct '20

07 Oct '20

commit ad7ffa5240c4b3a9b675a12f0705d9cbe0bc8beb Merge: 98e14720b5 ceb6585a4b Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Oct 7 08:25:55 2020 -0400 Merge remote-tracking branch 'tor-gitlab/mr/79' into maint-0.3.5 changes/ticket33747 | 7 +++++++ src/core/mainloop/connection.c | 7 ++++++- src/core/or/connection_st.h | 3 +++ src/feature/relay/ext_orport.c | 5 ++++- 4 files changed, 20 insertions(+), 2 deletions(-)

1 0

[translation/whisperback] https://gitweb.torproject.org/translation.git/commit/?h=whisperback
by translation＠torproject.org 07 Oct '20

07 Oct '20

commit 46052d0f91ee8aea9468a5feca12676ebfc05e5e Author: Translation commit bot <translation(a)torproject.org> Date: Wed Oct 7 12:18:28 2020 +0000 https://gitweb.torproject.org/translation.git/commit/?h=whisperback --- sw/sw.po | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sw/sw.po b/sw/sw.po index 9fe8c481ae..1191666ccb 100644 --- a/sw/sw.po +++ b/sw/sw.po @@ -9,7 +9,7 @@ msgstr "" "Project-Id-Version: Tor Project\n" "Report-Msgid-Bugs-To: \n" "POT-Creation-Date: 2019-04-29 12:08+0200\n" -"PO-Revision-Date: 2020-10-07 08:49+0000\n" +"PO-Revision-Date: 2020-10-07 12:15+0000\n" "Last-Translator: Zaituni Njovu <zaituni(a)zainafoundationtz.org>\n" "Language-Team: Swahili (http://www.transifex.com/otf/torproject/language/sw/)\n" "MIME-Version: 1.0\n" @@ -42,7 +42,7 @@ msgstr "" #: ../whisperBack/gui.py:114 msgid "Name of the affected software" -msgstr "" +msgstr "Majina yalio athiriwa na softi wea" #: ../whisperBack/gui.py:116 msgid "Exact steps to reproduce the error" @@ -54,7 +54,7 @@ msgstr "" #: ../whisperBack/gui.py:120 msgid "Desired result" -msgstr "" +msgstr "Matokeo pendwa" #: ../whisperBack/gui.py:133 msgid "Unable to load a valid configuration."

1 0

[translation/torbutton-securitylevelproperties] https://gitweb.torproject.org/translation.git/commit/?h=torbutton-securitylevelproperties
by translation＠torproject.org 07 Oct '20

07 Oct '20

commit 11bcbb62c9e8177dcc6a3eb06fb2fc7636be9552 Author: Translation commit bot <translation(a)torproject.org> Date: Wed Oct 7 12:18:06 2020 +0000 https://gitweb.torproject.org/translation.git/commit/?h=torbutton-securityl… --- sw/securitylevel.properties | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sw/securitylevel.properties b/sw/securitylevel.properties index 0eb5045315..a982bfa077 100644 --- a/sw/securitylevel.properties +++ b/sw/securitylevel.properties @@ -12,11 +12,11 @@ securityLevel.safer.description2 = Baadhi ya mwandiko na alama za hesabu zimezui securityLevel.safer.description3 = Sauti na video (HTML5 vyombo vya habari), na WebGL gusa kucheza. securityLevel.safest.level = Salama securityLevel.safest.tooltip = Ngazi ya usalama: Salama -securityLevel.safest.summary = Only allows website features required for static sites and basic services. These changes affect images, media, and scripts. +securityLevel.safest.summary = Kuruhusu sifa ya tofuti tu inayohitajika kwa takwimu ya tovuti na huduma za msingi. Haya mabadiliko yana yanaathiri picha, media, na maandishi. securityLevel.safest.description1 = JavaScript imezuiwa moja kwa moja kwa tovuti zote. securityLevel.safest.description2 = Baadhi ya mwandiko, ikoni, alama za hesabu, na picha zimezuiwa. securityLevel.safest.description3 = Sauti na video (HTML5 vyombo vya habari) guza kucheza. -securityLevel.custom.summary = Your custom browser preferences have resulted in unusual security settings. For security and privacy reasons, we recommend you choose one of the default security levels. +securityLevel.custom.summary = Desturi yako ya kivinjari yanapelekea matokeo yasiyo ya kawaida ya usalama wa mipangilio. Kwa usalama na sababu za kifaragha, tunapendekeza chaguo lako moja kwa chaguo-msingi la usawa wa usalama. securityLevel.learnMore = Kujifunza zaidi securityLevel.restoreDefaults = Kurejesha defaults securityLevel.advancedSecuritySettings = Mipangilio ya usalama wa juu.

1 0

[translation/torbutton-browseronboardingproperties] https://gitweb.torproject.org/translation.git/commit/?h=torbutton-browseronboardingproperties
by translation＠torproject.org 07 Oct '20

07 Oct '20

commit ebb7d980be3baf8cea043c0994c3087f10009a2b Author: Translation commit bot <translation(a)torproject.org> Date: Wed Oct 7 12:18:02 2020 +0000 https://gitweb.torproject.org/translation.git/commit/?h=torbutton-browseron… --- sw/browserOnboarding.properties | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sw/browserOnboarding.properties b/sw/browserOnboarding.properties index 09544ed8ab..49a4448be4 100644 --- a/sw/browserOnboarding.properties +++ b/sw/browserOnboarding.properties @@ -28,15 +28,15 @@ onboarding.tour-tor-circuit-display.next-button=nenda kwenye ulinzi onboarding.tour-tor-security=Ulizi onboarding.tour-tor-security.title=chagua uzoefu wako onboarding.tour-tor-security.description=tunakupatia pia nyongeza ya mipangilio kwa kubonyeza juu ya usalama wa kivinjari chako -onboarding.tour-tor-security.description-suffix=Zingatia: kwa chaguo msingi hakuna walaka na HITTPS kila mahali ambazo hazijajumuishwa kwenye mwambaa zana -onboarding.tour-tor-security-level.button=See Your Security Level +onboarding.tour-tor-security.description-suffix=Zingatia: kwa chaguo-msingi hakuna walaka na 'https' kila mahali ambazo hazijajumuishwa kwenye mwambaa zana +onboarding.tour-tor-security-level.button=angalia kiwango cha usalama wako onboarding.tour-tor-security-level.next-button=Go to Experience Tips onboarding.tour-tor-expect-differences=Vidokezo vya uzoefu onboarding.tour-tor-expect-differences.title=Tarajia tofauti baadhi. -onboarding.tour-tor-expect-differences.description=With all the security and privacy features provided by Tor, your experience while browsing the internet may be a little different. Things may be a bit slower, and depending on your security level, some elements may not work or load. You may also be asked to prove you are a human and not a robot. -onboarding.tour-tor-expect-differences.button=See FAQs -onboarding.tour-tor-expect-differences.next-button=Go to Onion Services +onboarding.tour-tor-expect-differences.description=kwa vipengele vyote vya ulinzi na usalama vinavyotolewa na Tor, uzoefu wako wakati wa kuvinjari unaweza kuwa tofauti kidogo. mambo yanaweza kuwa polepole kiasi kwa kutegemea kiwango cha usalama wako, baadhi ya vipengele vinaweza visifanye kazi au visipakie. unaweza pia kuulizwa kujihakiki kuwa ni binadamu na siyo roboti. +onboarding.tour-tor-expect-differences.button=angalia MYM +onboarding.tour-tor-expect-differences.next-button=nenda kwenye huduma za onion onboarding.tour-tor-onion-services=Huduma za Onion onboarding.tour-tor-onion-services.title=Kuwa na ulinzi zaidi.

1 0

[translation/torbutton-torbuttondtd] https://gitweb.torproject.org/translation.git/commit/?h=torbutton-torbuttondtd
by translation＠torproject.org 07 Oct '20

07 Oct '20

commit 56ca5e5fe802f0373096212c9c5ac96b2b8f580b Author: Translation commit bot <translation(a)torproject.org> Date: Wed Oct 7 12:17:54 2020 +0000 https://gitweb.torproject.org/translation.git/commit/?h=torbutton-torbutton… --- sw/torbutton.dtd | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sw/torbutton.dtd b/sw/torbutton.dtd index 61bd12fdb8..5faec7caa0 100644 --- a/sw/torbutton.dtd +++ b/sw/torbutton.dtd @@ -29,7 +29,7 @@ <!ENTITY torbutton.prefs.sec_safer_description "Makala za tovuti zilizozuiwa mara nyingi ni hatari, husababisha baadhi ya tovuti kukosa utendaji."> <!ENTITY torbutton.prefs.sec_safer_list_label "At the safer setting:"> <!ENTITY torbutton.prefs.sec_safest_label "Salama"> -<!ENTITY torbutton.prefs.sec_safest_description "Only allows website features required for static sites and basic services. These changes affect images, media, and scripts."> +<!ENTITY torbutton.prefs.sec_safest_description "Kuruhusu sifa ya tofuti tu inayohitajika kwa takwimu ya tovuti na huduma za msingi. Haya mabadiliko yana yanaathiri picha, media, na maandishi."> <!ENTITY torbutton.prefs.sec_safest_list_label "At the safest setting:"> <!ENTITY torbutton.prefs.sec_learn_more_label "Kujifunza zaidi"> <!ENTITY torbutton.prefs.sec_js_on_https_sites_only "JavaScript imezuiwa kwenye tovuti ambazo sio HTTPS."> @@ -42,7 +42,7 @@ <!ENTITY torbutton.prefs.sec_standard_tooltip "Ngazi ya usalama : Kiwango"> <!ENTITY torbutton.prefs.sec_safer_tooltip "Ngazi ya usalama : Salama"> <!ENTITY torbutton.prefs.sec_safest_tooltip "Ngazi ya usalama: Salama"> -<!ENTITY torbutton.prefs.sec_custom_summary "Your custom browser preferences have resulted in unusual security settings. For security and privacy reasons, we recommend you choose one of the default security levels."> +<!ENTITY torbutton.prefs.sec_custom_summary "Desturi yako ya kivinjari yanapelekea matokeo yasiyo ya kawaida ya usalama wa mipangilio. Kwa usalama na sababu za kifaragha, tunapendekeza chaguo lako moja kwa chaguo-msingi la usawa wa usalama."> <!ENTITY torbutton.prefs.sec_restore_defaults "Kurejesha defaults"> <!ENTITY torbutton.prefs.sec_advanced_security_settings "Mipangilio ya usalama wa juu."> <!ENTITY torbutton.circuit_display.title "Mzunguko wa Tor">

1 0

[translation/tails-openpgp-applet] https://gitweb.torproject.org/translation.git/commit/?h=tails-openpgp-applet
by translation＠torproject.org 07 Oct '20

07 Oct '20

commit 94789161cdb12fffdd8c88c1017e4e0741dff794 Author: Translation commit bot <translation(a)torproject.org> Date: Wed Oct 7 12:16:51 2020 +0000 https://gitweb.torproject.org/translation.git/commit/?h=tails-openpgp-applet --- sw/openpgp-applet.pot | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/sw/openpgp-applet.pot b/sw/openpgp-applet.pot index 7e67c93d61..5f09102ad8 100644 --- a/sw/openpgp-applet.pot +++ b/sw/openpgp-applet.pot @@ -9,7 +9,7 @@ msgstr "" "Project-Id-Version: Tor Project\n" "Report-Msgid-Bugs-To: tails(a)boum.org\n" "POT-Creation-Date: 2017-08-05 15:07-0400\n" -"PO-Revision-Date: 2020-10-07 11:44+0000\n" +"PO-Revision-Date: 2020-10-07 12:13+0000\n" "Last-Translator: Zaituni Njovu <zaituni(a)zainafoundationtz.org>\n" "Language-Team: Swahili (http://www.transifex.com/otf/torproject/language/sw/)\n" "MIME-Version: 1.0\n" @@ -56,23 +56,23 @@ msgstr "_Fungua kihariri ujumbe" #: bin/openpgp-applet:292 msgid "The clipboard does not contain valid input data." -msgstr "" +msgstr "Klipubodi haina kiingizio cha data sahihi." #: bin/openpgp-applet:337 bin/openpgp-applet:339 bin/openpgp-applet:341 msgid "Unknown Trust" -msgstr "" +msgstr "Uaminifu usiojulikana" #: bin/openpgp-applet:343 msgid "Marginal Trust" -msgstr "" +msgstr "Uaminifu wenye mpaka" #: bin/openpgp-applet:345 msgid "Full Trust" -msgstr "" +msgstr "uaminifu kamili" #: bin/openpgp-applet:347 msgid "Ultimate Trust" -msgstr "" +msgstr "Uaminifu wa mwisho" #: bin/openpgp-applet:400 msgid "Name" @@ -80,7 +80,7 @@ msgstr "Jina" #: bin/openpgp-applet:401 msgid "Key ID" -msgstr "" +msgstr "Ufunguo tambuzi" #: bin/openpgp-applet:402 msgid "Status" @@ -93,26 +93,26 @@ msgstr "Alama za kidole" #: bin/openpgp-applet:436 msgid "User ID:" msgid_plural "User IDs:" -msgstr[0] "" -msgstr[1] "" +msgstr[0] "Kitambulisho cha Mtumiaji" +msgstr[1] "Mtumiaji wa kitambulisho" #: bin/openpgp-applet:465 msgid "None (Don't sign)" -msgstr "" +msgstr "Haipo (usijiunge)" #: bin/openpgp-applet:528 msgid "Select recipients:" -msgstr "" +msgstr "Chagua wapokeaji;" #: bin/openpgp-applet:536 msgid "Hide recipients" -msgstr "" +msgstr "Ficha wapokeaji" #: bin/openpgp-applet:539 msgid "" "Hide the user IDs of all recipients of an encrypted message. Otherwise " "anyone that sees the encrypted message can see who the recipients are." -msgstr "" +msgstr "Ficha vitambulisho vyote vya wapokeaji wa meseji ficho. La sivyo mtumiaji yeyote anaweza akaona wapokeaji wa meseji ficho." #: bin/openpgp-applet:545 msgid "Sign message as:" @@ -120,11 +120,11 @@ msgstr "" #: bin/openpgp-applet:549 msgid "Choose keys" -msgstr "" +msgstr "Chagua funguo" #: bin/openpgp-applet:589 msgid "Do you trust these keys?" -msgstr "" +msgstr "Unaziamini funguo hizi?" #: bin/openpgp-applet:592 msgid "The following selected key is not fully trusted:"

1 0