January 2020 - tor-commits - lists.torproject.org

[tor/maint-0.4.2] Fix sandbox crash during reload of logging configuration
by nickm＠torproject.org 06 Jan '20

06 Jan '20

commit b9d81282e0dbfdae795b38c26879716d7860bcf9 Author: Peter Gerber <pgerber(a)tocco.ch> Date: Sun Jan 5 15:48:54 2020 +0100 Fix sandbox crash during reload of logging configuration Allow calls to dup() which was introduced in commit a22fbab986. From a security perspective, I don't think this should impact the security of the sandbox significantly. As far as I can tell, there is nothing an adversary can do with a duplicated FD that can't be done with the original. --- changes/bug32877 | 4 ++++ src/lib/sandbox/sandbox.c | 1 + 2 files changed, 5 insertions(+) diff --git a/changes/bug32877 b/changes/bug32877 new file mode 100644 index 000000000..96fe1af70 --- /dev/null +++ b/changes/bug32877 @@ -0,0 +1,4 @@ +o Minor bugfixes (linux seccomp sandbox): + - Fix crash when reloading logging configuration while the + experimental sandbox is enabled. Fixes bug 29150; bugfix + on 0.4.1.7. Patch by Peter Gerber. diff --git a/src/lib/sandbox/sandbox.c b/src/lib/sandbox/sandbox.c index faaf463f2..7e6354d88 100644 --- a/src/lib/sandbox/sandbox.c +++ b/src/lib/sandbox/sandbox.c @@ -143,6 +143,7 @@ static int filter_nopar_gen[] = { SCMP_SYS(clock_gettime), SCMP_SYS(close), SCMP_SYS(clone), + SCMP_SYS(dup), SCMP_SYS(epoll_create), SCMP_SYS(epoll_wait), #ifdef __NR_epoll_pwait

1 0

[tor/maint-0.4.2] update changes file to pass "make check-changes"
by nickm＠torproject.org 06 Jan '20

06 Jan '20

commit f5461a4bdf343a0572b0594fa33af37ce1be9d8f Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Jan 6 08:08:48 2020 -0500 update changes file to pass "make check-changes" --- changes/bug32841 | 4 ++++ changes/bug32877 | 4 ---- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/changes/bug32841 b/changes/bug32841 new file mode 100644 index 000000000..48568f6a6 --- /dev/null +++ b/changes/bug32841 @@ -0,0 +1,4 @@ + o Minor bugfixes (linux seccomp sandbox): + - Fix crash when reloading logging configuration while the + experimental sandbox is enabled. Fixes bug 32841; bugfix + on 0.4.1.7. Patch by Peter Gerber. diff --git a/changes/bug32877 b/changes/bug32877 deleted file mode 100644 index 96fe1af70..000000000 --- a/changes/bug32877 +++ /dev/null @@ -1,4 +0,0 @@ -o Minor bugfixes (linux seccomp sandbox): - - Fix crash when reloading logging configuration while the - experimental sandbox is enabled. Fixes bug 29150; bugfix - on 0.4.1.7. Patch by Peter Gerber.

1 0

[tor/maint-0.4.2] Merge branch 'maint-0.4.1' into maint-0.4.2
by nickm＠torproject.org 06 Jan '20

06 Jan '20

commit 16e94dc7a70e90fe7a1617ffeef817f3394fe382 Merge: 5dbb607e9 b9d81282e Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Jan 6 08:06:54 2020 -0500 Merge branch 'maint-0.4.1' into maint-0.4.2 changes/bug32877 | 4 ++++ src/lib/sandbox/sandbox.c | 1 + 2 files changed, 5 insertions(+)

1 0

[tor/maint-0.4.2] Merge branch 'maint-0.4.1' into maint-0.4.2
by nickm＠torproject.org 06 Jan '20

06 Jan '20

commit 2d8d6d1ebfd62ebc6da931170d949d8c02f67b76 Merge: 16e94dc7a f5461a4bd Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Jan 6 08:08:59 2020 -0500 Merge branch 'maint-0.4.1' into maint-0.4.2 changes/bug32841 | 4 ++++ changes/bug32877 | 4 ---- 2 files changed, 4 insertions(+), 4 deletions(-)

1 0

[tor/master] Fix sandbox crash during reload of logging configuration
by nickm＠torproject.org 06 Jan '20

06 Jan '20

commit b9d81282e0dbfdae795b38c26879716d7860bcf9 Author: Peter Gerber <pgerber(a)tocco.ch> Date: Sun Jan 5 15:48:54 2020 +0100 Fix sandbox crash during reload of logging configuration Allow calls to dup() which was introduced in commit a22fbab986. From a security perspective, I don't think this should impact the security of the sandbox significantly. As far as I can tell, there is nothing an adversary can do with a duplicated FD that can't be done with the original. --- changes/bug32877 | 4 ++++ src/lib/sandbox/sandbox.c | 1 + 2 files changed, 5 insertions(+) diff --git a/changes/bug32877 b/changes/bug32877 new file mode 100644 index 000000000..96fe1af70 --- /dev/null +++ b/changes/bug32877 @@ -0,0 +1,4 @@ +o Minor bugfixes (linux seccomp sandbox): + - Fix crash when reloading logging configuration while the + experimental sandbox is enabled. Fixes bug 29150; bugfix + on 0.4.1.7. Patch by Peter Gerber. diff --git a/src/lib/sandbox/sandbox.c b/src/lib/sandbox/sandbox.c index faaf463f2..7e6354d88 100644 --- a/src/lib/sandbox/sandbox.c +++ b/src/lib/sandbox/sandbox.c @@ -143,6 +143,7 @@ static int filter_nopar_gen[] = { SCMP_SYS(clock_gettime), SCMP_SYS(close), SCMP_SYS(clone), + SCMP_SYS(dup), SCMP_SYS(epoll_create), SCMP_SYS(epoll_wait), #ifdef __NR_epoll_pwait

1 0

[tor/master] update changes file to pass "make check-changes"
by nickm＠torproject.org 06 Jan '20

06 Jan '20

commit f5461a4bdf343a0572b0594fa33af37ce1be9d8f Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Jan 6 08:08:48 2020 -0500 update changes file to pass "make check-changes" --- changes/bug32841 | 4 ++++ changes/bug32877 | 4 ---- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/changes/bug32841 b/changes/bug32841 new file mode 100644 index 000000000..48568f6a6 --- /dev/null +++ b/changes/bug32841 @@ -0,0 +1,4 @@ + o Minor bugfixes (linux seccomp sandbox): + - Fix crash when reloading logging configuration while the + experimental sandbox is enabled. Fixes bug 32841; bugfix + on 0.4.1.7. Patch by Peter Gerber. diff --git a/changes/bug32877 b/changes/bug32877 deleted file mode 100644 index 96fe1af70..000000000 --- a/changes/bug32877 +++ /dev/null @@ -1,4 +0,0 @@ -o Minor bugfixes (linux seccomp sandbox): - - Fix crash when reloading logging configuration while the - experimental sandbox is enabled. Fixes bug 29150; bugfix - on 0.4.1.7. Patch by Peter Gerber.

1 0

[tor/master] Merge branch 'maint-0.4.1' into maint-0.4.2
by nickm＠torproject.org 06 Jan '20

06 Jan '20

commit 16e94dc7a70e90fe7a1617ffeef817f3394fe382 Merge: 5dbb607e9 b9d81282e Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Jan 6 08:06:54 2020 -0500 Merge branch 'maint-0.4.1' into maint-0.4.2 changes/bug32877 | 4 ++++ src/lib/sandbox/sandbox.c | 1 + 2 files changed, 5 insertions(+)

1 0

[tor/master] Merge branch 'maint-0.4.1' into maint-0.4.2
by nickm＠torproject.org 06 Jan '20

06 Jan '20

commit 2d8d6d1ebfd62ebc6da931170d949d8c02f67b76 Merge: 16e94dc7a f5461a4bd Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Jan 6 08:08:59 2020 -0500 Merge branch 'maint-0.4.1' into maint-0.4.2 changes/bug32841 | 4 ++++ changes/bug32877 | 4 ---- 2 files changed, 4 insertions(+), 4 deletions(-)

1 0

[tor/master] Merge branch 'maint-0.4.2'
by nickm＠torproject.org 06 Jan '20

06 Jan '20

commit 13216f848a120760fa372b9ae8f6d0840f4a83ba Merge: b062e0f0a 2d8d6d1eb Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Jan 6 08:08:59 2020 -0500 Merge branch 'maint-0.4.2' changes/bug32841 | 4 ++++ src/lib/sandbox/sandbox.c | 1 + 2 files changed, 5 insertions(+)

1 0

[tor/release-0.4.1] Fix sandbox crash during reload of logging configuration
by nickm＠torproject.org 06 Jan '20

06 Jan '20

commit b9d81282e0dbfdae795b38c26879716d7860bcf9 Author: Peter Gerber <pgerber(a)tocco.ch> Date: Sun Jan 5 15:48:54 2020 +0100 Fix sandbox crash during reload of logging configuration Allow calls to dup() which was introduced in commit a22fbab986. From a security perspective, I don't think this should impact the security of the sandbox significantly. As far as I can tell, there is nothing an adversary can do with a duplicated FD that can't be done with the original. --- changes/bug32877 | 4 ++++ src/lib/sandbox/sandbox.c | 1 + 2 files changed, 5 insertions(+) diff --git a/changes/bug32877 b/changes/bug32877 new file mode 100644 index 000000000..96fe1af70 --- /dev/null +++ b/changes/bug32877 @@ -0,0 +1,4 @@ +o Minor bugfixes (linux seccomp sandbox): + - Fix crash when reloading logging configuration while the + experimental sandbox is enabled. Fixes bug 29150; bugfix + on 0.4.1.7. Patch by Peter Gerber. diff --git a/src/lib/sandbox/sandbox.c b/src/lib/sandbox/sandbox.c index faaf463f2..7e6354d88 100644 --- a/src/lib/sandbox/sandbox.c +++ b/src/lib/sandbox/sandbox.c @@ -143,6 +143,7 @@ static int filter_nopar_gen[] = { SCMP_SYS(clock_gettime), SCMP_SYS(close), SCMP_SYS(clone), + SCMP_SYS(dup), SCMP_SYS(epoll_create), SCMP_SYS(epoll_wait), #ifdef __NR_epoll_pwait

1 0