June 2019 - tor-commits - lists.torproject.org

[tor/maint-0.4.0] Merge branch 'bug30713_035' into bug30713_040
by nickm＠torproject.org 11 Jun '19

11 Jun '19

commit 430dd2da6e97c7186b03caabbbac95d74c3d8b82 Merge: 6a6f7eb67 be0a4be27 Author: teor <teor(a)torproject.org> Date: Mon Jun 10 20:50:53 2019 +1000 Merge branch 'bug30713_035' into bug30713_040 .travis.yml | 2 ++ changes/bug30713 | 5 +++++ src/test/test_rebind.py | 7 +++++++ src/test/test_rebind.sh | 4 ++-- 4 files changed, 16 insertions(+), 2 deletions(-) diff --cc src/test/test_rebind.py index 7b12626a9,77829ca92..232b20032 --- a/src/test/test_rebind.py +++ b/src/test/test_rebind.py @@@ -16,12 -16,15 +16,16 @@@ def fail(msg) logging.error('FAIL') sys.exit(msg) + def skip(msg): + logging.warning('SKIP: {}'.format(msg)) + sys.exit(77) + def try_connecting_to_socksport(): socks_socket = socket.socket(socket.AF_INET, socket.SOCK_STREAM) - if socks_socket.connect_ex(('127.0.0.1', socks_port)): + e = socks_socket.connect_ex(('127.0.0.1', socks_port)) + if e: tor_process.terminate() - fail('Cannot connect to SOCKSPort') + fail('Cannot connect to SOCKSPort: error ' + os.strerror(e)) socks_socket.close() def wait_for_log(s):

1 0

[tor/maint-0.4.1] Travis: Skip test_rebind on macOS builds
by nickm＠torproject.org 11 Jun '19

11 Jun '19

commit be0a4be276c945e4e90b43ce8f784b5b75bef122 Author: teor <teor(a)torproject.org> Date: Mon Jun 10 18:59:02 2019 +1000 Travis: Skip test_rebind on macOS builds Skip test_rebind when the TOR_SKIP_TEST_REBIND environmental variable is set. Skip test_rebind on macOS in Travis builds, because it is unreliable on macOS on Travis. Fixes bug 30713; bugfix on 0.3.5.1-alpha. --- .travis.yml | 2 ++ changes/bug30713 | 5 +++++ src/test/test_rebind.py | 7 +++++++ src/test/test_rebind.sh | 4 ++-- 4 files changed, 16 insertions(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index 89040d822..3a9715b25 100644 --- a/.travis.yml +++ b/.travis.yml @@ -204,6 +204,8 @@ install: - if [[ "$TEST_STEM" != "" ]]; then pushd stem; python -c "from stem import stem; print(stem.__version__);"; git log -1; popd; fi script: + # Skip test_rebind on macOS + - if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then export TOR_SKIP_TEST_REBIND=true; fi - ./autogen.sh - CONFIGURE_FLAGS="$ASCIIDOC_OPTIONS $COVERAGE_OPTIONS $HARDENING_OPTIONS $MODULES_OPTIONS $NSS_OPTIONS $OPENSSL_OPTIONS $RUST_OPTIONS --enable-fatal-warnings --disable-silent-rules" - echo "Configure flags are $CONFIGURE_FLAGS" diff --git a/changes/bug30713 b/changes/bug30713 new file mode 100644 index 000000000..e00b98da6 --- /dev/null +++ b/changes/bug30713 @@ -0,0 +1,5 @@ + o Minor bugfixes (testing): + - Skip test_rebind when the TOR_SKIP_TEST_REBIND environmental variable is + set. Fixes bug 30713; bugfix on 0.3.5.1-alpha. + - Skip test_rebind on macOS in Travis, because it is unreliable on + macOS on Travis. Fixes bug 30713; bugfix on 0.3.5.1-alpha. diff --git a/src/test/test_rebind.py b/src/test/test_rebind.py index 00e5a08be..77829ca92 100644 --- a/src/test/test_rebind.py +++ b/src/test/test_rebind.py @@ -16,6 +16,10 @@ def fail(msg): logging.error('FAIL') sys.exit(msg) +def skip(msg): + logging.warning('SKIP: {}'.format(msg)) + sys.exit(77) + def try_connecting_to_socksport(): socks_socket = socket.socket(socket.AF_INET, socket.SOCK_STREAM) if socks_socket.connect_ex(('127.0.0.1', socks_port)): @@ -65,6 +69,9 @@ if sys.hexversion < 0x02070000: if sys.hexversion > 0x03000000 and sys.hexversion < 0x03010000: fail("ERROR: unsupported Python3 version (should be >= 3.1)") +if 'TOR_SKIP_TEST_REBIND' in os.environ: + skip('$TOR_SKIP_TEST_REBIND is set') + control_port = pick_random_port() socks_port = pick_random_port() diff --git a/src/test/test_rebind.sh b/src/test/test_rebind.sh index 498072de3..ea2012957 100755 --- a/src/test/test_rebind.sh +++ b/src/test/test_rebind.sh @@ -27,6 +27,6 @@ elif [ ! -d "$tmpdir" ]; then exit 3 fi -"${PYTHON:-python}" "${abs_top_srcdir:-.}/src/test/test_rebind.py" "${TESTING_TOR_BINARY}" "$tmpdir" || exitcode=1 +"${PYTHON:-python}" "${abs_top_srcdir:-.}/src/test/test_rebind.py" "${TESTING_TOR_BINARY}" "$tmpdir" -exit ${exitcode} +exit $?

1 0

[tor/maint-0.4.1] Merge branch 'maint-0.4.0' into maint-0.4.1
by nickm＠torproject.org 11 Jun '19

11 Jun '19

commit 6a72cc25983850fb23bd21adb181b38c0ead2c5a Merge: c0285320d 430dd2da6 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Jun 10 18:33:26 2019 -0400 Merge branch 'maint-0.4.0' into maint-0.4.1 .travis.yml | 2 ++ changes/bug30713 | 5 +++++ src/test/test_rebind.py | 7 +++++++ src/test/test_rebind.sh | 4 ++-- 4 files changed, 16 insertions(+), 2 deletions(-)

1 0

[tor/maint-0.4.1] Merge branch 'bug30713_035' into bug30713_040
by nickm＠torproject.org 11 Jun '19

11 Jun '19

commit 430dd2da6e97c7186b03caabbbac95d74c3d8b82 Merge: 6a6f7eb67 be0a4be27 Author: teor <teor(a)torproject.org> Date: Mon Jun 10 20:50:53 2019 +1000 Merge branch 'bug30713_035' into bug30713_040 .travis.yml | 2 ++ changes/bug30713 | 5 +++++ src/test/test_rebind.py | 7 +++++++ src/test/test_rebind.sh | 4 ++-- 4 files changed, 16 insertions(+), 2 deletions(-) diff --cc src/test/test_rebind.py index 7b12626a9,77829ca92..232b20032 --- a/src/test/test_rebind.py +++ b/src/test/test_rebind.py @@@ -16,12 -16,15 +16,16 @@@ def fail(msg) logging.error('FAIL') sys.exit(msg) + def skip(msg): + logging.warning('SKIP: {}'.format(msg)) + sys.exit(77) + def try_connecting_to_socksport(): socks_socket = socket.socket(socket.AF_INET, socket.SOCK_STREAM) - if socks_socket.connect_ex(('127.0.0.1', socks_port)): + e = socks_socket.connect_ex(('127.0.0.1', socks_port)) + if e: tor_process.terminate() - fail('Cannot connect to SOCKSPort') + fail('Cannot connect to SOCKSPort: error ' + os.strerror(e)) socks_socket.close() def wait_for_log(s):

1 0

[tor/master] Merge branch 'bug30713_035' into bug30713_040
by nickm＠torproject.org 11 Jun '19

11 Jun '19

commit 430dd2da6e97c7186b03caabbbac95d74c3d8b82 Merge: 6a6f7eb67 be0a4be27 Author: teor <teor(a)torproject.org> Date: Mon Jun 10 20:50:53 2019 +1000 Merge branch 'bug30713_035' into bug30713_040 .travis.yml | 2 ++ changes/bug30713 | 5 +++++ src/test/test_rebind.py | 7 +++++++ src/test/test_rebind.sh | 4 ++-- 4 files changed, 16 insertions(+), 2 deletions(-) diff --cc src/test/test_rebind.py index 7b12626a9,77829ca92..232b20032 --- a/src/test/test_rebind.py +++ b/src/test/test_rebind.py @@@ -16,12 -16,15 +16,16 @@@ def fail(msg) logging.error('FAIL') sys.exit(msg) + def skip(msg): + logging.warning('SKIP: {}'.format(msg)) + sys.exit(77) + def try_connecting_to_socksport(): socks_socket = socket.socket(socket.AF_INET, socket.SOCK_STREAM) - if socks_socket.connect_ex(('127.0.0.1', socks_port)): + e = socks_socket.connect_ex(('127.0.0.1', socks_port)) + if e: tor_process.terminate() - fail('Cannot connect to SOCKSPort') + fail('Cannot connect to SOCKSPort: error ' + os.strerror(e)) socks_socket.close() def wait_for_log(s):

1 0

[tor/master] Travis: Skip test_rebind on macOS builds
by nickm＠torproject.org 11 Jun '19

11 Jun '19

commit be0a4be276c945e4e90b43ce8f784b5b75bef122 Author: teor <teor(a)torproject.org> Date: Mon Jun 10 18:59:02 2019 +1000 Travis: Skip test_rebind on macOS builds Skip test_rebind when the TOR_SKIP_TEST_REBIND environmental variable is set. Skip test_rebind on macOS in Travis builds, because it is unreliable on macOS on Travis. Fixes bug 30713; bugfix on 0.3.5.1-alpha. --- .travis.yml | 2 ++ changes/bug30713 | 5 +++++ src/test/test_rebind.py | 7 +++++++ src/test/test_rebind.sh | 4 ++-- 4 files changed, 16 insertions(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index 89040d822..3a9715b25 100644 --- a/.travis.yml +++ b/.travis.yml @@ -204,6 +204,8 @@ install: - if [[ "$TEST_STEM" != "" ]]; then pushd stem; python -c "from stem import stem; print(stem.__version__);"; git log -1; popd; fi script: + # Skip test_rebind on macOS + - if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then export TOR_SKIP_TEST_REBIND=true; fi - ./autogen.sh - CONFIGURE_FLAGS="$ASCIIDOC_OPTIONS $COVERAGE_OPTIONS $HARDENING_OPTIONS $MODULES_OPTIONS $NSS_OPTIONS $OPENSSL_OPTIONS $RUST_OPTIONS --enable-fatal-warnings --disable-silent-rules" - echo "Configure flags are $CONFIGURE_FLAGS" diff --git a/changes/bug30713 b/changes/bug30713 new file mode 100644 index 000000000..e00b98da6 --- /dev/null +++ b/changes/bug30713 @@ -0,0 +1,5 @@ + o Minor bugfixes (testing): + - Skip test_rebind when the TOR_SKIP_TEST_REBIND environmental variable is + set. Fixes bug 30713; bugfix on 0.3.5.1-alpha. + - Skip test_rebind on macOS in Travis, because it is unreliable on + macOS on Travis. Fixes bug 30713; bugfix on 0.3.5.1-alpha. diff --git a/src/test/test_rebind.py b/src/test/test_rebind.py index 00e5a08be..77829ca92 100644 --- a/src/test/test_rebind.py +++ b/src/test/test_rebind.py @@ -16,6 +16,10 @@ def fail(msg): logging.error('FAIL') sys.exit(msg) +def skip(msg): + logging.warning('SKIP: {}'.format(msg)) + sys.exit(77) + def try_connecting_to_socksport(): socks_socket = socket.socket(socket.AF_INET, socket.SOCK_STREAM) if socks_socket.connect_ex(('127.0.0.1', socks_port)): @@ -65,6 +69,9 @@ if sys.hexversion < 0x02070000: if sys.hexversion > 0x03000000 and sys.hexversion < 0x03010000: fail("ERROR: unsupported Python3 version (should be >= 3.1)") +if 'TOR_SKIP_TEST_REBIND' in os.environ: + skip('$TOR_SKIP_TEST_REBIND is set') + control_port = pick_random_port() socks_port = pick_random_port() diff --git a/src/test/test_rebind.sh b/src/test/test_rebind.sh index 498072de3..ea2012957 100755 --- a/src/test/test_rebind.sh +++ b/src/test/test_rebind.sh @@ -27,6 +27,6 @@ elif [ ! -d "$tmpdir" ]; then exit 3 fi -"${PYTHON:-python}" "${abs_top_srcdir:-.}/src/test/test_rebind.py" "${TESTING_TOR_BINARY}" "$tmpdir" || exitcode=1 +"${PYTHON:-python}" "${abs_top_srcdir:-.}/src/test/test_rebind.py" "${TESTING_TOR_BINARY}" "$tmpdir" -exit ${exitcode} +exit $?

1 0

[tor/master] Merge branch 'maint-0.4.0' into maint-0.4.1
by nickm＠torproject.org 11 Jun '19

11 Jun '19

commit 6a72cc25983850fb23bd21adb181b38c0ead2c5a Merge: c0285320d 430dd2da6 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Jun 10 18:33:26 2019 -0400 Merge branch 'maint-0.4.0' into maint-0.4.1 .travis.yml | 2 ++ changes/bug30713 | 5 +++++ src/test/test_rebind.py | 7 +++++++ src/test/test_rebind.sh | 4 ++-- 4 files changed, 16 insertions(+), 2 deletions(-)

1 0

[tor/master] Merge branch 'maint-0.4.1'
by nickm＠torproject.org 11 Jun '19

11 Jun '19

commit d6b411a3514d65b5cabd2505ae4642e763074142 Merge: c8e09dd0d 6a72cc259 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Jun 10 18:33:26 2019 -0400 Merge branch 'maint-0.4.1' .travis.yml | 2 ++ changes/bug30713 | 5 +++++ src/test/test_rebind.py | 7 +++++++ src/test/test_rebind.sh | 4 ++-- 4 files changed, 16 insertions(+), 2 deletions(-)

1 0

[tor/maint-0.4.1] Merge remote-tracking branch 'tor-github/pr/1097' into maint-0.4.1
by nickm＠torproject.org 11 Jun '19

11 Jun '19

commit c0285320df4e52530129ca515de08245d035c889 Merge: 765e4364d b9041e8a6 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Jun 10 18:31:23 2019 -0400 Merge remote-tracking branch 'tor-github/pr/1097' into maint-0.4.1 src/test/test_rebind.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

1 0

[tor/maint-0.4.1] test: fix a typo in test_rebind.sh
by nickm＠torproject.org 11 Jun '19

11 Jun '19

commit b9041e8a631beda9762fcd0627fa91045086410d Author: teor <teor(a)torproject.org> Date: Mon Jun 10 20:56:40 2019 +1000 test: fix a typo in test_rebind.sh Closes 30821. --- src/test/test_rebind.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/test_rebind.sh b/src/test/test_rebind.sh index a8f07c7c1..1d54dd7f3 100755 --- a/src/test/test_rebind.sh +++ b/src/test/test_rebind.sh @@ -7,7 +7,7 @@ if test "$UNAME_OS" = 'CYGWIN' || \ test "$UNAME_OS" = 'MSYS' || \ test "$UNAME_OS" = 'MINGW'; then if test "$APPVEYOR" = 'True'; then - echo "This test is disabled on Windows CI, as it requires firewall examptions. Skipping." >&2 + echo "This test is disabled on Windows CI, as it requires firewall exemptions. Skipping." >&2 exit 77 fi fi

1 0