June 2019 - tor-commits - lists.torproject.org

[bridgedb/master] Remove Yahoo from our whitelisted email domains.
by phw＠torproject.org 07 Jun '19

07 Jun '19

commit 688e1ac015bcfe5a826032e207f9a0f671cd6174 Author: Philipp Winter <phw(a)nymity.ch> Date: Thu Jun 6 09:25:07 2019 -0700 Remove Yahoo from our whitelisted email domains. Yahoo allows you to create up to 500 disposable email addresses, which BridgeDB interprets as unique: <https://bugs.torproject.org/28496#comment:8> We could address this issue in BridgeDB but at this point we seem better off dropping support for Yahoo because the provider likely also fell behind in Sybil protection. This fixes bug 28496: <https://bugs.torproject.org/28496> --- CHANGELOG | 9 +++++++++ README.rst | 7 +++---- bridgedb.conf | 3 +-- bridgedb/distributors/https/templates/base.html | 3 +-- bridgedb/strings.py | 2 +- bridgedb/test/test_email_autoresponder.py | 2 +- 6 files changed, 16 insertions(+), 10 deletions(-) diff --git a/CHANGELOG b/CHANGELOG index f45f56f..dd460ab 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -1,5 +1,14 @@ Changes in version 0.6.X - YYYY-MM-DD + * FIXES #28496 https://bugs.torproject.org/28496 + Remove Yahoo from the list of allowed email domains. Yahoo allows you + to create up to 500 disposable email addresses, which BridgeDB + interprets as unique: + https://bugs.torproject.org/28496#comment:8 + We could address this issue in BridgeDB but at this point we seem better + off dropping support for Yahoo because the provider likely also fell + behind in Sybil protection. + * FIXES #28655 https://bugs.torproject.org/28655 When a bridge supports an active probing-resistant transport, it should not give out flavors that are vulnerable to active probing. For diff --git a/README.rst b/README.rst index feb5227..ea4bc7c 100644 --- a/README.rst +++ b/README.rst @@ -401,10 +401,9 @@ Accessing the Email User Interface ---------------------------------- Any mail sent to the ``EMAIL_PORT`` with a destination username as defined by -the ``EMAIL_USERNAME`` configuration option (the default is ``'bridge'``, -e.g. bridges@...) and sent from an ``(a)riseup.net``, ``(a)gmail.com``, or -``(a)yahoo.com`` address (by default, but configurable with the -``EMAIL_DOMAINS`` option). +the ``EMAIL_USERNAME`` configuration option (the default is ``'bridge'``, e.g. +bridges@...) and sent from an ``(a)riseup.net`` or ``(a)gmail.com`` address (by +default, but configurable with the ``EMAIL_DOMAINS`` option). You can email our BridgeDB instance `here <mailto:bridges@torproject.org>`__. diff --git a/bridgedb.conf b/bridgedb.conf index 73b65b8..900ead1 100644 --- a/bridgedb.conf +++ b/bridgedb.conf @@ -561,7 +561,7 @@ EMAIL_SMTP_PORT = 25 EMAIL_USERNAME = "bridges" # Canonical versions of domains that we will reply to. -EMAIL_DOMAINS = ["gmail.com", "yahoo.com", "riseup.net"] +EMAIL_DOMAINS = ["gmail.com", "riseup.net"] # Map from unofficial domain to canonical domain. EMAIL_DOMAIN_MAP = { @@ -582,7 +582,6 @@ EMAIL_DOMAIN_MAP = { # Note that unrecognized options are ignored; be sure to spell them right! EMAIL_DOMAIN_RULES = { 'gmail.com': ["ignore_dots", "dkim"], - 'yahoo.com': ["dkim"], 'riseup.net': ["ignore_dots", "dkim"], } diff --git a/bridgedb/distributors/https/templates/base.html b/bridgedb/distributors/https/templates/base.html index 93eb2b5..d7b6045 100644 --- a/bridgedb/distributors/https/templates/base.html +++ b/bridgedb/distributors/https/templates/base.html @@ -60,8 +60,7 @@ ${next.body(strings, rtl=rtl, lang=lang, **kwargs)} ${_(strings.OTHER_DISTRIBUTORS[1]) % \ ("""<a href="mailto:bridges@torproject.org">bridges(a)torproject.org</a>""", """<a href="https://riseup.net/">Riseup</a>""", - """<a href="https://mail.google.com/">Gmail</a>""", - """<a href="https://mail.yahoo.com/">Yahoo</a>""")} + """<a href="https://mail.google.com/">Gmail</a>""")} </p> <h4>${_(strings.HELP[0])}</h4> diff --git a/bridgedb/strings.py b/bridgedb/strings.py index 49bb933..569f339 100644 --- a/bridgedb/strings.py +++ b/bridgedb/strings.py @@ -108,7 +108,7 @@ OTHER_DISTRIBUTORS = { 1: _("""\ Another way to get bridges is to send an email to %s. Please note that you must send the email using an address from one of the following email providers: -%s, %s or %s."""), +%s or %s."""), } HELP = { diff --git a/bridgedb/test/test_email_autoresponder.py b/bridgedb/test/test_email_autoresponder.py index a1e376f..f59e5ef 100644 --- a/bridgedb/test/test_email_autoresponder.py +++ b/bridgedb/test/test_email_autoresponder.py @@ -520,7 +520,7 @@ class SMTPAutoresponderTests(unittest.TestCase): reported being from an email address at one supported domain and the email's 'From:' header reported another domain. """ - smtpFrom = 'not.an.evil.bot(a)yahoo.com' + smtpFrom = 'not.an.evil.bot(a)riseup.net' emailFrom = Address('not.an.evil.bot(a)gmail.com') self._getIncomingLines(str(emailFrom)) self._setUpResponder()

1 0

[bridgedb/master] Fix CHANGELOG.
by phw＠torproject.org 07 Jun '19

07 Jun '19

commit 589d6f7ce64a4a3d554ff6fe160655a2e56d35e7 Author: Philipp Winter <phw(a)nymity.ch> Date: Fri Jun 7 10:12:59 2019 -0700 Fix CHANGELOG. --- CHANGELOG | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGELOG b/CHANGELOG index 49b95dc..ed7d213 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -1,4 +1,4 @@ -Changes in version 0.6.X - YYYY-MM-DD +Changes in version 0.7.1 - YYYY-MM-DD * FIXES #28496 https://bugs.torproject.org/28496 Remove Yahoo from the list of allowed email domains. Yahoo allows you @@ -9,6 +9,8 @@ Changes in version 0.6.X - YYYY-MM-DD off dropping support for Yahoo because the provider likely also fell behind in Sybil protection. +Changes in version 0.7.0 - 2019-06-07 + * FIXES #28655 https://bugs.torproject.org/28655 When a bridge supports an active probing-resistant transport, it should not give out flavors that are vulnerable to active probing. For

1 0

[bridgedb/master] Merge branch 'master' into develop
by phw＠torproject.org 07 Jun '19

07 Jun '19

commit e6e02be5e8f1f410441c811bf80b52e518bf7c91 Merge: 1747723 a0644df Author: Philipp Winter <phw(a)nymity.ch> Date: Fri Jun 7 09:35:24 2019 -0700 Merge branch 'master' into develop

1 0

[bridgedb/master] Bump version number to 0.7.1.
by phw＠torproject.org 07 Jun '19

07 Jun '19

commit 6e7523ba4932cef7a442bdee18d2a6437fdec50d Author: Philipp Winter <phw(a)nymity.ch> Date: Fri Jun 7 10:23:17 2019 -0700 Bump version number to 0.7.1. --- CHANGELOG | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG b/CHANGELOG index ed7d213..1ebd47e 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -1,4 +1,4 @@ -Changes in version 0.7.1 - YYYY-MM-DD +Changes in version 0.7.1 - 2019-06-07 * FIXES #28496 https://bugs.torproject.org/28496 Remove Yahoo from the list of allowed email domains. Yahoo allows you

1 0

[bridgedb/master] Merge branch 'release-0.7.1'
by phw＠torproject.org 07 Jun '19

07 Jun '19

commit 2d86ae0c232a0390bbd891d42e9722a10589fd0e Merge: a0644df 6e7523b Author: Philipp Winter <phw(a)nymity.ch> Date: Fri Jun 7 10:23:40 2019 -0700 Merge branch 'release-0.7.1' CHANGELOG | 13 ++++++++++++- README.rst | 7 +++---- bridgedb.conf | 3 +-- bridgedb/distributors/https/templates/base.html | 3 +-- bridgedb/strings.py | 2 +- bridgedb/test/test_email_autoresponder.py | 2 +- 6 files changed, 19 insertions(+), 11 deletions(-)

1 0

[bridgedb/master] Add phw to the support options.
by phw＠torproject.org 07 Jun '19

07 Jun '19

commit ab4e116a395af99c391c87814c41e6f0cc7bdcb9 Author: Philipp Winter <phw(a)nymity.ch> Date: Mon May 20 15:24:28 2019 -0700 Add phw to the support options. --- README.rst | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/README.rst b/README.rst index feb5227..9247f6d 100644 --- a/README.rst +++ b/README.rst @@ -590,5 +590,6 @@ Contact & Support ================= Send your questions, patches, and suggestions to -`the tor-dev mailing list <mailto:tor-dev@lists.torproject.org>`__ -or `sysrqb <mailto:sysrqb@torproject.org>`__. +`the tor-dev mailing list <mailto:tor-dev@lists.torproject.org>`__, +`sysrqb <mailto:sysrqb@torproject.org>`__, or +`phw <mailto:phw@torproject.org>`__.

1 0

[bridgedb/master] Add missing CHANGELOG entries.
by phw＠torproject.org 07 Jun '19

07 Jun '19

commit ea009cf66238872871857cbf39665a36ff5714a8 Author: Philipp Winter <phw(a)nymity.ch> Date: Mon May 20 17:25:15 2019 -0700 Add missing CHANGELOG entries. --- CHANGELOG | 38 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 38 insertions(+) diff --git a/CHANGELOG b/CHANGELOG index 9ffeac1..4810a5e 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -1,3 +1,41 @@ +Changes in version 0.6.9 - 2018-11-20 + + * FIXES #23894 https://bugs.torproject.org/23894 + Really change the contact address, in the correct place this time. + +Changes in version 0.6.8 - 2018-11-19 + + * FIXES #28528 https://bugs.torproject.org/28528 + Change maintainer info. + + * FIXES #23894 https://bugs.torproject.org/23894 + Change contact email address. + +Changes in version 0.6.7 - 2018-05-21 + + Print fingerprints in hex thank you very much. + +Changes in version 0.6.6 - 2018-05-21 + + * FIXES #26150 https://bugs.torproject.org/26150 + Hotfix for strange bridges missing address fields. + +Changes in version 0.6.5 - 2018-05-04 + + * FIXES #26023 https://bugs.torproject.org/26023 + There's few bridges whose ed25519 certificates contain the year 491869, + which the datetime module (called from Stem) believes "out of range". So + instead we'll parse the descriptors one at a time and catch the errors + as we go. + + * FIXES #25246 https://bugs.torproject.org/25246 + Add script for assigning unallocated bridges to another distributor. + +Changes in version 0.6.4 - 2018-02-13 + + * FIXES #24432 https://bugs.torproject.org/24432 + Add config option to skip loopback addresses in X-Forwarded-For parsing. + Changes in version 0.6.3 - 2018-01-23 * FIXES #24432 https://bugs.torproject.org/24432

1 0

[bridgedb/master] Use HTTPS instead of HTTP URL.
by phw＠torproject.org 07 Jun '19

07 Jun '19

commit 1d20737517fe138b46f5edfb962096b3eb5394d6 Author: Philipp Winter <phw(a)nymity.ch> Date: Mon May 20 15:12:03 2019 -0700 Use HTTPS instead of HTTP URL. --- doc/HACKING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/HACKING.md b/doc/HACKING.md index 0be0aee..5c9c4f5 100644 --- a/doc/HACKING.md +++ b/doc/HACKING.md @@ -70,4 +70,4 @@ tagged release at that point, i.e.: References ---------- [trac]: https://trac.torproject.org/projects/tor/query?status=!closed&component=Cir… -[workflow]: http://nvie.com/posts/a-successful-git-branching-model/ +[workflow]: https://nvie.com/posts/a-successful-git-branching-model/

1 0

[bridgedb/master] Fix typo.
by phw＠torproject.org 07 Jun '19

07 Jun '19

commit ab5b09aa78fea5189e9bd4b28a053aa1894f6c28 Author: Philipp Winter <phw(a)nymity.ch> Date: Tue May 7 11:21:03 2019 -0700 Fix typo. --- bridgedb.conf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bridgedb.conf b/bridgedb.conf index 7700917..b67a5e8 100644 --- a/bridgedb.conf +++ b/bridgedb.conf @@ -142,7 +142,7 @@ STATUS_FILE = "networkstatus-bridges" # we ignore all errors which have anything to do with networkstatus being # wrong, out-of-date, or missing. # -# Otherwise, if ``True``, use the networkstatus to determine which bridges +# Otherwise, if ``False``, use the networkstatus to determine which bridges # should be distributed. # # See https://bugs.torproject.org/9380#comment:39,

1 0

[bridgedb/master] Fix broken Trac URL.
by phw＠torproject.org 07 Jun '19

07 Jun '19

commit ff67d2a673896b3436207443034880f76eb14002 Author: Philipp Winter <phw(a)nymity.ch> Date: Mon May 20 15:11:31 2019 -0700 Fix broken Trac URL. --- doc/HACKING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/HACKING.md b/doc/HACKING.md index 22f9b2b..0be0aee 100644 --- a/doc/HACKING.md +++ b/doc/HACKING.md @@ -69,5 +69,5 @@ tagged release at that point, i.e.: References ---------- -[trac]: https://trac.torproject.org/projects/tor/query?status=accepted&status=assig… +[trac]: https://trac.torproject.org/projects/tor/query?status=!closed&component=Cir… [workflow]: http://nvie.com/posts/a-successful-git-branching-model/

1 0