May 2019 - tor-commits - lists.torproject.org

[torspec/master] dir-spec: Add prop289 consensus parameters
by nickm＠torproject.org 31 May '19

31 May '19

commit 4ba8c630dcccd4f581ac5f371e5b94eead67b9b2 Author: David Goulet <dgoulet(a)torproject.org> Date: Fri May 24 10:08:10 2019 -0400 dir-spec: Add prop289 consensus parameters Part of #30365 Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- dir-spec.txt | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/dir-spec.txt b/dir-spec.txt index 460d02a..f620751 100644 --- a/dir-spec.txt +++ b/dir-spec.txt @@ -2098,6 +2098,14 @@ the circuit queue a given circuit. Min: 0. Max: 50000. Default 1000. First appeared: 0.4.0.3-alpha. + "sendme_emit_min_version" -- Minimum SENDME version that can be sent. + Min: 0. Max: 255. Default 0. First + appeared: 0.4.1.1-alpha. + + "sendme_accept_min_version" -- Minimum SENDME version that is accepted. + Min: 0. Max: 255. Default 0. First + appeared: 0.4.1.1-alpha. + "shared-rand-previous-value" SP NumReveals SP Value NL [At most once]

1 0

[torspec/master] tor-spec: Add authenticated SENDMEs
by nickm＠torproject.org 31 May '19

31 May '19

commit 4fc32990cfa29e31db04005fe35bc8e239d9fcd8 Author: David Goulet <dgoulet(a)torproject.org> Date: Fri May 24 10:05:58 2019 -0400 tor-spec: Add authenticated SENDMEs This merges proposal 289 into tor-spec.txt. Most of the circuit-level flow control section has been rewritten to be clearer and better detail version 0 and 1. Closes #30365 Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- proposals/289-authenticated-sendmes.txt | 2 +- tor-spec.txt | 108 ++++++++++++++++++++++++++------ 2 files changed, 89 insertions(+), 21 deletions(-) diff --git a/proposals/289-authenticated-sendmes.txt b/proposals/289-authenticated-sendmes.txt index c9eada6..3ae9e3e 100644 --- a/proposals/289-authenticated-sendmes.txt +++ b/proposals/289-authenticated-sendmes.txt @@ -1,6 +1,6 @@ Filename: 289-authenticated-sendmes.txt Title: Authenticating sendme cells to mitigate bandwidth attacks -Author: Rob Jansen, Roger Dingledine +Author: Rob Jansen, Roger Dingledine, David Goulet Created: 2016-12-01 Status: Open diff --git a/tor-spec.txt b/tor-spec.txt index b2b26eb..1a211bc 100644 --- a/tor-spec.txt +++ b/tor-spec.txt @@ -1861,32 +1861,91 @@ see tor-design.pdf. To control a circuit's bandwidth usage, each OR keeps track of two 'windows', consisting of how many RELAY_DATA cells it is allowed to - originate (package for transmission), and how many RELAY_DATA cells - it is willing to consume (receive for local streams). These limits - do not apply to cells that the OR receives from one host and relays - to another. + originate or willing to consume. + + These two windows are respectively named: the package window (packaged for + transmission) and the deliver window (delivered for local streams). + + Because of our leaky-pipe topology, every relay on the circuit has a pair + of windows, and the OP has a pair of windows for every relay on the + circuit. These windows do not apply to relayed cells, however, and a relay + that is never used for streams will never decrement its window or cause the + client to decrement a window. Each 'window' value is initially set based on the consensus parameter - 'circwindow' in the directory (see dir-spec.txt), or to 1000 data cells - if no 'circwindow' value is given, - in each direction (cells that are not data cells do not affect - the window). When an OR is willing to deliver more cells, it sends a - RELAY_SENDME cell towards the OP, with Stream ID zero and an empty - body. When an OR receives a RELAY_SENDME cell with stream ID zero, it - increments its packaging window. (The body SHOULD be ignored.) + 'circwindow' in the directory (see dir-spec.txt), or to 1000 data cells if + no 'circwindow' value is given. In each direction, cells that are not + RELAY_DATA cells do not affect the window. + + An OR or OP (depending on the stream direction) sends a RELAY_SENDME cell + to indicate that it is willing to receive more cells when its deliver + window goes down below a full increment (100). For example, if the window + started at 1000, it should send a RELAY_SENDME when it reaches 900. + + When an OR or OP receives a RELAY_SENDME, it increments its package window + by a value of 100 (circuit window increment) and proceeds to sending the + remaining RELAY_DATA cells. + + If a package window reaches 0, the OR or OP stops reading from TCP + connections for all streams on the corresponding circuit, and sends no more + RELAY_DATA cells until receiving a RELAY_SENDME cell. + + If a deliver window goes below 0, the circuit should be torn down. + + Starting with tor-0.4.1.1-alpha, authenticated SENDMEs are supported + (version 1, see below). This means that both the OR and OP need to remember + the rolling digest of the cell that precedes (triggers) a RELAY_SENDME. + This can be known if the package window gets to a multiple of the circuit + window increment (100). + + When the RELAY_SENDME version 1 arrives, it will contain a digest that MUST + match the one remembered. This represents a proof that the end point of the + circuit saw the sent cells. On failure to match, the circuit should be torn + down. + + To ensure unpredictability, random bytes should be added to at least one + RELAY_DATA cell within one increment window. In other word, every 100 cells + (increment), random bytes should be introduced in at least one cell. + +7.3.1 SENDME Cell Format + + A circuit-level RELAY_SENDME cell always has its StreamID=0. - Each of these cells increments the corresponding window by 100. + An OR or OP must obey these two consensus parameters in order to know which + version to emit and accept. - The OP behaves identically, except that it must track a packaging - window and a delivery window for every OR in the circuit. + 'sendme_emit_min_version': Minimum version to emit. + 'sendme_accept_min_version': Minimum version to accept. - An OR or OP sends cells to increment its delivery window when the - corresponding window value falls under some threshold (900). + If a RELAY_SENDME version is received that is below the minimum accepted + version, the circuit should be closed. - If a packaging window reaches 0, the OR or OP stops reading from - TCP connections for all streams on the corresponding circuit, and - sends no more RELAY_DATA cells until receiving a RELAY_SENDME cell. -[this stuff is badly worded; copy in the tor-design section -RD] + The RELAY_SENDME payload contains the following: + + VERSION [1 byte] + DATA_LEN [2 bytes] + DATA [DATA_LEN bytes] + + The VERSION tells us what is expected in the DATA section of length + DATA_LEN and how to handle it. The recognized values are: + + 0x00: The rest of the payload should be ignored. + + 0x01: Authenticated SENDME. The DATA section MUST contain: + + DIGEST [20 bytes] + + If the DATA_LEN value is less than 20 bytes, the cell should be + dropped and the circuit closed. If the value is more than 20 bytes, + then the first 20 bytes should be read to get the DIGEST value. + + The DIGEST is the rolling digest value from the RELAY_DATA cell that + immediately preceded (triggered) this RELAY_SENDME. This value is + matched on the other side from the previous cell sent that the OR/OP + must remember. + + If the VERSION is unrecognized or below the minimum accepted version (taken + from the consensus), the circuit should be torn down. 7.4. Stream-level flow control @@ -2111,3 +2170,12 @@ see tor-design.pdf. Describes the padding capabilities of the relay. "1" -- Relay supports circuit-level padding. + +9.12. "FlowCtrl" + + Describes the flow control protocol at the circuit and stream level. If + there is no FlowCtrl advertised, tor supports the unauthenticated flow + control features (version 0). + + "1" -- supports authenticated circuit level SENDMEs as of proposal 289 in + Tor 0.4.1.1-alpha.

1 0

[torspec/master] prop289: Close it
by nickm＠torproject.org 31 May '19

31 May '19

commit d58b7d180e68f4f332f25d6d31d5006866cf10b8 Author: David Goulet <dgoulet(a)torproject.org> Date: Fri May 24 10:10:37 2019 -0400 prop289: Close it It is not fully implemented and previous commit merges the relevant sections into tor-spec.txt and dir-spec.txt. I've also added "David Goulet" as a author since lots of it has changed from my work since the creation of the proposal. Part of #30365 Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- proposals/000-index.txt | 4 ++-- proposals/289-authenticated-sendmes.txt | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/proposals/000-index.txt b/proposals/000-index.txt index c83a6fd..d10f917 100644 --- a/proposals/000-index.txt +++ b/proposals/000-index.txt @@ -209,7 +209,7 @@ Proposals by number: 286 Controller APIs for hibernation access on mobile [REJECTED] 287 Reduce circuit lifetime without overloading the network [OPEN] 288 Privacy-Preserving Statistics with Privcount in Tor (Shamir version) [ACCEPTED] -289 Authenticating sendme cells to mitigate bandwidth attacks [OPEN] +289 Authenticating sendme cells to mitigate bandwidth attacks [CLOSED] 290 Continuously update consensus methods [META] 291 The move to two guard nodes [NEEDS-REVISION] 292 Mesh-based vanguards [ACCEPTED] @@ -253,7 +253,6 @@ Proposals by status: 277 Detect multiple relay instances running with same ID [for 0.3.??] 285 Directory documents should be standardized as UTF-8 287 Reduce circuit lifetime without overloading the network - 289 Authenticating sendme cells to mitigate bandwidth attacks 295 Using ADL for relay cryptography (solving the crypto-tagging attack) 296 Have Directory Authorities expose raw bandwidth list files 299 Preferring IPv4 or IPv6 based on IP Version Failure Count @@ -363,6 +362,7 @@ Proposals by status: 278 Directory Compression Scheme Negotiation [in 0.3.1.1-alpha] 283 Move IPv6 ORPorts from microdescriptors to the microdesc consensus [for 0.3.3.x] [in 0.3.3.1-alpha] 284 Hidden Service v3 Control Port + 289 Authenticating sendme cells to mitigate bandwidth attacks [in 0.4.1.1-alpha] 293 Other ways for relays to know when to publish [for 0.3.5] [in 0.4.0.1-alpha] 297 Relaxing the protover-based shutdown rules [for 0.3.5.x] [in 0.4.0.x] 298 Putting family lines in canonical form [for 0.3.6.x] [in 0.4.0.1-alpha] diff --git a/proposals/289-authenticated-sendmes.txt b/proposals/289-authenticated-sendmes.txt index 3ae9e3e..e09b882 100644 --- a/proposals/289-authenticated-sendmes.txt +++ b/proposals/289-authenticated-sendmes.txt @@ -2,7 +2,8 @@ Filename: 289-authenticated-sendmes.txt Title: Authenticating sendme cells to mitigate bandwidth attacks Author: Rob Jansen, Roger Dingledine, David Goulet Created: 2016-12-01 -Status: Open +Status: Closed +Implemented-In: 0.4.1.1-alpha 1. Overview and Motivation

1 0

[translation/tbmanual-contentspot_completed] Update translations for tbmanual-contentspot_completed
by translation＠torproject.org 31 May '19

31 May '19

commit 1d356fe64ae006306dba4e4aa9e2d23fe06ef4b7 Author: Translation commit bot <translation(a)torproject.org> Date: Fri May 31 18:48:02 2019 +0000 Update translations for tbmanual-contentspot_completed --- contents+fr.po | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/contents+fr.po b/contents+fr.po index d8da3397f..01759ca04 100644 --- a/contents+fr.po +++ b/contents+fr.po @@ -190,8 +190,8 @@ msgid "" "The safest and simplest way to download Tor Browser is from the official Tor" " Project website at https://www.torproject.org." msgstr "" -"La manière la plus sûre et la plus simple de télécharger le Navigateur Tor " -"est de le faire à partir du site Web officiel du Projet Tor à " +"La façon la plus sûre et la plus simple de télécharger le Navigateur Tor est" +" de le faire à partir du site Web officiel du Projet Tor à " "https://www.torproject.org/fr/." #: https//tb-manual.torproject.org/downloading/

1 0

[translation/tbmanual-contentspot] Update translations for tbmanual-contentspot
by translation＠torproject.org 31 May '19

31 May '19

commit f3c41ec3281dbec6141fddf1f164c89b75a130be Author: Translation commit bot <translation(a)torproject.org> Date: Fri May 31 18:47:52 2019 +0000 Update translations for tbmanual-contentspot --- contents+fr.po | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/contents+fr.po b/contents+fr.po index d8da3397f..01759ca04 100644 --- a/contents+fr.po +++ b/contents+fr.po @@ -190,8 +190,8 @@ msgid "" "The safest and simplest way to download Tor Browser is from the official Tor" " Project website at https://www.torproject.org." msgstr "" -"La manière la plus sûre et la plus simple de télécharger le Navigateur Tor " -"est de le faire à partir du site Web officiel du Projet Tor à " +"La façon la plus sûre et la plus simple de télécharger le Navigateur Tor est" +" de le faire à partir du site Web officiel du Projet Tor à " "https://www.torproject.org/fr/." #: https//tb-manual.torproject.org/downloading/

1 0

[translation/tails-openpgp-applet_completed] Update translations for tails-openpgp-applet_completed
by translation＠torproject.org 31 May '19

31 May '19

commit 8ef06ceed7f5ad81febf80e3dc48e3cd96869f1a Author: Translation commit bot <translation(a)torproject.org> Date: Fri May 31 17:47:20 2019 +0000 Update translations for tails-openpgp-applet_completed --- fr/openpgp-applet.pot | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fr/openpgp-applet.pot b/fr/openpgp-applet.pot index 6aaa5fd22..230c8eddc 100644 --- a/fr/openpgp-applet.pot +++ b/fr/openpgp-applet.pot @@ -12,7 +12,7 @@ msgstr "" "Project-Id-Version: Tor Project\n" "Report-Msgid-Bugs-To: tails(a)boum.org\n" "POT-Creation-Date: 2017-08-05 15:07-0400\n" -"PO-Revision-Date: 2019-03-12 18:35+0000\n" +"PO-Revision-Date: 2019-05-31 17:46+0000\n" "Last-Translator: AO <ao(a)localizationlab.org>\n" "Language-Team: French (http://www.transifex.com/otf/torproject/language/fr/)\n" "MIME-Version: 1.0\n"

1 0

[translation/tails-openpgp-applet] Update translations for tails-openpgp-applet
by translation＠torproject.org 31 May '19

31 May '19

commit 0a956c1248ea9cf0bf81772fe0b47c4202bd49a2 Author: Translation commit bot <translation(a)torproject.org> Date: Fri May 31 17:47:12 2019 +0000 Update translations for tails-openpgp-applet --- fr/openpgp-applet.pot | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fr/openpgp-applet.pot b/fr/openpgp-applet.pot index 6aaa5fd22..230c8eddc 100644 --- a/fr/openpgp-applet.pot +++ b/fr/openpgp-applet.pot @@ -12,7 +12,7 @@ msgstr "" "Project-Id-Version: Tor Project\n" "Report-Msgid-Bugs-To: tails(a)boum.org\n" "POT-Creation-Date: 2017-08-05 15:07-0400\n" -"PO-Revision-Date: 2019-03-12 18:35+0000\n" +"PO-Revision-Date: 2019-05-31 17:46+0000\n" "Last-Translator: AO <ao(a)localizationlab.org>\n" "Language-Team: French (http://www.transifex.com/otf/torproject/language/fr/)\n" "MIME-Version: 1.0\n"

1 0

[tor-browser-build/master] Revert "Bug 29641: Try to connect over IPv6 if needed"
by gk＠torproject.org 31 May '19

31 May '19

commit 5e8a92b225e3f67a4df6ce9e47e62eee59ed90fb Author: Georg Koppen <gk(a)torproject.org> Date: Fri May 31 11:47:29 2019 +0000 Revert "Bug 29641: Try to connect over IPv6 if needed" This reverts commit f75cf0bd2e1c4cef96a31e266da4a0385e5f2016. See: bug 30639 for the reasoning behind the revert and some work we need to do in the meantime. --- projects/tor-browser/Bundle-Data/linux/Data/Tor/torrc-defaults | 1 - projects/tor-browser/Bundle-Data/mac/TorBrowser/Data/Tor/torrc-defaults | 1 - projects/tor-browser/Bundle-Data/windows/Data/Tor/torrc-defaults | 1 - 3 files changed, 3 deletions(-) diff --git a/projects/tor-browser/Bundle-Data/linux/Data/Tor/torrc-defaults b/projects/tor-browser/Bundle-Data/linux/Data/Tor/torrc-defaults index d0c074e..f3645cd 100644 --- a/projects/tor-browser/Bundle-Data/linux/Data/Tor/torrc-defaults +++ b/projects/tor-browser/Bundle-Data/linux/Data/Tor/torrc-defaults @@ -13,4 +13,3 @@ AvoidDiskWrites 1 Log notice stdout CookieAuthentication 1 DormantCanceledByStartup 1 -ClientAutoIPv6ORPort 1 diff --git a/projects/tor-browser/Bundle-Data/mac/TorBrowser/Data/Tor/torrc-defaults b/projects/tor-browser/Bundle-Data/mac/TorBrowser/Data/Tor/torrc-defaults index d0c074e..f3645cd 100644 --- a/projects/tor-browser/Bundle-Data/mac/TorBrowser/Data/Tor/torrc-defaults +++ b/projects/tor-browser/Bundle-Data/mac/TorBrowser/Data/Tor/torrc-defaults @@ -13,4 +13,3 @@ AvoidDiskWrites 1 Log notice stdout CookieAuthentication 1 DormantCanceledByStartup 1 -ClientAutoIPv6ORPort 1 diff --git a/projects/tor-browser/Bundle-Data/windows/Data/Tor/torrc-defaults b/projects/tor-browser/Bundle-Data/windows/Data/Tor/torrc-defaults index d0c074e..f3645cd 100644 --- a/projects/tor-browser/Bundle-Data/windows/Data/Tor/torrc-defaults +++ b/projects/tor-browser/Bundle-Data/windows/Data/Tor/torrc-defaults @@ -13,4 +13,3 @@ AvoidDiskWrites 1 Log notice stdout CookieAuthentication 1 DormantCanceledByStartup 1 -ClientAutoIPv6ORPort 1

1 0

[tor-browser-build/maint-8.5] Release preparations for 8.5.1
by gk＠torproject.org 31 May '19

31 May '19

commit 4fd074e59d14c3a4b43a308c796486ab84e5b113 Author: Georg Koppen <gk(a)torproject.org> Date: Fri May 31 11:25:08 2019 +0000 Release preparations for 8.5.1 Versions bump and Changelog update --- projects/firefox/config | 2 +- projects/https-everywhere/config | 2 +- projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt | 18 ++++++++++++++++++ projects/torbutton/config | 2 +- rbm.conf | 6 +++--- 5 files changed, 24 insertions(+), 6 deletions(-) diff --git a/projects/firefox/config b/projects/firefox/config index 35dac3a..8547aca 100644 --- a/projects/firefox/config +++ b/projects/firefox/config @@ -1,7 +1,7 @@ # vim: filetype=yaml sw=2 version: '[% c("abbrev") %]' filename: 'firefox-[% c("version") %]-[% c("var/osname") %]-[% c("var/build_id") %]' -git_hash: 'tor-browser-[% c("var/firefox_version") %]-[% c("var/torbrowser_branch") %]-1-build1' +git_hash: 'tor-browser-[% c("var/firefox_version") %]-[% c("var/torbrowser_branch") %]-1-build2' tag_gpg_id: 1 git_url: https://git.torproject.org/tor-browser.git git_submodule: 1 diff --git a/projects/https-everywhere/config b/projects/https-everywhere/config index 60776cb..2db9177 100644 --- a/projects/https-everywhere/config +++ b/projects/https-everywhere/config @@ -1,5 +1,5 @@ # vim: filetype=yaml sw=2 -version: 2019.5.6.1 +version: 2019.5.13 git_url: https://git.torproject.org/https-everywhere.git git_hash: '[% c("version") %]' git_submodule: 1 diff --git a/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt b/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt index 83e2a2d..e881c48 100644 --- a/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt +++ b/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt @@ -1,3 +1,21 @@ +Tor Browser 8.5.1 -- June 4 2019 + * All platforms + * Update Torbutton to 2.1.10 + * Bug 30565: Sync nocertdb with privatebrowsing.autostart at startup + * Bug 30464: Add WebGL to safer descriptions + * Translations update + * Update NoScript to 10.6.2 + * Bug 29969: Remove workaround for Mozilla's bug 1532530 + * Update HTTPS Everywhere to 2019.5.13 + * Bug 30541: Disable WebGL readPixel() for web content + * Windows + OS X + Linux + * Bug 30560: Better match actual toolbar in onboarding toolbar graphic + * Android + * Bug 30635: Sync mobile default bridges list with desktop one + * Build System + * All platforms + * Bug 30480: Check that signed tag contains expected tag name + Tor Browser 8.5 -- May 21 2019 * All platforms * Update Firefox to 60.7.0esr diff --git a/projects/torbutton/config b/projects/torbutton/config index 971f0e6..43705ae 100644 --- a/projects/torbutton/config +++ b/projects/torbutton/config @@ -1,5 +1,5 @@ # vim: filetype=yaml sw=2 -version: 2.1.8 +version: 2.1.10 git_url: https://git.torproject.org/torbutton.git git_hash: '[% c("version") %]' gpg_keyring: torbutton.gpg diff --git a/rbm.conf b/rbm.conf index 54f6c65..ee9e322 100644 --- a/rbm.conf +++ b/rbm.conf @@ -24,10 +24,10 @@ buildconf: git_signtag_opt: '-s' var: - torbrowser_version: '8.5' - torbrowser_build: 'build3' + torbrowser_version: '8.5.1' + torbrowser_build: 'build1' torbrowser_incremental_from: - - 8.0.9 + - 8.5 project_name: tor-browser multi_lingual: 0 build_mar: 1

1 0

[tor-browser/tor-browser-60.7.0esr-9.0-1] fixup! Bug 29768: Introduce new features to users
by gk＠torproject.org 31 May '19

31 May '19

commit 79286b37dd0d3711a5ef029e15286cf37339cba6 Author: Georg Koppen <gk(a)torproject.org> Date: Fri May 31 10:47:49 2019 +0000 fixup! Bug 29768: Introduce new features to users Fixes bug 30560 --- .../content/img/figure_tor-security-level.png | Bin 10888 -> 11263 bytes .../content/img/figure_tor-toolbar-layout.png | Bin 5837 -> 10569 bytes 2 files changed, 0 insertions(+), 0 deletions(-) diff --git a/browser/extensions/onboarding/content/img/figure_tor-security-level.png b/browser/extensions/onboarding/content/img/figure_tor-security-level.png index 4f940ea008ef..9a5c221c8d8e 100644 Binary files a/browser/extensions/onboarding/content/img/figure_tor-security-level.png and b/browser/extensions/onboarding/content/img/figure_tor-security-level.png differ diff --git a/browser/extensions/onboarding/content/img/figure_tor-toolbar-layout.png b/browser/extensions/onboarding/content/img/figure_tor-toolbar-layout.png index 0a8161087827..624ef6514d39 100644 Binary files a/browser/extensions/onboarding/content/img/figure_tor-toolbar-layout.png and b/browser/extensions/onboarding/content/img/figure_tor-toolbar-layout.png differ

1 0