tor-commits April 2019

tor-commits@lists.torproject.org

18 participants
3314 discussions

[goptlib/master] ChangeLog for Log.
by dcf＠torproject.org 11 Apr '19

11 Apr '19

commit 781a46c66d2ddbc3509354ae7f1fccab74cb9927 Author: David Fifield <david(a)bamsoftware.com> Date: Thu Apr 11 12:29:08 2019 -0600 ChangeLog for Log. --- ChangeLog | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/ChangeLog b/ChangeLog index 38d63eb..2aae857 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +== v1.1.0 + +Added the Log function. +https://bugs.torproject.org/28940 + == v1.0.0 Changed the tag naming scheme to work better with Go modules.

1 0

[tor/master] Fix SC2006 in minimize.sh
by nickm＠torproject.org 11 Apr '19

11 Apr '19

commit 0e0a0b9802e7e7bf192df9c93f257913e926033a Author: rl1987 <rl1987(a)sdf.lonestar.org> Date: Mon Apr 8 11:16:45 2019 +0300 Fix SC2006 in minimize.sh --- changes/ticket30079 | 3 +++ src/test/fuzz/minimize.sh | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/changes/ticket30079 b/changes/ticket30079 new file mode 100644 index 000000000..56b88e7f5 --- /dev/null +++ b/changes/ticket30079 @@ -0,0 +1,3 @@ + o Code simplification and refactoring (shell scripts): + - Fix shellcheck warning SC2006 in src/test/fuzz/minimize.sh. Resolves + issue 30079. diff --git a/src/test/fuzz/minimize.sh b/src/test/fuzz/minimize.sh index 87d3dda13..ce43812bb 100755 --- a/src/test/fuzz/minimize.sh +++ b/src/test/fuzz/minimize.sh @@ -7,7 +7,7 @@ if [ ! -d "$1" ] ; then exit 1 fi -which=`basename "$1"` +which=$(basename "$1") mkdir "$1.out" afl-cmin -i "$1" -o "$1.out" -m none "./src/test/fuzz/fuzz-${which}"

1 0

[tor/master] Merge remote-tracking branch 'tor-github/pr/913'
by nickm＠torproject.org 11 Apr '19

11 Apr '19

commit 9fabf104ed8163e6647a31d3f54aaf4eba5dacb0 Merge: d54944012 0e0a0b980 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Apr 11 14:30:05 2019 -0400 Merge remote-tracking branch 'tor-github/pr/913' changes/ticket30079 | 3 +++ src/test/fuzz/minimize.sh | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-)

1 0

[tor/master] Fix SC2006 warnings
by nickm＠torproject.org 11 Apr '19

11 Apr '19

commit 700310df613e379dc1930917f0f8a25f0c894a52 Author: rl1987 <rl1987(a)sdf.lonestar.org> Date: Wed Apr 3 17:56:52 2019 +0300 Fix SC2006 warnings --- src/test/test_key_expiration.sh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/test/test_key_expiration.sh b/src/test/test_key_expiration.sh index 5e89bbbd6..6e4991994 100755 --- a/src/test/test_key_expiration.sh +++ b/src/test/test_key_expiration.sh @@ -13,7 +13,7 @@ if [ $# -eq 0 ] || [ ! -f "${1}" ] || [ ! -x "${1}" ]; then fi fi -UNAME_OS=`uname -s | cut -d_ -f1` +UNAME_OS=$(uname -s | cut -d_ -f1) if test "$UNAME_OS" = 'CYGWIN' || \ test "$UNAME_OS" = 'MSYS' || \ test "$UNAME_OS" = 'MINGW'; then @@ -48,10 +48,10 @@ die() { echo "$1" >&2 ; exit 5; } check_dir() { [ -d "$1" ] || die "$1 did not exist"; } check_file() { [ -e "$1" ] || die "$1 did not exist"; } check_no_file() { [ -e "$1" ] && die "$1 was not supposed to exist" || true; } -check_files_eq() { cmp "$1" "$2" || die "$1 and $2 did not match: `dump "$1"` vs `dump "$2"`"; } +check_files_eq() { cmp "$1" "$2" || die "$1 and $2 did not match: $(dump "$1") vs $(dump "$2")"; } check_keys_eq() { check_files_eq "${SRC}/keys/${1}" "${ME}/keys/${1}"; } -DATA_DIR=`mktemp -d -t tor_key_expiration_tests.XXXXXX` +DATA_DIR=$(mktemp -d -t tor_key_expiration_tests.XXXXXX) if [ -z "$DATA_DIR" ]; then echo "Failure: mktemp invocation returned empty string" >&2 exit 3 @@ -63,7 +63,7 @@ fi trap "rm -rf '$DATA_DIR'" 0 # Use an absolute path for this or Tor will complain -DATA_DIR=`cd "${DATA_DIR}" && pwd` +DATA_DIR=$(cd "${DATA_DIR}" && pwd) touch "${DATA_DIR}/empty_torrc"

1 0

[tor/master] Fix SC2064 warning
by nickm＠torproject.org 11 Apr '19

11 Apr '19

commit 9e04a8722081cd761ee3a2e173b53c7859a8c916 Author: rl1987 <rl1987(a)sdf.lonestar.org> Date: Wed Apr 3 17:58:05 2019 +0300 Fix SC2064 warning --- src/test/test_key_expiration.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/test_key_expiration.sh b/src/test/test_key_expiration.sh index 6e4991994..8614a4fa4 100755 --- a/src/test/test_key_expiration.sh +++ b/src/test/test_key_expiration.sh @@ -60,7 +60,7 @@ if [ ! -d "$DATA_DIR" ]; then echo "Failure: mktemp invocation result doesn't point to directory" >&2 exit 3 fi -trap "rm -rf '$DATA_DIR'" 0 +trap 'rm -rf "$DATA_DIR"' 0 # Use an absolute path for this or Tor will complain DATA_DIR=$(cd "${DATA_DIR}" && pwd)

1 0

[tor/master] Fix SC2086 warnings in test_key_expiration.sh
by nickm＠torproject.org 11 Apr '19

11 Apr '19

commit 9e0f0a565632327263c1c3466978f8bc5e759194 Author: rl1987 <rl1987(a)sdf.lonestar.org> Date: Wed Apr 3 17:52:31 2019 +0300 Fix SC2086 warnings in test_key_expiration.sh --- src/test/test_key_expiration.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/test/test_key_expiration.sh b/src/test/test_key_expiration.sh index cf6608634..5e89bbbd6 100755 --- a/src/test/test_key_expiration.sh +++ b/src/test/test_key_expiration.sh @@ -6,7 +6,7 @@ umask 077 set -e -if [ $# -eq 0 ] || [ ! -f ${1} ] || [ ! -x ${1} ]; then +if [ $# -eq 0 ] || [ ! -f "${1}" ] || [ ! -x "${1}" ]; then if [ "$TESTING_TOR_BINARY" = "" ] ; then echo "Usage: ${0} PATH_TO_TOR [case-number]" exit 1 @@ -48,7 +48,7 @@ die() { echo "$1" >&2 ; exit 5; } check_dir() { [ -d "$1" ] || die "$1 did not exist"; } check_file() { [ -e "$1" ] || die "$1 did not exist"; } check_no_file() { [ -e "$1" ] && die "$1 was not supposed to exist" || true; } -check_files_eq() { cmp "$1" "$2" || die "$1 and $2 did not match: `dump $1` vs `dump $2`"; } +check_files_eq() { cmp "$1" "$2" || die "$1 and $2 did not match: `dump "$1"` vs `dump "$2"`"; } check_keys_eq() { check_files_eq "${SRC}/keys/${1}" "${ME}/keys/${1}"; } DATA_DIR=`mktemp -d -t tor_key_expiration_tests.XXXXXX`

1 0

[tor/master] Add changes file
by nickm＠torproject.org 11 Apr '19

11 Apr '19

commit b2eced6c0747159ab7b3942a45c1a147a5ecfc96 Author: rl1987 <rl1987(a)sdf.lonestar.org> Date: Wed Apr 3 18:05:23 2019 +0300 Add changes file --- changes/bug30002 | 2 ++ 1 file changed, 2 insertions(+) diff --git a/changes/bug30002 b/changes/bug30002 new file mode 100644 index 000000000..da61c9e4b --- /dev/null +++ b/changes/bug30002 @@ -0,0 +1,2 @@ + o Code simplification and refactoring (shell scripts): + - Fix shellcheck warnings in test_key_expiration.sh. Resolves issue 30002.

1 0

[tor/master] Fix SC2015 warning
by nickm＠torproject.org 11 Apr '19

11 Apr '19

commit 4172b638b8221e2d56c20e2a408948977c68358a Author: rl1987 <rl1987(a)sdf.lonestar.org> Date: Wed Apr 3 18:03:34 2019 +0300 Fix SC2015 warning --- src/test/test_key_expiration.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/test_key_expiration.sh b/src/test/test_key_expiration.sh index 8614a4fa4..1ed81c81c 100755 --- a/src/test/test_key_expiration.sh +++ b/src/test/test_key_expiration.sh @@ -47,7 +47,7 @@ dump() { xxd -p "$1" | tr -d '\n '; } die() { echo "$1" >&2 ; exit 5; } check_dir() { [ -d "$1" ] || die "$1 did not exist"; } check_file() { [ -e "$1" ] || die "$1 did not exist"; } -check_no_file() { [ -e "$1" ] && die "$1 was not supposed to exist" || true; } +check_no_file() { if [ -e "$1" ]; then die "$1 was not supposed to exist"; fi } check_files_eq() { cmp "$1" "$2" || die "$1 and $2 did not match: $(dump "$1") vs $(dump "$2")"; } check_keys_eq() { check_files_eq "${SRC}/keys/${1}" "${ME}/keys/${1}"; }

1 0

[tor/master] Merge remote-tracking branch 'tor-github/pr/887'
by nickm＠torproject.org 11 Apr '19

11 Apr '19

commit d549440124be04986cc7a2b8cb98bd878fca5532 Merge: f8dc935fb b2eced6c0 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Apr 11 14:29:16 2019 -0400 Merge remote-tracking branch 'tor-github/pr/887' changes/bug30002 | 2 ++ src/test/test_key_expiration.sh | 14 +++++++------- 2 files changed, 9 insertions(+), 7 deletions(-)

1 0

[tor/master] Merge remote-tracking branch 'tor-github/pr/741'
by nickm＠torproject.org 11 Apr '19

11 Apr '19

commit f8dc935fb7f2d5fb2a5ec4224c7d99f0f177608e Merge: 3c64cfe64 9b7cdd23d Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Apr 11 14:27:06 2019 -0400 Merge remote-tracking branch 'tor-github/pr/741' doc/tor.1.txt | 13 +++++++------ src/config/torrc.sample.in | 21 ++++++++++++++++----- 2 files changed, 23 insertions(+), 11 deletions(-)

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

tor-commits April 2019