January 2019 - tor-commits - lists.torproject.org

[tor/master] Fix documentation for ClientAuth on HSv3.
by nickm＠torproject.org 22 Jan '19

22 Jan '19

commit 7c6a8c674bd563bf4b33e05a7267a5ec74b79170 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Jan 16 16:05:54 2019 -0500 Fix documentation for ClientAuth on HSv3. The manpage erroneously said "privkey" when "public-key" would have been correct. Reported by "Felixix" as ticket 28979. Bugfix on 0.3.5.1-alpha. --- changes/bug28979 | 4 ++++ doc/tor.1.txt | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/changes/bug28979 b/changes/bug28979 new file mode 100644 index 000000000..0625fd5d2 --- /dev/null +++ b/changes/bug28979 @@ -0,0 +1,4 @@ + o Minor bugfixes (documentation): + - Describe the contents of the v3 onion service client authorization + files correctly: They hold public keys, not private keys. Fixes bug + 28979; bugfix on 0.3.5.1-alpha. Spotted by "Felixix". diff --git a/doc/tor.1.txt b/doc/tor.1.txt index 581783dd6..573fdf221 100644 --- a/doc/tor.1.txt +++ b/doc/tor.1.txt @@ -2950,8 +2950,8 @@ file name is irrelevant) and its content format MUST be: <auth-type>:<key-type>:<base32-encoded-public-key> The supported <auth-type> are: "descriptor". The supported <key-type> are: -"x25519". The <base32-encoded-privkey> is the base32 representation of the raw -key bytes only (32 bytes for x25519). +"x25519". The <base32-encoded-public-key> is the base32 representation of +the raw key bytes only (32 bytes for x25519). Each file MUST contain one line only. Any malformed file will be ignored. Client authorization will only be enabled for the service if tor

1 0

[tor/master] Merge branch 'maint-0.3.5'
by nickm＠torproject.org 22 Jan '19

22 Jan '19

commit 0ce4d23af5cd6ca3a5fe7f8b931b07f171b7f4ed Merge: d1af4d65d 9ce1978b5 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Jan 22 08:04:55 2019 -0500 Merge branch 'maint-0.3.5' changes/bug28979 | 4 ++++ doc/tor.1.txt | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-)

1 0

[tor/master] Merge branch 'bug28979_035' into maint-0.3.5
by nickm＠torproject.org 22 Jan '19

22 Jan '19

commit 9ce1978b5ea630bca699eb1cf7f3f1c178f8e939 Merge: a8580a683 7c6a8c674 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Jan 22 08:04:52 2019 -0500 Merge branch 'bug28979_035' into maint-0.3.5 changes/bug28979 | 4 ++++ doc/tor.1.txt | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-)

1 0

[tor/maint-0.3.5] Fix documentation for ClientAuth on HSv3.
by nickm＠torproject.org 22 Jan '19

22 Jan '19

commit 7c6a8c674bd563bf4b33e05a7267a5ec74b79170 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Jan 16 16:05:54 2019 -0500 Fix documentation for ClientAuth on HSv3. The manpage erroneously said "privkey" when "public-key" would have been correct. Reported by "Felixix" as ticket 28979. Bugfix on 0.3.5.1-alpha. --- changes/bug28979 | 4 ++++ doc/tor.1.txt | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/changes/bug28979 b/changes/bug28979 new file mode 100644 index 000000000..0625fd5d2 --- /dev/null +++ b/changes/bug28979 @@ -0,0 +1,4 @@ + o Minor bugfixes (documentation): + - Describe the contents of the v3 onion service client authorization + files correctly: They hold public keys, not private keys. Fixes bug + 28979; bugfix on 0.3.5.1-alpha. Spotted by "Felixix". diff --git a/doc/tor.1.txt b/doc/tor.1.txt index 581783dd6..573fdf221 100644 --- a/doc/tor.1.txt +++ b/doc/tor.1.txt @@ -2950,8 +2950,8 @@ file name is irrelevant) and its content format MUST be: <auth-type>:<key-type>:<base32-encoded-public-key> The supported <auth-type> are: "descriptor". The supported <key-type> are: -"x25519". The <base32-encoded-privkey> is the base32 representation of the raw -key bytes only (32 bytes for x25519). +"x25519". The <base32-encoded-public-key> is the base32 representation of +the raw key bytes only (32 bytes for x25519). Each file MUST contain one line only. Any malformed file will be ignored. Client authorization will only be enabled for the service if tor

1 0

[tor/release-0.3.5] Merge branch 'bug28979_035' into maint-0.3.5
by nickm＠torproject.org 22 Jan '19

22 Jan '19

commit 9ce1978b5ea630bca699eb1cf7f3f1c178f8e939 Merge: a8580a683 7c6a8c674 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Jan 22 08:04:52 2019 -0500 Merge branch 'bug28979_035' into maint-0.3.5 changes/bug28979 | 4 ++++ doc/tor.1.txt | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-)

1 0

[tor/release-0.3.5] Fix documentation for ClientAuth on HSv3.
by nickm＠torproject.org 22 Jan '19

22 Jan '19

commit 7c6a8c674bd563bf4b33e05a7267a5ec74b79170 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Jan 16 16:05:54 2019 -0500 Fix documentation for ClientAuth on HSv3. The manpage erroneously said "privkey" when "public-key" would have been correct. Reported by "Felixix" as ticket 28979. Bugfix on 0.3.5.1-alpha. --- changes/bug28979 | 4 ++++ doc/tor.1.txt | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/changes/bug28979 b/changes/bug28979 new file mode 100644 index 000000000..0625fd5d2 --- /dev/null +++ b/changes/bug28979 @@ -0,0 +1,4 @@ + o Minor bugfixes (documentation): + - Describe the contents of the v3 onion service client authorization + files correctly: They hold public keys, not private keys. Fixes bug + 28979; bugfix on 0.3.5.1-alpha. Spotted by "Felixix". diff --git a/doc/tor.1.txt b/doc/tor.1.txt index 581783dd6..573fdf221 100644 --- a/doc/tor.1.txt +++ b/doc/tor.1.txt @@ -2950,8 +2950,8 @@ file name is irrelevant) and its content format MUST be: <auth-type>:<key-type>:<base32-encoded-public-key> The supported <auth-type> are: "descriptor". The supported <key-type> are: -"x25519". The <base32-encoded-privkey> is the base32 representation of the raw -key bytes only (32 bytes for x25519). +"x25519". The <base32-encoded-public-key> is the base32 representation of +the raw key bytes only (32 bytes for x25519). Each file MUST contain one line only. Any malformed file will be ignored. Client authorization will only be enabled for the service if tor

1 0

[tor/release-0.3.5] Merge branch 'maint-0.3.5' into release-0.3.5
by nickm＠torproject.org 22 Jan '19

22 Jan '19

commit 5dc6d2318c9aed60bfd17d856216323ec21eb3da Merge: 448448120 9ce1978b5 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Jan 22 08:04:55 2019 -0500 Merge branch 'maint-0.3.5' into release-0.3.5 changes/bug28979 | 4 ++++ doc/tor.1.txt | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-)

1 0

[translation/support-portal] Update translations for support-portal
by translation＠torproject.org 22 Jan '19

22 Jan '19

commit bc399751d9adb4f6ffa888e87b5dc57602a155dd Author: Translation commit bot <translation(a)torproject.org> Date: Tue Jan 22 10:49:39 2019 +0000 Update translations for support-portal --- contents+ru.po | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/contents+ru.po b/contents+ru.po index f1e4f1645..1a807ac61 100644 --- a/contents+ru.po +++ b/contents+ru.po @@ -1884,12 +1884,12 @@ msgstr "" #: http//localhost/tbb/different-circuit-each-website/ #: (content/tbb/tbb-40/contents+en.lrquestion.title) msgid "Does Tor Browser use a different circuit for each website?" -msgstr "Использует ли Tor Browser различные цепочки для каждого сайта?" +msgstr "Использует ли Tor Browser разные цепочки для каждого сайта?" #: http//localhost/tbb/different-circuit-each-website/ #: (content/tbb/tbb-40/contents+en.lrquestion.description) msgid "In Tor Browser, every new domain gets its own circuit." -msgstr "В Tor Browser каждый новый домен получает свою цепочку." +msgstr "В Tor Browser для каждого нового домена используется своя цепочка." #: http//localhost/tbb/different-circuit-each-website/ #: (content/tbb/tbb-40/contents+en.lrquestion.description) @@ -1899,6 +1899,9 @@ msgid "" "Browser</a> document further explains the thinking behind this " "design." msgstr "" +"Более подробная информация о данной функции представлена в документе " +"<a href=\"https://www.torproject.org/projects/torbrowser/design" +"/#identifier-linkability\">Проект и реализация Tor Browser</a>." #: http//localhost/tbb/different-circuit-each-website/ #: (content/tbb/tbb-40/contents+en.lrquestion.seo_slug) @@ -3328,7 +3331,7 @@ msgstr "Nickname ididnteditheconfig" #: http//localhost/operators/how-do-i-run-a-obfs4-bridge-debian/ #: (content/operators/operators-6/contents+en.lrquestion.description) msgid "## Set your own contact info" -msgstr "" +msgstr "## Укажите свои контактные данные" #: http//localhost/operators/how-do-i-run-a-middle-or-guard-relay/ #: (content/operators/operators-1/contents+en.lrquestion.description) @@ -4031,11 +4034,12 @@ msgid "" "The community team has developed this Glossary of terms about and related to" " Tor" msgstr "" +"Участники сообщества создали данный Глоссарий, посвященный и связанный с Tor" #: http//localhost/misc/tor-glossary/ #: (content/misc/glossary/contents+en.lrquestion.description) msgid "##### term" -msgstr "" +msgstr "##### термин" #: http//localhost/misc/tor-glossary/ #: (content/misc/glossary/contents+en.lrquestion.description) @@ -4045,7 +4049,7 @@ msgstr "определение" #: http//localhost/misc/tor-glossary/ #: (content/misc/glossary/contents+en.lrquestion.description) msgid "term:" -msgstr "" +msgstr "термин:" #: http//localhost/misc/tor-glossary/ #: (content/misc/glossary/contents+en.lrquestion.description)

1 0

[translation/support-portal] Update translations for support-portal
by translation＠torproject.org 22 Jan '19

22 Jan '19

commit 4d6f889e065106f3bcaec563025992fbd9c3b18b Author: Translation commit bot <translation(a)torproject.org> Date: Tue Jan 22 10:19:24 2019 +0000 Update translations for support-portal --- contents+ru.po | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/contents+ru.po b/contents+ru.po index f53ea8c43..f1e4f1645 100644 --- a/contents+ru.po +++ b/contents+ru.po @@ -1,5 +1,5 @@ # Translators: -# 45Green Anonymous <45tanaa(a)gmail.com>, 2018 +# Evgenya (45Green) <45tanaa(a)gmail.com>, 2018 # erinm, 2018 # Emma Peel, 2018 # Evgeny Malyshev <evgeny.malyshev.sss(a)gmail.com>, 2018 @@ -1310,6 +1310,8 @@ msgid "" "This option is useful if you want to prevent your subsequent browser " "activity from being linkable to what you were doing before." msgstr "" +"Данная функция позволяет предотвратить установление взаимосвязей между " +"Вашими последующими и предыдущими действиями в браузере." #: http//localhost/tbb/change-ip-address/ #: (content/tbb/tbb-29/contents+en.lrquestion.description) @@ -1378,6 +1380,9 @@ msgid "" "This option does not clear any private information or unlink your activity, " "nor does it affect your current connections to other websites." msgstr "" +"Данная функция не удаляет никакие личные данные или информацию о Ваших " +"действиях, а также не оказывает влияния на текущие соединения с другими " +"сайтами." #: http//localhost/tbb/change-ip-address/ #: (content/tbb/tbb-29/contents+en.lrquestion.description) @@ -2214,8 +2219,8 @@ msgid "" "We still believe in Tor's ability to be used in a messaging app, but we " "don't have the resources to make it happen right now." msgstr "" -"Мы по-прежнему верим в способность Tor использоваться в мессенджере, но у " -"нас нет ресурсов, чтобы сделать это прямо сейчас." +"Мы по-прежнему верим в возможность использования Tor в мессенджере, но у нас" +" нет ресурсов, чтобы реализовать это прямо сейчас." #: http//localhost/tormessenger/tor-project-app-for-private-chat/ #: (content/tormessenger/tormessenger-1/contents+en.lrquestion.description) @@ -2224,6 +2229,9 @@ msgid "" "href=\"https://www.torproject.org/about/contact.html.en\">Contact " "us</a>." msgstr "" +"Можете помочь? <a " +"href=\"https://www.torproject.org/about/contact.html.en\">Свяжитесь с " +"нами</a>." #: http//localhost/tormessenger/tor-project-app-for-private-chat/ #: (content/tormessenger/tormessenger-1/contents+en.lrquestion.seo_slug)

1 0

[torbutton/maint-2.0] Bug 27175: Add pref to allow users to persist custom noscript settings
by gk＠torproject.org 22 Jan '19

22 Jan '19

commit d0adb5ad47e97e2143bac6595084a33e6355acb8 Author: Arthur Edelstein <arthuredelstein(a)gmail.com> Date: Mon Sep 17 23:03:26 2018 -0700 Bug 27175: Add pref to allow users to persist custom noscript settings The pref is called "extensions.torbutton.noscript_persist". Warning! It is dangerous and could reveal what sites you have visited in the past. (We also use a pref named "extensions.torbutton.noscript_inited" to keep track of the first run.) --- src/defaults/preferences/preferences.js | 3 +++ src/modules/noscript-control.js | 31 +++++++++++++++++++++++-------- 2 files changed, 26 insertions(+), 8 deletions(-) diff --git a/src/defaults/preferences/preferences.js b/src/defaults/preferences/preferences.js index b991a3ae..eb055a65 100644 --- a/src/defaults/preferences/preferences.js +++ b/src/defaults/preferences/preferences.js @@ -48,6 +48,9 @@ pref("extensions.torbutton.prompt_torbrowser", true); pref("extensions.torbutton.confirm_plugins", true); pref("extensions.torbutton.confirm_newnym", true); +pref("extensions.torbutton.noscript_inited", false); +pref("extensions.torbutton.noscript_persist", false); + // Browser home page: pref("browser.startup.homepage", "chrome://torbutton/content/locale/non-localized.properties"); diff --git a/src/modules/noscript-control.js b/src/modules/noscript-control.js index 621f2b7f..275f9dba 100644 --- a/src/modules/noscript-control.js +++ b/src/modules/noscript-control.js @@ -5,9 +5,10 @@ // ## Utilities const { utils: Cu } = Components; +const { Services } = Cu.import("resource://gre/modules/Services.jsm", {}); const { LegacyExtensionContext } = Cu.import("resource://gre/modules/LegacyExtensionsUtils.jsm", {}); -const { bindPrefAndInit } = +const { bindPref } = Cu.import("resource://torbutton/modules/utils.js", {}); let logger = Components.classes["@torproject.org/torbutton-logger;1"] .getService(Components.interfaces.nsISupports).wrappedJSObject; @@ -128,14 +129,28 @@ var initialize = () => { // Wait for the first message from NoScript to arrive, and then // bind the security_slider pref to the NoScript settings. let messageListener = (a,b,c) => { - log(3, `Message received from NoScript: ${JSON.stringify([a,b,c])}`); - if (!["started", "pageshow"].includes(a.__meta.name)) { - return; + try { + log(3, `Message received from NoScript: ${JSON.stringify([a,b,c])}`); + if (!["started", "pageshow"].includes(a.__meta.name)) { + return; + } + extensionContext.api.browser.runtime.onMessage.removeListener(messageListener); + let noscriptPersist = Services.prefs.getBoolPref("extensions.torbutton.noscript_persist", false); + let noscriptInited = Services.prefs.getBoolPref("extensions.torbutton.noscript_inited", false); + // Set the noscript safety level once if we have never run noscript + // before, or if we are not allowing noscript per-site settings to be + // persisted between browser sessions. Otherwise make sure that the + // security slider position, if changed, will rewrite the noscript + // settings. + bindPref("extensions.torbutton.security_slider", + sliderState => setNoScriptSafetyLevel(securitySliderToSafetyLevel(sliderState)), + !noscriptPersist || !noscriptInited); + if (!noscriptInited) { + Services.prefs.setBoolPref("extensions.torbutton.noscript_inited", true); + } + } catch (e) { + log(5, e.message); } - extensionContext.api.browser.runtime.onMessage.removeListener(messageListener); - bindPrefAndInit( - "extensions.torbutton.security_slider", - sliderState => setNoScriptSafetyLevel(securitySliderToSafetyLevel(sliderState))); }; extensionContext.api.browser.runtime.onMessage.addListener(messageListener); log(3, "Listening for message from NoScript.");

1 0